]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
SMB3: Warn user if trying to sign connection that authenticated as guest
authorSteve French <smfrench@gmail.com>
Tue, 19 Sep 2017 23:40:03 +0000 (18:40 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Oct 2017 07:44:01 +0000 (09:44 +0200)
commit c721c38957fb19982416f6be71aae7b30630d83b upstream.

It can be confusing if user ends up authenticated as guest but they
requested signing (server will return error validating signed packets)
so add log message for this.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2pdu.c

index 9d8ad4b285fac0d7b5f66d43416738c2b77e33c5..b98d96a41518a3ac6255f6a3c44594d9fb7daf28 100644 (file)
@@ -1010,6 +1010,8 @@ SMB2_sess_setup(const unsigned int xid, struct cifs_ses *ses,
        while (sess_data->func)
                sess_data->func(sess_data);
 
+       if ((ses->session_flags & SMB2_SESSION_FLAG_IS_GUEST) && (ses->sign))
+               cifs_dbg(VFS, "signing requested but authenticated as guest\n");
        rc = sess_data->result;
 out:
        kfree(sess_data);