]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
nfp: flower: add missing clean up call to avoid memory leaks
authorJakub Kicinski <jakub.kicinski@netronome.com>
Fri, 7 Jul 2017 00:29:05 +0000 (17:29 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Jul 2017 08:17:42 +0000 (09:17 +0100)
nfp_flower_metadata_cleanup() is defined but never invoked,
not calling it will cause us to leak mask and statistics
queue memory on the host.

Fixes: 43f84b72c50d ("nfp: add metadata to each flow offload")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/main.c

index fc10f27e0a0cad2f9675f0aedcb662ab6e687630..6a65c8b33807ccb6b7f9394c6f60e0222e2ae396 100644 (file)
@@ -356,6 +356,7 @@ err_free_app_priv:
 
 static void nfp_flower_clean(struct nfp_app *app)
 {
+       nfp_flower_metadata_cleanup(app);
        vfree(app->priv);
        app->priv = NULL;
 }