]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
xhci: Fix incorrect EP_STATE_MASK
authorMathias Nyman <mathias.nyman@linux.intel.com>
Wed, 24 Jun 2020 13:59:45 +0000 (16:59 +0300)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:01 +0000 (15:38 -0400)
commit dceea67058fe22075db3aed62d5cb62092be5053 upstream.

EP_STATE_MASK should be 0x7 instead of 0xf

xhci spec 6.2.3 shows that the EP state field in the endpoint context data
structure consist of bits [2:0].
The old value included a bit from the next field which fortunately is a
 RsvdZ region. So hopefully this hasn't caused too much harm

Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20200624135949.22611-2-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci.h

index db1af99d53bdb967f2b8ef8a0389942f11addaf6..8b52a7773bc84fa19e1a5705ee8c3cd2a32f5c0a 100644 (file)
@@ -718,7 +718,7 @@ struct xhci_ep_ctx {
  * 4 - TRB error
  * 5-7 - reserved
  */
-#define EP_STATE_MASK          (0xf)
+#define EP_STATE_MASK          (0x7)
 #define EP_STATE_DISABLED      0
 #define EP_STATE_RUNNING       1
 #define EP_STATE_HALTED                2