make ppa: force lower version number

[people/ms/dma.git] / dma.c

diff --git a/dma.c b/dma.c
index 1ddd980946d8ebcdb83d8f2314e3e6440e8595f2..5a287fa9da860c63dc503d1c9870ea889e85b81c 100644 (file)
--- a/dma.c
+++ b/dma.c
@@ -63,44 +63,37 @@ static void deliver(struct qitem *);
 
 struct aliases aliases = LIST_HEAD_INITIALIZER(aliases);
 struct strlist tmpfs = SLIST_HEAD_INITIALIZER(tmpfs);
-struct virtusers virtusers = LIST_HEAD_INITIALIZER(virtusers);
 struct authusers authusers = LIST_HEAD_INITIALIZER(authusers);
-const char *username;
+char username[USERNAME_SIZE];
+uid_t useruid;
 const char *logident_base;
+char errmsg[ERRMSG_SIZE];
 
 static int daemonize = 1;
 
 struct config config = {
        .smarthost      = NULL,
        .port           = 25,
-       .aliases        = "/var/mail/aliases",
+       .aliases        = "/etc/aliases",
        .spooldir       = "/var/spool/dma",
-       .virtualpath    = NULL,
        .authpath       = NULL,
        .certfile       = NULL,
        .features       = 0,
        .mailname       = NULL,
-       .mailnamefile   = NULL,
 };
 
 
+static void
+sighup_handler(int signo)
+{
+       (void)signo;    /* so that gcc doesn't complain */
+}
+
 static char *
 set_from(struct queue *queue, const char *osender)
 {
-       struct virtuser *v;
        char *sender;
 
-       if ((config.features & VIRTUAL) != 0) {
-               SLIST_FOREACH(v, &virtusers, next) {
-                       if (strcmp(v->login, username) == 0) {
-                               sender = strdup(v->address);
-                               if (sender == NULL)
-                                       return(NULL);
-                               goto out;
-                       }
-               }
-       }
-
        if (osender) {
                sender = strdup(osender);
                if (sender == NULL)
@@ -119,7 +112,6 @@ set_from(struct queue *queue, const char *osender)
                return (NULL);
        }
 
-out:
        queue->sender = sender;
        return (sender);
 }
@@ -225,7 +217,6 @@ go_background(struct queue *queue)
        daemonize = 0;
 
        bzero(&sa, sizeof(sa));
-       sa.sa_flags = SA_NOCLDWAIT;
        sa.sa_handler = SIG_IGN;
        sigaction(SIGCHLD, &sa, NULL);
 
@@ -278,17 +269,18 @@ deliver(struct qitem *it)
 {
        int error;
        unsigned int backoff = MIN_RETRY;
-       const char *errmsg = "unknown bounce reason";
        struct timeval now;
        struct stat st;
 
+       snprintf(errmsg, sizeof(errmsg), "unknown bounce reason");
+
 retry:
        syslog(LOG_INFO, "trying delivery");
 
        if (it->remote)
-               error = deliver_remote(it, &errmsg);
+               error = deliver_remote(it);
        else
-               error = deliver_local(it, &errmsg);
+               error = deliver_local(it);
 
        switch (error) {
        case 0:
@@ -303,15 +295,17 @@ retry:
                }
                if (gettimeofday(&now, NULL) == 0 &&
                    (now.tv_sec - st.st_mtim.tv_sec > MAX_TIMEOUT)) {
-                       asprintf(__DECONST(void *, &errmsg),
+                       snprintf(errmsg, sizeof(errmsg),
                                 "Could not deliver for the last %d seconds. Giving up.",
                                 MAX_TIMEOUT);
                        goto bounce;
                }
-               sleep(backoff);
-               backoff *= 2;
-               if (backoff > MAX_RETRY)
-                       backoff = MAX_RETRY;
+               if (sleep(backoff) == 0) {
+                       /* pick the next backoff between [1.5, 2.5) times backoff */
+                       backoff = backoff + backoff / 2 + random() % backoff;
+                       if (backoff > MAX_RETRY)
+                               backoff = MAX_RETRY;
+               }
                goto retry;
 
        case -1:
@@ -372,13 +366,35 @@ show_queue(struct queue *queue)
 int
 main(int argc, char **argv)
 {
+       struct sigaction act;
        char *sender = NULL;
        struct queue queue;
        int i, ch;
        int nodot = 0, doqueue = 0, showq = 0, queue_only = 0;
        int recp_from_header = 0;
 
+       set_username();
+
+       /*
+        * We never run as root.  If called by root, drop permissions
+        * to the mail user.
+        */
+       if (geteuid() == 0 || getuid() == 0) {
+               struct passwd *pw;
+
+               pw = getpwnam(DMA_ROOT_USER);
+               if (pw == NULL)
+                       err(1, "cannot drop root privileges");
+
+               if (setuid(pw->pw_uid) != 0)
+                       err(1, "cannot drop root privileges");
+
+               if (geteuid() == 0 || getuid() == 0)
+                       errx(1, "cannot drop root privileges");
+       }
+
        atexit(deltmp);
+       init_random();
 
        bzero(&queue, sizeof(queue));
        LIST_INIT(&queue.queue);
@@ -481,18 +497,15 @@ skipopts:
        if (logident_base == NULL)
                logident_base = "dma";
        setlogident(NULL);
-       set_username();
 
-       /* XXX fork root here */
+       act.sa_handler = sighup_handler;
+       act.sa_flags = 0;
+       sigemptyset(&act.sa_mask);
+       if (sigaction(SIGHUP, &act, NULL) != 0)
+               syslog(LOG_WARNING, "can not set signal handler: %m");
 
        parse_conf(CONF_PATH);
 
-       if (config.features & VIRTUAL) {
-               if (config.virtualpath == NULL)
-                       errlogx(1, "no virtuser file specified, but VIRTUAL configured");
-               parse_virtuser(config.virtualpath);
-       }
-
        if (config.authpath != NULL)
                parse_authfile(config.authpath);