]> git.ipfire.org Git - people/ms/linux.git/commit
nvme: don't intialize hwmon for discovery controllers
authorSagi Grimberg <sagi@grimberg.me>
Thu, 14 Jan 2021 00:00:22 +0000 (16:00 -0800)
committerChristoph Hellwig <hch@lst.de>
Thu, 14 Jan 2021 19:27:35 +0000 (20:27 +0100)
commit5ab25a32cd90ce561ac28b9302766e565d61304c
tree306fac1d121d393b71f55d57a3162249b568953c
parentca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9
nvme: don't intialize hwmon for discovery controllers

Discovery controllers usually don't support smart log page command.
So when we connect to the discovery controller we see this warning:
nvme nvme0: Failed to read smart log (error 24577)
nvme nvme0: new ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery", addr 192.168.123.1:8009
nvme nvme0: Removing ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery"

Introduce a new helper to understand if the controller is a discovery
controller and use this helper to skip nvme_init_hwmon (also use it in
other places that we check if the controller is a discovery controller).

Fixes: 400b6a7b13a3 ("nvme: Add hardware monitoring support")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c