]> git.ipfire.org Git - people/ms/linux.git/commit
mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles
authorJisheng Zhang <jszhang@marvell.com>
Wed, 28 Jan 2015 11:54:12 +0000 (19:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 22:52:52 +0000 (14:52 -0800)
commitdd553502d83c37f57c2f7fcfa1d5f3d32a044ef0
tree8a106841e7d4c9df4f77a9c5c076821017fd001b
parent4d025d8000898c8e14bbf9a793063aadae31045b
mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles

commit 14460dbaf7a5a0488963fdb8232ad5c8a8cca7b7 upstream.

Current code checks "clk_delay_cycles > 0" to know whether the optional
"mrvl,clk_delay_cycles" is set or not. But of_property_read_u32() doesn't
touch clk_delay_cycles if the property is not set. And type of
clk_delay_cycles is u32, so we may always set pdata->clk_delay_cycles as a
random value.

This patch fix this problem by check the return value of of_property_read_u32()
to know whether the optional clk-delay-cycles is set or not.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/sdhci-pxav3.c