]> git.ipfire.org Git - people/ms/linux.git/commitdiff
tcp: ipv4: initialize unicast_sock sk_pacing_rate
authorEric Dumazet <edumazet@google.com>
Wed, 28 Jan 2015 13:47:11 +0000 (05:47 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Feb 2015 01:48:48 +0000 (17:48 -0800)
[ Upstream commit 811230cd853d62f09ed0addd0ce9a1b9b0e13fb5 ]

When I added sk_pacing_rate field, I forgot to initialize its value
in the per cpu unicast_sock used in ip_send_unicast_reply()

This means that for sch_fq users, RST packets, or ACK packets sent
on behalf of TIME_WAIT sockets might be sent to slowly or even dropped
once we reach the per flow limit.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 95bd09eb2750 ("tcp: TSO packets automatic sizing")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_output.c

index 22fa05e041ea83134be57d566a60b01454769a20..ee104cbcefd2902b4b12c657145fbb7e5f4c2bee 100644 (file)
@@ -1465,6 +1465,7 @@ static DEFINE_PER_CPU(struct inet_sock, unicast_sock) = {
                .sk_wmem_alloc  = ATOMIC_INIT(1),
                .sk_allocation  = GFP_ATOMIC,
                .sk_flags       = (1UL << SOCK_USE_WRITE_QUEUE),
+               .sk_pacing_rate = ~0U,
        },
        .pmtudisc       = IP_PMTUDISC_WANT,
        .uc_ttl         = -1,