]> git.ipfire.org Git - people/ms/linux.git/commitdiff
fix the regression from "direct-io: Fix negative return from dio read beyond eof"
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 8 Dec 2015 17:22:47 +0000 (12:22 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 8 Dec 2015 20:02:42 +0000 (15:02 -0500)
Sure, it's better to bail out of past-the-eof read and return 0 than return
a bogus negative value on such.  Only we'd better make sure we are bailing out
with 0 and not -ENOMEM...

Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/direct-io.c

index 1c75a3a07f8f02a2ddd3b85e02c74866ff5b1f08..602e8441bc0fb6b094ec96dfb3273ff73b8b1506 100644 (file)
@@ -1175,6 +1175,7 @@ do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
                if (dio->flags & DIO_LOCKING)
                        mutex_unlock(&inode->i_mutex);
                kmem_cache_free(dio_cache, dio);
+               retval = 0;
                goto out;
        }