]> git.ipfire.org Git - people/ms/linux.git/commitdiff
em28xx: ensure "closing" messages terminate with a newline
authorRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 20 Dec 2014 12:45:20 +0000 (09:45 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 22:43:26 +0000 (14:43 -0800)
commit 0418ca6073478f54f1da2e4013fa50d36838de75 upstream.

The lockdep splat addressed in a previous commit revealed that at
least one message in em28xx-input.c was missing a new line:

em28178 #0: Closing input extensionINFO: trying to register non-static key.

Further inspection shows several other messages also miss a new line.
These will be fixed in a subsequent patch.

Fixes: aa929ad783c0 ("[media] em28xx: print a message at disconnect")
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Reviewed-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/em28xx/em28xx-audio.c
drivers/media/usb/em28xx/em28xx-dvb.c
drivers/media/usb/em28xx/em28xx-input.c
drivers/media/usb/em28xx/em28xx-video.c

index dfdfa772eb1ee77641cc33313dd247131f4dde99..74a9a896cedfe6dd1a2e2d6e2145bca622792a05 100644 (file)
@@ -974,7 +974,7 @@ static int em28xx_audio_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing audio extension");
+       em28xx_info("Closing audio extension\n");
 
        if (dev->adev.sndcard) {
                snd_card_disconnect(dev->adev.sndcard);
index 1373cfa4e974f1569dd1698f52870384010be1e4..ec2ebe9b89fb2b134be27c115b08b5da14e3fcf2 100644 (file)
@@ -1468,7 +1468,7 @@ static int em28xx_dvb_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing DVB extension");
+       em28xx_info("Closing DVB extension\n");
 
        if (dev->dvb) {
                struct em28xx_dvb *dvb = dev->dvb;
index 18f65d89d4bc783a5005fc7b3aaa2b196c1c9904..dd59c005cbcc983fb66d9838bcf84920382b067a 100644 (file)
@@ -810,7 +810,7 @@ static int em28xx_ir_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing input extension");
+       em28xx_info("Closing input extension\n");
 
        em28xx_shutdown_buttons(dev);
 
index e24ee08e634ed4b554771721a63a4b992dc4dfeb..0e8d0856b89ab750028528a01fc0d3ea2d3032ce 100644 (file)
@@ -1900,7 +1900,7 @@ static int em28xx_v4l2_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing video extension");
+       em28xx_info("Closing video extension\n");
 
        mutex_lock(&dev->lock);