]> git.ipfire.org Git - people/ms/network.git/commitdiff
zone: Check early if a id is valid
authorJonatan Schlag <jonatan.schlag@ipfire.org>
Wed, 5 Jul 2017 14:19:53 +0000 (16:19 +0200)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 5 Jul 2017 15:14:13 +0000 (17:14 +0200)
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/functions/functions.zone

index 776b63b0144d5a2234eb9b53badceeb5e56248f6..d1212252cd5d17914c8c2f6d2fdd972096338212 100644 (file)
@@ -550,7 +550,12 @@ zone_config() {
                        zone_config_new "${zone}" "$@"
                        ;;
                destroy)
-                       zone_config_destroy "${zone}" "$@"
+                       local id=${1}
+                       if zone_config_id_is_valid ${zone} ${id}; then
+                               zone_config_destroy "${zone}" "$@"
+                       else
+                               log ERROR "${id} is not a valid id"
+                       fi
                        ;;
                edit)
                        zone_config_edit "${zone}" "$@"