]> git.ipfire.org Git - people/ms/u-boot.git/commit
fs-test.sh: fix pre-requisite detection
authorStephen Warren <swarren@wwwdotorg.org>
Sat, 3 Oct 2015 19:56:48 +0000 (13:56 -0600)
committerTom Rini <trini@konsulko.com>
Sat, 24 Oct 2015 17:50:34 +0000 (13:50 -0400)
commit47b71644500f7dff768254570ff62c6e985e4bc3
treeb8e23263e642ae4cdfdafadfd490f1e22d123ca4
parent4a28274227d085d77d46709dc94ccc3d69610f53
fs-test.sh: fix pre-requisite detection

In the following snippet:

if [ ! -x `which $prereq` ]; then

When $prereq does not exist, `which $prereq` evaluates to the empty string,
which results in *no* argument being passed to the -x operator, which then
evaluates to true, which is the equivalent of the prereq having been found. In
order for this to fail as expected, we must pass an empty argument, which then
causes -x to fail. Do this by wrapping the `` in quotes so there's always an
argument to -x, even if the value of the argument is zero-length.

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
test/fs/fs-test.sh