]> git.ipfire.org Git - people/ms/u-boot.git/commit
ext4: Fix comparision of unsigned expression with < 0
authorLokesh Vutla <lokeshvutla@ti.com>
Wed, 26 Apr 2017 11:28:22 +0000 (16:58 +0530)
committerTom Rini <trini@konsulko.com>
Thu, 27 Apr 2017 20:49:09 +0000 (16:49 -0400)
commit509b498a500afab1111d69f789b630c699b071a3
tree9dc40469845fd01d98382361f89be57f855a5859
parent8a707bafe0677b034632dda6dd0dc1061b105ff1
ext4: Fix comparision of unsigned expression with < 0

In file ext4fs.c funtion ext4fs_read_file() compares an
unsigned expression with < 0 like below

lbaint_t blknr;
blknr = read_allocated_block(&(node->inode), i);
if (blknr < 0)
return -1;

blknr is of type ulong/uint64_t. read_allocated_block() returns
long int. So comparing blknr with < 0 will always be false. Instead
declare blknr as long int.

Similarly ext4/dev.c does a similar comparison. Drop the redundant
comparison.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
fs/ext4/dev.c
fs/ext4/ext4fs.c