]> git.ipfire.org Git - people/ms/u-boot.git/commit
common: miiphyutil: avoid memory leak
authorPeng Fan <Peng.Fan@freescale.com>
Thu, 26 Nov 2015 02:26:59 +0000 (10:26 +0800)
committerTom Rini <trini@konsulko.com>
Sat, 5 Dec 2015 23:22:24 +0000 (18:22 -0500)
commit746da1bd42aa5ecc47898399514c9c76d0329706
tree43b3dbb21a9c804bfd52a390aede9bbdc4e203b9
parent678e9316d48f78d162f705846b6f6eeab4aa5dd0
common: miiphyutil: avoid memory leak

The following code will alloc memory for new_dev and ldev:
"
new_dev = mdio_alloc();
ldev = malloc(sizeof(*ldev));
"
Either new_dev or ldev is NULL, directly return, but this may leak memory.
So before return, using free(ldev) and mdio_free(new_dev) to avoid
leaking memory, also free can handle NULL pointer.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
common/miiphyutil.c