]> git.ipfire.org Git - people/ms/u-boot.git/commit
drivers: remoteproc: rproc-uclass: Fix check for NULL pointers
authorNishanth Menon <nm@ti.com>
Tue, 1 Dec 2015 04:05:58 +0000 (22:05 -0600)
committerTom Rini <trini@konsulko.com>
Sat, 5 Dec 2015 23:22:32 +0000 (18:22 -0500)
commit9cb05a8f9f87297820a5ff6a487f100cb1cd69c1
tree7523ae532bd635f2d666fa030a381824db75d6bd
parent5be93569262f4ebc963ca95891667f523f368d89
drivers: remoteproc: rproc-uclass: Fix check for NULL pointers

Neither uc_pdata->name nor check_name are supposed to be NULL in
_rproc_name_is_unique(). if uc_pdata->name is NULL, we are not
intialized yet, however if check_data is NULL, we do not have
proper data. Further, if either were NULL, strlen will crap out
while attempting to derefence NULL.

Instead, just check if either of these are NULL and bail out.

This should also fix the following coverity scan warnings:
*** CID 132281:  Null pointer dereferences  (FORWARD_NULL)
/drivers/remoteproc/rproc-uclass.c: 73 in _rproc_name_is_unique()

Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/remoteproc/rproc-uclass.c