]> git.ipfire.org Git - people/ms/u-boot.git/commit
mmc: sh_sdhi: Fix the ACMD handling
authorMarek Vasut <marek.vasut@gmail.com>
Fri, 21 Jul 2017 21:22:55 +0000 (23:22 +0200)
committerJaehoon Chung <jh80.chung@samsung.com>
Thu, 17 Aug 2017 05:38:02 +0000 (14:38 +0900)
commita3f0a7d5b50aa558ecab1fc3a9f5d773eac94051
tree00697972d1fc2ecf5395036eb1a7baffc331a74a
parentd1c18ca1103956087f303cf6a28fc84ba5b25922
mmc: sh_sdhi: Fix the ACMD handling

The command handling in this driver is awful, esp. because the driver
depends on command numbers to determine whether this is APPCMD or not.
Also, handling of command RSP response types is totally wrong.

This patch at least plucks out some of the custom command encoding and
fixes the APPCMD handling. The RSP handling still needs work, yet that
might not be needed as it turns out the uniphier-sd.c driver is in much
better shape and supports the same IP, so we might be able to just drop
this driver in favor of the uniphier one.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
arch/arm/mach-rmobile/include/mach/sh_sdhi.h
drivers/mmc/sh_sdhi.c