]> git.ipfire.org Git - people/ms/u-boot.git/commit
dm: spi_flash: fix wrong dependency
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 31 Mar 2015 03:47:52 +0000 (12:47 +0900)
committerSimon Glass <sjg@chromium.org>
Sat, 18 Apr 2015 17:11:30 +0000 (11:11 -0600)
commitb3d023b4058acc83d211555e62068f84e322bcac
tree47a7cb39b7eabd1fc80f85dd669468acd47e7f1d
parent5fd2733e5a821acf0358f51d436b61209deac9a5
dm: spi_flash: fix wrong dependency

CONFIG_SPI does not exist in Kconfig in the first place, so the
dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH
can never be enabled (unless you ignore the dependency in an illegal
way.  See below.)

Actually, some defconfigs such as socfpga_*_defconfig define
CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file
because of this wrong dependency.

On the other hand, all the Tegra boards enable DM_SPI_FLASH because

  config DM_SPI_FLASH
          default y

silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere
in U-Boot, so we easily miss such a wrong dependency.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
drivers/mtd/spi/Kconfig