]> git.ipfire.org Git - people/ms/u-boot.git/commit
spl: mmc: Unify non/driver model spl_mmc_find_device()
authorSimon Glass <sjg@chromium.org>
Wed, 2 Dec 2015 17:59:13 +0000 (10:59 -0700)
committerTom Rini <trini@konsulko.com>
Sat, 5 Dec 2015 23:22:34 +0000 (18:22 -0500)
commitb4857aa90105ea85bf029f8eb99e72fbadc0e2d0
tree1e288524936ab3740e167d25be58cfe311416d03
parent99c7a51a249292ba98889b253659b27ed089bd7e
spl: mmc: Unify non/driver model spl_mmc_find_device()

It is risky to have two different functions with much the same code. Future
authors may update one but not the other. It is hard to see which parts are
the same and which are different.

Unify the functions and drop the differences that are not really needed.

Note that one puts() becomes printf() as Tom mentioned that this does not
affect image size:

https://patchwork.ozlabs.org/patch/537276/

Note: It would be better to have an empty printf() and avoid the #ifdef for
CONFIG_SPL_LIBCOMMON_SUPPORT.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Michal Simek <michal.simek@xilinx.com>
common/spl/spl_mmc.c