]> git.ipfire.org Git - people/ms/u-boot.git/commit
mtd: nand: fix bug writing 1 byte less than page size
authorHector Palacios <hector.palacios@digi.com>
Mon, 18 Jul 2016 07:37:41 +0000 (09:37 +0200)
committerScott Wood <oss@buserror.net>
Mon, 25 Jul 2016 01:36:29 +0000 (20:36 -0500)
commitebb7febc92fc628d1f37b96616a1bb21b646d072
tree8ba36cc251180dff8aacbc762354539397b14c5d
parentc1aa7d629eb9f0ed7836061170461abb04d34111
mtd: nand: fix bug writing 1 byte less than page size

nand_do_write_ops() determines if it is writing a partial page with the
formula:
part_pagewr = (column || writelen < (mtd->writesize - 1))

When 'writelen' is exactly 1 byte less than the NAND page size the formula
equates to zero, so the code doesn't process it as a partial write, although
it should.
As a consequence the function remains in the while(1) loop with 'writelen'
becoming 0xffffffff and iterating until the watchdog timeout triggers.

To reproduce the issue on a NAND with 2K page (0x800):
=> nand erase.part <partition>
=> nand write $loadaddr <partition> 7ff

Signed-off-by: Hector Palacios <hector.palacios@digi.com>
drivers/mtd/nand/nand_base.c