]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/blobdiff - html/cgi-bin/dns.cgi
dns.cgi: Set kdig params for timeout and retry back to default.
[people/pmueller/ipfire-2.x.git] / html / cgi-bin / dns.cgi
index f4838b0464959e69cbb516e5dbae9ffa9f7907bd..385c7be44b9b67c3c1d1d52b0fa5c9f467e29dd5 100755 (executable)
@@ -28,6 +28,7 @@ use IO::Socket;
 
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/geoip-functions.pl";
+require "${General::swroot}/ids-functions.pl";
 require "${General::swroot}/lang.pl";
 require "${General::swroot}/header.pl";
 
@@ -51,11 +52,16 @@ unless (-f $settings_file) { system("touch $settings_file") };
 unless (-f $servers_file) { system("touch $servers_file") };
 
 # File which stores the ISP assigned DNS servers.
-my @ISP_nameserver_files = ( "${General::swroot}/dns/dns1", "${General::swroot}/dns/dns2" );
+my @ISP_nameserver_files = ( "/var/run/dns1", "/var/run/dns2" );
 
 # File which contains the ca-certificates.
 my $ca_certs_file = "/etc/ssl/certs/ca-bundle.crt";
 
+# Server which is used, to determine if the whole DNS system works properly.
+my $dns_test_server = "ping.ipfire.org";
+
+my $check_servers;
+
 my %color = ();
 my %mainsettings = ();
 &General::readhash("${General::swroot}/main/settings", \%mainsettings);
@@ -81,8 +87,20 @@ if ($cgiparams{'GENERAL'} eq $Lang::tr{'save'}) {
                $cgiparams{'ENABLE_SAFE_SEARCH'} = "off";
        }
 
-       # Store settings into settings file.
-       &General::writehash("$settings_file", \%cgiparams);
+       # Check if using ISP nameservers and TLS is enabled at the same time.
+       if (($cgiparams{'USE_ISP_NAMESERVERS'} eq "on") && ($cgiparams{'PROTO'} eq "TLS")) {
+               $errormessage = $Lang::tr{'dns isp nameservers and tls not allowed'}
+       }
+
+       # Check if there was an error.
+       if ( ! $errormessage) {
+
+               # Store settings into settings file.
+               &General::writehash("$settings_file", \%cgiparams);
+
+               # Call function to handle unbound restart, etc.
+               &_handle_unbound_and_more()
+       }
 }
 
 ###
@@ -95,8 +113,13 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
        # Read-in generic settings.
        &General::readhash("$settings_file", \%settings);
 
+       # Check if an IP-address has been given.
+       if ($cgiparams{"NAMESERVER"} eq "") {
+               $errormessage = "$Lang::tr{'dns no address given'}";
+       }
+
        # Check if the given DNS server is valid.
-       if(!&General::validip($cgiparams{"NAMESERVER"})) {
+       elsif(!&General::validip($cgiparams{"NAMESERVER"})) {
                $errormessage = "$Lang::tr{'invalid ip'}: $cgiparams{'NAMESERVER'}";
        }
 
@@ -112,16 +135,6 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
                }
        }
 
-       # Check the nameserver.
-       my $status = &check_nameserver("$cgiparams{'NAMESERVER'}", "ping.ipfire.org", "$settings{'PROTO'}", "$cgiparams{'TLS_HOSTNAME'}");
-
-       # Assign errormessage, if the nameserver does not support dnssec or any other kind of error happened.
-       if ($status eq "0") {
-               $errormessage = "$Lang::tr{'dns could not add server'} $Lang::tr{'dnssec not supported'}";
-       } elsif (($status ne "1") && ($status ne "2")) {
-               $errormessage = "$Lang::tr{'dns could not add server'} $status";
-       }
-
        # Go further if there was no error.
        if ( ! $errormessage) {
                # Check if a remark has been entered.
@@ -164,7 +177,7 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
                        # The first allowed id is 3 to keep space for
                        # possible ISP assigned DNS servers.
-                       if ($id le "2") {
+                       if ($id <= "2") {
                                $id = "3";
                        }
                }
@@ -174,6 +187,9 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
                # Write the changed hash to the config file.
                &General::writehasharray($servers_file, \%dns_servers);
+
+               # Call function to handle unbound restart, etc.
+               &_handle_unbound_and_more();
        } else {
                # Switch back to previous mode.
                $cgiparams{'SERVERS'} = $cgiparams{'MODE'};
@@ -210,6 +226,9 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
                # Write the changed hash back to the config file.
                &General::writehasharray($servers_file, \%dns_servers);
+
+               # Call function to handle unbound restart, etc.
+               &_handle_unbound_and_more();
        }
 
 ## Remove entry from DNS servers list.
@@ -228,6 +247,14 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
        # Write the changed hash to the config file.
        &General::writehasharray($servers_file, \%dns_servers);
+
+       # Call function to handle unbound restart, etc.
+       &_handle_unbound_and_more();
+
+## Handle request to check the servers.
+#
+} elsif ($cgiparams{'SERVERS'} eq $Lang::tr{'dns check servers'}) {
+       $check_servers = 1;
 }
 
 # Hash to store the generic DNS settings.
@@ -389,9 +416,39 @@ END
 # Section to display the configured and used DNS servers.
 #
 sub show_nameservers () {
-       &Header::openbox('100%', 'center', "DNS-Servers");
+       &Header::openbox('100%', 'center', "$Lang::tr{'dns title'}");
+
+       my $dns_status_string;
+       my $dns_status_col;
+       my $dns_working;
+
+       # Test if the DNS system is working.
+       #
+       # Simple send a request to unbound and check if it can resolve the
+       # DNS test server.
+       my $dns_status_ret = &check_nameserver("127.0.0.1", "$dns_test_server", "UDP");
+
+       if ($dns_status_ret eq "2") {
+               $dns_status_string = "$Lang::tr{'working'}";
+               $dns_status_col = "${Header::colourgreen}";
+               $dns_working = 1;
+       } else {
+               $dns_status_string = "$Lang::tr{'broken'}";
+               $dns_status_col = "${Header::colourred}";
+       }
 
 print <<END;
+               <table width='100%'>
+                       <tr>
+                               <td>
+                                       <strong>$Lang::tr{'status'}:&nbsp;</strong>
+                                       <strong><font color='$dns_status_col'>$dns_status_string</font></strong>
+                               </td>
+                       </tr>
+               </table>
+
+               <br>
+
                <table class="tbl" width='100%'>
                        <tr>
                                <td align="center">
@@ -409,34 +466,43 @@ print <<END;
                                <td align="center">
                                        <strong>$Lang::tr{'remark'}</strong>
                                </td>
-
+END
+       # Check if the status should be displayed.
+       if ($check_servers) {
+print <<END
                                <td align="center">
                                        <strong>$Lang::tr{'status'}</strong>
                                </td>
+END
+;
+       }
+
+print <<END
 
                                <td align="center" colspan="3">
                                        <strong>$Lang::tr{'action'}</strong>
                                </td>
                        </tr>
 END
+;
 
                # Check the usage of ISP assigned nameservers is enabled.
-               if ($settings{'USE_ISP_NAMESERVERS'} eq "on") {
-                       my $id="1";
-
-                       # Loop through the array which stores the files.
-                       foreach my $file (@ISP_nameserver_files) {
-                               # Grab the address of the nameserver.
-                               my $address = &grab_address_from_file($file);
-
-                               # Check if we got an address.
-                               if ($address) {
-                                       # Add the address to the hash of nameservers.
-                                       $dns_servers{$id} = [ "$address", "none", "enabled", "$Lang::tr{'dns isp assigned nameserver'}" ];
-
-                                       # Increase id by one.
-                                       $id++;
-                               }
+               my $id = 1;
+
+               # Loop through the array which stores the files.
+               foreach my $file (@ISP_nameserver_files) {
+                       # Grab the address of the nameserver.
+                       my $address = &General::grab_address_from_file($file);
+
+                       # Check if we got an address.
+                       if ($address) {
+                               # Add the address to the hash of nameservers.
+                               $dns_servers{$id} = [ "$address", "none",
+                                       ($settings{'USE_ISP_NAMESERVERS'} eq "on") ? "enabled" : "disabled",
+                                       "$Lang::tr{'dns isp assigned nameserver'}" ];
+
+                               # Increase id by one.
+                               $id++;
                        }
                }
 
@@ -483,11 +549,11 @@ END
                                my $status_colour;
 
                                # Only grab the status if the nameserver is enabled.
-                               if ($enabled eq "enabled") {
+                               if (($check_servers) && ($enabled eq "enabled")) {
                                        $status = &check_nameserver("$nameserver", "ping.ipfire.org", "$settings{'PROTO'}", "$tls_hostname");
                                }
 
-                               if (!$status) {
+                               if (!defined $status) {
                                        $status_short = "$Lang::tr{'disabled'}";
 
                                # DNSSEC Not supported
@@ -519,11 +585,21 @@ END
                                my $ccode = &GeoIP::lookup($nameserver);
                                my $flag_icon = &GeoIP::get_flag_icon($ccode);
 
-                               my $iaddr = inet_aton($nameserver);
-                               my $rdns = gethostbyaddr($iaddr, AF_INET);
+                               my $rdns;
+
+                               # Only do the reverse lookup if the system is online.
+                               if ($dns_working) {
+                                       my $iaddr = inet_aton($nameserver);
+                                       $rdns = gethostbyaddr($iaddr, AF_INET);
+                               }
 
                                if (!$rdns) { $rdns = $Lang::tr{'lookup failed'}; }
 
+                               # Mark ISP name servers as disabled
+                               if ($id <= 2 && $enabled eq "disabled") {
+                                       $nameserver = "<del>$nameserver</del>";
+                               }
+
 print <<END;
                        <tr>
                                <td align="center" $col>
@@ -541,12 +617,18 @@ print <<END;
                                <td align="center" $col>
                                        $remark
                                </td>
-
-                               <td align="center" $col>
-                                       <strong><font color="$status_colour"><abbr title="$status_message">$status_short</abbr></font></strong>
-                               </td>
 END
 ;
+                               # Display server status if requested.
+                               if ($check_servers) {
+print <<END
+                                       <td align="center" $col>
+                                               <strong><font color="$status_colour"><abbr title="$status_message">$status_short</abbr></font></strong>
+                                       </td>
+END
+;
+                               }
+
                                # Check if the id is greater than "2".
                                #
                                # Nameservers with an ID's of one or two are ISP assigned,
@@ -614,7 +696,10 @@ END
 print <<END;
                        <tr>
                                <form method="post" action="$ENV{'SCRIPT_NAME'}">
-                                       <td colspan="9" align="right"><input type="submit" name="SERVERS" value="$Lang::tr{'add'}"></td>
+                                       <td colspan="9" align="right">
+                                               <input type="submit" name="SERVERS" value="$Lang::tr{'add'}">
+                                               <input type="submit" name="SERVERS" value="$Lang::tr{'dns check servers'}">
+                                       </td>
                                </form>
                        </tr>
                </table>
@@ -673,6 +758,13 @@ sub show_add_edit_nameserver() {
                &Header::openbox('100%', 'left', $Lang::tr{'dnsforward add a new entry'});
        }
 
+       my $tls_required_image;
+
+       # If the protocol is TLS, dispaly the required image.
+       if ($settings{'PROTO'} eq "TLS") {
+               $tls_required_image = "<img src='/blob.gif' alt='*'>";
+       }
+
        # Add hidden input to store the mode.
        print "<input type='hidden' name='MODE' value='$cgiparams{'SERVERS'}'>\n";
 
@@ -682,20 +774,13 @@ print <<END
                        <td width='20%' class='base'>$Lang::tr{'ip address'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
                        <td><input type='text' name='NAMESERVER' value='$cgiparams{"NAMESERVER"}' size='24' /></td>
                </tr>
-END
-;
-       # If the protocol is TLS, display the TLS hostname input.
-       if ($settings{'PROTO'} eq "TLS") {
-print <<END
+
+
                <tr>
-                       <td width='20%' class='base'>$Lang::tr{'dns tls hostname'}:&nbsp;<img src='/blob.gif' alt='*'></td>
+                       <td width='20%' class='base'>$Lang::tr{'dns tls hostname'}:&nbsp;$tls_required_image</td>
                        <td><input type='text' name='TLS_HOSTNAME' value='$cgiparams{'TLS_HOSTNAME'}' size='24'></td>
                </tr>
-END
-;
-       }
 
-print <<END
 
                <tr>
                        <td width ='20%' class='base'>$Lang::tr{'remark'}:</td>
@@ -724,47 +809,46 @@ END
        &Header::closebox();
 }
 
-# Tiny function to grab an IP-address of a given file.
-sub grab_address_from_file($) {
-       my ($file) = @_;
-
-       my $address;
+# Private function to handle the restart of unbound and more.
+sub _handle_unbound_and_more () {
+       # Restart unbound
+       system('/usr/local/bin/unboundctrl reload >/dev/null');
 
-       # Check if the given file exists.
-       if(-f $file) {
-               # Open the file for reading.
-               open(FILE, $file) or die "Could not read from $file. $!\n";
+       # Check if the IDS is running.
+       if(&IDS::ids_is_running()) {
+               # Re-generate the file which contains the DNS Server
+               # details.
+               &IDS::generate_dns_servers_file();
 
-               # Read the address from the file.
-               $address = <FILE>;
-
-               # Close filehandle.
-               close(FILE);
-
-               # Remove newlines.
-               chomp($address);
-
-               # Check if the obtained address is valid.
-               if (&General::validip($address)) {
-                       # Return the address.
-                       return $address;
-               }
+               # Call suricatactrl to perform a reload.
+               &IDS::call_suricatactrl("restart");
        }
+}
 
-       # Return nothing.
-       return;
+# Check if the system is online (RED is connected).
+sub red_is_active () {
+       # Check if the "active" file is present.
+       if ( -f "${General::swroot}/red/active") {
+               # Return "1" - True.
+               return 1;
+       } else {
+               # Return nothing - False.
+               return;
+       }
 }
 
 # Function to check a given nameserver against propper work.
 sub check_nameserver($$$$) {
        my ($nameserver, $record, $proto, $tls_hostname) = @_;
 
-       # Timout for the query in seconds.
-       my $timeout;
-       my $retry = "+retry=0";
+       # Check if the system is online.
+       unless (&red_is_active()) {
+               return "$Lang::tr{'system is offline'}";
+       }
 
        # Default values.
-       my @command = ("kdig", "$timeout", "$retry", "+dnssec");
+       my @command = ("kdig", "+dnssec",
+               "+bufsize=1232");
 
        # Handle different protols.
        if ($proto eq "TCP") {
@@ -798,10 +882,6 @@ sub check_nameserver($$$$) {
         my $output = join("", @output);
 
        my $status = 0;
-       if ($output =~ m/WARNING: (.*)/) {
-               return $1;
-
-       }
 
        if ($output =~ m/status: (\w+)/) {
                $status = ($1 eq "NOERROR");
@@ -809,6 +889,18 @@ sub check_nameserver($$$$) {
                if (!$status) {
                        return -1;
                }
+       } else {
+               my $warning;
+
+               while ($output =~ m/WARNING: (.*)/g) {
+                       # Add the current grabbed warning to the warning string.
+                       $warning .= "$1\; ";
+               }
+
+               # Return the warning string, if we grabbed at least one.
+               if ($warning) {
+                       return $warning;
+               }
        }
 
        my @flags = ();
@@ -817,7 +909,7 @@ sub check_nameserver($$$$) {
        }
 
        my $aware = ($output =~ m/RRSIG/);
-       my $validating = ("ad;" ~~ @flags);
+       my $validating = (grep(/ad;/, @flags));
 
        return $aware + $validating;
 }