]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/blobdiff - html/cgi-bin/ovpnmain.cgi
suricata: Change midstream policy to "pass-flow"
[people/pmueller/ipfire-2.x.git] / html / cgi-bin / ovpnmain.cgi
old mode 100644 (file)
new mode 100755 (executable)
index 7e274b3..c92d023
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2014  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2023  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
 #                                                                             #
 ###############################################################################
-###
-# Based on IPFireCore 77
-###
+
 use CGI;
 use CGI qw/:standard/;
+use Imager::QRCode;
+use MIME::Base32;
+use MIME::Base64;
+use URI::Encode qw(uri_encode uri_decode);;
 use Net::DNS;
 use Net::Ping;
 use Net::Telnet;
@@ -31,6 +33,7 @@ use File::Temp qw/ tempfile tempdir /;
 use strict;
 use Archive::Zip qw(:ERROR_CODES :CONSTANTS);
 use Sort::Naturally;
+use Date::Parse;
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
 require "${General::swroot}/header.pl";
@@ -40,6 +43,7 @@ require "${General::swroot}/location-functions.pl";
 # enable only the following on debugging purpose
 #use warnings;
 #use CGI::Carp 'fatalsToBrowser';
+
 #workaround to suppress a warning when a variable is used only once
 my @dummy = ( ${Header::colourgreen}, ${Header::colourblue} );
 undef (@dummy);
@@ -75,6 +79,7 @@ my $name;
 my $col="";
 my $local_serverconf = "${General::swroot}/ovpn/scripts/server.conf.local";
 my $local_clientconf = "${General::swroot}/ovpn/scripts/client.conf.local";
+my $dhparameter = "/etc/ssl/ffdhe4096.pem";
 
 &General::readhash("${General::swroot}/ethernet/settings", \%netsettings);
 $cgiparams{'ENABLED'} = 'off';
@@ -86,8 +91,6 @@ $cgiparams{'COMPRESSION'} = 'off';
 $cgiparams{'ONLY_PROPOSED'} = 'off';
 $cgiparams{'ACTION'} = '';
 $cgiparams{'CA_NAME'} = '';
-$cgiparams{'DH_NAME'} = 'dh1024.pem';
-$cgiparams{'DHLENGHT'} = '';
 $cgiparams{'DHCP_DOMAIN'} = '';
 $cgiparams{'DHCP_DNS'} = '';
 $cgiparams{'DHCP_WINS'} = '';
@@ -135,6 +138,17 @@ unless (-e "$local_clientconf") {
 ###
 ### Useful functions
 ###
+sub iscertlegacy
+{
+       my $file=$_[0];
+       my @certinfo = &General::system_output("/usr/bin/openssl", "pkcs12", "-info", "-nodes", 
+       "-in", "$file.p12", "-noout", "-passin", "pass:''");
+       if (index ($certinfo[0], "MAC: sha1") != -1) {
+               return 1;
+       }
+       return 0;
+}
+
 sub haveOrangeNet
 {
        if ($netsettings{'CONFIG_TYPE'} == 2) {return 1;}
@@ -218,28 +232,6 @@ sub deletebackupcert
 
 sub pkiconfigcheck
 {
-       # Warning if DH parameter is 1024 bit
-       if (-f "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}") {
-               my @dhparameter = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}");
-               my $dhbit;
-
-               # Loop through the output and search for the DH bit lenght.
-               foreach my $line (@dhparameter) {
-                       if ($line =~ (/(\d+)/)) {
-                               # Assign match to dhbit value.
-                               $dhbit = $1;
-
-                               last;
-                       }
-               }
-
-               # Check if the used key lenght is at least 2048 bit.
-               if ($dhbit < 2048) {
-                       $cryptoerror = "$Lang::tr{'ovpn error dh'}";
-                       goto CRYPTO_ERROR;
-               }
-       }
-
        # Warning if md5 is in usage
        if (-f "${General::swroot}/ovpn/certs/servercert.pem") {
                my @signature = &General::system_output("/usr/bin/openssl", "x509", "-noout", "-text", "-in", "${General::swroot}/ovpn/certs/servercert.pem");
@@ -264,11 +256,11 @@ sub pkiconfigcheck
 }
 
 sub writeserverconf {
-    my %sovpnsettings = ();  
-    my @temp = ();  
+    my %sovpnsettings = ();
+    my @temp = ();
     &General::readhash("${General::swroot}/ovpn/settings", \%sovpnsettings);
     &read_routepushfile;
-    
+
     open(CONF,    ">${General::swroot}/ovpn/server.conf") or die "Unable to open ${General::swroot}/ovpn/server.conf: $!";
     flock CONF, 2;
     print CONF "#OpenVPN Server conf\n";
@@ -287,7 +279,7 @@ sub writeserverconf {
     print CONF "ca ${General::swroot}/ovpn/ca/cacert.pem\n";
     print CONF "cert ${General::swroot}/ovpn/certs/servercert.pem\n";
     print CONF "key ${General::swroot}/ovpn/certs/serverkey.pem\n";
-    print CONF "dh ${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}\n";
+    print CONF "dh $dhparameter\n";
     my @tempovpnsubnet = split("\/",$sovpnsettings{'DOVPN_SUBNET'});
     print CONF "server $tempovpnsubnet[0] $tempovpnsubnet[1]\n";
     #print CONF "push \"route $netsettings{'GREEN_NETADDRESS'} $netsettings{'GREEN_NETMASK'}\"\n";
@@ -332,9 +324,9 @@ sub writeserverconf {
                print CONF "fragment $sovpnsettings{'FRAGMENT'}\n";
     }
 
-    if ($sovpnsettings{KEEPALIVE_1} > 0 && $sovpnsettings{KEEPALIVE_2} > 0) {  
+    if ($sovpnsettings{KEEPALIVE_1} > 0 && $sovpnsettings{KEEPALIVE_2} > 0) {
        print CONF "keepalive $sovpnsettings{'KEEPALIVE_1'} $sovpnsettings{'KEEPALIVE_2'}\n";
-    }  
+    }
     print CONF "status-version 1\n";
     print CONF "status /var/run/ovpnserver.log 30\n";
     print CONF "ncp-disable\n";
@@ -363,15 +355,17 @@ sub writeserverconf {
     if ($sovpnsettings{DHCP_WINS} ne '') {
         print CONF "push \"dhcp-option WINS $sovpnsettings{DHCP_WINS}\"\n";
     }
-    
+
     if ($sovpnsettings{MAX_CLIENTS} eq '') {
        print CONF "max-clients 100\n";
     }
     if ($sovpnsettings{MAX_CLIENTS} ne '') {
        print CONF "max-clients $sovpnsettings{MAX_CLIENTS}\n";
-    }  
+    }
     print CONF "tls-verify /usr/lib/openvpn/verify\n";
     print CONF "crl-verify /var/ipfire/ovpn/crls/cacrl.pem\n";
+    print CONF "auth-user-pass-optional\n";
+    print CONF "reneg-sec 86400\n";
     print CONF "user nobody\n";
     print CONF "group nobody\n";
     print CONF "persist-key\n";
@@ -385,6 +379,11 @@ sub writeserverconf {
     print CONF "# Log clients connecting/disconnecting\n";
     print CONF "client-connect \"/usr/sbin/openvpn-metrics client-connect\"\n";
     print CONF "client-disconnect \"/usr/sbin/openvpn-metrics client-disconnect\"\n";
+    print CONF "\n";
+
+    print CONF "# Enable Management Socket\n";
+    print CONF "management /var/run/openvpn.sock unix\n";
+    print CONF "management-client-auth\n";
 
     # Print server.conf.local if entries exist to server.conf
     if ( !-z $local_serverconf  && $sovpnsettings{'ADDITIONAL_CONFIGS'} eq 'on') {
@@ -402,9 +401,9 @@ sub writeserverconf {
        close (LSC);
     }
     print CONF "\n";
-    
+
     close(CONF);
-}    
+}
 
 sub emptyserverlog{
     if (open(FILE, ">/var/run/ovpnserver.log")) {
@@ -415,7 +414,7 @@ sub emptyserverlog{
 
 }
 
-sub delccdnet 
+sub delccdnet
 {
        my %ccdconfhash = ();
        my %ccdhash = ();
@@ -436,7 +435,7 @@ sub delccdnet
                        }
        }
        &General::writehasharray("${General::swroot}/ovpn/ccd.conf", \%ccdconfhash);
-       
+
        &writeserverconf;
        return 0;
 }
@@ -452,21 +451,21 @@ sub addccdnet
        my $checkup;
        my $ccdip;
        my $baseaddress;
-       
-       
-       #check name     
-       if ($ccdname eq '') 
+
+
+       #check name
+       if ($ccdname eq '')
        {
                $errormessage=$errormessage.$Lang::tr{'ccd err name'}."<br>";
                return
        }
-       
-       if(!&General::validhostname($ccdname))
+
+       if(!&General::validccdname($ccdname))
        {
                $errormessage=$Lang::tr{'ccd err invalidname'};
                return;
        }
-               
+
        ($ccdip,$subcidr) = split (/\//,$ccdnet);
        $subcidr=&General::iporsubtocidr($subcidr);
        #check subnet
@@ -499,14 +498,14 @@ sub addccdnet
 
 sub modccdnet
 {
-       
+
        my $newname=$_[0];
        my $oldname=$_[1];
        my %ccdconfhash=();
        my %ccdhash=();
 
        # Check if the new name is valid.
-       if(!&General::validhostname($newname)) {
+       if(!&General::validccdname($newname)) {
                $errormessage=$Lang::tr{'ccd err invalidname'};
                return;
        }
@@ -526,7 +525,7 @@ sub modccdnet
                        }
                }
        }
-       
+
        &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%ccdhash);
                foreach my $key (keys %ccdhash) {
                        if ($ccdhash{$key}[32] eq $oldname) {
@@ -535,7 +534,7 @@ sub modccdnet
                                last;
                        }
                }
-       
+
        return 0;
 }
 sub ccdmaxclients
@@ -554,7 +553,7 @@ sub ccdmaxclients
        return $e-1;
 }
 
-sub getccdadresses 
+sub getccdadresses
 {
        my $ipin=$_[0];
        my ($ip1,$ip2,$ip3,$ip4)=split  /\./, $ipin;
@@ -591,7 +590,7 @@ sub getccdadresses
 sub fillselectbox
 {
        my $boxname=$_[1];
-       my ($ccdip,$subcidr) = split("/",$_[0]); 
+       my ($ccdip,$subcidr) = split("/",$_[0]);
        my $tz=$_[2];
        my @allccdips=&getccdadresses($ccdip,$subcidr,&ccdmaxclients($ccdip."/".$subcidr),$tz);
        print"<select name='$boxname' STYLE='font-family : arial; font-size : 9pt; width:130px;' >";
@@ -628,10 +627,10 @@ sub check_routes_push
                                open(FILE,"${General::swroot}/ovpn/routes_push");
                                while (<FILE>) {
                                        $_=~s/\s*$//g;
-                                       
+
                                        my ($ip2,$cidr2) = split (/\//,"$_");
                                        my $val2=$ip2."/".&General::iporsubtodec($cidr2);
-                                       
+
                                        if($val eq $val2){
                                                return 0;
                                        }
@@ -682,7 +681,7 @@ sub check_ccdconf
                        if (&General::IpInSubnet ($ip,$ip2,&General::cidrtosub($cidr2))){
                                return 0;
                        }
-               
+
        }
        return 1;
 }
@@ -697,7 +696,7 @@ sub validdotmask
        if (&General::validip($ipdotmask)) { return 0; }
        if (!($ipdotmask =~ /^(.*?)\/(.*?)$/)) {  }
        my $mask = $2;
-       if (($mask =~ /\./ )) { return 0; }     
+       if (($mask =~ /\./ )) { return 0; }
   return 1;
 }
 
@@ -710,7 +709,7 @@ sub write_routepushfile
        if ($vpnsettings{'ROUTES_PUSH'} ne '') {
                print FILE $vpnsettings{'ROUTES_PUSH'};
        }
-       close(FILE); 
+       close(FILE);
 }
 
 sub read_routepushfile
@@ -721,7 +720,7 @@ sub read_routepushfile
                while (<FILE>) { $vpnsettings{'ROUTES_PUSH'} .= $_ };
                close(FILE);
                $cgiparams{'ROUTES_PUSH'} = $vpnsettings{'ROUTES_PUSH'};
-               
+
        }
 }
 
@@ -777,18 +776,18 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'start ovpn server'} ||
     if ($cgiparams{'ACTION'} eq $Lang::tr{'start ovpn server'}){
        &emptyserverlog();
        &General::system("/usr/local/bin/openvpnctrl", "-s");
-    }   
+    }
     #stop openvpn server
     if ($cgiparams{'ACTION'} eq $Lang::tr{'stop ovpn server'}){
        &General::system("/usr/local/bin/openvpnctrl", "-k");
-       &emptyserverlog();      
-    }   
+       &emptyserverlog();
+    }
 #    #restart openvpn server
 #    if ($cgiparams{'ACTION'} eq $Lang::tr{'restart ovpn server'}){
-#workarund, till SIGHUP also works when running as nobody    
-#      system('/usr/local/bin/openvpnctrl', '-r');     
-#      &emptyserverlog();      
-#    }       
+#workarund, till SIGHUP also works when running as nobody
+#      system('/usr/local/bin/openvpnctrl', '-r');
+#      &emptyserverlog();
+#    }
 }
 
 ###
@@ -813,11 +812,11 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}) {
     $vpnsettings{'DHCP_WINS'} = $cgiparams{'DHCP_WINS'};
     $vpnsettings{'ROUTES_PUSH'} = $cgiparams{'ROUTES_PUSH'};
     my @temp=();
-    
+
     if ($cgiparams{'FRAGMENT'} eq '') {
        delete $vpnsettings{'FRAGMENT'};
     } else {
-       if ($cgiparams{'FRAGMENT'} !~ /^[0-9]+$/) { 
+       if ($cgiparams{'FRAGMENT'} !~ /^[0-9]+$/) {
            $errormessage = "Incorrect value, please insert only numbers.";
         goto ADV_ERROR;
                } else {
@@ -852,29 +851,29 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}) {
     if ($cgiparams{'ROUTES_PUSH'} ne ''){
        @temp = split(/\n/,$cgiparams{'ROUTES_PUSH'});
        undef $vpnsettings{'ROUTES_PUSH'};
-       
+
        foreach my $tmpip (@temp)
        {
                s/^\s+//g; s/\s+$//g;
-               
+
                if ($tmpip)
                {
-                       $tmpip=~s/\s*$//g; 
+                       $tmpip=~s/\s*$//g;
                        unless (&General::validipandmask($tmpip)) {
                                $errormessage = "$tmpip ".$Lang::tr{'ovpn errmsg invalid ip or mask'};
                                goto ADV_ERROR;
                        }
                        my ($ip, $cidr) = split("\/",&General::ipcidr2msk($tmpip));
-                       
+
                        if ($ip eq $netsettings{'GREEN_NETADDRESS'} && $cidr eq $netsettings{'GREEN_NETMASK'}) {
                                $errormessage = $Lang::tr{'ovpn errmsg green already pushed'};
                                goto ADV_ERROR;
                        }
-# a.marx ccd                   
+# a.marx ccd
                        my %ccdroutehash=();
                        &General::readhasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
                        foreach my $key (keys %ccdroutehash) {
-                               foreach my $i (1 .. $#{$ccdroutehash{$key}}) { 
+                               foreach my $i (1 .. $#{$ccdroutehash{$key}}) {
                                        if ( $ip."/".$cidr eq $ccdroutehash{$key}[$i] ){
                                                $errormessage="Route $ip\/$cidr ".$Lang::tr{'ccd err inuse'}." $ccdroutehash{$key}[0]" ;
                                                goto ADV_ERROR;
@@ -886,9 +885,9 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}) {
                                        }
                                }
                        }
-                       
+
 # ccd end
-                       
+
                        $vpnsettings{'ROUTES_PUSH'} .= $tmpip."\n";
                }
        }
@@ -904,20 +903,20 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}) {
         goto ADV_ERROR;
     }
     if ($cgiparams{'KEEPALIVE_1'} ne '') {
-       if ($cgiparams{'KEEPALIVE_1'} !~ /^[0-9]+$/) { 
+       if ($cgiparams{'KEEPALIVE_1'} !~ /^[0-9]+$/) {
            $errormessage = $Lang::tr{'invalid input for keepalive 1'};
         goto ADV_ERROR;
        }
     }
     if ($cgiparams{'KEEPALIVE_2'} ne ''){
-       if ($cgiparams{'KEEPALIVE_2'} !~ /^[0-9]+$/) { 
+       if ($cgiparams{'KEEPALIVE_2'} !~ /^[0-9]+$/) {
            $errormessage = $Lang::tr{'invalid input for keepalive 2'};
         goto ADV_ERROR;
        }
     }
     if ($cgiparams{'KEEPALIVE_2'} < ($cgiparams{'KEEPALIVE_1'} * 2)){
         $errormessage = $Lang::tr{'invalid input for keepalive 1:2'};
-        goto ADV_ERROR;        
+        goto ADV_ERROR;
     }
     &General::writehash("${General::swroot}/ovpn/settings", \%vpnsettings);
     &writeserverconf();#hier ok
@@ -936,62 +935,62 @@ my $ovsubnet =  "$ovsubnettemp[0].$ovsubnettemp[1].$ovsubnettemp[2]";
 my $tunmtu =  '';
 
 unless(-d "${General::swroot}/ovpn/n2nconf/"){mkdir "${General::swroot}/ovpn/n2nconf", 0755 or die "Unable to create dir $!";}
-unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}", 0770 or die "Unable to create dir $!";}   
+unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}", 0770 or die "Unable to create dir $!";}
 
   open(SERVERCONF,    ">${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Unable to open ${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf: $!";
-  
+
   flock SERVERCONF, 2;
-  print SERVERCONF "# IPFire n2n Open VPN Server Config by ummeegge und m.a.d\n"; 
-  print SERVERCONF "\n"; 
+  print SERVERCONF "# IPFire n2n Open VPN Server Config by ummeegge und m.a.d\n";
+  print SERVERCONF "\n";
   print SERVERCONF "# User Security\n";
   print SERVERCONF "user nobody\n";
   print SERVERCONF "group nobody\n";
   print SERVERCONF "persist-tun\n";
   print SERVERCONF "persist-key\n";
   print SERVERCONF "script-security 2\n";
-  print SERVERCONF "# IP/DNS for remote Server Gateway\n"; 
+  print SERVERCONF "# IP/DNS for remote Server Gateway\n";
 
   if ($cgiparams{'REMOTE'} ne '') {
   print SERVERCONF "remote $cgiparams{'REMOTE'}\n";
   }
 
   print SERVERCONF "float\n";
-  print SERVERCONF "# IP adresses of the VPN Subnet\n"; 
-  print SERVERCONF "ifconfig $ovsubnet.1 $ovsubnet.2\n"; 
-  print SERVERCONF "# Client Gateway Network\n"; 
+  print SERVERCONF "# IP adresses of the VPN Subnet\n";
+  print SERVERCONF "ifconfig $ovsubnet.1 $ovsubnet.2\n";
+  print SERVERCONF "# Client Gateway Network\n";
   print SERVERCONF "route $remsubnet[0] $remsubnet[1]\n";
   print SERVERCONF "up \"/etc/init.d/static-routes start\"\n";
-  print SERVERCONF "# tun Device\n"; 
-  print SERVERCONF "dev tun\n"; 
+  print SERVERCONF "# tun Device\n";
+  print SERVERCONF "dev tun\n";
   print SERVERCONF "#Logfile for statistics\n";
   print SERVERCONF "status-version 1\n";
   print SERVERCONF "status /var/run/openvpn/$cgiparams{'NAME'}-n2n 10\n";
-  print SERVERCONF "# Port and Protokol\n"; 
-  print SERVERCONF "port $cgiparams{'DEST_PORT'}\n"; 
+  print SERVERCONF "# Port and Protokol\n";
+  print SERVERCONF "port $cgiparams{'DEST_PORT'}\n";
 
   if ($cgiparams{'PROTOCOL'} eq 'tcp') {
-  print SERVERCONF "proto tcp-server\n";
+  print SERVERCONF "proto tcp4-server\n";
   print SERVERCONF "# Packet size\n";
   if ($cgiparams{'MTU'} eq '') {$tunmtu = '1400'} else {$tunmtu = $cgiparams{'MTU'}};
   print SERVERCONF "tun-mtu $tunmtu\n";
   }
-  
+
   if ($cgiparams{'PROTOCOL'} eq 'udp') {
-  print SERVERCONF "proto udp\n"; 
+  print SERVERCONF "proto udp4\n";
   print SERVERCONF "# Paketsize\n";
   if ($cgiparams{'MTU'} eq '') {$tunmtu = '1500'} else {$tunmtu = $cgiparams{'MTU'}};
   print SERVERCONF "tun-mtu $tunmtu\n";
-  if ($cgiparams{'FRAGMENT'} ne '') {print SERVERCONF "fragment $cgiparams{'FRAGMENT'}\n";} 
+  if ($cgiparams{'FRAGMENT'} ne '') {print SERVERCONF "fragment $cgiparams{'FRAGMENT'}\n";}
   if ($cgiparams{'MSSFIX'} eq 'on') {print SERVERCONF "mssfix\n"; } else { print SERVERCONF "mssfix 0\n" };
   }
 
-  print SERVERCONF "# Auth. Server\n"; 
-  print SERVERCONF "tls-server\n"; 
-  print SERVERCONF "ca ${General::swroot}/ovpn/ca/cacert.pem\n"; 
-  print SERVERCONF "cert ${General::swroot}/ovpn/certs/servercert.pem\n"; 
-  print SERVERCONF "key ${General::swroot}/ovpn/certs/serverkey.pem\n"; 
-  print SERVERCONF "dh ${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}\n";
-  print SERVERCONF "# Cipher\n"; 
+  print SERVERCONF "# Auth. Server\n";
+  print SERVERCONF "tls-server\n";
+  print SERVERCONF "ca ${General::swroot}/ovpn/ca/cacert.pem\n";
+  print SERVERCONF "cert ${General::swroot}/ovpn/certs/servercert.pem\n";
+  print SERVERCONF "key ${General::swroot}/ovpn/certs/serverkey.pem\n";
+  print SERVERCONF "dh $dhparameter\n";
+  print SERVERCONF "# Cipher\n";
   print SERVERCONF "cipher $cgiparams{'DCIPHER'}\n";
 
   # If GCM cipher is used, do not use --auth
@@ -1012,14 +1011,14 @@ unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General
    print SERVERCONF "# Enable Compression\n";
    print SERVERCONF "comp-lzo\n";
      }
-  print SERVERCONF "# Debug Level\n"; 
-  print SERVERCONF "verb 3\n"; 
-  print SERVERCONF "# Tunnel check\n"; 
-  print SERVERCONF "keepalive 10 60\n"; 
-  print SERVERCONF "# Start as daemon\n"; 
-  print SERVERCONF "daemon $cgiparams{'NAME'}n2n\n"; 
-  print SERVERCONF "writepid /var/run/$cgiparams{'NAME'}n2n.pid\n"; 
-  print SERVERCONF "# Activate Management Interface and Port\n"; 
+  print SERVERCONF "# Debug Level\n";
+  print SERVERCONF "verb 3\n";
+  print SERVERCONF "# Tunnel check\n";
+  print SERVERCONF "keepalive 10 60\n";
+  print SERVERCONF "# Start as daemon\n";
+  print SERVERCONF "daemon $cgiparams{'NAME'}n2n\n";
+  print SERVERCONF "writepid /var/run/$cgiparams{'NAME'}n2n.pid\n";
+  print SERVERCONF "# Activate Management Interface and Port\n";
   if ($cgiparams{'OVPN_MGMT'} eq '') {print SERVERCONF "management localhost $cgiparams{'DEST_PORT'}\n"}
   else {print SERVERCONF "management localhost $cgiparams{'OVPN_MGMT'}\n"};
   close(SERVERCONF);
@@ -1037,46 +1036,46 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq 'net' &&
         my $ovsubnet =  "$ovsubnettemp[0].$ovsubnettemp[1].$ovsubnettemp[2]";
         my @remsubnet =  split(/\//,$cgiparams{'REMOTE_SUBNET'});
         my $tunmtu =  '';
-                   
+
 unless(-d "${General::swroot}/ovpn/n2nconf/"){mkdir "${General::swroot}/ovpn/n2nconf", 0755 or die "Unable to create dir $!";}
 unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}", 0770 or die "Unable to create dir $!";}
-  
+
   open(CLIENTCONF,    ">${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Unable to open ${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf: $!";
-  
+
   flock CLIENTCONF, 2;
   print CLIENTCONF "# IPFire rewritten n2n Open VPN Client Config by ummeegge und m.a.d\n";
-  print CLIENTCONF "#\n"; 
+  print CLIENTCONF "#\n";
   print CLIENTCONF "# User Security\n";
   print CLIENTCONF "user nobody\n";
   print CLIENTCONF "group nobody\n";
   print CLIENTCONF "persist-tun\n";
   print CLIENTCONF "persist-key\n";
   print CLIENTCONF "script-security 2\n";
-  print CLIENTCONF "# IP/DNS for remote Server Gateway\n"; 
+  print CLIENTCONF "# IP/DNS for remote Server Gateway\n";
   print CLIENTCONF "remote $cgiparams{'REMOTE'}\n";
   print CLIENTCONF "float\n";
-  print CLIENTCONF "# IP adresses of the VPN Subnet\n"; 
-  print CLIENTCONF "ifconfig $ovsubnet.2 $ovsubnet.1\n"; 
-  print CLIENTCONF "# Server Gateway Network\n"; 
-  print CLIENTCONF "route $remsubnet[0] $remsubnet[1]\n"; 
+  print CLIENTCONF "# IP adresses of the VPN Subnet\n";
+  print CLIENTCONF "ifconfig $ovsubnet.2 $ovsubnet.1\n";
+  print CLIENTCONF "# Server Gateway Network\n";
+  print CLIENTCONF "route $remsubnet[0] $remsubnet[1]\n";
   print CLIENTCONF "up \"/etc/init.d/static-routes start\"\n";
-  print CLIENTCONF "# tun Device\n"; 
-  print CLIENTCONF "dev tun\n"; 
+  print CLIENTCONF "# tun Device\n";
+  print CLIENTCONF "dev tun\n";
   print CLIENTCONF "#Logfile for statistics\n";
   print CLIENTCONF "status-version 1\n";
   print CLIENTCONF "status /var/run/openvpn/$cgiparams{'NAME'}-n2n 10\n";
-  print CLIENTCONF "# Port and Protokol\n"; 
-  print CLIENTCONF "port $cgiparams{'DEST_PORT'}\n"; 
+  print CLIENTCONF "# Port and Protokol\n";
+  print CLIENTCONF "port $cgiparams{'DEST_PORT'}\n";
 
   if ($cgiparams{'PROTOCOL'} eq 'tcp') {
-  print CLIENTCONF "proto tcp-client\n";
+  print CLIENTCONF "proto tcp4-client\n";
   print CLIENTCONF "# Packet size\n";
   if ($cgiparams{'MTU'} eq '') {$tunmtu = '1400'} else {$tunmtu = $cgiparams{'MTU'}};
   print CLIENTCONF "tun-mtu $tunmtu\n";
   }
-  
+
   if ($cgiparams{'PROTOCOL'} eq 'udp') {
-  print CLIENTCONF "proto udp\n"; 
+  print CLIENTCONF "proto udp4\n";
   print CLIENTCONF "# Paketsize\n";
   if ($cgiparams{'MTU'} eq '') {$tunmtu = '1500'} else {$tunmtu = $cgiparams{'MTU'}};
   print CLIENTCONF "tun-mtu $tunmtu\n";
@@ -1093,9 +1092,9 @@ unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General
   } else {
        print CLIENTCONF "remote-cert-tls server\n";
   }
-  print CLIENTCONF "# Auth. Client\n"; 
-  print CLIENTCONF "tls-client\n"; 
-  print CLIENTCONF "# Cipher\n"; 
+  print CLIENTCONF "# Auth. Client\n";
+  print CLIENTCONF "tls-client\n";
+  print CLIENTCONF "# Cipher\n";
   print CLIENTCONF "cipher $cgiparams{'DCIPHER'}\n";
   print CLIENTCONF "pkcs12 ${General::swroot}/ovpn/certs/$cgiparams{'NAME'}.p12\r\n";
 
@@ -1117,16 +1116,19 @@ unless(-d "${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}"){mkdir "${General
    print CLIENTCONF "# Enable Compression\n";
    print CLIENTCONF "comp-lzo\n";
   }
-  print CLIENTCONF "# Debug Level\n"; 
-  print CLIENTCONF "verb 3\n"; 
-  print CLIENTCONF "# Tunnel check\n"; 
-  print CLIENTCONF "keepalive 10 60\n"; 
-  print CLIENTCONF "# Start as daemon\n"; 
+  print CLIENTCONF "# Debug Level\n";
+  print CLIENTCONF "verb 3\n";
+  print CLIENTCONF "# Tunnel check\n";
+  print CLIENTCONF "keepalive 10 60\n";
+  print CLIENTCONF "# Start as daemon\n";
   print CLIENTCONF "daemon $cgiparams{'NAME'}n2n\n";
-  print CLIENTCONF "writepid /var/run/$cgiparams{'NAME'}n2n.pid\n"; 
-  print CLIENTCONF "# Activate Management Interface and Port\n"; 
+  print CLIENTCONF "writepid /var/run/$cgiparams{'NAME'}n2n.pid\n";
+  print CLIENTCONF "# Activate Management Interface and Port\n";
   if ($cgiparams{'OVPN_MGMT'} eq '') {print CLIENTCONF "management localhost $cgiparams{'DEST_PORT'}\n"}
   else {print CLIENTCONF "management localhost $cgiparams{'OVPN_MGMT'}\n"};
+  if (&iscertlegacy("${General::swroot}/ovpn/certs/$cgiparams{'NAME'}")) {
+       print CLIENTCONF "providers legacy default\n";
+  }
   close(CLIENTCONF);
 
 }
@@ -1151,26 +1153,26 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq '' && $cg
                        goto SETTINGS_ERROR;
     }
     my @tmpovpnsubnet = split("\/",$cgiparams{'DOVPN_SUBNET'});
-    
-    if (&General::IpInSubnet ( $netsettings{'RED_ADDRESS'}, 
+
+    if (&General::IpInSubnet ( $netsettings{'RED_ADDRESS'},
        $tmpovpnsubnet[0], $tmpovpnsubnet[1])) {
        $errormessage = "$Lang::tr{'ovpn subnet overlap'} IPFire RED Network $netsettings{'RED_ADDRESS'}";
        goto SETTINGS_ERROR;
     }
-    
-    if (&General::IpInSubnet ( $netsettings{'GREEN_ADDRESS'}, 
+
+    if (&General::IpInSubnet ( $netsettings{'GREEN_ADDRESS'},
        $tmpovpnsubnet[0], $tmpovpnsubnet[1])) {
         $errormessage = "$Lang::tr{'ovpn subnet overlap'} IPFire Green Network $netsettings{'GREEN_ADDRESS'}";
         goto SETTINGS_ERROR;
     }
 
-    if (&General::IpInSubnet ( $netsettings{'BLUE_ADDRESS'}, 
+    if (&General::IpInSubnet ( $netsettings{'BLUE_ADDRESS'},
        $tmpovpnsubnet[0], $tmpovpnsubnet[1])) {
        $errormessage = "$Lang::tr{'ovpn subnet overlap'} IPFire Blue Network $netsettings{'BLUE_ADDRESS'}";
        goto SETTINGS_ERROR;
     }
-    
-    if (&General::IpInSubnet ( $netsettings{'ORANGE_ADDRESS'}, 
+
+    if (&General::IpInSubnet ( $netsettings{'ORANGE_ADDRESS'},
        $tmpovpnsubnet[0], $tmpovpnsubnet[1])) {
        $errormessage = "$Lang::tr{'ovpn subnet overlap'} IPFire Orange Network $netsettings{'ORANGE_ADDRESS'}";
        goto SETTINGS_ERROR;
@@ -1181,10 +1183,10 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq '' && $cg
        chomp($_);
        my @tempalias = split(/\,/,$_);
        if ($tempalias[1] eq 'on') {
-           if (&General::IpInSubnet ($tempalias[0] , 
+           if (&General::IpInSubnet ($tempalias[0] ,
                $tmpovpnsubnet[0], $tmpovpnsubnet[1])) {
                $errormessage = "$Lang::tr{'ovpn subnet overlap'} IPFire alias entry $tempalias[0]";
-           }           
+           }
        }
     }
     close(ALIASES);
@@ -1199,7 +1201,7 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq '' && $cg
         $errormessage = $Lang::tr{'invalid mtu input'};
         goto SETTINGS_ERROR;
     }
-    
+
     unless (&General::validport($cgiparams{'DDEST_PORT'})) {
        $errormessage = $Lang::tr{'invalid port'};
        goto SETTINGS_ERROR;
@@ -1250,7 +1252,7 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq '' && $cg
          unlink("${General::swroot}/ovpn/enable");
   }
 
-#new settings for daemon    
+#new settings for daemon
     &General::writehash("${General::swroot}/ovpn/settings", \%vpnsettings);
     &writeserverconf();#hier ok
 SETTINGS_ERROR:
@@ -1348,102 +1350,6 @@ END
     exit (0);
 
 ###
-### Generate DH key step 2
-###
-} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'generate dh key'} && $cgiparams{'AREUSURE'} eq 'yes') {
-    # Delete if old key exists
-    if (-f "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}") {
-        unlink "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}";
-       }
-       # Create Diffie Hellmann Parameter
-       # The system call is safe, because all arguments are passed as an array.
-       system("/usr/bin/openssl", "dhparam", "-out", "${General::swroot}/ovpn/ca/dh1024.pem", "$cgiparams{'DHLENGHT'}");
-       if ($?) {
-               $errormessage = "$Lang::tr{'openssl produced an error'}: $?";
-               unlink ("${General::swroot}/ovpn/ca/dh1024.pem");
-       }
-
-###
-### Generate DH key step 1
-###
-} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'generate dh key'}) {
-       &Header::showhttpheaders();
-       &Header::openpage($Lang::tr{'ovpn'}, 1, '');
-       &Header::openbigbox('100%', 'LEFT', '', '');
-       &Header::openbox('100%', 'LEFT', "$Lang::tr{'gen dh'}:");
-       print <<END;
-       <table width='100%'>
-       <tr>
-               <td width='20%'> </td> <td width='15%'></td> <td width='65%'></td>
-       </tr>
-       <tr>
-               <td class='base'>$Lang::tr{'ovpn dh'}:</td>
-               <td align='center'>
-               <form method='post'><input type='hidden' name='AREUSURE' value='yes' />
-               <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
-                       <select name='DHLENGHT'>
-                               <option value='2048' $selected{'DHLENGHT'}{'2048'}>2048 $Lang::tr{'bit'}</option>
-                               <option value='3072' $selected{'DHLENGHT'}{'3072'}>3072 $Lang::tr{'bit'}</option>
-                               <option value='4096' $selected{'DHLENGHT'}{'4096'}>4096 $Lang::tr{'bit'}</option>
-                       </select>
-               </td>
-       </tr>
-       <tr><td colspan='4'><br></td></tr>
-       </table>
-       <table width='100%'>
-       <tr>
-               <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}: </font></b>$Lang::tr{'dh key warn'}
-       </tr>
-       <tr>
-               <td class='base'>$Lang::tr{'dh key warn1'}</td>
-       </tr>
-       <tr><td colspan='2'><br></td></tr>
-       <tr>
-               <td align='center'><input type='submit' name='ACTION' value='$Lang::tr{'generate dh key'}' /></td>
-               </form>
-       </tr>
-       </table>
-
-END
-       ;
-       &Header::closebox();
-       print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
-       &Header::closebigbox();
-       &Header::closepage();
-       exit (0);
-
-###
-### Upload DH key
-###
-} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'upload dh key'}) {
-    unless (ref ($cgiparams{'FH'})) {
-         $errormessage = $Lang::tr{'there was no file upload'};
-         goto UPLOADCA_ERROR;
-    }
-    # Move uploaded dh key to a temporary file
-    (my $fh, my $filename) = tempfile( );
-    if (copy ($cgiparams{'FH'}, $fh) != 1) {
-        $errormessage = $!;
-       goto UPLOADCA_ERROR;
-    }
-    my @temp = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "$filename");
-    if ( ! grep(/DH Parameters: \((2048|3072|4096) bit\)/, @temp)) {
-        $errormessage = $Lang::tr{'not a valid dh key'};
-        unlink ($filename);
-        goto UPLOADCA_ERROR;
-    } else {
-       # Delete if old key exists
-       if (-f "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}") {
-               unlink "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}";
-       }
-
-       unless(move($filename, "${General::swroot}/ovpn/ca/$cgiparams{'DH_NAME'}")) {
-               $errormessage = "$Lang::tr{'dh key move failed'}: $!";
-               unlink ($filename);
-               goto UPLOADCA_ERROR;
-       }
-    }
-###
 ### Upload CA Certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'upload ca certificate'}) {
@@ -1552,7 +1458,7 @@ END
        print "Content-Disposition: filename=$cahash{$cgiparams{'KEY'}}[0]cert.pem\r\n\r\n";
 
        my @tmp =  &General::system_output("/usr/bin/openssl", "x509", "-in", "${General::swroot}/ovpn/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem");
-       print "@tmp";
+       print @tmp;
 
        exit(0);
     } else {
@@ -1667,11 +1573,11 @@ END
        print "Content-Disposition: filename=cacert.pem\r\n\r\n";
 
        my @tmp = &General::system_output("/usr/bin/openssl", "x509", "-in", "${General::swroot}/ovpn/ca/cacert.pem");
-       print "@tmp";
+       print @tmp;
 
        exit(0);
     }
-    
+
 ###
 ### Download host certificate
 ###
@@ -1681,7 +1587,7 @@ END
        print "Content-Disposition: filename=servercert.pem\r\n\r\n";
 
        my @tmp = &General::system_output("/usr/bin/openssl", "x509", "-in", "${General::swroot}/ovpn/certs/servercert.pem");
-       print "@tmp";
+       print @tmp;
 
        exit(0);
     }
@@ -1698,7 +1604,7 @@ END
        my @tmp = <FILE>;
        close(FILE);
 
-       print "@tmp";
+       print @tmp;
 
        exit(0);
     }
@@ -1906,7 +1812,7 @@ END
 
        # refresh
        #system ('/bin/touch', "${General::swroot}/ovpn/gencanow");
-       
+
        # Create the CA certificate
        my $pid = open(OPENSSL, "|-");
        $SIG{ALRM} = sub { $errormessage = $Lang::tr{'broken pipe'}; goto ROOTCERT_ERROR;};
@@ -1958,7 +1864,7 @@ END
            }
        } else {        # child
            unless (exec ('/usr/bin/openssl', 'req', '-nodes',
-                       '-newkey', 'rsa:2048',
+                       '-newkey', 'rsa:4096',
                        '-keyout', "${General::swroot}/ovpn/certs/serverkey.pem",
                        '-out', "${General::swroot}/ovpn/certs/serverreq.pem",
                        '-extensions', 'server',
@@ -1971,7 +1877,7 @@ END
                goto ROOTCERT_ERROR;
            }
        }
-       
+
        # Sign the host certificate request
        # This system call is safe, because all argeuments are passed as an array.
        system('/usr/bin/openssl', 'ca', '-days', '999999',
@@ -2004,7 +1910,7 @@ END
            unlink ("${General::swroot}/ovpn/certs/serverkey.pem");
            unlink ("${General::swroot}/ovpn/certs/servercert.pem");
            unlink ("${General::swroot}/ovpn/ca/cacert.pem");
-           unlink ("${General::swroot}/ovpn/crls/cacrl.pem");      
+           unlink ("${General::swroot}/ovpn/crls/cacrl.pem");
            &cleanssldatabase();
            goto ROOTCERT_ERROR;
 #      } else {
@@ -2018,21 +1924,6 @@ END
            &cleanssldatabase();
            goto ROOTCERT_ERROR;
        }
-       # Create Diffie Hellmann Parameter
-       # The system call is safe, because all arguments are passed as an array.
-       system('/usr/bin/openssl', 'dhparam', '-out', "${General::swroot}/ovpn/ca/dh1024.pem", "$cgiparams{'DHLENGHT'}");
-       if ($?) {
-           $errormessage = "$Lang::tr{'openssl produced an error'}: $?";
-           unlink ("${General::swroot}/ovpn/certs/serverkey.pem");
-           unlink ("${General::swroot}/ovpn/certs/servercert.pem");
-           unlink ("${General::swroot}/ovpn/ca/cacert.pem");
-           unlink ("${General::swroot}/ovpn/crls/cacrl.pem");
-           unlink ("${General::swroot}/ovpn/ca/dh1024.pem");
-           &cleanssldatabase();
-           goto ROOTCERT_ERROR;
-#      } else {
-#          &cleanssldatabase();
-       }
        goto ROOTCERT_SUCCESS;
     }
     ROOTCERT_ERROR:
@@ -2069,7 +1960,7 @@ END
            <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_STATE' value='$cgiparams{'ROOTCERT_STATE'}' size='32' /></td>
            <td colspan='2'>&nbsp;</td></tr>
        <tr><td class='base'>$Lang::tr{'country'}:</td>
-           <td class='base'><select name='ROOTCERT_COUNTRY'> 
+           <td class='base'><select name='ROOTCERT_COUNTRY'>
 
 END
        ;
@@ -2082,31 +1973,13 @@ END
        }
        print <<END;
            </select></td>
-       <tr><td class='base'>$Lang::tr{'ovpn dh'}:</td>
-               <td class='base'><select name='DHLENGHT'>
-                               <option value='2048' $selected{'DHLENGHT'}{'2048'}>2048 $Lang::tr{'bit'}</option>
-                               <option value='3072' $selected{'DHLENGHT'}{'3072'}>3072 $Lang::tr{'bit'}</option>
-                               <option value='4096' $selected{'DHLENGHT'}{'4096'}>4096 $Lang::tr{'bit'}</option>
-                       </select>
-               </td>
-       </tr>
 
        <tr><td>&nbsp;</td>
            <td><input type='submit' name='ACTION' value='$Lang::tr{'generate root/host certificates'}' /></td>
-           <td>&nbsp;</td><td>&nbsp;</td></tr> 
+           <td>&nbsp;</td><td>&nbsp;</td></tr>
        <tr><td class='base' colspan='4' align='left'>
            <img src='/blob.gif' valign='top' alt='*' />&nbsp;$Lang::tr{'required field'}</td></tr>
        <tr><td colspan='2'><br></td></tr>
-       <table width='100%'>
-       <tr>
-               <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}: </font></b>$Lang::tr{'ovpn generating the root and host certificates'}
-               <td class='base'>$Lang::tr{'dh key warn'}</td>
-       </tr>
-       <tr>
-               <td class='base'>$Lang::tr{'dh key warn1'}</td>
-       </tr>
-       <tr><td colspan='2'><br></td></tr>
-       <tr>
        </table>
 
        <table width='100%'>
@@ -2149,7 +2022,7 @@ END
 ###
 
 }elsif ($cgiparams{'ACTION'} eq $Lang::tr{'toggle enable disable'}) {
-    
+
     &General::readhash("${General::swroot}/ovpn/settings", \%vpnsettings);
     &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
     my $n2nactive = '';
@@ -2158,7 +2031,7 @@ END
     if(grep(/$confighash{$cgiparams{'KEY'}}[1]/, @ps)) {
        $n2nactive = "1";
     }
-    
+
     if ($confighash{$cgiparams{'KEY'}}) {
                if ($confighash{$cgiparams{'KEY'}}[0] eq 'off') {
                        $confighash{$cgiparams{'KEY'}}[0] = 'on';
@@ -2201,19 +2074,19 @@ END
 ###
 
 if ($confighash{$cgiparams{'KEY'}}[3] eq 'net'){
-        
+
         my $zipname = "$confighash{$cgiparams{'KEY'}}[1]-Client.zip";
         my $zippathname = "$zippath$zipname";
-        $clientovpn = "$confighash{$cgiparams{'KEY'}}[1].conf";  
+        $clientovpn = "$confighash{$cgiparams{'KEY'}}[1].conf";
         my @ovsubnettemp =  split(/\./,$confighash{$cgiparams{'KEY'}}[27]);
         my $ovsubnet =  "$ovsubnettemp[0].$ovsubnettemp[1].$ovsubnettemp[2]";
-        my $tunmtu = ''; 
+        my $tunmtu = '';
         my @remsubnet = split(/\//,$confighash{$cgiparams{'KEY'}}[8]);
         my $n2nfragment = '';
-        
+
     open(CLIENTCONF, ">$tempdir/$clientovpn") or die "Unable to open tempfile: $!";
     flock CLIENTCONF, 2;
-    
+
     my $zip = Archive::Zip->new();
    print CLIENTCONF "# IPFire n2n Open VPN Client Config by ummeegge und m.a.d\n";
    print CLIENTCONF "# \n";
@@ -2223,30 +2096,30 @@ if ($confighash{$cgiparams{'KEY'}}[3] eq 'net'){
    print CLIENTCONF "persist-tun\n";
    print CLIENTCONF "persist-key\n";
    print CLIENTCONF "script-security 2\n";
-   print CLIENTCONF "# IP/DNS for remote Server Gateway\n"; 
+   print CLIENTCONF "# IP/DNS for remote Server Gateway\n";
    print CLIENTCONF "remote $vpnsettings{'VPN_IP'}\n";
    print CLIENTCONF "float\n";
-   print CLIENTCONF "# IP adresses of the VPN Subnet\n"; 
-   print CLIENTCONF "ifconfig $ovsubnet.2 $ovsubnet.1\n"; 
-   print CLIENTCONF "# Server Gateway Network\n"; 
+   print CLIENTCONF "# IP adresses of the VPN Subnet\n";
+   print CLIENTCONF "ifconfig $ovsubnet.2 $ovsubnet.1\n";
+   print CLIENTCONF "# Server Gateway Network\n";
    print CLIENTCONF "route $remsubnet[0] $remsubnet[1]\n";
-   print CLIENTCONF "# tun Device\n"; 
-   print CLIENTCONF "dev tun\n"; 
+   print CLIENTCONF "# tun Device\n";
+   print CLIENTCONF "dev tun\n";
    print CLIENTCONF "#Logfile for statistics\n";
    print CLIENTCONF "status-version 1\n";
    print CLIENTCONF "status /var/run/openvpn/$cgiparams{'NAME'}-n2n 10\n";
-   print CLIENTCONF "# Port and Protokoll\n"; 
-   print CLIENTCONF "port $confighash{$cgiparams{'KEY'}}[29]\n"; 
-   
+   print CLIENTCONF "# Port and Protokoll\n";
+   print CLIENTCONF "port $confighash{$cgiparams{'KEY'}}[29]\n";
+
    if ($confighash{$cgiparams{'KEY'}}[28] eq 'tcp') {
-   print CLIENTCONF "proto tcp-client\n";
+   print CLIENTCONF "proto tcp4-client\n";
    print CLIENTCONF "# Packet size\n";
    if ($confighash{$cgiparams{'KEY'}}[31] eq '') {$tunmtu = '1400'} else {$tunmtu = $confighash{$cgiparams{'KEY'}}[31]};
    print CLIENTCONF "tun-mtu $tunmtu\n";
    }
-  
+
    if ($confighash{$cgiparams{'KEY'}}[28] eq 'udp') {
-   print CLIENTCONF "proto udp\n"; 
+   print CLIENTCONF "proto udp4\n";
    print CLIENTCONF "# Paketsize\n";
    if ($confighash{$cgiparams{'KEY'}}[31] eq '') {$tunmtu = '1500'} else {$tunmtu = $confighash{$cgiparams{'KEY'}}[31]};
    print CLIENTCONF "tun-mtu $tunmtu\n";
@@ -2262,11 +2135,11 @@ if ($confighash{$cgiparams{'KEY'}}[3] eq 'net'){
    } else {
                print CLIENTCONF "remote-cert-tls server\n";
    }
-   print CLIENTCONF "# Auth. Client\n"; 
-   print CLIENTCONF "tls-client\n"; 
+   print CLIENTCONF "# Auth. Client\n";
+   print CLIENTCONF "tls-client\n";
    print CLIENTCONF "# Cipher\n";
    print CLIENTCONF "cipher $confighash{$cgiparams{'KEY'}}[40]\n";
-    if ($confighash{$cgiparams{'KEY'}}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12") { 
+    if ($confighash{$cgiparams{'KEY'}}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12") {
         print CLIENTCONF "pkcs12 ${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12\r\n";
      $zip->addFile( "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12", "$confighash{$cgiparams{'KEY'}}[1].p12") or die "Can't add file $confighash{$cgiparams{'KEY'}}[1].p12\n";
    }
@@ -2286,21 +2159,25 @@ if ($confighash{$cgiparams{'KEY'}}[3] eq 'net'){
    print CLIENTCONF "# Enable Compression\n";
    print CLIENTCONF "comp-lzo\n";
      }
-   print CLIENTCONF "# Debug Level\n"; 
-   print CLIENTCONF "verb 3\n"; 
-   print CLIENTCONF "# Tunnel check\n"; 
-   print CLIENTCONF "keepalive 10 60\n"; 
-   print CLIENTCONF "# Start as daemon\n"; 
-   print CLIENTCONF "daemon $confighash{$cgiparams{'KEY'}}[1]n2n\n"; 
-   print CLIENTCONF "writepid /var/run/$confighash{$cgiparams{'KEY'}}[1]n2n.pid\n"; 
-   print CLIENTCONF "# Activate Management Interface and Port\n"; 
+   print CLIENTCONF "# Debug Level\n";
+   print CLIENTCONF "verb 3\n";
+   print CLIENTCONF "# Tunnel check\n";
+   print CLIENTCONF "keepalive 10 60\n";
+   print CLIENTCONF "# Start as daemon\n";
+   print CLIENTCONF "daemon $confighash{$cgiparams{'KEY'}}[1]n2n\n";
+   print CLIENTCONF "writepid /var/run/$confighash{$cgiparams{'KEY'}}[1]n2n.pid\n";
+   print CLIENTCONF "# Activate Management Interface and Port\n";
    if ($confighash{$cgiparams{'KEY'}}[22] eq '') {print CLIENTCONF "management localhost $confighash{$cgiparams{'KEY'}}[29]\n"}
     else {print CLIENTCONF "management localhost $confighash{$cgiparams{'KEY'}}[22]\n"};
    print CLIENTCONF "# remsub $confighash{$cgiparams{'KEY'}}[11]\n";
-  
+  if (&iscertlegacy("${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]")) {
+       print CLIENTCONF "providers legacy default\n";
+  }
+
+
 
     close(CLIENTCONF);
-        
+
     $zip->addFile( "$tempdir/$clientovpn", $clientovpn) or die "Can't add file $clientovpn\n";
     my $status = $zip->writeToFileNamed($zippathname);
 
@@ -2320,12 +2197,12 @@ else
 ###
 # m.a.d net2net
 ###
-  
+
     open(CLIENTCONF, ">$tempdir/$clientovpn") or die "Unable to open tempfile: $!";
     flock CLIENTCONF, 2;
-    
+
     my $zip = Archive::Zip->new();
-    
+
     print CLIENTCONF "#OpenVPN Client conf\r\n";
     print CLIENTCONF "tls-client\r\n";
     print CLIENTCONF "client\r\n";
@@ -2336,29 +2213,29 @@ else
 
     if ( $vpnsettings{'ENABLED'} eq 'on'){
        print CLIENTCONF "remote $vpnsettings{'VPN_IP'} $vpnsettings{'DDEST_PORT'}\r\n";
-       if ( $vpnsettings{'ENABLED_BLUE'} eq 'on' && (&haveBlueNet())){ 
-           print CLIENTCONF "#Coment the above line and uncoment the next line, if you want to connect on the Blue interface\r\n";     
+       if ( $vpnsettings{'ENABLED_BLUE'} eq 'on' && (&haveBlueNet())){
+           print CLIENTCONF "#comment the above line and uncomment the next line, if you want to connect on the Blue interface\r\n";
            print CLIENTCONF ";remote $netsettings{'BLUE_ADDRESS'} $vpnsettings{'DDEST_PORT'}\r\n";
        }
        if ( $vpnsettings{'ENABLED_ORANGE'} eq 'on' && (&haveOrangeNet())){
-           print CLIENTCONF "#Coment the above line and uncoment the next line, if you want to connect on the Orange interface\r\n";           
+           print CLIENTCONF "#comment the above line and uncomment the next line, if you want to connect on the Orange interface\r\n";
            print CLIENTCONF ";remote $netsettings{'ORANGE_ADDRESS'} $vpnsettings{'DDEST_PORT'}\r\n";
        }
     } elsif ( $vpnsettings{'ENABLED_BLUE'} eq 'on' && (&haveBlueNet())){
        print CLIENTCONF "remote $netsettings{'BLUE_ADDRESS'} $vpnsettings{'DDEST_PORT'}\r\n";
        if ( $vpnsettings{'ENABLED_ORANGE'} eq 'on' && (&haveOrangeNet())){
-           print CLIENTCONF "#Coment the above line and uncoment the next line, if you want to connect on the Orange interface\r\n";           
+           print CLIENTCONF "#comment the above line and uncomment the next line, if you want to connect on the Orange interface\r\n";
            print CLIENTCONF ";remote $netsettings{'ORANGE_ADDRESS'} $vpnsettings{'DDEST_PORT'}\r\n";
        }
     } elsif ( $vpnsettings{'ENABLED_ORANGE'} eq 'on' && (&haveOrangeNet())){
        print CLIENTCONF "remote $netsettings{'ORANGE_ADDRESS'} $vpnsettings{'DDEST_PORT'}\r\n";
     }
-                       
+
     my $file_crt = new File::Temp( UNLINK => 1 );
     my $file_key = new File::Temp( UNLINK => 1 );
     my $include_certs = 0;
 
-    if ($confighash{$cgiparams{'KEY'}}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12") { 
+    if ($confighash{$cgiparams{'KEY'}}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12") {
        if ($cgiparams{'MODE'} eq 'insecure') {
                $include_certs = 1;
 
@@ -2368,10 +2245,18 @@ else
 
                # Extract the certificate
                # This system call is safe, because all arguments are passed as an array.
-               system('/usr/bin/openssl', 'pkcs12', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
-                       '-clcerts', '-nokeys', '-nodes', '-out', "$file_crt" , '-passin', 'pass:');
-               if ($?) {
-                       die "openssl error: $?";
+               if (&iscertlegacy("${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]")) {
+                       system('/usr/bin/openssl', 'pkcs12', '-legacy', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
+                               '-clcerts', '-nokeys', '-nodes', '-out', "$file_crt" , '-passin', 'pass:');
+                       if ($?) {
+                               die "openssl error: $?";
+                       }
+               } else {
+                       system('/usr/bin/openssl', 'pkcs12', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
+                               '-clcerts', '-nokeys', '-nodes', '-out', "$file_crt" , '-passin', 'pass:');
+                       if ($?) {
+                               die "openssl error: $?";
+                       }
                }
 
                $zip->addFile("$file_crt", "$confighash{$cgiparams{'KEY'}}[1].pem") or die;
@@ -2379,10 +2264,18 @@ else
 
                # Extract the key
                # This system call is safe, because all arguments are passed as an array.
-               system('/usr/bin/openssl', 'pkcs12', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
-                       '-nocerts', '-nodes', '-out', "$file_key", '-passin', 'pass:');
-               if ($?) {
-                       die "openssl error: $?";
+               if (&iscertlegacy("${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]")) {
+                       system('/usr/bin/openssl', 'pkcs12', '-legacy', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
+                               '-nocerts', '-nodes', '-out', "$file_key", '-passin', 'pass:');
+                       if ($?) {
+                               die "openssl error: $?";
+                       }
+               } else {
+                       system('/usr/bin/openssl', 'pkcs12', '-in', "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1].p12",
+                               '-nocerts', '-nodes', '-out', "$file_key", '-passin', 'pass:');
+                       if ($?) {
+                               die "openssl error: $?";
+                       }
                }
 
                $zip->addFile("$file_key", "$confighash{$cgiparams{'KEY'}}[1].key") or die;
@@ -2396,7 +2289,7 @@ else
        print CLIENTCONF "cert $confighash{$cgiparams{'KEY'}}[1]cert.pem\r\n";
        print CLIENTCONF "key $confighash{$cgiparams{'KEY'}}[1].key\r\n";
        $zip->addFile( "${General::swroot}/ovpn/ca/cacert.pem", "cacert.pem")  or die "Can't add file cacert.pem\n";
-       $zip->addFile( "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem", "$confighash{$cgiparams{'KEY'}}[1]cert.pem") or die "Can't add file $confighash{$cgiparams{'KEY'}}[1]cert.pem\n";    
+       $zip->addFile( "${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem", "$confighash{$cgiparams{'KEY'}}[1]cert.pem") or die "Can't add file $confighash{$cgiparams{'KEY'}}[1]cert.pem\n";
     }
     print CLIENTCONF "cipher $vpnsettings{DCIPHER}\r\n";
        print CLIENTCONF "auth $vpnsettings{'DAUTH'}\r\n";
@@ -2431,6 +2324,21 @@ else
        print CLIENTCONF "fragment $vpnsettings{'FRAGMENT'}\r\n";
     }
 
+    # Disable storing any credentials in memory
+    print CLIENTCONF "auth-nocache\r\n";
+
+    # Set a fake user name for authentication
+    print CLIENTCONF "auth-token-user USER\r\n";
+    print CLIENTCONF "auth-token TOTP\r\n";
+
+    # If the server is asking for TOTP this needs to happen interactively
+    print CLIENTCONF "auth-retry interact\r\n";
+
+    # Add provider line if certificate is legacy type
+    if (&iscertlegacy("${General::swroot}/ovpn/certs/$confighash{$cgiparams{'KEY'}}[1]")) {
+       print CLIENTCONF "providers legacy default\r\n";
+    }
+
     if ($include_certs) {
        print CLIENTCONF "\r\n";
 
@@ -2493,7 +2401,7 @@ else
        close (LCC);
     }
     close(CLIENTCONF);
-        
+
     $zip->addFile( "$tempdir/$clientovpn", $clientovpn) or die "Can't add file $clientovpn\n";
     my $status = $zip->writeToFileNamed($zippathname);
 
@@ -2504,9 +2412,9 @@ else
     print @fileholder;
     exit (0);
    }
-   
-   
-   
+
+
+
 ###
 ### Remove connection
 ###
@@ -2548,7 +2456,7 @@ else
                {
                        unlink "${General::swroot}/ovpn/ccd/$confighash{$cgiparams{'KEY'}}[2]";
                }
-       
+
                &General::readhasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
                foreach my $key (keys %ccdroutehash) {
                        if ($ccdroutehash{$key}[0] eq $confighash{$cgiparams{'KEY'}}[1]){
@@ -2556,7 +2464,7 @@ else
                        }
                }
                &General::writehasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
-       
+
                &General::readhasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
                foreach my $key (keys %ccdroute2hash) {
                        if ($ccdroute2hash{$key}[0] eq $confighash{$cgiparams{'KEY'}}[1]){
@@ -2593,7 +2501,7 @@ else
     my @tmp = <FILE>;
     close(FILE);
 
-    print "@tmp";
+    print @tmp;
     exit (0);
 
 ###
@@ -2617,19 +2525,58 @@ else
        exit(0);
     }
 
+###
+### Display OTP QRCode
+###
+} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'show otp qrcode'}) {
+   &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
+
+   my $qrcode = Imager::QRCode->new(
+      size          => 6,
+      margin        => 0,
+      version       => 0,
+      level         => 'M',
+      mode          => '8-bit',
+      casesensitive => 1,
+      lightcolor    => Imager::Color->new(255, 255, 255),
+      darkcolor     => Imager::Color->new(0, 0, 0),
+   );
+   my $cn = uri_encode($confighash{$cgiparams{'KEY'}}[2]);
+   my $secret = encode_base32(pack('H*', $confighash{$cgiparams{'KEY'}}[44]));
+   my $issuer = uri_encode("$mainsettings{'HOSTNAME'}.$mainsettings{'DOMAINNAME'}");
+   my $qrcodeimg = $qrcode->plot("otpauth://totp/$cn?secret=$secret&issuer=$issuer");
+   my $qrcodeimgdata;
+   $qrcodeimg->write(data => \$qrcodeimgdata, type=> 'png')
+      or die $qrcodeimg->errstr;
+   $qrcodeimgdata = encode_base64($qrcodeimgdata, '');
+
+   &Header::showhttpheaders();
+   &Header::openpage($Lang::tr{'ovpn'}, 1, '');
+   &Header::openbigbox('100%', 'LEFT', '', '');
+   &Header::openbox('100%', 'LEFT', "$Lang::tr{'otp qrcode'}:");
+   print <<END;
+$Lang::tr{'secret'}:&nbsp;$secret</br></br>
+<img alt="$Lang::tr{'otp qrcode'}" src="data:image/png;base64,$qrcodeimgdata">
+END
+   &Header::closebox();
+   print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
+   &Header::closebigbox();
+   &Header::closepage();
+   exit(0);
+
 ###
 ### Display Diffie-Hellman key
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'show dh'}) {
 
-    if (! -e "${General::swroot}/ovpn/ca/dh1024.pem") {
+    if (! -e "$dhparameter") {
        $errormessage = $Lang::tr{'not present'};
        } else {
                &Header::showhttpheaders();
                &Header::openpage($Lang::tr{'ovpn'}, 1, '');
                &Header::openbigbox('100%', 'LEFT', '', '');
                &Header::openbox('100%', 'LEFT', "$Lang::tr{'dh'}:");
-               my @output = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "${General::swroot}/ovpn/ca/dh1024.pem");
+               my @output = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "$dhparameter");
                my $output = &Header::cleanhtml(join("", @output) ,"y");
                print "<pre>$output</pre>\n";
                &Header::closebox();
@@ -2699,10 +2646,10 @@ else
     my $disabled;
     &General::readhash("${General::swroot}/ovpn/settings", \%cgiparams);
     read_routepushfile;
-       
-       
+
+
 #    if ($cgiparams{'CLIENT2CLIENT'} eq '') {
-#      $cgiparams{'CLIENT2CLIENT'} =  'on';     
+#      $cgiparams{'CLIENT2CLIENT'} =  'on';
 #    }
 ADV_ERROR:
     if ($cgiparams{'MAX_CLIENTS'} eq '') {
@@ -2748,10 +2695,10 @@ ADV_ERROR:
     $selected{'LOG_VERB'}{'10'} = '';
     $selected{'LOG_VERB'}{'11'} = '';
     $selected{'LOG_VERB'}{$cgiparams{'LOG_VERB'}} = 'SELECTED';
-   
+
     &Header::showhttpheaders();
     &Header::openpage($Lang::tr{'status ovpn'}, 1, '');
-    &Header::openbigbox('100%', 'LEFT', '', $errormessage);    
+    &Header::openbigbox('100%', 'LEFT', '', $errormessage);
     if ($errormessage) {
        &Header::openbox('100%', 'LEFT', $Lang::tr{'error messages'});
        print "<class name='base'>$errormessage\n";
@@ -2767,23 +2714,23 @@ ADV_ERROR:
     </tr>
     <tr>
                <td width='25%'></td> <td width='20%'> </td><td width='25%'> </td><td width='30%'></td>
-    </tr>      
-    <tr>               
+    </tr>
+    <tr>
                <td class='base'>Domain</td>
         <td><input type='TEXT' name='DHCP_DOMAIN' value='$cgiparams{'DHCP_DOMAIN'}' size='30'  /></td>
     </tr>
-    <tr>       
+    <tr>
                <td class='base'>DNS</td>
                <td><input type='TEXT' name='DHCP_DNS' value='$cgiparams{'DHCP_DNS'}' size='30' /></td>
-    </tr>      
-    <tr>       
+    </tr>
+    <tr>
                <td class='base'>WINS</td>
                <td><input type='TEXT' name='DHCP_WINS' value='$cgiparams{'DHCP_WINS'}' size='30' /></td>
        </tr>
     <tr>
                <td colspan='4'><b>$Lang::tr{'ovpn routes push options'}</b></td>
     </tr>
-    <tr>       
+    <tr>
                <td class='base'>$Lang::tr{'ovpn routes push'}</td>
                <td colspan='2'>
                <textarea name='ROUTES_PUSH' cols='26' rows='6' wrap='off'>
@@ -2803,7 +2750,7 @@ print <<END;
 <hr size='1'>
 <table width='100%'>
        <tr>
-               <td class'base'><b>$Lang::tr{'misc-options'}</b></td>
+               <td class='base'><b>$Lang::tr{'misc-options'}</b></td>
        </tr>
 
        <tr>
@@ -2858,7 +2805,7 @@ print <<END;
 <hr size='1'>
 <table width='100%'>
     <tr>
-       <td class'base'><b>$Lang::tr{'log-options'}</b></td>
+       <td class='base'><b>$Lang::tr{'log-options'}</b></td>
     </tr>
     <tr>
        <td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
@@ -2894,14 +2841,14 @@ print"  <br><b><font color='#990000'>$Lang::tr{'attention'}:</b></font><br>
     <td>&nbsp;</td>
     <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'save-adv-options'}' disabled='disabled' /></td>
     <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'cancel-adv-options'}' /></td>
-    <td>&nbsp;</td>    
+    <td>&nbsp;</td>
 </tr>
-</table>    
+</table>
 </form>
 END
-;              
-               
-               
+;
+
+
 }else{
 
        print<<END;
@@ -2910,25 +2857,25 @@ END
     <td>&nbsp;</td>
     <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'save-adv-options'}' /></td>
     <td allign='center'><input type='submit' name='ACTION' value='$Lang::tr{'cancel-adv-options'}' /></td>
-    <td>&nbsp;</td>    
+    <td>&nbsp;</td>
 </tr>
-</table>    
+</table>
 </form>
 END
-;                                 
+;
 }
     &Header::closebox();
 #    print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
     &Header::closebigbox();
     &Header::closepage();
     exit(0);
-       
+
 
 # A.Marx CCD   Add,delete or edit CCD net
 
-} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'ccd net'} || 
-               $cgiparams{'ACTION'} eq $Lang::tr{'ccd add'} ||  
-               $cgiparams{'ACTION'} eq "kill" || 
+} elsif ($cgiparams{'ACTION'} eq $Lang::tr{'ccd net'} ||
+               $cgiparams{'ACTION'} eq $Lang::tr{'ccd add'} ||
+               $cgiparams{'ACTION'} eq "kill" ||
                $cgiparams{'ACTION'} eq "edit" ||
                $cgiparams{'ACTION'} eq 'editsave'){
        &Header::showhttpheaders();
@@ -2938,14 +2885,14 @@ END
        if ($cgiparams{'ACTION'} eq "kill"){
                &delccdnet($cgiparams{'net'});
        }
-       
+
        if ($cgiparams{'ACTION'} eq 'editsave'){
                my ($a,$b) =split (/\|/,$cgiparams{'ccdname'});
                if ( $a ne $b){ &modccdnet($a,$b);}
                $cgiparams{'ccdname'}='';
                $cgiparams{'ccdsubnet'}='';
        }
-       
+
        if ($cgiparams{'ACTION'} eq $Lang::tr{'ccd add'}) {
                &addccdnet($cgiparams{'ccdname'},$cgiparams{'ccdsubnet'});
        }
@@ -2953,10 +2900,10 @@ END
            &Header::openbox('100%', 'LEFT', $Lang::tr{'error messages'});
            print "<class name='base'>$errormessage";
            print "&nbsp;</class>";
-           &Header::closebox();                
+           &Header::closebox();
        }
 if ($cgiparams{'ACTION'} eq "edit"){
-       
+
        &Header::openbox('100%', 'LEFT', $Lang::tr{'ccd modify'});
 
        print <<END;
@@ -2994,7 +2941,7 @@ else{
                <td colspan='4' align='right'><input type='hidden' name='ACTION' value='$Lang::tr{'ccd add'}' /><input type='submit' value='$Lang::tr{'add'}' /><input type='hidden' name='DOVPN_SUBNET' value='$cgiparams{'DOVPN_SUBNET'}'/></td></tr>
                </table></form>
 END
-       
+
        &Header::closebox();
 }
        &Header::openbox('100%', 'LEFT',$Lang::tr{'ccd net'} );
@@ -3002,7 +2949,7 @@ END
                print "<b>$Lang::tr{'attention'}:</b><br>";
                print "$Lang::tr{'ccd noaddnet'}<br><hr>";
        }
-       
+
     print <<END;
     <table width='100%' cellpadding='0' cellspacing='1'>
     <tr>
@@ -3010,8 +2957,8 @@ END
 END
 ;
 }
-       my %ccdconfhash=();     
-       &General::readhasharray("${General::swroot}/ovpn/ccd.conf", \%ccdconfhash);     
+       my %ccdconfhash=();
+       &General::readhasharray("${General::swroot}/ovpn/ccd.conf", \%ccdconfhash);
        my @ccdconf=();
        my $count=0;
        foreach my $key (sort { uc($ccdconfhash{$a}[0]) cmp uc($ccdconfhash{$b}[0]) } keys %ccdconfhash) {
@@ -3035,14 +2982,14 @@ END
                <input type='image' src='/images/delete.gif' align='middle' alt='$Lang::tr{'remove'}' title='$Lang::tr{'remove'}' /></form></td></tr>
 END
 ;
-       }       
+       }
        print "</table></form>";
        &Header::closebox();
        print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
        &Header::closebigbox();
        &Header::closepage();
        exit(0);
-       
+
 #END CCD
 
 ###
@@ -3056,7 +3003,7 @@ END
 
 #
 #      <td><b>$Lang::tr{'protocol'}</b></td>
-# protocol temp removed 
+# protocol temp removed
     print <<END;
     <table width='100%' cellpadding='2' cellspacing='0' class='tbl'>
     <tr>
@@ -3087,10 +3034,10 @@ END
        {
            chomp($line);
            if ( $line =~ /^Updated,(.+)/){
-               @match = split( /^Updated,(.+)/, $line); 
+               @match = split( /^Updated,(.+)/, $line);
                $status = $match[1];
            }
-#gian      
+#gian
            if ( $line =~ /^(.+),(\d+\.\d+\.\d+\.\d+\:\d+),(\d+),(\d+),(.+)/) {
                @match = split(m/^(.+),(\d+\.\d+\.\d+\.\d+\:\d+),(\d+),(\d+),(.+)/, $line);
                if ($match[1] ne "Common Name") {
@@ -3108,7 +3055,7 @@ END
                    my $flag_icon = &Location::Functions::get_flag_icon($ccode);
                    $users[$uid]{'Country'} = "<a href='country.cgi#$ccode'><img src='$flag_icon' border='0' align='absmiddle' alt='$ccode' title='$ccode' /></a>";
                    $uid++;
-               }    
+               }
            }
            if ( $line =~ /^(\d+\.\d+\.\d+\.\d+),(.+),(\d+\.\d+\.\d+\.\d+\:\d+),(.+)/) {
                @match = split(m/^(\d+\.\d+\.\d+\.\d+),(.+),(\d+\.\d+\.\d+\.\d+\:\d+),(.+)/, $line);
@@ -3141,7 +3088,7 @@ END
                                                print "<td align='left' $col>$users[$idx-1]{'LastRef'}</td>";
                        }
        }
-       
+
        print "</table>";
        print <<END;
        <table width='100%' border='0' cellpadding='2' cellspacing='0'>
@@ -3152,7 +3099,7 @@ END
        <tr><td align='center' >$Lang::tr{'the statistics were last updated at'} <b>$status</b></td></tr>
        </table>
 END
-;      
+;
        &Header::closebox();
        print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
        &Header::closebigbox();
@@ -3173,7 +3120,7 @@ END
        my @tmp = <FILE>;
        close(FILE);
 
-       print "@tmp";
+       print @tmp;
        exit (0);
     }
 
@@ -3182,7 +3129,7 @@ END
 ###
 
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'toggle enable disable'}) {
-    
+
     &General::readhash("${General::swroot}/ovpn/settings", \%vpnsettings);
     &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
 
@@ -3244,7 +3191,7 @@ if ( -s "${General::swroot}/ovpn/settings") {
                <td class='base'>$Lang::tr{'host to net vpn'}</td></tr>
            <tr><td><input type='radio' name='TYPE' value='net' /></td>
                <td class='base'>$Lang::tr{'net to net vpn'}</td></tr>
-               <tr><td><input type='radio' name='TYPE' value='net2net' /></td>         
+               <tr><td><input type='radio' name='TYPE' value='net2net' /></td>
                <td class='base'>$Lang::tr{'net to net vpn'} (Upload Client Package)</td></tr>
          <tr><td>&nbsp;</td><td class='base'><input type='file' name='FH' size='30'></td></tr>
          <tr><td>&nbsp;</td><td>Import Connection Name</td></tr>
@@ -3254,7 +3201,7 @@ if ( -s "${General::swroot}/ovpn/settings") {
            </form></table>
 END
        ;
-       
+
 
 } else {
        print <<END;
@@ -3288,11 +3235,11 @@ END
        my $uplp12name2 = '';
        my @rem_subnet;
        my @rem_subnet2;
-       my @tmposupnet3;        
+       my @tmposupnet3;
        my $key;
        my @n2nname;
 
-       &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);    
+       &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
 
        # Check if a file is uploaded
        unless (ref ($cgiparams{'FH'})) {
@@ -3311,7 +3258,7 @@ END
        my $zip = Archive::Zip->new();
        my $zipName = $filename;
        my $status = $zip->read( $zipName );
-       if ($status != AZ_OK) {   
+       if ($status != AZ_OK) {
                $errormessage = "Read of $zipName failed\n";
                goto N2N_ERROR;
        }
@@ -3332,7 +3279,7 @@ END
                        }
                        if ( $_ =~ /.p12$/){
                                $uplp12name = $_;
-                       }                       
+                       }
                }
                if (($uplconffilename eq '') || ($uplp12name eq '')){
                        $errormessage = "Either no *.conf or no *.p12 file found\n";
@@ -3352,11 +3299,11 @@ END
 ###
 # m.a.d net2net
 ###
-  
+
  if ($cgiparams{'n2nname'} ne ''){
 
-  $uplconffilename2 = "$cgiparams{'n2nname'}.conf"; 
-  $uplp12name2 = "$cgiparams{'n2nname'}.p12"; 
+  $uplconffilename2 = "$cgiparams{'n2nname'}.conf";
+  $uplp12name2 = "$cgiparams{'n2nname'}.p12";
   $n2nname[0] = $cgiparams{'n2nname'};
   my @n2nname2 = split(/\./,$uplconffilename);
   $n2nname2[0] =~ s/\n|\r//g;
@@ -3379,15 +3326,19 @@ END
     $uplp12name2 = $uplp12name;
     @n2nname = split(/\./,$uplconffilename);
     $n2nname[0] =~ s/\n|\r//g;
-   } 
+   }
     unless(-d "${General::swroot}/ovpn/n2nconf/"){mkdir "${General::swroot}/ovpn/n2nconf", 0755 or die "Unable to create dir $!";}
-    unless(-d "${General::swroot}/ovpn/n2nconf/$n2nname[0]"){mkdir "${General::swroot}/ovpn/n2nconf/$n2nname[0]", 0770 or die "Unable to create dir $!";}   
+    unless(-d "${General::swroot}/ovpn/n2nconf/$n2nname[0]"){mkdir "${General::swroot}/ovpn/n2nconf/$n2nname[0]", 0770 or die "Unable to create dir $!";}
 
        #Add collectd settings to configfile
        open(FILE, ">> $tempdir/$uplconffilename") or die 'Unable to open config file.';
        print FILE "# Logfile\n";
        print FILE "status-version 1\n";
        print FILE "status /var/run/openvpn/$n2nname[0]-n2n 10\n";
+       if (&iscertlegacy("${General::swroot}/ovpn/certs/$cgiparams{'n2nname'}")) {
+               print CLIENTCONF "providers legacy default\n";
+       }
+
        close FILE;
 
        unless(move("$tempdir/$uplconffilename", "${General::swroot}/ovpn/n2nconf/$n2nname[0]/$uplconffilename2")) {
@@ -3395,7 +3346,7 @@ END
            unlink ($filename);
            goto N2N_ERROR;
        }
-       
+
        unless(move("$tempdir/$uplp12name", "${General::swroot}/ovpn/certs/$uplp12name2")) {
            $errormessage = "$Lang::tr{'certificate file move failed'}: $!";
            unlink ($filename);
@@ -3403,7 +3354,7 @@ END
        }
 
        chmod 0600, "${General::swroot}/ovpn/certs/$uplp12name";
-       
+
 my $complzoactive;
 my $mssfixactive;
 my $authactive;
@@ -3413,7 +3364,7 @@ my @n2nproto = split(/-/, $n2nproto2[1]);
 my @n2nport = split(/ /, (grep { /^port/ } @firen2nconf)[0]);
 my @n2ntunmtu = split(/ /, (grep { /^tun-mtu/ } @firen2nconf)[0]);
 my @n2ncomplzo = grep { /^comp-lzo/ } @firen2nconf;
-if ($n2ncomplzo[0] =~ /comp-lzo/){$complzoactive = "on";} else {$complzoactive = "off";}       
+if ($n2ncomplzo[0] =~ /comp-lzo/){$complzoactive = "on";} else {$complzoactive = "off";}
 my @n2nmssfix  = grep { /^mssfix/ } @firen2nconf;
 if ($n2nmssfix[0] =~ /mssfix/){$mssfixactive = "on";} else {$mssfixactive = "off";}
 #my @n2nmssfix = split(/ /, (grep { /^mssfix/ } @firen2nconf)[0]);
@@ -3462,7 +3413,7 @@ chomp ($mssfixactive);
                        unlink ("${General::swroot}/ovpn/n2nconf/$n2nname[0]/$n2nname[0].conf") or die "Removing Configfile fail: $!";
            unlink ("${General::swroot}/ovpn/certs/$n2nname[0].p12") or die "Removing Certfile fail: $!";
       rmdir ("${General::swroot}/ovpn/n2nconf/$n2nname[0]") || die "Removing Directory fail: $!";
-                       goto N2N_ERROR;                 
+                       goto N2N_ERROR;
                }
        }
 
@@ -3476,7 +3427,7 @@ foreach my $dkey (keys %confighash) {
                        unlink ("${General::swroot}/ovpn/n2nconf/$n2nname[0]/$n2nname[0].conf") or die "Removing Configfile fail: $!";
            unlink ("${General::swroot}/ovpn/certs/$n2nname[0].p12") or die "Removing Certfile fail: $!";
       rmdir ("${General::swroot}/ovpn/n2nconf/$n2nname[0]") || die "Removing Directory fail: $!";
-                       goto N2N_ERROR;                 
+                       goto N2N_ERROR;
                }
        }
 
@@ -3490,25 +3441,25 @@ foreach my $dkey (keys %confighash) {
                        unlink ("${General::swroot}/ovpn/n2nconf/$n2nname[0]/$n2nname[0].conf") or die "Removing Configfile fail: $!";
            unlink ("${General::swroot}/ovpn/certs/$n2nname[0].p12") or die "Removing Certfile fail: $!";
       rmdir ("${General::swroot}/ovpn/n2nconf/$n2nname[0]") || die "Removing Directory fail: $!";
-                       goto N2N_ERROR;                 
+                       goto N2N_ERROR;
                }
        }
-       
-       
-       
+
+
+
   $key = &General::findhasharraykey (\%confighash);
 
        foreach my $i (0 .. 42) { $confighash{$key}[$i] = "";}
 
        $confighash{$key}[0] = 'off';
        $confighash{$key}[1] = $n2nname[0];
-       $confighash{$key}[2] = $n2nname[0];     
+       $confighash{$key}[2] = $n2nname[0];
        $confighash{$key}[3] = 'net';
-       $confighash{$key}[4] = 'cert';  
-       $confighash{$key}[6] = 'client';                
+       $confighash{$key}[4] = 'cert';
+       $confighash{$key}[6] = 'client';
        $confighash{$key}[8] =  $n2nlocalsub[2];
        $confighash{$key}[10] = $n2nremote[1];
-       $confighash{$key}[11] = "$n2nremsub[1]/$n2nremsub[2]";          
+       $confighash{$key}[11] = "$n2nremsub[1]/$n2nremsub[2]";
        $confighash{$key}[22] = $n2nmgmt[2];
        $confighash{$key}[23] = $mssfixactive;
        $confighash{$key}[24] = $n2nfragment[1];
@@ -3521,12 +3472,12 @@ foreach my $dkey (keys %confighash) {
        $confighash{$key}[31] = $n2ntunmtu[1];
        $confighash{$key}[39] = $n2nauth[1];
        $confighash{$key}[40] = $n2ncipher[1];
-       $confighash{$key}[41] = 'disabled';
+       $confighash{$key}[41] = 'no-pass';
 
   &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
+
   N2N_ERROR:
-               
+
        &Header::showhttpheaders();
        &Header::openpage('Validate imported configuration', 1, '');
        &Header::openbigbox('100%', 'LEFT', '', $errormessage);
@@ -3534,10 +3485,10 @@ foreach my $dkey (keys %confighash) {
            &Header::openbox('100%', 'LEFT', $Lang::tr{'error messages'});
            print "<class name='base'>$errormessage";
            print "&nbsp;</class>";
-           &Header::closebox();                
+           &Header::closebox();
 
-       } else 
-  {            
+       } else
+  {
                &Header::openbox('100%', 'LEFT', 'import ipfire net2net config');
        }
        if ($errormessage eq ''){
@@ -3546,8 +3497,8 @@ foreach my $dkey (keys %confighash) {
                <table width='100%'>
                <tr><td width='25%'>&nbsp;</td><td width='25%'>&nbsp;</td></tr>
     <tr><td class='boldbase'>$Lang::tr{'name'}:</td><td><b>$n2nname[0]</b></td></tr>
-    <tr><td>&nbsp;</td><td>&nbsp;</td></tr>    
-               <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'Act as'}</td><td><b>$confighash{$key}[6]</b></td></tr>                                                              
+    <tr><td>&nbsp;</td><td>&nbsp;</td></tr>
+               <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'Act as'}</td><td><b>$confighash{$key}[6]</b></td></tr>
                <tr><td class='boldbase' nowrap='nowrap'>Remote Host </td><td><b>$confighash{$key}[10]</b></td></tr>
                <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'local subnet'}</td><td><b>$confighash{$key}[8]</b></td></tr>
                <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'remote subnet'}:</td><td><b>$confighash{$key}[11]</b></td></tr>
@@ -3561,21 +3512,21 @@ foreach my $dkey (keys %confighash) {
                <tr><td class='boldbase' nowrap='nowrap'>Management Port </td><td><b>$confighash{$key}[22]</b></td></tr>
                <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'ovpn tls auth'}:</td><td><b>$confighash{$key}[39]</b></td></tr>
                <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'cipher'}</td><td><b>$confighash{$key}[40]</b></td></tr>
-               <tr><td>&nbsp;</td><td>&nbsp;</td></tr> 
+               <tr><td>&nbsp;</td><td>&nbsp;</td></tr>
     </table>
 END
-;      
+;
                &Header::closebox();
        }
 
        if ($errormessage) {
                print "<div align='center'><a href='/cgi-bin/ovpnmain.cgi'>$Lang::tr{'back'}</a></div>";
-       } else {        
-               print "<div align='center'><form method='post' ENCTYPE='multipart/form-data'><input type='submit' name='ACTION' value='$Lang::tr{'add'}' />";           
+       } else {
+               print "<div align='center'><form method='post' ENCTYPE='multipart/form-data'><input type='submit' name='ACTION' value='$Lang::tr{'add'}' />";
                print "<input type='hidden' name='TYPE' value='net2netakn' />";
-               print "<input type='hidden' name='KEY' value='$key' />";                        
+               print "<input type='hidden' name='KEY' value='$key' />";
                print "<input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></div></form>";
-       }       
+       }
        &Header::closebigbox();
        &Header::closepage();
        exit(0);
@@ -3592,7 +3543,7 @@ END
 ###
 
   }  elsif (($cgiparams{'ACTION'} eq $Lang::tr{'cancel'}) && ($cgiparams{'TYPE'} eq 'net2netakn')){
-     
+
      &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
 
 if ($confighash{$cgiparams{'KEY'}}) {
@@ -3603,12 +3554,12 @@ if ($confighash{$cgiparams{'KEY'}}) {
      unlink ($conffile) or die "Removing $conffile fail: $!";
      rmdir ("${General::swroot}/ovpn/n2nconf/$confighash{$cgiparams{'KEY'}}[1]") || die "Kann Verzeichnis nicht loeschen: $!";
      delete $confighash{$cgiparams{'KEY'}};
-    &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);      
+    &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
 
      } else {
                $errormessage = $Lang::tr{'invalid key'};
-   }   
-    
+   }
+
 
 ###
 # m.a.d net2net
@@ -3621,7 +3572,7 @@ if ($confighash{$cgiparams{'KEY'}}) {
 } elsif (($cgiparams{'ACTION'} eq $Lang::tr{'add'}) ||
         ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) ||
         ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'ADVANCED'} eq '')) {
-           
+
     &General::readhash("${General::swroot}/ovpn/settings", \%vpnsettings);
     &General::readhasharray("${General::swroot}/ovpn/caconfig", \%cahash);
     &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
@@ -3660,9 +3611,10 @@ if ($confighash{$cgiparams{'KEY'}}) {
                $cgiparams{'DAUTH'}             = $confighash{$cgiparams{'KEY'}}[39];
                $cgiparams{'DCIPHER'}           = $confighash{$cgiparams{'KEY'}}[40];
                $cgiparams{'TLSAUTH'}           = $confighash{$cgiparams{'KEY'}}[41];
+               $cgiparams{'OTP_STATE'}         = $confighash{$cgiparams{'KEY'}}[43];
        } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
        $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
-       
+
 #A.Marx CCD check iroute field and convert it to decimal
 if ($cgiparams{'TYPE'} eq 'host') {
        my @temp=();
@@ -3687,7 +3639,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
                my $val=0;
                foreach $val (@temp){
                        chomp($val);
-                       $val=~s/\s*$//g; 
+                       $val=~s/\s*$//g;
                        #check if iroute exists in ccdroute or if new iroute is part of an existing one
                        foreach my $key (keys %ccdroutehash) {
                                foreach my $oldiroute ( 1 .. $#{$ccdroutehash{$key}}){
@@ -3701,8 +3653,8 @@ if ($cgiparams{'TYPE'} eq 'host') {
                                                if (&General::IpInSubnet ($ip1,$ip2,$cidr2)){
                                                        $errormessage=$errormessage.$Lang::tr{'ccd err irouteexist'};
                                                        goto VPNCONF_ERROR;
-                                               } 
-                                                                       
+                                               }
+
                                }
                        }
                        if (!&General::validipandmask($val)){
@@ -3713,9 +3665,9 @@ if ($cgiparams{'TYPE'} eq 'host') {
                                $ip=&General::getnetworkip($ip,&General::iporsubtocidr($cidr));
                                $cidr=&General::iporsubtodec($cidr);
                                $ccdroutehash{$keypoint}[$i] = $ip."/".$cidr;
-                       
+
                        }
-                                                                                                                                       
+
                        #check for existing network IP's
                        if (&General::IpInSubnet ($ip,$netsettings{GREEN_NETADDRESS},$netsettings{GREEN_NETMASK}) && $netsettings{GREEN_NETADDRESS} ne '0.0.0.0')
                        {
@@ -3734,7 +3686,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
                                $errormessage=$Lang::tr{'ccd err orange'};
                                goto VPNCONF_ERROR;
                        }
-                                               
+
                        if (&General::validipandmask($val)){
                                $ccdroutehash{$keypoint}[$i] = $ip."/".$cidr;
                        }else{
@@ -3753,7 +3705,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
                                &General::writehasharray("${General::swroot}/ovpn/ccdroute", \%ccdroutehash);
                                &writeserverconf;
                        }
-               }       
+               }
        }
        undef @temp;
        #check route field and convert it to decimal
@@ -3778,7 +3730,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
        &General::readhash("${General::swroot}/ethernet/settings", \%ownnet);
        foreach $val (@temp){
                chomp($val);
-               $val=~s/\s*$//g; 
+               $val=~s/\s*$//g;
                if ($val eq $Lang::tr{'green'})
                {
                        $val=$ownnet{GREEN_NETADDRESS}."/".$ownnet{GREEN_NETMASK};
@@ -3792,9 +3744,9 @@ if ($cgiparams{'TYPE'} eq 'host') {
                        $val=$ownnet{ORANGE_NETADDRESS}."/".$ownnet{ORANGE_NETMASK};
                }
                my ($ip,$cidr) = split (/\//, $val);
-               
+
                if ($val ne $Lang::tr{'ccd none'})
-               {       
+               {
                        if (! &check_routes_push($val)){$errormessage=$errormessage."Route $val ".$Lang::tr{'ccd err routeovpn2'}." ($val)";goto VPNCONF_ERROR;}
                        if (! &check_ccdroute($val)){$errormessage=$errormessage."<br>Route $val ".$Lang::tr{'ccd err inuse'}." ($val)" ;goto VPNCONF_ERROR;}
                        if (! &check_ccdconf($val)){$errormessage=$errormessage."<br>Route $val ".$Lang::tr{'ccd err routeovpn'}." ($val)";goto VPNCONF_ERROR;}
@@ -3809,7 +3761,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
                        $ccdroute2hash{$keypoint}[$i]='';
                }
                $i++;
-       }       
+       }
        &General::writehasharray("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
 
        #check dns1 ip
@@ -3831,7 +3783,7 @@ if ($cgiparams{'TYPE'} eq 'host') {
 
 #CCD End
 
-       
+
        if ($cgiparams{'TYPE'} !~ /^(host|net)$/) {
                $errormessage = $Lang::tr{'connection type is invalid'};
                if ($cgiparams{'TYPE'} eq 'net') {
@@ -3879,7 +3831,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                        $errormessage = $Lang::tr{'openvpn destination port used'};
                        unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
-      goto VPNCONF_ERROR;                      
+      goto VPNCONF_ERROR;
                }
     #Bugfix 10357
     foreach my $key (sort keys %confighash){
@@ -3887,14 +3839,14 @@ if ($cgiparams{'TYPE'} eq 'net') {
                        $errormessage = $Lang::tr{'openvpn destination port used'};
                        unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
-      goto VPNCONF_ERROR;      
+      goto VPNCONF_ERROR;
                }
        }
     if ($cgiparams{'DEST_PORT'} eq  '') {
                        $errormessage = $Lang::tr{'invalid port'};
                        unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
-      goto VPNCONF_ERROR;                      
+      goto VPNCONF_ERROR;
                }
 
     # Check if the input for the transfer net is valid.
@@ -3909,7 +3861,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                        $errormessage = $Lang::tr{'openvpn subnet is used'};
                        unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
-                       goto VPNCONF_ERROR;                     
+                       goto VPNCONF_ERROR;
                }
 
          if (($cgiparams{'PROTOCOL'} eq 'tcp') && ($cgiparams{'MSSFIX'} eq 'on')) {
@@ -3918,7 +3870,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
            goto VPNCONF_ERROR;
     }
-     
+
     if (($cgiparams{'PROTOCOL'} eq 'tcp') && ($cgiparams{'FRAGMENT'} ne '')) {
            $errormessage = $Lang::tr{'openvpn fragment allowed with udp'};
            unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
@@ -3931,22 +3883,22 @@ if ($cgiparams{'TYPE'} eq 'net') {
                  unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
                  goto VPNCONF_ERROR;
-               } 
-    
+               }
+
     if ( &validdotmask ($cgiparams{'OVPN_SUBNET'}))  {
                  $errormessage = $Lang::tr{'openvpn prefix openvpn subnet'};
                  unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
                  goto VPNCONF_ERROR;
-               } 
-    
+               }
+
     if ( &validdotmask ($cgiparams{'REMOTE_SUBNET'}))  {
                  $errormessage = $Lang::tr{'openvpn prefix remote subnet'};
                  unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
            rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
                  goto VPNCONF_ERROR;
                }
-       
+
        if ($cgiparams{'DEST_PORT'} <= 1023) {
                $errormessage = $Lang::tr{'ovpn port in root range'};
                  unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
@@ -3955,9 +3907,9 @@ if ($cgiparams{'TYPE'} eq 'net') {
                }
 
        if ($cgiparams{'OVPN_MGMT'} eq '') {
-               $cgiparams{'OVPN_MGMT'} = $cgiparams{'DEST_PORT'};              
+               $cgiparams{'OVPN_MGMT'} = $cgiparams{'DEST_PORT'};
                }
-       
+
        if ($cgiparams{'OVPN_MGMT'} <= 1023) {
                $errormessage = $Lang::tr{'ovpn mgmt in root range'};
                  unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
@@ -4023,7 +3975,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
        if ($cgiparams{'TYPE'} ne 'host') {
             unless (&General::validipandmask($cgiparams{'LOCAL_SUBNET'})) {
-                   $errormessage = $Lang::tr{'local subnet is invalid'}; 
+                   $errormessage = $Lang::tr{'local subnet is invalid'};
                    if ($cgiparams{'TYPE'} eq 'net') {
               unlink ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}/$cgiparams{'NAME'}.conf") or die "Removing Configfile fail: $!";
                    rmdir ("${General::swroot}/ovpn/n2nconf/$cgiparams{'NAME'}") || die "Removing Directory fail: $!";
@@ -4033,8 +3985,8 @@ if ($cgiparams{'TYPE'} eq 'net') {
        # Check if there is no other entry without IP-address and PSK
        if ($cgiparams{'REMOTE'} eq '') {
            foreach my $key (keys %confighash) {
-               if(($cgiparams{'KEY'} ne $key) && 
-                  ($confighash{$key}[4] eq 'psk' || $cgiparams{'AUTH'} eq 'psk') && 
+               if(($cgiparams{'KEY'} ne $key) &&
+                  ($confighash{$key}[4] eq 'psk' || $cgiparams{'AUTH'} eq 'psk') &&
                    $confighash{$key}[10] eq '') {
                        $errormessage = $Lang::tr{'you can only define one roadwarrior connection when using pre-shared key authentication'};
                        goto VPNCONF_ERROR;
@@ -4125,7 +4077,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                        last;
                }
            }
-               
+
            $cgiparams{'CERT_NAME'} = $temp;
            $cgiparams{'CERT_NAME'} =~ s/,//g;
            $cgiparams{'CERT_NAME'} =~ s/\'//g;
@@ -4246,7 +4198,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                    $errormessage = $Lang::tr{'password too short'};
                    goto VPNCONF_ERROR;
                }
-           }   
+           }
            if ($cgiparams{'CERT_PASS1'} ne $cgiparams{'CERT_PASS2'}) {
                $errormessage = $Lang::tr{'passwords do not match'};
                goto VPNCONF_ERROR;
@@ -4264,15 +4216,25 @@ if ($cgiparams{'TYPE'} eq 'net') {
                }
            }
 
-               # Check for RW if client name is already set
-               if ($cgiparams{'TYPE'} eq 'host') {
-                       foreach my $key (keys %confighash) {
-                               if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
-                                       $errormessage = $Lang::tr{'a connection with this name already exists'};
-                                       goto VPNCONF_ERROR;
-                               }
-                       }
-               }
+           # Check for RW if client name is already set
+           if ($cgiparams{'TYPE'} eq 'host') {
+                   foreach my $key (keys %confighash) {
+                           if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
+                                   $errormessage = $Lang::tr{'a connection with this name already exists'};
+                                   goto VPNCONF_ERROR;
+                   }
+                   }
+           }
+
+           # Check if there is no other entry with this common name
+           if ((! $cgiparams{'KEY'}) && ($cgiparams{'AUTH'} ne 'psk')) {
+               foreach my $key (keys %confighash) {
+                   if ($confighash{$key}[2] eq $cgiparams{'CERT_NAME'}) {
+                       $errormessage = $Lang::tr{'a connection with this common name already exists'};
+                       goto VPNCONF_ERROR;
+                   }
+               }
+           }
 
            # Replace empty strings with a .
            (my $ou = $cgiparams{'CERT_OU'}) =~ s/^\s*$/\./;
@@ -4301,7 +4263,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                }
            } else {    # child
                unless (exec ('/usr/bin/openssl', 'req', '-nodes',
-                       '-newkey', 'rsa:2048',
+                       '-newkey', 'rsa:4096',
                        '-keyout', "${General::swroot}/ovpn/certs/$cgiparams{'NAME'}key.pem",
                        '-out', "${General::swroot}/ovpn/certs/$cgiparams{'NAME'}req.pem",
                        '-config',"${General::swroot}/ovpn/openssl/ovpn.cnf")) {
@@ -4311,7 +4273,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                    goto VPNCONF_ERROR;
                }
            }
-       
+
            # Sign the host certificate request
            # The system call is safe, because all arguments are passed as an array.
            system('/usr/bin/openssl', 'ca', '-days', "$cgiparams{'DAYS_VALID'}",
@@ -4333,12 +4295,12 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
            # Create the pkcs12 file
            # The system call is safe, because all arguments are passed as an array.
-           system('/usr/bin/openssl', 'pkcs12', '-export', 
+           system('/usr/bin/openssl', 'pkcs12', '-export',
                '-inkey', "${General::swroot}/ovpn/certs/$cgiparams{'NAME'}key.pem",
                '-in', "${General::swroot}/ovpn/certs/$cgiparams{'NAME'}cert.pem",
                '-name', $cgiparams{'NAME'},
                '-passout', "pass:$cgiparams{'CERT_PASS1'}",
-               '-certfile', "${General::swroot}/ovpn/ca/cacert.pem", 
+               '-certfile', "${General::swroot}/ovpn/ca/cacert.pem",
                '-caname', "$vpnsettings{'ROOTCERT_ORGANIZATION'} CA",
                '-out', "${General::swroot}/ovpn/certs/$cgiparams{'NAME'}.p12");
            if ($?) {
@@ -4357,19 +4319,9 @@ if ($cgiparams{'TYPE'} eq 'net') {
            goto VPNCONF_ERROR;
        }
 
-       # Check if there is no other entry with this common name
-       if ((! $cgiparams{'KEY'}) && ($cgiparams{'AUTH'} ne 'psk')) {
-           foreach my $key (keys %confighash) {
-               if ($confighash{$key}[2] eq $cgiparams{'CERT_NAME'}) {
-                   $errormessage = $Lang::tr{'a connection with this common name already exists'};
-                   goto VPNCONF_ERROR;
-               }
-           }
-       }
-
     # Save the config
        my $key = $cgiparams{'KEY'};
-       
+
        if (! $key) {
            $key = &General::findhasharraykey (\%confighash);
            foreach my $i (0 .. 43) { $confighash{$key}[$i] = "";}
@@ -4379,7 +4331,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
        if ((! $cgiparams{'KEY'}) && $cgiparams{'AUTH'} ne 'psk') {
            $confighash{$key}[2]        = $cgiparams{'CERT_NAME'};
        }
-       
+
        $confighash{$key}[3]            = $cgiparams{'TYPE'};
        if ($cgiparams{'AUTH'} eq 'psk') {
            $confighash{$key}[4]        = 'psk';
@@ -4402,7 +4354,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
        $confighash{$key}[24]           = $cgiparams{'FRAGMENT'};
        $confighash{$key}[25]           = $cgiparams{'REMARK'};
        $confighash{$key}[26]           = $cgiparams{'INTERFACE'};
-# new fields   
+# new fields
        $confighash{$key}[27]           = $cgiparams{'OVPN_SUBNET'};
        $confighash{$key}[28]           = $cgiparams{'PROTOCOL'};
        $confighash{$key}[29]           = $cgiparams{'DEST_PORT'};
@@ -4418,14 +4370,30 @@ if ($cgiparams{'TYPE'} eq 'net') {
        $confighash{$key}[39]           = $cgiparams{'DAUTH'};
        $confighash{$key}[40]           = $cgiparams{'DCIPHER'};
 
-       if (($cgiparams{'TYPE'} eq 'host') && ($cgiparams{'CERT_PASS1'} eq "")) {
-               $confighash{$key}[41] = "no-pass";
+       if ($confighash{$key}[41] eq "") {
+               if (($cgiparams{'TYPE'} eq 'host') && ($cgiparams{'CERT_PASS1'} eq "")) {
+                       $confighash{$key}[41] = "no-pass";
+               } elsif (($cgiparams{'TYPE'} eq 'host') && ($cgiparams{'CERT_PASS1'} ne "")) {
+                       $confighash{$key}[41] = "pass";
+               } elsif ($cgiparams{'TYPE'} eq 'net') {
+                       $confighash{$key}[41] = "no-pass";
+               }
+       }
+
+   $confighash{$key}[42] = 'HOTP/T30/6';
+       $confighash{$key}[43] = $cgiparams{'OTP_STATE'};
+       if (($confighash{$key}[43] eq 'on') && ($confighash{$key}[44] eq '')) {
+               my @otp_secret = &General::system_output("/usr/bin/openssl", "rand", "-hex", "20");
+      chomp($otp_secret[0]);
+               $confighash{$key}[44] = $otp_secret[0];
+       } elsif ($confighash{$key}[43] eq '') {
+               $confighash{$key}[44] = '';
        }
 
        &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
-       
+
        if ($cgiparams{'CHECK1'} ){
-               
+
                my ($ccdip,$ccdsub)=split "/",$cgiparams{$name};
                my ($a,$b,$c,$d) = split (/\./,$ccdip);
                        if ( -e "${General::swroot}/ovpn/ccd/$confighash{$key}[2]"){
@@ -4495,12 +4463,12 @@ if ($cgiparams{'TYPE'} eq 'net') {
 ###
 # m.a.d n2n begin
 ###
-       
+
        if ($cgiparams{'TYPE'} eq 'net') {
-       
+
                if (-e "/var/run/$confighash{$key}[1]n2n.pid") {
                        &General::system("/usr/local/bin/openvpnctrl", "-kn2n", "$confighash{$cgiparams{'KEY'}}[1]");
-       
+
                        &General::readhasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
                        my $key = $cgiparams{'KEY'};
                        if (! $key) {
@@ -4512,14 +4480,14 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
                        $confighash{$key}[0] = 'on';
                        &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);
-  
+
                        &General::system("/usr/local/bin/openvpnctrl", "-sn2n", "$confighash{$cgiparams{'KEY'}}[1]");
                }
        }
 
 ###
 # m.a.d n2n end
-###    
+###
 
        if ($cgiparams{'EDIT_ADVANCED'} eq 'on') {
            $cgiparams{'KEY'} = $key;
@@ -4530,13 +4498,13 @@ if ($cgiparams{'TYPE'} eq 'net') {
         $cgiparams{'ENABLED'} = 'on';
 ###
 # m.a.d n2n begin
-###    
+###
         $cgiparams{'MSSFIX'} = 'on';
         $cgiparams{'FRAGMENT'} = '1300';
        $cgiparams{'DAUTH'} = 'SHA512';
 ###
 # m.a.d n2n end
-###    
+###
         $cgiparams{'SIDE'} = 'left';
        if ( ! -f "${General::swroot}/ovpn/ca/cakey.pem" ) {
            $cgiparams{'AUTH'} = 'psk';
@@ -4572,7 +4540,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
     $selected{'SIDE'}{'server'} = '';
     $selected{'SIDE'}{'client'} = '';
     $selected{'SIDE'}{$cgiparams{'SIDE'}} = 'SELECTED';
-    
+
     $selected{'PROTOCOL'}{'udp'} = '';
     $selected{'PROTOCOL'}{'tcp'} = '';
     $selected{'PROTOCOL'}{$cgiparams{'PROTOCOL'}} = 'SELECTED';
@@ -4585,7 +4553,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
     $checked{'AUTH'}{$cgiparams{'AUTH'}} = 'CHECKED';
 
     $selected{'INTERFACE'}{$cgiparams{'INTERFACE'}} = 'SELECTED';
-    
+
     $checked{'COMPLZO'}{'off'} = '';
     $checked{'COMPLZO'}{'on'} = '';
     $checked{'COMPLZO'}{$cgiparams{'COMPLZO'}} = 'CHECKED';
@@ -4656,7 +4624,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
        print "<table width='100%'  border='0'>\n";
 
        print "<tr><td width='14%' class='boldbase'>$Lang::tr{'name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>";
-       
+
        if ($cgiparams{'TYPE'} eq 'host') {
            if ($cgiparams{'KEY'}) {
                print "<td width='35%' class='base'><input type='hidden' name='NAME' value='$cgiparams{'NAME'}' />$cgiparams{'NAME'}</td>";
@@ -4691,7 +4659,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
            print <<END;
                    <td width='25%'>&nbsp;</td>
-                   <td width='25%'>&nbsp;</td></tr>    
+                   <td width='25%'>&nbsp;</td></tr>
        <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'Act as'}</td>
                <td><select name='SIDE'>
                                <option value='server' $selected{'SIDE'}{'server'}>$Lang::tr{'openvpn server'}</option>
@@ -4718,7 +4686,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
                        <option value='udp' $selected{'PROTOCOL'}{'udp'}>UDP</option>
                        <option value='tcp' $selected{'PROTOCOL'}{'tcp'}>TCP</option></select></td>
        </tr>
-       
+
        <tr>
                <td class='boldbase'>$Lang::tr{'destination port'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
                <td><input type='TEXT' name='DEST_PORT' value='$cgiparams{'DEST_PORT'}' size='5' /></td>
@@ -4728,9 +4696,9 @@ if ($cgiparams{'TYPE'} eq 'net') {
        </tr>
 
        <tr><td colspan=4><hr /></td></tr><tr>
-       
+
        <tr>
-               <td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
+               <td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
        </tr>
 
         <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
@@ -4754,7 +4722,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
 <tr><td colspan=4><hr /></td></tr><tr>
        <tr>
-               <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+               <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
        </tr>
 
        <tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
@@ -4811,14 +4779,14 @@ END
 #jumper
        print "<tr><td class='boldbase'>$Lang::tr{'remark title'}</td>";
        print "<td colspan='3'><input type='text' name='REMARK' value='$cgiparams{'REMARK'}' size='55' maxlength='50' /></td></tr></table>";
-       
+
        if ($cgiparams{'TYPE'} eq 'host') {
       print "<tr><td>$Lang::tr{'enabled'} <input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} /></td>";
-    }  
+    }
 
                print"</tr></table><br><br>";
-#A.Marx CCD new client         
-if ($cgiparams{'TYPE'} eq 'host') {    
+#A.Marx CCD new client
+if ($cgiparams{'TYPE'} eq 'host') {
            print "<table border='0' width='100%' cellspacing='1' cellpadding='0'><tr><td colspan='3'><hr><br><b>$Lang::tr{'ccd choose net'}</td></tr><tr><td height='20' colspan='3'></td></tr>";
            my %vpnnet=();
            my $vpnip;
@@ -4835,8 +4803,9 @@ if ($cgiparams{'TYPE'} eq 'host') {
            print"</td></tr></table><br><br>";
                my $name=$cgiparams{'CHECK1'};
                $checked{'RG'}{$cgiparams{'RG'}} = 'CHECKED';
-               
-       if (! -z "${General::swroot}/ovpn/ccd.conf"){   
+               $checked{'OTP_STATE'}{$cgiparams{'OTP_STATE'}} = 'CHECKED';
+
+       if (! -z "${General::swroot}/ovpn/ccd.conf"){
                print"<table border='0' width='100%' cellspacing='1' cellpadding='0'><tr><td width='1%'></td><td width='30%' class='boldbase' align='center'><b>$Lang::tr{'ccd name'}</td><td width='15%' class='boldbase' align='center'><b>$Lang::tr{'network'}</td><td class='boldbase' align='center' width='18%'><b>$Lang::tr{'ccd clientip'}</td></tr>";
                foreach my $key (sort { uc($ccdconfhash{$a}[0]) cmp uc($ccdconfhash{$b}[0]) } keys %ccdconfhash) {
                        $count++;
@@ -4852,24 +4821,24 @@ if ($cgiparams{'TYPE'} eq 'host') {
 # ccd end
        &Header::closebox();
        if ($cgiparams{'KEY'} && $cgiparams{'AUTH'} eq 'psk') {
-               
+
                } elsif (! $cgiparams{'KEY'}) {
-               
-               
+
+
            my $disabled='';
            my $cakeydisabled='';
            my $cacrtdisabled='';
            if ( ! -f "${General::swroot}/ovpn/ca/cakey.pem" ) { $cakeydisabled = "disabled='disabled'" } else { $cakeydisabled = "" };
            if ( ! -f "${General::swroot}/ovpn/ca/cacert.pem" ) { $cacrtdisabled = "disabled='disabled'" } else { $cacrtdisabled = "" };
-           
+
            &Header::openbox('100%', 'LEFT', $Lang::tr{'authentication'});
+
+
  if ($cgiparams{'TYPE'} eq 'host') {
 
        print <<END;
            <table width='100%' cellpadding='0' cellspacing='5' border='0'>
-           
+
            <tr><td><input type='radio' name='AUTH' value='certreq' $checked{'AUTH'}{'certreq'} $cakeydisabled /></td><td class='base'>$Lang::tr{'upload a certificate request'}</td><td class='base' rowspan='2'><input type='file' name='FH' size='30' $cacrtdisabled></td></tr>
            <tr><td><input type='radio' name='AUTH' value='certfile' $checked{'AUTH'}{'certfile'} $cacrtdisabled /></td><td class='base'>$Lang::tr{'upload a certificate'}</td></tr>
            <tr><td colspan='3'>&nbsp;</td></tr>
@@ -4894,7 +4863,7 @@ END
 
        print <<END;
            <table width='100%' cellpadding='0' cellspacing='5' border='0'>
-      
+
            <tr><td><input type='radio' name='AUTH' value='certgen' $checked{'AUTH'}{'certgen'} $cakeydisabled /></td><td class='base'>$Lang::tr{'generate a certificate'}</td><td>&nbsp;</td></tr>
            <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'users fullname or system hostname'}:&nbsp;<img src='/blob.gif' alt='*' /></td><td class='base' nowrap='nowrap'><input type='text' name='CERT_NAME' value='$cgiparams{'CERT_NAME'}' SIZE='32' $cakeydisabled /></td></tr>
            <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'users email'}:</td><td class='base' nowrap='nowrap'><input type='text' name='CERT_EMAIL' value='$cgiparams{'CERT_EMAIL'}' SIZE='32' $cakeydisabled /></td></tr>
@@ -4903,8 +4872,8 @@ END
            <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'city'}:</td><td class='base' nowrap='nowrap'><input type='text' name='CERT_CITY' value='$cgiparams{'CERT_CITY'}' SIZE='32' $cakeydisabled /></td></tr>
            <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'state or province'}:</td><td class='base' nowrap='nowrap'><input type='text' name='CERT_STATE' value='$cgiparams{'CERT_STATE'}' SIZE='32' $cakeydisabled /></td></tr>
            <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'country'}:</td><td class='base'><select name='CERT_COUNTRY' $cakeydisabled>
-          
-      
+
+
 END
 ;
 
@@ -4950,7 +4919,7 @@ END
                <tr><td colspan='3'><hr /></td></tr>
                <tr><td class='base' colspan='3' align='left'><img src='/blob.gif' alt='*' />&nbsp;$Lang::tr{'required field'}</td></tr>
        </table>
+
 END
 }
 
@@ -4959,23 +4928,24 @@ END
 ###
            ;
            &Header::closebox();
-           
+
        }
 
-#A.Marx CCD new client 
+#A.Marx CCD new client
 if ($cgiparams{'TYPE'} eq 'host') {
            print"<br><br>";
            &Header::openbox('100%', 'LEFT', "$Lang::tr{'ccd client options'}:");
 
-       
+
        print <<END;
        <table border='0' width='100%'>
+       <tr><td width='20%'>$Lang::tr{'enable otp'}:</td><td colspan='3'><input type='checkbox' name='OTP_STATE' $checked{'OTP_STATE'}{'on'} /></td></tr>
        <tr><td width='20%'>Redirect Gateway:</td><td colspan='3'><input type='checkbox' name='RG' $checked{'RG'}{'on'} /></td></tr>
        <tr><td colspan='4'><b><br>$Lang::tr{'ccd routes'}</b></td></tr>
        <tr><td colspan='4'>&nbsp</td></tr>
        <tr><td valign='top'>$Lang::tr{'ccd iroute'}</td><td align='left' width='30%'><textarea name='IR' cols='26' rows='6' wrap='off'>
 END
-       
+
        if ($cgiparams{'IR'} ne ''){
                print $cgiparams{'IR'};
        }else{
@@ -4991,13 +4961,13 @@ END
                        }
                }
        }
-        
+
        print <<END;
 </textarea></td><td valign='top' colspan='2'>$Lang::tr{'ccd iroutehint'}</td></tr>
        <tr><td colspan='4'><br></td></tr>
        <tr><td valign='top' rowspan='3'>$Lang::tr{'ccd iroute2'}</td><td align='left' valign='top' rowspan='3'><select name='IFROUTE' style="width: 205px"; size='6' multiple>
 END
-       
+
        my $set=0;
        my $selorange=0;
        my $selblue=0;
@@ -5007,12 +4977,12 @@ END
        my $other=0;
        my $none=0;
        my @temp=();
-       
+
        our @current = ();
        open(FILE, "${General::swroot}/main/routing") ;
        @current = <FILE>;
        close (FILE);
-       &General::readhasharray ("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);         
+       &General::readhasharray ("${General::swroot}/ovpn/ccdroute2", \%ccdroute2hash);
        #check for "none"
        foreach my $key (keys %ccdroute2hash) {
                if($ccdroute2hash{$key}[0] eq $cgiparams{'NAME'}){
@@ -5029,7 +4999,7 @@ END
        }
        #check if static routes are defined for client
        foreach my $line (@current) {
-               chomp($line);   
+               chomp($line);
                $line=~s/\s*$//g;                       # remove newline
                @temp=split(/\,/,$line);
                $temp[1] = '' unless defined $temp[1]; # not always populated
@@ -5045,7 +5015,7 @@ END
                        }
                }
                if ($set == '1' && $#temp != -1){ print"<option selected>$temp[1]</option>";$set=0;}elsif($set == '0' && $#temp != -1){print"<option>$temp[1]</option>";}
-       }       
+       }
 
        my %vpnconfig = ();
        &General::readhasharray("${General::swroot}/vpn/config", \%vpnconfig);
@@ -5097,14 +5067,14 @@ END
                }
        }
        if (&haveBlueNet() && $selblue == '1'){ print"<option selected>$Lang::tr{'blue'}</option>";$selblue=0;}elsif(&haveBlueNet() && $selblue == '0'){print"<option>$Lang::tr{'blue'}</option>";}
-       if (&haveOrangeNet() && $selorange == '1'){ print"<option selected>$Lang::tr{'orange'}</option>";$selorange=0;}elsif(&haveOrangeNet() && $selorange == '0'){print"<option>$Lang::tr{'orange'}</option>";}                       
+       if (&haveOrangeNet() && $selorange == '1'){ print"<option selected>$Lang::tr{'orange'}</option>";$selorange=0;}elsif(&haveOrangeNet() && $selorange == '0'){print"<option>$Lang::tr{'orange'}</option>";}
        if ($selgreen == '1' || $other == '0'){ print"<option selected>$Lang::tr{'green'}</option>";$set=0;}else{print"<option>$Lang::tr{'green'}</option>";};
-       
+
        print<<END;
        </select></td><td valign='top'>DNS1:</td><td valign='top'><input type='TEXT' name='CCD_DNS1' value='$cgiparams{'CCD_DNS1'}' size='30' /></td></tr>
        <tr valign='top'><td>DNS2:</td><td><input type='TEXT' name='CCD_DNS2' value='$cgiparams{'CCD_DNS2'}' size='30' /></td></tr>
        <tr valign='top'><td valign='top'>WINS:</td><td><input type='TEXT' name='CCD_WINS' value='$cgiparams{'CCD_WINS'}' size='30' /></td></tr></table><br><hr>
-       
+
 END
 ;
      &Header::closebox();
@@ -5147,7 +5117,7 @@ END
                    }
                }
     }
-    
+
 #default setzen
     if ($cgiparams{'DCIPHER'} eq '') {
                $cgiparams{'DCIPHER'} =  'AES-256-CBC';
@@ -5275,8 +5245,8 @@ END
        $activeonrun = "";
     } else {
        $activeonrun = "disabled='disabled'";
-    }  
-    &Header::openbox('100%', 'LEFT', $Lang::tr{'global settings'});    
+    }
+    &Header::openbox('100%', 'LEFT', $Lang::tr{'global settings'});
        print <<END;
     <table width='100%' border='0'>
     <form method='post'>
@@ -5293,7 +5263,7 @@ END
        print "<tr><td class='boldbase'>$Lang::tr{'ovpn on blue'}</td>";
        print "<td><input type='checkbox' name='ENABLED_BLUE' $checked{'ENABLED_BLUE'}{'on'} /></td>";
     }
-    if (&haveOrangeNet()) {    
+    if (&haveOrangeNet()) {
        print "<tr><td class='boldbase'>$Lang::tr{'ovpn on orange'}</td>";
        print "<td><input type='checkbox' name='ENABLED_ORANGE' $checked{'ENABLED_ORANGE'}{'on'} /></td>";
     }
@@ -5302,7 +5272,7 @@ END
 
        <tr><td colspan='4'><br></td></tr>
        <tr>
-               <td class'base'><b>$Lang::tr{'net config'}:</b></td>
+               <td class='base'><b>$Lang::tr{'net config'}:</b></td>
        </tr>
     <tr><td colspan='1'><br></td></tr>
 
@@ -5310,7 +5280,7 @@ END
        <td class='boldbase' nowrap='nowrap' colspan='2'>$Lang::tr{'ovpn subnet'}<br /><input type='TEXT' name='DOVPN_SUBNET' value='$cgiparams{'DOVPN_SUBNET'}' size='30' /></td></tr>
     <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'protocol'}</td>
         <td><select name='DPROTOCOL'><option value='udp' $selected{'DPROTOCOL'}{'udp'}>UDP</option>
-                                           <option value='tcp' $selected{'DPROTOCOL'}{'tcp'}>TCP</option></select></td>                                    
+                                           <option value='tcp' $selected{'DPROTOCOL'}{'tcp'}>TCP</option></select></td>
         <td class='boldbase'>$Lang::tr{'destination port'}:</td>
         <td><input type='TEXT' name='DDEST_PORT' value='$cgiparams{'DDEST_PORT'}' size='5' /></td></tr>
     <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}&nbsp;</td>
@@ -5319,7 +5289,7 @@ END
 
        <tr><td colspan='4'><br></td></tr>
        <tr>
-               <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+               <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
        </tr>
        <tr><td colspan='1'><br></td></tr>
 
@@ -5363,28 +5333,28 @@ END
 
     <tr><td colspan='4'><br><br></td></tr>
 END
-;                                 
-    
+;
+
     if ( $srunning eq "yes" ) {
        print "<tr><td align='right' colspan='4'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' disabled='disabled' />";
        print "<input type='submit' name='ACTION' value='$Lang::tr{'ccd net'}' />";
-       print "<input type='submit' name='ACTION' value='$Lang::tr{'advanced server'}' />";     
+       print "<input type='submit' name='ACTION' value='$Lang::tr{'advanced server'}' />";
        print "<input type='submit' name='ACTION' value='$Lang::tr{'stop ovpn server'}' /></td></tr>";
     } else{
        print "<tr><td align='right' colspan='4'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' />";
        print "<input type='submit' name='ACTION' value='$Lang::tr{'ccd net'}' />";
        print "<input type='submit' name='ACTION' value='$Lang::tr{'advanced server'}' />";
        if (( -e "${General::swroot}/ovpn/ca/cacert.pem" &&
-            -e "${General::swroot}/ovpn/ca/dh1024.pem" &&
+            -e "$dhparameter" &&
             -e "${General::swroot}/ovpn/certs/servercert.pem" &&
             -e "${General::swroot}/ovpn/certs/serverkey.pem") &&
-           (( $cgiparams{'ENABLED'} eq 'on') || 
+           (( $cgiparams{'ENABLED'} eq 'on') ||
            ( $cgiparams{'ENABLED_BLUE'} eq 'on') ||
            ( $cgiparams{'ENABLED_ORANGE'} eq 'on'))){
            print "<input type='submit' name='ACTION' value='$Lang::tr{'start ovpn server'}' /></td></tr>";
        } else {
-           print "<input type='submit' name='ACTION' value='$Lang::tr{'start ovpn server'}' disabled='disabled' /></td></tr>";    
-       }    
+           print "<input type='submit' name='ACTION' value='$Lang::tr{'start ovpn server'}' disabled='disabled' /></td></tr>";
+       }
     }
     print "</form></table>";
     &Header::closebox();
@@ -5413,7 +5383,7 @@ END
        <th width='15%' class='boldbase' align='center'><b>$Lang::tr{'type'}</b></th>
        <th width='20%' class='boldbase' align='center'><b>$Lang::tr{'remark'}</b></th>
        <th width='10%' class='boldbase' align='center'><b>$Lang::tr{'status'}</b></th>
-       <th width='5%' class='boldbase' colspan='7' align='center'><b>$Lang::tr{'action'}</b></th>
+       <th width='5%' class='boldbase' colspan='8' align='center'><b>$Lang::tr{'action'}</b></th>
 </tr>
 END
                }
@@ -5427,36 +5397,61 @@ END
        <th width='15%' class='boldbase' align='center'><b>$Lang::tr{'type'}</b></th>
        <th width='20%' class='boldbase' align='center'><b>$Lang::tr{'remark'}</b></th>
        <th width='10%' class='boldbase' align='center'><b>$Lang::tr{'status'}</b></th>
-       <th width='5%' class='boldbase' colspan='7' align='center'><b>$Lang::tr{'action'}</b></th>
+       <th width='5%' class='boldbase' colspan='8' align='center'><b>$Lang::tr{'action'}</b></th>
 </tr>
 END
                }
        if ($confighash{$key}[0] eq 'on') { $gif = 'on.gif'; } else { $gif = 'off.gif'; }
-       if ($id % 2) {
-               print "<tr>";
+
+       # Create some simple booleans to check the status
+       my $hasExpired;
+       my $expiresSoon;
+
+       # Fetch information about the certificate for non-N2N connections only
+       if ($confighash{$key}[3] ne 'net') {
+               my @cavalid = &General::system_output("/usr/bin/openssl", "x509", "-text",
+                       "-in", "${General::swroot}/ovpn/certs/$confighash{$key}[1]cert.pem");
+
+               my $expiryDate = 0;
+
+               # Parse the certificate information
+               foreach my $line (@cavalid) {
+                       if ($line =~ /Not After : (.*)[\n]/) {
+                               $expiryDate = &Date::Parse::str2time($1);
+                               last;
+                       }
+               }
+
+               # Calculate the remaining time
+               my $remainingTime = $expiryDate - time();
+
+               # Determine whether the certificate has already expired, or will so soon
+               $hasExpired = ($remainingTime <= 0);
+               $expiresSoon = ($remainingTime <= 30 * 24 * 3600);
+
+       } else {
+               # Populate booleans with dummy values for N2N connections (#13066)
+               $hasExpired = 0;
+               $expiresSoon = 0;
+       }
+
+       print "<tr>";
+
+       if ($hasExpired || $expiresSoon) {
+               $col="bgcolor='$color{'color14'}'";
+       } elsif ($id % 2) {
                $col="bgcolor='$color{'color20'}'";
        } else {
-               print "<tr>";
                $col="bgcolor='$color{'color22'}'";
        }
-       print "<td align='center' nowrap='nowrap' $col>$confighash{$key}[1]</td>";
-       print "<td align='center' nowrap='nowrap' $col>" . $Lang::tr{"$confighash{$key}[3]"} . " (" . $Lang::tr{"$confighash{$key}[4]"} . ")</td>";
-       #if ($confighash{$key}[4] eq 'cert') {
-           #print "<td align='left' nowrap='nowrap'>$confighash{$key}[2]</td>";
-       #} else {
-           #print "<td align='left'>&nbsp;</td>";
-       #}
-       my @cavalid = &General::system_output("/usr/bin/openssl", "x509", "-text", "-in", "${General::swroot}/ovpn/certs/$confighash{$key}[1]cert.pem");
-       my $cavalid;
-
-       foreach my $line (@cavalid) {
-               if ($line =~ /Not After : (.*)[\n]/) {
-                       $cavalid    = $1;
-
-                       last;
-               }
+       print "<td align='center' nowrap='nowrap' $col>$confighash{$key}[1]";
+       if ($hasExpired) {
+               print " ($Lang::tr{'openvpn cert has expired'})";
+       } elsif ($expiresSoon) {
+               print " ($Lang::tr{'openvpn cert expires soon'})";
        }
-
+       print "</td>";
+       print "<td align='center' nowrap='nowrap' $col>" . $Lang::tr{"$confighash{$key}[3]"} . " (" . $Lang::tr{"$confighash{$key}[4]"} . ")</td>";
        print "<td align='center' $col>$confighash{$key}[25]</td>";
        $col1="bgcolor='${Header::colourred}'";
        my $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsclosed'}</font></b>";
@@ -5476,7 +5471,7 @@ END
           my @output = "";
           my @tustate = "";
           my $tport = $confighash{$key}[22];
-          my $tnet = new Net::Telnet ( Timeout=>5, Errmode=>'return', Port=>$tport); 
+          my $tnet = new Net::Telnet ( Timeout=>5, Errmode=>'return', Port=>$tport);
           if ($tport ne '') {
           $tnet->open('127.0.0.1');
           @output = $tnet->cmd(String => 'state', Prompt => '/(END.*\n|ERROR:.*\n)/');
@@ -5513,7 +5508,6 @@ END
                                if ($match[1] ne "Common Name") {
                                        $cn = $match[1];
                                }
-                               $cn =~ s/[_]/ /g;
                                if ($cn eq "$confighash{$key}[2]") {
                                        $col1="bgcolor='${Header::colourgreen}'";
                                        $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsopen'}</font></b>";
@@ -5524,20 +5518,24 @@ END
 }
 
 
-    print <<END;
-       <td align='center' $col1>$active</td>
-               
-       <form method='post' name='frm${key}a'><td align='center' $col>
-           <input type='image'  name='$Lang::tr{'dl client arch'}' src='/images/openvpn.png' alt='$Lang::tr{'dl client arch'}' title='$Lang::tr{'dl client arch'}' border='0' />
-           <input type='hidden' name='ACTION' value='$Lang::tr{'dl client arch'}' />
-           <input type='hidden' name='KEY' value='$key' />
-       </td></form>
+       if ($confighash{$key}[41] eq "pass") {
+               print <<END;
+                       <td align='center' $col1>$active</td>
+
+                       <form method='post' name='frm${key}a'><td align='center' $col>
+                           <input type='image'  name='$Lang::tr{'dl client arch'}' src='/images/openvpn_encrypted.png'
+                                       alt='$Lang::tr{'dl client arch'}' title='$Lang::tr{'dl client arch'}' border='0' />
+                           <input type='hidden' name='ACTION' value='$Lang::tr{'dl client arch'}' />
+                           <input type='hidden' name='MODE' value='secure' />
+                           <input type='hidden' name='KEY' value='$key' />
+                       </td></form>
 END
-       ;
 
-       if ($confighash{$key}[41] eq "no-pass") {
+       ; } elsif ($confighash{$key}[41] eq "no-pass") {
                print <<END;
-                       <form method='post' name='frm${key}g'><td align='center' $col>
+                       <td align='center' $col1>$active</td>
+
+                       <form method='post' name='frm${key}a'><td align='center' $col>
                                <input type='image'  name='$Lang::tr{'dl client arch insecure'}' src='/images/openvpn.png'
                                        alt='$Lang::tr{'dl client arch insecure'}' title='$Lang::tr{'dl client arch insecure'}' border='0' />
                                <input type='hidden' name='ACTION' value='$Lang::tr{'dl client arch'}' />
@@ -5545,7 +5543,7 @@ END
                                <input type='hidden' name='KEY' value='$key' />
                        </td></form>
 END
-       } else {
+       } else {
                print "<td $col>&nbsp;</td>";
        }
 
@@ -5560,7 +5558,20 @@ END
        ; } else {
            print "<td>&nbsp;</td>";
        }
-       if ($confighash{$key}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$key}[1].p12") { 
+
+   if ($confighash{$key}[43] eq 'on') {
+      print <<END;
+<form method='post' name='frm${key}o'><td align='center' $col>
+<input type='image' name='$Lang::tr{'show otp qrcode'}' src='/images/qr-code.png' alt='$Lang::tr{'show otp qrcode'}' title='$Lang::tr{'show otp qrcode'}' border='0' />
+<input type='hidden' name='ACTION' value='$Lang::tr{'show otp qrcode'}' />
+<input type='hidden' name='KEY' value='$key' />
+</td></form>
+END
+; } else {
+      print "<td $col>&nbsp;</td>";
+   }
+
+       if ($confighash{$key}[4] eq 'cert' && -f "${General::swroot}/ovpn/certs/$confighash{$key}[1].p12") {
            print <<END;
            <form method='post' name='frm${key}c'><td align='center' $col>
                <input type='image' name='$Lang::tr{'download pkcs12 file'}' src='/images/media-floppy.png' alt='$Lang::tr{'download pkcs12 file'}' title='$Lang::tr{'download pkcs12 file'}' border='0' />
@@ -5608,28 +5619,33 @@ END
     # If the config file contains entries, print Key to action icons
     if ( $id ) {
     print <<END;
-    <table border='0'>
-    <tr>
+       <table width='85%' border='0'>
+       <tr>
                <td class='boldbase'>&nbsp; <b>$Lang::tr{'legend'}:</b></td>
-               <td>&nbsp; <img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
-               <td class='base'>$Lang::tr{'click to disable'}</td>
+              <td>&nbsp; &nbsp; <img src='/images/openvpn.png' alt='?RELOAD'/></td>
+              <td class='base'>$Lang::tr{'dl client arch insecure'}</td>
+              <td>&nbsp; &nbsp; <img src='/images/openvpn_encrypted.png' alt='?RELOAD'/></td>
+              <td class='base'>$Lang::tr{'dl client arch'}</td>
                <td>&nbsp; &nbsp; <img src='/images/info.gif' alt='$Lang::tr{'show certificate'}' /></td>
                <td class='base'>$Lang::tr{'show certificate'}</td>
+              <td>&nbsp; &nbsp; <img src='/images/qr-code.png' alt='$Lang::tr{'show otp qrcode'}'/></td>
+              <td class='base'>$Lang::tr{'show otp qrcode'}</td>
+       </tr>
+       <tr>
+              <td>&nbsp; </td>
+              <td>&nbsp; &nbsp; <img src='/images/media-floppy.png' alt='?FLOPPY' /></td>
+              <td class='base'>$Lang::tr{'download certificate'}</td>
+              <td>&nbsp; <img src='/images/off.gif' alt='?OFF' /></td>
+              <td class='base'>$Lang::tr{'click to enable'}</td>
+              <td>&nbsp; <img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
+              <td class='base'>$Lang::tr{'click to disable'}</td>              
+
                <td>&nbsp; &nbsp; <img src='/images/edit.gif' alt='$Lang::tr{'edit'}' /></td>
                <td class='base'>$Lang::tr{'edit'}</td>
                <td>&nbsp; &nbsp; <img src='/images/delete.gif' alt='$Lang::tr{'remove'}' /></td>
                <td class='base'>$Lang::tr{'remove'}</td>
-    </tr>
-    <tr>
-               <td>&nbsp; </td>
-               <td>&nbsp; <img src='/images/off.gif' alt='?OFF' /></td>
-               <td class='base'>$Lang::tr{'click to enable'}</td>
-               <td>&nbsp; &nbsp; <img src='/images/media-floppy.png' alt='?FLOPPY' /></td>
-               <td class='base'>$Lang::tr{'download certificate'}</td>
-               <td>&nbsp; &nbsp; <img src='/images/openvpn.png' alt='?RELOAD'/></td>
-               <td class='base'>$Lang::tr{'dl client arch'}</td>
-               </tr>
-    </table><br>
+       </tr>
+       </table><br>
 END
     ;
     }
@@ -5751,8 +5767,8 @@ END
     }
 
     # Adding DH parameter to chart
-    if (-f "${General::swroot}/ovpn/ca/dh1024.pem") {
-               my @dhsubject = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "${General::swroot}/ovpn/ca/dh1024.pem");
+    if (-f "$dhparameter") {
+               my @dhsubject = &General::system_output("/usr/bin/openssl", "dhparam", "-text", "-in", "$dhparameter");
                my $dhsubject;
 
                foreach my $line (@dhsubject) {
@@ -5765,7 +5781,7 @@ END
 
        print <<END;
                <tr>
-                       <td class='base' $col3>$Lang::tr{'dh parameter'}</td>
+                       <td class='base' $col3>$Lang::tr{'dh'}</td>
                        <td class='base' $col3>$dhsubject</td>
                        <form method='post' name='frmdhparam'><td width='3%' align='center' $col3>
                        <input type='hidden' name='ACTION' value='$Lang::tr{'show dh'}' />
@@ -5781,7 +5797,7 @@ END
                # Nothing
                print <<END;
                <tr>
-                       <td width='25%' class='base' $col3>$Lang::tr{'dh parameter'}:</td>
+                       <td width='25%' class='base' $col3>$Lang::tr{'dh'}:</td>
                        <td class='base' $col3>$Lang::tr{'not present'}</td>
                        </td><td colspan='3' $col3>&nbsp;</td>
                </tr>
@@ -5909,27 +5925,8 @@ END
                                <td align='right'><input type='submit' name='ACTION' value='$Lang::tr{'show crl'}' /></td>
                        </tr>
                </table>
-
-               <br>
-
-               <table border='0' width='100%'>
-                       <tr>
-                               <td colspan='4'><b>$Lang::tr{'ovpn dh parameters'}</b></td>
-                       </tr>
-
-                       <tr>
-                               <td width='40%'>$Lang::tr{'ovpn dh upload'}:</td>
-                               <td width='30%'><input type='file' name='FH' size='25'>
-                               <td width='30%' align='right'><input type='submit' name='ACTION' value='$Lang::tr{'upload dh key'}'></td>
-                       </tr>
-
-                       <tr>
-                               <td width='40%'>$Lang::tr{'ovpn dh new key'}:</td>
-                               <td colspan='2' width='60%' align='right'><input type='submit' name='ACTION' value='$Lang::tr{'generate dh key'}' /></td>
-                       </tr>
-               </table>
        </form>
-       
+
        <br><hr>
 END
        ;