]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/blobdiff - src/initscripts/init.d/unbound
unbound: Test for working EDNS buffer size and adjust accordingly
[people/pmueller/ipfire-2.x.git] / src / initscripts / init.d / unbound
index 3b8beee24826526de78aa81f44bed3151aaa673a..08f98059ee72c0beffe557b3dda5d052de4a64d7 100644 (file)
@@ -12,6 +12,7 @@ TEST_DOMAIN="ipfire.org"
 # This domain will never validate
 TEST_DOMAIN_FAIL="dnssec-failed.org"
 
+INSECURE_ZONES=
 USE_FORWARDERS=1
 
 # Cache any local zones for 60 seconds
@@ -85,6 +86,24 @@ update_forwarders() {
                        esac
                done
 
+               # Determine EDNS buffer size
+               local current_edns_buffer_size=$(unbound-control get_option edns-buffer-size)
+
+               if [ -n "${current_edns_buffer_size}" ]; then
+                       local new_edns_buffer_size=${current_edns_buffer_size}
+
+                       for ns in ${forwarders}; do
+                               local edns_buffer_size=$(ns_determine_edns_buffer_size ${ns})
+                               if [ -n "${edns_buffer_size}" ]; then
+                                       if [ ${edns_buffer_size} -lt ${current_edns_buffer_size} ]; then
+                                               new_edns_buffer_size=${edns_buffer_size}
+                                       fi
+                               fi
+                       done
+
+                       unbound-control -q set_option edns-buffer-size: ${new_edns_buffer_size}
+               fi
+
                # Show warning for any broken upstream name servers
                if [ -n "${broken_forwarders}" ]; then
                        boot_mesg "Ignoring broken upstream name server(s): ${broken_forwarders:1}" ${WARNING}
@@ -138,45 +157,47 @@ update_hosts() {
 
                unbound-control -q local_data "${fqdn} ${LOCAL_TTL} IN A ${address}"
 
+               # Skip reverse resolution if the address equals the GREEN address
+               [ "${address}" = "${GREEN_ADDRESS}" ] && continue
+
                # Add RDNS
                address=$(ip_address_revptr ${address})
                unbound-control -q local_data "${address} ${LOCAL_TTL} IN PTR ${fqdn}"
        done < /var/ipfire/main/hosts
 }
 
-write_interfaces_conf() {
-       (
-               config_header
-
-               # 1.1.1.1 is reserved for unused green
-               if [ -n "${GREEN_ADDRESS}" -a "${GREEN_ADDRESS}" != "1.1.1.1" ]; then
-                       echo "# GREEN"
-                       echo "interface: ${GREEN_ADDRESS}"
-                       echo "access-control: $(cidr ${GREEN_NETADDRESS} ${GREEN_NETMASK}) allow"
-               fi
-
-               if [ -n "${BLUE_ADDRESS}" ]; then
-                       echo "# BLUE"
-                       echo "interface: ${BLUE_ADDRESS}"
-                       echo "access-control: $(cidr ${BLUE_NETADDRESS} ${BLUE_NETMASK}) allow"
-               fi
-       ) > /etc/unbound/interfaces.conf
-}
-
 write_forward_conf() {
        (
                config_header
 
+               local insecure_zones="${INSECURE_ZONES}"
+
                local enabled zone server remark
                while IFS="," read -r enabled zone server remark; do
                        # Line must be enabled.
                        [ "${enabled}" = "on" ] || continue
 
+                       # Zones that end with .local are commonly used for internal
+                       # zones and therefore not signed
+                       case "${zone}" in
+                               *.local)
+                                       insecure_zones="${insecure_zones} ${zone}"
+                                       ;;
+                       esac
+
                        echo "forward-zone:"
                        echo "  name: ${zone}"
                        echo "  forward-addr: ${server}"
                        echo
                done < /var/ipfire/dnsforward/config
+
+               if [ -n "${insecure_zones}" ]; then
+                       echo "server:"
+
+                       for zone in ${insecure_zones}; do
+                               echo "  domain-insecure: ${zone}"
+                       done
+               fi
        ) > /etc/unbound/forward.conf
 }
 
@@ -246,6 +267,7 @@ get_memory_amount() {
 
 test_name_server() {
        local ns=${1}
+       local args
 
        # Return codes:
        # 0     DNSSEC validating
@@ -256,12 +278,15 @@ test_name_server() {
        # Exit when the server is not reachable
        ns_is_online ${ns} || return 1
 
-       # Return 0 if validating
-       ns_is_validating ${ns} && return 0
+       # Determine the maximum edns buffer size that works
+       local edns_buffer_size=$(ns_determine_edns_buffer_size ${ns})
+       if [ -n "${edns_buffer_size}" ]; then
+               args="${args} +bufsize=${edns_buffer_size}"
+       fi
 
        local errors
        for rr in DNSKEY DS RRSIG; do
-               if ! ns_forwards_${rr} ${ns}; then
+               if ! ns_forwards_${rr} ${ns} ${args}; then
                        errors="${errors} ${rr}"
                fi
        done
@@ -271,48 +296,74 @@ test_name_server() {
                return 3
        fi
 
-       # Is DNSSEC-aware
-       return 2
+       if ns_is_validating ${ns} ${args}; then
+               # Return 0 if validating
+               return 0
+       else
+               # Is DNSSEC-aware
+               return 2
+       fi
 }
 
 # Sends an A query to the nameserver w/o DNSSEC
 ns_is_online() {
        local ns=${1}
+       shift
 
-       dig @${ns} +nodnssec A ${TEST_DOMAIN} >/dev/null
+       dig @${ns} +nodnssec A ${TEST_DOMAIN} $@ >/dev/null
 }
 
 # Resolving ${TEST_DOMAIN_FAIL} will fail if the nameserver is validating
 ns_is_validating() {
        local ns=${1}
+       shift
 
-       dig @${ns} A ${TEST_DOMAIN_FAIL} | grep -q SERVFAIL
+       dig @${ns} A ${TEST_DOMAIN_FAIL} $@ | grep -q SERVFAIL
 }
 
 # Checks if we can retrieve the DNSKEY for this domain.
 # dig will print the SOA if nothing was found
 ns_forwards_DNSKEY() {
        local ns=${1}
+       shift
 
-       dig @${ns} DNSKEY ${TEST_DOMAIN} | grep -qv SOA
+       dig @${ns} DNSKEY ${TEST_DOMAIN} $@ | grep -qv SOA
 }
 
 ns_forwards_DS() {
        local ns=${1}
+       shift
 
-       dig @${ns} DS ${TEST_DOMAIN} | grep -qv SOA
+       dig @${ns} DS ${TEST_DOMAIN} $@ | grep -qv SOA
 }
 
 ns_forwards_RRSIG() {
        local ns=${1}
+       shift
 
-       dig @${ns} +dnssec A ${TEST_DOMAIN} | grep -q RRSIG
+       dig @${ns} +dnssec A ${TEST_DOMAIN} $@ | grep -q RRSIG
 }
 
 ns_supports_tcp() {
        local ns=${1}
+       shift
+
+       dig @${ns} +tcp A ${TEST_DOMAIN} $@ >/dev/null || return 1
+}
+
+ns_determine_edns_buffer_size() {
+       local ns=${1}
+       shift
 
-       dig @${ns} +tcp A ${TEST_DOMAIN} >/dev/null || return 1
+       local b
+       for b in 4096 2048 1500 1480 1464 1400 1280 512; do
+               if dig @${ns} +dnssec +bufsize=${b} A ${TEST_DOMAIN} $@ >/dev/null; then
+                       echo "${b}"
+                       return 0
+               fi
+       done
+
+       return 1
 }
 
 case "$1" in
@@ -332,7 +383,6 @@ case "$1" in
 
                # Update configuration files
                write_tuning_conf
-               write_interfaces_conf
                write_forward_conf
 
                boot_mesg "Starting Unbound DNS Proxy..."
@@ -364,6 +414,11 @@ case "$1" in
                ;;
 
        update-forwarders)
+               # Do not try updating forwarders when unbound is not running
+               if ! pgrep unbound &>/dev/null; then
+                       exit 0
+               fi
+
                update_forwarders
                ;;
 
@@ -385,6 +440,7 @@ case "$1" in
                                ;;
                        *)
                                echo "Test failed for an unknown reason"
+                               exit ${ret}
                                ;;
                esac
 
@@ -394,6 +450,11 @@ case "$1" in
                        echo "${ns} does not support TCP fallback"
                fi
 
+               edns_buffer_size=$(ns_determine_edns_buffer_size ${ns})
+               if [ -n "${edns_buffer_size}" ]; then
+                       echo "EDNS buffer size for ${ns}: ${edns_buffer_size}"
+               fi
+
                exit ${ret}
                ;;