misc-progs: smartctrl: Sanitise device name

Fixes: #12562
Reported-by: Albert Schwarzkopf <ipfire@quitesimple.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/misc-progs/smartctrl.c b/src/misc-progs/smartctrl.c
index c6451acba3a031baaa1f2ce2856a668395a88a92..22f0e0a10a3539d0f5c4d53081df6ded5540c5fa 100644 (file)
--- a/src/misc-progs/smartctrl.c
+++ b/src/misc-progs/smartctrl.c
@@ -22,6 +22,11 @@ int main(int argc, char *argv[]) {
                exit(1);
        }
 
+       if (!is_valid_argument_alnum(argv[1])) {
+               fprintf(stderr, "Invalid device name '%s'\n", argv[1]);
+               exit(2);
+       }
+
        char command[STRING_SIZE];
        snprintf(command, STRING_SIZE, "/var/run/hddshutdown-%s", argv[1]);