Drop unmaintained add-on dpfhack

This package seems to be unmaintained for at least five years. It's
(former?) upstream traces back to https://section5.ch/index.php/2011/01/13/dpf-hacking/,
but download links to both dpfhack and a patched version of lcd4linux
point to http://localhost/.

http://tech.section5.ch/files/dpfhack-0.1alpha.tgz still serves
something apparently related to dpfhack, but it is unclear whether that
is a previous version than the "0.12devel" we know about, or a
successor. https://tech.section5.ch/files/dpfhack-0.1alpha.tgz, just to
have it noticed, comes with a X.509 certificate not issued for this
FQDN.

dpfhack is solely needed as a dependancy for lcd4linux, which appears to
be unmaintained as well, hence being dropped in a dedicated patch.

Given the status quo, bugs in dpfhack cannot be reported properly,
security issues won't be addressed (by anybody else then ourselves), and
technical questions cannot be clarified aside a reverse engineering
approach.

We should not allow such an add-on to be installed on a firewall system.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/config/rootfiles/packages/dpfhack b/config/rootfiles/packages/dpfhack
deleted file mode 100644 (file)
index b79791c..0000000
--- a/config/rootfiles/packages/dpfhack
+++ /dev/null
@@ -1,3 +0,0 @@
-#usr/include/dpf.h
-#usr/include/usbuser.h
-usr/lib/libdpf.so

diff --git a/lfs/dpfhack b/lfs/dpfhack
deleted file mode 100644 (file)
index 4d1c158..0000000
--- a/lfs/dpfhack
+++ /dev/null
@@ -1,84 +0,0 @@
-###############################################################################
-#                                                                             #
-# IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2018  IPFire Team  <info@ipfire.org>                     #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-###############################################################################
-
-###############################################################################
-# Definitions
-###############################################################################
-
-include Config
-
-VER        = 0.12devel
-APP        = dpf
-THISAPP    = dpfhack-$(VER)
-DL_FILE    = $(THISAPP).tgz
-DL_FROM    = $(URL_IPFIRE)
-DIR_APP    = $(DIR_SRC)/$(APP)
-TARGET     = $(DIR_INFO)/$(THISAPP)
-PROG       = dpfhack
-PAK_VER    = 1
-
-DEPS       =
-
-###############################################################################
-# Top-level Rules
-###############################################################################
-
-objects = $(DL_FILE)
-
-$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-
-$(DL_FILE)_MD5 = 00473bb01d8da7c5967ecb19ca251ac2
-
-install : $(TARGET)
-
-check : $(patsubst %,$(DIR_CHK)/%,$(objects))
-
-download :$(patsubst %,$(DIR_DL)/%,$(objects))
-
-md5 : $(subst %,%_MD5,$(objects))
-
-dist: 
-       $(PAK)
-
-###############################################################################
-# Downloading, checking, md5sum
-###############################################################################
-
-$(patsubst %,$(DIR_CHK)/%,$(objects)) :
-       @$(CHECK)
-
-$(patsubst %,$(DIR_DL)/%,$(objects)) :
-       @$(LOAD)
-
-$(subst %,%_MD5,$(objects)) :
-       @$(MD5)
-
-###############################################################################
-# Installation Details
-###############################################################################
-
-$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
-       @$(PREBUILD)
-       @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
-       cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/$(PROG).patch
-       cd $(DIR_APP) && make 
-       cd $(DIR_APP) && cp Debug/libdpf.so /usr/lib && cp dpflib/dpf.h include/usbuser.h /usr/include
-       @rm -rf $(DIR_APP)
-       @$(POSTBUILD)

diff --git a/make.sh b/make.sh
index 9f9fd7b0e34ea514b128e805b44d6cc9dc582539..fc03ebcd5ccb8cb0bcec82ff59319f2040ae5d3a 100755 (executable)
--- a/make.sh
+++ b/make.sh
@@ -1546,7 +1546,6 @@ buildipfire() {
   lfsmake2 python3-msgpack
   lfsmake2 aws-cli
   lfsmake2 transmission
-  lfsmake2 dpfhack
   lfsmake2 mtr
   lfsmake2 minidlna
   lfsmake2 acpid

diff --git a/src/patches/dpfhack.patch b/src/patches/dpfhack.patch
deleted file mode 100644 (file)
index 2a47317..0000000
--- a/src/patches/dpfhack.patch
+++ /dev/null
@@ -1,12 +0,0 @@
-diff -Naur dpf_alt/python/Makefile dpf/python/Makefile
---- dpf_alt/python/Makefile    2011-04-18 17:14:12.000000000 +0200
-+++ dpf/python/Makefile        2011-08-14 13:22:46.129748815 +0200
-@@ -32,7 +32,7 @@
- endif
- 
- ifeq (Linux, $(PLATFORM))
--      PYTHON=$(shell pyversions -d)
-+      PYTHON=python2.7
-       include $(DEVLIB)/unixdll.mk
-       DLLDEPS = $(CLIENTLIB) -l$(PYTHON)
-       PYTHONINCLUDES = -I/usr/include/$(PYTHON)