build: Move checking for broken symlinks into C

Fixes: #13057 - Broken symlink check seems to fail if spaces are in filename
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Use S_IFMT instead of AE_IFMT

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Append symlink target to dump

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Don't install logrotate files

logrotate has been dropped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Don't run MACRO_FIX_AUTOTOOLS all the time any more

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Fix update config.guess/config.sub macro

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Delete static libraries only when there is a shared object

This brings back the former behaviour.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Refactor the whole thing

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: requires: Search for all reverse dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

search: Consolidate using Dataiterator and add file search

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire_whatprovides/requires: Write to an existant list

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ui: Don't ask any questions if the shell isn't interactive

This is a slight hack because we did not finish implementing a proper
solution with callbacks that we would prefer.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Refactor returning all packages in a repository

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Return some value on push

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelists: Split function to import packages from Queue

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Check if makefile name matches the package name

This is quite important because the build process relies on it.

Fixes: #13041 - pakfire-builder confuses on wrong .nm file name
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Fix sorting when adding more elements

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add a simple test for filelists

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Don't return filelists in a funny order

Since filelists are now ordered, there is no point in trying to be smart
here. In fact it is more efficient to return it pre-sorted.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Rename *_append() to *_add()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: Drop performance_index function

We no longer use this.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Rename *_size() -> *_length()

Also call *_is_empty() wherever suitable as it is much faster.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Remove any *.a and *.la files internally instead of using a script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Implement removing files from a filelist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Implement detecting static libraries and libtool archives

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Drop sort function as filelists are now always sorted

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Refactor the entire module

This carries some changes that will allow us more flexibility with
filelists as they are now based on a slightly easier to manage data
structure.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-requires: Only check for interpreters for executable files

This avoids collecting interpreters from firmware likes like QEMU
installs them for instance.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Add support for arch() namespace

This can be used (mainly in source packages) to check on what system a
package is being installed - but not to check whether it is compatible.

Most commonly, this feature is going to be used to pull in dependencies
that should only be installed on certain architectures.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Fix parsing complex dependencies

It is possible that a complex dependency has more than one closing
bracket. In that case, we will take too much of the string.

This patch makes sure we take the first bracket.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Increase size for /tmp in jail

Some build processes require more temporary space than 1GiB, so I up
this to 4GiB hoping that it will suffice for most builds.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Skip calling scripts if no file matches

Fixes: #13038
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Make killall function static and fix memory leak

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Try to classify files using libmagic

Just filtering by "*.pm" will result in packages that miss some
dependencies, but the provides script generates too many false-positives
so that we cannot just pass the entire filelist.

This will now filter them using libmagic.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Depend on libmagic

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Make it easier to build in a different directory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Define firmwaredir

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

perl: Correctly decode Perl versions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Meson does not support parallel tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Implement filter_provides/filter_requires

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Move regex compilation function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Construct LDFLAGS with more information and add -O1

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Implement configuring timeouts for commands

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: cmake: Fix setting paths

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set container and container_uuid environment variables in jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set SYSTEMD_OFFLINE when in chroot

This will prevent systemctl to talk to systemd which won't work in a
chroot environment.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set LANG to C.utf-8 by default

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Make sure that CMake always uses the correct CFLAGS

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Drop pattern matching from walk function

This is no longer being used.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Bring back pattern matching which was accidentially dropped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Do not add dependencies to files provided by the same package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: communicate: Mark the stdin fd as closed to avoid later writes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Send the scriptlet only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: epoll: Only register for the operations we actually need

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Avoid deadlock when sending data to stdin

It could happen that we filled up the buffer the input pipe and the jail
communication got deadlocked.

This is now being solved by using the event loop to find out when we are
ready to send more data. This required some changes into how the
callbacks behave.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Fix searching for descriptions

SEARCH_SUBSTRING and SEARCH_GLOB does not seem to work together.

Therefore I am dropping SEARCH_GLOB because a substring search is the
more intuitive one.

Fixes: #12998
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: jail: Send signals to ourselves

This should not cause the parent process to die.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: jail: Check for correct exit code on SEGV

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: command: Add a command that immediately causes SEGV

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Return 139 when the child was killed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: jail: Check for correct exit code

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Fix bind-mounting read-only shares

Fixes: #12968
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Remind libtool where to find any system libraries

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Set CC and CXX environment variables to the default compilers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transactions: Fix showing freed space

Fixes: #13013
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Append -pipe to CFLAGS

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Support export VAR += VALUE

Fixes: #13011
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Move CFLAGS/CXXFLAGS/LDFLAGS into the build section

This is where they belong and it makes it easier to modify them in the
build section of individual packages.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Do not log skipped dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add -Wl,--as-needed to LDFLAGS by default

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix FTBFS linux/fcntl.h and fcntl.h are incompatible

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Bump release to 0.9.28

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Avoid reading past the end of the key buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Avoid double brackets in section name

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Ensure /etc/pakfire/repos exists before writing files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create a new network namespace unless running interactively

This will deny any internet connectivity in the build environment, but
will allow users in an interative shell to use the network.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set HOME in shell environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progressbar: Don't join rendering thread when it has never been started

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Silence a compiler warning that a comment contains /*

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "packages: Ensure that the pool is internalized for packages w/o repo"

This reverts commit 2fcc2e22f92577c8bf572a3276445fd6869eb158.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Make pattern matching less eager

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add newline to python3_version output

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix off-by-one error when deleting files

The last file was never deleted.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Sort the filelist before writing the package

This is probably not strictly necessary, but is nicer for humans.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Don't print empty string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Fix function declaration for yy_scan_bytes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Actually check whether title is set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Free correct value

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Fix my messy code and use proper return codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Don't make types array static

Let the compiler decide what is best.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Skip requires which are provided by the same package

This will avoid that the dependency resolution has to deal with
dependencies which should not really exist.

Fixes: #13000
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Ensure that the pool is internalized for packages w/o repo

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Add function to check whether a depenency matches

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Use self-provides function from libsolv

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Add error message when digest isn't set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix compiler warning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix checking scriptlets for any dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Do not link against libsolv-ext any more

We do not use anything that is part of this library.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-provides/requires: Drop Perl handling

This is now done in a separate script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Sort the filelist after scanning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>