gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
   4         (tui_update_source_windows_with_line): Update.
   5         * tui/tui-source.h (struct tui_source_window)
   6         <show_symtab_source>: Declare.
   7         (tui_show_symtab_source): Don't declare.
   8         * tui/tui-source.c (tui_show_symtab_source): Rename from
   9         tui_show_symtab_source.
  10
  11 2019-08-16  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-winsource.h (struct tui_source_window_base)
  14         <set_contents>: Declare.
  15         * tui/tui-winsource.c
  16         (tui_source_window_base::update_source_window_as_is): Update.
  17         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  18         Declare.
  19         (tui_set_source_content): Don't declare.
  20         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  21         tui_set_source_content.
  22         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  23         Declare.
  24         (tui_set_disassem_content): Don't declare.
  25         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  26         tui_set_disassem_content.
  27
  28 2019-08-16  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-winsource.h (struct tui_source_window_base)
  31         <update_breakpoint_info>: Declare.
  32         (tui_update_breakpoint_info): Don't declare.
  33         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  34         (tui_update_all_breakpoint_info): Update.
  35         (tui_source_window_base::update_breakpoint_info): Rename from
  36         tui_update_breakpoint_info.
  37         (tui_source_window_base::update_exec_info): Update.
  38
  39 2019-08-16  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-winsource.h (struct tui_source_window_base)
  42         <update_source_window>: Declare.
  43         (tui_update_source_window): Don't declare.
  44         * tui/tui-winsource.c
  45         (tui_source_window_base::update_source_window): Rename from
  46         tui_update_source_window.
  47         (tui_source_window_base::rerender): Update.
  48         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  49         * tui/tui-disasm.c (tui_show_disassem)
  50         (tui_show_disassem_and_update_source)
  51         (tui_disasm_window::maybe_update): Update.
  52
  53 2019-08-16  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.h (struct tui_source_window_base)
  56         <update_source_window_as_is>: Declare.
  57         (tui_update_source_window_as_is): Don't declare.
  58         * tui/tui-winsource.c (tui_update_source_window): Update
  59         (tui_source_window_base::update_source_window_as_is): Rename from
  60         tui_update_source_window_as_is.
  61         (tui_source_window_base::refill): Update.
  62         * tui/tui-source.c (tui_show_symtab_source): Update.
  63         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  64         Update.
  65
  66 2019-08-16  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-winsource.h (tui_update_source_window)
  69         (tui_update_source_window_as_is): Remove "noerror" parameter.
  70         * tui/tui-winsource.c (tui_update_source_window)
  71         (tui_update_source_window_as_is): Remove "noerror" parameter.
  72         (tui_update_source_windows_with_addr)
  73         (tui_update_source_windows_with_line)
  74         (tui_source_window_base::rerender)
  75         (tui_source_window_base::refill): Update.
  76         * tui/tui-source.h (tui_set_source_content)
  77         (tui_show_symtab_source): Remove "noerror" parameter.
  78         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  79         parameter.
  80         (tui_show_symtab_source): Likewise.
  81         (tui_source_window::maybe_update): Update.
  82         * tui/tui-disasm.c (tui_show_disassem)
  83         (tui_show_disassem_and_update_source)
  84         (tui_disasm_window::do_scroll_vertical)
  85         (tui_disasm_window::maybe_update): Update.
  86
  87 2019-08-16  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui.c (tui_is_window_visible): Update.
  90         * tui/tui-wingeneral.c (tui_make_window)
  91         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  92         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  93         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  94         (tui_set_win_height_command, parse_scrolling_args): Update.
  95         * tui/tui-source.c (tui_source_window::style_changed): Update.
  96         * tui/tui-regs.c (tui_show_registers)
  97         (tui_data_window::first_data_item_displayed)
  98         (tui_data_window::delete_data_content_windows)
  99         (tui_check_register_values, tui_reg_command): Update.
 100         * tui/tui-disasm.c (tui_show_disassem): Update.
 101         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 102         method.
 103         <is_visible>: Remove field.
 104         * tui/tui-data.c (tui_next_win, tui_prev_win)
 105         (tui_delete_invisible_windows): Update.
 106
 107 2019-08-16  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-winsource.h (struct tui_source_window_base)
 110         <m_has_locator>: Remove.
 111         * tui/tui-layout.c (show_source_disasm_command, show_data)
 112         (show_source_or_disasm_and_command): Update.
 113
 114 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 115
 116         * NEWS (Other MI changes): New subsection.
 117         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 118         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 119         * arch-utils.c (default_get_pc_address_flags): New function.
 120         * arch-utils.h (default_get_pc_address_flags): New declaration.
 121         * gdbarch.sh: Add get_pc_address_flags.
 122         * gdbarch.c: Regenerate.
 123         * gdbarch.h: Likewise.
 124         * stack.c (print_pc): New function.
 125         (print_frame_info) (print_frame): Call print_pc.
 126
 127 2019-08-16  Tom de Vries  <tdevries@suse.de>
 128
 129         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 130         print_objfile_section_info.
 131
 132 2019-08-15  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 135         calling update_cmdwin_start_line.
 136         * tui/tui-winsource.h (struct tui_source_window_base)
 137         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 138         <rerender>: Declare.
 139         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 140         Call rerender.
 141         (tui_source_window_base::set_new_height): Remove.
 142         (tui_source_window_base::rerender): Rename from
 143         do_make_visible_with_new_height.
 144         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 145         resize method.
 146         (tui_win_info::make_invisible_and_set_new_height)
 147         (tui_win_info::make_visible_with_new_height): Remove.
 148         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 149         Declare.
 150         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 151         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 152         do_make_visible_with_new_height>: Don't declare.
 153         <rerender>: Declare.
 154         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 155         set_new_height.
 156         (tui_data_window::do_make_visible_with_new_height): Remove.
 157         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 158         call tui_show_locator_content.
 159         (tui_gen_win_info::resize): Call rerender.
 160         (show_source_or_disasm_and_command): Don't call
 161         tui_show_locator_content.
 162         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 163         method.
 164         (struct tui_win_info) <rerender>: Declare.
 165         <set_new_height, make_invisible_and_set_new_height,
 166         make_visible_with_new_height>: Don't declare.
 167         * tui/tui-data.c (tui_win_list::rerender): New method.
 168         * tui/tui-command.h (struct tui_cmd_window)
 169         <do_make_visible_with_new_height>: Don't declare.
 170         * tui/tui-command.c
 171         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 172
 173 2019-08-15  Tom Tromey  <tromey@adacore.com>
 174
 175         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 176         * ada-lang.c (ada_enum_name): Likewise.
 177
 178 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 179
 180         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 181         leading underscore.
 182         (GdbOutputErrorFile): Likewise.
 183         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 184         accordingly.
 185         (execute_unwinders): Rename to have a leading underscore.
 186         (auto_load_packages): Likewise.
 187         (global scope): Adjust call to auto_load_packages accordingly.
 188         (GdbSetPythonDirectory): Likewise.
 189         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 190         instead of execute_unwinders.
 191
 192 2019-08-15  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 195         (show_data): Don't change window visibility.
 196         (tui_gen_win_info::resize): Remove special case for command
 197         window.  Use wresize, when available.
 198         (show_source_or_disasm_and_command): Don't change window
 199         visibility.
 200         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 201         <make_visible>: New method.
 202         * tui/tui-command.c (tui_cmd_window::resize): New method.
 203
 204 2019-08-15  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 207         (struct tui_source_windows): New.
 208         * tui/tui-winsource.c (tui_display_main): Update.
 209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 210         (new_height_ok, parse_scrolling_args): Update.
 211         * tui/tui-layout.c (show_layout, show_data): Update.
 212         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 213         (tui_add_to_source_windows): Don't declare.
 214         * tui/tui-data.c (source_windows, tui_source_windows)
 215         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 216
 217 2019-08-15  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 220         Rename from reset.
 221         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 222         * tui/tui-layout.c (show_source_disasm_command, show_data):
 223         Update.
 224         (tui_gen_win_info::resize): Rename.
 225         (show_source_or_disasm_and_command): Update.
 226         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 227         reset.
 228
 229 2019-08-15  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 232         * tui/tui-interp.c (tui_interp::init): Don't call
 233         tui_initialize_static_data.
 234         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 235
 236 2019-08-15  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 239         examine tui_win_list.
 240
 241 2019-08-15  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 244         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 245         tui_clear_source_content.
 246         (tui_clear_source_content): Remove.
 247         (tui_source_window_base::do_erase_source_content): Hoist call to
 248         content.clear().
 249         * tui/tui-stack.c (tui_show_frame_info): Don't call
 250         tui_clear_source_content.
 251
 252 2019-08-15  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-winsource.h (struct tui_source_window_base)
 255         <do_erase_source_content>: New method.
 256         <erase_source_content>: New method.
 257         (tui_erase_source_content): Don't declare.
 258         * tui/tui-winsource.c (tui_clear_source_content): Update.
 259         (tui_source_window_base::do_erase_source_content): Rename from
 260         tui_erase_source_content.
 261         (tui_source_window_base::show_source_content): Update.
 262         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 263         * tui/tui-source.h (struct tui_source_window)
 264         <erase_source_content>: New method.
 265         * tui/tui-disasm.h (struct tui_disasm_window)
 266         <erase_source_content>: New method.
 267
 268 2019-08-15  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 271         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 272         constructor.
 273         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 274         * tui/tui-source.c (tui_set_source_content): Update.
 275         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 276
 277 2019-08-15  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 280         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 281         tui-source.c.
 282         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 283         Declare.
 284         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 285         method.
 286         (tui_source_window::maybe_update): Update.
 287
 288 2019-08-15  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 291         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 292         tui-disasm.c.
 293         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 294         Declare.
 295         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 296         method.
 297         (tui_disasm_window::maybe_update): Update.
 298
 299 2019-08-15  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-winsource.h (struct tui_source_window_base)
 302         <maybe_update>: Declare.
 303         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 304         method.
 305         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 306         Declare.
 307         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 308         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 309         Declare.
 310         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 311
 312 2019-08-15  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 315
 316 2019-08-15  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-wingeneral.c: Include tui-stack.h.
 319         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 320         (struct tui_locator_window): Move from tui-data.h.
 321         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 322         (tui_initialize_static_data): Move from tui-data.c.
 323         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 324         (struct tui_locator_window): Move to tui-stack.c.
 325         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 326         (tui_initialize_static_data): Move to tui-stack.c.
 327
 328 2019-08-15  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-layout.c (show_source_disasm_command)
 331         (show_source_or_disasm_and_command): Use make_visible method, not
 332         tui_make_window.
 333         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 334         Remove.
 335
 336 2019-08-15  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-wingeneral.h (tui_make_window): Update.
 339         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 340         parameter.
 341         (tui_gen_win_info::make_visible): Update.
 342         * tui/tui-regs.c (tui_data_window::display_registers_from):
 343         Update.
 344         * tui/tui-layout.c (show_source_disasm_command)
 345         (show_source_or_disasm_and_command): Update.
 346         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 347         (enum tui_box): Remove.
 348         (struct tui_win_info) <can_box>: New method.
 349         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 350         method.
 351
 352 2019-08-15  Tom de Vries  <tdevries@suse.de>
 353
 354         * linux-nat-trad.c: Include gdbarch.h.
 355
 356 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 357
 358         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 359         register sizes.
 360
 361 2019-08-14  Tom Tromey  <tromey@adacore.com>
 362
 363         * darwin-nat.c: Include gdbarch.h.
 364         * darwin-nat-info.c: Include gdbarch.h.
 365
 366 2019-08-13  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 369         Remove.
 370         * tui/tui-data.c (tui_initialize_static_data): Update.
 371
 372 2019-08-13  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.h (struct tui_exec_info_window)
 375         <~tui_exec_info_window, maybe_allocate_content, get_content,
 376         m_content>: Remove.
 377         (struct tui_source_window_base) <set_exec_info_content,
 378         show_exec_info_content>: Don't declare.
 379         * tui/tui-winsource.c
 380         (tui_exec_info_window::maybe_allocate_content): Remove.
 381         (tui_source_window_base::update_exec_info): Rename from
 382         set_exec_info_content.
 383         (tui_source_window_base::show_exec_info_content)
 384         (tui_source_window_base::update_exec_info): Remove.
 385
 386 2019-08-13  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 389         declare.
 390         * tui/tui-winsource.c (tui_update_source_window_as_is)
 391         (tui_update_source_windows_with_addr, tui_erase_source_content):
 392         Update.
 393         (tui_clear_exec_info_content): Remove.
 394
 395 2019-08-13  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 398         declare.
 399         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 400         call tui_erase_exec_info_content.
 401         (tui_clear_exec_info_content): Rename from
 402         tui_erase_exec_info_content.
 403         (tui_clear_exec_info_content): Delete.
 404
 405 2019-08-13  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-winsource.h (struct tui_source_window_base)
 408         <show_exec_info_content>: Declare.
 409         (tui_show_exec_info_content): Don't declare.
 410         * tui/tui-winsource.c
 411         (tui_source_window_base::show_exec_info_content): Rename from
 412         tui_show_exec_info_content.
 413         (tui_source_window_base::update_exec_info): Update.
 414
 415 2019-08-13  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 418         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 419         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 420         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 421         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 422         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 423         ... here.
 424
 425 2019-08-13  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.h (struct tui_source_window_base)
 428         <update_exec_info>: Declare.
 429         (tui_update_exec_info): Don't declare.
 430         * tui/tui-winsource.c (tui_update_source_window_as_is)
 431         (tui_source_window_base::refresh_all)
 432         (tui_update_all_breakpoint_info): Update.
 433         (tui_source_window_base::update_exec_info): Rename from
 434         tui_update_exec_info.
 435         * tui/tui-stack.c (tui_show_frame_info): Update.
 436
 437 2019-08-13  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-winsource.h (struct tui_source_window_base)
 440         <set_exec_info_content>: Declare.
 441         (tui_set_exec_info_content): Don't declare.
 442         * tui/tui-winsource.c
 443         (tui_source_window_base::set_exec_info_content): Rename from
 444         tui_set_exec_info_content.
 445         (tui_update_exec_info): Update.
 446
 447 2019-08-13  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.h (struct tui_source_window_base)
 450         <show_source_content>: Declare.
 451         (tui_show_source_content): Don't declare.
 452         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 453         (tui_source_window_base::show_source_content): Rename from
 454         tui_show_source_content.
 455         (tui_source_window_base::refresh_all): Update.
 456         * tui/tui-layout.c (show_source_disasm_command)
 457         (show_source_or_disasm_and_command): Update.
 458
 459 2019-08-13  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.c (tui_erase_source_content)
 462         (tui_show_source_content, tui_source_window_base::refresh_all):
 463         Update.
 464         * tui/tui-wingeneral.h
 465         (tui_check_and_display_highlight_if_needed): Don't declare.
 466         * tui/tui-wingeneral.c
 467         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 468         check_and_display_highlight_if_needed.
 469         * tui/tui-win.c (tui_rehighlight_all)
 470         (tui_win_info::make_visible_with_new_height): Update.
 471         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 472         (tui_data_window::erase_data_content)
 473         (tui_data_window::display_all_data): Update.
 474         * tui/tui-data.h (struct tui_win_info)
 475         <check_and_display_highlight_if_needed>: Declare.
 476
 477 2019-08-13  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-win.c (tui_resize_all): Call
 480         tui_delete_invisible_windows.
 481         * tui/tui-layout.c (show_layout): Call
 482         tui_delete_invisible_windows.
 483         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 484         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 485
 486 2019-08-13  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 489         tui_add_win_to_layout.
 490
 491 2019-08-13  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 494         * tui/tui-layout.c (tui_default_win_height): Now static.
 495
 496 2019-08-13  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 499         single switch.
 500         (show_source_disasm_command, show_source_or_disasm_and_command):
 501         Don't check current layout.
 502
 503 2019-08-13  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-wingeneral.c (make_all_visible): Remove.
 506         (tui_make_all_invisible): Simplify.
 507         * tui/tui-layout.c (tui_make_all_invisible): Move from
 508         tui-wingeneral.c; simplify.
 509         (show_layout): Hoist call to tui_make_all_invisible.
 510         (show_data): Don't call tui_make_all_invisible.
 511
 512 2019-08-13  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 515         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 516
 517 2019-08-13  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 520         tui-data.c.
 521         (show_source_disasm_command, show_data)
 522         (show_source_or_disasm_and_command): Don't use
 523         tui_set_current_layout_to.
 524         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 525         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 526         tui-layout.c.
 527         (tui_set_current_layout_to): Remove.
 528
 529 2019-08-13  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-layout.c (tui_set_layout): Update.
 532         * tui/tui-data.h (struct tui_layout_def): Remove.
 533         (tui_layout_def): Don't declare.
 534         * tui/tui-data.c (layout_def): Remove.
 535         (tui_layout_def): Remove.
 536
 537 2019-08-13  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-winsource.h (struct tui_source_window_base)
 540         <clear_detail>: No longer "override".
 541         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 542         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 543         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 544         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 545         Remove.
 546         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 547
 548 2019-08-13  Tom Tromey  <tromey@adacore.com>
 549
 550         * tracepoint.c: Don't include readline.h or history.h.
 551
 552 2019-08-12  Tom Tromey  <tom@tromey.com>
 553
 554         * configure: Rebuild.
 555         * configure.ac: Check for readline 7.
 556         * NEWS: Mention readline 7 requirement.
 557         * README: Update.
 558
 559 2019-08-12  Tom Tromey  <tom@tromey.com>
 560
 561         * mingw-hdep.c (gdb_select): Remove readline hack.
 562
 563 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 564
 565         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 566         when the function fails.
 567
 568 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 569
 570         * s390-tdep.c (s390_type_align): New function.
 571         (s390_gdbarch_init): Set it as type_align gdbarch method.
 572
 573 2019-08-09  Tom de Vries  <tdevries@suse.de>
 574
 575         PR gdb/24591
 576         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 577         pc_low with relocation offset.
 578
 579 2019-08-07  Tom Tromey  <tromey@adacore.com>
 580
 581         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 582         (print_frame_args): Update.
 583         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 584         Update.
 585         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 586         * frame.h (struct frame_arg): Add initializers.
 587         <error>: Now a unique_xmalloc_ptr.
 588
 589 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 590
 591         * NEWS: Expand the Pointer Authentication entry.
 592         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 593         (aarch64_frame_unmask_lr): ... to this.
 594         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 595         Call aarch64_frame_unmask_lr.
 596         * frame.c (struct frame_info): Add "masked" variable.
 597         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 598         (fprint_frame): Check for masked pc.
 599         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 600         declarations.
 601         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 602         * stack.c (print_frame): Check for masked pc.
 603
 604 2019-08-06  Tom Tromey  <tom@tromey.com>
 605
 606         * stabsread.c (patch_block_stabs, read_one_struct_field)
 607         (read_enum_type): Use obstack_strndup.
 608         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 609         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 610         * dwarf2read.c (guess_full_die_structure_name)
 611         (anonymous_struct_prefix): Use obstack_strndup.
 612         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 613         * c-exp.y (yylex): Use obstack_strndup.
 614         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 615         (write_var_or_type): Use obstack_strndup.
 616
 617 2019-08-06  Tom Tromey  <tom@tromey.com>
 618
 619         * symfile.c (reread_symbols): Use obstack_strdup.
 620         * stabsread.c (read_type): Use obstack_strdup.
 621         * gdb_obstack.h (obstack_strdup): New overload.
 622         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 623         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 624         (dwarf2_canonicalize_name): Use obstack_strdup.
 625         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 626         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 627         Use obstack_strdup.
 628
 629 2019-08-06  Tom Tromey  <tom@tromey.com>
 630
 631         * gdb_obstack.h (obstack_strdup): Define.
 632         * gdb_obstack.c (obstack_strdup): Don't define.
 633
 634 2019-08-06  Tom Tromey  <tom@tromey.com>
 635
 636         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 637         obstack_strdup.
 638         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 639         obstack_strdup.
 640         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 641         * stabsread.c (common_block_start): Use obstack_strdup.
 642         * objfiles.c (set_objfile_main_name, objfile): Use
 643         obstack_strdup.
 644         * namespace.c (add_using_directive): Use obstack_strdup.
 645         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 646         * jit.c (finalize_symtab): Use obstack_strdup.
 647         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 648         (guess_partial_die_structure_name, partial_die_info::fixup)
 649         (dwarf2_name): Use obstack_strdup.
 650         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 651         obstack_strdup.
 652         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 653         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 654         obstack_strdup.
 655         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 656
 657 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 658
 659         * unittests/help-doc-selftests.c: New file.
 660         * Makefile.in: Add the new file.
 661
 662 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 665         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 666         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 667         the trailing '.' is not output, and the first character is uppercased.
 668         (print_help_for_command): Update call to print_doc_line.
 669         (print_doc_of_command): Likewise.
 670         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 671         * cli/cli-option.c (append_indented_doc): Do not append newline.
 672         (build_help_option): Append newline after first appended_indented_doc
 673         only if a second call is done.
 674         (build_help): Append 2 new lines before each option, except the first
 675         one.
 676         * compile/compile.c (_initialize_compile): Add new lines after
 677         %OPTIONS%, when not at the end of the help.
 678         Change help doc or code
 679         producing the help doc to respect the invariants.
 680         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 681         Also removed the new line after 'Options:', as all other commands
 682         do not put an empty line between 'Options:' and the first option.
 683         * printcmd.c (_initialize_printcmd): Likewise.
 684         * stack.c (_initialize_stack): Likewise.
 685         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 686         incorrectly telling COMMAND is optional.
 687         * ada-lang.c (_initialize_ada_language): Change help doc or code
 688         producing the help doc to respect the invariants.
 689         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 690         * breakpoint.c (_initialize_breakpoint): Likewise.
 691         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 692         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 693         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 694         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 695         _initialize_cli_style): Likewise.
 696         * corelow.c (core_target_info): Likewise.
 697         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 698         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 699         * filesystem.c (_initialize_filesystem): Likewise.
 700         * frame.c (_initialize_frame): Likewise.
 701         * gnu-nat.c (add_task_commands): Likewise.
 702         * infcall.c (_initialize_infcall): Likewise.
 703         * infcmd.c (_initialize_infcmd): Likewise.
 704         * interps.c (_initialize_interpreter): Likewise.
 705         * language.c (_initialize_language): Likewise.
 706         * linux-fork.c (_initialize_linux_fork): Likewise.
 707         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 708         * maint.c (_initialize_maint_cmds): Likewise.
 709         * memattr.c (_initialize_mem): Likewise.
 710         * printcmd.c (_initialize_printcmd): Likewise.
 711         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 712         _RegEx): Likewise.
 713         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 714         * record-btrace.c (_initialize_record_btrace): Likewise.
 715         * record-full.c (_initialize_record_full): Likewise.
 716         * record.c (_initialize_record): Likewise.
 717         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 718         * regcache.c (_initialize_regcache): Likewise.
 719         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 720         _initialize_remote): Likewise.
 721         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 722         * serial.c (_initialize_serial): Likewise.
 723         * skip.c (_initialize_step_skip): Likewise.
 724         * source.c (_initialize_source): Likewise.
 725         * stack.c (_initialize_stack): Likewise.
 726         * symfile.c (_initialize_symfile): Likewise.
 727         * symtab.c (_initialize_symtab): Likewise.
 728         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 729         * top.c (init_main): Likewise.
 730         * tracefile-tfile.c (tfile_target_info): Likewise.
 731         * tracepoint.c (_initialize_tracepoint): Likewise.
 732         * tui/tui-win.c (_initialize_tui_win): Likewise.
 733         * utils.c (add_internal_problem_command): Likewise.
 734         * valprint.c (value_print_option_defs): Likewise.
 735
 736 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 737
 738         PR build/24886
 739         * configure.ac: Drop enable-libmcheck support.
 740         * configure, config.in: Rebuild.
 741         * libmcheck.m4: Remove.
 742         * acinclude.m4: Don't include it.
 743         * Makefile.in: Don't distribute it.
 744         * top.c (print_gdb_configuration): Don't mention it.
 745
 746 2019-08-06  Tom Tromey  <tom@tromey.com>
 747
 748         * utils.c (set_output_style): Sometimes pass stream to
 749         emit_style_escape.
 750         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 751         * record-btrace.c (btrace_insn_history): Update.
 752         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 753         method.
 754         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 755         Update initializers.
 756         <m_uiout>: New field.
 757         <m_di>: Move lower.
 758         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 759         Remove "uiout" parameter.
 760         (dump_insns): Update.
 761         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 762         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 763
 764 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 765
 766         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 767         (error_in_psymtab_expansion): Likewise.
 768         (lookup_symbol_via_quick_fns): Likewise.
 769         (basic_lookup_transparent_type_quick): Likewise.
 770         (basic_lookup_transparent_type_1): Likewise.
 771
 772 2019-08-06  Tom Tromey  <tromey@adacore.com>
 773
 774         * source.c (last_source_error): Now bool.
 775         (print_source_lines_base): Make "noprint" bool.  Only open
 776         source file when last_source_visited changes.
 777
 778 2019-08-06  Tom Tromey  <tromey@adacore.com>
 779
 780         * annotate.c (annotate_source_line): Use g_source_cache.
 781         * source-cache.c (source_cache::get_plain_source_lines): Change
 782         parameters.  Populate m_offset_cache.
 783         (source_cache::ensure): New method.
 784         (source_cache::get_line_charpos): New method.
 785         (extract_lines): Move lower.  Change parameters.
 786         (source_cache::get_source_lines): Move lower.
 787         * source-cache.h (class source_cache): Update comment.
 788         <get_line_charpos>: New method.
 789         <get_source_lines>: Update comment.
 790         <clear>: Clear m_offset_cache.
 791         <get_plain_source_lines>: Change parameters.
 792         <ensure>: New method
 793         <m_offset_cache>: New member.
 794         * source.c (forget_cached_source_info_for_objfile): Update.
 795         (info_source_command): Use g_source_cache.
 796         (find_source_lines, open_source_file_with_line_charpos): Remove.
 797         (print_source_lines_base, search_command_helper): Use g_source_cache.
 798         * source.h (open_source_file_with_line_charpos): Don't declare.
 799         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 800         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 801         Use g_source_cache.
 802
 803 2019-08-06  Tom Tromey  <tromey@adacore.com>
 804
 805         * source-cache.c (source_cache::get_plain_source_lines):
 806         Remove "first_line" and "last_line" parameters.
 807         (source_cache::get_source_lines): Cache plain text.
 808         * source-cache.h (class source_cache)
 809         <get_plain_source_lines>: Update.
 810
 811 2019-08-06  Tom Tromey  <tromey@adacore.com>
 812
 813         * source-cache.c (extract_lines): No longer a method.
 814         Changed type of parameter.  Include final newline.
 815         (selftests::extract_lines_test): New function.
 816         (_initialize_source_cache): Likewise.
 817         * source-cache.h (class source_cache)
 818         <extract_lines>: Don't declare.
 819
 820 2019-08-06  Tom Tromey  <tromey@adacore.com>
 821
 822         * breakpoint.c (init_breakpoint_sal): Update.
 823         (breakpoint): Update.
 824         * breakpoint.h (struct breakpoint) <filter>: Now a
 825         unique_xmalloc_ptr.
 826
 827 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 828
 829         * NEWS: Mention dictionary access on blocks.
 830         * python/py-block.c (blpy_getitem): New function.
 831         (block_object_as_mapping): New struct.
 832         (block_object_type): Use new struct for tp_as_mapping field.
 833
 834 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 835
 836         * objfiles.h (objfile): Add a comment describing partial symbols.
 837
 838 2019-08-05  Tom Tromey  <tromey@adacore.com>
 839
 840         * compile/compile.c (_initialize_compile): Use _(), not N_().
 841         * thread.c (_initialize_thread): Use _(), not N_().
 842         * stack.c (_initialize_stack): Use _(), not N_().
 843         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 844
 845 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 846
 847         * dwarf2read.c (struct dw2_symtab_iterator):
 848         <want_specific_block>: Remove.
 849         <block_index>: Change type to gdb::optional.
 850         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 851         change type of BLOCK_INDEX parameter to gdb::optional.
 852         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 853         (dw2_lookup_symbol): Don't pass argument for
 854         WANT_SPECIFIC_BLOCK.
 855         (dw2_expand_symtabs_for_function): Don't pass argument for
 856         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 857         (class dw2_debug_names_iterator)
 858         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 859         parameter, change BLOCK_INDEX type to gdb::optional.
 860         <m_want_specific_block>: Remove.
 861         <m_block_index>: Change type to gdb::optional.
 862         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 863         gdb::optional.  Re-write in function of gdb::optional.
 864         (dw2_debug_names_lookup_symbol): Don't pass argument for
 865         WANT_SPECIFIC_BLOCK.
 866         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 867         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 868         BLOCK_INDEX.
 869
 870 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * NEWS: Mention changes to "info sources" command.
 873
 874 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 875
 876         * symtab.c (filename_partial_match_opts): New struct type.
 877         (struct output_source_filename_data): New members
 878         regexp, c_regexp, partial_match.
 879         (output_source_filename): Use new members to decide to print file.
 880         (info_sources_option_defs): New variable.
 881         (make_info_sources_options_def_group, print_info_sources_header,
 882         info_sources_command_completer):
 883         New functions.
 884         (info_sources_command): Read new optional arguments.
 885         (_initialize_symtab): Update info sources help.
 886
 887 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 888
 889         * ada-lang.c (exception_support_info_v0): Renamed from...
 890         (default_exception_support_info): ... this.  Create new
 891         definition for v1.
 892         (ada_has_this_exception_support): Look up catch_handlers_sym.
 893         (ada_exception_support_info_sniffer): Try v0 after default.
 894
 895 2019-08-01  Tom Tromey  <tromey@adacore.com>
 896
 897         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 898         gdbarch.h.
 899
 900 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 901
 902         * s12z-tdep.c: Fix include path for s12z-opc.h.
 903
 904 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 905
 906         * NEWS: Require GNU make 3.82.
 907
 908 2019-07-16  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 911         declare.
 912
 913 2019-07-30  Tom Tromey  <tromey@adacore.com>
 914
 915         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 916
 917 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 918
 919         * printcmd.c (print_address_symbolic): Print negative offsets.
 920         (build_address_symbolic): Force signed arithmetic when computing
 921         offset.
 922
 923 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 924
 925         PR/24474: Add a function to lookup static variables.
 926         * NEWS: Mention this new function.
 927         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 928         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 929         * python/python.c (python_GdbMethods): Add new function.
 930
 931 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 932
 933         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 934         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 935         (objfpy_lookup_static_symbol): New function.
 936         (objfile_object_methods): Add new functions.
 937
 938 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 939
 940         * NEWS: Mention 'set|show print frame-info'.  Mention new
 941         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 942         backtrace argument.  Mention that python frame filtering code
 943         is now consistent with what 'backtrace' command prints.
 944
 945 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 946
 947         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 948         comments.
 949         (print_frame_info_auto, print_frame_info_source_line,
 950         print_frame_info_location, print_frame_info_source_and_location,
 951         print_frame_info_location_and_address, print_frame_info_short_location):
 952         New declarations.
 953         (struct frame_print_options): New member print_frame_info.
 954         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 955         * stack.h (get_user_print_what_frame_info): New declaration.
 956         (frame_show_address): New declaration.
 957         * stack.c (print_frame_arguments_choices): New value 'presence'.
 958         (print_frame_info_auto, print_frame_info_source_line,
 959         print_frame_info_location, print_frame_info_source_and_location,
 960         print_frame_info_location_and_address, print_frame_info_short_location,
 961         print_frame_info_choices, print_frame_info_print_what): New definitions.
 962         (print_frame_args): Only print dots for args if print frame-arguments
 963         is 'presence'.
 964         (frame_print_option_defs): New element for "frame-info".
 965         (get_user_print_what_frame_info): New function.
 966         (frame_show_address): Make non static.  Move comment to stack.h.
 967         (print_frame_info_to_print_what): New function.
 968         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 969         to decide what to print.
 970         (backtrace_command_1): Handle the new print_frame_arguments_presence
 971         value.
 972         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 973         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 974         (py_print_frame): In non-mi mode, use LOCATION as default for
 975         print_what, similarly to frame information printed directly by
 976         backtrace command. Handle frame-info user option in non MI mode.
 977
 978 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 979
 980         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 981         Add case for debugging 32-bit target on 64-bit host.  Revise
 982         comment.
 983
 984 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 985
 986         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 987         instead of find_function_entry_range_from_pc.
 988
 989 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 990
 991         * stack.c (find_frame_funname): Remove code which preferred
 992         minsym over symtab sym in "certain pathological cases".
 993
 994         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 995         parameter.  Change type of "do_demangle" to bool.
 996         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 997         Pass suitable "prefer_sym_over_minsym" flag to
 998         build_address_symbolic().  Don't output "+" for negative offsets.
 999         * printcmd.c (print_address_symbolic): Update invocation of
1000         build_address_symbolic to include a "prefer_sym_over_minsym"
1001         flag.
1002         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1003         Restrict cases in which use of minimal symbol is preferred to that
1004         of a found symbol.  Update comments.
1005
1006         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1007         for entry pc when entry pc is out of range for that FDE.
1008
1009 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1010
1011         PR gdb/24839:
1012         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1013         type.
1014
1015 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1018         this function's Python signature.
1019
1020
1021 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1022
1023         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1024         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1025         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1026         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1027         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1028
1029
1030 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1031
1032         * h8300-tdep.c (h8300_register_name_common): New.
1033         h8300_register_name): Use h8300_register_name_common.
1034         (h8300s_register_name): Likewise.
1035         (h8300sx_register_name): Likewise.
1036         (h8300h_register_nam): New.
1037         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1038
1039
1040 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1041
1042         * arm-tdep.c (arm_skip_cmse_entry): New function.
1043         (arm_is_sgstubs_section): New function.
1044         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1045
1046 2019-07-22  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1049         Don't self-assign.
1050
1051 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1054         type_print.
1055
1056 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1059         so that GDB doesn't match any msymbols when searching in the
1060         TYPES_DOMAIN.
1061         (print_symbol_info): Print using typedef_print or type_print based
1062         on the type of the symbol.  Add updated FIXME comment moved from...
1063         (_initialize_symtab): ... move and update FIXME comment to above.
1064
1065 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * NEWS: Mention adding -q option to "info types".
1068         * symtab.c (struct info_types_options): New struct.
1069         (info_types_options_defs): New variable.
1070         (make_info_types_options_def_group): New function.
1071         (info_types_command): Use gdb::option framework to parse options.
1072         (info_types_command_completer): New function.
1073         (_initialize_symtab): Extend the help text on "info types" and
1074         register command completer.
1075
1076 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1077
1078         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1079         (lookup_symbol_in_objfile): Change int to block_enum and add a
1080         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1081
1082 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1083
1084         * MAINTAINERS (Write After Approval): Add self.
1085
1086 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1089         instruction to the dummy code region.
1090
1091 2019-07-19  Tom Tromey  <tromey@adacore.com>
1092
1093         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1094         (ARGSUSED, PARAMS, __func__): Remove rules.
1095
1096 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1097
1098         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1099         * features/arm/arm-with-iwmmxt.c: Remove.
1100         * features/arm/arm-with-iwmmxt.xml: Remove.
1101         * features/arm/arm-with-m-fpa-layout.c: Remove.
1102         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1103         * features/arm/arm-with-m-vfp-d16.c: Remove.
1104         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1105         * features/arm/arm-with-m.c: Remove.
1106         * features/arm/arm-with-m.xml: Remove.
1107         * features/arm/arm-with-neon.c: Remove.
1108         * features/arm/arm-with-neon.xml: Remove.
1109         * features/arm/arm-with-vfpv2.c: Remove.
1110         * features/arm/arm-with-vfpv2.xml: Remove.
1111         * features/arm/arm-with-vfpv3.c: Remove.
1112         * features/arm/arm-with-vfpv3.xml: Remove.
1113
1114 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1115
1116         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1117
1118 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1119
1120         * arch/aarch32.c (aarch32_create_target_description): Create
1121         target descriptions using features.
1122         * arch/arm.c (arm_create_target_description)
1123         (arm_create_mprofile_target_description): Likewise.
1124         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1125
1126 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * Makefile.in: Add new files.
1129         * aarch32-tdep.c: New file.
1130         * aarch32-tdep.h: New file.
1131         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1132         Call aarch32_read_description.
1133         * arch/aarch32.c: New file.
1134         * arch/aarch32.h: New file.
1135         * arch/arm.c (arm_create_target_description)
1136         (arm_create_mprofile_target_description): New function.
1137         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1138         (arm_create_target_description)
1139         (arm_create_mprofile_target_description): New declaration.
1140         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1141         read_description functions.
1142         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1143         Likewise.
1144         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1145         * arm-tdep.c (tdesc_arm_list): New variable.
1146         (arm_register_g_packet_guesses): Call create description functions.
1147         (arm_read_description) (arm_read_mprofile_description): New
1148         function.
1149         * arm-tdep.h (arm_read_description)
1150         (arm_read_mprofile_description): Add declaration.
1151         * configure.tgt: Add new files.
1152
1153 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1154
1155         * top.c (new_ui_command): Open specified terminal just once.
1156
1157 2019-07-18  Tom Tromey  <tromey@adacore.com>
1158
1159         * symtab.c (main_name): Constify return type.
1160         * symfile.c (set_initial_language): Update.
1161         * symtab.h (main_name): Constify return type.
1162
1163 2019-07-17  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-winsource.c (tui_update_source_window)
1166         (tui_update_source_window_as_is)
1167         (tui_update_source_windows_with_line): Remove return.
1168         * tui/tui-disasm.c (tui_show_disassem)
1169         (tui_show_disassem_and_update_source): Remove return.
1170         * tui/tui.c (tui_reset): Remove return.
1171         * tui/tui-wingeneral.c
1172         (tui_check_and_display_highlight_if_needed): Remove return.
1173
1174 2019-07-17  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1177
1178 2019-07-17  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-winsource.h (struct tui_exec_info_window)
1181         (struct tui_source_window_base): Move from tui-data.h.
1182         * tui/tui-winsource.c: Move many method definitions from
1183         elsewhere.  Remove "structuring" comments.
1184         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1185         (tui_source_window_base::refresh_window): Move to
1186         tui-winsource.c.
1187         * tui/tui-win.c (tui_source_window_base::refresh_all)
1188         (tui_source_window_base::update_tab_width)
1189         (tui_source_window_base::set_new_height)
1190         (tui_source_window_base::do_make_visible_with_new_height): Move to
1191         tui-winsource.c.
1192         * tui/tui-source.h: Update.
1193         * tui/tui-source.c (tui_source_window_base::reset): Move to
1194         tui-winsource.c.
1195         * tui/tui-disasm.h: Update.
1196         * tui/tui-data.h (struct tui_exec_info_window): Move to
1197         tui-winsource.h.
1198         (struct tui_source_window_base): Likewise.
1199         * tui/tui-data.c (tui_source_window_base::clear_detail)
1200         (tui_source_window_base, ~tui_source_window_base): Move to
1201         tui-winsource.c.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-win.c (tui_resize_all)
1206         (tui_source_window_base::update_tab_width)
1207         (tui_adjust_win_heights): Update.
1208         (tui_win_info::make_invisible_and_set_new_height): Rename from
1209         make_invisible_and_set_new_height.
1210         * tui/tui-data.h (struct tui_win_info)
1211         <make_invisible_and_set_new_height>: New method.
1212
1213 2019-07-17  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui.c: Update.
1216         * tui/tui-source.h (struct tui_source_window): Move from
1217         tui-data.h.
1218         * tui/tui-layout.c: Update.
1219         * tui/tui-disasm.c: Update.
1220         * tui/tui-data.h (struct tui_source_window): Move to
1221         tui-source.h.
1222
1223 2019-07-17  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1226         tui-data.h.
1227         * tui/tui-data.h (struct tui_disasm_window): Move to
1228         tui-disasm.h.
1229
1230 2019-07-17  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-regs.h (struct tui_data_item_window): Move from
1233         tui-data.h.
1234         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1235         * tui/tui-data.h (struct tui_data_item_window): Move to
1236         tui-regs.h.
1237         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1238
1239 2019-07-17  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui.c: Update.
1242         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1243         (tui_cmd_window::max_height): Move to tui-command.c.
1244         * tui/tui-layout.c: Update.
1245         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1246         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1247         tui-command.c.
1248         * tui/tui-command.h (struct tui_cmd_window): Move from
1249         tui-data.h.
1250         * tui/tui-command.c: Remove "structuring" comments.
1251         (tui_cmd_window::clear_detail)
1252         (tui_cmd_window::do_make_visible_with_new_height)
1253         (tui_cmd_window::max_height): Move from elsewhere.
1254
1255 2019-07-17  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1258         Now static.
1259         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1260         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1261
1262 2019-07-17  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui.c: Update.
1265         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1266         tui-regs.c.
1267         * tui/tui-windata.h: Remove file.
1268         * tui/tui-windata.c: Remove file.
1269         * tui/tui-win.c (tui_data_window::set_new_height)
1270         (tui_data_window::do_make_visible_with_new_height): Move to
1271         tui-regs.c.
1272         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1273         * tui/tui-regs.c: Remove "structuring" comments.
1274         (tui_data_window::first_data_item_displayed)
1275         (tui_data_window::delete_data_content_windows)
1276         (tui_data_window::erase_data_content)
1277         (tui_data_window::display_all_data)
1278         (tui_data_window::refresh_all)
1279         (tui_data_window::do_scroll_vertical)
1280         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1281         (tui_data_window::do_make_visible_with_new_height)
1282         (tui_data_window::refresh_window): Move from elsewhere.
1283         (_initialize_tui_regs): Move to end of file.
1284         * tui/tui-layout.c: Update.
1285         * tui/tui-hooks.c: Update.
1286         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1287         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1288         tui-regs.c.
1289         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1290
1291 2019-07-17  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1294         seen.
1295
1296 2019-07-17  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-win.c (tui_source_window_base::set_new_height)
1299         (tui_source_window_base::do_make_visible_with_new_height): Use
1300         m_has_locator field directly.
1301         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1302         method.
1303         (struct tui_source_window_base) <has_locator>: Likewise.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1308         Don't declare.
1309         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1310         Remove.
1311         * tui/tui-win.c (tui_source_window_base::set_new_height)
1312         (tui_source_window_base::set_new_height)
1313         (make_invisible_and_set_new_height)
1314         (tui_source_window_base::do_make_visible_with_new_height)
1315         (tui_source_window_base::do_make_visible_with_new_height):
1316         Update.
1317         * tui/tui-layout.c (show_source_disasm_command, show_data)
1318         (show_source_or_disasm_and_command): Update.
1319         * tui/tui-layout.c (show_layout): Update.
1320
1321 2019-07-17  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-layout.c (make_data_window): Remove.
1324         (show_data): Unify creation and re-initialization cases.
1325
1326 2019-07-17  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (make_source_window, make_disasm_window):
1329         Remove.
1330         (show_data): Unify creation and re-initialization cases.
1331
1332 2019-07-17  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-layout.c (make_command_window): Remove.
1335         (show_source_disasm_command, show_source_or_disasm_and_command):
1336         Unify creation and re-initialization cases.
1337
1338 2019-07-17  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1341         creation and re-initialization cases.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-regs.c (tui_get_register): Return void.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1350         Simplify.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1355         resetting.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1360         * tui/tui-regs.c (tui_reg_layout): New function.
1361         (tui_show_registers, tui_reg_command): Use it.
1362         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1363         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1364         parameters.
1365         (tui_layout_command): Remove.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-layout.h (tui/tui-layout): Return void.
1370         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1371
1372 2019-07-17  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-layout.c (show_source_disasm_command, show_data):
1375         Update.
1376         (reset_locator): Remove.
1377         (show_source_or_disasm_and_command): Update.
1378
1379 2019-07-17  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-source.c (tui_source_window_base::reset): Remove
1382         win_type parameter.
1383         * tui/tui-layout.c (make_command_window, make_source_window)
1384         (make_disasm_window, make_data_window)
1385         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1386         (reset_locator, show_source_or_disasm_and_command): Update.
1387         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1388         win_type parameter.
1389         (struct tui_source_window_base) <reset>: Likewise.
1390
1391 2019-07-17  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-layout.c (show_source_disasm_command): Use
1394         reset_locator.
1395         (reset_locator): New function.
1396         (init_and_make_win): Remove.
1397         (show_source_or_disasm_and_command): Use reset_locator.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1402         condition.
1403         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1404         Remove condition.
1405         * tui/tui-source.c (tui_source_window_base::reset): New method.
1406         * tui/tui-layout.c (make_command_window): Don't call
1407         init_and_make_win.
1408         (make_source_window, make_disasm_window): Don't call
1409         make_source_or_disasm_window.
1410         (make_data_window): Don't call init_and_make_win.  Change calling
1411         convention.
1412         (show_source_disasm_command, show_data): Simplify.
1413         (make_source_or_disasm_window): Remove.
1414         (show_source_or_disasm_and_command): Simplify.
1415         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1416         (struct tui_source_window_base) <reset>: Likewise.
1417         <execution_info>: Remove initializer.
1418         * tui/tui-data.c (tui_source_window_base): Initialize
1419         execution_info.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1424         variable.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui.c (tui_rl_other_window): Update.
1429         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1430         superclass method first.  Always iterate over regs_content.
1431         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1432         method.
1433         * tui/tui-win.c (tui_set_focus_command): Update.
1434
1435 2019-07-17  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-win.c (tui_set_focus_command): Rename from
1438         tui_set_focus.  Call tui_enable.
1439         (tui_set_focus_command): Remove.
1440
1441 2019-07-17  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1444         refresh_window.
1445         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1446         touchwin.
1447         (tui_data_window::refresh_window): Call refresh_window on data
1448         items.  Always call superclass refresh_window.
1449         (tui_win_info::refresh): Remove.
1450         (tui_source_window_base::refresh_window): Update.
1451         (tui_refresh_all): Update.
1452         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1453         refresh_window.
1454         (show_source_or_disasm_and_command): Likewise.
1455         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1456         (struct tui_source_window_base) <refresh>: Likewise.
1457
1458 2019-07-17  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.c (tui_clear_source_content)
1461         (tui_show_source_content): Update.
1462         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1463         whether content is empty.
1464         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1465         Remove.
1466
1467 2019-07-17  Tom Tromey  <tom@tromey.com>
1468
1469         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1470         window's contents.
1471         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1472         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1473
1474 2019-07-17  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1477         (struct tui_data_item_window): Update.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1482         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1483         defines.
1484
1485 2019-07-17  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-winsource.h (tui_erase_source_content)
1488         (tui_clear_source_content): Remove "display_prompt" parameter.
1489         * tui/tui-winsource.c (tui_update_source_window_as_is)
1490         (tui_update_source_windows_with_addr): Update.
1491         (tui_clear_source_content): Remove "display_prompt" parameter.
1492         (tui_erase_source_content): Likewise.  Simplify.
1493         (tui_show_source_content): Update.
1494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1495         * tui/tui-stack.c (tui_show_frame_info): Update.
1496         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1497         Remove defines.
1498
1499 2019-07-17  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1502         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1503         parameter.
1504         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1505         parameter.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-winsource.c (tui_clear_source_content)
1510         (tui_show_source_content, tui_show_exec_info_content)
1511         (tui_clear_exec_info_content): Update.
1512         * tui/tui-stack.c (tui_show_locator_content): Update.
1513         (tui_show_frame_info): Update.
1514         * tui/tui-source.h (tui_source_window): Don't declare.
1515         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1516         from tui_source_is_displayed.
1517         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1518         Remove field.
1519         (struct tui_source_window_base) <content_in_use>: New field.  Now
1520         bool.
1521         (struct tui_source_window) <showing_source_p>: New method.
1522         (TUI_SRC_WIN): Change cast.
1523         * tui/tui-data.c (tui_initialize_static_data): Update.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1528         location_matches_p.
1529         * tui/tui-source.c (tui_source_window::location_matches_p): New
1530         method.
1531         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1532         method.
1533         * tui/tui-data.h (struct tui_source_window_base)
1534         <location_matches_p>: New method.
1535         (struct tui_source_window, struct tui_disasm_window)
1536         <location_matches_p>: Likewise.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-win.c (tui_set_win_height_command): Rename from
1541         tui_set_win_height.
1542         (tui_set_win_height_command): Remove.
1543
1544 2019-07-17  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-source.c (tui_source_window): New constructor.  Add
1547         observer.
1548         (~tui_source_window): New destructor.
1549         (tui_source_window::style_changed): New method.
1550         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1551         (tui_attach_detach_observers): Update.
1552         * tui/tui-data.h (struct tui_source_window): Make constructor not
1553         inline.  Add destructor.
1554         (struct tui_source_window) <style_changed>: New method.
1555         <m_observable>: New member.
1556
1557 2019-07-17  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1560         * tui/tui-win.c (tui_resize_all): Fix typo.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1565         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1566         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1567         * tui/tui-win.c (window_name_completer): Use foreach.
1568         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1569         (update_tab_width): Likewise.
1570         * tui/tui-layout.c (show_layout): Update.
1571         * tui/tui-data.h (class tui_window_iterator): New.
1572         (struct all_tui_windows): New.
1573         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1574
1575 2019-07-17  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1578         parameter.  Don't reference globals.
1579         (tui_reg_command): Update.
1580
1581 2019-07-17  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-regs.c (tui_show_registers): Simplify.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-regs.c (tui_show_registers): Update.
1588         (tui_show_register_group): Add win_info parameter.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1593         Rename from tui_display_reg_element_at_line.
1594         (tui_data_window::display_registers_from_line): Update.
1595         * tui/tui-data.h (struct tui_data_window)
1596         <display_reg_element_at_line>: New method.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-regs.h (tui_display_registers_from)
1601         (tui_display_registers_from_line): Don't declare.
1602         * tui/tui-windata.c (tui_data_window::display_all_data)
1603         (tui_data_window::refresh_all)
1604         (tui_data_window::do_scroll_vertical): Update.
1605         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1606         from tui_display_registers_from.
1607         (tui_display_reg_element_at_line): Update.
1608         (tui_data_window::display_registers_from_line): Rename from
1609         tui_display_registers_from_line.
1610         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1611         display_registers_from_line>: New methods.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1616         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1617         from tui_erase_data_content.
1618         (tui_data_window::display_all_data)
1619         (tui_data_window::refresh_all)
1620         (tui_data_window::do_scroll_vertical): Update.
1621         * tui/tui-regs.c (tui_show_registers): Update.
1622         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1623         New method.
1624
1625 2019-07-17  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1628         declare.
1629         * tui/tui-windata.c
1630         (tui_data_window::delete_data_content_windows): Rename from
1631         tui_delete_data_content_windows.
1632         (tui_data_window::display_all_data)
1633         (tui_data_window::do_scroll_vertical): Update.
1634         * tui/tui-data.h (struct tui_data_window)
1635         <delete_data_content_windows>: New method.
1636
1637 2019-07-17  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1640         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1641
1642 2019-07-17  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1645         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1646         from tui_display_all_data.
1647         * tui/tui-win.c
1648         (tui_data_window::do_make_visible_with_new_height): Update.
1649         * tui/tui-regs.c (tui_show_registers): Update.
1650         * tui/tui-layout.c (tui_set_layout): Update.
1651         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1652         method.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1657         * tui/tui-windata.c (tui_display_data_from): Remove.
1658         (tui_data_window::refresh_all): Update.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1663         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1664         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1665         tui_display_registers_from_line.
1666         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1667         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1668         "force_display" parameter.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1673         declare.
1674         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1675         Rename from tui_first_reg_element_no_inline.
1676         (tui_display_reg_element_at_line)
1677         (tui_display_registers_from_line): Update.
1678         * tui/tui-data.h (struct tui_data_window)
1679         <first_reg_element_no_inline>: New method.
1680
1681 2019-07-17  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-windata.c (tui_display_data_from)
1684         (tui_data_window::do_scroll_vertical): Update.
1685         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1686         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1687         Rename from tui_line_from_reg_element_no.
1688         (tui_display_registers_from_line): Update.
1689         * tui/tui-data.h (struct tui_data_window)
1690         <line_from_reg_element_no>: New method.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1695         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1696         tui_last_regs_line_no.
1697         (tui_display_reg_element_at_line)
1698         (tui_display_registers_from_line): Update.
1699         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1700         method.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         PR tui/24722:
1705         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1706         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1707         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1708         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1709         (tui_update_breakpoint_info): Likewise.
1710         * tui/tui-hooks.c (tui_event_create_breakpoint)
1711         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1712         Update.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-winsource.c (tui_update_source_window_as_is)
1721         (tui_update_source_windows_with_addr): Update.
1722         * tui/tui-source.h (tui_set_source_content)
1723         (tui_show_symtab_source): Add "win_info" parameter.
1724         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1725         parameter.
1726         (tui_show_symtab_source): Likewise.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-wingeneral.c
1731         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1736         (struct tui_cmd_window) <can_scroll>: New method.
1737         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1738         method.
1739
1740 2019-07-17  Tom Tromey  <tromey@adacore.com>
1741
1742         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1743         do_field_signed>: Rename.  Change type of "value".
1744         * ui-out.c (ui_out::field_signed): Rename from field_int.
1745         Change type of "value".
1746         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1747         type of "value".
1748         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1749         do_field_int.  Change type of "value".
1750         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1751         do_field_int.  Change type of "value".
1752         * tracepoint.c (trace_status_mi, tfind_1)
1753         (print_one_static_tracepoint_marker): Update.
1754         * thread.c (print_thread_info_1, print_selected_thread_frame):
1755         Update.
1756         * stack.c (print_frame, print_frame_info): Update.
1757         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1758         Update.
1759         * source.c (print_source_lines_base): Update.
1760         * skip.c (info_skip_command): Update.
1761         * record-btrace.c (btrace_ui_out_decode_error)
1762         (btrace_call_history_src_line): Update.
1763         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1764         Update.
1765         * progspace.c (print_program_space): Update.
1766         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1767         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1768         do_field_int.  Change type of "value".
1769         * mi/mi-out.c (mi_ui_out::do_table_begin)
1770         (mi_ui_out::do_table_header): Update.
1771         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1772         type of "value".
1773         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1774         (mi_cmd_data_list_changed_registers, output_register)
1775         (mi_cmd_data_read_memory, mi_load_progress)
1776         (mi_cmd_trace_frame_collected): Update.
1777         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1778         Update.
1779         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1780         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1781         (mi_cmd_var_list_children, varobj_update_one): Update.
1782         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1783         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1784         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1785         * inferior.c (print_inferior): Update.
1786         * gdb_bfd.c (print_one_bfd): Update.
1787         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1788         Update.
1789         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1790         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1791         do_field_int.  Change type of "value".
1792         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1793         do_field_int.  Change type of "value".
1794         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1795         (print_one_breakpoint_location, print_it_catch_fork)
1796         (print_one_catch_fork, print_it_catch_vfork)
1797         (print_one_catch_vfork, print_it_catch_solib)
1798         (print_it_catch_exec, print_it_ranged_breakpoint)
1799         (print_mention_watchpoint, print_mention_masked_watchpoint)
1800         (bkpt_print_it, update_static_tracepoint): Update.
1801         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1802         * break-catch-syscall.c (print_it_catch_syscall): Update.
1803         * ada-tasks.c (print_ada_task_info): Update.
1804         * ada-lang.c (print_it_exception, print_mention_exception):
1805         Update.
1806
1807 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         PR breakpoints/24541
1810         * gdbarch.c: Regenerate.
1811         * gdbarch.h: Regenerate.
1812         * gdbarch.sh: Adjust return type and parameter types for
1813         'stap_adjust_register'.
1814         (i386_stap_adjust_register): Adjust signature and return new
1815         register name.
1816         * stap-probe.c (stap_parse_register_operand): Adjust use of
1817         'gdbarch_stap_adjust_register'.
1818
1819 2019-07-17  Tom Tromey  <tromey@adacore.com>
1820
1821         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1822         declare VEC.
1823         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1824         std::vector.
1825         (struct s390_process_info): Add initializers.
1826         (s390_add_process): Use new.
1827         (s390_linux_nat_target::low_forget_process): Use delete.
1828         (s390_linux_nat_target::low_new_fork)
1829         (s390_linux_nat_target::stopped_by_watchpoint)
1830         (s390_linux_nat_target::low_prepare_to_resume)
1831         (s390_linux_nat_target::insert_watchpoint)
1832         (s390_linux_nat_target::insert_hw_breakpoint)
1833         (s390_linux_nat_target::remove_watchpoint)
1834         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1835
1836 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1837
1838         * aarch64-fbsd-nat.c: Include regcache.h.
1839         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1840         argument.
1841         (aarch64_fbsd_nat_target::fetch_registers)
1842         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1843         variable.
1844         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1845
1846 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1847
1848         * fbsd-nat.c: Include gdbarch.h.
1849
1850 2019-07-15  Tom Tromey  <tromey@adacore.com>
1851
1852         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1853
1854 2019-07-15  Tom Tromey  <tromey@adacore.com>
1855
1856         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1857         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1858         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1859         * cli-out.c (cli_ui_out::do_field_int): New method.
1860         * ui-out.c (ui_out::field_unsigned): New method.
1861         * symfile.c (generic_load): Use field_unsigned.
1862         (print_transfer_performance): Likewise.
1863         * record-btrace.c (ui_out_field_uint): Remove.
1864         (btrace_call_history_insn_range, btrace_call_history): Use
1865         field_unsigned.
1866         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1867         field_unsigned.
1868         * ui-out.h (class ui_out) <field_unsigned>: New method.
1869         <do_field_unsigned>: Likewise.
1870
1871 2019-07-15  Tom Tromey  <tromey@adacore.com>
1872
1873         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1874         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1875         * target.c (flash_erase_command): Use field_string.
1876         * infrun.c (print_signal_received_reason): Use field_string.
1877         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1878         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1879         field_string.
1880         * ada-tasks.c (print_ada_task_info): Use field_string.
1881
1882 2019-07-15  Tom Tromey  <tromey@adacore.com>
1883
1884         * target.c (flash_erase_command): Use field_core_addr.
1885         * symfile.c (generic_load): Use field_core_addr.
1886         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1887         Use field_core_addr.
1888         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1889         field_core_addr.
1890
1891 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1894         value if its desired type is smaller than a CORE_ADDR and signed.
1895
1896 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1899         of changes to field names, and use new is_reference field to
1900         decide if a property is a reference or not.
1901         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1902         field.
1903         (struct dwarf2_property_baton): Update header comment, rename
1904         'referenced_type' to 'property_type' and update comments.
1905         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1906         default property type, store in property baton, update to take
1907         accound of renamed field.
1908         (read_func_scope): Update call to attr_to_dynamic_prop.
1909         (read_array_type): Likewise.
1910         (dwarf2_per_cu_addr_sized_int_type): New function.
1911         (read_subrange_index_type): Move type finding code to
1912         dwarf2_per_cu_addr_sized_int_type.
1913         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1914         (dwarf2_per_cu_addr_type): New function.
1915         (set_die_type): Update calls to attr_to_dynamic_prop.
1916
1917 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * dwarf2read.c (read_subrange_index_type): New function.
1920         (read_subrange_type): Move code into new function and call it.
1921         * gdbtypes.c (create_range_type): Add some asserts.
1922
1923 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1926         update return statements.
1927         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1928         declaration, and update comment to match.
1929         * gdbtypes.c (resolve_dynamic_array): Update call to
1930         dwarf2_evaluate_property to match new return type.
1931
1932 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * valarith.c (value_subscripted_rvalue): Change lowerbound
1935         parameter type from int to LONGEST.
1936         * value.h (value_subscripted_rvalue): Likewise in declaration.
1937
1938 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * cli/cli-utils.c (info_print_command_completer): New function.
1941         * cli/cli-utils.h: Add 'completer.h' include, and forward
1942         declaration for 'struct cmd_list_element'.
1943         (info_print_command_completer): Declare.
1944         * stack.c (_initialize_stack): Add completer for 'info locals' and
1945         'info args'.
1946         * symtab.c (_initialize_symtab): Add completer for 'info
1947         variables' and 'info functions'.
1948         * NEWS: Mention completion for additional info commands.
1949
1950 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * cli/cli-utils.c (extract_info_print_args): Delete.
1953         (extract_arg_maybe_quoted): Delete.
1954         (info_print_options_defs): New variable.
1955         (make_info_print_options_def_group): New function.
1956         (extract_info_print_options): Define new function.
1957         * cli/cli-utils.h (extract_info_print_args): Delete.
1958         (struct info_print_options): New structure.
1959         (extract_info_print_options): Declare new function.
1960         * stack.c (info_locals_command): Update to use new
1961         extract_info_print_options, also add a header comment.
1962         (info_args_command): Likewise.
1963         * symtab.c (info_variables_command): Likewise.
1964         (info_functions_command): Likewise.
1965
1966 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1969         to extract string arguments.
1970         * common/common-utils.c (extract_string_maybe_quoted): New function.
1971         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1972
1973 2019-07-11  Tom Tromey  <tromey@adacore.com>
1974
1975         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1976         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1977         * top.h (gdbinit): Don't declare.
1978         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1979         into...
1980         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1981         * top.c (gdb_init): Don't call init_cli_cmds.
1982         (gdbinit): Remove.
1983         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1984
1985 2019-07-11  Tom Tromey  <tromey@adacore.com>
1986
1987         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1988         after it has been moved.
1989
1990 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * valops.c (value_must_coerce_to_target): Change return type to
1993         bool.
1994         * value.h (value_must_coerce_to_target): Likewise.
1995
1996 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1997
1998         * breakpoint.c (is_hardware_watchpoint): Remove
1999         forward-declaration.
2000         (is_masked_watchpoint): Change return type to bool.
2001         (is_tracepoint): Likewise.
2002         (is_breakpoint): Likewise.
2003         (is_hardware_watchpoint): Likewise.
2004         (is_watchpoint): Likewise.
2005         (is_no_memory_software_watchpoint): Likewise.
2006         (is_catchpoint): Likewise.
2007         (breakpoint_1): Make FILTER parameter's return type bool.
2008         is_masked_watchpoint): Change return type to bool.
2009         (save_breakpoints): Make FILTER parameter's return type bool.
2010         * breakpoint.h (is_breakpoint): Change return type to bool.
2011         (is_watchpoint): Likewise.
2012         (is_catchpoint): Likewise.
2013         (is_tracepoint): Likewise.
2014
2015 2019-07-10  Tom Tromey  <tom@tromey.com>
2016
2017         * defs.h: Don't include gdbarch.h.
2018         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2019         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2020         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2021         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2022         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2023         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2024         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2025         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2026         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2027         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2028         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2029         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2030         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2031         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2032         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2033         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2034         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2035         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2036         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2037         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2038         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2039         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2040         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2041         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2042         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2043         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2044         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2045
2046 2019-07-10  Tom Tromey  <tromey@adacore.com>
2047
2048         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2049         * breakpoint.c (init_ada_exception_breakpoint): Register as
2050         bp_catchpoint.
2051         (print_one_breakpoint_location, print_one_breakpoint): Use
2052         is_ada_exception_catchpoint.
2053         * ada-lang.c (class ada_catchpoint_location): Pass
2054         bp_loc_software_breakpoint to bp_location constructor.
2055         (is_ada_exception_catchpoint): New function.
2056
2057 2019-07-10  Tom Tromey  <tromey@adacore.com>
2058
2059         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2060         VEC.
2061         (struct arm_exidx_entry): New method operator<.
2062         (struct arm_exidx_data) <section_maps>: Change type.
2063         (arm_exidx_data_free): Remove.
2064         (arm_exidx_data_key): Change type.  Move lower.
2065         (arm_exidx_new_objfile): Update.
2066         (arm_compare_exidx_entries): Remove.
2067         (arm_find_exidx_entry, _initialize_arm_tdep)
2068
2069 2019-07-10  Tom Tromey  <tromey@adacore.com>
2070
2071         * solib-spu.c (ocl_program_data_key): Change type.
2072         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2073         Update.
2074
2075 2019-07-10  Tom Tromey  <tromey@adacore.com>
2076
2077         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2078         (struct solib_aix_inferior_data) <library_list>: Change type.
2079         (solib_aix_inferior_data_handle): Change type.
2080         (get_solib_aix_inferior_data): Update.
2081         (solib_aix_free_library_list): Remove.
2082         (library_list_start_library): Update.
2083         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2084         return type.
2085         (solib_aix_get_library_list)
2086         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2087         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2088
2089 2019-07-10  Tom Tromey  <tromey@adacore.com>
2090
2091         * solib-dsbt.c (struct dsbt_info): Add initializers.
2092         (solib_dsbt_pspace_data): Change type.
2093         (dsbt_pspace_data_cleanup): Remove.
2094         (get_dsbt_info, _initialize_dsbt_solib): Update.
2095
2096 2019-07-10  Tom Tromey  <tromey@adacore.com>
2097
2098         * spu-tdep.c (spu_overlay_data): Change type.
2099         (spu_get_overlay_table, spu_overlay_new_objfile)
2100         (_initialize_spu_tdep): Update.
2101
2102 2019-07-10  Tom Tromey  <tromey@adacore.com>
2103
2104         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2105         destructor.
2106         (dbx_objfile_data_key): Change type and declare later.
2107         (DBX_SYMFILE_INFO): Rewrite.
2108         * dbxread.c (dbx_objfile_data_key): Change type.
2109         (dbx_symfile_init): Update.
2110         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2111         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2112         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2113
2114 2019-07-10  Tom Tromey  <tromey@adacore.com>
2115
2116         * jit.c (jit_program_space_key): Change type.  Move lower.
2117         (get_jit_program_space_data): Update.
2118         (jit_program_space_data_cleanup): Remove.
2119         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2120         Update.
2121         (struct jit_program_space_data): Add initializers.
2122
2123 2019-07-10  Tom Tromey  <tromey@adacore.com>
2124
2125         * solib-darwin.c (struct darwin_info): Add initializers.
2126         (solib_darwin_pspace_data): Change type.
2127         (darwin_pspace_data_cleanup): Remove.
2128         (get_darwin_info, _initialize_darwin_solib): Update.
2129
2130 2019-07-10  Tom Tromey  <tromey@adacore.com>
2131
2132         * remote-sim.c (struct sim_inferior_data): Add initializers,
2133         constructor, and destructor.
2134         (sim_inferior_data_key): Change type.  Move lower.
2135         (check_for_duplicate_sim_descriptor): Update.
2136         (get_sim_inferior_data): Use new.  Update.
2137         (~sim_inferior_data_cleanup): Rename from
2138         sim_inferior_data_cleanup.  Simplify.
2139         (gdbsim_close_inferior, simulator_command)
2140         (sim_command_completer, _initialize_remote_sim): Update.
2141         (next_pid, INITIAL_PID): Move earlier.
2142
2143 2019-07-10  Tom Tromey  <tromey@adacore.com>
2144
2145         * python/python-internal.h (create_thread_object): Return
2146         gdbpy_ref.
2147         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2148         * python/py-inferior.c (struct threadlist_entry): Add
2149         constructor.
2150         <thread_obj>: Now a gdbpy_ref.
2151         (thread_to_thread_object): Update.
2152         (add_thread_object): Use new.
2153         (delete_thread_object): Use delete.
2154         (infpy_threads): Update.
2155         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2156         GIL.
2157
2158 2019-07-10  Tom Tromey  <tromey@adacore.com>
2159
2160         * valops.c (value_cast): Specialize error message for Ada.
2161
2162 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2163
2164         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2165
2166 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2167
2168         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2169         bpstat_should_step): Return bool, adjust comments.
2170         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2171         bpstat_should_step): Likewise.
2172
2173 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2174
2175         * features/Makefile: Use feature target descriptions for Arm.
2176         * features/arm/arm-core.c: Generate new file.
2177         * features/arm/arm-fpa.c: Likewise.
2178         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2179         * features/arm/arm-m-profile.c: Likewise.
2180         * features/arm/arm-vfpv2.c: Likewise.
2181         * features/arm/arm-vfpv3.c: Likewise.
2182         * features/arm/xscale-iwmmxt.c: Likewise.
2183         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2184
2185 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2186
2187         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2188         ptrace earlier.
2189
2190 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * features/aarch64-pauth.c: Regenerate.
2193
2194 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2195
2196         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2197         bool.
2198         (bpstat_what): Use false instead of 0.
2199
2200 2019-07-09  Pedro Alves  <palves@redhat.com>
2201
2202         * break-catch-throw.c (is_exception_catchpoint): New.
2203         * breakpoint.c (print_one_breakpoint_location): New parameter
2204         'raw_loc'.  Handle it.  Use
2205         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2206         looking at the breakpoint's type.
2207         (print_one_breakpoint): If handling "maint info breakpoints", also
2208         print locations of exception catchpoints.
2209         * breakpoint.h (is_exception_catchpoint): Declare.
2210
2211 2019-07-09  Pedro Alves  <palves@redhat.com>
2212
2213         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2214         "addr" field.
2215         (allocate_location_exception_catchpoint): New.
2216         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2217         (initialize_throw_catchpoint_ops): Install
2218         allocate_location_exception_catchpoint as allocate_location
2219         method.
2220         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2221         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2222         bp_loc_other.
2223         (breakpoint_address_is_meaningful): Delete.
2224         (bl_address_is_meaningful): New.
2225         (breakpoint_locations_match): Adjust comment.
2226         (bp_location_from_bp_type): New, factored out of...
2227         (bp_location::bp_location(breakpoint *)): ... this.
2228         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2229         factored out of...
2230         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2231         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2232         breakpoint_address_is_meaningful.
2233         (bp_locations_compare): Adjust comment.
2234         (update_global_location_list): Use bl_address_is_meaningful
2235         instead of breakpoint_address_is_meaningful.
2236         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2237         explicit.
2238         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2239         * python/py-breakpoint.c (bppy_get_location): No longer check
2240         whether location is null.
2241
2242 2019-07-09  Pedro Alves  <palves@redhat.com>
2243
2244         PR c++/15468
2245         * breakpoint.c (print_one_breakpoint_location): Remove
2246         single-location assert.
2247
2248 2019-07-09  Tom Tromey  <tom@tromey.com>
2249
2250         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2251         * configure: Rebuild.
2252         * configure.ac: Change common to gdbsupport.
2253         * gdbsupport: Rename from common.
2254         * acinclude.m4: Change common to gdbsupport.
2255         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2256         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2257         gdbsupport.
2258         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2259         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2260         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2261         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2262         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2263         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2264         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2265         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2266         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2267         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2268         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2269         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2270         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2271         coff-pe-read.c, command.h, compile/compile-c-support.c,
2272         compile/compile-c.h, compile/compile-cplus-symbols.c,
2273         compile/compile-cplus-types.c, compile/compile-cplus.h,
2274         compile/compile-loc2c.c, compile/compile.c, completer.c,
2275         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2276         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2277         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2278         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2279         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2280         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2281         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2282         features/aarch64-core.c, features/aarch64-fpu.c,
2283         features/aarch64-pauth.c, features/aarch64-sve.c,
2284         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2285         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2286         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2287         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2288         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2289         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2290         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2291         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2292         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2293         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2294         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2295         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2296         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2297         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2298         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2299         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2300         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2301         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2302         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2303         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2304         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2305         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2306         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2307         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2308         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2309         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2310         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2311         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2312         minsyms.c, mips-linux-tdep.c, namespace.h,
2313         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2314         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2315         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2316         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2317         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2318         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2319         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2320         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2321         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2322         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2323         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2324         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2325         procfs.c, producer.c, progspace.h, psymtab.h,
2326         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2327         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2328         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2329         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2330         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2331         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2332         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2333         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2334         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2335         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2336         target-memory.c, target.c, target.h, target/waitstatus.c,
2337         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2338         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2339         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2340         unittests/array-view-selftests.c,
2341         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2342         unittests/common-utils-selftests.c,
2343         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2344         unittests/format_pieces-selftests.c,
2345         unittests/function-view-selftests.c,
2346         unittests/lookup_name_info-selftests.c,
2347         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2348         unittests/mkdir-recursive-selftests.c,
2349         unittests/observable-selftests.c,
2350         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2351         unittests/parse-connection-spec-selftests.c,
2352         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2353         unittests/scoped_fd-selftests.c,
2354         unittests/scoped_mmap-selftests.c,
2355         unittests/scoped_restore-selftests.c,
2356         unittests/string_view-selftests.c, unittests/style-selftests.c,
2357         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2358         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2359         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2360         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2361         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2362         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2363
2364 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2367         bool value.
2368         (decode_digits_ordinary): Set explicit_line field in sal.
2369         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2370         symtab_and_line that was set on an explicit line number in
2371         assembler code.  Do always update the recorded symtab and line if
2372         we do skip the prologue.
2373
2374 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * breakpoint.c (set_breakpoint_location_function): Remove
2377         explicit_loc parameter.
2378         (momentary_breakpoint_from_master): Update call to
2379         set_breakpoint_location_function.
2380         (add_location_to_breakpoint): Likewise.
2381
2382 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2385         required features based on default bfd type when no specific bfd
2386         is present.
2387
2388 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2389
2390         * NEWS: Mention that GDB printf and eval commands can now print
2391         C-style and Ada-style convenience var strings without
2392         calling the inferior.
2393         * printcmd.c (printf_c_string): Locally print GDB internal var
2394         instead of transiting via the inferior.
2395         (printf_wide_c_string): Likewise.
2396
2397 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2398
2399         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2400
2401 2019-07-04  Tom Tromey  <tom@tromey.com>
2402
2403         PR tui/24724:
2404         * tui/tui-winsource.c (tui_clear_source_content): Update.
2405         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2406         (tui_update_breakpoint_info): Update.
2407         (tui_set_exec_info_content): Update.
2408         * tui/tui-source.c (tui_set_source_content_nil): Update.
2409         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2410         has_break.
2411         * tui/tui-data.h (enum tui_bp_flag): New.
2412         (tui_bp_flags): New enum flags type.
2413         (struct tui_source_element) <break_mode>: Change type.  Rename
2414         from has_break.
2415         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2416         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2417         constants.
2418         * tui/tui-winsource.h: Fix comment.
2419
2420 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2421
2422         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2423         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2424         (store_fpregs_to_thread)
2425         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2426         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2427         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2428         (IWMMXT_REGS_SIZE): Add define.
2429         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2430         (fetch_vfp_regs, store_vfp_regs)
2431         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2432         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2433
2434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2435
2436         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2437         defines.
2438         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2439         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2440         (ARM_INT_REGISTER_SIZE): ...to this.
2441         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2442         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2443         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2444         (arm_linux_collect_gregset, supply_nwfpe_register)
2445         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2446         defines.
2447         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2448         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2449         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2450         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2451         (arm_return_in_memory, arm_store_return_value)
2452         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2453         (arm_record_ld_st_multiple): Likewise.
2454         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2455         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2456
2457 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2458
2459         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2460         AARCH64_DISPLACED_MODIFIED_INSNS.
2461         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2462         (aarch64_displaced_step_copy_insn): Likewise.
2463         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2464         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2465         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2466         ARM_DISPLACED_MODIFIED_INSNS.
2467         * arm-tdep.c (arm_gdbarch_init): Likewise.
2468         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2469         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2470         (struct arm_displaced_step_closure): Use
2471         ARM_DISPLACED_MODIFIED_INSNS.
2472
2473 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2474
2475         * features/Makefile: Remove unused xml files.
2476         * features/aarch64.xml: Remove.
2477         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2478         * features/i386/amd64-avx-avx512.xml: Remove.
2479         * features/i386/amd64-avx-linux.xml: Remove.
2480         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2481         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2482         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2483         * features/i386/amd64-avx-mpx.xml: Remove.
2484         * features/i386/amd64-avx.xml: Remove.
2485         * features/i386/amd64-linux.xml: Remove.
2486         * features/i386/amd64-mpx-linux.xml: Remove.
2487         * features/i386/amd64-mpx.xml: Remove.
2488         * features/i386/amd64.xml: Remove.
2489         * features/i386/i386-avx-avx512-linux.xml: Remove.
2490         * features/i386/i386-avx-avx512.xml: Remove.
2491         * features/i386/i386-avx-linux.xml: Remove.
2492         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2493         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2494         * features/i386/i386-avx-mpx-linux.xml: Remove.
2495         * features/i386/i386-avx-mpx.xml: Remove.
2496         * features/i386/i386-avx.xml: Remove.
2497         * features/i386/i386-linux.xml: Remove.
2498         * features/i386/i386-mmx-linux.xml: Remove.
2499         * features/i386/i386-mmx.xml: Remove.
2500         * features/i386/i386-mpx-linux.xml: Remove.
2501         * features/i386/i386-mpx.xml: Remove.
2502         * features/i386/i386.xml: Remove.
2503         * features/i386/x32-avx-avx512-linux.xml: Remove.
2504         * features/i386/x32-avx-linux.xml: Remove.
2505         * features/i386/x32-linux.xml: Remove.
2506
2507 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2508
2509         * regformats/aarch64.dat: Remove.
2510         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2511         * regformats/i386/amd64-avx-linux.dat: Remove.
2512         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2513         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2514         * regformats/i386/amd64-linux.dat: Remove.
2515         * regformats/i386/amd64-mpx-linux.dat: Remove.
2516         * regformats/i386/amd64.dat: Remove.
2517         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2518         * regformats/i386/i386-avx-linux.dat: Remove.
2519         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2520         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2521         * regformats/i386/i386-linux.dat: Remove.
2522         * regformats/i386/i386-mmx-linux.dat: Remove.
2523         * regformats/i386/i386-mpx-linux.dat: Remove.
2524         * regformats/i386/i386.dat: Remove.
2525         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2526         * regformats/i386/x32-avx-linux.dat: Remove.
2527         * regformats/i386/x32-linux.dat: Remove.
2528
2529 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2530
2531         * aarch64-tdep.c: Remove xml self tests.
2532         * amd64-linux-tdep.c: Likewise.
2533         * amd64-tdep.c: Likewise.
2534         * i386-linux-tdep.c: Likewise.
2535         * i386-tdep.c: Likewise.
2536
2537 2019-07-03  Pedro Alves  <palves@redhat.com>
2538
2539         PR cli/24732
2540         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2541         (pipe_cmd_option_defs): New.
2542         (make_pipe_cmd_options_def_group): New.
2543         (pipe_command): Use gdb::option::process_options.
2544         (pipe_command_completer): New function.
2545         (_initialize_cli_cmds): Install completer for "pipe" command.
2546
2547 2019-07-03  Pedro Alves  <palves@redhat.com>
2548
2549         * cli/cli-option.c (union option_value) <string>: New field.
2550         (struct option_def_and_value): Add ctor, move ctor, dtor and
2551         use DISABLE_COPY_AND_ASSIGN.
2552         (option_def_and_value::clear_value): New.
2553         (parse_option, save_option_value_in_ctx, get_val_type_str)
2554         (add_setshow_cmds_for_options): Handle var_string.
2555         * cli-option.h (union option_def::var_address) <string>: New
2556         field.
2557         (struct string_option_def): New.
2558         * maint-test-options.c (struct test_options_opts): Add default
2559         ctor and use DISABLE_COPY_AND_ASSIGN.
2560         <string_opt>: New field.
2561         (test_options_opts::~test_options_opts): New.
2562         (test_options_opts::dump): Also dump "-string".
2563         (test_options_option_defs): Install "string.
2564
2565 2019-07-03  Pedro Alves  <palves@redhat.com>
2566
2567         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2568         option_value with a null enumeration.
2569         (complete_options): Save the option values in the context.
2570         (save_option_value_in_ctx): New, factored out from ...
2571         (process_options): ... here.
2572         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2573         of the function.
2574         * maint-test-options.c (test_options_opts::dump): New, factored
2575         out from ...
2576         (maintenance_test_options_command_mode): ... here.
2577         (maintenance_test_options_command_completion_result): Delete.
2578         (maintenance_test_options_command_completion_text): Update
2579         comment.
2580         (maintenance_show_test_options_completion_result): Change
2581         prototype.  Just print
2582         maintenance_test_options_command_completion_text.
2583         (save_completion_result): New.
2584         (maintenance_test_options_completer_mode): Pass options context to
2585         complete_options, and then save a dump.
2586         (_initialize_maint_test_options): Use add_cmd to install "maint
2587         show test-options-completion-result".
2588
2589 2019-07-03  Pedro Alves  <palves@redhat.com>
2590
2591         * NEWS (New commands): Mention "with" and "maint with".
2592         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2593         (with_command, with_command_completer): New.
2594         (pipe_command): Adjust to new repeat_previous
2595         interface.
2596         (_initialize_cli_cmds): Install the "with" command and its "w"
2597         alias.
2598         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2599         declarations.
2600         * cli/cli-setshow.c (parse_cli_var_uinteger)
2601         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2602         argument strings for all var_types.
2603         (get_setshow_command_value_string): New, factored out from ...
2604         (do_show_command): ... this.
2605         * cli/cli-setshow.h: Include <string>.
2606         (get_setshow_command_value_string): Declare.
2607         * command.h (repeat_previous): Now returns const char *.  Adjust
2608         comment.
2609         * maint.c: Include "cli/cli-cmds.h".
2610         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2611         (_initialize_maint_cmds): Register the "maintenance with" command.
2612         * top.c (repeat_previous): Move bits from pipe_command here:
2613         Return the saved command line, if any; error out if there's no
2614         command to relaunch.
2615
2616 2019-07-03  Pedro Alves  <palves@redhat.com>
2617
2618         * NEWS (New commands): Mention "maint set/show test-settings"
2619         instead of "maint test-settings".
2620         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2621         (maintenance_test_settings_set_list): Rename to ...
2622         (maintenance_set_test_settings_list): ... this.
2623         (maintenance_test_settings_show_list): Rename to  ...
2624         (maintenance_show_test_settings_list): ... this.
2625         (maintenance_test_settings_cmd): Delete.
2626         (maintenance_test_settings_set_cmd): ...
2627         (maintenance_set_test_settings_cmd): ... this.
2628         (maintenance_test_settings_show_cmd): ...
2629         (maintenance_show_test_settings_cmd): ... this.
2630         (maintenance_test_settings_show_value_cmd):
2631         (maintenance_show_test_settings_value_cmd): ... this.
2632         (_initialize_maint_test_settings): No longer install the "maint
2633         test-settings" prefix command.  Rename "maint test-settings set"
2634         to "maint set test-settings", and "maint test-settings show" to
2635         "maint show test-settings".  Adjust all subcommands.
2636
2637 2019-07-03  Pedro Alves  <palves@redhat.com>
2638
2639         * maint-test-settings.c: Fix file's intro comment.  Replace all
2640         references to "test-options" with references to "test-settings",
2641         in comments.
2642
2643 2019-07-03  Pedro Alves  <palves@redhat.com>
2644
2645         * maint-test-settings.c (maintenance_test_settings_xxx)
2646         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2647         New.
2648         (maintenance_test_settings_enums): Use them.
2649         (maintenance_test_settings_enum): Default to
2650         maintenance_test_settings_xxx.
2651         (_initialize_maint_test_settings): Initialize
2652         MAINTENANCE_TEST_SETTINGS_FILENAME.
2653
2654 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2655
2656         * breakpoint.h (remove_breakpoints_inf): Change return type to
2657         void, move function documentation here.
2658         * breakpoint.c (remove_breakpoints_inf): Change return type to
2659         void, move function documentation to header.
2660
2661 2019-07-02  Pedro Alves  <palves@redhat.com>
2662
2663         * NEWS (Completion improvements): Mention "info threads".
2664         * thread.c (struct info_threads_opts, info_threads_option_defs)
2665         (make_info_threads_options_def_group): New.
2666         (info_threads_command): Use gdb::option::process_options.
2667         (info_threads_command_completer): New.
2668         (_initialize_thread): Use gdb::option::build_help to build the
2669         help text for "info threads".
2670
2671 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2672
2673         * defs.h (generic_load): Move from here...
2674         * symfile.h (generic_load): ... to here.  Rename name parameter
2675         to args.
2676         * symfile.c (generic_load): Add comment.
2677
2678 2019-07-01  Tom Tromey  <tromey@adacore.com>
2679
2680         * dwarf2read.c
2681         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2682         declaration of without_params.  Fix formatting.
2683
2684 2019-07-01  Tom Tromey  <tromey@adacore.com>
2685
2686         * ada-exp.y (find_primitive_type): Update.
2687         * ada-lang.h (ada_lookup_symbol): Update.
2688         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2689         parameter.
2690         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2691
2692 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2693
2694         PR breakpoints/24541
2695         * gdbarch.c: Regenerate.
2696         * gdbarch.h: Regenerate.
2697         * gdbarch.sh: Add 'stap_adjust_register'.
2698         * i386-tdep.c: Include '<unordered_set>'.
2699         (i386_stap_adjust_register): New function.
2700         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2701         * stap-probe.c (stap_parse_register_operand): Call
2702         'gdbarch_stap_adjust_register'.
2703
2704 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2705
2706         PR python/24742
2707         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2708         * python/python.c (do_start_initialization): Use 'xmalloc'
2709         instead of 'PyMem_Malloc'.
2710
2711 2019-06-28  Tom Tromey  <tromey@adacore.com>
2712
2713         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2714         for Ada.
2715
2716 2019-06-27  Tom Tromey  <tromey@adacore.com>
2717
2718         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2719         objfile_key.
2720         (arm_find_mapping_symbol, arm_record_special_symbol)
2721         (_initialize_arm_tdep): Update.
2722         (arm_objfile_data_free): Remove.
2723
2724 2019-06-27  Tom Tromey  <tromey@adacore.com>
2725
2726         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2727         to cp_print_static_field.
2728
2729 2019-06-26  Tom Tromey  <tromey@adacore.com>
2730
2731         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2732         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2733         declare.
2734
2735 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2736
2737         * features/aarch64-core.c (create_feature_aarch64_core):
2738         Regenerate.
2739         * features/aarch64-core.xml: Add cpsr flags.
2740
2741 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2744         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2745
2746 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2747
2748         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2749         field.
2750         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2751         use.
2752         (arm_record_special_symbol): Don't insert new symbol in sorted
2753         position, push it at the end.
2754
2755 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2756
2757         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2758         (arm_mapping_symbol_s): Remove.
2759         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2760         (arm_mapping_symbol_vec): New typedef.
2761         (struct arm_per_objfile): Add constructor.
2762         <section_maps>: Change type to
2763         std::unique_ptr<arm_mapping_symbol_vec[]>.
2764         (arm_compare_mapping_symbols): Remove.
2765         (arm_find_mapping_symbol): Adjust to section_maps type change.
2766         (arm_objfile_data_free): Call delete on arm_per_objfile.
2767         (arm_record_special_symbol): Adjust to section_maps type change.
2768         Allocate arm_per_objfile with new.
2769
2770 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2771
2772         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2773         with the command prefix.
2774
2775 2019-06-25  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2778         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2779
2780 2019-06-25  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2783         type.
2784         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2785         protected.
2786
2787 2019-06-25  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-winsource.c
2790         (tui_source_window_base::set_is_exec_point_at): Add check against
2791         LOA_ADDRESS.
2792
2793 2019-06-25  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-source.c (tui_set_source_content): Don't check before
2796         xfree.
2797         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2798
2799 2019-06-25  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-winsource.h (tui_update_source_window_as_is)
2802         (tui_alloc_source_buffer, tui_line_is_displayed)
2803         (tui_addr_is_displayed): Change type of win_info.
2804         * tui/tui-winsource.c (tui_update_source_window_as_is)
2805         (tui_clear_source_content, tui_show_source_line)
2806         (tui_show_source_content, tui_source_window_base::refill)
2807         (tui_source_window_base::set_is_exec_point_at)
2808         (tui_source_window_base::set_is_exec_point_at)
2809         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2810         (tui_alloc_source_buffer, tui_line_is_displayed)
2811         (tui_addr_is_displayed): Change type of win_info.  Update.
2812         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2813         (tui_source_window_base::do_make_visible_with_new_height):
2814         Update.
2815         * tui/tui-source.c (tui_set_source_content)
2816         (tui_set_source_content_nil)
2817         (tui_source_window::do_scroll_vertical): Update.
2818         * tui/tui-layout.c (show_layout): Update.
2819         * tui/tui-disasm.c (tui_set_disassem_content)
2820         (tui_disasm_window::do_scroll_vertical): Update.
2821         * tui/tui-data.h (tui_win_content): Remove.
2822         (struct tui_gen_win_info) <content, content_size>: Remove.
2823         (struct tui_source_element): Add initializers and destructor.
2824         (union tui_which_element, struct tui_win_element): Remove.
2825         (struct tui_source_window_base) <content>: New field.
2826         (struct tui_data_window): Remove destructor.
2827         (tui_alloc_content, tui_free_win_content)
2828         (tui_free_all_source_wins_content): Don't declare.
2829         * tui/tui-data.c (tui_initialize_static_data): Update.
2830         (init_content_element, tui_alloc_content): Remove.
2831         (~tui_gen_win_info): Update.
2832         (~tui_data_window, tui_free_all_source_wins_content)
2833         (tui_free_win_content, free_content, free_content_elements):
2834         Remove.
2835
2836 2019-06-25  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-winsource.h (tui_clear_source_content)
2839         (tui_erase_source_content, tui_show_source_content): Change type
2840         of win_info.
2841         * tui/tui-winsource.c (tui_clear_source_content)
2842         (tui_erase_source_content, tui_show_source_content): Change type
2843         of win_info.
2844         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2845         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2846         win_info.
2847         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2848         win_info.
2849         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2850
2851 2019-06-25  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-winsource.c (tui_clear_source_content)
2854         (tui_source_window_base::set_is_exec_point_at): Update.
2855         * tui/tui-source.c (tui_set_source_content_nil): Update.
2856         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2857         a bool.
2858         * tui/tui-data.c (init_content_element): Update.
2859
2860 2019-06-25  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2863         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2864         * tui/tui-layout.c (init_and_make_win): Update.
2865         * tui/tui.h (enum tui_win_type): Update.
2866         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2867         tui_win_is_auxillary.
2868         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2869         tui_win_is_auxillary.
2870
2871 2019-06-25  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2874         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2875         (tui_delete_data_content_windows, tui_display_all_data)
2876         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2877         Update.
2878         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2879         * tui/tui-regs.c (tui_last_regs_line_no)
2880         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2881         (tui_show_registers): Update.
2882         (tui_show_register_group): Return void.  Update.
2883         (tui_display_registers_from, tui_display_reg_element_at_line)
2884         (tui_display_registers_from_line, tui_check_register_values):
2885         Update.
2886         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2887         member.
2888         (struct tui_data_window) <regs_content>: Now a std::vector.
2889         <regs_content_count>: Remove.
2890         (tui_add_content_elements, tui_free_data_content): Don't declare.
2891         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2892         (init_content_element): Remove DATA_WIN case.  Add assert.
2893         (tui_add_content_elements): Remove.
2894         (tui_data_window): Update.
2895         (tui_free_data_content): Remove.
2896         (free_content_elements): Remove DATA_WIN case.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-data.c (tui_data_item_window): Update.
2901         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2902         * tui/tui-windata.c (tui_display_all_data)
2903         (tui_display_data_from_line): Update.
2904         (tui_check_data_values): Remove.
2905         * tui/tui-regs.c (tui_show_register_group)
2906         (tui_display_reg_element_at_line): Update.
2907         * tui/tui-hooks.c (tui_register_changed)
2908         (tui_refresh_frame_and_register_information): Call
2909         tui_check_register_values.
2910         * tui/tui-data.h (struct tui_data_window) <data_content,
2911         data_content_count, data_type>: Remove.
2912         (enum tui_data_type): Remove.
2913
2914         * tui/tui-data.c (tui_data_window::clear_detail)
2915         (~tui_data_window): Update.
2916
2917 2019-06-25  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2920         declare.
2921         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2922         Rename from tui_first_data_item_displayed.  Update.
2923         (tui_data_window::refresh_all)
2924         (tui_data_window::do_scroll_vertical): Update.
2925         * tui/tui-data.h (struct tui_data_window)
2926         <first_data_item_displayed>: Declare new method.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2931         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2932         contents...
2933         (tui_initialize_static_data): ...here.
2934
2935 2019-06-25  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2938         (tui_display_registers_from, tui_check_register_values): Update.
2939         (tui_display_register): Remove win_info parameter; update.
2940         (tui_get_register): Change type of parameters.
2941         * tui/tui-data.h (struct tui_data_element): Remove.
2942         (union tui_which_element) <data>: Remove.
2943         <data_window>: Change type.
2944         (struct tui_data_item_window): New.
2945         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2946         case.  Add assert.
2947         (~tui_data_item_window): New destructor.
2948         (free_content_elements): Remove DATA_ITEM_WIN case.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2953         Remove.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-data.h (struct tui_command_element): Remove.
2958         (union tui_which_element) <command>: Remove.
2959         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2960         assert.
2961         (free_content_elements): Remove CMD_WIN case.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-layout.c (tui_set_layout): Update.
2966         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2967         * tui/tui-data.c (layout_def): Update.
2968
2969 2019-06-25  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2972         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2973         (tui_source_window_base::set_new_height): Update.
2974         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2975         Update.
2976         (tui_set_locator_fullname, tui_set_locator_info)
2977         (tui_show_frame_info): Update.
2978         * tui/tui-source.c (tui_set_source_content)
2979         (tui_source_is_displayed): Update.
2980         * tui/tui-layout.c (show_source_disasm_command, show_data)
2981         (show_source_or_disasm_and_command): Update.
2982         * tui/tui-disasm.c (tui_set_disassem_content)
2983         (tui_get_begin_asm_address): Update.
2984         * tui/tui-data.h (struct tui_locator_element): Remove.
2985         (union tui_which_element) <locator>: Remove.
2986         (struct tui_locator_window): New.
2987         (tui_locator_win_info_ptr): Change return type.
2988         * tui/tui-data.c (_locator): Change type.
2989         (tui_locator_win_info_ptr): Change return type.
2990         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2991         (tui_alloc_content): Add assert.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-winsource.c
2996         (tui_exec_info_window::maybe_allocate_content): New method.
2997         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2998         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2999         (make_source_or_disasm_window): Add cast.
3000         * tui/tui-data.h (union tui_which_element) <simple_string>:
3001         Remove.
3002         (struct tui_source_info): New.
3003         (struct tui_source_window_base) <execution_info>: Change type.
3004         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3005         case, and add assert.
3006         (tui_alloc_content): Add assert.
3007
3008 2019-06-25  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3011         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3012         * tui/tui-data.c (tui_alloc_win_info): Remove.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3017         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3018         can_highlight.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3023         make_visible_with_new_height method.
3024         (tui_win_info::make_visible_with_new_height): New method.
3025         (tui_source_window_base::do_make_visible_with_new_height)
3026         (tui_data_window::do_make_visible_with_new_height)
3027         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3028         (make_visible_with_new_height): Remove.
3029         (tui_resize_all, tui_adjust_win_heights): Use
3030         make_visible_with_new_height method.
3031         * tui/tui-data.h (struct tui_win_info)
3032         <do_make_visible_with_new_height, make_visible_with_new_height>:
3033         New methods.
3034         (struct tui_source_window_base, struct tui_data_window)
3035         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3036         methods.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3041         method.
3042         (update_tab_width): Call update_tab_width method.
3043         * tui/tui-data.h (struct tui_win_info)
3044         (struct tui_source_window_base) <update_tab_width>: New methods.
3045
3046 2019-06-25  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3049         parameter.
3050         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3051         parameter.
3052         (tui_gen_win_info::make_visible): Update.
3053         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3054         parameter.
3055         * tui/tui-data.h (enum tui_box): New enum.
3056         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3061         init_and_make_win for EXEC_INFO_WIN.
3062         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3063         longer inline.
3064         (struct tui_win_info) <~tui_win_info>: Inline.
3065         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3066         Don't declare.
3067         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3068         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3069         Remove.
3070         (tui_initialize_static_data): Update.
3071         (~tui_gen_win_info): Handle more cleanup here.
3072         (~tui_source_window_base): Delete "execution_info".
3073         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3074
3075 2019-06-25  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-layout.c (make_command_window): Don't set
3078         can_highlight.
3079         (show_source_disasm_command): Call the reset method.
3080         (show_data): Don't set can_highlight.  Call the reset method.
3081         (tui_gen_win_info::reset): Rename from init_gen_win_info
3082         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3083         (show_source_or_disasm_and_command): Call the reset method.
3084         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3085         (struct tui_cmd_window): Set can_highlight.
3086
3087 2019-06-25  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3090         from make_visible.
3091         (tui_make_visible, tui_make_invisible): Rewrite.
3092         (tui_win_info::make_visible): Remove.
3093         (tui_source_window_base::make_visible): Update.
3094         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3095         method.  Moved from...
3096         (struct tui_win_info) <make_visible>: ...here.
3097
3098 2019-06-25  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-winsource.c
3101         (tui_source_window_base::do_scroll_horizontal): Remove direction
3102         parameter.
3103         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3104         direction parameter.
3105         * tui/tui-win.c (tui_win_info::forward_scroll)
3106         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3107         (tui_win_info::right_scroll): Update.
3108         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3109         direction parameter.
3110         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3111         direction parameter.
3112         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3113         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3114         Remove direction parameter.
3115         (struct tui_source_window_base, struct tui_source_window)
3116         (struct tui_disasm_window, struct tui_data_window)
3117         (struct tui_cmd_window): Update.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-winsource.h (tui_set_exec_info_content)
3122         (tui_show_exec_info_content, tui_erase_exec_info_content)
3123         (tui_clear_exec_info_content, tui_update_exec_info): Change
3124         argument to tui_source_window_base.
3125         * tui/tui-winsource.c (tui_set_exec_info_content)
3126         (tui_show_exec_info_content, tui_erase_exec_info_content)
3127         (tui_clear_exec_info_content, tui_update_exec_info): Change
3128         argument to tui_source_window_base.
3129
3130 2019-06-25  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3133         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3134
3135 2019-06-25  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3138         check.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3143         type to void.
3144         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3145         type to void.
3146         * tui/tui-source.c (tui_set_source_content): Update.
3147         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3148
3149 2019-06-25  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-win.c (window_name_completer, tui_set_focus)
3152         (tui_all_windows_info): Use name method.
3153         * tui/tui-data.h (struct tui_gen_win_info)
3154         (struct tui_source_window, struct tui_disasm_window)
3155         (struct tui_data_window, struct tui_cmd_window) <name>: New
3156         method.
3157         (tui_win_name): Don't declare.
3158         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3159         (tui_win_name): Remove.
3160
3161 2019-06-25  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-winsource.h (tui_update_source_window)
3164         (tui_update_source_window_as_is): Change parameter type.
3165         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3166         to be a tui_source_window_base.
3167         (tui_update_source_window_as_is): Likewise.
3168         * tui/tui-win.c (make_visible_with_new_height): Update.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-winsource.c (tui_erase_source_content)
3173         (tui_show_source_content, tui_show_exec_info_content)
3174         (tui_erase_exec_info_content): Use refresh_window method.
3175         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3176         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3177         from tui_refresh_win.
3178         (tui_data_window::refresh_window): New method.
3179         (tui_win_info::refresh, tui_source_window_base::refresh)
3180         (tui_refresh_all): Use refresh_window method.
3181         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3182         method.
3183         * tui/tui-regs.c (tui_display_register): Call refresh_window
3184         method.
3185         * tui/tui-layout.c (show_source_disasm_command)
3186         (show_source_or_disasm_and_command): Call refresh_window method.
3187         * tui/tui-data.h (struct tui_gen_win_info)
3188         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3189         New method.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui.c (tui_rl_other_window, tui_enable)
3194         (tui_is_window_visible, tui_get_command_dimension): Update.
3195         * tui/tui-winsource.c (tui_update_source_window_as_is)
3196         (tui_clear_source_content, tui_erase_source_content)
3197         (tui_show_source_line, tui_source_window_base::refill)
3198         (tui_source_window_base::do_scroll_horizontal)
3199         (tui_source_window_base::set_is_exec_point_at)
3200         (tui_update_breakpoint_info, tui_set_exec_info_content)
3201         (tui_alloc_source_buffer, tui_line_is_displayed)
3202         (tui_addr_is_displayed): Update.
3203         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3204         (tui_check_and_display_highlight_if_needed)
3205         (tui_win_info::make_visible, tui_win_info::refresh)
3206         (tui_refresh_all): Update.
3207         * tui/tui-windata.c (tui_first_data_item_displayed)
3208         (tui_delete_data_content_windows, tui_erase_data_content)
3209         (tui_display_all_data, tui_data_window::refresh_all)
3210         (tui_check_data_values): Update.
3211         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3212         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3213         (tui_win_info::backward_scroll, tui_refresh_all_win)
3214         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3215         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3216         (tui_source_window_base::set_new_height)
3217         (tui_data_window::set_new_height)
3218         (make_invisible_and_set_new_height)
3219         (make_visible_with_new_height, new_height_ok)
3220         (parse_scrolling_args): Update.
3221         * tui/tui-stack.c (tui_show_frame_info): Update.
3222         * tui/tui-source.c (tui_set_source_content)
3223         (tui_set_source_content_nil, tui_source_is_displayed)
3224         (tui_source_window::do_scroll_vertical): Update.
3225         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3226         (tui_display_registers_from, tui_display_reg_element_at_line)
3227         (tui_check_register_values, tui_reg_command): Update.
3228         * tui/tui-layout.c (tui_default_win_height)
3229         (show_source_disasm_command, show_data, init_and_make_win)
3230         (show_source_or_disasm_and_command): Update.
3231         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3232         (tui_redisplay_readline, tui_mld_flush)
3233         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3234         (tui_getc): Update.
3235         * tui/tui-disasm.c (tui_set_disassem_content)
3236         (tui_disasm_window::do_scroll_vertical): Update.
3237         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3238         Now virtual.
3239         (struct tui_win_info): Derive from tui_gen_win_info.
3240         <~tui_win_info>: Mark as override.
3241         <generic>: Remove member.
3242         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3243         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3244         (~tui_data_window, ~tui_win_info)
3245         (tui_free_all_source_wins_content): Update.
3246         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3247
3248 2019-06-25  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-layout.c (init_and_make_win): Use new.
3251         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3252         destructor, initializers.
3253         (tui_alloc_generic_win_info): Don't declare.
3254         * tui/tui-data.c (_locator): Add argument to constructor.
3255         (source_win, disasm_win): New globals.
3256         (exec_info): Remove.
3257         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3258         Update.
3259         (tui_alloc_generic_win_info): Remove.
3260         (init_content_element): Use new.
3261         (tui_win_info::tui_win_info): Update.
3262         (free_content_elements) <case DATA_WIN>: Use delete.
3263
3264 2019-06-25  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3267         * tui/tui-windata.c (tui_first_data_item_displayed)
3268         (tui_delete_data_content_windows): Update.
3269         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3270         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3271         (tui_display_registers_from, tui_check_register_values): Update.
3272         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3273         pointer.
3274         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3275         window.
3276         (tui_free_data_content): Update.
3277         (free_content_elements) <case DATA_WIN>: Free the window.
3278
3279 2019-06-25  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3282         Update.
3283         * tui/tui-layout.c (make_command_window)
3284         (show_source_disasm_command, show_data, init_and_make_win)
3285         (show_source_or_disasm_and_command): Update.
3286         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3287         method.
3288         <can_highight, is_highlighted>: Now bool.
3289         (tui_set_win_highlight): Don't declare.
3290         * tui/tui-data.c (tui_set_win_highlight): Remove.
3291
3292 2019-06-25  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-wingeneral.c (make_visible): Remove check of window
3295         type.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-win.c (tui_win_info::max_height)
3300         (tui_cmd_window::max_height): New methods.
3301         (new_height_ok): Call max_height.
3302         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3303         <max_height>: New method.
3304
3305 2019-06-25  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-win.c (tui_source_window_base::set_new_height)
3308         (tui_data_window::set_new_height): New methods.
3309         (make_invisible_and_set_new_height): Call set_new_height method.
3310         * tui/tui-data.h (struct tui_win_info)
3311         (struct tui_source_window_base, struct tui_data_window)
3312         <set_new_height>: New method.
3313
3314 2019-06-25  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3317         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3318         tui_refresh_data_win.
3319         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3320         method.
3321         (tui_refresh_all_win): Call the refresh_all method.
3322         (tui_set_focus): Likewise.
3323         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3324         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3325         Likewise.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-winsource.h (tui_refill_source_window)
3330         (tui_set_is_exec_point_at): Don't declare.
3331         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3332         (tui_source_window_base::refill): Rename from
3333         tui_refill_source_window.
3334         (tui_source_window_base::do_scroll_horizontal): Update.
3335         (tui_source_window_base::set_is_exec_point_at): Rename from
3336         tui_set_is_exec_point_at.
3337         (tui_update_all_breakpoint_info): Update.
3338         * tui/tui-stack.c (tui_show_frame_info): Update.
3339         * tui/tui-layout.c (show_data): Add cast.
3340         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3341         * tui/tui-data.h (struct tui_source_window_base) <refill,
3342         set_is_exec_point_at>: New methods.
3343         (tui_source_windows, tui_add_to_source_windows): Update types.
3344         (tui_add_to_source_windows): Remove redundant declaration.
3345         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3346         (tui_source_windows): Change return type.
3347         (tui_clear_source_windows_detail): Update.
3348         (tui_add_to_source_windows): Change type of parameter.
3349         (tui_free_all_source_wins_content): Update.
3350
3351 2019-06-25  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c (tui_win_info::refresh)
3354         (tui_source_window_base::refresh): New methods.
3355         (tui_refresh_all): Call the refresh method.
3356         * tui/tui-data.h (struct tui_win_info)
3357         (struct tui_source_window_base) <refresh>: New method.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui.h (tui_is_window_visible): Return bool.
3362         * tui/tui.c (tui_is_window_visible): Return bool.
3363         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3364         (tui_make_visible, tui_make_invisible)
3365         (tui_win_info::make_visible)
3366         (tui_source_window_base::make_visible, make_all_visible)
3367         (tui_make_all_visible, tui_make_all_invisible): Update.
3368         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3369         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3370         bool.
3371         (struct tui_win_info, struct tui_source_window_base)
3372         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3373         * tui/tui-data.c (tui_init_generic_part): Update.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3378         (tui_source_window_base::make_visible): New methods.
3379         (make_all_visible): Make method call.
3380         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3381         (struct tui_source_window_base, struct tui_cmd_window): Override
3382         make_visible.
3383         (tui_win_is_source_type): Don't declare.
3384         * tui/tui-data.c (tui_win_is_source_type): Remove.
3385
3386 2019-06-25  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3389         NULL check.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3394         Inline constructor.  Add initializers for members.
3395         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3396         constructors; now inline in class.
3397
3398 2019-06-25  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-regs.c (tui_show_registers): Update.
3401         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3402         bool.
3403         * tui/tui-data.c (tui_data_window::clear_detail)
3404         (tui_data_window): Update.
3405
3406 2019-06-25  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-windata.c (tui_display_all_data)
3409         (tui_display_data_from_line, tui_display_data_from)
3410         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3411         Update.
3412         * tui/tui-regs.c (tui_last_regs_line_no)
3413         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3414         (tui_show_registers, tui_show_register_group)
3415         (tui_display_registers_from, tui_display_reg_element_at_line)
3416         (tui_display_registers_from_line, tui_check_register_values)
3417         (tui_reg_next, tui_reg_prev): Update.
3418         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3419         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3420         tui_data_window.
3421         (struct tui_win_info) <detail>: Remove.  Add new fields from
3422         tui_data_info.
3423         (TUI_DATA_WIN): Add cast.
3424         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3425         (~tui_data_window): Simplify.
3426
3427 2019-06-25  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-layout.c (show_source_disasm_command)
3430         (show_source_or_disasm_and_command): Update.
3431         * tui/tui-io.c (update_cmdwin_start_line)
3432         (tui_redisplay_readline): Update.
3433         * tui/tui-data.h (struct tui_command_info): Remove.
3434         (struct tui_win_info) <detail>: Remove command_info member.
3435         (struct tui_data_window) <start_line>: New member, from
3436         tui_command_info.
3437         (TUI_CMD_WIN): Add casts.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-winsource.c (tui_update_source_window)
3442         (tui_refill_source_window)
3443         (tui_source_window_base::do_scroll_horizontal)
3444         (tui_update_breakpoint_info, tui_set_exec_info_content)
3445         (tui_show_exec_info_content, tui_erase_exec_info_content)
3446         (tui_clear_exec_info_content): Update.
3447         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3448         Update.
3449         * tui/tui-win.c (make_invisible_and_set_new_height)
3450         (make_visible_with_new_height): Update.
3451         * tui/tui-source.c (tui_set_source_content)
3452         (tui_show_symtab_source): Update.
3453         * tui/tui-layout.c (extract_display_start_addr)
3454         (show_source_disasm_command, show_data)
3455         (make_source_or_disasm_window)
3456         (show_source_or_disasm_and_command): Update.
3457         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3458         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3459         "gdbarch".
3460         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3461         to tui_source_window_base.
3462         (struct tui_win_info) <detail>: Remove source_info member.
3463         (struct tui_source_window_base) <has_locator>: Inline.
3464         Move contents from tui_source_info; rename has_locator member to
3465         m_has_locator.
3466         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3467         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3468         header file.
3469         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3470         Simplify.
3471         (tui_free_all_source_wins_content): Cast to
3472         tui_source_window_base.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-win.c (make_invisible_and_set_new_height)
3477         (make_visible_with_new_height): Call has_locator method.
3478         * tui/tui-layout.c (show_source_disasm_command, show_data)
3479         (show_source_or_disasm_and_command): Update for bool change.
3480         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3481         (tui_win_info) <has_locator>: New method.
3482         (struct tui_source_window_base) <has_locator>: New method.
3483         (tui_win_has_locator): Don't declare.
3484         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3485         from tui_win_has_locator.
3486         (tui_source_window_base): Use false, not FALSE.
3487
3488 2019-06-25  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3491         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3492         clear_detail method directly.
3493         (tui_clear_win_detail): Remove.
3494
3495 2019-06-25  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3498         "this", not TUI_DISASM_WIN.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3503         declare.
3504         * tui/tui-winsource.c
3505         (tui_source_window_base::do_scroll_horizontal): Rename from
3506         tui_horizontal_source_scroll.
3507         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3508         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3509         from tui_vertical_data_scroll.
3510         * tui/tui-win.h (tui_scroll): Don't declare.
3511         * tui/tui-win.c (tui_win_info::forward_scroll)
3512         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3513         (tui_win_info::right_scroll): Rename and update.
3514         (tui_scroll_forward_command, tui_scroll_backward_command)
3515         (tui_scroll_left_command, tui_scroll_right_command): Update.
3516         (tui_scroll): Remove.
3517         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3518         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3519         from tui_vertical_source_scroll.
3520         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3521         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3522         from tui_vertical_disassem_scroll.
3523         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3524         do_scroll_horizontal>: New methods.
3525         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3526         Likewise.
3527         (struct tui_source_window_base): Add do_scroll_horizontal.
3528         (struct tui_source_window, struct tui_disasm_window): Add
3529         do_scroll_vertical.
3530         (struct tui_data_window, struct tui_cmd_window): Add
3531         do_scroll_horizontal and do_scroll_vertical.
3532         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-data.h (struct tui_source_window_base): New struct.
3537         (struct tui_source_window): Derive from tui_source_window_base.
3538         (struct tui_disasm_window): New struct.
3539         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3540         from tui_source_window::clear_detail.
3541         (tui_source_window_base): Rename from tui_source_window.
3542         (~tui_source_window_base): Rename from ~tui_source_window.
3543         (tui_alloc_win_info): Create a tui_disasm_window.
3544
3545 2019-06-25  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-data.h (struct tui_source_window)
3548         (struct tui_data_window): Declare destructors.
3549         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3550         destructors.
3551         (tui_win_info): Simplify.
3552
3553 2019-06-25  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-winsource.c (tui_display_main)
3556         (tui_update_source_windows_with_addr)
3557         (tui_update_all_breakpoint_info): Update.
3558         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3559         (new_height_ok, parse_scrolling_args): Update.
3560         * tui/tui-stack.c (tui_show_frame_info): Update.
3561         * tui/tui-data.h (struct tui_list): Remove.
3562         (tui_source_windows): Return a reference to a std::vector.
3563         * tui/tui-data.c (source_windows): Now a std::vector.
3564         (tui_source_windows): Change return type.
3565         (tui_clear_source_windows): Rewrite.
3566         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3567         (tui_free_all_source_wins_content): Rewrite.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3572         (struct tui_data_window, struct tui_cmd_window): Declare
3573         clear_detail method.
3574         * tui/tui-data.c (tui_source_window::clear_detail)
3575         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3576         methods.
3577         (tui_clear_win_detail): Simplify.
3578
3579 2019-06-25  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-layout.c (make_source_window, make_disasm_window)
3582         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3583         Return the new window.
3584         (show_source_disasm_command, show_data)
3585         (show_source_or_disasm_and_command): Update.
3586
3587 2019-06-25  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3590         parameter.  Return the new window.
3591         (show_source_disasm_command): Update and remove NULL check.
3592         (show_source_or_disasm_and_command): Update.
3593
3594 2019-06-25  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3597
3598 2019-06-25  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-data.h (struct tui_win_info): Make constructor
3601         protected.  Make destructor virtual.  Add initializers.
3602         (tui_source_window, tui_data_window, tui_cmd_window): New
3603         classes.
3604         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3605         constructor.  Add "type" parameter.
3606         (tui_source_window, tui_data_window, tui_cmd_window): New
3607         constructors.
3608         (tui_alloc_win_info): Instantiate the appropriate subclass.
3609
3610 2019-06-25  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-win.c (tui_resize_all): Use delete.
3613         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3614         destructor.
3615         (tui_free_window): Don't declare.
3616         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3617         Update.
3618
3619 2019-06-25  Tom Tromey  <tom@tromey.com>
3620
3621         * tui/tui-data.h (struct tui_win_info): Add constructor.
3622         * tui/tui-data.c (tui_alloc_win_info): Use new.
3623         (tui_free_window): Use delete.
3624
3625 2019-06-22  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3628         declare.
3629         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3630
3631 2019-06-22  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3634         declare.
3635         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3636
3637 2019-06-22  Tom de Vries  <tdevries@suse.de>
3638
3639         * dwarf2read.c (create_addrmap_from_aranges)
3640         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3641         instead of '%zu'.
3642
3643 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3644
3645         * dwarf2read.h (dwarf2_section_info_def): Remove.
3646         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3647         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3648         std::vector<dwarf2_section_info>.
3649         (struct dwo_file) <~dwo_file>: Remove.
3650         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3651         types field.
3652         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3653         (dwarf2_read_debug_names): Likewise.
3654         (create_debug_types_hash_table): Change parameter type to
3655         array_view, adjust code accordingly.
3656         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3657         (partial_die_info::fixup): Likewise.
3658         (determine_prefix): Likewise.
3659         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3660
3661 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3662
3663         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3664         gdb_bfd_ref_ptr.
3665         <~dwo_file>: Remove call to gdb_bfd_unref.
3666         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3667         gdb_bfd_ref_ptr::get.
3668
3669 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3670
3671         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3672         type to htab_up.
3673         * dwarf2read.c (struct dwo_file): Initialize fields.
3674         <~dwo_file>: New.
3675         (free_dwo_file): Remove, move content to ~dwo_file.
3676         (struct dwo_file_deleter): Remove.
3677         (dwo_file_up>: Remove custom deleter.
3678         (free_dwo_files): Remove.
3679         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3680         dwo_files.
3681         (process_skeletonless_type_units): Call unique_ptr::get.
3682         (allocate_dwo_file_hash_table): Add deleter to created hash
3683         table.  Change return type to htab_up.
3684         (lookup_dwo_file_slot): Don't memset dwo_file, call
3685         unique_ptr::get.
3686         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3687         (create_dwo_unit_in_dwp_v2): Likewise.
3688         (open_and_init_dwo_file): Likewise.
3689         (free_dwo_file_from_slot): Remove.
3690
3691 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3692
3693         * dwarf2read.h (struct dwarf2_section_info) <readin,
3694         is_virtual>: Change type to bool.
3695         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3696         true instead of 1.
3697
3698 2019-06-19  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-data.h (tui_init_content_element): Don't declare.
3701
3702 2019-06-19  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-data.h (tui_init_win_info): Don't declare.
3705
3706 2019-06-19  Tom de Vries  <tdevries@suse.de>
3707
3708         * dwarf2read.h (abstract_to_concrete): Change type to
3709         std::unordered_map<sect_offset, std::vector<sect_offset>,
3710         gdb::hash_enum<sect_offset>>.
3711
3712 2019-06-19  Tom Tromey  <tromey@adacore.com>
3713
3714         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3715         EVAL_AVOID_SIDE_EFFECTS specially.
3716
3717 2019-06-19  Tom Tromey  <tromey@adacore.com>
3718
3719         * source-cache.c (highlighter): New global.
3720         (source_cache::get_source_lines): Create a highlighter on demand.
3721
3722 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * defs.h (deprecated_interactive_hook): Delete declaration.
3725         * interps.c (clear_interpreter_hooks): Remove use of
3726         deprecated_interactive_hook.
3727         * top.c (deprecated_interactive_hook): Delete definition.
3728         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3729
3730 2019-06-18  Tom de Vries  <tdevries@suse.de>
3731
3732         PR gdb/24515
3733         * dwarf2read.h (abstract_to_concrete): Change type from
3734         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3735         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3736         * dwarf2read.c (read_variable): Update.
3737         (dwarf2_fetch_die_loc_sect_off): Update.
3738
3739 2019-06-17  Tom de Vries  <tdevries@suse.de>
3740
3741         PR gdb/24617
3742         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3743         accessing parent[parent_len - 1].
3744
3745 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3746
3747         PR gdb/24364
3748         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3749         call dtrace_process_dof with NULL dof.
3750
3751 2019-06-16  Tom de Vries  <tdevries@suse.de>
3752
3753         PR gdb/24445
3754         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3755
3756 2019-06-16  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3759         (make_all_visible): Use address of member.
3760
3761 2019-06-16  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3764         (tui_free_window, free_content, free_content_elements): Remove
3765         unnecessary cast.
3766         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3767         cast.
3768         * tui/tui-regs.c (tui_show_register_group)
3769         (tui_display_registers_from, tui_display_reg_element_at_line):
3770         Remove unnecessary cast.
3771
3772 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * linux-nat.c (normal_mask): Delete.
3775         (_initialize_linux_nat): Don't initialise normal_mask.
3776
3777 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3778
3779         PR gdb/24445
3780         * dwarf-index-write.h (write_psymtabs_to_index): Add
3781         dwz_basename parameter.
3782         * dwarf-index-write.c (write_gdbindex): Move file writing to
3783         write_gdbindex_1.  Change return type void.
3784         (assert_file_size): Move up, remove filename parameter.
3785         (write_gdbindex_1): New function.
3786         (write_debug_names): Change return type to void, call
3787         assert_file_size.
3788         (struct index_wip_file): New struct.
3789         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3790         file logic to index_wip_file.  Write index for dwz file if
3791         needed.
3792         (save_gdb_index_command): Pass basename of dwz file, if present.
3793         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3794         build-id of dwz file, if present.
3795         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3796         (dwarf2_get_dwz_file): Likewise.
3797         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3798         (dwarf2_get_dwz_file): Likewise.
3799
3800 2019-06-16  Tom Tromey  <tom@tromey.com>
3801
3802         * coffread.c (process_coff_symbol): Use xstrdup.
3803         * value.c (create_internalvar): Use xstrdup.
3804
3805 2019-06-16  Tom Tromey  <tom@tromey.com>
3806
3807         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3808         * breakpoint.c (stopin_command, stopat_command)
3809         (until_break_command, decode_location_default): Remove unnecessary
3810         cast.
3811         * utils.c (subset_compare): Remove unnecessary cast.
3812         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3813         cast.
3814         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3815         cast.
3816         * infcmd.c (path_command): Remove unnecessary cast.
3817         * coffread.c (decode_type): Remove unnecessary cast.
3818         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3819         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3820         * tui/tui-stack.c (tui_show_locator_content)
3821         (tui_show_frame_info): Remove unnecessary cast.
3822         * tui/tui-win.c (tui_scroll_forward_command)
3823         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3824         (parse_scrolling_args): Remove unnecessary cast.
3825         * tui/tui-data.c (init_win_info, tui_del_window)
3826         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3827         (free_content_elements): Remove unnecessary cast.
3828         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3829         unnecessary cast.
3830         * tui/tui-source.c (tui_set_source_content)
3831         (tui_vertical_source_scroll): Remove unnecessary cast.
3832         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3833         cast.
3834         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3835         * tui/tui-regs.c (tui_display_registers_from)
3836         (tui_display_register): Remove unnecessary cast.
3837         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3838         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3839         (make_visible): Remove unnecessary cast.
3840         * tui/tui-winsource.c (tui_erase_source_content)
3841         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3842         unnecessary cast.
3843         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3844         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3845         * stabsread.c (read_type, read_array_type, read_range_type):
3846         Remove unnecessary cast.
3847         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3848         (parse_symbol, parse_type, upgrade_type, parse_external)
3849         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3850         unnecessary cast.
3851         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3852
3853 2019-06-16  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-data.c (tui_alloc_generic_win_info)
3856         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3857         checks.
3858
3859 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3860             Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * f-typeprint.c (f_print_type): Don't return early for not
3863         associated or not allocated types.
3864         (f_type_print_varspec_suffix): Add print_rank parameter and print
3865         ranks of array types in case they dangling.
3866         (f_type_print_base): Add print_rank parameter.
3867
3868 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * NEWS: Mention new MI commands.
3871         * break-catch-throw.c (enum exception_event_kind): Move to
3872         breakpoint.h.
3873         (print_mention_exception_catchpoint): Output text as a single
3874         message.
3875         (catch_exception_command_1): Rename to...
3876         (catch_exception_event): ...this, make non-static, update header
3877         command, and change some parameter types.
3878         (catch_catch_command): Update for changes to
3879         catch_exception_command_1.
3880         (catch_throw_command): Likewise.
3881         (catch_rethrow_command): Likewise.
3882         * breakpoint.c (enum exception_event_kind): Delete.
3883         * breakpoint.h (enum exception_event_kind): Moved here from
3884         break-catch-throw.c.
3885         (catch_exception_event): Declare.
3886         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3887         (mi_cmd_catch_throw): New function.
3888         (mi_cmd_catch_rethrow): New function.
3889         (mi_cmd_catch_catch): New function.
3890         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3891         'catch-catch' entries.
3892         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3893         (mi_cmd_catch_rethrow): Declare.
3894         (mi_cmd_catch_catch): Declare.
3895
3896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * annotate.c (annotate_source_line): Change return type to void,
3899         update implementation to match.
3900         * annotate.h (annotate_source_line): Change return type to void,
3901         update header comment.
3902         * stack.c (print_frame_info): Don't change what frame information
3903         is printed based on whether annotations are on or not.
3904
3905 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3908         (annotate_source): Make static.
3909         (annotate_source_line): Moved from source.c and renamed from
3910         identify_source_line.  Update the return type.
3911         * annotate.h (annotate_source): Delete declaration.
3912         (annotate_source_line): Declaration moved from source.h, and
3913         renamed from identify_source_line.  Return type updated.
3914         * source.c (identify_source_line): Moved to annotate.c and renamed
3915         to annotate_source_line.
3916         (info_line_command): Remove check of annotation_level.
3917         * source.h (identify_source_line): Move declaration to annotate.h
3918         and rename to annotate_source_line.
3919         * stack.c: Add 'annotate.h' include.
3920         (print_frame_info): Remove check of annotation_level before
3921         calling annotate_source_line.
3922
3923 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * source-cache.c (source_cache::get_plain_source_lines): Use
3926         open_source_file_with_line_charpos instead of just
3927         open_source_file, remove call to find_source_lines.
3928         (source_cache::get_source_lines): Likewise.
3929         * source.c (find_source_lines): Make static.
3930         (get_filename_and_charpos): Renamed into...
3931         (open_source_file_with_line_charpos): ..this along with changes to
3932         return a scoped_fd, and some other minor clean ups.
3933         (identify_source_line): Use open_source_file_with_line_charpos.
3934         (search_command_helper): Use open_source_file_with_line_charpos
3935         instead of just open_source_file, remove call to
3936         find_source_lines.
3937         * source.h (open_source_file_with_line_charpos): Declare new
3938         function.
3939         (find_source_lines): Delete declaration.
3940
3941 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * source.c (get_filename_and_charpos): Remove fullname
3944         parameter.
3945         (identify_source_line): Update call to get_filename_and_charpos.
3946
3947 2019-06-14  Tom Tromey  <tromey@adacore.com>
3948
3949         PR gdb/24502:
3950         * ui-style.h (skip_ansi_escape): Update comment.
3951         * ui-file.h (class no_terminal_escape_file): New class.
3952         * ui-file.c (no_terminal_escape_file::write)
3953         (no_terminal_escape_file::puts): New methods.
3954         * cli/cli-logging.c (handle_redirections): Use
3955         no_terminal_escape_file.
3956
3957 2019-06-14  Tom Tromey  <tromey@adacore.com>
3958
3959         * NEWS: Move convenience variable news above Python news.
3960
3961 2019-06-14  Tom Tromey  <tom@tromey.com>
3962
3963         * gnulib: Move directory to top-level.
3964         * configure.ac: Don't configure gnulib.
3965         * configure: Rebuild.
3966         * common/common-defs.h: Use new path to gnulib.
3967         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3968         (GNULIB_H): Remove.
3969         (INCGNU): Look in new gnulib location.
3970         (HFILES_NO_SRCDIR): Remove gnulib files.
3971         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3972         (generated_files): Remove GNULIB_H.
3973         ($(LIBGNU), all-lib): Remove targets.
3974         (distclean): Don't mention GNULIB_BUILDDIR.
3975         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3976
3977 2019-06-14  Tom Tromey  <tromey@adacore.com>
3978
3979         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3980         Warn if symbol file does not provide any symbols.
3981
3982 2019-06-14  Tom Tromey  <tromey@adacore.com>
3983
3984         * source.c (find_and_open_source): Respect basenames_may_differ.
3985
3986 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * annotate.c (annotate_breakpoints_invalid): Make use of
3989         scoped_restore_terminal_state.
3990         (annotate_frames_invalid): Likewise.
3991
3992 2019-06-14  Tom Tromey  <tromey@adacore.com>
3993
3994         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3995         allow assignment to an internalvar.
3996
3997 2019-06-14  Tom Tromey  <tromey@adacore.com>
3998
3999         * ada-lex.l: Allow "_" in attribute names.
4000
4001 2019-06-14  Tom Tromey  <tromey@adacore.com>
4002
4003         PR gdb/24653:
4004         * regcache.c (registers_changed): Don't call alloca.
4005         * top.c (execute_command): Don't call alloca.
4006
4007 2019-06-13  Pedro Alves  <palves@redhat.com>
4008
4009         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4010         'expression'.  When parsing an expression, error out if there's
4011         junk after "unlimited".
4012         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4013         (do_set_command): Adjust calls to is_unlimited_literal.
4014
4015 2019-06-13  Pedro Alves  <palves@redhat.com>
4016
4017         * compile/compile.c (make_compile_options_def_group): Add braces
4018         around array_view initializer.
4019         * thread.c (make_thread_apply_all_options_def_group)
4020         (make_thread_apply_all_options_def_group): Likewise.
4021
4022 2019-06-13  Pedro Alves  <palves@redhat.com>
4023
4024         * NEWS (New commands): Mention "maint test-options
4025         require-delimiter", "maint test-options unknown-is-error", "maint
4026         test-options unknown-is-operand" and "maint show
4027         test-options-completion-result".
4028         (New command options, command completion): New section.
4029         (Completion improvements): New section.
4030         Mention that you can abbreviate "unlimited".
4031
4032 2019-06-13  Pedro Alves  <palves@redhat.com>
4033
4034         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4035         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4036         * unittests/cli-utils-selftests.c (test_parse_flags)
4037         (test_parse_flags_qcs): Delete.
4038         (test_cli_utils): Don't call deleted functions.
4039
4040 2019-06-13  Pedro Alves  <palves@redhat.com>
4041
4042         * thread.c: Include "cli/cli-option.h".
4043         (tp_array_compar_ascending): Global.
4044         (tp_array_compar): Delete function.
4045         (tp_array_compar_ascending, tp_array_compar_descending): New
4046         functions.
4047         (ascending_option_def, qcs_flag_option_def)
4048         (thr_qcs_flags_option_defs)
4049         (make_thread_apply_all_options_def_group)
4050         (make_thread_apply_options_def_group): New.
4051         (thread_apply_all_command): Use gdb::option::process_options.
4052         (thread_apply_command_completer)
4053         (thread_apply_all_command_completer): New.
4054         (thread_apply_command): Use gdb::option::process_options.
4055         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4056         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4057         to generate help text of "thread apply".  Adjust "taas"'s help.
4058         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4059         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4060
4061 2019-06-13  Pedro Alves  <palves@redhat.com>
4062
4063         * thread.c (thread_apply_command): Check for invalid TID with
4064         isdigit instead of !isalpha.
4065
4066 2019-06-13  Pedro Alves  <palves@redhat.com>
4067
4068         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4069         (validate_flags_qcs): New.
4070         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4071         (validate_flags_qcs): Declare.
4072         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4073         (make_frame_apply_options_def_group): New.
4074         (frame_apply_command_count): Process options with
4075         gdb::option::process_options.
4076         (frame_apply_completer): New.
4077         (frame_apply_level_completer, frame_apply_all_completer)
4078         (frame_apply_completer): New.
4079         (_initialize_stack): Update help of "frame apply", "frame apply
4080         level", "frame apply all" and "faas" to mention supported options
4081         and install command completers.
4082         * stack.h (frame_apply_all_completer): Declare.
4083         * thread.c: Include "stack.h".
4084         (tfaas_command): Add "--".
4085         (_initialize_thread): Update help "tfaas" to mention supported
4086         options and install command completer.
4087
4088 2019-06-13  Pedro Alves  <palves@redhat.com>
4089
4090         * completer.c (complete_nested_command_line): New.
4091         (gdb_completion_word_break_characters_throw): Add assertion.
4092         * completer.h (complete_nested_command_line): Declare.
4093
4094 2019-06-13  Pedro Alves  <palves@redhat.com>
4095
4096         * stack.c (parse_backtrace_qualifiers): New.
4097         (backtrace_command): Use it.
4098         (backtrace_command_completer): Complete on qualifiers.
4099
4100 2019-06-13  Pedro Alves  <palves@redhat.com>
4101
4102         * frame.c: Include "cli/cli-option.h.
4103         (user_set_backtrace_options): New.
4104         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4105         Delete.
4106         (get_prev_frame): Adjust.
4107         (boolean_option_def, uinteger_option_def)
4108         (set_backtrace_option_defs): New.
4109         (_initialize_frame): Adjust and use
4110         gdb::option::add_setshow_cmds_for_options to install "set
4111         backtrace past-main" and "set backtrace past-entry".
4112         * frame.h: Include "cli/cli-option.h".
4113         (struct frame_print_options): Forward declare.
4114         (print_frame_arguments_all, print_frame_arguments_scalars)
4115         (print_frame_arguments_none): Declare.
4116         (print_entry_values): Delete declaration.
4117         (struct frame_print_options, user_frame_print_options): New.
4118         (struct set_backtrace_options): New.
4119         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4120         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4121         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4122         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4123         (list_args_or_locals): Add frame_print_options parameter.
4124         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4125         * python/py-framefilter.c (enumerate_args): Pass down
4126         USER_FRAME_PRINT_OPTIONS.
4127         * stack.c: Include "cli/cli-option.h".
4128         (print_frame_arguments_all, print_frame_arguments_scalars)
4129         (print_frame_arguments_none): Declare.
4130         (print_raw_frame_arguments, print_entry_values): Delete.
4131         (user_frame_print_options): New.
4132         (boolean_option_def, enum_option_def, frame_print_option_defs):
4133         New.
4134         (struct backtrace_cmd_options): New.
4135         (bt_flag_option_def): New.
4136         (backtrace_command_option_defs): New.
4137         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4138         (print_frame_arg, read_frame_arg, print_frame_args)
4139         (print_frame_info, print_frame): Add frame_print_options parameter
4140         and use it.
4141         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4142         (backtrace_command_1): Add frame_print_options and
4143         backtrace_cmd_options parameters and use them.
4144         (make_backtrace_options_def_group): New.
4145         (backtrace_command): Process command options with
4146         gdb::option::process_options.
4147         (backtrace_command_completer): New.
4148         (_initialize_stack): Extend "backtrace"'s help to mention
4149         supported options.  Install completer for "backtrace".
4150         Install some settings commands with add_setshow_cmds_for_options.
4151
4152 2019-06-13  Pedro Alves  <palves@redhat.com>
4153
4154         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4155         and that "set/show print raw frame-arguments" are now deprecated.
4156
4157         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4158         command.
4159         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4160         * stack.c (_initialize_stack): Install "set/show print
4161         raw-frame-arguments", and deprecate "set/show print raw
4162         frame-arguments".
4163         * valprint.c (_initialize_valprint): Deprecate "set/show print
4164         raw".
4165
4166 2019-06-13  Pedro Alves  <palves@redhat.com>
4167
4168         * compile/compile.c (struct compile_options): New.
4169         (compile_flag_option_def, compile_command_option_defs)
4170         (make_compile_options_def_group): New.
4171         (compile_file_command): Handle options with
4172         gdb::option::process_options.
4173         (compile_file_command_completer): New function.
4174         (compile_code_command): Handle options with
4175         gdb::option::process_options.
4176         (compile_code_command_completer): New function.
4177         (_initialize_compiler): Install completers for "compile code" and
4178         "compile file".  Mention available options in "compile code" and
4179         "compile code"'s help.
4180         * completer.c (advance_to_completion_word): New, factored out from
4181         ...
4182         (advance_to_expression_complete_word_point): ... this.
4183         (advance_to_filename_complete_word_point): New.
4184         * completer.h (advance_to_filename_complete_word_point): New
4185         declaration.
4186
4187 2019-06-13  Pedro Alves  <palves@redhat.com>
4188
4189         * compile/compile.c: Include "cli/cli-option.h".
4190         (compile_print_value): Scope data pointer is now a
4191         value_print_options pointer; adjust.
4192         (compile_print_command): Process options.  Scope data pointer is
4193         now a value_print_options pointer; adjust.
4194         (_initialize_compile): Update "compile print"'s help to include
4195         supported options.  Install a completer for "compile print".
4196         * cp-valprint.c (show_vtblprint, show_objectprint)
4197         (show_static_field_print): Delete.
4198         (_initialize_cp_valprint): Don't install "set print
4199         static-members", "set print vtbl", "set print object" here.
4200         * printcmd.c: Include "cli/cli-option.h" and
4201         "common/gdb_optional.h".
4202         (print_command_parse_format): Rework to fill in a
4203         value_print_options instead of a format_data.
4204         (print_value): Change parameter type from format_data pointer to
4205         value_print_options reference.  Adjust.
4206         (print_command_1): Process options.  Adjust to pass down a
4207         value_print_options.
4208         (print_command_completer): New.
4209         (_initialize_printcmd): Install print_command_completer as
4210         handle_brkchars completer for the "print" command.  Update
4211         "print"'s help to include supported options.
4212         * valprint.c: Include "cli/cli-option.h".
4213         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4214         here from cp-valprint.c.
4215         (boolean_option_def, uinteger_option_def)
4216         (value_print_option_defs, make_value_print_options_def_group):
4217         New.  Use gdb::option::add_setshow_cmds_for_options to install
4218         "set print elements", "set print null-stop", "set print repeats",
4219         "set print pretty", "set print union", "set print array", "set
4220         print address", "set print symbol", "set print array-indexes".
4221         * valprint.h: Include <string> and "cli/cli-option.h".
4222         (make_value_print_options_def_group): Declare.
4223         (print_value): Change parameter type from format_data pointer to
4224         value_print_options reference.
4225         (print_command_completer): Declare.
4226
4227 2019-06-13  Pedro Alves  <palves@redhat.com>
4228
4229         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4230         (COMMON_SFILES): Add maint-test-settings.c.
4231         * cli/cli-decode.c (boolean_enums): New global, factored out from
4232         ...
4233         (add_setshow_boolean_cmd): ... here.
4234         * cli/cli-decode.h (boolean_enums): Declare.
4235         * cli/cli-option.c: New file.
4236         * cli/cli-option.h: New file.
4237         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4238         factored out from ...
4239         (parse_cli_boolean_value(const char *)): ... this.
4240         (is_unlimited_literal): Change parameter type to pointer to
4241         pointer.  Adjust and advance ARG pointer.
4242         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4243         (parse_cli_var_enum): New, factored out from ...
4244         (do_set_command): ... this.  Adjust.
4245         * cli/cli-setshow.h (parse_cli_boolean_value)
4246         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4247         (parse_cli_var_enum): Declare.
4248         * cli/cli-utils.c: Include "cli/cli-option.h".
4249         (get_ulongest): New.
4250         * cli/cli-utils.h (get_ulongest): Declare.
4251         (check_for_argument): New overloads.
4252         * maint-test-options.c: New file.
4253
4254 2019-06-13  Pedro Alves  <palves@redhat.com>
4255
4256         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4257         parse a range if "-" is at the end of the string.
4258
4259 2019-06-13  Pedro Alves  <palves@redhat.com>
4260
4261         * cli/cli-setshow.c (parse_auto_binary_operation)
4262         (parse_cli_boolean_value): Don't allow "o".
4263
4264 2019-06-13  Pedro Alves  <palves@redhat.com>
4265
4266         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4267         * NEWS: Mention maint test-settings KIND.
4268         * maint-test-settings.c: New file.
4269
4270 2019-06-13  Pedro Alves  <palves@redhat.com>
4271
4272         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4273         completer.
4274         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4275         "set" completers.
4276
4277 2019-06-13  Pedro Alves  <palves@redhat.com>
4278
4279         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4280         after item.
4281
4282 2019-06-13  Pedro Alves  <palves@redhat.com>
4283
4284         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4285
4286 2019-06-13  Pedro Alves <palves@redhat.com>
4287
4288         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4289         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4290         call.
4291         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4292         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4293         calls.
4294         (check_for_argument): Skip spaces after argument.
4295
4296 2019-06-13  Pedro Alves  <palves@redhat.com>
4297
4298         * thread.c (thread_apply_command): Adjust TID parsing.
4299         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4300         detected before end of string.
4301         (tid_is_in_list): Error out if LIST is invalid.
4302
4303 2019-06-13  Pedro Alves  <palves@redhat.com>
4304
4305         * completer.c (complete_line_internal_1): Rewind completion word
4306         point.
4307         (completion_tracker::advance_custom_word_point_by): Change
4308         parameter type to int.
4309         * completer.h (completion_tracker::advance_custom_word_point_by):
4310         Likewise.
4311
4312 2019-06-13  Pedro Alves  <palves@redhat.com>
4313
4314         * completer.c (advance_to_completion_word): Handle delimiters.
4315
4316 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4317
4318         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4319
4320 2019-06-11  Tom Tromey  <tom@tromey.com>
4321
4322         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4323         (xmalloc_failed): Move to alloc.c.
4324         * alloc.c: New file.
4325         * Makefile.in (COMMON_SFILES): Add alloc.c.
4326
4327 2019-06-11  Tom Tromey  <tom@tromey.com>
4328
4329         * nat/linux-waitpid.c: Don't include server.h.
4330         (linux_debug): Remove.
4331         (my_waitpid): Update.
4332
4333 2019-06-11  Tom Tromey  <tromey@adacore.com>
4334
4335         * infcall.c (_initialize_infcall): Remove trailing newline from
4336         help.
4337         * user-regs.c (_initialize_user_regs): Remove trailing newline
4338         from help.
4339         * typeprint.c (_initialize_typeprint): Remove trailing newline
4340         from help.
4341         * reverse.c (_initialize_reverse): Remove trailing newlines from
4342         help.
4343         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4344         from help.
4345         * language.c (add_set_language_command): Remove trailing newline
4346         from help.
4347         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4348         help.
4349         * disasm.c (_initialize_disasm): Remove trailing newline from
4350         help.
4351         * top.c (init_main): Remove trailing newline from help.
4352         * interps.c (_initialize_interpreter): Remove trailing newline
4353         from help.
4354         * btrace.c (_initialize_btrace): Remove trailing newlines from
4355         help.
4356         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4357         from help.
4358         * python/python.c (_initialize_python): Remove trailing newline
4359         from help.
4360         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4361         help.
4362         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4363         from help.  Reformat some text.
4364         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4365         from help.
4366         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4367         newline from help.
4368
4369 2019-06-11  Tom Tromey  <tromey@adacore.com>
4370
4371         * darwin-nat.c (darwin_decode_exception_message)
4372         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4373
4374 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * valops.c (value_slice): Check for not allocated or not
4377         associated values.
4378
4379 2019-06-10  Tom de Vries  <tdevries@suse.de>
4380
4381         PR gdb/24618
4382         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4383         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4384         invalid.
4385
4386 2019-06-10  Tom de Vries  <tdevries@suse.de>
4387
4388         PR gdb/24611
4389         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4390         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4391
4392 2019-06-10  Tom de Vries  <tdevries@suse.de>
4393
4394         PR symtab/24545
4395         * symtab.c (struct demangled_name_entry): Add language field.
4396         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4397         static minimal symbol".  Set and use language field.
4398
4399 2019-06-10  Tom Tromey  <tromey@adacore.com>
4400
4401         * ada-lang.c (_initialize_ada_language): Update help text.
4402
4403 2019-06-10  Tom Tromey  <tromey@adacore.com>
4404
4405         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4406         with a newline.
4407         * guile/guile.c (handle_boot_error): Don't end warning with a
4408         newline.
4409         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4410         warning with a newline.
4411         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4412         newline.
4413         (s12z_frame_cache): Likewise.
4414         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4415         a newline.
4416         * solib-svr4.c (disable_probes_interface): Don't end warning with
4417         a newline.
4418         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4419         newline.
4420         * python/python.c (do_finish_initialization): Don't end warning
4421         with a newline.
4422
4423 2019-06-10  Tom Tromey  <tom@tromey.com>
4424
4425         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4426         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4427         gdbpy_enter.
4428
4429 2019-06-10  Tom Tromey  <tromey@adacore.com>
4430
4431         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4432         data.
4433         (elf_new_init): Don't call stabsread_new_init.
4434         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4435         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4436         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4437
4438 2019-06-10  Tom de Vries  <tdevries@suse.de>
4439
4440         PR symtab/16264
4441         PR symtab/24517
4442         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4443
4444 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4445
4446         * source.c (find_and_open_source): Also rewrite relative file
4447         names.
4448
4449 2019-04-26  Amos Bird  <amosbird@gmail.com>
4450
4451         * annotate.c (annotate_thread_exited): Add "thread-exited"
4452         annotation.
4453
4454 2019-06-06  Tom Tromey  <tromey@adacore.com>
4455
4456         * maint.h (class scoped_command_stats): Use
4457         DISABLE_COPY_AND_ASSIGN.
4458         <print_time>: New method.
4459         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4460         print_time.
4461         (scoped_command_stats::print_time): New method.
4462
4463 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4466         instructions of lengths 6 or 8 bytes.
4467
4468 2019-06-04  Pedro Alves  <palves@redhat.com>
4469
4470         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4471
4472         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4473         * breakpoint.c (condition_completer): Likewise.
4474         * cli/cli-dump.c (scan_expression): Likewise.
4475         * common/filestuff.c (mkdir_recursive): Likewise.
4476         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4477         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4478         (gdb_abspath): Likewise.
4479         * compile/compile-cplus-types.c
4480         (compile_cplus_instance::decl_name): Likewise.
4481         * completer.c (complete_explicit_location):
4482         (signal_completer, reg_or_group_completer_1): Likewise.
4483         * cp-support.c (cp_remove_params_if_any): Likewise.
4484         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4485         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4486         * infcmd.c (strip_bg_char): Likewise.
4487         * linespec.c (copy_token_string): Likewise.
4488         * mi/mi-main.c (output_cores): Likewise.
4489         * psymtab.c (psymtab_search_name):
4490         * symfile.c (test_set_ext_lang_command): Likewise.
4491         * target.c (target_fileio_read_stralloc): Likewise.
4492         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4493         * value.c (complete_internalvar): Likewise.
4494
4495 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4496
4497         Add objfile property to gdb.Type.
4498         * NEWS: Mention Python API addition.
4499         * python/py-type.c (typy_get_objfile): New method.
4500
4501 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4502
4503         * NEWS: Mention the new set|show style [title|highlight].
4504         Mention changes to "show style", "help" and "apropos".
4505
4506 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4507
4508         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4509         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4510         instead of print_help_for_command.
4511         (print_doc_of_command): New function.
4512         (help_list): Add 'apropos -v word' suggestion.
4513         (print_help_for_command): Style the command name using title style.
4514         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4515         (_initialize_cli_cmds): Describe -v in apropos_command help.
4516
4517 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4518
4519         * cli/cli-style.h (cli_style_option): Add name in constructor,
4520         add m_name class member, add constructor with intensity,
4521         add name class function.
4522         (cli_style_option::add_setshow_commands): Remove name argument.
4523         (highlight_style, title_style): New styles.
4524         * cli/cli-style.c (do_show): New function that shows a style
4525         characteristic styling the style name with itself.
4526         (set_style_name): New function.
4527         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4528         Update all callers according to the changes in cli/cli-style.h.
4529         * utils.h (fputs_highlighted): New function.
4530         * utils.c (fputs_highlighted): Likewise.
4531
4532 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4533
4534         * NEWS: Mention new pipe command and new convenience variables.
4535
4536 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * cli/cli-cmds.c (pipe_command): New function.
4539         (_initialize_cli_cmds): Call add_com for pipe_command.
4540         Define | as an alias for pipe.
4541         (exit_status_set_internal_vars): New function.
4542         (shell_escape): Call exit_status_set_internal_vars.
4543         cli/cli-decode.c (find_command_name_length): Recognize | as
4544         a single character command.
4545
4546 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4547
4548         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4549         top.c (execute_command_to_ui_file): New function, mostly a copy
4550         of execute_command_to_string.
4551         (execute_command_to_string): Implement by calling
4552         execute_command_to_ui_file.
4553
4554 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * top.h (saved_command_line): Remove declaration.
4557         * top.c (previous_saved_command_line, previous_repeat_arguments):
4558         New variables.
4559         (saved_command_line): Make static, define together with other
4560         'repeat variables'.
4561         (dont_repeat): Clear repeat_arguments.
4562         (repeat_previous, get_saved_command_line, save_command_line):
4563         New functions.
4564         (gdb_init): Initialize saved_command_line
4565         and previous_saved_command_line.
4566         * main.c (captured_main_1): Remove saved_command_line initialization.
4567         * event-top.c (handle_line_of_input): Update to use
4568         the new 'repeat' related functions instead of direct access to
4569         saved_command_line.
4570         * command.h (repeat_previous, get_saved_command_line,
4571         save_command_line): New declarations.
4572         (dont_repeat): Add comment.
4573
4574 2019-05-30  Tom Tromey  <tromey@adacore.com>
4575
4576         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4577         Fix comment.
4578         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4579
4580 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4581
4582         PR cli/24587
4583         * completer.c (complete): Initialize variable word.
4584
4585 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4586
4587         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4588         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4589         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4590         'body' is NULL to the outter 'if', protecting the '!is_define'
4591         situation as well.
4592
4593 2019-05-29  Tom Tromey  <tromey@adacore.com>
4594
4595         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4596         (dwarf_unknown): New function.
4597         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4598         (dwarf_type_encoding_name): Use dwarf_unknown.
4599
4600 2019-05-29  Tom Tromey  <tromey@adacore.com>
4601
4602         PR c++/20020:
4603         * cp-valprint.c (cp_print_value_fields): Call
4604         cp_print_static_field inside "try".
4605
4606 2019-05-29  Tom Tromey  <tromey@adacore.com>
4607
4608         * inflow.c (struct terminal_info): Add default operator=.
4609         * configure: Rebuild.
4610         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4611         -Wdeprecated-copy-dtor, -Wredundant-move.
4612
4613 2019-05-29  Tom Tromey  <tromey@adacore.com>
4614
4615         * NEWS: Add entry.
4616         * infcmd.c (print_return_value_1): Handle finish_print
4617         option.
4618         (show_print_finish): New function.
4619         (_initialize_infcmd): Add "set/show print finish" commands.
4620         * valprint.c (user_print_options): Initialize new member.
4621         * valprint.h (struct value_print_options) <finish_print>: New
4622         member.
4623
4624 2019-05-28  Tom Tromey  <tromey@adacore.com>
4625
4626         * ada-lang.c (ada_remove_Xbn_suffix)
4627         (find_old_style_renaming_symbol)
4628         (parse_old_style_renaming): Remove.
4629         (ada_find_renaming_symbol): Don't call
4630         find_old_style_renaming_symbol.
4631         (ada_is_renaming_symbol): Rename from
4632         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4633         bool.  Now static.
4634         (ada_read_var_value): Update and simplify.
4635         * ada-exp.y (write_var_or_type): Remove old code.
4636
4637 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4638
4639         * event-top.c: Remove include comment.
4640         * inflow.c (class scoped_ignore_sigttou): Move from here...
4641         * inflow.h (class scoped_ignore_sigttou): ...to here.
4642         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4643         * top.c:  Remove include comment.
4644
4645 2019-05-27  Tom Tromey  <tom@tromey.com>
4646
4647         * NEWS: Fix typo.
4648
4649 2019-05-22  Tom Tromey  <tromey@adacore.com>
4650
4651         * target.c (target_follow_exec): Constify parameter.
4652         * target-delegates.c: Rebuild.
4653         * remote.c (remote_target::follow_exec): Constify parameter.
4654         * infrun.c (follow_exec): Constify parameter.
4655         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4656         (target_follow_exec): Likewise.
4657
4658 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4659
4660         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4661         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4662
4663 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4664
4665         * NEWS: Add debugredirect and testsuite sections.
4666
4667 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4668
4669         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4670         target descriptions using exclusively floating point register name
4671         aliases.
4672
4673 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         PR gdb/18644:
4676         * f-lang.c (build_fortran_types): Handle the case where
4677         gdbarch_floatformat_for_type returns a nullptr.
4678
4679 2019-05-21  Tom de Vries  <tdevries@suse.de>
4680
4681         PR cli/24587
4682         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4683
4684 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         PR gdb/18644:
4687         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4688         16-byte floats.
4689         * i386-tdep.c (i386_floatformat_for_type): Use
4690         floatformats_ia64_quad for the 16-byte floating point component
4691         within a fortran 32-byte complex number.
4692
4693 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4696         delete default constructor.
4697         (find_partial_die): Update to return const struct.
4698         (partial_die_parent_scope): Move variable declaration into scope
4699         of its use and change its type to auto.
4700         (guess_partial_die_structure_name): Likewise.
4701         (partial_die_info::fixup): Likewise.
4702
4703 2019-05-17  Tom Tromey  <tromey@adacore.com>
4704
4705         * source.c (find_and_open_source): Remove cast.
4706
4707 2019-05-17  Tom Tromey  <tromey@adacore.com>
4708
4709         * annotate.c (annotate_source): Make "filename" const.
4710         * annotate.h (annotate_source): Use const.
4711
4712 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4713
4714         * disasm.c (set_disassembler_options): Send errors to stderr.
4715
4716 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4717
4718         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4719         (cli_interp_base::set_logging): Check debug_redirect.
4720         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4721         * cli/cli-logging.c (debug_redirect): Add static variable.
4722         (pop_output_files): Add default param.
4723         (handle_redirections): Print debug setting.
4724         (show_logging_command): Likewise.
4725         (_initialize_cli_logging): Add debugredirect command.
4726         * interps.c (current_interp_set_logging): Add debug_redirect
4727         parameter.
4728         * interps.h (set_logging): Add debug_redirect parameter.
4729         (current_interp_set_logging): Likewise.
4730         * mi/mi-common.h: Likewise.
4731         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4732
4733 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4734             Tom Tromey  <tromey@adacore.com>
4735
4736         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4737         directly.
4738         * cli/cli-interp.h (make_logging_output): Remove declaration.
4739         * cli/cli-logging.c (make_logging_output): Remove function.
4740         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4741         directly.
4742         * ui-file.c (tee_file::tee_file): Remove bools.
4743         (tee_file::~tee_file): Remove deletes.
4744         * ui-file.h (tee_file): Remove bools.
4745
4746 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4747
4748         * mi/mi-cmds.h (mi_cmd_complete): New function.
4749         * mi/mi-main.c (mi_cmd_complete): Likewise.
4750         * mi/mi-cmds.c: Define new MI command -complete.
4751         * NEWS: Mention new -complete command.
4752
4753 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4754
4755         * completer.h (complete): New function.
4756         * completer.c (complete): Likewise.
4757         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4758         function defined in completer.h.
4759
4760 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4761
4762         * MAINTAINERS (Write After Approval): Add myself.
4763
4764 2019-05-17  Tom de Vries  <tdevries@suse.de>
4765
4766         PR gdb/24094
4767         * dwarf2read.c (struct cu_partial_die_info): New struct.
4768         (find_partial_die): Return cu_partial_die_info.
4769         (partial_die_parent_scope, guess_partial_die_structure_name)
4770         (partial_die_info::fixup): Handle new return type of find_partial_die.
4771
4772 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4773
4774         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4775         "std::string", simplifying the algorithm.
4776
4777 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4778
4779         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4780         (stap_static_probe_ops::get_probes): Likewise.
4781
4782 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4783
4784         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4785         '-')" and "else if".
4786         (stap_parse_single_operand): Join checks for
4787         "gdbarch_stap_parse_special_token_p" and
4788         "gdbarch_stap_parse_special_token" in the same "if" statement.
4789         Invert check when verifying for operation on register
4790         displacement.
4791
4792 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4793
4794         * stap-probe.c (stap_get_opcode): Update comment.
4795         (stap_get_expected_argument_type): Likewise.
4796         (handle_stap_probe): Likewise.
4797
4798 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4799
4800         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4801         return type to 'bool'.  Adjust comment.  Use 'bool' when
4802         appropriate.
4803         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4804         * stap-probe.c (stap_parse_argument_1): Likewise.
4805         (stap_is_operator): Likewise.
4806         (stap_is_generic_prefix): Likewise.
4807         (stap_is_register_prefix): Likewise.
4808         (stap_is_register_indirection_prefix): Likewise.
4809         (stap_is_integer_prefix): Likewise.
4810         (stap_generic_check_suffix): Likewise.
4811         (stap_check_integer_suffix): Likewise.
4812         (stap_check_register_suffix): Likewise.
4813         (stap_check_register_indirection_suffix): Likewise.
4814         (stap_parse_register_operand): Likewise.
4815         (stap_parse_single_operand): Likewise.
4816         (stap_parse_argument_1): Likewise.
4817         (stap_probe::get_argument_count): Likewise.
4818         (stap_is_operator): Likewise.
4819
4820 2019-05-16  Tom Tromey  <tromey@adacore.com>
4821
4822         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4823         keyword to foreach.
4824
4825 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4826
4827         * linux-thread-db.c (try_thread_db_load_1): Change return type
4828         to bool.
4829         (try_thread_db_load): Likewise.
4830         (try_thread_db_load_from_pdir_1): Likewise.
4831         (try_thread_db_load_from_pdir): Likewise.
4832         (try_thread_db_load_from_sdir): Likewise.
4833         (try_thread_db_load_from_dir): Likewise.
4834         (thread_db_load_search): Likewise.
4835         (has_libpthread): Likewise.
4836         (thread_db_load): Likewise.
4837
4838 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4839
4840         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4841         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4842         NULL, and complain/return if that's the case.
4843
4844 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4845
4846         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4847         (advance, posn, abstract_read_memory): New functions.
4848         [struct mem_read_abstraction]: New struct.
4849         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4850
4851 2019-05-14  Tom Tromey  <tromey@adacore.com>
4852
4853         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4854         value is not lval_memory.
4855
4856 2019-05-14  Tom Tromey  <tromey@adacore.com>
4857
4858         * solib.c (info_sharedlibrary_command): Style the file name.
4859
4860 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4861
4862         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4863         (aarch64_vnv_type): Likewise.
4864         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4865         * common/tdesc.c: Likewise.
4866         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4867         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4868         * features/aarch64-fpu.xml: Add ieee half view.
4869         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4870         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4871         * gdbtypes.h (struct builtin_type): Likewise.
4872         (struct objfile_type): Likewise.
4873
4874 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4875
4876         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4877         typo.
4878         * location.h (string_to_event_location): Likewise.
4879
4880 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4881
4882         GDB 8.3 released.
4883
4884 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4887         New variable declaration.
4888         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4889         New variable.
4890         (print_one_breakpoint): Use ui_out::test_flags and new global
4891         variable to compute use_fixed_output.
4892         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4893         Remove.
4894         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4895         (mi_multi_location_breakpoint_output_fixed): Remove.
4896         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4897         new variable.
4898         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4899         fix_multi_location_breakpoint_output flag if version >= 3.
4900         * ui-out.h (enum ui_out_flag)
4901         <fix_multi_location_breakpoint_output>: New enumerator.
4902
4903 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4904
4905         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4906
4907 2019-05-10  Tom Tromey  <tromey@adacore.com>
4908
4909         * ada-lang.c (catch_ada_completer): New function.
4910         (_initialize_ada_language): Use it.
4911
4912 2019-05-10  Tom Tromey  <tromey@adacore.com>
4913
4914         * thread.c (print_thread_info): Make "requested_threads" const.
4915         * gdbthread.h (print_thread_info): Make "requested_threads"
4916         const.
4917         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4918         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4919
4920 2019-05-08  Tom Tromey  <tom@tromey.com>
4921
4922         * gdbtypes.c (objfile_type_data): Change type.
4923         (objfile_type, _initialize_gdbtypes): Update.
4924
4925 2019-05-08  Tom Tromey  <tom@tromey.com>
4926
4927         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4928         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4929         (_initialize_dwarf2_frame): Update.
4930
4931 2019-05-08  Tom Tromey  <tom@tromey.com>
4932
4933         * objc-lang.c (objc_objfile_data): Change type.
4934         (find_methods): Update.
4935         (_initialize_objc_lang): Remove.
4936
4937 2019-05-08  Tom Tromey  <tom@tromey.com>
4938
4939         * stabsread.c (rs6000_builtin_type_data): Change type.
4940         (rs6000_builtin_type, _initialize_stabsread): Update.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * mips-tdep.c (mips_pdr_data): Remove.
4945         (_initialize_mips_tdep): Update.
4946
4947 2019-05-08  Tom Tromey  <tom@tromey.com>
4948
4949         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4950         (hppa_init_objfile_priv_data, read_unwind_info)
4951         (find_unwind_entry, _initialize_hppa_tdep): Update.
4952
4953 2019-05-08  Tom Tromey  <tom@tromey.com>
4954
4955         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4956         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4957         on obstack.
4958         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4959
4960 2019-05-08  Tom Tromey  <tom@tromey.com>
4961
4962         * mdebugread.c (basic_type_data): Change type.
4963         (basic_type, _initialize_mdebugread): Update.
4964
4965 2019-05-08  Tom Tromey  <tom@tromey.com>
4966
4967         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * nto-tdep.c (nto_inferior_data_reg): Change type.
4972         (nto_inferior_data): Update.
4973         (nto_inferior_data_cleanup, nto_new_inferior_data)
4974         (_initialize_nto_tdep): Remove.
4975         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4976
4977 2019-05-08  Tom Tromey  <tom@tromey.com>
4978
4979         * ada-lang.c (struct ada_inferior_data): Add initializers.
4980         (ada_inferior_data): Change type.
4981         (ada_inferior_data_cleanup): Remove.
4982         (get_ada_inferior_data, ada_inferior_exit)
4983         (struct ada_pspace_data): Add initializers, destructor.
4984         (ada_pspace_data_handle): Change type.
4985         (get_ada_pspace_data): Update.
4986         (ada_pspace_data_cleanup): Remove.
4987
4988 2019-05-08  Tom Tromey  <tom@tromey.com>
4989
4990         * coffread.c (struct coff_symfile_info): Add initializers.
4991         (coff_objfile_data_key): Move lower.  Change type.
4992         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4993         Update.
4994         (coff_free_info): Remove.
4995
4996 2019-05-08  Tom Tromey  <tom@tromey.com>
4997
4998         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4999         (fbsd_pspace_data_handle): Move lower.  Change type.
5000         (get_fbsd_pspace_data): Update.
5001         (fbsd_pspace_data_cleanup): Remove.
5002         (_initialize_fbsd_tdep): Update.
5003
5004 2019-05-08  Tom Tromey  <tom@tromey.com>
5005
5006         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5007         (get_ada_tasks_pspace_data): Update.
5008         (ada_tasks_pspace_data_cleanup): Remove.
5009         (_initialize_tasks): Update.
5010         (ada_tasks_inferior_data_handle): Change type.
5011         (get_ada_tasks_inferior_data): Update.
5012         (ada_tasks_inferior_data_cleanup): Remove.
5013         (struct ada_tasks_pspace_data): Add initializers.
5014
5015 2019-05-08  Tom Tromey  <tom@tromey.com>
5016
5017         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5018         * symfile-debug.c (debug_sym_get_probes): Change type.
5019         * stap-probe.c (handle_stap_probe):
5020         (stap_static_probe_ops::get_probes): Change type.
5021         * probe.h (class static_probe_ops) <get_probes>: Change type.
5022         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5023         (parse_probes_in_pspace): Update.
5024         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5025         Update.
5026         (any_static_probe_ops::get_probes): Change type.
5027         * elfread.c (elfread_data): New typedef.
5028         (probe_key): Change type.
5029         (elf_get_probes): Likewise.  Update.
5030         (probe_key_free): Remove.
5031         (_initialize_elfread): Update.
5032         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5033         Change type.
5034         (dtrace_process_dof_probe, dtrace_process_dof)
5035         (dtrace_static_probe_ops::get_probe): Change type.
5036
5037 2019-05-08  Tom Tromey  <tom@tromey.com>
5038
5039         * xcoffread.c (struct xcoff_symfile_info): Rename from
5040         coff_symfile_info.  Add initializers.
5041         (xcoff_objfile_data_key): Move lower.  Change type.
5042         (XCOFF_DATA): Rewrite.
5043         (xcoff_free_info): Remove.
5044         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5045         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5046         (xcoff_initial_scan): Update.
5047
5048 2019-05-08  Tom Tromey  <tom@tromey.com>
5049
5050         * solib-svr4.c (struct svr4_info): Add initializers and
5051         destructor.
5052         <probes_table>: Now an htab_up.
5053         (solib_svr4_pspace_data): Change type.
5054         (free_probes_table): Simplify.
5055         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5056         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5057         (probes_table_remove_objfile_probes, register_solib_event_probe)
5058         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5059         (_initialize_svr4_solib): Update.
5060
5061 2019-05-08  Tom Tromey  <tom@tromey.com>
5062
5063         * remote.c (remote_pspace_data): Change type.
5064         (remote_pspace_data_cleanup): Remove.
5065         (get_remote_exec_file, set_pspace_remote_exec_file)
5066         (_initialize_remote): Update.
5067
5068 2019-05-08  Tom Tromey  <tom@tromey.com>
5069
5070         * breakpoint.c (breakpoint_objfile_key): Change type.
5071         (get_breakpoint_objfile_data): Update.
5072         (free_breakpoint_objfile_data): Remove.
5073         (_initialize_breakpoint): Update.
5074
5075 2019-05-08  Tom Tromey  <tom@tromey.com>
5076
5077         * linux-tdep.c (struct linux_info): Add initializers.
5078         (linux_inferior_data): Move.  Change type.
5079         (invalidate_linux_cache_inf): Update.
5080         (linux_inferior_data_cleanup): Remove.
5081         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5082
5083 2019-05-08  Tom Tromey  <tom@tromey.com>
5084
5085         * auxv.c (auxv_inferior_data): Move.  Change type.
5086         (auxv_inferior_data_cleanup): Remove.
5087         (invalidate_auxv_cache_inf): Rewrite.
5088         (get_auxv_inferior_data, _initialize_auxv): Update.
5089
5090 2019-05-08  Tom Tromey  <tom@tromey.com>
5091
5092         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5093         (symfile_debug_objfile_data_key): Change type.
5094         (symfile_debug_installed, debug_qf_has_symbols)
5095         (debug_qf_find_last_source_symtab)
5096         (debug_qf_forget_cached_source_info)
5097         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5098         (debug_qf_print_stats, debug_qf_dump)
5099         (debug_qf_expand_symtabs_for_function)
5100         (debug_qf_expand_all_symtabs)
5101         (debug_qf_expand_symtabs_with_fullname)
5102         (debug_qf_map_matching_symbols)
5103         (debug_qf_expand_symtabs_matching)
5104         (debug_qf_find_pc_sect_compunit_symtab)
5105         (debug_qf_map_symbol_filenames)
5106         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5107         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5108         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5109         (debug_sym_read_linetable, debug_sym_relocate): Update.
5110         (symfile_debug_free_objfile): Remove.
5111         (install_symfile_debug_logging, _initialize_symfile_debug):
5112         Update.
5113
5114 2019-05-08  Tom Tromey  <tom@tromey.com>
5115
5116         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5117         allocate_on_obstack.
5118         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5119         (get_dwarf2_per_objfile): Update.
5120         (set_dwarf2_per_objfile): Remove.
5121         (dwarf2_has_info, dwarf2_get_section_info): Update.
5122         (dwarf2_free_objfile): Remove.
5123         (_initialize_dwarf2_read): Update.
5124
5125 2019-05-08  Tom Tromey  <tom@tromey.com>
5126
5127         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5128         initializers.
5129         <unsupported_script_warning_printed,
5130         script_not_found_warning_printed>: Now bool.
5131         (auto_load_pspace_data): Change type.
5132         (~auto_load_pspace_info): Rename from
5133         auto_load_pspace_data_cleanup.
5134         (get_auto_load_pspace_data, init_loaded_scripts_info)
5135         (clear_section_scripts, maybe_print_unsupported_script_warning)
5136         (maybe_print_script_not_found_warning, _initialize_auto_load):
5137         Update.
5138
5139 2019-05-08  Tom Tromey  <tom@tromey.com>
5140
5141         * objfiles.c (objfile_pspace_info): Add destructor and
5142         initializers.
5143         (objfiles_pspace_data): Change type.
5144         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5145         (get_objfile_pspace_data): Update.
5146         (objfiles_bfd_data): Change type.
5147         (get_objfile_bfd_data): Update.
5148         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5149
5150 2019-05-08  Tom Tromey  <tom@tromey.com>
5151
5152         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5153         Change type.
5154         (get_catch_syscall_inferior_data): Update.
5155         (catch_syscall_inferior_data_cleanup): Remove.
5156         (_initialize_break_catch_syscall): Update.
5157
5158 2019-05-08  Tom Tromey  <tom@tromey.com>
5159
5160         * inflow.c (struct terminal_info): Add destructor and
5161         initializers.
5162         (inflow_inferior_data): Change type.
5163         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5164         (get_inflow_inferior_data, inflow_inferior_exit)
5165         (swap_terminal_info, _initialize_inflow): Update.
5166
5167 2019-05-08  Tom Tromey  <tom@tromey.com>
5168
5169         * target-dcache.c (target_dcache_cleanup): Remove.
5170         (target_dcache_aspace_key): Change type.
5171         (target_dcache_init_p, target_dcache_invalidate)
5172         (target_dcache_get, target_dcache_get_or_init)
5173         (_initialize_target_dcache): Update.
5174         * dcache.h (struct dcache_deleter): New.
5175
5176 2019-05-08  Tom Tromey  <tom@tromey.com>
5177
5178         * symtab.c (struct symbol_cache): Add destructor and
5179         initializers.
5180         (symbol_cache_key): Move.  Change type.
5181         (make_symbol_cache, free_symbol_cache): Remove.
5182         (get_symbol_cache): Update.
5183         (symbol_cache_cleanup): Remove.
5184         (ALL_PSPACES, symbol_cache_flush)
5185         (maintenance_print_symbol_cache)
5186         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5187         Update.
5188
5189 2019-05-08  Tom Tromey  <tom@tromey.com>
5190
5191         * symtab.c (struct main_info): Add destructor and initializers.
5192         (main_progspace_key): Move.  Change type.
5193         (get_main_info): Update.
5194         (main_info_cleanup): Remove.
5195         (_initialize_symtab): Update.
5196
5197 2019-05-08  Tom Tromey  <tom@tromey.com>
5198
5199         * registry.h (DECLARE_REGISTRY): Define the _key class.
5200
5201 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * NEWS: Merge two 'New commands' sections.
5204
5205 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5206
5207         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5208         parameter and use Ada language definition instead.
5209         (ada_val_print_ptr): Remove unused language parameter.
5210         (ada_val_print_num): Remove language parameter and use Ada language
5211         definition instead.
5212         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5213         parameter.
5214         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5215         parameter and use Ada language definition instead.
5216         (ada_val_print_1): Update all ada_val_print_xxx calls.
5217         Remove language parameter.
5218         (ada_val_print): Update ada_val_print_1 call.
5219
5220 2019-05-08  Tom Tromey  <tromey@adacore.com>
5221
5222         * remote.c (remote_hw_watchpoint_limit)
5223         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5224         Now static.
5225
5226 2019-05-08  Tom Tromey  <tromey@adacore.com>
5227
5228         * maint.c (_initialize_maint_cmds): Move initialization code to
5229         remote.c.
5230         (watchdog, show_watchdog): Move to remote.c.
5231         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5232         "watchdog" static.
5233         (_initialize_remote): Move initialization code from maint.c.
5234         * defs.h (watchdog): Don't declare.
5235
5236 2019-05-08  Tom Tromey  <tromey@adacore.com>
5237
5238         * tui/tui-interp.c: Include main.h.
5239         * interps.c: Include main.h.
5240         * main.h (interpreter_p): Declare.
5241         * defs.h (interpreter_p): Don't declare.
5242
5243 2019-05-08  Tom Tromey  <tromey@adacore.com>
5244
5245         * dwarf2loc.c: Include dwarf2read.h.
5246         * defs.h (read_unsigned_leb128): Don't declare.
5247         * dwarf2read.h (read_unsigned_leb128): Declare.
5248
5249 2019-05-08  Tom Tromey  <tromey@adacore.com>
5250
5251         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5252         method.
5253
5254 2019-05-08  Tom Tromey  <tromey@adacore.com>
5255
5256         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5257         when no wrap column is set.
5258
5259 2019-05-08  Tom Tromey  <tromey@adacore.com>
5260
5261         * c-lang.c (c_get_string): Handle non-C-style arrays.
5262
5263 2019-05-08  Tom Tromey  <tromey@adacore.com>
5264
5265         * typeprint.c (print_offset_data::update): Print the bit offset,
5266         not the number of bits remaining.
5267
5268 2019-05-08  Tom Tromey  <tromey@adacore.com>
5269
5270         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5271         padding at end of comment.
5272
5273 2019-05-08  Tom Tromey  <tromey@adacore.com>
5274
5275         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5276         Compare main types.
5277
5278 2019-05-06  Tom Tromey  <tom@tromey.com>
5279
5280         * common/scoped_mmap.c: Include common-defs.h.
5281         * common/scoped_mmap.h: Don't include config.h.
5282
5283 2019-05-04  Tom Tromey  <tom@tromey.com>
5284
5285         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5286         (struct aarch64_call_info): Add initializers.
5287         <si>: Now a std::vector.
5288         (pass_on_stack, aarch64_push_dummy_call): Update.
5289
5290 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5291             Tom Tromey  <tom@tromey.com>
5292
5293         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5294         (ppc_threads): Now a std::vector.  Now static.
5295         (hwdebug_find_thread_points_by_tid)
5296         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5297         Update.
5298
5299 2019-05-04  Tom Tromey  <tom@tromey.com>
5300
5301         * arc-tdep.c (arc_tdesc_init): Return bool.
5302
5303 2019-05-04  Tom Tromey  <tom@tromey.com>
5304
5305         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5306         Use gdb_assert_not_reached.
5307
5308 2019-05-04  Tom Tromey  <tom@tromey.com>
5309
5310         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5311         "false".
5312
5313 2019-05-04  Tom Tromey  <tom@tromey.com>
5314
5315         * arc-tdep.c (arc_tdesc_init): Use bool.
5316
5317 2019-05-04  Tom Tromey  <tom@tromey.com>
5318
5319         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5320
5321 2019-05-04  Tom Tromey  <tom@tromey.com>
5322
5323         * cli/cli-cmds.c (valid_command_p): Return bool.
5324
5325 2019-05-04  Tom Tromey  <tom@tromey.com>
5326
5327         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5328         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5329
5330 2019-05-04  Raul Tambre  <raul@tambre.ee>
5331
5332         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5333         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5334         operator for comparison.
5335
5336 2019-05-04  Tom Tromey  <tom@tromey.com>
5337
5338         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5339         (lookup_partial_symbol, print_partial_symbols)
5340         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5341         (psymbol_compare): Update.
5342         (add_psymbol_to_bcache): Clear the entire psymbol.
5343         (maintenance_check_psymtabs): Update.
5344         * psympriv.h (struct partial_symbol): Don't derive from
5345         general_symbol_info.
5346         <obj_section, unrelocated_address, address,
5347         set_unrelocated_address>: Update.
5348         <ginfo>: New member.
5349         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5350         (debug_names::write_psymbols): Update.
5351
5352 2019-05-04  Tom de Vries  <tdevries@suse.de>
5353
5354         * contrib/cc-with-tweaks.sh: Support -n arg.
5355
5356 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5357
5358         * corelow.c (core_target::detach): Ensure frame cache and
5359         register caches are cleared.
5360         inferior.c (exit_inferior_1): Likewise.
5361
5362 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5363             Tom Tromey  <tom@tromey.com>
5364
5365         * dictionary.c (collate_pending_symbols_by_language): Remove
5366         "struct" from foreach.
5367         * symtab.c (lookup_global_symbol_from_objfile)
5368         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5369         foreach.
5370         * ser-tcp.c (net_open): Remove "struct" from foreach.
5371         * objfiles.c (objfile_relocate, objfile_rebase)
5372         (objfile_has_symbols): Remove "struct" from foreach.
5373         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5374         from foreach.
5375         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5376         foreach.
5377         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5378         "struct" from foreach.
5379         * ada-lang.c (create_excep_cond_exprs)
5380         (ada_exception_catchpoint_cond_string): Remove "struct" from
5381         foreach.
5382
5383 2019-05-03  Tom Tromey  <tromey@adacore.com>
5384
5385         * ada-exp.y (convert_char_literal): Check suffix of each
5386         enumerator.
5387
5388 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5389
5390         PR ada/21406:
5391         * ada-exp.y (yywrap): Don't define.
5392         * ada-lex.l (%option): Add noyywrap
5393         (yywrap): Remove.
5394
5395 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5396
5397         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5398         _WIN32_WINNT to the XP level, unless already defined to a higher
5399         level.
5400
5401         * unittests/parse-connection-spec-selftests.c:
5402         * ser-tcp.c:
5403         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5404         override.
5405
5406         * symfile.c (find_separate_debug_file): Remove colon from the
5407         drive spec of DOS/Windows file names of the target, so that the
5408         file name produced from DEBUGDIR and the target's directory will
5409         be valid on DOS/Windows systems.
5410
5411 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5412
5413         * rust-lang.c (val_print_struct): Handle printing structures
5414         containing strings.
5415
5416 2019-05-02  Tom Tromey  <tromey@adacore.com>
5417
5418         * valarith.c (_initialize_valarith): Remove.
5419
5420 2019-05-01  Tom Tromey  <tromey@adacore.com>
5421
5422         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5423         bitfields.
5424
5425 2019-05-01  Tom Tromey  <tromey@adacore.com>
5426
5427         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5428         for big-endian copies.
5429
5430 2019-04-30  Ali Tamur  <tamur@google.com>
5431         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5432         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5433         (read_3_bytes): New function.
5434
5435 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5436
5437         * windows-nat.c (main_thread_id): Delete.
5438         (handle_output_debug_string): Replace main_thread_id by
5439         current_event.dwThreadId.
5440         (fake_create_process): Likewise.
5441         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5442         Do not set main_thread_id.
5443         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5444         current_event.dwThreadId.
5445         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5446
5447 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5448
5449         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5450         Use current_event.dwThreadId instead of main_thread_id.
5451
5452 2019-04-30  Tom Tromey  <tromey@adacore.com>
5453
5454         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5455         (create_excep_cond_exprs): Iterate over program spaces.
5456         (ada_exception_catchpoint_cond_string): Examine all minimal
5457         symbols for exception types.
5458
5459 2019-04-30  Tom Tromey  <tromey@adacore.com>
5460
5461         PR c++/24470:
5462         * dwarf2read.c (process_structure_scope): Handle case where type
5463         has template parameters but no symbol was created.
5464
5465 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5466             Chris January  <chris.january@arm.com>
5467
5468         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5469         qualifier.
5470         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5471
5472 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * f-typeprint.c (f_print_type): Update rules for printing
5475         whitespace.
5476         (f_type_print_varspec_suffix): Likewise.
5477
5478 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5479             Chris January  <chris.january@arm.com>
5480
5481         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5482         function arguments.
5483
5484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * f-lang.c (build_fortran_types): Change name of void type to
5487         lower case.
5488         * f-typeprint.c (f_type_print_base): Print the name of the void
5489         type, rather than a fixed string.
5490         * f-valprint.c (f_decorations): Use lower case void string.
5491
5492 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5493             Chris January  <chris.january@arm.com>
5494
5495         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5496         types for Fortran.
5497
5498 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5499             Chris January  <chris.january@arm.com>
5500             David Lecomber  <david.lecomber@arm.com>
5501
5502         * f-exp.y (BINOP_INTRINSIC): New token.
5503         (exp): New parser rule handling BINOP_INTRINSIC.
5504         (f77_keywords): Add new builtin procedures.
5505         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5506         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5507         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5508         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5509         (print_unop_subexp_f): New function.
5510         (print_binop_subexp_f): New function.
5511         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5512         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5513         (dump_subexp_body_f): Likewise.
5514         (operator_check_f): Likewise.
5515         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5516         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5517
5518 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5521         UNOP_KIND.
5522         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5523         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5524         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5525         (operator_length_f): New fuction.
5526         (print_subexp_f): New function.
5527         (op_name_f): New function.
5528         (dump_subexp_body_f): New function.
5529         (operator_check_f): New function.
5530         (exp_descriptor_f): Replace standard expression handling functions
5531         with new functions.
5532         * gdb/fortran-operator.def: New file.
5533         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5534         * gdb/std-operator.def: Remove UNOP_KIND.
5535
5536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * std-operator.def: Remove unbalanced, stray double quote
5539         character.
5540
5541 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5542             Chris January  <chris.january@arm.com>
5543             Daniel Everett  <daniel.everett@arm.com>
5544             Nick Forrington  <nick.forrington@arm.com>
5545             Richard Bunt  <richard.bunt@arm.com>
5546
5547         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5548         of depth when printing anonymous structs or unions.
5549         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5550         Don't print either the top-level value, or the children if the
5551         max-depth is exceeded.
5552         (ppscm_print_children): When printing the key of a map, allow one
5553         extra level of depth.
5554         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5555         print either the top-level value, or the children if the max-depth
5556         is exceeded.
5557         (print_children): When printing the key of a map, allow one extra
5558         level of depth.
5559         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5560         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5561         (user_print_options): Initialise max_depth field.
5562         (val_print_scalar_or_string_type_p): New function.
5563         (val_print): Check to see if the max depth has been reached.
5564         (val_print_check_max_depth): Define new function.
5565         (show_print_max_depth): New function.
5566         (_initialize_valprint): Add 'print max-depth' option.
5567         * valprint.h (struct value_print_options) <max_depth>: New field.
5568         (val_print_check_max_depth): Declare new function.
5569         * NEWS: Document new feature.
5570
5571 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * ada-lang.c (ada_language_defn): Initialise new field.
5574         * c-lang.c (c_is_string_type_p): New function.
5575         (c_language_defn): Initialise new field.
5576         (cplus_language_defn): Initialise new field.
5577         (asm_language_defn): Initialise new field.
5578         (minimal_language_defn): Initialise new field.
5579         * c-lang.h (c_is_string_type_p): Declare new function.
5580         * d-lang.c (d_language_defn): Initialise new field.
5581         * f-lang.c (f_is_string_type_p): New function.
5582         (f_language_defn): Initialise new field.
5583         * go-lang.c (go_is_string_type_p): New function.
5584         (go_language_defn): Initialise new field.
5585         * language.c (default_is_string_type_p): New function.
5586         (unknown_language_defn): Initialise new field.
5587         (auto_language_defn): Initialise new field.
5588         * language.h (struct language_defn) <la_is_string_type_p>: New
5589         member variable.
5590         (default_is_string_type_p): Declare new function.
5591         * m2-lang.c (m2_language_defn): Initialise new field.
5592         * objc-lang.c (objc_language_defn): Initialise new field.
5593         * opencl-lang.c (opencl_language_defn): Initialise new field.
5594         * p-lang.c (pascal_is_string_type_p): New function.
5595         (pascal_language_defn): Initialise new field.
5596         * rust-lang.c (rust_is_string_type_p): New function.
5597         (rust_language_defn): Initialise new field.
5598
5599 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5602         New field.
5603         * ada-lang.c (ada_language_defn): Initialise new field.
5604         * c-lang.c (c_language_defn): Likewise.
5605         (cplus_language_defn): Likewise.
5606         (asm_language_defn): Likewise.
5607         (minimal_language_defn): Likewise.
5608         * d-lang.c (d_language_defn): Likewise.
5609         * f-lang.c (f_language_defn): Likewise.
5610         * go-lang.c (go_language_defn): Likewise.
5611         * language.c (unknown_language_defn): Likewise.
5612         (auto_language_defn): Likewise.
5613         * m2-lang.c (m2_language_defn): Likewise.
5614         * objc-lang.c (objc_language_defn): Likewise.
5615         * opencl-lang.c (opencl_language_defn): Likewise.
5616         * p-lang.c (pascal_language_defn): Likewise.
5617         * rust-lang.c (rust_language_defn): Likewise.
5618
5619 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5620
5621         * ada-lang.c (ada_is_character_type): Change return type to bool.
5622         (ada_is_string_type): Likewise.
5623         * ada-lang.h (ada_is_character_type): Update declaration
5624         (ada_is_string_type): Likewise.
5625
5626 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         Support style in 'frame|thread apply'
5629
5630         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5631         * record.c (record_start, record_stop): Update callers of
5632         execute_command_to_string with false.
5633         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5634         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5635         methods.
5636         (class string_file): New constructor with term_out parameter.
5637         Override methods term_out and can_emit_style_escape.  New member
5638         term_out.
5639         (class stdio_file): Override can_emit_style_escape.
5640         (class tee_file): Override term_out and can_emit_style_escape.
5641         * utils.h (can_emit_style_escape): Remove.
5642         * utils.c (can_emit_style_escape): Likewise.
5643         Update all callers of can_emit_style_escape (SOMESTREAM) to
5644         SOMESTREAM->can_emit_style_escape.
5645         * source-cache.c (source_cache::get_source_lines): Likewise.
5646         * stack.c (frame_apply_command_count): Call execute_command_to_string
5647         passing the term_out characteristic of the current gdb_stdout.
5648         * thread.c (thr_try_catch_cmd): Likewise.
5649         * top.c (execute_command_to_string): pass term_out parameter
5650         to construct the string_file for the command output.
5651         * ui-file.c (term_cli_styling): New function (most code moved
5652         from utils.c can_emit_style_escape).
5653         (string_file::string_file, string_file::can_emit_style_escape,
5654         stdio_file::can_emit_style_escape, tee_file::term_out,
5655         tee_file::can_emit_style_escape): New functions.
5656
5657 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5658
5659         * NEWS: Mention the new set|show may-call-functions.
5660         * infcall.c (may_call_functions_p): New variable.
5661         (show_may_call_functions_p): New function.
5662         (call_function_by_hand_dummy): Throws an error if not
5663         may-call-functions.
5664         (_initialize_infcall): Call add_setshow_boolean_cmd for
5665         may-call-functions.
5666
5667 2019-04-25  Keith Seitz  <keiths@redhat.com>
5668
5669         PR c++/24367
5670         * cp-support.c (inspect_type): Don't attempt substitutions
5671         of symbol with the same name.
5672
5673 2019-04-25  Tom Tromey  <tromey@adacore.com>
5674
5675         PR gdb/24475:
5676         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5677         static.
5678
5679 2019-04-25  Tom Tromey  <tromey@adacore.com>
5680
5681         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5682         rvalue reference.
5683         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5684         (gdb_xml_parser::parse): Use std::move.
5685         * python/python-internal.h (gdbpy_convert_exception): Take a const
5686         reference.
5687         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5688         std::move.
5689         * python/py-utils.c (gdbpy_convert_exception): Take a const
5690         reference.
5691         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5692         Use std::move.
5693         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5694         Use std::move.
5695         * mi/mi-main.c (mi_print_exception): Take a const reference.
5696         * main.c (handle_command_errors): Take a const reference.
5697         * linespec.c (parse_linespec): Use std::move.
5698         * infcall.c (run_inferior_call): Use std::move.
5699         (call_function_by_hand_dummy): Use std::move.
5700         * exec.c (try_open_exec_file): Use std::move.
5701         * exceptions.h (exception_print, exception_fprintf)
5702         (exception_print_same): Update.
5703         * exceptions.c (print_exception, exception_print)
5704         (exception_fprintf, exception_print_same): Change parameters to
5705         const reference.
5706         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5707         * common/new-op.c: Use std::move.
5708         * common/common-exceptions.h (struct gdb_exception): Add move
5709         constructor.
5710         (struct gdb_exception_error, struct gdb_exception_quit, struct
5711         gdb_quit_bad_alloc): Change constructor to move constructor.
5712         (throw_exception): Change parameter to rvalue reference.
5713         * common/common-exceptions.c (throw_exception): Take rvalue
5714         reference.
5715         * cli/cli-interp.c (safe_execute_command): Use std::move.
5716         * breakpoint.c (insert_bp_location, location_to_sals): Use
5717         std::move.
5718
5719 2019-04-25  Tom Tromey  <tromey@adacore.com>
5720
5721         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5722         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5723         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5724         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5725         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5726         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5727         guile/scm-value.c: Use unpack.
5728         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5729         gdbscm_gdb_exception.
5730         (gdbscm_throw_gdb_exception): Likewise.
5731         (struct gdbscm_gdb_exception): New.
5732         (unpack): New function.
5733         (gdbscm_wrap): Use unpack.
5734
5735 2019-04-25  Tom Tromey  <tromey@adacore.com>
5736
5737         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5738         (gdb_rl_callback_handler): Use std::move.
5739         * common/common-exceptions.h (struct gdb_exception): Add move
5740         assignment operator.
5741         (throw_exception_sjlj): Change "exception" to const reference.
5742         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5743         (throw_exception_sjlj): Change "exception" to const reference.
5744
5745 2019-04-25  Tom Tromey  <tromey@adacore.com>
5746
5747         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5748         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5749         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5750         Update.
5751         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5752         Update.
5753         * mi/mi-interp.c (mi_interp::exec): Update.
5754         * linespec.c (parse_linespec): Update.
5755         * infcall.c (run_inferior_call): Update.
5756         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5757         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5758         (gdbscm_lookup_global_symbol): Update.
5759         * guile/scm-param.c (gdbscm_parameter_value): Update.
5760         * guile/scm-frame.c (gdbscm_frame_read_register)
5761         (gdbscm_frame_read_var): Update.
5762         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5763         * exec.c (try_open_exec_file): Update.
5764         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5765         (gdb_rl_callback_handler): Update.
5766         * common/common-exceptions.h (exception_none): Don't declare.
5767         * common/common-exceptions.c (exception_none): Don't define.
5768         (struct catcher) <exception>: Update.
5769         * cli/cli-interp.c (safe_execute_command): Update.
5770         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5771
5772 2019-04-25  Ali Tamur  <tamur@google.com>
5773
5774         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5775         (read_attribute_value): Likewise.
5776         (dwarf2_read_addr_index): Update comment.
5777         (read_str_index): Add DW_FORM_strx.
5778         (dwarf2_string_attr): Likewise.
5779         (dwarf2_const_value_attr): Likewise.
5780         (dump_die_shallow): Likewise.
5781         (dwarf2_fetch_constant_bytes): Likewise.
5782         (skip_form_bytes): Likewise.
5783         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5784
5785 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5786
5787         PR corefiles/11608
5788         PR corefiles/18187
5789         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5790         OFFSET.  Verify if current mapping contains an ELF header.
5791         (linux_find_memory_regions_full): Adjust call to
5792         dump_mapping_p.
5793
5794 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5795             Kang Li <kanglictf@gmail.com>
5796
5797         PR gdb/21600
5798
5799         * dwarf2-frame.c (read_initial_length): Be consistent about using
5800         unsigned representation of length.
5801         (decode_frame_entry_1): Likewise.  Check for wraparound of
5802         end pointer as well as buffer overflow.
5803
5804 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5805
5806         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5807         "vq".
5808
5809 2019-04-24  Tom Tromey  <tromey@adacore.com>
5810
5811         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5812
5813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5814
5815         * s12z-tdep.c (s12z_unwind_pc): Delete.
5816         (s12z_unwind_sp): Delete.
5817         (s12z_gdbarch_init): Don't register deleted functions with
5818         gdbarch.
5819
5820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * rl78-tdep.c (rl78_unwind_sp): Delete.
5823         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5824
5825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5828         (xstormy16_unwind_pc): Delete.
5829         (xstormy16_dummy_id): Delete.
5830         (xstormy16_gdbarch_init): Don't register deleted functions with
5831         gdbarch.
5832
5833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * vax-tdep.c (vax_unwind_pc): Delete.
5836         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5837
5838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * v850-tdep.c (v850_unwind_sp): Delete.
5841         (v850_unwind_pc): Delete.
5842         (v850_dummy_id): Delete.
5843         (v850_gdbarch_init): Don't register deleted functions with
5844         gdbarch.
5845
5846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5849         (tilegx_unwind_pc): Delete.
5850         (tilegx_unwind_dummy_id): Delete.
5851         (tilegx_gdbarch_init): Don't register deleted functions with
5852         gdbarch.
5853
5854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5855
5856         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5857         (tic6x_dummy_id): Delete.
5858         (tic6x_gdbarch_init): Don't register deleted functions with
5859         gdbarch.
5860
5861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * sparc-tdep.c (sparc_unwind_pc): Delete.
5864         (sparc32_gdbarch_init): Don't register deleted function with
5865         gdbarch.
5866
5867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * sh-tdep.c (sh_unwind_sp): Delete.
5870         (sh_unwind_pc): Delete.
5871         (sh_dummy_id): Delete.
5872         (sh_gdbarch_init): Don't register deleted functions with
5873         gdbarch.
5874
5875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * score-tdep.c (score_unwind_sp): Delete.
5878         (score_unwind_pc): Delete.
5879         (score_dummy_id): Delete.
5880         (score_gdbarch_init): Don't register deleted functions with
5881         gdbarch.
5882
5883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * rx-tdep.c (rx_unwind_pc): Delete.
5886         (rx_unwind_sp): Delete.
5887         (rx_dummy_id): Delete.
5888         (rx_gdbarch_init): Don't register deleted functions with
5889         gdbarch.  Update comment.
5890
5891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5894         (rs6000_dummy_id): Delete.
5895         (rs6000_gdbarch_init): Don't register deleted functions with
5896         gdbarch.
5897
5898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * or1k-tdep.c (or1k_dummy_id): Delete.
5901         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5902
5903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * nios2-tdep.c (nios2_dummy_id): Delete.
5906         (nios2_unwind_sp): Delete.
5907         (nios2_gdbarch_init): Don't register deleted functions with
5908         gdbarch.
5909
5910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5911
5912         * nds32-tdep.c (nds32_dummy_id): Delete.
5913         (nds32_unwind_pc): Delete.
5914         (nds32_unwind_sp): Delete.
5915         (nds32_gdbarch_init): Don't register deleted functions with
5916         gdbarch.
5917
5918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5919
5920         * msp430-tdep.c (msp430_unwind_pc): Delete.
5921         (msp430_unwind_sp): Delete.
5922         (msp430_dummy_id): Delete.
5923         (msp430_gdbarch_init): Don't register deleted functions with
5924         gdbarch.
5925
5926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5927
5928         * moxie-tdep.c (moxie_unwind_sp): Delete.
5929         (moxie_unwind_pc): Delete.
5930         (moxie_dummy_id): Delete.
5931         (moxie_gdbarch_init): Don't register deleted functions with
5932         gdbarch.
5933
5934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5937         (mn10300_unwind_pc): Delete.
5938         (mn10300_unwind_sp): Delete.
5939         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5940         mn10300_unwind_sp.
5941         (mn10300_frame_unwind_init): Don't register deleted functions with
5942         gdbarch.
5943
5944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * mep-tdep.c (mep_unwind_pc): Delete.
5947         (mep_unwind_sp): Delete.
5948         (mep_dummy_id): Delete.
5949         (mep_gdbarch_init): Don't register deleted functions with
5950         gdbarch.
5951
5952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5953
5954         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5955         (m68hc11_unwind_sp): Delete.
5956         (m68hc11_gdbarch_init): Don't register deleted functions with
5957         gdbarch.
5958
5959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * m32r-tdep.c (m32r_unwind_sp): Delete.
5962         (m32r_unwind_pc): Delete.
5963         (m32r_dummy_id): Delete.
5964         (m32r_gdbarch_init): Don't register deleted functions with
5965         gdbarch.
5966
5967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * m32c-tdep.c (m32c_unwind_pc): Delete.
5970         (m32c_unwind_sp): Delete.
5971         (m32c_dummy_id): Delete.
5972         (m32c_gdbarch_init): Don't register deleted functions with
5973         gdbarch.
5974
5975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5978         (lm32_unwind_pc): Delete.
5979         (lm32_dummy_id): Delete.
5980         (lm32_gdbarch_init): Don't register deleted functions with
5981         gdbarch.
5982
5983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5984
5985         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5986         (iq2000_unwind_pc): Delete.
5987         (iq2000_dummy_id): Delete.
5988         (iq2000_gdbarch_init): Don't register deleted functions with
5989         gdbarch.
5990
5991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * nds32-tdep.c (nds32_type_align): Delete.
5994         (nds32_push_dummy_call): Use type_align instead.
5995
5996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * arm-tdep.c (arm_type_align): Only handle vector override case.
5999         (arm_push_dummy_call): Use type_align.
6000         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6001
6002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6005         case.
6006         (pass_on_stack): Use type_align.
6007         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6008         function.
6009
6010 2019-04-23  Tom Tromey  <tromey@adacore.com>
6011
6012         * dwarf2read.c (line_header::file_name_at): Remove unused
6013         overload.
6014
6015 2019-04-23  Tom de Vries  <tdevries@suse.de>
6016
6017         PR gdb/24438
6018         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6019         invocation.
6020
6021
6022 2019-03-27  Ali Tamur  <tamur@google.com>
6023
6024         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6025         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6026         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6027         (dwarf_expr_context::get_addr_index): Likewise
6028         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6029         (symbol_needs_eval_context::get_addr_index): Likewise
6030         (disassemble_dwarf_expression): Add DW_OP_addrx
6031         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6032         (read_cutu_die_from_dwo): Update comment
6033         (skip_one_die): Add DW_FORM_addrx
6034         (read_attribute_value): Likewise
6035         (var_decode_location): Add DW_OP_addrx
6036         (dwarf2_const_value_attr): Add DW_FORM_addrx
6037         (dump_die_shallow): Likewise
6038         (dwarf2_fetch_constant_bytes): Likewise
6039         (decode_locdesc): Add DW_OP_addrx
6040         (skip_form_bytes): Add DW_FORM_addrx
6041
6042 2019-04-22  Ali Tamur  <tamur@google.com>
6043
6044         * MAINTAINERS (Write After Approval): Add self.
6045
6046 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6047
6048         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6049         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6050         (open_symbol_file_object): Likewise.
6051         (svr4_default_sos): Add info parameter.
6052         (svr4_read_so_list): Likewise.
6053         (svr4_current_sos_direct): Adjust functions calls to pass down
6054         info.
6055         (svr4_current_sos_1): Add info parameter.
6056         (svr4_current_sos): Call get_svr4_info, pass info down to
6057         svr4_current_sos_1.
6058         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6059         get_svr4_info.
6060         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6061         get_svr4_info.
6062         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6063         to get_svr4_info.
6064         (probes_table_remove_objfile_probes): Likewise.
6065         (register_solib_event_probe): Add info parameter.
6066         (solist_update_incremental): Pass info parameter down to
6067         svr4_read_so_list.
6068         (disable_probes_interface): Add info parameter.
6069         (svr4_handle_solib_event): Pass current_program_space to
6070         get_svr4_info.  Adjust disable_probes_interface cleanup.
6071         (svr4_create_probe_breakpoints): Add info parameter, pass it
6072         down to register_solib_event_probe.
6073         (svr4_create_solib_event_breakpoints): Add info parameter,
6074         pass it down to svr4_create_probe_breakpoints.
6075         (enable_break): Pass info down to
6076         svr4_create_solib_event_breakpoints.
6077         (svr4_solib_create_inferior_hook): Pass current_program_space to
6078         get_svr4_info.
6079         (svr4_clear_solib): Likewise.
6080
6081 2019-04-22  Pedro Alves  <palves@redhat.com>
6082
6083         * solib-svr4.c (svr4_free_objfile_observer): New.
6084         (probe_and_action::objfile): New field.
6085         (probes_table_htab_remove_objfile_probes)
6086         (probes_table_remove_objfile_probes): New functions.
6087         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6088         in the new probe_and_action.  Don't store the probe in 'lookup'.
6089         (svr4_create_probe_breakpoints): Pass objfile to
6090         register_solib_event_probe.
6091         (_initialize_svr4_solib): Register a free_objfile observer.
6092
6093 2019-04-19  Tom Tromey  <tom@tromey.com>
6094
6095         * common/queue.h: Remove.
6096
6097 2019-04-19  Tom Tromey  <tom@tromey.com>
6098
6099         * event-loop.c: Don't include "common/queue.h".
6100
6101 2019-04-19  Tom Tromey  <tom@tromey.com>
6102
6103         * remote.c (remote_target): Use delete.
6104         * remote-notif.h: Include <list>, not "common/queue.h".
6105         (notif_client_p): Remove typedef.
6106         (remote_notif_state): Add constructor, destructor, initializer.
6107         <notif_queue>: Now a std::list.
6108         (remote_notif_state_xfree): Don't declare.
6109         * remote-notif.c (remote_notif_process, handle_notification)
6110         (remote_notif_state_allocate): Update.
6111         (~remote_notif_state): Rename from remote_notif_state_xfree.
6112
6113 2019-04-19  Tom Tromey  <tom@tromey.com>
6114
6115         * symfile.c (reread_symbols): Update.
6116         * objfiles.c (objfile_register_static_link)
6117         (objfile_lookup_static_link): Update
6118         (~objfile) Don't delete static_links.
6119         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6120
6121 2019-04-19  Tom Tromey  <tom@tromey.com>
6122
6123         * type-stack.h (struct type_stack) <insert>: Constify string.
6124         * type-stack.c (type_stack::insert): Constify string.
6125         * gdbtypes.h (lookup_template_type): Update.
6126         (address_space_name_to_int): Update.
6127         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6128         const.
6129         (lookup_template_type): Make name const.
6130         * c-exp.y: Update rules.
6131         (lex_one_token, classify_name, classify_inner_name)
6132         (c_print_token): Update.
6133         * p-exp.y: Update rules.
6134         (yylex): Update.
6135         * f-exp.y: Update rules.
6136         (yylex): Update.
6137         * d-exp.y: Update rules.
6138         (lex_one_token, classify_name, classify_inner_name): Update.
6139         * parse.c (write_dollar_variable, copy_name): Return std::string.
6140         * parser-defs.h (copy_name): Change return type.
6141         * m2-exp.y: Update rules.
6142         (yylex): Update.
6143         * go-exp.y (lex_one_token): Update.
6144         Update rules.
6145         (classify_unsafe_function, classify_packaged_name)
6146         (classify_name, yylex): Update.
6147
6148 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6149
6150         * configure.ac: add --enable-source-highlight switch.
6151         * configure: Regenerate.
6152         * top.c (print_gdb_version): plumb --enable-source-highlight
6153         status to "show configuration".
6154
6155 2019-04-19  Tom Tromey  <tromey@adacore.com>
6156
6157         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6158         Check ADA_TYPE_P.
6159         (empty_record, ada_template_to_fixed_record_type_1)
6160         (template_to_static_fixed_type)
6161         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6162         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6163         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6164         macros.
6165
6166 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6167
6168         PR symtab/24423:
6169         * source.c (print_source_lines_base): Advance "iter" when a
6170         control character is seen.
6171
6172 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * inferior.h (struct infcall_suspend_state_deleter):
6175         Catch exception in destructor to avoid crash.
6176
6177 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6178
6179         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6180         close to the add_com "shell".
6181
6182 2019-04-18  Tom Tromey  <tromey@adacore.com>
6183
6184         * process-stratum-target.h (class process_stratum_target)
6185         <stratum>: Add "final".
6186
6187 2019-04-17  Tom Tromey  <tromey@adacore.com>
6188
6189         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6190         against nullptr before use.
6191
6192 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6193
6194         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6195
6196 2019-04-17  Jim Wilson  <jimw@sifive.com>
6197             Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6200         code read might fail, assume 4-byte breakpoint in that case.
6201
6202 2019-04-15  Leszek Swirski  <leszeks@google.com>
6203
6204         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6205         rather than a hand-rolled POD check when checking for forced MEMORY
6206         classification.
6207
6208 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6209
6210         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6211         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6212         function.
6213         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6214         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6215         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6216         declaration.
6217
6218 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6219
6220         * aarch64-linux-nat.c
6221         (aarch64_linux_nat_target::thread_architecture): Add override.
6222         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6223         each VQ.
6224
6225 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6226
6227         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6228
6229 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6232         target types of size 96-bits, add some additional comments, and
6233         check that the builtin type we found was the correct size.
6234
6235 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6236
6237         * utils.c (prompt_for_continue): Don't restore the styling at the
6238         end, as applied_style has the wrong value.  This fixes styling in
6239         long lists of file names that are interrupted by the "Continue?"
6240         prompt.
6241
6242 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6245         * c-lang.c (c_language_defn): Likewise.
6246         (cplus_language_defn): Likewise.
6247         (asm_language_defn): Likewise.
6248         (minimal_language_defn): Likewise.
6249         * d-lang.c (d_language_defn): Likewise.
6250         * f-lang.c (f_language_defn): Likewise.
6251         * go-lang.c (go_language_defn): Likewise.
6252         * language.c (unknown_language_defn): Likewise.
6253         (auto_language_defn): Likewise.
6254         * language.h (struct language_defn): Remove la_magic field.
6255         (LANG_MAGIC): Delete.
6256         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6257         * objc-lang.c (objc_language_defn): Likewise.
6258         * opencl-lang.c (opencl_language_defn): Likewise.
6259         * p-lang.c (pascal_language_defn): Likewise.
6260         * rust-lang.c (rust_language_defn): Likewise.
6261
6262 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * riscv-tdep.c (riscv_type_align): New function.
6265         (riscv_type_alignment): Delete.
6266         (riscv_arg_location): Use 'type_align'.
6267         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6268
6269 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * gdbtypes.c (type_align): A struct with no non-static fields also
6272         has alignment of 1.
6273
6274 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6277         component to 0.
6278         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6279         member.
6280         (riscv_struct_info::analyse): New implementation using new
6281         analyse_inner member function.
6282         (riscv_struct_info::field_offset): New member function.
6283         (riscv_struct_info::m_offsets): New member variable.
6284         (riscv_struct_info::analyse_inner): New private member function,
6285         takes the old implementation of riscv_struct_info::analyse but
6286         extended to track field offsets.
6287         (riscv_call_arg_struct): Update the struct folding special cases
6288         to handle cases where empty C++ structs, which are non-zero
6289         length, are found.
6290         (riscv_arg_location): Initialise the length of each location, a
6291         non-zero length now indicates the location is in use.
6292         (riscv_push_dummy_call): Allow for the first location having a
6293         non-zero offset when setting up arguments.
6294         (riscv_return_value): Likewise, but for return values.
6295
6296 2019-04-11  Tom Tromey  <tromey@adacore.com>
6297
6298         * utils.c (internal_vproblem): Make "msg" const.
6299
6300 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6301
6302         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6303         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6304         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6305         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6306
6307 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6308
6309         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6310         function.
6311         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6312         of amd64_collect_native_gregset.
6313         (amd64_linux_nat_target::store_registers): Likewise.
6314
6315 2019-04-10  Tom Tromey  <tom@tromey.com>
6316
6317         * symtab.c (lookup_global_symbol_from_objfile)
6318         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6319         * objfiles.h (class separate_debug_iterator): New.
6320         (class separate_debug_range): New.
6321         (struct objfile) <separate_debug_objfiles>: New method.
6322         (objfile_separate_debug_iterate): Don't declare.
6323         * objfiles.c (separate_debug_iterator::operator++): Rename from
6324         objfile_separate_debug_iterate.
6325         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6326         iterator.
6327         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6328         iterator.
6329
6330 2019-04-10  Tom Tromey  <tom@tromey.com>
6331
6332         * symfile.c (reread_symbols): Remove old comment.
6333         * objfiles.c (free_all_objfiles): Fix a typo.
6334
6335 2019-04-10  Tom Tromey  <tom@tromey.com>
6336
6337         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6338         * minsyms.c (lookup_minimal_symbol): Use foreach.
6339         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6340         (lookup_minimal_symbol_solib_trampoline): Likewise.
6341         * symfile.c (reread_symbols): Use foreach.
6342
6343 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6344             Tom Tromey  <tromey@adacore.com>
6345
6346         PR rust/24414:
6347         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6348         (rust_lex_int_test): Change "value" to be LONGEST.
6349         (rust_lex_tests): Add test for long integer literal.
6350
6351 2019-04-09  Tom Tromey  <tromey@adacore.com>
6352
6353         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6354         to bool.
6355         (extended_remote_target::attach): Update.
6356         (remote_target::remote_notice_new_inferior): Update.
6357         (remote_target::add_current_inferior_and_thread): Update.
6358         * inferior.c (exit_inferior_1): Use "false".
6359         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6360
6361 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6362
6363         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6364         the "start" command.
6365
6366 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6367
6368         * python/py-inferior.c (infpy_thread_from_thread_handle):
6369         Adjust comments to reflect renaming of thread_from_thread_handle
6370         to thread_from_handle.  Adjust keywords.  Fix type error message.
6371         (inferior_object_methods): Add thread_from_handle.  Retain
6372         thread_from_thread_handle, but mark it as deprecated.
6373
6374 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6375
6376         * gdbthread.h (find_thread_by_handle): Revise declaration.
6377         * thread.c (find_thread_by_handle): Likewise.  Adjust
6378         implementation too.
6379         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6380         support for buffer objects as handles.
6381
6382 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6383
6384         * python/py-infthread.c (thpy_thread_handle): New function.
6385         (thread_object_methods): Register thpy_thread_handle.
6386
6387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6388
6389         * gdbthread.h (thread_to_thread_handle): Declare.
6390         * thread.c (gdbtypes.h): Include.
6391         (thread_to_thread_handle): New function.
6392
6393         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6394         (target_thread_info_to_thread_handle): Declare.
6395         * target.c (target_thread_info_to_thread_handle): New function.
6396         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6397         * target-delegates.c: Regenerate.
6398
6399         * linux-thread-db.c (class thread_db_target): Add method
6400         thread_info_to_thread_handle.
6401         (thread_db_target::thread_info_to_thread_handle): Define.
6402         * remote.c (class remote_target): Add new method
6403         thread_info_to_thread_handle.
6404         (remote_target::thread_info_to_thread_handle): Define.
6405
6406 2019-04-08  Pedro Alves  <palves@redhat.com>
6407
6408         * common/common-exceptions.c (throw_exception): Don't create
6409         named object to throw; throw directly.
6410         (throw_it): Likewise.  Don't initialize gdb_exception::message
6411         here, with new; pass FMT and AP to the ctor instead.
6412         * common/common-exceptions.h: Include <string>.
6413         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6414         const char *, va_list)): New ctor.  Use std::make_shared.
6415         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6416         errors)): Delete.
6417         (gdb_exception_error::gdb_exception_error(enum errors, const char
6418         *, va_list)): New.
6419         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6420         Add assertion.
6421         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6422         errors)): Delete.
6423         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6424         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6425         Add assertion.
6426
6427 2019-04-08  Tom Tromey  <tom@tromey.com>
6428
6429         * valops.c (value_rtti_indirect_type): Replace throw_exception
6430         with throw.
6431         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6432         with throw.
6433         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6434         throw.
6435         * target.c (target_translate_tls_address): Replace throw_exception
6436         with throw.
6437         * stack.c (frame_apply_command_count): Replace throw_exception
6438         with throw.
6439         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6440         throw.
6441         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6442         with throw.
6443         * rs6000-tdep.c (rs6000_frame_cache)
6444         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6445         * remote.c: Replace throw_exception with throw.
6446         * record-full.c (record_full_message, record_full_wait_1)
6447         (record_full_restore): Replace throw_exception with throw.
6448         * record-btrace.c:
6449         (get_thread_current_frame_id, record_btrace_start_replaying)
6450         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6451         (cmd_record_btrace_start): Replace throw_exception with throw.
6452         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6453         throw.
6454         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6455         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6456         * linespec.c:
6457         (find_linespec_symbols): Replace throw_exception with throw.
6458         * infrun.c (displaced_step_prepare, resume): Replace
6459         throw_exception with throw.
6460         * infcmd.c (post_create_inferior): Replace throw_exception with
6461         throw.
6462         * inf-loop.c (inferior_event_handler): Replace throw_exception
6463         with throw.
6464         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6465         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6466         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6467         (get_prev_frame_always, get_frame_pc_if_available)
6468         (get_frame_address_in_block_if_available, get_frame_language):
6469         Replace throw_exception with throw.
6470         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6471         throw_exception with throw.
6472         * eval.c (fetch_subexp_value, evaluate_var_value)
6473         (evaluate_funcall, evaluate_subexp_standard): Replace
6474         throw_exception with throw.
6475         * dwarf2loc.c (call_site_find_chain)
6476         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6477         Replace throw_exception with throw.
6478         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6479         with throw.
6480         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6481         throw.
6482         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6483         * completer.c (complete_line_internal): Replace throw_exception
6484         with throw.
6485         * compile/compile-object-run.c (compile_object_run): Replace
6486         throw_exception with throw.
6487         * cli/cli-script.c (process_next_line): Replace throw_exception
6488         with throw.
6489         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6490         (btrace_enable, btrace_maint_update_pt_packets): Replace
6491         throw_exception with throw.
6492         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6493         throw_exception with throw.
6494         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6495         throw_exception with throw.
6496         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6497         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6498         * aarch64-tdep.c (aarch64_make_prologue_cache)
6499         (aarch64_make_stub_cache): Replace throw_exception with throw.
6500
6501 2019-04-08  Tom Tromey  <tom@tromey.com>
6502
6503         * common/common-exceptions.c (throw_exception): Rename from
6504         throw_exception_cxx.  Remove old copy.  Make argument const.
6505         (throw_it): Create and throw exception objects directly.
6506         * common/common-exceptions.h (throw_exception): Make argument
6507         const.
6508         (struct gdb_exception_error): Add constructor.
6509         (struct gdb_exception_quit): Add constructor.
6510
6511 2019-04-08  Tom Tromey  <tom@tromey.com>
6512
6513         * common/common-exceptions.h (exception_rethrow): Don't declare.
6514         (TRY_SJLJ): Update comment.
6515         (TRY, CATCH, END_CATCH): Remove.
6516         * common/common-exceptions.c (exception_rethrow): Remove.
6517
6518 2019-04-08  Tom Tromey  <tom@tromey.com>
6519
6520         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6521         Remove.
6522         (gdb_exception_error): Rename from
6523         gdb_exception_RETURN_MASK_ERROR.
6524         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6525         (gdb_quit_bad_alloc): Update.
6526         * aarch64-tdep.c: Update.
6527         * ada-lang.c: Update.
6528         * ada-typeprint.c: Update.
6529         * ada-valprint.c: Update.
6530         * amd64-tdep.c: Update.
6531         * arch-utils.c: Update.
6532         * break-catch-throw.c: Update.
6533         * breakpoint.c: Update.
6534         * btrace.c: Update.
6535         * c-varobj.c: Update.
6536         * cli/cli-cmds.c: Update.
6537         * cli/cli-interp.c: Update.
6538         * cli/cli-script.c: Update.
6539         * common/common-exceptions.c: Update.
6540         * common/new-op.c: Update.
6541         * common/selftest.c: Update.
6542         * compile/compile-c-symbols.c: Update.
6543         * compile/compile-cplus-symbols.c: Update.
6544         * compile/compile-object-load.c: Update.
6545         * compile/compile-object-run.c: Update.
6546         * completer.c: Update.
6547         * corelow.c: Update.
6548         * cp-abi.c: Update.
6549         * cp-support.c: Update.
6550         * cp-valprint.c: Update.
6551         * darwin-nat.c: Update.
6552         * disasm-selftests.c: Update.
6553         * dtrace-probe.c: Update.
6554         * dwarf-index-cache.c: Update.
6555         * dwarf-index-write.c: Update.
6556         * dwarf2-frame-tailcall.c: Update.
6557         * dwarf2-frame.c: Update.
6558         * dwarf2loc.c: Update.
6559         * dwarf2read.c: Update.
6560         * eval.c: Update.
6561         * event-loop.c: Update.
6562         * event-top.c: Update.
6563         * exec.c: Update.
6564         * f-valprint.c: Update.
6565         * fbsd-tdep.c: Update.
6566         * frame-unwind.c: Update.
6567         * frame.c: Update.
6568         * gdbtypes.c: Update.
6569         * gnu-v3-abi.c: Update.
6570         * guile/guile-internal.h: Update.
6571         * guile/scm-block.c: Update.
6572         * guile/scm-breakpoint.c: Update.
6573         * guile/scm-cmd.c: Update.
6574         * guile/scm-disasm.c: Update.
6575         * guile/scm-frame.c: Update.
6576         * guile/scm-lazy-string.c: Update.
6577         * guile/scm-math.c: Update.
6578         * guile/scm-param.c: Update.
6579         * guile/scm-ports.c: Update.
6580         * guile/scm-pretty-print.c: Update.
6581         * guile/scm-symbol.c: Update.
6582         * guile/scm-symtab.c: Update.
6583         * guile/scm-type.c: Update.
6584         * guile/scm-value.c: Update.
6585         * i386-linux-tdep.c: Update.
6586         * i386-tdep.c: Update.
6587         * inf-loop.c: Update.
6588         * infcall.c: Update.
6589         * infcmd.c: Update.
6590         * infrun.c: Update.
6591         * jit.c: Update.
6592         * language.c: Update.
6593         * linespec.c: Update.
6594         * linux-fork.c: Update.
6595         * linux-nat.c: Update.
6596         * linux-tdep.c: Update.
6597         * linux-thread-db.c: Update.
6598         * main.c: Update.
6599         * mi/mi-cmd-break.c: Update.
6600         * mi/mi-cmd-stack.c: Update.
6601         * mi/mi-interp.c: Update.
6602         * mi/mi-main.c: Update.
6603         * objc-lang.c: Update.
6604         * p-valprint.c: Update.
6605         * parse.c: Update.
6606         * ppc-linux-tdep.c: Update.
6607         * printcmd.c: Update.
6608         * python/py-arch.c: Update.
6609         * python/py-breakpoint.c: Update.
6610         * python/py-cmd.c: Update.
6611         * python/py-finishbreakpoint.c: Update.
6612         * python/py-frame.c: Update.
6613         * python/py-framefilter.c: Update.
6614         * python/py-gdb-readline.c: Update.
6615         * python/py-inferior.c: Update.
6616         * python/py-infthread.c: Update.
6617         * python/py-lazy-string.c: Update.
6618         * python/py-linetable.c: Update.
6619         * python/py-objfile.c: Update.
6620         * python/py-param.c: Update.
6621         * python/py-prettyprint.c: Update.
6622         * python/py-progspace.c: Update.
6623         * python/py-record-btrace.c: Update.
6624         * python/py-record.c: Update.
6625         * python/py-symbol.c: Update.
6626         * python/py-type.c: Update.
6627         * python/py-unwind.c: Update.
6628         * python/py-utils.c: Update.
6629         * python/py-value.c: Update.
6630         * python/python.c: Update.
6631         * record-btrace.c: Update.
6632         * record-full.c: Update.
6633         * remote-fileio.c: Update.
6634         * remote.c: Update.
6635         * riscv-tdep.c: Update.
6636         * rs6000-aix-tdep.c: Update.
6637         * rs6000-tdep.c: Update.
6638         * rust-exp.y: Update.
6639         * rust-lang.c: Update.
6640         * s390-tdep.c: Update.
6641         * selftest-arch.c: Update.
6642         * solib-dsbt.c: Update.
6643         * solib-frv.c: Update.
6644         * solib-spu.c: Update.
6645         * solib-svr4.c: Update.
6646         * solib.c: Update.
6647         * sparc64-linux-tdep.c: Update.
6648         * stack.c: Update.
6649         * symfile-mem.c: Update.
6650         * symmisc.c: Update.
6651         * target.c: Update.
6652         * thread.c: Update.
6653         * top.c: Update.
6654         * tracefile-tfile.c: Update.
6655         * tui/tui.c: Update.
6656         * typeprint.c: Update.
6657         * unittests/cli-utils-selftests.c: Update.
6658         * unittests/parse-connection-spec-selftests.c: Update.
6659         * valops.c: Update.
6660         * valprint.c: Update.
6661         * value.c: Update.
6662         * varobj.c: Update.
6663         * windows-nat.c: Update.
6664         * x86-linux-nat.c: Update.
6665         * xml-support.c: Update.
6666
6667 2019-04-08  Tom Tromey  <tom@tromey.com>
6668
6669         * xml-support.c: Use C++ exception handling.
6670         * x86-linux-nat.c: Use C++ exception handling.
6671         * windows-nat.c: Use C++ exception handling.
6672         * varobj.c: Use C++ exception handling.
6673         * value.c: Use C++ exception handling.
6674         * valprint.c: Use C++ exception handling.
6675         * valops.c: Use C++ exception handling.
6676         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6677         handling.
6678         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6679         * typeprint.c: Use C++ exception handling.
6680         * tui/tui.c: Use C++ exception handling.
6681         * tracefile-tfile.c: Use C++ exception handling.
6682         * top.c: Use C++ exception handling.
6683         * thread.c: Use C++ exception handling.
6684         * target.c: Use C++ exception handling.
6685         * symmisc.c: Use C++ exception handling.
6686         * symfile-mem.c: Use C++ exception handling.
6687         * stack.c: Use C++ exception handling.
6688         * sparc64-linux-tdep.c: Use C++ exception handling.
6689         * solib.c: Use C++ exception handling.
6690         * solib-svr4.c: Use C++ exception handling.
6691         * solib-spu.c: Use C++ exception handling.
6692         * solib-frv.c: Use C++ exception handling.
6693         * solib-dsbt.c: Use C++ exception handling.
6694         * selftest-arch.c: Use C++ exception handling.
6695         * s390-tdep.c: Use C++ exception handling.
6696         * rust-lang.c: Use C++ exception handling.
6697         * rust-exp.y: Use C++ exception handling.
6698         * rs6000-tdep.c: Use C++ exception handling.
6699         * rs6000-aix-tdep.c: Use C++ exception handling.
6700         * riscv-tdep.c: Use C++ exception handling.
6701         * remote.c: Use C++ exception handling.
6702         * remote-fileio.c: Use C++ exception handling.
6703         * record-full.c: Use C++ exception handling.
6704         * record-btrace.c: Use C++ exception handling.
6705         * python/python.c: Use C++ exception handling.
6706         * python/py-value.c: Use C++ exception handling.
6707         * python/py-utils.c: Use C++ exception handling.
6708         * python/py-unwind.c: Use C++ exception handling.
6709         * python/py-type.c: Use C++ exception handling.
6710         * python/py-symbol.c: Use C++ exception handling.
6711         * python/py-record.c: Use C++ exception handling.
6712         * python/py-record-btrace.c: Use C++ exception handling.
6713         * python/py-progspace.c: Use C++ exception handling.
6714         * python/py-prettyprint.c: Use C++ exception handling.
6715         * python/py-param.c: Use C++ exception handling.
6716         * python/py-objfile.c: Use C++ exception handling.
6717         * python/py-linetable.c: Use C++ exception handling.
6718         * python/py-lazy-string.c: Use C++ exception handling.
6719         * python/py-infthread.c: Use C++ exception handling.
6720         * python/py-inferior.c: Use C++ exception handling.
6721         * python/py-gdb-readline.c: Use C++ exception handling.
6722         * python/py-framefilter.c: Use C++ exception handling.
6723         * python/py-frame.c: Use C++ exception handling.
6724         * python/py-finishbreakpoint.c: Use C++ exception handling.
6725         * python/py-cmd.c: Use C++ exception handling.
6726         * python/py-breakpoint.c: Use C++ exception handling.
6727         * python/py-arch.c: Use C++ exception handling.
6728         * printcmd.c: Use C++ exception handling.
6729         * ppc-linux-tdep.c: Use C++ exception handling.
6730         * parse.c: Use C++ exception handling.
6731         * p-valprint.c: Use C++ exception handling.
6732         * objc-lang.c: Use C++ exception handling.
6733         * mi/mi-main.c: Use C++ exception handling.
6734         * mi/mi-interp.c: Use C++ exception handling.
6735         * mi/mi-cmd-stack.c: Use C++ exception handling.
6736         * mi/mi-cmd-break.c: Use C++ exception handling.
6737         * main.c: Use C++ exception handling.
6738         * linux-thread-db.c: Use C++ exception handling.
6739         * linux-tdep.c: Use C++ exception handling.
6740         * linux-nat.c: Use C++ exception handling.
6741         * linux-fork.c: Use C++ exception handling.
6742         * linespec.c: Use C++ exception handling.
6743         * language.c: Use C++ exception handling.
6744         * jit.c: Use C++ exception handling.
6745         * infrun.c: Use C++ exception handling.
6746         * infcmd.c: Use C++ exception handling.
6747         * infcall.c: Use C++ exception handling.
6748         * inf-loop.c: Use C++ exception handling.
6749         * i386-tdep.c: Use C++ exception handling.
6750         * i386-linux-tdep.c: Use C++ exception handling.
6751         * guile/scm-value.c: Use C++ exception handling.
6752         * guile/scm-type.c: Use C++ exception handling.
6753         * guile/scm-symtab.c: Use C++ exception handling.
6754         * guile/scm-symbol.c: Use C++ exception handling.
6755         * guile/scm-pretty-print.c: Use C++ exception handling.
6756         * guile/scm-ports.c: Use C++ exception handling.
6757         * guile/scm-param.c: Use C++ exception handling.
6758         * guile/scm-math.c: Use C++ exception handling.
6759         * guile/scm-lazy-string.c: Use C++ exception handling.
6760         * guile/scm-frame.c: Use C++ exception handling.
6761         * guile/scm-disasm.c: Use C++ exception handling.
6762         * guile/scm-cmd.c: Use C++ exception handling.
6763         * guile/scm-breakpoint.c: Use C++ exception handling.
6764         * guile/scm-block.c: Use C++ exception handling.
6765         * guile/guile-internal.h: Use C++ exception handling.
6766         * gnu-v3-abi.c: Use C++ exception handling.
6767         * gdbtypes.c: Use C++ exception handling.
6768         * frame.c: Use C++ exception handling.
6769         * frame-unwind.c: Use C++ exception handling.
6770         * fbsd-tdep.c: Use C++ exception handling.
6771         * f-valprint.c: Use C++ exception handling.
6772         * exec.c: Use C++ exception handling.
6773         * event-top.c: Use C++ exception handling.
6774         * event-loop.c: Use C++ exception handling.
6775         * eval.c: Use C++ exception handling.
6776         * dwarf2read.c: Use C++ exception handling.
6777         * dwarf2loc.c: Use C++ exception handling.
6778         * dwarf2-frame.c: Use C++ exception handling.
6779         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6780         * dwarf-index-write.c: Use C++ exception handling.
6781         * dwarf-index-cache.c: Use C++ exception handling.
6782         * dtrace-probe.c: Use C++ exception handling.
6783         * disasm-selftests.c: Use C++ exception handling.
6784         * darwin-nat.c: Use C++ exception handling.
6785         * cp-valprint.c: Use C++ exception handling.
6786         * cp-support.c: Use C++ exception handling.
6787         * cp-abi.c: Use C++ exception handling.
6788         * corelow.c: Use C++ exception handling.
6789         * completer.c: Use C++ exception handling.
6790         * compile/compile-object-run.c: Use C++ exception handling.
6791         * compile/compile-object-load.c: Use C++ exception handling.
6792         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6793         * compile/compile-c-symbols.c: Use C++ exception handling.
6794         * common/selftest.c: Use C++ exception handling.
6795         * common/new-op.c: Use C++ exception handling.
6796         * cli/cli-script.c: Use C++ exception handling.
6797         * cli/cli-interp.c: Use C++ exception handling.
6798         * cli/cli-cmds.c: Use C++ exception handling.
6799         * c-varobj.c: Use C++ exception handling.
6800         * btrace.c: Use C++ exception handling.
6801         * breakpoint.c: Use C++ exception handling.
6802         * break-catch-throw.c: Use C++ exception handling.
6803         * arch-utils.c: Use C++ exception handling.
6804         * amd64-tdep.c: Use C++ exception handling.
6805         * ada-valprint.c: Use C++ exception handling.
6806         * ada-typeprint.c: Use C++ exception handling.
6807         * ada-lang.c: Use C++ exception handling.
6808         * aarch64-tdep.c: Use C++ exception handling.
6809
6810 2019-04-08  Tom Tromey  <tom@tromey.com>
6811
6812         * xml-support.c (gdb_xml_parser::parse): Update.
6813         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6814         * value.c (show_convenience): Update.
6815         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6816         (test_parse_flags_qcs): Update.
6817         * thread.c (thr_try_catch_cmd): Update.
6818         * target.c (target_translate_tls_address): Update.
6819         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6820         (info_frame_command_core, frame_apply_command_count): Update.
6821         * rust-exp.y (rust_lex_exception_test): Update.
6822         * riscv-tdep.c (riscv_print_one_register_info): Update.
6823         * remote.c (remote_target::enable_btrace): Update.
6824         * record-btrace.c (record_btrace_enable_warn): Update.
6825         * python/py-utils.c (gdbpy_convert_exception): Update.
6826         * printcmd.c (do_one_display, print_variable_and_value): Update.
6827         * mi/mi-main.c (mi_print_exception): Update.
6828         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6829         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6830         * linux-nat.c (linux_nat_target::attach): Update.
6831         * linux-fork.c (class scoped_switch_fork_info): Update.
6832         * infrun.c (displaced_step_prepare): Update.
6833         * infcall.c (call_function_by_hand_dummy): Update.
6834         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6835         * gnu-v3-abi.c (print_one_vtable): Update.
6836         * frame.c (get_prev_frame_always): Update.
6837         * f-valprint.c (info_common_command_for_block): Update.
6838         * exec.c (try_open_exec_file): Update.
6839         * exceptions.c (print_exception, exception_print)
6840         (exception_fprintf, exception_print_same): Update.
6841         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6842         * dwarf-index-cache.c (index_cache::store)
6843         (index_cache::lookup_gdb_index): Update.
6844         * darwin-nat.c (maybe_cache_shell): Update.
6845         * cp-valprint.c (cp_print_value_fields): Update.
6846         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6847         (gcc_cplus_symbol_address): Update.
6848         * compile/compile-c-symbols.c (gcc_convert_symbol)
6849         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6850         * common/selftest.c: Update.
6851         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6852         a std::string.
6853         (exception_try_scope_entry, exception_try_scope_exit): Don't
6854         declare.
6855         (struct exception_try_scope): Remove.
6856         (TRY): Don't use exception_try_scope.
6857         (struct gdb_exception): Add constructor, operator=.
6858         <what>: New method.
6859         (struct gdb_exception_RETURN_MASK_ALL)
6860         (struct gdb_exception_RETURN_MASK_ERROR)
6861         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6862         (struct gdb_quit_bad_alloc): Update.
6863         * common/common-exceptions.c (exception_none): Change
6864         initializer.
6865         (struct catcher) <state, exception>: Initialize inline.
6866         <prev>: Remove member.
6867         (current_catcher): Remove.
6868         (catchers): New global.
6869         (exceptions_state_mc_init): Simplify.
6870         (catcher_pop): Remove.
6871         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6872         (try_scope_depth, exception_try_scope_entry)
6873         (exception_try_scope_exit): Remove.
6874         (throw_exception_sjlj): Update.
6875         (exception_messages, exception_messages_size): Remove.
6876         (throw_it): Simplify.
6877         (gdb_exception_sliced_copy): Remove.
6878         (throw_exception_cxx): Update.
6879         * cli/cli-script.c (script_from_file): Update.
6880         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6881         Update.
6882         * ada-valprint.c (ada_val_print): Update.
6883         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6884         (create_excep_cond_exprs): Update.
6885
6886 2019-04-08  Tom Tromey  <tom@tromey.com>
6887
6888         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6889         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6890         (TRY, CATCH, END_CATCH): Remove some definitions.
6891         * common/common-exceptions.c: Don't use GDB_XCPT.
6892         (catcher_list_size): Remove.
6893         (throw_exception, throw_it): Simplify.
6894
6895 2019-04-05  Tom Tromey  <tom@tromey.com>
6896
6897         Revert the header-sorting patch.
6898         * ft32-tdep.c: Revert.
6899         * frv-tdep.c: Revert.
6900         * frv-linux-tdep.c: Revert.
6901         * frame.c: Revert.
6902         * frame-unwind.c: Revert.
6903         * frame-base.c: Revert.
6904         * fork-child.c: Revert.
6905         * findvar.c: Revert.
6906         * findcmd.c: Revert.
6907         * filesystem.c: Revert.
6908         * filename-seen-cache.h: Revert.
6909         * filename-seen-cache.c: Revert.
6910         * fbsd-tdep.c: Revert.
6911         * fbsd-nat.h: Revert.
6912         * fbsd-nat.c: Revert.
6913         * f-valprint.c: Revert.
6914         * f-typeprint.c: Revert.
6915         * f-lang.c: Revert.
6916         * extension.h: Revert.
6917         * extension.c: Revert.
6918         * extension-priv.h: Revert.
6919         * expprint.c: Revert.
6920         * exec.h: Revert.
6921         * exec.c: Revert.
6922         * exceptions.c: Revert.
6923         * event-top.c: Revert.
6924         * event-loop.c: Revert.
6925         * eval.c: Revert.
6926         * elfread.c: Revert.
6927         * dwarf2read.h: Revert.
6928         * dwarf2read.c: Revert.
6929         * dwarf2loc.c: Revert.
6930         * dwarf2expr.h: Revert.
6931         * dwarf2expr.c: Revert.
6932         * dwarf2-frame.c: Revert.
6933         * dwarf2-frame-tailcall.c: Revert.
6934         * dwarf-index-write.h: Revert.
6935         * dwarf-index-write.c: Revert.
6936         * dwarf-index-common.c: Revert.
6937         * dwarf-index-cache.h: Revert.
6938         * dwarf-index-cache.c: Revert.
6939         * dummy-frame.c: Revert.
6940         * dtrace-probe.c: Revert.
6941         * disasm.h: Revert.
6942         * disasm.c: Revert.
6943         * disasm-selftests.c: Revert.
6944         * dictionary.c: Revert.
6945         * dicos-tdep.c: Revert.
6946         * demangle.c: Revert.
6947         * dcache.h: Revert.
6948         * dcache.c: Revert.
6949         * darwin-nat.h: Revert.
6950         * darwin-nat.c: Revert.
6951         * darwin-nat-info.c: Revert.
6952         * d-valprint.c: Revert.
6953         * d-namespace.c: Revert.
6954         * d-lang.c: Revert.
6955         * ctf.c: Revert.
6956         * csky-tdep.c: Revert.
6957         * csky-linux-tdep.c: Revert.
6958         * cris-tdep.c: Revert.
6959         * cris-linux-tdep.c: Revert.
6960         * cp-valprint.c: Revert.
6961         * cp-support.c: Revert.
6962         * cp-namespace.c: Revert.
6963         * cp-abi.c: Revert.
6964         * corelow.c: Revert.
6965         * corefile.c: Revert.
6966         * continuations.c: Revert.
6967         * completer.h: Revert.
6968         * completer.c: Revert.
6969         * complaints.c: Revert.
6970         * coffread.c: Revert.
6971         * coff-pe-read.c: Revert.
6972         * cli-out.h: Revert.
6973         * cli-out.c: Revert.
6974         * charset.c: Revert.
6975         * c-varobj.c: Revert.
6976         * c-valprint.c: Revert.
6977         * c-typeprint.c: Revert.
6978         * c-lang.c: Revert.
6979         * buildsym.c: Revert.
6980         * buildsym-legacy.c: Revert.
6981         * build-id.h: Revert.
6982         * build-id.c: Revert.
6983         * btrace.c: Revert.
6984         * bsd-uthread.c: Revert.
6985         * breakpoint.h: Revert.
6986         * breakpoint.c: Revert.
6987         * break-catch-throw.c: Revert.
6988         * break-catch-syscall.c: Revert.
6989         * break-catch-sig.c: Revert.
6990         * blockframe.c: Revert.
6991         * block.c: Revert.
6992         * bfin-tdep.c: Revert.
6993         * bfin-linux-tdep.c: Revert.
6994         * bfd-target.c: Revert.
6995         * bcache.c: Revert.
6996         * ax-general.c: Revert.
6997         * ax-gdb.h: Revert.
6998         * ax-gdb.c: Revert.
6999         * avr-tdep.c: Revert.
7000         * auxv.c: Revert.
7001         * auto-load.c: Revert.
7002         * arm-wince-tdep.c: Revert.
7003         * arm-tdep.c: Revert.
7004         * arm-symbian-tdep.c: Revert.
7005         * arm-pikeos-tdep.c: Revert.
7006         * arm-obsd-tdep.c: Revert.
7007         * arm-nbsd-tdep.c: Revert.
7008         * arm-nbsd-nat.c: Revert.
7009         * arm-linux-tdep.c: Revert.
7010         * arm-linux-nat.c: Revert.
7011         * arm-fbsd-tdep.c: Revert.
7012         * arm-fbsd-nat.c: Revert.
7013         * arm-bsd-tdep.c: Revert.
7014         * arch-utils.c: Revert.
7015         * arc-tdep.c: Revert.
7016         * arc-newlib-tdep.c: Revert.
7017         * annotate.h: Revert.
7018         * annotate.c: Revert.
7019         * amd64-windows-tdep.c: Revert.
7020         * amd64-windows-nat.c: Revert.
7021         * amd64-tdep.c: Revert.
7022         * amd64-sol2-tdep.c: Revert.
7023         * amd64-obsd-tdep.c: Revert.
7024         * amd64-obsd-nat.c: Revert.
7025         * amd64-nbsd-tdep.c: Revert.
7026         * amd64-nbsd-nat.c: Revert.
7027         * amd64-nat.c: Revert.
7028         * amd64-linux-tdep.c: Revert.
7029         * amd64-linux-nat.c: Revert.
7030         * amd64-fbsd-tdep.c: Revert.
7031         * amd64-fbsd-nat.c: Revert.
7032         * amd64-dicos-tdep.c: Revert.
7033         * amd64-darwin-tdep.c: Revert.
7034         * amd64-bsd-nat.c: Revert.
7035         * alpha-tdep.c: Revert.
7036         * alpha-obsd-tdep.c: Revert.
7037         * alpha-nbsd-tdep.c: Revert.
7038         * alpha-mdebug-tdep.c: Revert.
7039         * alpha-linux-tdep.c: Revert.
7040         * alpha-linux-nat.c: Revert.
7041         * alpha-bsd-tdep.c: Revert.
7042         * alpha-bsd-nat.c: Revert.
7043         * aix-thread.c: Revert.
7044         * agent.c: Revert.
7045         * addrmap.c: Revert.
7046         * ada-varobj.c: Revert.
7047         * ada-valprint.c: Revert.
7048         * ada-typeprint.c: Revert.
7049         * ada-tasks.c: Revert.
7050         * ada-lang.c: Revert.
7051         * aarch64-tdep.c: Revert.
7052         * aarch64-ravenscar-thread.c: Revert.
7053         * aarch64-newlib-tdep.c: Revert.
7054         * aarch64-linux-tdep.c: Revert.
7055         * aarch64-linux-nat.c: Revert.
7056         * aarch64-fbsd-tdep.c: Revert.
7057         * aarch64-fbsd-nat.c: Revert.
7058         * aarch32-linux-nat.c: Revert.
7059
7060 2019-04-05  Tom Tromey  <tom@tromey.com>
7061
7062         * ft32-tdep.c: Sort headers.
7063         * frv-tdep.c: Sort headers.
7064         * frv-linux-tdep.c: Sort headers.
7065         * frame.c: Sort headers.
7066         * frame-unwind.c: Sort headers.
7067         * frame-base.c: Sort headers.
7068         * fork-child.c: Sort headers.
7069         * findvar.c: Sort headers.
7070         * findcmd.c: Sort headers.
7071         * filesystem.c: Sort headers.
7072         * filename-seen-cache.h: Sort headers.
7073         * filename-seen-cache.c: Sort headers.
7074         * fbsd-tdep.c: Sort headers.
7075         * fbsd-nat.h: Sort headers.
7076         * fbsd-nat.c: Sort headers.
7077         * f-valprint.c: Sort headers.
7078         * f-typeprint.c: Sort headers.
7079         * f-lang.c: Sort headers.
7080         * extension.h: Sort headers.
7081         * extension.c: Sort headers.
7082         * extension-priv.h: Sort headers.
7083         * expprint.c: Sort headers.
7084         * exec.h: Sort headers.
7085         * exec.c: Sort headers.
7086         * exceptions.c: Sort headers.
7087         * event-top.c: Sort headers.
7088         * event-loop.c: Sort headers.
7089         * eval.c: Sort headers.
7090         * elfread.c: Sort headers.
7091         * dwarf2read.h: Sort headers.
7092         * dwarf2read.c: Sort headers.
7093         * dwarf2loc.c: Sort headers.
7094         * dwarf2expr.h: Sort headers.
7095         * dwarf2expr.c: Sort headers.
7096         * dwarf2-frame.c: Sort headers.
7097         * dwarf2-frame-tailcall.c: Sort headers.
7098         * dwarf-index-write.h: Sort headers.
7099         * dwarf-index-write.c: Sort headers.
7100         * dwarf-index-common.c: Sort headers.
7101         * dwarf-index-cache.h: Sort headers.
7102         * dwarf-index-cache.c: Sort headers.
7103         * dummy-frame.c: Sort headers.
7104         * dtrace-probe.c: Sort headers.
7105         * disasm.h: Sort headers.
7106         * disasm.c: Sort headers.
7107         * disasm-selftests.c: Sort headers.
7108         * dictionary.c: Sort headers.
7109         * dicos-tdep.c: Sort headers.
7110         * demangle.c: Sort headers.
7111         * dcache.h: Sort headers.
7112         * dcache.c: Sort headers.
7113         * darwin-nat.h: Sort headers.
7114         * darwin-nat.c: Sort headers.
7115         * darwin-nat-info.c: Sort headers.
7116         * d-valprint.c: Sort headers.
7117         * d-namespace.c: Sort headers.
7118         * d-lang.c: Sort headers.
7119         * ctf.c: Sort headers.
7120         * csky-tdep.c: Sort headers.
7121         * csky-linux-tdep.c: Sort headers.
7122         * cris-tdep.c: Sort headers.
7123         * cris-linux-tdep.c: Sort headers.
7124         * cp-valprint.c: Sort headers.
7125         * cp-support.c: Sort headers.
7126         * cp-namespace.c: Sort headers.
7127         * cp-abi.c: Sort headers.
7128         * corelow.c: Sort headers.
7129         * corefile.c: Sort headers.
7130         * continuations.c: Sort headers.
7131         * completer.h: Sort headers.
7132         * completer.c: Sort headers.
7133         * complaints.c: Sort headers.
7134         * coffread.c: Sort headers.
7135         * coff-pe-read.c: Sort headers.
7136         * cli-out.h: Sort headers.
7137         * cli-out.c: Sort headers.
7138         * charset.c: Sort headers.
7139         * c-varobj.c: Sort headers.
7140         * c-valprint.c: Sort headers.
7141         * c-typeprint.c: Sort headers.
7142         * c-lang.c: Sort headers.
7143         * buildsym.c: Sort headers.
7144         * buildsym-legacy.c: Sort headers.
7145         * build-id.h: Sort headers.
7146         * build-id.c: Sort headers.
7147         * btrace.c: Sort headers.
7148         * bsd-uthread.c: Sort headers.
7149         * breakpoint.h: Sort headers.
7150         * breakpoint.c: Sort headers.
7151         * break-catch-throw.c: Sort headers.
7152         * break-catch-syscall.c: Sort headers.
7153         * break-catch-sig.c: Sort headers.
7154         * blockframe.c: Sort headers.
7155         * block.c: Sort headers.
7156         * bfin-tdep.c: Sort headers.
7157         * bfin-linux-tdep.c: Sort headers.
7158         * bfd-target.c: Sort headers.
7159         * bcache.c: Sort headers.
7160         * ax-general.c: Sort headers.
7161         * ax-gdb.h: Sort headers.
7162         * ax-gdb.c: Sort headers.
7163         * avr-tdep.c: Sort headers.
7164         * auxv.c: Sort headers.
7165         * auto-load.c: Sort headers.
7166         * arm-wince-tdep.c: Sort headers.
7167         * arm-tdep.c: Sort headers.
7168         * arm-symbian-tdep.c: Sort headers.
7169         * arm-pikeos-tdep.c: Sort headers.
7170         * arm-obsd-tdep.c: Sort headers.
7171         * arm-nbsd-tdep.c: Sort headers.
7172         * arm-nbsd-nat.c: Sort headers.
7173         * arm-linux-tdep.c: Sort headers.
7174         * arm-linux-nat.c: Sort headers.
7175         * arm-fbsd-tdep.c: Sort headers.
7176         * arm-fbsd-nat.c: Sort headers.
7177         * arm-bsd-tdep.c: Sort headers.
7178         * arch-utils.c: Sort headers.
7179         * arc-tdep.c: Sort headers.
7180         * arc-newlib-tdep.c: Sort headers.
7181         * annotate.h: Sort headers.
7182         * annotate.c: Sort headers.
7183         * amd64-windows-tdep.c: Sort headers.
7184         * amd64-windows-nat.c: Sort headers.
7185         * amd64-tdep.c: Sort headers.
7186         * amd64-sol2-tdep.c: Sort headers.
7187         * amd64-obsd-tdep.c: Sort headers.
7188         * amd64-obsd-nat.c: Sort headers.
7189         * amd64-nbsd-tdep.c: Sort headers.
7190         * amd64-nbsd-nat.c: Sort headers.
7191         * amd64-nat.c: Sort headers.
7192         * amd64-linux-tdep.c: Sort headers.
7193         * amd64-linux-nat.c: Sort headers.
7194         * amd64-fbsd-tdep.c: Sort headers.
7195         * amd64-fbsd-nat.c: Sort headers.
7196         * amd64-dicos-tdep.c: Sort headers.
7197         * amd64-darwin-tdep.c: Sort headers.
7198         * amd64-bsd-nat.c: Sort headers.
7199         * alpha-tdep.c: Sort headers.
7200         * alpha-obsd-tdep.c: Sort headers.
7201         * alpha-nbsd-tdep.c: Sort headers.
7202         * alpha-mdebug-tdep.c: Sort headers.
7203         * alpha-linux-tdep.c: Sort headers.
7204         * alpha-linux-nat.c: Sort headers.
7205         * alpha-bsd-tdep.c: Sort headers.
7206         * alpha-bsd-nat.c: Sort headers.
7207         * aix-thread.c: Sort headers.
7208         * agent.c: Sort headers.
7209         * addrmap.c: Sort headers.
7210         * ada-varobj.c: Sort headers.
7211         * ada-valprint.c: Sort headers.
7212         * ada-typeprint.c: Sort headers.
7213         * ada-tasks.c: Sort headers.
7214         * ada-lang.c: Sort headers.
7215         * aarch64-tdep.c: Sort headers.
7216         * aarch64-ravenscar-thread.c: Sort headers.
7217         * aarch64-newlib-tdep.c: Sort headers.
7218         * aarch64-linux-tdep.c: Sort headers.
7219         * aarch64-linux-nat.c: Sort headers.
7220         * aarch64-fbsd-tdep.c: Sort headers.
7221         * aarch64-fbsd-nat.c: Sort headers.
7222         * aarch32-linux-nat.c: Sort headers.
7223
7224 2019-04-04  Tom Tromey  <tom@tromey.com>
7225
7226         * varobj.c (varobj_create): Update.
7227         * rust-exp.y (struct rust_parser) <update_innermost_block,
7228         lookup_symbol>: New methods.
7229         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7230         Rename.
7231         (rust_parser::rust_lookup_type)
7232         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7233         * printcmd.c (display_command, do_one_display): Update.
7234         * parser-defs.h (struct parser_state) <parser_state>: Add
7235         "tracker" parameter.
7236         (block_tracker): New member.
7237         (class innermost_block_tracker) <innermost_block_tracker>: Add
7238         "types" parameter.
7239         <reset>: Remove method.
7240         (innermost_block): Don't declare.
7241         (null_post_parser): Update.
7242         * parse.c (innermost_block): Remove global.
7243         (write_dollar_variable): Update.
7244         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7245         Remove "tracker_types" parameter.
7246         (parse_expression): Add "tracker" parameter.
7247         (parse_expression_for_completion): Update.
7248         (null_post_parser): Add "tracker" parameter.
7249         * p-exp.y: Update rules.
7250         * m2-exp.y: Update rules.
7251         * language.h (struct language_defn) <la_post_parser>: Add
7252         "tracker" parameter.
7253         * go-exp.y: Update rules.
7254         * f-exp.y: Update rules.
7255         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7256         parameter.
7257         * d-exp.y: Update rules.
7258         * c-exp.y: Update rules.
7259         * breakpoint.c (set_breakpoint_condition): Create an
7260         innermost_block_tracker.
7261         (watch_command_1): Likewise.
7262         * ada-lang.c (resolve): Add "tracker" parameter.
7263         (resolve_subexp): Likewise.
7264         * ada-exp.y (write_var_from_sym): Update.
7265
7266 2019-04-04  Tom Tromey  <tom@tromey.com>
7267
7268         * type-stack.h: New file.
7269         * type-stack.c: New file.
7270         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7271         type-stack.h.
7272         (insert_into_type_stack, insert_type, push_type, push_type_int)
7273         (insert_type_address_space, pop_type, pop_type_int)
7274         (pop_typelist, pop_type_stack, append_type_stack)
7275         (push_type_stack, get_type_stack, push_typelist)
7276         (follow_type_instance_flags, follow_types): Don't declare.
7277         * parse.c (type_stack): Remove global.
7278         (parse_exp_in_context): Update.
7279         (insert_into_type_stack, insert_type, push_type, push_type_int)
7280         (insert_type_address_space, pop_type, pop_type_int)
7281         (pop_typelist, pop_type_stack, append_type_stack)
7282         (push_type_stack, get_type_stack, push_typelist)
7283         (follow_type_instance_flags, follow_types): Remove (moved to
7284         type-stack.c).
7285         * f-exp.y (type_stack): New global.
7286         Update rules.
7287         (push_kind_type, f_parse): Update.
7288         * d-exp.y (type_stack): New global.
7289         Update rules.
7290         (d_parse): Update.
7291         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7292         Update rules.
7293         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7294         (HFILES_NO_SRCDIR): Add type-stack.h.
7295
7296 2019-04-04  Tom Tromey  <tom@tromey.com>
7297
7298         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7299         (rust_parser::convert_ast_to_expression, rust_parse)
7300         (rust_lex_test_completion, rust_lex_tests): Update.
7301         * parser-defs.h (struct expr_completion_state): New.
7302         (struct parser_state) <parser_state>: Add completion parameter.
7303         <mark_struct_expression, mark_completion_tag>: New methods.
7304         <parse_completion, m_completion_state>: New members.
7305         (prefixify_expression, null_post_parser): Update.
7306         (mark_struct_expression, mark_completion_tag): Don't declare.
7307         * parse.c (parse_completion, expout_last_struct)
7308         (expout_tag_completion_type, expout_completion_name): Remove
7309         globals.
7310         (parser_state::mark_struct_expression)
7311         (parser_state::mark_completion_tag): Now methods.
7312         (prefixify_expression): Add last_struct parameter.
7313         (prefixify_subexp): Likewise.
7314         (parse_exp_1): Update.
7315         (parse_exp_in_context): Add cstate parameter.  Update.
7316         (parse_expression_for_completion): Create an
7317         expr_completion_state.
7318         (null_post_parser): Add "completion" parameter.
7319         * p-exp.y: Update rules.
7320         (yylex): Update.
7321         * language.h (struct language_defn) <la_post_parser>: Add
7322         "completing" parameter.
7323         * go-exp.y: Update rules.
7324         (lex_one_token): Update.
7325         * expression.h (parse_completion): Don't declare.
7326         * d-exp.y: Update rules.
7327         (lex_one_token): Update rules.
7328         * c-exp.y: Update rules.
7329         (lex_one_token): Update.
7330         * ada-lang.c (resolve): Add "parse_completion" parameter.
7331         (resolve_subexp): Likewise.
7332         (ada_resolve_function): Likewise.
7333
7334 2019-04-04  Tom Tromey  <tom@tromey.com>
7335
7336         * parser-defs.h (struct parser_state) <start_arglist,
7337         end_arglist>: New methods.
7338         <arglist_len, m_funcall_chain>: New members.
7339         (arglist_len, start_arglist, end_arglist): Don't declare.
7340         * parse.c (arglist_len, funcall_chain): Remove global.
7341         (start_arglist, end_arglist): Remove functions.
7342         (parse_exp_in_context): Update.
7343         * p-exp.y: Update rules.
7344         * m2-exp.y: Update rules.
7345         * go-exp.y: Update rules.
7346         * f-exp.y: Update rules.
7347         * d-exp.y: Update rules.
7348         * c-exp.y: Update rules.
7349
7350 2019-04-04  Tom Tromey  <tom@tromey.com>
7351
7352         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7353         lex_operator, push_back>: New methods.
7354         Update all rules.
7355         (rust_parser::lex_hex, lex_escape): Rename and update.
7356         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7357         (rust_parser::lex_operator): Rename and update.
7358         (rust_parser::lex_number, rustyylex, rustyyerror)
7359         (rust_lex_test_init, rust_lex_test_sequence)
7360         (rust_lex_test_push_back, rust_lex_tests): Update.
7361         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7362         parameter.
7363         <lexptr, prev_lexptr>: New members.
7364         (lexptr, prev_lexptr): Don't declare.
7365         * parse.c (lexptr, prev_lexptr): Remove globals.
7366         (parse_exp_in_context): Update.
7367         * p-exp.y (yylex, yyerror): Update.
7368         * m2-exp.y (parse_number, yylex, yyerror): Update.
7369         * go-exp.y (lex_one_token, yyerror): Update.
7370         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7371         * d-exp.y (lex_one_token, yyerror): Update.
7372         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7373         (lex_one_token, yyerror): Update.
7374         * ada-lex.l (YY_INPUT): Update.
7375         (rewind_to_char): Update.
7376         * ada-exp.y (yyerror): Update.
7377
7378 2019-04-04  Tom Tromey  <tom@tromey.com>
7379
7380         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7381         * parser-defs.h (struct parser_state) <parser_state>: Add new
7382         parameter.
7383         <comma_terminates>: New member.
7384         (comma_terminates): Don't declare global.
7385         * parse.c (comma_terminates): Remove global.
7386         (parse_exp_in_context): Update.
7387         * p-exp.y (yylex): Update.
7388         * m2-exp.y (yylex): Update.
7389         * go-exp.y (lex_one_token): Update.
7390         * f-exp.y (yylex): Update.
7391         * d-exp.y (lex_one_token): Update.
7392         * c-exp.y (lex_one_token): Update.
7393         * ada-lex.l: Update.
7394
7395 2019-04-04  Tom Tromey  <tom@tromey.com>
7396
7397         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7398         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7399         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7400         * parser-defs.h (paren_depth): Don't declare.
7401         * parse.c (paren_depth): Remove global.
7402         (parse_exp_in_context): Update.
7403         * p-exp.y (paren_depth): New global.
7404         (pascal_parse): Initialize it.
7405         * m2-exp.y (paren_depth): New global.
7406         (m2_parse): Initialize it.
7407         * go-exp.y (paren_depth): New global.
7408         (go_parse): Initialize it.
7409         * f-exp.y (paren_depth): New global.
7410         (f_parse): Initialize it.
7411         * d-exp.y (paren_depth): New global.
7412         (d_parse): Initialize it.
7413         * c-exp.y (paren_depth): New global.
7414         (c_parse): Initialize it.
7415         * ada-lex.l (paren_depth): New global.
7416         (lexer_init): Initialize it.
7417
7418 2019-04-04  Tom Tromey  <tom@tromey.com>
7419
7420         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7421         (rust_parser::convert_ast_to_type)
7422         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7423         * parser-defs.h (struct parser_state) <parser_state>: Add
7424         parameters.  Initialize new members.
7425         <expression_context_block, expression_context_pc>: New members.
7426         * parse.c (expression_context_block, expression_context_pc):
7427         Remove globals.
7428         (parse_exp_in_context): Update.
7429         * p-exp.y: Update all rules.
7430         (yylex): Update.
7431         * m2-exp.y: Update all rules.
7432         (yylex): Update.
7433         * go-exp.y (yylex): Update.
7434         * f-exp.y (yylex): Update.
7435         * d-exp.y: Update all rules.
7436         (yylex): Update.
7437         * c-exp.y: Update all rules.
7438         (lex_one_token, classify_name, yylex, c_parse): Update.
7439         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7440
7441 2019-04-04  Tom Tromey  <tom@tromey.com>
7442
7443         * gdbarch.h, gdbarch.c: Rebuild.
7444         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7445         * stap-probe.h:
7446         (struct stap_parse_info): Replace "parser_state" with
7447         "expr_builder".
7448         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7449         (parser_state): New class.
7450         * parse.c (expr_builder): Rename.
7451         (expr_builder::release): Rename.
7452         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7453         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7454         (write_exp_elt_longcst, write_exp_elt_floatcst)
7455         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7456         (write_exp_string_vector, write_exp_bitstring)
7457         (write_exp_msymbol, mark_struct_expression)
7458         (write_dollar_variable)
7459         (insert_type_address_space, increase_expout_size): Replace
7460         "parser_state" with "expr_builder".
7461         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7462         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7463         "parser_state" with "expr_builder".
7464
7465 2019-04-04  Tom Tromey  <tom@tromey.com>
7466
7467         * rust-exp.y: Replace "parse_language" with method call.
7468         * p-exp.y:
7469         (yylex): Replace "parse_language" with method call.
7470         * m2-exp.y:
7471         (yylex): Replace "parse_language" with method call.
7472         * go-exp.y (classify_name): Replace "parse_language" with method
7473         call.
7474         * f-exp.y (yylex): Replace "parse_language" with method call.
7475         * d-exp.y (lex_one_token): Replace "parse_language" with method
7476         call.
7477         * c-exp.y:
7478         (lex_one_token, classify_name, yylex): Replace "parse_language"
7479         with method call.
7480         * ada-exp.y (find_primitive_type, type_char)
7481         (type_system_address): Replace "parse_language" with method call.
7482
7483 2019-04-04  Tom Tromey  <tom@tromey.com>
7484
7485         * rust-exp.y: Replace "parse_gdbarch" with method call.
7486         * parse.c (write_dollar_variable, insert_type_address_space):
7487         Replace "parse_gdbarch" with method call.
7488         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7489         call.
7490         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7491         call.
7492         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7493         "parse_gdbarch" with method call.
7494         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7495         with method call.
7496         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7497         "parse_gdbarch" with method call.
7498         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7499         "parse_gdbarch" with method call.
7500         * c-exp.y (parse_type, parse_number, classify_name): Replace
7501         "parse_gdbarch" with method call.
7502         * ada-lex.l: Replace "parse_gdbarch" with method call.
7503         * ada-exp.y (parse_type, find_primitive_type, type_char)
7504         (type_system_address): Replace "parse_gdbarch" with method call.
7505
7506 2019-04-04  Tom Tromey  <tom@tromey.com>
7507
7508         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7509         * stap-probe.c (stap_parse_argument): Update.
7510         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7511         initial_size parameter.
7512         * rust-exp.y (rust_lex_tests): Update.
7513         * parse.c (parser_state): Update.
7514         (parse_exp_in_context): Update.
7515         * parser-defs.h (struct parser_state) <parser_state>: Remove
7516         "initial_size" parameter.
7517
7518 2019-04-04  Tom Tromey  <tom@tromey.com>
7519
7520         * parser-defs.h (increase_expout_size): Don't declare.
7521         * parse.c (increase_expout_size): Now static.
7522
7523 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7524
7525         * gnu-nat.c (gnu_nat_target::wait): Fix
7526         target_waitstatus_to_string call.
7527
7528 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * eval.c (evaluate_subexp_standard): Handle internal functions
7531         during Fortran function call handling.
7532
7533 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * NEWS: Mention new internal functions.
7536         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7537         (read_base_type): Use dwarf2_init_complex_target_type.
7538         * value.c (creal_internal_fn): New function.
7539         (cimag_internal_fn): New function.
7540         (_initialize_values): Register new internal functions.
7541
7542 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7543
7544         * infrun.c (stop_all_threads): If debug_infrun, always
7545         trace the wait status after wait_one, using
7546         target_waitstatus_to_string and target_pid_to_str.
7547         (handle_inferior_event): Replace various trace of
7548         wait status kind by a single trace.
7549         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7550         wait status kind image by target_waitstatus_to_string.
7551         * target/waitstatus.c (target_waitstatus_to_string): Fix
7552         obsolete comment.
7553
7554 2019-04-01  Tom Tromey  <tromey@adacore.com>
7555
7556         PR symtab/23331:
7557         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7558
7559 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7560             Pedro Alves  <palves@redhat.com>
7561
7562         * top.c (quit_force): Call 'finalize_values'.
7563         * value.c (finalize_values): New function.
7564         * value.h (finalize_values): Declare.
7565
7566 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7567
7568         * NEWS: Announce $_gdb_major and $_gdb_minor.
7569
7570         * top.c (init_gdb_version_vars): New function.
7571         (gdb_init): Call init_gdb_version_vars.
7572
7573 2019-03-29  Tom Tromey  <tromey@adacore.com>
7574
7575         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7576         help text.  Remove dead code.
7577
7578 2019-03-29  Keith Seitz  <keiths@redhat.com>
7579
7580         From Siddhesh Poyarekar:
7581         * f-lang.h (f77_get_upperbound): Return LONGEST.
7582         (f77_get_lowerbound): Likewise.
7583         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7584         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7585         print them.
7586         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7587         plongest to format print it.
7588         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7589         (f77_get_upperbound): Likewise.
7590         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7591         LOWER_BOUND to LONGEST.
7592         (f77_create_arrayprint_offset_tbl): Likewise.
7593
7594 2019-03-29  Keith Seitz  <keiths@redhat.com>
7595
7596         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7597         %s/pulongest for TYPE_LENGTH instead of %d in format
7598         strings.
7599         * ada-typerint.c (ada_print_type): Likewise.
7600         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7601         * compile/compile-c-support.c (generate_register_struct): Likewise.
7602         * gdbtypes.c (recursive_dump_type): Likewise.
7603         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7604         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7605         instead of %d in format strings.
7606         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7607         to std::min to ULONGEST.
7608         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7609         instead of %d in format strings.
7610         * tracepoint.c (info_scope_command): Likewise.
7611         * typeprint.c (print_offset_data::update)
7612         (print_offset_data::finish): Likewise.
7613         * xtensa-tdep.c (xtensa_store_return_value)
7614         (xtensa_push_dummy_call): Likewise.
7615
7616 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7617
7618         * windows-nat.c (display_selector): Fixed format specifications
7619         for 64-bit Cygwin.
7620
7621 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7622
7623         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7624
7625 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7626
7627         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7628         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7629         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7630         (nios2_linux_init_abi): Install it.
7631
7632 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7633
7634         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7635
7636 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7637
7638         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7639
7640 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7641             Tom Tromey  <tromey@adacore.com>
7642
7643         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7644
7645 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7646
7647         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7648         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7649         method to compute the bounds of range types. Also print "[evaluated]"
7650         if the bounds' values come from a dynamic evaluation.
7651
7652 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7655         whitespace when pretty printing is on.
7656
7657 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7658
7659         * ppc-linux-nat.c: Add include.
7660
7661 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7662
7663         * NEWS: Mention AArch64 Pointer Authentication.
7664
7665 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7666
7667         * arm-linux-nat.c: Add include.
7668
7669 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7670
7671         * source-cache.c (source_cache::get_source_lines): Re-read
7672         fullname after calling open_source_file.
7673
7674 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7675
7676         * NEWS: Mention TLS support for FreeBSD.
7677
7678 2019-03-25  Tom Tromey  <tromey@adacore.com>
7679
7680         * minsyms.c (BUNCH_SIZE): Update comment.
7681         (~minimal_symbol_reader): Remove old comment.
7682         (compact_minimal_symbols): Update comment.
7683         (minimal_symbol_reader::install): Remove old comment.  Update
7684         other comments.
7685
7686 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7687
7688         * s390-linux-nat.c: Add include.
7689
7690 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7691
7692         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7693         Call linux_get_hwcap.
7694         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7695         Likewise.
7696         (aarch64_linux_get_hwcap): Remove function.
7697         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7698         declaration.
7699         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7700         linux_get_hwcap.
7701         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7702         * linux-tdep.c (linux_get_hwcap): Add function.
7703         (linux_get_hwcap2): Likewise.
7704         * linux-tdep.h (linux_get_hwcap): Add declaration.
7705         (linux_get_hwcap2): Likewise.
7706         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7707         (ppc_linux_get_hwcap2): Likewise.
7708         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7709         linux_get_hwcap.
7710         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7711         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7712         (ppc_linux_nat_target::read_description): Likewise.
7713         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7714         * s390-linux-nat.c: Likewise.
7715         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7716
7717 2019-03-24  Tom Tromey  <tom@tromey.com>
7718
7719         * ada-lang.c (standard_lookup): Simplify initialization.
7720         (ada_lookup_symbol_nonlocal): Simplify return.
7721         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7722         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7723         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7724         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7725         initialization.
7726         * solib.c (solib_global_lookup): Simplify.
7727         * symtab.c (null_block_symbol): Remove.
7728         (symbol_cache_lookup): Simplify returns.
7729         (lookup_language_this): Simplify returns.
7730         (lookup_symbol_aux): Simplify return.
7731         (lookup_local_symbol): Simplify returns.
7732         (lookup_global_symbol_from_objfile): Simplify return.
7733         (lookup_symbol_in_objfile_symtabs)
7734         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7735         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7736         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7737         * cp-namespace.c (cp_lookup_bare_symbol)
7738         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7739         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7740         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7741         (cp_lookup_symbol_via_imports): Simplify initialization.
7742         (find_symbol_in_baseclass): Likewise.
7743         * symtab.h (null_block_symbol): Remove.
7744         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7745         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7746         (d_lookup_symbol_module): Likewise.
7747         (find_symbol_in_baseclass): Simplify initialization.
7748
7749 2019-03-24  Tom Tromey  <tom@tromey.com>
7750
7751         * expression.h: Don't include symtab.h.
7752         (struct block): Forward declare.
7753
7754 2019-03-24  Tom Tromey  <tom@tromey.com>
7755
7756         * c-exp.y (typebase): Remove casts.
7757         * gdbtypes.c (lookup_unsigned_typename, )
7758         (lookup_signed_typename): Remove cast.
7759         * eval.c (parse_to_comma_and_eval): Remove cast.
7760         * parse.c (write_dollar_variable): Remove cast.
7761         * block.h (struct block) <superblock>: Now const.
7762         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7763         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7764         (map_block): Make "block" const.
7765         * symfile.h (struct quick_symbol_functions)
7766         <map_matching_symbols>: Constify block argument to "callback".
7767         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7768         const.
7769         (find_pc_sect_compunit_symtab): Make "b" const.
7770         (find_symbol_at_address): Likewise.
7771         (search_symbols): Likewise.
7772         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7773         (dw2_debug_names_lookup_symbol): Likewise.
7774         (dw2_map_matching_symbols): Update.
7775         * p-valprint.c (pascal_val_print): Remove "block".
7776         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7777         (aux_add_nonlocal_symbols): Make "block" const.
7778         (resolve_subexp): Remove cast.
7779         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7780         const.
7781         (iterate_over_file_blocks): Likewise.
7782         * f-exp.y (%union) <bval>: Remove.
7783         * coffread.c (patch_opaque_types): Make "b" const.
7784         * spu-tdep.c (spu_catch_start): Make "block" const.
7785         * c-valprint.c (print_unpacked_pointer): Remove "block".
7786         * symmisc.c (dump_symtab_1): Make "b" const.
7787         (block_depth): Make "block" const.
7788         * d-exp.y (%union) <bval>: Remove.
7789         * cp-support.h (cp_lookup_rtti_type): Update.
7790         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7791         * psymtab.c (psym_lookup_symbol): Make "block" const.
7792         (maintenance_check_psymtabs): Make "b" const.
7793         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7794         (enumerate_locals, enumerate_args): Update.
7795         * python/py-symtab.c (stpy_global_block): Make "block" const.
7796         (stpy_static_block): Likewise.
7797         * inline-frame.c (block_starting_point_at): Make "new_block"
7798         const.
7799         * block.c (find_block_in_blockvector): Make return type const.
7800         (blockvector_for_pc_sect): Make "b" const.
7801         (find_block_in_blockvector): Make "b" const.
7802
7803 2019-03-23  Tom Tromey  <tom@tromey.com>
7804
7805         * varobj.c (varobj_create): Update.
7806         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7807         * printcmd.c (display_command, do_one_display): Don't reset
7808         innermost_block.
7809         * parser-defs.h (enum innermost_block_tracker_type): Move to
7810         expression.h.
7811         (innermost_block): Update comment.
7812         * parse.c (parse_exp_1): Add tracker_types parameter.
7813         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7814         tracker_types parameter.  Reset innermost_block.
7815         (parse_exp_in_context): Remove.
7816         (parse_expression_for_completion): Update.
7817         * objfiles.c (~objfile): Don't reset expression_context_block or
7818         innermost_block.
7819         * expression.h (enum innermost_block_tracker_type): Move from
7820         parser-defs.h.
7821         (parse_exp_1): Add tracker_types parameter.
7822         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7823         reset innermost_block.
7824
7825 2019-03-23  Tom Tromey  <tom@tromey.com>
7826
7827         * objfiles.h: Include bcache.h.
7828
7829 2019-03-23  Tom Tromey  <tom@tromey.com>
7830
7831         * linespec.c (get_current_search_block): Use
7832         scoped_restore_current_language.
7833         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7834
7835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7836             Jiong Wang  <jiong.wang@arm.com>
7837
7838         * aarch64-linux-tdep.c
7839         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7840         section.
7841         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7842
7843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7844             Jiong Wang  <jiong.wang@arm.com>
7845
7846         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7847         instructions.
7848         (aarch64_analyze_prologue_test): Add PACIASP test.
7849         (aarch64_prologue_prev_register): Unmask PC value.
7850
7851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7852             Jiong Wang  <jiong.wang@arm.com>
7853
7854         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7855         (aarch64_dwarf2_prev_register): Unmask PC value.
7856         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7857         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7858         DW_CFA_AARCH64_negate_ra_state.
7859         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7860
7861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7862             Jiong Wang  <jiong.wang@arm.com>
7863
7864         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7865         registers.
7866         (aarch64_pseudo_register_name): Likewise.
7867         (aarch64_pseudo_register_type): Likewise.
7868         (aarch64_pseudo_register_reggroup_p): Likewise.
7869         (aarch64_gdbarch_init): Add pauth registers.
7870         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7871         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7872         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7873         (struct gdbarch_tdep): Add regnum for ra_state.
7874
7875 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7876             Jiong Wang  <jiong.wang@arm.com>
7877
7878         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7879
7880 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7881             Jiong Wang  <jiong.wang@arm.com>
7882
7883         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7884         function.
7885         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7886         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7887         (aarch64_gdbarch_init): Add puth registers.
7888         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7889         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7890         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7891
7892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7893             Jiong Wang  <jiong.wang@arm.com>
7894
7895         * aarch64-linux-nat.c
7896         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7897         * aarch64-linux-tdep.c
7898         (aarch64_linux_core_read_description): Likewise.
7899         (aarch64_linux_get_hwcap): New function.
7900         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7901         (aarch64_linux_get_hwcap): New declaration.
7902
7903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7904             Jiong Wang  <jiong.wang@arm.com>
7905
7906         * aarch64-linux-nat.c
7907         (aarch64_linux_nat_target::read_description): Add pauth param.
7908         * aarch64-linux-tdep.c
7909         (aarch64_linux_core_read_description): Likewise.
7910         * aarch64-tdep.c (struct target_desc): Add in pauth.
7911         (aarch64_read_description): Add pauth param.
7912         (aarch64_gdbarch_init): Likewise.
7913         * aarch64-tdep.h (aarch64_read_description): Likewise.
7914         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7915         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7916         * features/Makefile: Add new files.
7917         * features/aarch64-pauth.c: New file.
7918         * features/aarch64-pauth.xml: New file.
7919
7920 2019-03-20  Tom Tromey  <tromey@adacore.com>
7921
7922         * infrun.c (handle_inferior_event): Rename from
7923         handle_inferior_event_1.  Create a scoped_value_mark.
7924         (handle_inferior_event): Remove.
7925
7926 2019-03-19  Tom Tromey  <tromey@adacore.com>
7927
7928         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7929         * infrun.h (print_stop_event): Add "displays" parameter.
7930         * infrun.c (print_stop_event): Add "displays" parameter.
7931
7932 2019-03-19  Pedro Alves  <palves@redhat.com>
7933
7934         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7935         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7936         to -1.  Fix TABs vs spaces.
7937         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7938         * tui/tui-out.h (tui_ui_out) Add intro comments.
7939         <m_line, m_start_of_line>: In-class initialize, and add describing
7940         comment.
7941
7942 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7943
7944         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7945         variable names.
7946         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7947
7948 2019-03-18  Pedro Alves  <palves@redhat.com>
7949             Eli Zaretskii <eliz@gnu.org>
7950
7951         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7952         m_line and m_start_of_line.
7953
7954 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7955
7956         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7957         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7958         it returns a newline.  This fixes a regression in TU mode, whereby
7959         the next line is output on the same screen line as the user input.
7960
7961 2019-03-18  Tom Tromey  <tromey@adacore.com>
7962
7963         * minsyms.c (minimal_symbol_reader::install): Remove call to
7964         obstack_blank.
7965
7966 2019-03-18  Pedro Alves  <palves@redhat.com>
7967
7968         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7969         New globals.
7970         (apply_style): New, factored out from ...
7971         (apply_ansi_escape): ... this.  Handle reverse video mode.
7972         (tui_set_reverse_mode): New function.
7973         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7974         * tui/tui-winsource.c (tui_show_source_line): Use
7975         tui_set_reverse_mode instead of setting A_STANDOUT.
7976         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7977         New setter methods.
7978
7979 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7980
7981         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7982         Handle tabs.
7983
7984 2019-03-18  Tom Tromey  <tromey@adacore.com>
7985
7986         * ada-lang.c (empty_array): Add "high" parameter.
7987         (ada_evaluate_subexp): Update.
7988
7989 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7990
7991         * unittests/string_view-selftests.c: Define
7992         _initialize_string_view_selftests unconditionally.
7993
7994 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7995
7996         PR gdb/24350
7997         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7998
7999 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8000
8001         PR gdb/24351
8002         * windows-nat.c (display_selector): Fix format specifiers.
8003
8004 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8005
8006         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8007         tui_refill_source_window instead of tui_refresh_win, to update the
8008         current execution line.  This fixes redisplay of the current line
8009         when stepping through the code with "next" or "step".
8010
8011 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8012
8013         * source-cache.c (source_cache::get_source_lines): Call
8014         find_source_lines to initialize s->nlines.  This fixes vertical
8015         scrolling of TUI source window when the DOWN arrow is pressed.
8016
8017 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8018
8019         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8020         linux-thread-db.c (_initialize_thread_db): Likewise.
8021
8022 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8023
8024         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8025         wclrtoeol in tui_show_source_line".  This reverts changes made in
8026         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8027
8028 2019-03-15  Tom Tromey  <tom@tromey.com>
8029
8030         * symtab.h (struct minimal_symbol): Derive from
8031         general_symbol_info.
8032         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8033         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8034         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8035         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8036         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8037         (MSYMBOL_SEARCH_NAME): Update.
8038         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8039         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8040         * minsyms.c (minimal_symbol_reader::record_full): Update.
8041
8042 2019-03-15  Tom Tromey  <tom@tromey.com>
8043
8044         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8045
8046 2019-03-15  Tom Tromey  <tom@tromey.com>
8047
8048         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8049         unique_xmalloc_ptr.
8050         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8051         Update.
8052         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8053         (build_minimal_symbol_hash_tables)
8054         (minimal_symbol_reader::install): Update.
8055
8056 2019-03-15  Tom Tromey  <tom@tromey.com>
8057
8058         * symtab.c (create_demangled_names_hash): Update.
8059         (symbol_set_names): Update.
8060         * objfiles.h (struct objfile_per_bfd_storage)
8061         <demangled_names_hash>: Now an htab_up.
8062         * objfiles.c (objfile_per_bfd_storage): Simplify.
8063
8064 2019-03-15  Tom Tromey  <tom@tromey.com>
8065
8066         * objfiles.h (struct objfile_per_bfd_storage): Declare
8067         destructor.
8068         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8069         New.
8070         (get_objfile_bfd_data): Use new.  Don't initialize
8071         language_of_main.
8072         (free_objfile_per_bfd_storage): Remove.
8073         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8074
8075 2019-03-15  Tom Tromey  <tom@tromey.com>
8076
8077         * symfile.c (reread_symbols): Update.
8078         * objfiles.c (objfile::objfile): Update.
8079         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8080         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8081         comment.
8082         (minimal_symbol_reader::install): Update.
8083         (terminate_minimal_symbol_table): Remove.
8084         * jit.c (jit_object_close_impl): Update.
8085
8086 2019-03-15  Tom Tromey  <tom@tromey.com>
8087
8088         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8089         initializations.
8090
8091 2019-03-15  Tom Tromey  <tom@tromey.com>
8092
8093         * objfiles.h (struct objfile_per_bfd_storage)
8094         <demangled_hash_languages>: Now a bitset.
8095         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8096         (lookup_minimal_symbol): Update.
8097
8098 2019-03-15  Tom Tromey  <tom@tromey.com>
8099
8100         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8101         Don't return the symbol.
8102         * coffread.c (record_minimal_symbol): Use record_full.
8103
8104 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8105
8106         The MS-Windows port of ncurses fails to switch to a color pair if
8107         one or both of the colors are the implicit default colors.  This
8108         change records the default colors when TUI is initialized, and
8109         then specifies them explicitly when a color pair uses the default
8110         colors.  This allows color styling in TUI mode on MS-Windows.
8111
8112         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8113         ncurses_norm_attr.
8114         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8115         colors in ncurses_norm_attr.
8116         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8117         "none", replace it with the default color recorded in
8118         ncurses_norm_attr.
8119
8120 2019-03-14  Tom Tromey  <tromey@adacore.com>
8121
8122         * source-cache.h (class source_cache) <get_source_lines>: Return
8123         std::string.
8124         * source-cache.c (source_cache::extract_lines): Handle case where
8125         first_pos==npos.  Return std::string.
8126         (source_cache::get_source_lines): Update.
8127
8128 2019-03-14  Tom Tromey  <tromey@adacore.com>
8129
8130         * NEWS: Add item for "style sources" commands.
8131         * source-cache.c (source_cache::get_source_lines): Check
8132         source_styling.
8133         * cli/cli-style.c (source_styling): New global.
8134         (_initialize_cli_style): Add "style sources" commands.
8135         (show_style_sources): New function.
8136         * cli/cli-style.h (source_styling): Declare.
8137
8138 2019-03-14  Pedro Alves  <palves@redhat.com>
8139             Tom Tromey  <tromey@adacore.com>
8140
8141         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8142         * tui/tui-winsource.c (tui_refill_source_window): New function,
8143         from...
8144         (tui_horizontal_source_scroll): ... here.  Move some logic.
8145         * cli/cli-style.c (set_style_enabled): Notify new observable.
8146         * tui/tui-hooks.c (tui_redisplay_source): New function.
8147         (tui_attach_detach_observers): Attach or detach
8148         tui_redisplay_source.
8149         * observable.h (source_styling_changed): New observable.
8150         * observable.c: Define source_styling_changed observable.
8151
8152 2019-03-13  Tom Tromey  <tromey@adacore.com>
8153
8154         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8155         (i386_gnu_nat_target::store_registers): Update.
8156         * target-debug.h (target_debug_print_std_string): New macro.
8157         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8158         * windows-tdep.c (display_one_tib): Update.
8159         * tui/tui-stack.c (tui_make_status_line): Update.
8160         * top.c (print_inferior_quit_action): Update.
8161         * thread.c (thr_try_catch_cmd): Update.
8162         (add_thread_with_info): Update.
8163         (thread_target_id_str): Update.
8164         (thr_try_catch_cmd): Update.
8165         (thread_command): Update.
8166         (thread_find_command): Update.
8167         * record-btrace.c (record_btrace_target::info_record)
8168         (record_btrace_resume_thread, record_btrace_target::resume)
8169         (record_btrace_cancel_resume, record_btrace_step_thread)
8170         (record_btrace_target::wait, record_btrace_target::wait)
8171         (record_btrace_target::wait, record_btrace_target::stop): Update.
8172         * progspace.c (print_program_space): Update.
8173         * process-stratum-target.c
8174         (process_stratum_target::thread_address_space): Update.
8175         * linux-fork.c (linux_fork_mourn_inferior)
8176         (detach_checkpoint_command, info_checkpoints_command)
8177         (linux_fork_context): Update.
8178         (linux_fork_detach): Update.
8179         (class scoped_switch_fork_info): Update.
8180         (delete_checkpoint_command): Update.
8181         * infrun.c (follow_fork_inferior): Update.
8182         (follow_fork_inferior): Update.
8183         (proceed_after_vfork_done): Update.
8184         (handle_vfork_child_exec_or_exit): Update.
8185         (follow_exec): Update.
8186         (displaced_step_prepare_throw): Update.
8187         (displaced_step_restore): Update.
8188         (start_step_over): Update.
8189         (resume_1): Update.
8190         (clear_proceed_status_thread): Update.
8191         (proceed): Update.
8192         (print_target_wait_results): Update.
8193         (do_target_wait): Update.
8194         (context_switch): Update.
8195         (stop_all_threads): Update.
8196         (restart_threads): Update.
8197         (finish_step_over): Update.
8198         (handle_signal_stop): Update.
8199         (switch_back_to_stepped_thread): Update.
8200         (keep_going_pass_signal): Update.
8201         (print_exited_reason): Update.
8202         (normal_stop): Update.
8203         * inferior.c (inferior_pid_to_str): Change return type.
8204         (print_selected_inferior): Update.
8205         (add_inferior): Update.
8206         (detach_inferior): Update.
8207         * dummy-frame.c (fprint_dummy_frames): Update.
8208         * dcache.c (dcache_info_1): Update.
8209         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8210         (btrace_fetch, btrace_clear): Update.
8211         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8212         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8213         type.
8214         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8215         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8216         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8217         * gdbarch.c, gdbarch.h: Rebuild.
8218         * gdbarch.sh (core_pid_to_str): Change return type.
8219         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8220         return type.
8221         (windows_nat_target::pid_to_str): Change return type.
8222         (windows_delete_thread): Update.
8223         (windows_nat_target::attach): Update.
8224         (windows_nat_target::files_info): Update.
8225         * target-delegates.c: Rebuild.
8226         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8227         return type.
8228         (sol_thread_target::pid_to_str): Change return type.
8229         * remote.c (class remote_target) <pid_to_str>: Change return
8230         type.
8231         (remote_target::pid_to_str): Change return type.
8232         (extended_remote_target::attach, remote_target::remote_stop_ns)
8233         (remote_target::remote_notif_remove_queued_reply)
8234         (remote_target::push_stop_reply, remote_target::disable_btrace):
8235         Update.
8236         (extended_remote_target::attach): Update.
8237         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8238         type.
8239         (gdbsim_target::pid_to_str): Change return type.
8240         * ravenscar-thread.c (struct ravenscar_thread_target)
8241         <pid_to_str>: Change return type.
8242         (ravenscar_thread_target::pid_to_str): Change return type.
8243         * procfs.c (class procfs_target) <pid_to_str>: Change return
8244         type.
8245         (procfs_target::pid_to_str): Change return type.
8246         (procfs_target::attach): Update.
8247         (procfs_target::detach): Update.
8248         (procfs_target::fetch_registers): Update.
8249         (procfs_target::store_registers): Update.
8250         (procfs_target::wait): Update.
8251         (procfs_target::files_info): Update.
8252         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8253         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8254         return type.
8255         (nto_procfs_target::pid_to_str): Change return type.
8256         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8257         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8258         return type.
8259         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8260         (exit_lwp): Update.
8261         (attach_proc_task_lwp_callback, get_detach_signal)
8262         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8263         (linux_nat_target::resume, wait_lwp, stop_callback)
8264         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8265         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8266         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8267         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8268         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8269         type.
8270         (inf_ptrace_target::attach): Update.
8271         (inf_ptrace_target::files_info): Update.
8272         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8273         type.
8274         (go32_nat_target::pid_to_str): Change return type.
8275         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8276         (gnu_nat_target::wait): Update.
8277         (gnu_nat_target::wait): Update.
8278         (gnu_nat_target::resume): Update.
8279         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8280         (fbsd_nat_target::wait): Update.
8281         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8282         type.
8283         (darwin_nat_target::attach): Update.
8284         * corelow.c (class core_target) <pid_to_str>: Change return type.
8285         (core_target::pid_to_str): Change return type.
8286         * target.c (normal_pid_to_str): Change return type.
8287         (default_pid_to_str): Likewise.
8288         (target_pid_to_str): Change return type.
8289         (target_translate_tls_address): Update.
8290         (target_announce_detach): Update.
8291         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8292         return type.
8293         (bsd_uthread_target::pid_to_str): Change return type.
8294         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8295         type.
8296         (bsd_kvm_target::pid_to_str): Change return type.
8297         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8298         return type.
8299         (aix_thread_target::pid_to_str): Change return type.
8300         * target.h (struct target_ops) <pid_to_str>: Change return type.
8301         (target_pid_to_str, normal_pid_to_str): Likewise.
8302         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8303         type.
8304         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8305         type.
8306         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8307         return type.
8308         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8309         type.
8310         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8311         type.
8312         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8313         return type.
8314
8315 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8316
8317         * NEWS: Mention that the new default MI version is 3.  Mention
8318         changes to the output of commands and events that deal with
8319         multi-location breakpoints.
8320         * breakpoint.c: Include "mi/mi-out.h".
8321         (print_one_breakpoint): Change output syntax if using MI version
8322         >= 3.
8323         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8324         New.
8325         (mi_multi_location_breakpoint_output_fixed): New.
8326         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8327         (mi_cmd_fix_multi_location_breakpoint_output): New.
8328         (mi_multi_location_breakpoint_output_fixed): New.
8329         * mi/mi-cmds.c (mi_cmds): Register command
8330         -fix-multi-location-breakpoint-output.
8331         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8332         interpreter "mi".
8333
8334 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8335
8336         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8337         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8338         instantiate mi_ui_out based on interpreter name.
8339         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8340         * mi/mi-main.c (mi_load_progress): Likewise.
8341
8342 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8343
8344         * NEWS: Combine separate "New targets" sections for 8.3.
8345
8346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8347
8348         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8349         (ppcfbsd_init_abi): Install gdbarch
8350         "fetch_tls_load_module_address" and "get_thread_local_address"
8351         methods.
8352
8353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8354
8355         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8356         (riscv_fbsd_init_abi): Install gdbarch
8357         "fetch_tls_load_module_address" and "get_thread_local_address"
8358         methods.
8359
8360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8361
8362         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8363         (i386fbsd_init_abi): Install gdbarch
8364         "fetch_tls_load_module_address" and "get_thread_local_address"
8365         methods.
8366
8367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8368
8369         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8370         (amd64fbsd_init_abi): Install gdbarch
8371         "fetch_tls_load_module_address" and "get_thread_local_address"
8372         methods.
8373
8374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8375
8376         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8377         (struct fbsd_pspace_data): New type.
8378         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8379         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8380         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8381         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8382         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8383
8384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8385
8386         * gdbtypes.c (lookup_struct_elt): New function.
8387         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8388         * gdbtypes.h (struct struct_elt): New type.
8389         (lookup_struct_elt): New prototype.
8390
8391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8392
8393         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8394         remove disabled code block.
8395
8396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8397
8398         * gdbarch.sh (get_thread_local_address): New method.
8399         * gdbarch.h, gdbarch.c: Regenerate.
8400         * target.c (target_translate_tls_address): Use
8401         gdbarch_get_thread_local_address if present instead of
8402         target::get_thread_local_address.
8403
8404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8405
8406         * target.h (target::get_thread_local_address): Update comment.
8407
8408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8409
8410         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8411         objfile->separate_debug_objfile_backlink if not NULL.
8412
8413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8414
8415         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8416         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8417         (amd64bsd_store_inferior_registers): Likewise.
8418         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8419         Enable segment base registers.
8420         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8421         PT_GETFSBASE and PT_GETGSBASE.
8422         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8423         PT_SETGSBASE.
8424         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8425         segment base registers.
8426         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8427
8428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8429
8430         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8431         Update calls to i386_target_description to add 'segments'
8432         parameter.
8433         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8434         add segment base registers.
8435         * arch/i386.c (i386_create_target_description): Add 'segments'
8436         parameter to enable segment base registers.
8437         * arch/i386.h (i386_create_target_description): Likewise.
8438         * features/i386/32bit-segments.xml: New file.
8439         * features/i386/32bit-segments.c: Generate.
8440         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8441         call to i386_target_description to add 'segments' parameter.
8442         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8443         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8444         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8445         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8446         if feature is present.
8447         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8448         Add 'segments' parameter to call to i386_target_description.
8449         (i386_target_description): Add 'segments' parameter to enable
8450         segment base registers.
8451         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8452         to call to i386_target_description.
8453         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8454         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8455         Define I386_NUM_REGS.
8456         (i386_target_description): Add 'segments' parameter to enable
8457         segment base registers.
8458
8459 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8460
8461         PR/24325
8462         * source-cache.c: #undef open and close, to avoid unresolved
8463         externals during linking.
8464
8465 2019-03-12  Tom Tromey  <tromey@adacore.com>
8466
8467         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8468         const.  Add initializers.
8469         (_initialize_remote): Don't initialize ptid globals.
8470
8471 2019-03-12  Pedro Alves  <palves@redhat.com>
8472
8473         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8474
8475 2019-03-12  Pedro Alves  <palves@redhat.com>
8476
8477         * cp-name-parser.y (main): Remove unused 'len' variable.
8478
8479 2019-03-12  Tom Tromey  <tromey@adacore.com>
8480
8481         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8482         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8483
8484 2019-03-12  Tom Tromey  <tromey@adacore.com>
8485
8486         * linux-nat.c (iterate_over_lwps): Update.
8487         (stop_callback): Remove parameter.
8488         (stop_wait_callback, detach_callback, resume_set_callback)
8489         (select_singlestep_lwp_callback, set_ignore_sigint)
8490         (status_callback, resumed_callback, resume_clear_callback)
8491         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8492         data parameter.
8493         (linux_nat_target::detach, linux_nat_target::resume)
8494         (linux_stop_and_wait_all_lwps, select_event_lwp)
8495         (linux_nat_filter_event, linux_nat_wait_1)
8496         (linux_nat_target::kill, linux_nat_target::stop)
8497         (linux_nat_target::stop): Update.
8498         (linux_nat_resume_callback): Change type.
8499         (resume_stopped_resumed_lwps, count_events_callback)
8500         (select_event_lwp_callback): Likewise.
8501         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8502         * arm-linux-nat.c (struct update_registers_data): Remove.
8503         (update_registers_callback): Change type.
8504         (arm_linux_insert_hw_breakpoint1): Update.
8505         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8506         parameter.
8507         (x86_linux_dr_set_addr): Update.
8508         (x86_linux_dr_set_control): Update.
8509         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8510         (iterate_over_lwps): Use gdb::function_view.
8511         * nat/aarch64-linux-hw-point.c (struct
8512         aarch64_dr_update_callback_param): Remove.
8513         (debug_reg_change_callback): Change type.
8514         (aarch64_notify_debug_reg_change): Update.
8515         * s390-linux-nat.c (s390_refresh_per_info): Update.
8516
8517 2019-03-11  Tom Tromey  <tromey@adacore.com>
8518
8519         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8520         redundant assignment to "this_cu".
8521
8522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8523
8524         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8525
8526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8527
8528         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8529         from...
8530         (rank_one_type): ... this.
8531
8532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8533
8534         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8535         from...
8536         (rank_one_type): ... this.
8537
8538 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8539
8540         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8541         from...
8542         (rank_one_type): ... this.
8543
8544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8545
8546         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8547         from...
8548         (rank_one_type): ... this.
8549
8550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8551
8552         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8553         from...
8554         (rank_one_type): ... this.
8555
8556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8557
8558         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8559         from...
8560         (rank_one_type): ... this.
8561
8562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8563
8564         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8565         from...
8566         (rank_one_type): ... this.
8567
8568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8569
8570         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8571         from...
8572         (rank_one_type): ... this.
8573
8574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8575
8576         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8577         from...
8578         (rank_one_type): ... this.
8579
8580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8581
8582         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8583         from...
8584         (rank_one_type): ... this.
8585
8586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8587
8588         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8589         from...
8590         (rank_one_type): ... this.
8591
8592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8593
8594         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8595         from...
8596         (rank_one_type): ... this.
8597
8598 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8599
8600         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8601         inferior-events' shows the example events.
8602
8603 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8604
8605         Support styling on native MS-Windows console
8606
8607         PR/24315
8608         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8609         on MS-Windows if $TERM is not defined.
8610
8611         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8612
8613         * posix-hdep.c (gdb_console_fputs):
8614         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8615         functions.
8616         * ui-file.h (gdb_console_fputs): Add prototype.
8617
8618         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8619         back to fputs only if the former returns zero.
8620
8621 2019-03-07  Tom Tromey  <tom@tromey.com>
8622
8623         * symmisc.c (print_symbol_bcache_statistics): Update.
8624         (print_objfile_statistics): Update.
8625         * symfile.c (allocate_symtab): Update.
8626         * stabsread.c: Don't include bcache.h.
8627         * psymtab.h (struct psymbol_bcache): Don't declare.
8628         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8629         (psymbol_bcache_init, psymbol_bcache_free)
8630         (psymbol_bcache_get_bcache): Don't declare.
8631         * psymtab.c (struct psymbol_bcache): Remove.
8632         (psymtab_storage::psymtab_storage): Update.
8633         (psymtab_storage::~psymtab_storage): Update.
8634         (psymbol_bcache_init, psymbol_bcache_free)
8635         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8636         (add_psymbol_to_bcache): Update.
8637         (allocate_psymtab): Update.
8638         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8639         macro_cache>: No longer pointers.
8640         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8641         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8642         * macrotab.c (macro_bcache): Update.
8643         * macroexp.c: Don't include bcache.h.
8644         * gdbtypes.c (check_types_worklist): Update.
8645         (types_deeply_equal): Remove TRY/CATCH.  Update.
8646         * elfread.c (elf_symtab_read): Update.
8647         * dwarf2read.c: Don't include bcache.h.
8648         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8649         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8650         (print_bcache_statistics, bcache_memory_used): Don't declare.
8651         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8652         methods.  Rename all data members.
8653         * bcache.c (struct bcache): Move to bcache.h.
8654         (bcache::expand_hash_table): Rename from expand_hash_table.
8655         (bcache): Remove.
8656         (bcache::insert): Rename from bcache_full.
8657         (bcache::compare): Rename from bcache_compare.
8658         (bcache_xmalloc): Remove.
8659         (bcache::~bcache): Rename from bcache_xfree.
8660         (bcache::print_statistics): Rename from print_bcache_statistics.
8661         (bcache::memory_used): Rename from bcache_memory_used.
8662
8663 2019-03-07  Pedro Alves  <palves@redhat.com>
8664
8665         * infrun.c (normal_stop): Also check for
8666         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8667
8668 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8669
8670         * f-lang.c (value_from_host_double): Moved to...
8671         * value.c (value_from_host_double): ...here.
8672         * value.h (value_from_host_double): Declare.
8673         * guile/scm-math.c (vlscm_convert_typed_number): Use
8674         value_from_host_double.
8675         (vlscm_convert_number): Likewise.
8676         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8677         * python/py-value.c (convert_value_from_python): Likewise.
8678
8679 2019-03-06  Tom Tromey  <tom@tromey.com>
8680
8681         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8682
8683 2019-03-06  Tom Tromey  <tom@tromey.com>
8684
8685         * utils.h (free_current_contents): Don't declare.
8686         * utils.c (free_current_contents): Remove.
8687
8688 2019-03-06  Tom Tromey  <tom@tromey.com>
8689
8690         * top.c (quit_force): Update.
8691         * main.c (captured_command_loop): Update.
8692         * common/new-op.c (operator new): Update.
8693         * common/common-exceptions.c (struct catcher)
8694         <save_cleanup_chain>: Remove member.
8695         (exceptions_state_mc_init): Update.
8696         (exception_try_scope_entry): Return nullptr.
8697         (exception_try_scope_exit, exception_rethrow)
8698         (throw_exception_sjlj, throw_exception_cxx): Update.
8699         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8700         (all_cleanups, do_cleanups, discard_cleanups)
8701         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8702         (restore_cleanups, restore_final_cleanups): Don't declare.
8703         (do_final_cleanups): Remove parameter.
8704         * common/cleanups.c (cleanup_chain, make_cleanup)
8705         (make_cleanup_dtor, all_cleanups, do_cleanups)
8706         (discard_my_cleanups, discard_cleanups)
8707         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8708         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8709         (null_cleanup): Remove.
8710         (do_final_cleanups): Remove parameter.
8711
8712 2019-03-06  Tom Tromey  <tom@tromey.com>
8713
8714         * remote.c (remote_target::remote_parse_stop_reply): Use
8715         unique_xmalloc_ptr.
8716
8717 2019-03-06  Tom Tromey  <tom@tromey.com>
8718
8719         * stabsread.c (struct stabs_field_info): Rename from field_info.
8720         <list, fnlist>: Add initializers.
8721         <obstack>: New member.
8722         (read_member_functions, read_struct_fields, read_baseclasses):
8723         Allocate on obstack.  Don't use cleanups.
8724         (read_one_struct_field, read_member_functions, read_struct_fields)
8725         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8726         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8727         (read_struct_type): Update.
8728
8729 2019-03-06  Tom Tromey  <tom@tromey.com>
8730
8731         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8732         * common/filestuff.h (make_cleanup_close): Don't declare.
8733         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8734         Remove.
8735
8736 2019-03-06  Tom Tromey  <tom@tromey.com>
8737
8738         * solib-aix.c: Use make_scope_exit.
8739
8740 2019-03-06  Tom Tromey  <tom@tromey.com>
8741
8742         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8743         Use make_scope_exit.
8744
8745 2019-03-06  Tom Tromey  <tom@tromey.com>
8746
8747         * solib-svr4.c (disable_probes_interface): Remove parameter.
8748         (svr4_handle_solib_event): Use make_scope_exit.
8749
8750 2019-03-06  Tom Tromey  <tom@tromey.com>
8751
8752         * remote.c (struct stop_reply_deleter): Remove.
8753         (stop_reply_up): Update.
8754         (struct stop_reply): Derive from notif_event.  Don't typedef.
8755         <regcache>: Now a std::vector.
8756         (stop_reply_xfree): Remove.
8757         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8758         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8759         (remote_target::discard_pending_stop_replies): Use delete.
8760         (remote_target::remote_parse_stop_reply): Update.
8761         (remote_target::process_stop_reply): Update.
8762         * remote-notif.h (struct notif_event): Add virtual destructor.
8763         Remove "dtr" member.
8764         (struct notif_client) <alloc_event>: Return a unique_ptr.
8765         (notif_event_xfree): Don't declare.
8766         (notif_event_up): New typedef.
8767         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8768         (notif_event_xfree, do_notif_event_xfree): Remove.
8769         (remote_notif_state_xfree): Update.
8770
8771 2019-03-06  Tom Tromey  <tom@tromey.com>
8772
8773         * infrun.c (displaced_step_clear_cleanup): Now a
8774         forward_scope_exit type.
8775         (displaced_step_prepare_throw): Update.
8776         (displaced_step_fixup): Update.
8777
8778 2019-03-06  Tom Tromey  <tom@tromey.com>
8779
8780         * inferior.h (class inferior): Update comment.
8781         * gdbthread.h (class thread_info): Update comment.
8782
8783 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8784             Tom Tromey  <tom@tromey.com>
8785
8786         * stabsread.h (struct stab_section_list): Remove.
8787         (coffstab_build_psymtabs): Update.
8788         * dbxread.c (symbuf_sections): Now a std::vector.
8789         (sect_idx): New global.
8790         (fill_symbuf): Update.
8791         (coffstab_build_psymtabs): Change type of stabsects parameter.
8792         Update.
8793         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8794         std::vector.
8795         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8796         (coff_locate_sections): Update.
8797         (coff_symfile_read): Remove cleanups.  Update.
8798         (init_stringtab): Add storage parameter.
8799         (free_stringtab, free_stringtab_cleanup): Remove.
8800         (init_lineno): Add storage parameter.
8801         (free_linetab, free_linetab_cleanup): Remove.
8802
8803 2019-03-06  Pedro Alves  <palves@redhat.com>
8804
8805         * linux-fork.c (fork_info::clobber_regs): Delete.
8806         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8807         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8808         comment.  Adjust.
8809         (scoped_switch_fork_info::scoped_switch_fork_info)
8810         (checkpoint_command, linux_fork_context): Adjust
8811         fork_save_infrun_state calls.
8812
8813 2019-03-06  Pedro Alves  <palves@redhat.com>
8814
8815         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8816         (inf_has_multiple_threads): Return 'bool' and rewrite using
8817         inferior_info::threads().
8818
8819 2019-03-06  Pedro Alves  <palves@redhat.com>
8820
8821         * linux-fork.c: Include <list>.
8822         (fork_list): Now a std::list instance.
8823         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8824         (forks_exist_p, find_last_fork): Adjust.
8825         (new_fork): Delete.
8826         (one_fork_p): New.
8827         (add_fork): Adjust.
8828         (free_fork): Delete, folded into fork_info::~fork_info().
8829         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8830         Adjust.
8831         (init_fork_list): Delete.
8832         (linux_fork_killall, linux_fork_mourn_inferior)
8833         (linux_fork_detach, info_checkpoints_command): Adjust.
8834         (_initialize_linux_fork): No longer call init_fork_list.
8835
8836 2019-03-06  Pedro Alves  <palves@redhat.com>
8837
8838         * linux-fork.c (new_fork): New, split out of ...
8839         (add_fork): ... this.  Return void.  Move "first fork" special
8840         case from here, to ...
8841         (checkpoint_command): ... here.
8842         * linux-linux.h (add_fork): Return void.
8843
8844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8845
8846         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8847
8848 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8849             Chris January  <chris.january@arm.com>
8850             David Lecomber  <david.lecomber@arm.com>
8851
8852         * f-exp.y: New token, UNOP_INTRINSIC.
8853         (exp): New pattern using UNOP_INTRINSIC token.
8854         (f77_keywords): Add 'abs' keyword.
8855         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8856         (value_from_host_double): New function.
8857         (evaluate_subexp_f): Support UNOP_ABS.
8858
8859 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8862         types.
8863
8864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8867         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8868         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8869
8870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8871
8872         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8873
8874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8875             Chris January  <chris.january@arm.com>
8876
8877         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8878         * f-exp.y: Define 'KIND' token.
8879         (exp): New pattern for KIND expressions.
8880         (ptype): Handle types with a kind extension.
8881         (direct_abs_decl): Extend to spot kind extensions.
8882         (f77_keywords): Add 'kind' to the list.
8883         (push_kind_type): New function.
8884         (convert_to_kind_type): New function.
8885         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8886         * parse.c (operator_length_standard): Likewise.
8887         * parser-defs.h (enum type_pieces): Add tp_kind.
8888         * std-operator.def: Add UNOP_KIND.
8889
8890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * f-exp.y (f_parse): Set yydebug.
8893
8894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * f-lang.c (evaluate_subexp_f): New function.
8897         (exp_descriptor_f): New global.
8898         (f_language_defn): Use exp_descriptor_f instead of
8899         exp_descriptor_standard.
8900
8901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * f-exp.y (struct token): Add comments.
8904         (dot_ops): Remove uppercase versions and the end marker.
8905         (f77_keywords): Likewise.
8906         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8907         entries in the dot_ops array are case insensitive, and use
8908         strncasecmp to compare strings.  Also some whitespace cleanup in
8909         this area.  Similar for the f77_keywords array, except entries in
8910         this list might be case sensitive.
8911
8912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * f-exp.y (struct f77_boolean_val): Add comments.
8915         (boolean_values): Remove uppercase versions, and end marker.
8916         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8917         and use strncasecmp to achieve case insensitivity.  Additionally,
8918         perform whitespace cleanup around this code.
8919
8920 2019-03-06  Tom Tromey  <tromey@adacore.com>
8921
8922         * remote-sim.c (gdbsim_target_open): Use result of
8923         gdb_argv::release.
8924
8925 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8926         Dirk Schubert  <dirk.schubert@arm.com>
8927         Chris January  <chris.january@arm.com>
8928
8929         * eval.c (evaluate_subexp_standard): Call Fortran argument
8930         wrapping logic.
8931         * f-lang.c (struct value): A value which can be passed into a
8932         Fortran function call.
8933         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8934         where appropriate.
8935         (struct type): Value ready for a Fortran function call.
8936         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8937         is needed.
8938         * f-lang.h (fortran_argument_convert): Declaration.
8939         (fortran_preserve_arg_pointer): Declaration.
8940         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8941
8942 2019-03-05  Tom Tromey  <tromey@adacore.com>
8943
8944         * python/py-prettyprint.c (print_string_repr): Remove #if.
8945         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8946
8947 2019-03-05  Tom Tromey  <tromey@adacore.com>
8948
8949         * target.c (the_dummy_target): Move later.  Change type to
8950         "dummy_target".
8951         (initialize_targets): Don't initialize the_dummy_target.
8952
8953 2019-03-05  Tom Tromey  <tromey@adacore.com>
8954
8955         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8956         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8957
8958 2019-03-05  Tom Tromey  <tromey@adacore.com>
8959
8960         * windows-nat.c (windows_nat_target::attach)
8961         (windows_nat_target::detach): Don't call gdb_flush.
8962         * valprint.c (generic_val_print, val_print, val_print_string):
8963         Don't call gdb_flush.
8964         * utils.c (defaulted_query): Don't call gdb_flush.
8965         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8966         * target.c (target_announce_detach): Don't call gdb_flush.
8967         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8968         * remote.c (extended_remote_target::attach): Don't call
8969         gdb_flush.
8970         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8971         * printcmd.c (do_examine): Don't call gdb_flush.
8972         (info_display_command): Don't call gdb_flush.
8973         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8974         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8975         * memattr.c (info_mem_command): Don't call gdb_flush.
8976         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8977         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8978         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8979         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8980         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8981         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8982         (gnu_nat_target::detach): Don't call gdb_flush.
8983         * f-valprint.c (f_val_print): Don't call gdb_flush.
8984         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8985         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8986         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8987         gdb_flush.
8988         * c-valprint.c (c_val_print): Don't call gdb_flush.
8989         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8990
8991 2019-03-05  Tom Tromey  <tromey@adacore.com>
8992
8993         * varobj.c (update_dynamic_varobj_children): Update.
8994         (install_default_visualizer): Use reset, not release.
8995         * value.c (set_internalvar): Update.
8996         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8997         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8998         ATTRIBUTE_UNUSED_RESULT.
8999
9000 2019-03-05  Tom Tromey  <tromey@adacore.com>
9001
9002         * remote.c (class scoped_remote_fd) <release>: Add
9003         ATTRIBUTE_UNUSED_RESULT.
9004
9005 2019-03-05  Tom Tromey  <tromey@adacore.com>
9006
9007         * macroexp.c (struct macro_buffer) <release>: Add
9008         ATTRIBUTE_UNUSED_RESULT.
9009
9010 2019-03-05  Tom Tromey  <tromey@adacore.com>
9011
9012         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9013         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9014         ATTRIBUTE_UNUSED_RESULT.
9015
9016 2019-03-05  Tom Tromey  <tromey@adacore.com>
9017
9018         * common/scoped_fd.h (class scoped_fd) <release>: Add
9019         ATTRIBUTE_UNUSED_RESULT.
9020
9021 2019-03-05  Tom Tromey  <tromey@adacore.com>
9022
9023         * parser-defs.h (struct parser_state) <release>: Add
9024         ATTRIBUTE_UNUSED_RESULT.
9025
9026 2019-03-05  Tom Tromey  <tromey@adacore.com>
9027
9028         * utils.h (class gdb_argv) <release>: Add
9029         ATTRIBUTE_UNUSED_RESULT.
9030         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9031
9032 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9033
9034         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9035         for-loop range, to avoid compiler warnings.
9036
9037         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9038         avoid compiler warnings about unused variables.
9039
9040         * NEWS: Mention end of support for native debugging on MS-Windows
9041         before XP.
9042
9043         PR gdb/24292
9044         * common/netstuff.c:
9045         * gdbserver/gdbreplay.c
9046         * gdbserver/remote-utils.c:
9047         * ser-tcp.c:
9048         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9049         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9050         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9051         'getaddrinfo' and 'freeaddrinfo' were not available before
9052         Windows XP, and mingw.org's MinGW headers by default define
9053         _WIN32_WINNT to 0x500.
9054
9055 2019-03-01  Gary Benson <gbenson@redhat.com>
9056
9057         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9058
9059 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9060             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9061
9062         PR gdb/8527
9063         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9064         set_sigint_trap, clear_sigint_trap.
9065
9066 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9067
9068         * target.c (target_detach): Clear the regcache and the
9069         frame cache.
9070
9071 2019-02-27  Pedro Alves  <palves@redhat.com>
9072
9073         * utils.c (set_screen_size): When we cap the height/width sizes,
9074         tweak the corresponding command variable to show "unlimited":
9075
9076 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9077             Pedro Alves  <palves@redhat.com>
9078
9079         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9080         before calling rl_set_screen_size.
9081
9082 2019-02-27  Tom Tromey  <tromey@adacore.com>
9083
9084         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9085         define.
9086         * python/py-value.c: Remove Python 2.4 workaround.
9087         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9088         workaround.
9089         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9090         Python 2.4 workaround.
9091         * python/python-internal.h: Remove Python 2.4 comment.
9092         (Py_ssize_t): Don't define.
9093         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9094         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9095         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9096         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9097         * python/python.c (do_start_initialization): Remove Python 2.4
9098         workaround.
9099         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9100         (print_children): Remove Python 2.4 workaround.
9101         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9102         workaround.
9103         (CHARBUFFERPROC_NAME): Remove.
9104         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9105         Python 2.4 workaround.
9106
9107 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9108
9109         * NEWS: Note minimum Python version.
9110
9111 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9112
9113         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9114         code from these functions.  Remove corresponding ifdefs.  Use
9115         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9116         Remove gotos and target of gotos.
9117         (infpy_search_memory): Likewise.
9118
9119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9120
9121         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9122         (hppa_gdbarch_init): Don't register deleted functions with
9123         gdbarch.
9124
9125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9126
9127         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9128         (h8300_unwind_sp): Delete.
9129         (h8300_dummy_id): Delete.
9130         (h8300_gdbarch_init): Don't register deleted functions with
9131         gdbarch.
9132
9133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9134
9135         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9136         (ft32_unwind_pc): Delete.
9137         (ft32_unwind_sp): Delete.
9138         (ft32_gdbarch_init): Don't register deleted functions with
9139         gdbarch.
9140
9141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9142
9143         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9144         (frv_unwind_pc): Delete.
9145         (frv_unwind_sp): Delete.
9146         (frv_gdbarch_init): Don't register deleted functions with
9147         gdbarch.
9148
9149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9150
9151         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9152         (riscv_unwind_pc): Delete.
9153         (riscv_unwind_sp): Delete.
9154         (riscv_gdbarch_init): Don't register deleted functions with
9155         gdbarch.
9156
9157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9158
9159         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9160         (csky_unwind_pc): Delete.
9161         (csky_unwind_sp): Delete.
9162         (csky_gdbarch_init): Don't register deleted functions with
9163         gdbarch.
9164
9165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9166
9167         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9168         (cris_unwind_pc): Delete.
9169         (cris_unwind_sp): Delete.
9170         (cris_gdbarch_init): Don't register deleted functions with
9171         gdbarch.
9172
9173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9174
9175         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9176         (bfin_unwind_pc): Delete.
9177         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9178
9179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9182         (arm_unwind_pc): Delete.
9183         (arm_unwind_sp): Delete.
9184         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9185
9186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9187
9188         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9189         (arc_unwind_pc): Delete.
9190         (arc_unwind_sp): Delete.
9191         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9192
9193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9196         (alpha_unwind_pc): Delete.
9197         (alpha_gdbarch_init): Don't register deleted functions with
9198         gdbarch.
9199
9200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9203         (aarch64_unwind_pc): Delete.
9204         (aarch64_unwind_sp): Delete.
9205         (aarch64_gdbarch_init): Don't register deleted functions with
9206         gdbarch.
9207
9208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * gdbtypes.c (type_align): Don't consider static members when
9211         computing structure alignment.
9212
9213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9216         return 0 for other types.
9217         * arch-utils.c (default_type_align): Always return 0.
9218         * gdbarch.h: Regenerate.
9219         * gdbarch.sh (type_align): Extend comment.
9220         * gdbtypes.c (type_align): Add additional comments, always call
9221         gdbarch_type_align before applying the default rules.
9222         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9223         generic code will then apply a suitable default.
9224         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9225         types, return 0 for other types.
9226
9227 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9228
9229         * NEWS: Create a new section for the next release branch.
9230         Rename the section of the current branch, now that it has
9231         been cut.
9232
9233 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9234
9235         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9236         * version.in: Bump version to 8.3.50.DATE-git.
9237
9238 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9239
9240         * aix-thread.c (ptid_cmp): Remove unused variable.
9241         (get_signaled_thread): Likewise.
9242         (store_regs_user_thread): Likewise.
9243         (store_regs_kernel_thread): Likewise.
9244         (fetch_regs_kernel_thread): Remove shadowed variable.
9245
9246 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * features/riscv/32bit-cpu.xml: Add register numbers.
9249         * features/riscv/32bit-fpu.c: Regenerate.
9250         * features/riscv/32bit-fpu.xml: Add register numbers.
9251         * features/riscv/64bit-cpu.xml: Add register numbers.
9252         * features/riscv/64bit-fpu.c: Regenerate.
9253         * features/riscv/64bit-fpu.xml: Add register numbers.
9254
9255 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9256
9257         * NEWS: Mention two argument form of gdb.Value constructor.
9258         * python/py-value.c (convert_buffer_and_type_to_value): New
9259         function.
9260         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9261         Add support for handling an optional second argument.  Call
9262         convert_buffer_and_type_to_value as appropriate.
9263         * python/python-internal.h (Py_buffer_deleter): New struct.
9264         (Py_buffer_up): New typedef.
9265
9266 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9267
9268         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9269         instead of releasing ownership.
9270
9271 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9272
9273         * dwarf2read.c (open_and_init_dwp_file): Call
9274         elf_numsections instead of bfd_count_sections to initialize
9275         dwp_file->num_sections.
9276
9277 2019-02-25  Tom Tromey  <tromey@adacore.com>
9278
9279         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9280
9281 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9282
9283         * gcore.in: Add '--readnever' option when invoking GDB.
9284
9285 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9286
9287         * MAINTAINERS: Update my email address.
9288
9289 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9290
9291         * build-id.c (build_id_to_debug_bfd_1): New function.
9292         (build_id_to_debug_bfd): Look for separate debug file in
9293         sysroot.
9294
9295 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9296
9297         * gdbarch.sh: Update the copyright year range that is placed into
9298         generated files.
9299
9300 2019-02-22  Keith Seitz  <keiths@redhat.com>
9301
9302         PR symtab/23853
9303         * linespec.c (create_sals_line_offset): Search for the default
9304         symtab's filename instead of its fullname.
9305
9306 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9307
9308         * NEWS: Update style defaults.
9309
9310 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9311
9312         * main.c (captured_main_1): Disable styling in batch mode.
9313
9314 2019-02-20  Tom Tromey  <tom@tromey.com>
9315
9316         * symtab.c (symtab_symbol_info): Fix typos.
9317
9318 2019-02-20  Tom Tromey  <tromey@adacore.com>
9319
9320         * findcmd.c (_initialize_mem_search): Use upper case for
9321         metasyntactic variables.
9322
9323 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9324
9325         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9326         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9327
9328 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9329
9330         * top.h (source_file_name): Change to std::string.
9331         * top.c (source_file_name): Likewise.
9332         (command_line_input): Adjust.
9333         * cli/cli-script.c (script_from_file): Adjust.
9334
9335 2019-02-19  Tom Tromey  <tromey@adacore.com>
9336
9337         * ravenscar-thread.c
9338         (ravenscar_thread_target::update_thread_list): Don't call
9339         ada_build_task_list.
9340         * ada-lang.h (ada_build_task_list): Don't declare.
9341         * ada-tasks.c (struct ada_tasks_inferior_data)
9342         <task_list_valid_p>: Now bool.
9343         (read_known_tasks, ada_task_list_changed)
9344         (ada_tasks_invalidate_inferior_data): Update.
9345         (read_known_tasks_array): Return bool.
9346         (read_known_tasks_list): Likewise.
9347         (read_known_tasks): Return void.
9348         (ada_build_task_list): Now static.
9349
9350 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9353         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9354
9355 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9356
9357         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9358         variant for ada_tasks_pspace_data_handle and
9359         ada_tasks_inferior_data_handle.
9360         (ada_tasks_pspace_data_cleanup): New function.
9361         (ada_tasks_inferior_data_cleanup): New function.
9362
9363 2019-02-17  Tom Tromey  <tom@tromey.com>
9364
9365         * macrotab.h (macro_source_fullname): Return a std::string.
9366         * macrotab.c (macro_include, check_for_redefinition)
9367         (macro_undef, macro_lookup_definition, foreach_macro)
9368         (foreach_macro_in_scope): Update.
9369         (macro_source_fullname): Return a std::string.
9370         * macrocmd.c (show_pp_source_pos): Update.
9371
9372 2019-02-17  Tom Tromey  <tom@tromey.com>
9373
9374         * macrocmd.c (show_pp_source_pos): Style the file names.
9375
9376 2019-02-17  Tom Tromey  <tom@tromey.com>
9377
9378         PR tui/24197:
9379         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9380
9381 2019-02-17  Tom Tromey  <tom@tromey.com>
9382
9383         * ada-lang.c (user_select_syms): Use filtered printing.
9384         * utils.c (wrap_style): New global.
9385         (desired_style): Remove.
9386         (emit_style_escape): Add stream parameter.
9387         (set_output_style, reset_terminal_style, prompt_for_continue):
9388         Update.
9389         (flush_wrap_buffer): Only flush gdb_stdout.
9390         (wrap_here): Set wrap_style.
9391         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9392         treat escape sequences as a character.  Change when wrap buffer is
9393         flushed.
9394         (fputs_styled): Do not set the output style when the default is
9395         requested.
9396         * ui-style.h (struct ui_file_style) <is_default>: New method.
9397         * source.c (print_source_lines_base): Emit escape sequences in one
9398         piece.
9399
9400 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9401
9402         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9403         integers and enumeration types.
9404
9405 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9406
9407         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9408         instead of lookup_symbol_in_language
9409         (do_exact_match): New function.
9410         (ada_get_symbol_name_matcher): Return do_exact_match when
9411         doing a verbatim match.
9412
9413 2019-02-15  Tom Tromey  <tromey@adacore.com>
9414
9415         * ravenscar-thread.c (ravenscar_thread_target::resume)
9416         (ravenscar_thread_target::wait): Special case wildcard requests.
9417
9418 2019-02-15  Tom Tromey  <tromey@adacore.com>
9419
9420         * ravenscar-thread.c (base_ptid): Remove.
9421         (struct ravenscar_thread_target) <close>: New method.
9422         <m_base_ptid>: New member.
9423         <update_inferior_ptid, active_task, task_is_currently_active,
9424         runtime_initialized>: Declare methods.
9425         <ravenscar_thread_target>: Add constructor.
9426         (ravenscar_thread_target::task_is_currently_active)
9427         (ravenscar_thread_target::update_inferior_ptid)
9428         (ravenscar_runtime_initialized): Rename.  Now methods.
9429         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9430         (ravenscar_thread_target::update_thread_list): Update.
9431         (ravenscar_thread_target::active_task): Now method.
9432         (ravenscar_thread_target::store_registers)
9433         (ravenscar_thread_target::prepare_to_store)
9434         (ravenscar_thread_target::prepare_to_store)
9435         (ravenscar_thread_target::mourn_inferior): Update.
9436         (ravenscar_inferior_created): Use "new" to create target.
9437         (ravenscar_thread_target::get_ada_task_ptid): Update.
9438         (_initialize_ravenscar): Don't initialize base_ptid.
9439         (ravenscar_ops): Remove global.
9440
9441 2019-02-15  Tom Tromey  <tromey@adacore.com>
9442
9443         * target.h (push_target): Declare new overload.
9444         * target.c (push_target): New overload, taking an rvalue reference.
9445         * remote.c (remote_target::open_1): Use push_target overload.
9446         * corelow.c (core_target_open): Use push_target overload.
9447
9448 2019-02-15  Tom Tromey  <tromey@adacore.com>
9449
9450         * ravenscar-thread.c (is_ravenscar_task)
9451         (ravenscar_task_is_currently_active): Return bool.
9452         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9453         (_initialize_ravenscar): Remove "(void)".
9454         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9455         Return bool.
9456
9457 2019-02-15  Tom Tromey  <tromey@adacore.com>
9458
9459         * ravenscar-thread.c (ravenscar_runtime_initializer)
9460         (has_ravenscar_runtime, get_running_thread_id)
9461         (ravenscar_thread_target::resume): Fix indentation.
9462
9463 2019-02-15  Tom Tromey  <tromey@adacore.com>
9464
9465         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9466         from ravenscar_arch_ops.
9467         (sparc_ravenscar_ops::fetch_registers)
9468         (sparc_ravenscar_ops::store_registers): Now methods.
9469         (sparc_ravenscar_prepare_to_store): Remove.
9470         (sparc_ravenscar_ops): Redefine.
9471         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9472         methods and destructor.  Remove members.
9473         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9474         (ravenscar_thread_target::store_registers)
9475         (ravenscar_thread_target::prepare_to_store): Update.
9476         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9477         Remove.
9478         (struct ppc_ravenscar_powerpc_ops): Derive from
9479         ravenscar_arch_ops.
9480         (ppc_ravenscar_powerpc_ops::fetch_registers)
9481         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9482         (ppc_ravenscar_powerpc_ops): Redefine.
9483         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9484         (ppc_ravenscar_e500_ops::fetch_registers)
9485         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9486         (ppc_ravenscar_e500_ops): Redefine.
9487         * aarch64-ravenscar-thread.c
9488         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9489         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9490         (aarch64_ravenscar_fetch_registers)
9491         (aarch64_ravenscar_store_registers): Now methods.
9492         (aarch64_ravenscar_ops): Redefine.
9493
9494 2019-02-15  Tom Tromey  <tromey@adacore.com>
9495
9496         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9497         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9498         (ravenscar_thread_target::stopped_by_watchpoint)
9499         (ravenscar_thread_target::stopped_data_address)
9500         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9501
9502 2019-02-15  Tom Tromey  <tromey@adacore.com>
9503
9504         * ravenscar-thread.c: Fix some typos.
9505
9506 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9507             Tom Tromey  <tromey@adacore.com>
9508
9509         * ada-lang.c (ada_exception_sal): Change addr_string to a
9510         std::string.
9511         (create_ada_exception_catchpoint): Update.
9512
9513 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9514             Tom Tromey  <tromey@adacore.com>
9515
9516         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9517         (bp_location_ops): Remove.
9518         (base_breakpoint_allocate_location): Update.
9519         (free_bp_location): Update.
9520         * ada-lang.c (class ada_catchpoint_location)
9521         <ada_catchpoint_location>: Remove ops parameter.
9522         (ada_catchpoint_location_dtor): Remove.
9523         (ada_catchpoint_location_ops): Remove.
9524         (allocate_location_exception): Update.
9525         * breakpoint.h (struct bp_location_ops): Remove.
9526         (class bp_location) <bp_location>: Remove bp_location_ops
9527         parameter.
9528         <~bp_location>: Add destructor.
9529         <ops>: Remove.
9530
9531 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9532             Pedro Alves  <palves@redhat.com>
9533
9534         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9535         'PATH_MAX'.
9536
9537 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9538             Samuel Thibault  <samuel.thibault@gnu.org>
9539             Thomas Schwinge  <thomas@codesourcery.com>
9540
9541         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9542         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9543
9544 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9545
9546         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9547         (check_empty): Use "const char *".
9548
9549         * gnu-nat.c (gnu_nat_target::detach): Instead of
9550         'detach_inferior (pid)' call
9551         'detach_inferior (find_inferior_pid (pid))'.
9552
9553         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9554         'nat/fork-inferior.o'.
9555         * gnu-nat.c: #include "nat/fork-inferior.h".
9556
9557         * gnu-nat.c (gnu_nat_target::detach): Instead of
9558         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9559         * gnu-nat.h: #include "inf-child.h".
9560         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9561         'i386_gnu_nat_target::fetch_registers'.
9562         (gnu_store_registers): Rename/move to
9563         'i386_gnu_nat_target::store_registers'.
9564
9565         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9566         * gnu-nat.h (mach_thread_info): New function.
9567         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9568
9569         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9570
9571 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9572
9573         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9574
9575 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9576
9577         * windows-nat.c (windows_add_thread): Add new parameter
9578         "main_thread_p" with default value set to false.  Update
9579         function documentation as well as all callers.
9580         (windows_delete_thread): Likewise.
9581         (fake_create_process): Update call to windows_add_thread.
9582         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9583         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9584         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9585         call to windows_delete_thread.
9586
9587 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9588
9589         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9590
9591 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9592
9593         * symfile.c (find_separate_debug_file): Use canonical path of
9594         sysroot with child_path instead of gdb_sysroot if it is valid.
9595
9596 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9597
9598         * symfile.c (find_separate_debug_file): Use child_path to
9599         determine if an object file is under a sysroot.
9600
9601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9602
9603         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9604         unittests/child-path-selftests.c.
9605         * common/pathstuff.c (child_path): New function.
9606         * common/pathstuff.h (child_path): New prototype.
9607         * unittests/child-path-selftests.c: New file.
9608
9609 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9610
9611         * symfile.c (find_separate_debug_file): Look for separate debug
9612         files in debug directories under the sysroot.
9613
9614 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9615
9616         * symtab.h (struct minimal_symbol data_p): New const method.
9617         (struct minimal_symbol text_p): Likewise.
9618         * symtab.c (output_source_filename): Use file name style
9619         to print file name.
9620         (print_symbol_info): Likewise.
9621         (print_msymbol_info): Use address style to print addresses.
9622         Use function name style to print executable text symbols.
9623         (expand_symtab_containing_pc): Use data_p.
9624         (find_pc_sect_compunit_symtab): Likewise.
9625
9626 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9627
9628         * breakpoint.c (describe_other_breakpoints): Use address style
9629         to print addresses.
9630         (say_where): Likewise.
9631
9632 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9633
9634         * ada-typeprint.c (print_func_type): Print function name
9635         style to print function name.
9636         * c-typeprint.c (c_print_type_1): Likewise.
9637
9638 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9639
9640         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9641         for execve.
9642
9643 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9644
9645         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9646         type_stack.
9647
9648 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9649
9650         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9651         TYPE_CODE_REF types.
9652
9653 2019-02-08  Jim Wilson  <jimw@sifive.com>
9654
9655         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9656         (riscv_linux_fregset): New.
9657         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9658
9659 2019-02-07  Tom Tromey  <tom@tromey.com>
9660
9661         * thread.c (thread_cancel_execution_command): Update.
9662         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9663         methods.
9664         (struct thread_fsm_ops): Remove.
9665         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9666         (thread_fsm_should_stop, thread_fsm_return_value)
9667         (thread_fsm_set_finished, thread_fsm_finished_p)
9668         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9669         Don't declare.
9670         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9671         * infrun.c (clear_proceed_status_thread)
9672         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9673         (print_stop_event): Update.
9674         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9675         Add constructor.
9676         (step_command_fsm_ops): Remove.
9677         (new_step_command_fsm): Remove.
9678         (step_1): Update.
9679         (step_command_fsm::should_stop): Rename from
9680         step_command_fsm_should_stop.
9681         (step_command_fsm::clean_up): Rename from
9682         step_command_fsm_clean_up.
9683         (step_command_fsm::do_async_reply_reason): Rename from
9684         step_command_fsm_async_reply_reason.
9685         (struct until_next_fsm): Inherit from thread_fsm.  Add
9686         constructor.
9687         (until_next_fsm_ops): Remove.
9688         (new_until_next_fsm): Remove.
9689         (until_next_fsm::should_stop): Rename from
9690         until_next_fsm_should_stop.
9691         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9692         (until_next_fsm::do_async_reply_reason): Rename from
9693         until_next_fsm_async_reply_reason.
9694         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9695         constructor.  Change type of breakpoint.
9696         (finish_command_fsm_ops): Remove.
9697         (new_finish_command_fsm): Remove.
9698         (finish_command_fsm::should_stop): Rename from
9699         finish_command_fsm_should_stop.
9700         (finish_command_fsm::clean_up): Rename from
9701         finish_command_fsm_clean_up.
9702         (finish_command_fsm::return_value): Rename from
9703         finish_command_fsm_return_value.
9704         (finish_command_fsm::do_async_reply_reason): Rename from
9705         finish_command_fsm_async_reply_reason.
9706         (finish_command): Update.
9707         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9708         Add constructor.
9709         (call_thread_fsm_ops): Remove.
9710         (call_thread_fsm::call_thread_fsm): Rename from
9711         new_call_thread_fsm.
9712         (call_thread_fsm::should_stop): Rename from
9713         call_thread_fsm_should_stop.
9714         (call_thread_fsm::should_notify_stop): Rename from
9715         call_thread_fsm_should_notify_stop.
9716         (run_inferior_call, call_function_by_hand_dummy): Update.
9717         * cli/cli-interp.c (should_print_stop_to_console): Update.
9718         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9719         Add constructor.  Change type of location_breakpoint,
9720         caller_breakpoint.
9721         (until_break_fsm_ops): Remove.
9722         (new_until_break_fsm): Remove.
9723         (until_break_fsm::should_stop): Rename from
9724         until_break_fsm_should_stop.
9725         (until_break_fsm::clean_up): Rename from
9726         until_break_fsm_clean_up.
9727         (until_break_fsm::do_async_reply_reason): Rename from
9728         until_break_fsm_async_reply_reason.
9729         (until_break_command): Update.
9730         * thread-fsm.c: Remove.
9731         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9732
9733 2019-02-07  Tom Tromey  <tom@tromey.com>
9734
9735         * yy-remap.h: Add include guard.
9736         * xtensa-tdep.h: Add include guard.
9737         * xcoffread.h: Rename include guard.
9738         * varobj-iter.h: Add include guard.
9739         * tui/tui.h: Rename include guard.
9740         * tui/tui-winsource.h: Rename include guard.
9741         * tui/tui-wingeneral.h: Rename include guard.
9742         * tui/tui-windata.h: Rename include guard.
9743         * tui/tui-win.h: Rename include guard.
9744         * tui/tui-stack.h: Rename include guard.
9745         * tui/tui-source.h: Rename include guard.
9746         * tui/tui-regs.h: Rename include guard.
9747         * tui/tui-out.h: Rename include guard.
9748         * tui/tui-layout.h: Rename include guard.
9749         * tui/tui-io.h: Rename include guard.
9750         * tui/tui-hooks.h: Rename include guard.
9751         * tui/tui-file.h: Rename include guard.
9752         * tui/tui-disasm.h: Rename include guard.
9753         * tui/tui-data.h: Rename include guard.
9754         * tui/tui-command.h: Rename include guard.
9755         * tic6x-tdep.h: Add include guard.
9756         * target/waitstatus.h: Rename include guard.
9757         * target/wait.h: Rename include guard.
9758         * target/target.h: Rename include guard.
9759         * target/resume.h: Rename include guard.
9760         * target-float.h: Rename include guard.
9761         * stabsread.h: Add include guard.
9762         * rs6000-tdep.h: Add include guard.
9763         * riscv-fbsd-tdep.h: Add include guard.
9764         * regformats/regdef.h: Rename include guard.
9765         * record.h: Rename include guard.
9766         * python/python.h: Rename include guard.
9767         * python/python-internal.h: Rename include guard.
9768         * python/py-stopevent.h: Rename include guard.
9769         * python/py-ref.h: Rename include guard.
9770         * python/py-record.h: Rename include guard.
9771         * python/py-record-full.h: Rename include guard.
9772         * python/py-record-btrace.h: Rename include guard.
9773         * python/py-instruction.h: Rename include guard.
9774         * python/py-events.h: Rename include guard.
9775         * python/py-event.h: Rename include guard.
9776         * procfs.h: Add include guard.
9777         * proc-utils.h: Add include guard.
9778         * p-lang.h: Add include guard.
9779         * or1k-tdep.h: Rename include guard.
9780         * observable.h: Rename include guard.
9781         * nto-tdep.h: Rename include guard.
9782         * nat/x86-linux.h: Rename include guard.
9783         * nat/x86-linux-dregs.h: Rename include guard.
9784         * nat/x86-gcc-cpuid.h: Add include guard.
9785         * nat/x86-dregs.h: Rename include guard.
9786         * nat/x86-cpuid.h: Rename include guard.
9787         * nat/ppc-linux.h: Rename include guard.
9788         * nat/mips-linux-watch.h: Rename include guard.
9789         * nat/linux-waitpid.h: Rename include guard.
9790         * nat/linux-ptrace.h: Rename include guard.
9791         * nat/linux-procfs.h: Rename include guard.
9792         * nat/linux-osdata.h: Rename include guard.
9793         * nat/linux-nat.h: Rename include guard.
9794         * nat/linux-namespaces.h: Rename include guard.
9795         * nat/linux-btrace.h: Rename include guard.
9796         * nat/glibc_thread_db.h: Rename include guard.
9797         * nat/gdb_thread_db.h: Rename include guard.
9798         * nat/gdb_ptrace.h: Rename include guard.
9799         * nat/fork-inferior.h: Rename include guard.
9800         * nat/amd64-linux-siginfo.h: Rename include guard.
9801         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9802         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9803         * nat/aarch64-linux.h: Rename include guard.
9804         * nat/aarch64-linux-hw-point.h: Rename include guard.
9805         * mn10300-tdep.h: Add include guard.
9806         * mips-linux-tdep.h: Add include guard.
9807         * mi/mi-parse.h: Rename include guard.
9808         * mi/mi-out.h: Rename include guard.
9809         * mi/mi-main.h: Rename include guard.
9810         * mi/mi-interp.h: Rename include guard.
9811         * mi/mi-getopt.h: Rename include guard.
9812         * mi/mi-console.h: Rename include guard.
9813         * mi/mi-common.h: Rename include guard.
9814         * mi/mi-cmds.h: Rename include guard.
9815         * mi/mi-cmd-break.h: Rename include guard.
9816         * m2-lang.h: Add include guard.
9817         * location.h: Rename include guard.
9818         * linux-record.h: Rename include guard.
9819         * linux-nat.h: Add include guard.
9820         * linux-fork.h: Add include guard.
9821         * i386-darwin-tdep.h: Rename include guard.
9822         * hppa-linux-offsets.h: Add include guard.
9823         * guile/guile.h: Rename include guard.
9824         * guile/guile-internal.h: Rename include guard.
9825         * gnu-nat.h: Rename include guard.
9826         * gdb-stabs.h: Rename include guard.
9827         * frv-tdep.h: Add include guard.
9828         * f-lang.h: Add include guard.
9829         * event-loop.h: Add include guard.
9830         * darwin-nat.h: Rename include guard.
9831         * cp-abi.h: Rename include guard.
9832         * config/sparc/nm-sol2.h: Rename include guard.
9833         * config/nm-nto.h: Rename include guard.
9834         * config/nm-linux.h: Add include guard.
9835         * config/i386/nm-i386gnu.h: Rename include guard.
9836         * config/djgpp/nl_types.h: Rename include guard.
9837         * config/djgpp/langinfo.h: Rename include guard.
9838         * compile/gcc-cp-plugin.h: Add include guard.
9839         * compile/gcc-c-plugin.h: Add include guard.
9840         * compile/compile.h: Rename include guard.
9841         * compile/compile-object-run.h: Rename include guard.
9842         * compile/compile-object-load.h: Rename include guard.
9843         * compile/compile-internal.h: Rename include guard.
9844         * compile/compile-cplus.h: Rename include guard.
9845         * compile/compile-c.h: Rename include guard.
9846         * common/xml-utils.h: Rename include guard.
9847         * common/x86-xstate.h: Rename include guard.
9848         * common/version.h: Rename include guard.
9849         * common/vec.h: Rename include guard.
9850         * common/tdesc.h: Rename include guard.
9851         * common/selftest.h: Rename include guard.
9852         * common/scoped_restore.h: Rename include guard.
9853         * common/scoped_mmap.h: Rename include guard.
9854         * common/scoped_fd.h: Rename include guard.
9855         * common/safe-iterator.h: Rename include guard.
9856         * common/run-time-clock.h: Rename include guard.
9857         * common/refcounted-object.h: Rename include guard.
9858         * common/queue.h: Rename include guard.
9859         * common/ptid.h: Rename include guard.
9860         * common/print-utils.h: Rename include guard.
9861         * common/preprocessor.h: Rename include guard.
9862         * common/pathstuff.h: Rename include guard.
9863         * common/observable.h: Rename include guard.
9864         * common/netstuff.h: Rename include guard.
9865         * common/job-control.h: Rename include guard.
9866         * common/host-defs.h: Rename include guard.
9867         * common/gdb_wait.h: Rename include guard.
9868         * common/gdb_vecs.h: Rename include guard.
9869         * common/gdb_unlinker.h: Rename include guard.
9870         * common/gdb_unique_ptr.h: Rename include guard.
9871         * common/gdb_tilde_expand.h: Rename include guard.
9872         * common/gdb_sys_time.h: Rename include guard.
9873         * common/gdb_string_view.h: Rename include guard.
9874         * common/gdb_splay_tree.h: Rename include guard.
9875         * common/gdb_setjmp.h: Rename include guard.
9876         * common/gdb_ref_ptr.h: Rename include guard.
9877         * common/gdb_optional.h: Rename include guard.
9878         * common/gdb_locale.h: Rename include guard.
9879         * common/gdb_assert.h: Rename include guard.
9880         * common/filtered-iterator.h: Rename include guard.
9881         * common/filestuff.h: Rename include guard.
9882         * common/fileio.h: Rename include guard.
9883         * common/environ.h: Rename include guard.
9884         * common/common-utils.h: Rename include guard.
9885         * common/common-types.h: Rename include guard.
9886         * common/common-regcache.h: Rename include guard.
9887         * common/common-inferior.h: Rename include guard.
9888         * common/common-gdbthread.h: Rename include guard.
9889         * common/common-exceptions.h: Rename include guard.
9890         * common/common-defs.h: Rename include guard.
9891         * common/common-debug.h: Rename include guard.
9892         * common/cleanups.h: Rename include guard.
9893         * common/buffer.h: Rename include guard.
9894         * common/btrace-common.h: Rename include guard.
9895         * common/break-common.h: Rename include guard.
9896         * cli/cli-utils.h: Rename include guard.
9897         * cli/cli-style.h: Rename include guard.
9898         * cli/cli-setshow.h: Rename include guard.
9899         * cli/cli-script.h: Rename include guard.
9900         * cli/cli-interp.h: Rename include guard.
9901         * cli/cli-decode.h: Rename include guard.
9902         * cli/cli-cmds.h: Rename include guard.
9903         * charset-list.h: Add include guard.
9904         * buildsym-legacy.h: Rename include guard.
9905         * bfin-tdep.h: Add include guard.
9906         * ax.h: Rename include guard.
9907         * arm-linux-tdep.h: Add include guard.
9908         * arm-fbsd-tdep.h: Add include guard.
9909         * arch/xtensa.h: Rename include guard.
9910         * arch/tic6x.h: Add include guard.
9911         * arch/i386.h: Add include guard.
9912         * arch/arm.h: Rename include guard.
9913         * arch/arm-linux.h: Rename include guard.
9914         * arch/arm-get-next-pcs.h: Rename include guard.
9915         * arch/amd64.h: Add include guard.
9916         * arch/aarch64-insn.h: Rename include guard.
9917         * arch-utils.h: Rename include guard.
9918         * annotate.h: Add include guard.
9919         * amd64-darwin-tdep.h: Rename include guard.
9920         * aarch64-linux-tdep.h: Add include guard.
9921         * aarch64-fbsd-tdep.h: Add include guard.
9922         * aarch32-linux-nat.h: Add include guard.
9923
9924 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9925
9926         * macrotab.c (macro_define_internal): New function that
9927         factorizes macro_define_object_internal and macro_define_function
9928         code.
9929         (macro_define_object_internal): Use macro_define_internal.
9930         (macro_define_function): Likewise.
9931
9932 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9933
9934         * macrocmd.c (extract_identifier): Return
9935         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9936         callers.
9937
9938 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9939
9940         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9941
9942 2019-02-05  Tom Tromey  <tom@tromey.com>
9943
9944         * target.c (target_stack::unpush): Move assertion earlier.
9945
9946 2019-01-30  Tom Tromey  <tom@tromey.com>
9947
9948         PR python/23615:
9949         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9950         (gdbpy_parse_and_eval): Likewise.
9951         * python/python-internal.h (gdbpy_allow_threads): New class.
9952
9953 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9954
9955         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9956         (aarch64_fbsd_fpregmap): Move earlier.
9957         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9958         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9959         instead of individual calls to trad_frame_set_reg_addr.
9960         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9961         earlier.
9962         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9963         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9964         instead of individual calls to trad_frame_set_reg_addr.
9965
9966 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9967
9968         * CONTRIBUTE: Replace contribution list with wiki link.
9969
9970 2019-01-25  Tom Tromey  <tom@tromey.com>
9971
9972         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9973
9974 2019-01-25  Tom Tromey  <tom@tromey.com>
9975
9976         * xtensa-linux-nat.c: Fix common/ includes.
9977         * xml-support.h: Fix common/ includes.
9978         * xml-support.c: Fix common/ includes.
9979         * x86-linux-nat.c: Fix common/ includes.
9980         * windows-nat.c: Fix common/ includes.
9981         * varobj.h: Fix common/ includes.
9982         * varobj.c: Fix common/ includes.
9983         * value.c: Fix common/ includes.
9984         * valops.c: Fix common/ includes.
9985         * utils.c: Fix common/ includes.
9986         * unittests/xml-utils-selftests.c: Fix common/ includes.
9987         * unittests/utils-selftests.c: Fix common/ includes.
9988         * unittests/unpack-selftests.c: Fix common/ includes.
9989         * unittests/tracepoint-selftests.c: Fix common/ includes.
9990         * unittests/style-selftests.c: Fix common/ includes.
9991         * unittests/string_view-selftests.c: Fix common/ includes.
9992         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9993         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9994         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9995         * unittests/rsp-low-selftests.c: Fix common/ includes.
9996         * unittests/parse-connection-spec-selftests.c: Fix common/
9997         includes.
9998         * unittests/optional-selftests.c: Fix common/ includes.
9999         * unittests/offset-type-selftests.c: Fix common/ includes.
10000         * unittests/observable-selftests.c: Fix common/ includes.
10001         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10002         * unittests/memrange-selftests.c: Fix common/ includes.
10003         * unittests/memory-map-selftests.c: Fix common/ includes.
10004         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10005         * unittests/function-view-selftests.c: Fix common/ includes.
10006         * unittests/environ-selftests.c: Fix common/ includes.
10007         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10008         * unittests/common-utils-selftests.c: Fix common/ includes.
10009         * unittests/cli-utils-selftests.c: Fix common/ includes.
10010         * unittests/array-view-selftests.c: Fix common/ includes.
10011         * ui-file.c: Fix common/ includes.
10012         * tui/tui-io.c: Fix common/ includes.
10013         * tracepoint.h: Fix common/ includes.
10014         * tracepoint.c: Fix common/ includes.
10015         * tracefile-tfile.c: Fix common/ includes.
10016         * top.h: Fix common/ includes.
10017         * top.c: Fix common/ includes.
10018         * thread.c: Fix common/ includes.
10019         * target/waitstatus.h: Fix common/ includes.
10020         * target/waitstatus.c: Fix common/ includes.
10021         * target.h: Fix common/ includes.
10022         * target.c: Fix common/ includes.
10023         * target-memory.c: Fix common/ includes.
10024         * target-descriptions.c: Fix common/ includes.
10025         * symtab.h: Fix common/ includes.
10026         * symfile.c: Fix common/ includes.
10027         * stap-probe.c: Fix common/ includes.
10028         * spu-linux-nat.c: Fix common/ includes.
10029         * sparc-nat.c: Fix common/ includes.
10030         * source.c: Fix common/ includes.
10031         * solib.c: Fix common/ includes.
10032         * solib-target.c: Fix common/ includes.
10033         * ser-unix.c: Fix common/ includes.
10034         * ser-tcp.c: Fix common/ includes.
10035         * ser-pipe.c: Fix common/ includes.
10036         * ser-base.c: Fix common/ includes.
10037         * selftest-arch.c: Fix common/ includes.
10038         * s12z-tdep.c: Fix common/ includes.
10039         * rust-exp.y: Fix common/ includes.
10040         * rs6000-aix-tdep.c: Fix common/ includes.
10041         * riscv-tdep.c: Fix common/ includes.
10042         * remote.c: Fix common/ includes.
10043         * remote-notif.h: Fix common/ includes.
10044         * remote-fileio.h: Fix common/ includes.
10045         * remote-fileio.c: Fix common/ includes.
10046         * regcache.h: Fix common/ includes.
10047         * regcache.c: Fix common/ includes.
10048         * record-btrace.c: Fix common/ includes.
10049         * python/python.c: Fix common/ includes.
10050         * python/py-type.c: Fix common/ includes.
10051         * python/py-inferior.c: Fix common/ includes.
10052         * progspace.h: Fix common/ includes.
10053         * producer.c: Fix common/ includes.
10054         * procfs.c: Fix common/ includes.
10055         * proc-api.c: Fix common/ includes.
10056         * printcmd.c: Fix common/ includes.
10057         * ppc-linux-nat.c: Fix common/ includes.
10058         * parser-defs.h: Fix common/ includes.
10059         * osdata.c: Fix common/ includes.
10060         * obsd-nat.c: Fix common/ includes.
10061         * nat/x86-linux.c: Fix common/ includes.
10062         * nat/x86-linux-dregs.c: Fix common/ includes.
10063         * nat/x86-dregs.h: Fix common/ includes.
10064         * nat/x86-dregs.c: Fix common/ includes.
10065         * nat/ppc-linux.c: Fix common/ includes.
10066         * nat/mips-linux-watch.h: Fix common/ includes.
10067         * nat/mips-linux-watch.c: Fix common/ includes.
10068         * nat/linux-waitpid.c: Fix common/ includes.
10069         * nat/linux-ptrace.h: Fix common/ includes.
10070         * nat/linux-ptrace.c: Fix common/ includes.
10071         * nat/linux-procfs.c: Fix common/ includes.
10072         * nat/linux-personality.c: Fix common/ includes.
10073         * nat/linux-osdata.c: Fix common/ includes.
10074         * nat/linux-namespaces.c: Fix common/ includes.
10075         * nat/linux-btrace.h: Fix common/ includes.
10076         * nat/linux-btrace.c: Fix common/ includes.
10077         * nat/fork-inferior.c: Fix common/ includes.
10078         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10079         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10080         * nat/aarch64-linux.c: Fix common/ includes.
10081         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10082         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10083         * namespace.h: Fix common/ includes.
10084         * mips-linux-tdep.c: Fix common/ includes.
10085         * minsyms.c: Fix common/ includes.
10086         * mi/mi-parse.h: Fix common/ includes.
10087         * mi/mi-main.c: Fix common/ includes.
10088         * mi/mi-cmd-env.c: Fix common/ includes.
10089         * memrange.h: Fix common/ includes.
10090         * memattr.c: Fix common/ includes.
10091         * maint.h: Fix common/ includes.
10092         * maint.c: Fix common/ includes.
10093         * main.c: Fix common/ includes.
10094         * machoread.c: Fix common/ includes.
10095         * location.c: Fix common/ includes.
10096         * linux-thread-db.c: Fix common/ includes.
10097         * linux-nat.c: Fix common/ includes.
10098         * linux-fork.c: Fix common/ includes.
10099         * inline-frame.c: Fix common/ includes.
10100         * infrun.c: Fix common/ includes.
10101         * inflow.c: Fix common/ includes.
10102         * inferior.h: Fix common/ includes.
10103         * inferior.c: Fix common/ includes.
10104         * infcmd.c: Fix common/ includes.
10105         * inf-ptrace.c: Fix common/ includes.
10106         * inf-child.c: Fix common/ includes.
10107         * ia64-linux-nat.c: Fix common/ includes.
10108         * i387-tdep.c: Fix common/ includes.
10109         * i386-tdep.c: Fix common/ includes.
10110         * i386-linux-tdep.c: Fix common/ includes.
10111         * i386-linux-nat.c: Fix common/ includes.
10112         * i386-go32-tdep.c: Fix common/ includes.
10113         * i386-fbsd-tdep.c: Fix common/ includes.
10114         * i386-fbsd-nat.c: Fix common/ includes.
10115         * guile/scm-type.c: Fix common/ includes.
10116         * guile/guile.c: Fix common/ includes.
10117         * go32-nat.c: Fix common/ includes.
10118         * gnu-nat.c: Fix common/ includes.
10119         * gdbthread.h: Fix common/ includes.
10120         * gdbarch-selftests.c: Fix common/ includes.
10121         * gdb_usleep.c: Fix common/ includes.
10122         * gdb_select.h: Fix common/ includes.
10123         * gdb_bfd.c: Fix common/ includes.
10124         * gcore.c: Fix common/ includes.
10125         * fork-child.c: Fix common/ includes.
10126         * findvar.c: Fix common/ includes.
10127         * fbsd-nat.c: Fix common/ includes.
10128         * event-top.c: Fix common/ includes.
10129         * event-loop.c: Fix common/ includes.
10130         * dwarf2read.c: Fix common/ includes.
10131         * dwarf2loc.c: Fix common/ includes.
10132         * dwarf2-frame.c: Fix common/ includes.
10133         * dwarf-index-cache.c: Fix common/ includes.
10134         * dtrace-probe.c: Fix common/ includes.
10135         * disasm-selftests.c: Fix common/ includes.
10136         * defs.h: Fix common/ includes.
10137         * csky-tdep.c: Fix common/ includes.
10138         * cp-valprint.c: Fix common/ includes.
10139         * cp-support.h: Fix common/ includes.
10140         * cp-support.c: Fix common/ includes.
10141         * corelow.c: Fix common/ includes.
10142         * completer.h: Fix common/ includes.
10143         * completer.c: Fix common/ includes.
10144         * compile/compile.c: Fix common/ includes.
10145         * compile/compile-loc2c.c: Fix common/ includes.
10146         * compile/compile-cplus-types.c: Fix common/ includes.
10147         * compile/compile-cplus-symbols.c: Fix common/ includes.
10148         * command.h: Fix common/ includes.
10149         * cli/cli-dump.c: Fix common/ includes.
10150         * cli/cli-cmds.c: Fix common/ includes.
10151         * charset.c: Fix common/ includes.
10152         * build-id.c: Fix common/ includes.
10153         * btrace.h: Fix common/ includes.
10154         * btrace.c: Fix common/ includes.
10155         * breakpoint.h: Fix common/ includes.
10156         * breakpoint.c: Fix common/ includes.
10157         * ax.h:
10158         (enum agent_op): Fix common/ includes.
10159         * ax-general.c (struct aop_map): Fix common/ includes.
10160         * ax-gdb.c: Fix common/ includes.
10161         * auxv.c: Fix common/ includes.
10162         * auto-load.c: Fix common/ includes.
10163         * arm-tdep.c: Fix common/ includes.
10164         * arch/riscv.c: Fix common/ includes.
10165         * arch/ppc-linux-common.c: Fix common/ includes.
10166         * arch/i386.c: Fix common/ includes.
10167         * arch/arm.c: Fix common/ includes.
10168         * arch/arm-linux.c: Fix common/ includes.
10169         * arch/arm-get-next-pcs.c: Fix common/ includes.
10170         * arch/amd64.c: Fix common/ includes.
10171         * arch/aarch64.c: Fix common/ includes.
10172         * arch/aarch64-insn.c: Fix common/ includes.
10173         * arch-utils.c: Fix common/ includes.
10174         * amd64-windows-tdep.c: Fix common/ includes.
10175         * amd64-tdep.c: Fix common/ includes.
10176         * amd64-sol2-tdep.c: Fix common/ includes.
10177         * amd64-obsd-tdep.c: Fix common/ includes.
10178         * amd64-nbsd-tdep.c: Fix common/ includes.
10179         * amd64-linux-tdep.c: Fix common/ includes.
10180         * amd64-linux-nat.c: Fix common/ includes.
10181         * amd64-fbsd-tdep.c: Fix common/ includes.
10182         * amd64-fbsd-nat.c: Fix common/ includes.
10183         * amd64-dicos-tdep.c: Fix common/ includes.
10184         * amd64-darwin-tdep.c: Fix common/ includes.
10185         * agent.c: Fix common/ includes.
10186         * ada-lang.h: Fix common/ includes.
10187         * ada-lang.c: Fix common/ includes.
10188         * aarch64-tdep.c: Fix common/ includes.
10189
10190 2019-01-25  Tom Tromey  <tom@tromey.com>
10191
10192         * common/create-version.sh: Use common/version.h.
10193
10194 2019-01-24  Pedro Alves  <palves@redhat.com>
10195
10196         * infrun.c (signal_stop, signal_print, signal_program)
10197         (signal_catch, signal_pass): Now arrays instead of pointers.
10198         (update_signals_program_target, do_target_resume)
10199         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10200         * linux-nat.c (linux_nat_target::pass_signals)
10201         (linux_nat_target::create_inferior, linux_nat_target::attach):
10202         Adjust.
10203         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10204         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10205         * procfs.c (procfs_target::pass_signals): Adjust.
10206         * record-full.c (record_full_target::resume): Adjust.
10207         * remote.c (remote_target::pass_signals)
10208         (remote_target::program_signals): Adjust.
10209         * target-debug.h (target_debug_print_signals): Now takes a
10210         gdb::array_view as parameter.  Adjust.
10211         * target.h (target_ops) <pass_signals, program_signals>: Replace
10212         pointer and length parameters with gdb::array_view.
10213         (target_pass_signals, target_program_signals): Likewise.
10214         * target-delegates.c: Regenerate.
10215
10216 2019-01-24  Pedro Alves  <palves@redhat.com>
10217
10218         * common/forward-scope-exit.h
10219         (forward_scope_exit::forward_scope_exit): Pass arguments to
10220         m_bind_function directly, instead of creating a std::bind and
10221         copying that.
10222
10223 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10224
10225         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10226         for static members.
10227         (pass_in_v_vfp_candidate): Likewise.
10228
10229 2019-01-23  Tom Tromey  <tom@tromey.com>
10230             Pedro Alves  <palves@redhat.com>
10231
10232         * regcache.c (class regcache_invalidator): Remove.
10233         (regcache::raw_write): Use make_scope_exit.
10234
10235 2019-01-23  Tom Tromey  <tom@tromey.com>
10236
10237         * ui-out.h (class ui_out_emit_type): Update comment.
10238
10239 2019-01-23  Tom Tromey  <tom@tromey.com>
10240
10241         * infrun.c (fetch_inferior_event): Update comment.
10242
10243 2019-01-23  Tom Tromey  <tom@tromey.com>
10244             Pedro Alves  <palves@redhat.com>
10245
10246         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10247         parameter.
10248         (fetch_inferior_event): Use SCOPE_EXIT.
10249
10250
10251 2019-01-23  Tom Tromey  <tom@tromey.com>
10252             Pedro Alves  <palves@redhat.com>
10253
10254         * infrun.c (disable_thread_events): Delete.
10255         (stop_all_threads): Use SCOPE_EXIT.
10256
10257 2019-01-23  Tom Tromey  <tom@tromey.com>
10258             Pedro Alves  <palves@redhat.com>
10259
10260         * symfile.c: Include forward-scope-exit.h.
10261         (clear_symtab_users_cleanup): Replace forward declaration with
10262         a FORWARD_SCOPE_EXIT.
10263         (syms_from_objfile_1): Use the forward_scope_exit and
10264         gdb::optional instead of cleanup_function.
10265         (reread_symbols): Use the forward_scope_exit instead of
10266         cleanup_function.
10267         (clear_symtab_users_cleanup): Remove function.
10268
10269 2019-01-23  Tom Tromey  <tom@tromey.com>
10270             Pedro Alves  <palves@redhat.com>
10271
10272         * linux-nat.c: Include scope-exit.h.
10273         (cleanup_target_stop): Remove.
10274         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10275         SCOPE_EXIT.
10276
10277 2019-01-23  Tom Tromey  <tom@tromey.com>
10278             Pedro Alves  <palves@redhat.com>
10279
10280         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10281         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10282
10283 2019-01-23  Tom Tromey  <tom@tromey.com>
10284             Andrew Burgess  <andrew.burgess@embecosm.com>
10285             Pedro Alves  <palves@redhat.com>
10286
10287         * infrun.c (fetch_inferior_event): Use scope_exit.
10288         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10289         * top.c (execute_command): Use scope_exit.
10290         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10291         * utils.c (do_bpstat_clear_actions_cleanup)
10292         (make_bpstat_clear_actions_cleanup): Remove.
10293
10294 2019-01-23  Tom Tromey  <tom@tromey.com>
10295             Pedro Alves  <palves@redhat.com>
10296
10297         * infrun.c: Include "common/scope-exit.h"
10298         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10299         (wait_for_inferior): Use SCOPE_EXIT.
10300         (fetch_inferior_event): Use scope_exit.
10301
10302 2019-01-23  Tom Tromey  <tom@tromey.com>
10303             Pedro Alves  <palves@redhat.com>
10304
10305         * breakpoint.c (create_breakpoint): Remove cleanup.
10306
10307 2019-01-23  Tom Tromey  <tom@tromey.com>
10308             Andrew Burgess  <andrew.burgess@embecosm.com>
10309             Pedro Alves  <palves@redhat.com>
10310
10311 2019-01-23  Pedro Alves  <palves@redhat.com>
10312
10313         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10314
10315 2019-01-23  Pedro Alves  <palves@redhat.com>
10316             Andrew Burgess  <andrew.burgess@embecosm.com>
10317
10318         * gdbthread.h: Include "common/forward-scope-exit.h".
10319         (scoped_finish_thread_state): Redefine custom class in terms of
10320         forward_scope_exit.
10321
10322 2019-01-23  Pedro Alves  <palves@redhat.com>
10323             Andrew Burgess  <andrew.burgess@embecosm.com>
10324
10325         * common/forward-scope-exit.h: New file.
10326
10327 2019-01-23  Pedro Alves  <palves@redhat.com>
10328             Andrew Burgess  <andrew.burgess@embecosm.com>
10329             Tom Tromey  <tom@tromey.com>
10330
10331         * common/scope-exit.h: New file.
10332
10333 2019-01-23  Pedro Alves  <palves@redhat.com>
10334
10335         * common/preprocessor.h (ESC): Rename to ...
10336         (ESC_PARENS): ... this.
10337         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10338         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10339
10340 2019-01-23  Tom Tromey  <tom@tromey.com>
10341
10342         * language.h (class scoped_switch_to_sym_language_if_auto):
10343         Initialize m_lang in both cases.
10344
10345 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10346
10347         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10348         with XCNEW.
10349
10350 2019-01-22  Tom Tromey  <tom@tromey.com>
10351
10352         * corelow.c: Do not include sys/file.h.
10353
10354 2019-01-22  Tom Tromey  <tom@tromey.com>
10355
10356         * tui/tui-wingeneral.h: Include gdb_curses.h.
10357
10358 2019-01-22  Tom Tromey  <tom@tromey.com>
10359
10360         * source-cache.h (class source_cache) <get_source_lines,
10361         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10362
10363 2019-01-22  Tom Tromey  <tom@tromey.com>
10364
10365         * remote-fileio.h (struct remote_target): Declare.
10366
10367 2019-01-22  Tom Tromey  <tom@tromey.com>
10368
10369         * python/py-arch.c: Do not include py-ref.h.
10370         * python/py-bpevent.c: Do not include py-ref.h.
10371         * python/py-cmd.c: Do not include py-ref.h.
10372         * python/py-continueevent.c: Do not include py-ref.h.
10373         * python/py-event.h: Do not include py-ref.h.
10374         * python/py-evtregistry.c: Do not include py-ref.h.
10375         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10376         * python/py-frame.c: Do not include py-ref.h.
10377         * python/py-framefilter.c: Do not include py-ref.h.
10378         * python/py-function.c: Do not include py-ref.h.
10379         * python/py-infevents.c: Do not include py-ref.h.
10380         * python/py-linetable.c: Do not include py-ref.h.
10381         * python/py-objfile.c: Do not include py-ref.h.
10382         * python/py-param.c: Do not include py-ref.h.
10383         * python/py-prettyprint.c: Do not include py-ref.h.
10384         * python/py-progspace.c: Do not include py-ref.h.
10385         * python/py-symbol.c: Do not include py-ref.h.
10386         * python/py-symtab.c: Do not include py-ref.h.
10387         * python/py-type.c: Do not include py-ref.h.
10388         * python/py-unwind.c: Do not include py-ref.h.
10389         * python/py-utils.c: Do not include py-ref.h.
10390         * python/py-value.c: Do not include py-ref.h.
10391         * python/py-varobj.c: Do not include py-ref.h.
10392         * python/py-xmethods.c: Do not include py-ref.h.
10393         * python/python.c: Do not include py-ref.h.
10394         * varobj.c: Do not include py-ref.h.
10395
10396 2019-01-22  Tom Tromey  <tom@tromey.com>
10397
10398         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10399         keyword for bcache.
10400
10401 2019-01-22  Tom Tromey  <tom@tromey.com>
10402
10403         * compile/compile-cplus-types.c: Remove a comment by #include.
10404
10405 2019-01-22  Tom Tromey  <tom@tromey.com>
10406
10407         * compile/gcc-c-plugin.h: Include compile-internal.h.
10408
10409 2019-01-22  Tom Tromey  <tom@tromey.com>
10410
10411         * stabsread.c (EXTERN): Do not define.
10412         (symnum, next_symbol_text_func, processing_gcc_compilation)
10413         (within_function, global_sym_chain, global_stabs)
10414         (previous_stab_code, this_object_header_files)
10415         (n_this_object_header_files)
10416         (n_allocated_this_object_header_files): Define.
10417         * stabsread.h (EXTERN): Never define.  Use "extern".
10418
10419 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10420
10421         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10422         history_value.
10423
10424 2019-01-21  Tom Tromey  <tom@tromey.com>
10425
10426         * ui-out.c: Fix includes.
10427         * tui/tui-source.c: Fix includes.
10428         * target.c: Fix includes.
10429         * remote.c: Fix includes.
10430         * regcache.c: Fix includes.
10431         * python/py-block.c: Fix includes.
10432         * printcmd.c: Fix includes.
10433         * or1k-tdep.c: Fix includes.
10434         * mi/mi-main.c: Fix includes.
10435         * m32r-tdep.c: Fix includes.
10436         * csky-tdep.c: Fix includes.
10437         * compile/compile-cplus-types.c: Fix includes.
10438         * cli/cli-interp.c: Fix includes.
10439
10440 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10441
10442         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10443         for padding.
10444
10445 2019-01-16  Tom Tromey  <tom@tromey.com>
10446
10447         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10448         earlier.
10449         (struct objfile) <msymbols_range>: Move from top level.
10450         <msymbols>: New method.
10451         (class objfile_msymbols): Remove.
10452         * symtab.c (default_collect_symbol_completion_matches_break_on):
10453         Update.
10454         * symmisc.c (dump_msymbols): Update.
10455         * stabsread.c (scan_file_globals): Update.
10456         * objc-lang.c (info_selectors_command, info_classes_command)
10457         (find_methods): Update.
10458         * minsyms.c (find_solib_trampoline_target): Update.
10459         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10460         * coffread.c (coff_symfile_read): Update.
10461         * ada-lang.c (ada_lookup_simple_minsym)
10462         (ada_collect_symbol_completion_matches): Update.
10463
10464 2019-01-16  Tom Tromey  <tom@tromey.com>
10465
10466         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10467         type.  Remove no-argument constructor.
10468         <iterator::operator++>: Simplify.
10469         <begin>: Update.
10470         <end>: Use minimal_symbol_count.
10471
10472 2019-01-16  Tom Tromey  <tom@tromey.com>
10473
10474         * objfiles.h (struct objfile) <psymtabs>: New method.
10475         (class objfile_psymtabs): Remove.
10476         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10477         typedef.
10478         <range>: New method.
10479         (require_partial_symbols): Change return type.
10480         * psymtab.c (require_partial_symbols)
10481         (psym_expand_symtabs_matching): Update.
10482         * mdebugread.c (parse_partial_symbols): Update.
10483         * dbxread.c (dbx_end_psymtab): Update.
10484
10485 2019-01-15  Tom Tromey  <tom@tromey.com>
10486
10487         * symtab.c (lookup_objfile_from_block)
10488         (lookup_symbol_in_objfile_symtabs)
10489         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10490         (find_line_symtab, info_sources_command)
10491         (default_collect_symbol_completion_matches_break_on)
10492         (make_source_files_completion_list): Update.
10493         * symmisc.c (print_objfile_statistics, dump_objfile)
10494         (maintenance_print_symbols, maintenance_info_symtabs)
10495         (maintenance_check_symtabs, maintenance_info_line_tables):
10496         Update.
10497         * source.c (select_source_symtab)
10498         (forget_cached_source_info_for_objfile): Update.
10499         * objfiles.h (class objfile_compunits): Remove.
10500         (struct objfile) <compunits_range>: New typedef.
10501         (compunits): New method.
10502         * objfiles.c (objfile_relocate1): Update.
10503         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10504         * maint.c (count_symtabs_and_blocks): Update.
10505         * linespec.c (iterate_over_all_matching_symtabs): Update.
10506         * cp-support.c (add_symbol_overload_list_qualified): Update.
10507         * coffread.c (coff_symtab_read): Update.
10508         * ada-lang.c (add_nonlocal_symbols)
10509         (ada_collect_symbol_completion_matches)
10510         (ada_add_global_exceptions): Update.
10511
10512 2019-01-15  Tom Tromey  <tom@tromey.com>
10513
10514         * progspace.h (program_space) <objfiles_safe_range>: New
10515         typedef.
10516         <objfiles_safe>: New method.
10517         * objfiles.h (class all_objfiles_safe): Remove.
10518         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10519         * jit.c (jit_inferior_exit_hook): Update.
10520
10521 2019-01-17  Tom Tromey  <tom@tromey.com>
10522
10523         * progspace.h (program_space) <objfiles_range>: New typedef.
10524         <objfiles>: New method.
10525         <objfiles_head>: Rename from objfiles.
10526         (object_files): Update.
10527         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10528         * guile/scm-pretty-print.c
10529         (ppscm_find_pretty_printer_from_objfiles): Update.
10530         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10531         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10532         Update.
10533         * python/py-progspace.c (pspy_get_objfiles): Update.
10534         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10535         Update.
10536         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10537         (objfpy_lookup_objfile_by_build_id): Update.
10538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10539         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10540         Update.
10541         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10542         (expand_symtab_containing_pc, lookup_objfile_from_block)
10543         (lookup_static_symbol, basic_lookup_transparent_type)
10544         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10545         (find_line_symtab, info_sources_command)
10546         (default_collect_symbol_completion_matches_break_on)
10547         (make_source_files_completion_list, find_main_name): Update.
10548         * symmisc.c (print_symbol_bcache_statistics)
10549         (print_objfile_statistics, maintenance_print_symbols)
10550         (maintenance_print_msymbols, maintenance_print_objfiles)
10551         (maintenance_info_symtabs, maintenance_check_symtabs)
10552         (maintenance_expand_symtabs, maintenance_info_line_tables):
10553         Update.
10554         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10555         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10556         (map_overlay_command, unmap_overlay_command)
10557         (simple_overlay_update, expand_symtabs_matching)
10558         (map_symbol_filenames): Update.
10559         * symfile-debug.c (set_debug_symfile): Update.
10560         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10561         Update.
10562         * source.c (select_source_symtab, forget_cached_source_info):
10563         Update.
10564         * solib.c (solib_read_symbols): Update.
10565         * solib-spu.c (append_ocl_sos): Update.
10566         * psymtab.c (maintenance_print_psymbols)
10567         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10568         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10569         * printcmd.c (info_symbol_command): Update.
10570         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10571         Update.
10572         * objfiles.h (class all_objfiles): Remove.
10573         * objfiles.c (have_partial_symbols, have_full_symbols)
10574         (have_minimal_symbols, qsort_cmp, update_section_map)
10575         (shared_objfile_contains_address_p)
10576         (default_iterate_over_objfiles_in_search_order): Update.
10577         * objc-lang.c (info_selectors_command, info_classes_command)
10578         (find_methods): Update.
10579         * minsyms.c (find_solib_trampoline_target): Update.
10580         * maint.c (maintenance_info_sections)
10581         (maintenance_translate_address, count_symtabs_and_blocks):
10582         Update.
10583         * main.c (captured_main_1): Update.
10584         * linux-thread-db.c (try_thread_db_load_from_pdir)
10585         (has_libpthread): Update.
10586         * linespec.c (iterate_over_all_matching_symtabs)
10587         (search_minsyms_for_name): Update.
10588         * jit.c (jit_find_objf_with_entry_addr): Update.
10589         * hppa-tdep.c (find_unwind_entry)
10590         (hppa_lookup_stub_minimal_symbol): Update.
10591         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10592         Update.
10593         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10594         (elf_gnu_ifunc_resolve_by_got): Update.
10595         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10596         * dwarf-index-write.c (save_gdb_index_command): Update.
10597         * cp-support.c (add_symbol_overload_list_qualified): Update.
10598         * breakpoint.c (create_overlay_event_breakpoint)
10599         (create_longjmp_master_breakpoint)
10600         (create_std_terminate_master_breakpoint)
10601         (create_exception_master_breakpoint): Update.
10602         * blockframe.c (find_pc_partial_function): Update.
10603         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10604         (ada_collect_symbol_completion_matches)
10605         (ada_add_global_exceptions): Update.
10606
10607 2019-01-17  Tom Tromey  <tom@tromey.com>
10608
10609         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10610         declare VEC.
10611         (solib_target_parse_libraries): Change return type.
10612         (library_list_start_segment, library_list_start_section)
10613         (library_list_end_library, library_list_start_library); Update.
10614         (solib_target_free_library_list): Remove.
10615         (solib_target_parse_libraries): Remove cleanup.  Change return
10616         type.
10617         (solib_target_current_sos): Update.
10618
10619 2019-01-17  Tom Tromey  <tromey@bapiya>
10620
10621         * valprint.c: Replace "the the" with "the".
10622         * symtab.c: Replace "the the" with "the".
10623         * solib.c: Replace "the the" with "the".
10624         * solib-dsbt.c: Replace "the the" with "the".
10625         * linespec.c: Replace "the the" with "the".
10626         * dwarf2loc.h: Replace "the the" with "the".
10627         * amd64-windows-tdep.c: Replace "the the" with "the".
10628         * aarch64-tdep.c: Replace "the the" with "the".
10629
10630 2019-01-16  Keith Seitz  <keiths@redhat.com>
10631
10632         PR gdb/23773
10633         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10634         <builder>: Rename to ..
10635         <m_builder>: ... this and make private.
10636         (dwarf2_cu::get_builder): New method.  Change all users of
10637         `builder' to use this method.
10638         (dwarf2_start_symtab): Move to ...
10639         (dwarf2_cu::start_symtab): ... here.  Update all callers
10640         (setup_type_unit_groups): Move to ...
10641         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10642         callers.
10643         (dwarf2_cu::reset_builder): New method.
10644         (process_full_compunit, process_full_type_unit): Use
10645         dwarf2_cu::reset_builder.
10646         (follow_die_offset): Record the ancestor CU if it is different
10647         from the followed DIE's CU.
10648         (follow_die_sig_1): Likewise.
10649
10650 2019-01-15  Tom Tromey  <tom@tromey.com>
10651
10652         * remote.c (class remote_state) <buf>: Now a char_vector.
10653         <buf_size>: Remove.
10654         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10655         parameter.
10656         (remote_target::getpkt_or_notif_sane_1)
10657         (remote_target::getpkt_sane)
10658         (remote_target::getpkt_or_notif_sane): Likewise.
10659         (class remote_target) <putpkt>: New overload.
10660         (remote_target::read_frame): Change type of "buf_p".  Remove
10661         sizeof_p parameter.
10662         (packet_ok): New overload.
10663         (packet_check_result): New overload.
10664         Update all uses.
10665
10666 2019-01-14  Tom Tromey  <tom@tromey.com>
10667
10668         * remote-notif.c (handle_notification, remote_notif_ack)
10669         (remote_notif_parse): Make "buf" const.
10670         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10671         const.
10672         (remote_notif_parse, remote_notif_ack, handle_notification):
10673         Likewise.
10674         * remote.c (remote_notif_stop_parse): Make "buf" const.
10675         (remote_target::remote_parse_stop_reply): Make "buf" const.
10676         (remote_notif_stop_ack): Make "buf" const.
10677
10678 2019-01-14  Tom Tromey  <tom@tromey.com>
10679
10680         * remote.c (remote_console_output): Make parameter const.
10681
10682 2019-01-14  Tom Tromey  <tom@tromey.com>
10683
10684         * target-debug.h (target_debug_print_signals): Constify.
10685         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10686         * procfs.c (procfs_target::pass_signals): Update.
10687         * linux-nat.c (linux_nat_target::pass_signals): Update.
10688         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10689         * target-delegates.c: Rebuild.
10690         * remote.c (remote_target::program_signals): Update.
10691         (remote_target::pass_signals): Update.
10692         * target.c (target_pass_signals): Constify argument.
10693         (target_program_signals): Likewise.
10694         * target.h (struct target_ops) <pass_signals, program_signals>:
10695         Constify argument.
10696         (target_pass_signals, target_program_signals): Constify argument.
10697
10698 2019-01-14  Tom Tromey  <tom@tromey.com>
10699
10700         PR tui/28819:
10701         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10702
10703 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10704
10705         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10706         field.
10707         * rs6000-tdep.c: Include reggroups.h.
10708         (IS_V_ALIAS_PSEUDOREG): Define.
10709         (rs6000_register_name): Return names for the "vX" aliases.
10710         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10711         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10712         aliases.  Call default_register_reggroup_p for all other
10713         pseudo-registers.
10714         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10715         New functions.
10716         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10717         Handle "vX" aliases.
10718         (v_alias_pseudo_register_collect): New function.
10719         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10720         (rs6000_gdbarch_init): Initialize "vX" aliases as
10721         pseudo-registers.  Restore registration of
10722         rs6000_pseudo_register_reggroup_p with
10723         set_tdesc_pseudo_register_reggroup_p.
10724
10725 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10726
10727         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10728         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10729         set_gdbarch_num_pseudo_regs.
10730
10731 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10732
10733         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10734         Remove arg prefixname, add do_set and do_show.
10735         Add member functions set_list and show_list.
10736         * cli/cli-style.c (class cli_style_option): Update accordingly.
10737         (style_set_list): Move to file scope.
10738         (style_show_list): Likewise.
10739         (set_style): Call help_list.
10740         (show_style): Call cmd_show_list.
10741         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10742         Update to use the new macro.
10743
10744 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10745
10746         * ada-lang.c (_initialize_ada_language): Expand the help text
10747         for the "catch exception" command.
10748
10749 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10750
10751         * symtab.c (matching_obj_sections): Initialize obj,
10752         declare it closer to its usage.
10753
10754 2019-01-10  Tom Tromey  <tom@tromey.com>
10755
10756         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10757         (basic_inf_threads_range): Remove.
10758         (inf_threads_range, inf_non_exited_threads_range)
10759         (safe_inf_threads_range): Use next_adapter.
10760
10761 2019-01-10  Keith Seitz  <keiths@redhat.com>
10762
10763         PR gdb/23712
10764         PR symtab/23010
10765         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10766         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10767
10768 2019-01-10  Keith Seitz  <keiths@redhat.com>
10769
10770         PR gdb/23712
10771         PR symtab/23010
10772         * dictionary.c (pending_to_vector): Remove.
10773         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10774         Remove _1 suffix, replacing functions of the same name.  Update
10775         all callers.
10776         (dict_create_hashed, dict_create_hashed_expandable)
10777         (dict_create_linear, dict_create_linear_expandable, dict_free)
10778         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10779         Make functions static.
10780
10781 2019-01-10  Keith Seitz  <keiths@redhat.com>
10782
10783         PR gdb/23712
10784         PR symtab/23010
10785         * dictionary.h (struct dictionary): Replace declaration with
10786         multidictionary.
10787         (dict_create_hashed, dict_create_hashed_expandable)
10788         (dict_create_linear, dict_create_linear_expandable)
10789         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10790         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10791         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10792         taking multidictionary argument.
10793         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10794         * block.h (struct block) <dict>: Change to multidictionary
10795         and rename `multidict'.
10796         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10797         symmisc.c: Update all dictionary references to multidictionary.
10798
10799 2019-01-10  Keith Seitz  <keiths@redhat.com>
10800
10801         PR gdb/23712
10802         PR symtab/23010
10803         * dictionary.c: Include unordered_map.
10804         (pending_to_vector): New function.
10805         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10806         Rewrite the non-"_1" functions to take vector instead
10807         of linked list.
10808         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10809         "new" _1 versions of the same name.
10810         (multidictionary): Define.
10811         (std::hash<enum language): New definition.
10812         (collate_pending_symbols_by_language, mdict_create_hashed)
10813         (mdict_create_hashed_expandable, mdict_create_linear)
10814         (mdict_create_linear_expandable, mdict_free)
10815         (find_language_dictionary, create_new_language_dictionary)
10816         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10817         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10818         (mdict_size, mdict_empty): New functions.
10819         * dictionary.h (mdict_iterator): Define.
10820
10821 2019-01-10  Pedro Alves  <palves@redhat.com>
10822
10823         * breakpoint.c (read_uploaded_action)
10824         (create_tracepoint_from_upload): Adjust to use
10825         gdb::unique_xmalloc_ptr.
10826         * ctf.c (ctf_write_uploaded_tp):
10827         (SET_ARRAY_FIELD): Use emplace_back.
10828         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10829         * tracefile-tfile.c (tfile_write_uploaded_tp):
10830         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10831         gdb::unique_xmalloc_ptr.
10832         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10833         at_string, cond_string, cmd_strings>: Replace char pointers
10834         with gdb::unique_xmalloc_ptr.
10835
10836 2019-01-10  Pedro Alves  <palves@redhat.com>
10837
10838         * solib-target.c (library_list_start_library): Don't xstrdup name.
10839
10840 2019-01-10  Pedro Alves  <palves@redhat.com>
10841
10842         * mdebugread.c (parse_partial_symbols): Use
10843         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10844
10845 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10846
10847         * linux-fork.c (scoped_switch_fork_info)
10848         <~scoped_switch_fork_info>: Fix incorrect variable name.
10849
10850 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10851
10852         * linux-fork.c (scoped_switch_fork_info)
10853         <scoped_switch_fork_info>: Make explicit.
10854         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10855
10856 2019-01-10  Tom Tromey  <tom@tromey.com>
10857
10858         * objfiles.h (objfile::reset_psymtabs): Update.
10859         * objfiles.c (objfile::objfile): Update.
10860         * psymtab.h (psymtab_storage::obstack): Update.
10861         (psymtab_storage::m_obstack): Use gdb::optional.
10862         (class psymtab_storage): Update comment.  Remove objfile
10863         parameter.
10864         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10865
10866 2019-01-10  Tom Tromey  <tom@tromey.com>
10867
10868         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10869         <free_psymtabs>: Now private.
10870         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10871         (allocate_psymtab): Use new method.
10872
10873 2019-01-10  Tom Tromey  <tom@tromey.com>
10874
10875         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10876         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10877         * mdebugread.c (parse_partial_symbols): Use
10878         allocate_dependencies.
10879         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10880         allocate_dependencies.
10881         (process_psymtab_comp_unit_reader)
10882         (build_type_psymtab_dependencies): Likewise.
10883         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10884
10885 2019-01-10  Tom Tromey  <tom@tromey.com>
10886
10887         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10888         PSYMBOL_SET_LANGUAGE.
10889         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10890
10891 2019-01-10  Tom Tromey  <tom@tromey.com>
10892
10893         * psymtab.h (psymtab_storage::obstack): New method.
10894         <m_obstack>: Rename from obstack; now private.
10895         * psymtab.c (psymtab_storage): Update.
10896         * dwarf2read.c (create_addrmap_from_index)
10897         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10898         Update.
10899
10900 2019-01-10  Tom Tromey  <tom@tromey.com>
10901
10902         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10903         * objfiles.h (objfile::reset_psymtabs): New method.
10904
10905 2019-01-10  Tom Tromey  <tom@tromey.com>
10906
10907         * symmisc.c (print_symbol_bcache_statistics): Update.
10908         (print_objfile_statistics): Update.
10909         * symfile.c (reread_symbols): Update.
10910         * psymtab.h (class psymtab_storage): New.
10911         * psymtab.c (psymtab_storage): New constructor.
10912         (~psymtab_storage): New destructor.
10913         (require_partial_symbols): Update.
10914         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10915         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10916         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10917         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10918         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10919         (start_psymtab_common, end_psymtab_common)
10920         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10921         (allocate_psymtab): Update.
10922         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10923         Update.
10924         (dump_psymtab_addrmap, maintenance_print_psymbols)
10925         (maintenance_check_psymtabs): Update.
10926         (class objfile_psymtabs): Move to objfiles.h.
10927         * psympriv.h (discard_psymtab): Now inline.
10928         (psymtab_discarder::psymtab_discarder): Update.
10929         (psymtab_discarder::~psymtab_discarder): Update.
10930         (ALL_OBJFILE_PSYMTABS): Rewrite.
10931         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10932         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10933         Remove fields.
10934         <partial_symtabs>: New field.
10935         (class objfile_psymtabs): Move from psymtab.h.  Update.
10936         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10937         psymbol_cache.
10938         (objfile::~objfile): Don't destroy psymbol_cache.
10939         * mdebugread.c (parse_partial_symbols): Update.
10940         * dwarf2read.c (create_addrmap_from_index)
10941         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10942         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10943         (add_partial_subprogram, dwarf2_ranges_read): Update.
10944         * dwarf-index-write.c (write_address_map)
10945         (write_one_signatured_type, recursively_write_psymbols)
10946         (class debug_names, class debug_names, write_psymtabs_to_index):
10947         Update.
10948
10949 2019-01-10  Tom Tromey  <tom@tromey.com>
10950
10951         * symtab.h (SYMBOL_SET_NAMES): Update.
10952         (symbol_set_names): Update.
10953         (MSYMBOL_SET_NAMES): Update.
10954         * symtab.c (symbol_set_names): Change argument to be an
10955         objfile_per_bfd_storage.
10956         * psymtab.c (add_psymbol_to_bcache): Update.
10957         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10958
10959 2019-01-10  Tom Tromey  <tom@tromey.com>
10960
10961         * symtab.c (create_demangled_names_hash): Change argument to be an
10962         objfile_per_bfd_storage.
10963         (symbol_set_names): Update.
10964
10965 2019-01-10  Tom Tromey  <tom@tromey.com>
10966
10967         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10968         init_psymbol_list.
10969         * psymtab.c (init_psymbol_list): Do nothing if already called.
10970         * psympriv.h (init_psymbol_list): Add comment.
10971         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10972         init_psymbol_list.
10973         * dbxread.c (dbx_symfile_read): Unconditionally call
10974         init_psymbol_list.
10975
10976 2019-01-10  Tom Tromey  <tom@tromey.com>
10977
10978         * xcoffread.c (scan_xcoff_symtab): Update.
10979         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10980         "where".
10981         * mdebugread.c (parse_partial_symbols)
10982         (handle_psymbol_enumerators): Update.
10983         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10984         * dbxread.c (read_dbx_symtab): Update.
10985         * psympriv.h (psymbol_placement): New enum.
10986         (add_psymbol_to_list): Update.
10987
10988 2019-01-10  Tom Tromey  <tom@tromey.com>
10989
10990         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10991         static_psymbols parameters.
10992         (scan_xcoff_symtab): Update.
10993         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10994         static_psymbols parameters.
10995         * psympriv.h (start_psymtab_common): Update.
10996         * mdebugread.c (parse_partial_symbols): Update.
10997         * dwarf2read.c (create_partial_symtab): Update.
10998         * dbxread.c (read_dbx_symtab): Update.
10999         (start_psymtab): Remove global_psymbols and static_psymbols
11000         parameters.
11001
11002 2019-01-10  Tom Tromey  <tom@tromey.com>
11003
11004         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11005         * psymtab.c (allocate_psymtab): Add comment.
11006         * psympriv.h (allocate_psymtab): Add comment.
11007         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11008         initializations.
11009         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11010
11011 2019-01-10  Tom Tromey  <tom@tromey.com>
11012
11013         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11014         Don't declare.
11015         * mipsread.c: Include mdebugread.h.
11016         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11017         Declare.
11018         * elfread.c: Include mdebugread.h.
11019
11020 2019-01-09  Tom Tromey  <tom@tromey.com>
11021
11022         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11023         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11024         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11025         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11026         (psym_lookup_symbol, psym_find_last_source_symtab)
11027         (psym_forget_cached_source_info, psym_print_stats)
11028         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11029         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11030         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11031         (psym_find_compunit_symtab_by_address)
11032         (maintenance_print_psymbols, maintenance_info_psymtabs)
11033         (maintenance_check_psymtabs): Use ranged for.
11034         * psymtab.h (class objfile_psymtabs): New.
11035         (require_partial_symbols): Return objfile_psymtabs.
11036         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11037
11038 2019-01-09  Tom Tromey  <tom@tromey.com>
11039
11040         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11041         (find_pc_mapped_section, list_overlays_command)
11042         (map_overlay_command, unmap_overlay_command)
11043         (simple_overlay_update): Use all_objfiles.
11044         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11045         * printcmd.c (info_symbol_command): Use all_objfiles.
11046         * objfiles.h (ALL_OBJSECTIONS): Remove.
11047         * maint.c (maintenance_translate_address): Use all_objfiles.
11048         * gcore.c (gcore_create_callback): Use all_objfiles.
11049         (objfile_find_memory_regions): Likewise.
11050
11051 2019-01-09  Tom Tromey  <tom@tromey.com>
11052
11053         * symtab.c (find_line_symtab, info_sources_command)
11054         (make_source_files_completion_list): Use objfile_compunits.
11055         * source.c (select_source_symtab): Use objfile_compunits.
11056         * objfiles.h (struct objfile): Update comment.
11057         (ALL_OBJFILES): Remove.
11058         (ALL_FILETABS): Remove.
11059         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11060         objfile_compunits.
11061
11062 2019-01-09  Tom Tromey  <tom@tromey.com>
11063
11064         * symmisc.c (print_objfile_statistics, dump_objfile)
11065         (maintenance_print_symbols): Use compunit_filetabs.
11066         * source.c (forget_cached_source_info_for_objfile): Use
11067         compunit_filetabs.
11068         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11069         (ALL_FILETABS): Use compunit_filetabs.
11070         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11071         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11072
11073 2019-01-09  Tom Tromey  <tom@tromey.com>
11074
11075         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11076         (compunit_filetabs): New.
11077         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11078         compunit_filetabs.
11079         (info_sources_command, make_source_files_completion_list): Remove
11080         declaration.
11081         * symmisc.c (print_objfile_statistics, dump_objfile)
11082         (maintenance_print_symbols): Remove declaration.
11083         (maintenance_info_symtabs): Use compunit_filetabs.
11084         (maintenance_info_line_tables): Likewise.
11085         * source.c (select_source_symtab): Change local variable name.
11086         (forget_cached_source_info_for_objfile): Remove declaration.
11087         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11088         * objfiles.c (objfile_relocate1): Remove declaration.
11089         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11090         declaration.
11091         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11092         * coffread.c (coff_symtab_read): Remove declaration.
11093         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11094         compunit_filetabs.
11095
11096 2019-01-09  Tom Tromey  <tom@tromey.com>
11097
11098         * symtab.c (lookup_objfile_from_block)
11099         (find_pc_sect_compunit_symtab, search_symbols)
11100         (default_collect_symbol_completion_matches_break_on): Use
11101         objfile_compunits.
11102         * objfiles.h (ALL_COMPUNITS): Remove.
11103         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11104         * cp-support.c (add_symbol_overload_list_qualified): Use
11105         objfile_compunits.
11106         * ada-lang.c (ada_collect_symbol_completion_matches)
11107         (ada_add_global_exceptions): Use objfile_compunits.
11108
11109 2019-01-09  Tom Tromey  <tom@tromey.com>
11110
11111         * source.c (select_source_symtab)
11112         (forget_cached_source_info_for_objfile): Remove declaration.
11113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11114         declaration.
11115         * maint.c (count_symtabs_and_blocks): Remove declaration.
11116         * cp-support.c (add_symbol_overload_list_qualified): Remove
11117         declaration.
11118         * coffread.c (coff_symtab_read): Remove declaration.
11119         * symtab.c (lookup_symbol_in_objfile_symtabs)
11120         (basic_lookup_transparent_type_1): Use objfile_compunits.
11121         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11122         (info_sources_command, search_symbols)
11123         (default_collect_symbol_completion_matches_break_on)
11124         (make_source_files_completion_list): Remove declaration.
11125         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11126         (ada_collect_symbol_completion_matches)
11127         (ada_add_global_exceptions): Remove declaration.
11128         * linespec.c (iterate_over_all_matching_symtabs): Use
11129         objfile_compunits.
11130         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11131         (class objfile_compunits): New.
11132         (ALL_COMPUNITS): Use objfile_compunits.
11133         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11134         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11135         objfile_compunits.
11136         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11137
11138 2019-01-09  Tom Tromey  <tom@tromey.com>
11139
11140         * symtab.c (search_symbols)
11141         (default_collect_symbol_completion_matches_break_on): Use
11142         objfile_msymbols.
11143         * ada-lang.c (ada_lookup_simple_minsym)
11144         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11145         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11146         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11147         objfile_msymbols.
11148         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11149         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11150         * objc-lang.c (find_methods): Use objfile_msymbols.
11151         (info_selectors_command, info_classes_command): Likewise.
11152         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11153         * objfiles.h (class objfile_msymbols): New.
11154         (ALL_OBJFILE_MSYMBOLS): Remove.
11155         (ALL_MSYMBOLS): Remove.
11156
11157 2019-01-09  Tom Tromey  <tom@tromey.com>
11158
11159         * common/next-iterator.h (next_adapter): Add Iterator template
11160         parameter.
11161         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11162         (class all_objfiles_safe): New.
11163         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11164         * objfiles.c (put_objfile_before): Update comment.
11165         (add_separate_debug_objfile): Likewise.
11166         (free_all_objfiles): Use all_objfiles_safe.
11167         (objfile_purge_solibs): Likewise.
11168
11169 2019-01-09  Tom Tromey  <tom@tromey.com>
11170
11171         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11172         (expand_symtab_containing_pc, lookup_static_symbol)
11173         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11174         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11175         all_objfiles.
11176         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11177         * breakpoint.c (create_overlay_event_breakpoint)
11178         (create_longjmp_master_breakpoint)
11179         (create_std_terminate_master_breakpoint)
11180         (create_exception_master_breakpoint): Use all_objfiles.
11181         * linux-thread-db.c (try_thread_db_load_from_pdir)
11182         (has_libpthread): Use all_objfiles.
11183         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11184         * linespec.c (iterate_over_all_matching_symtabs)
11185         (search_minsyms_for_name): Use all_objfiles.
11186         * maint.c (maintenance_info_sections): Use all_objfiles.
11187         * main.c (captured_main_1): Use all_objfiles.
11188         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11189         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11190         * guile/scm-pretty-print.c
11191         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11192         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11193         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11194         (maintenance_print_msymbols): Use all_objfiles.
11195         * source.c (select_source_symtab): Use all_objfiles.
11196         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11197         * symfile.c (remove_symbol_file_command)
11198         (expand_symtabs_matching, map_symbol_filenames): Use
11199         all_objfiles.
11200         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11201         all_objfiles.
11202         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11203         * objc-lang.c (find_methods): Use all_objfiles.
11204         * objfiles.c (have_partial_symbols, have_full_symbols)
11205         (have_minimal_symbols, qsort_cmp)
11206         (default_iterate_over_objfiles_in_search_order): Use
11207         all_objfiles.
11208         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11209         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11210         (maintenance_check_psymtabs): Use all_objfiles.
11211         (ALL_PSYMTABS): Remove.
11212         * compile/compile-object-run.c (do_module_cleanup): Use
11213         all_objfiles.
11214         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11215         * cp-support.c (add_symbol_overload_list_qualified): Use
11216         all_objfiles.
11217         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11218         Use all_objfiles.
11219         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11220         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11221         all_objfiles.
11222         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11223         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11224         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11225         Uses all_objfiles.
11226         * solib.c (solib_read_symbols): Use all_objfiles
11227
11228 2019-01-09  Tom Tromey  <tom@tromey.com>
11229
11230         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11231         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11232         all_objfiles.
11233         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11234         * symmisc.c (print_symbol_bcache_statistics)
11235         (print_objfile_statistics, maintenance_print_objfiles)
11236         (maintenance_info_symtabs, maintenance_check_symtabs)
11237         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11238         all_objfiles.
11239         * source.c (forget_cached_source_info): Use all_objfiles.
11240         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11241         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11242         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11243         * objfiles.c (update_section_map): Use all_objfiles.
11244         (shared_objfile_contains_address_p): Likewise.
11245         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11246         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11247
11248 2019-01-09  Tom Tromey  <tom@tromey.com>
11249
11250         * common/next-iterator.h: New file.
11251         * objfiles.h (class all_objfiles): New.
11252         (struct objfile_iterator): New.
11253
11254 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11255
11256         * NEWS: Move the description of the changed "frame", "select-frame",
11257          and "info frame" commands to the Changed commands section.
11258
11259 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11260
11261         * gdbtypes.c (check_stub_method_group): Remove handling of old
11262         mangling schemes.
11263         * linespec.c (find_methods): Likewise.
11264         * stabsread.c (read_member_functions): Likewise.
11265         * valops.c (search_struct_method): Likewise.
11266         (value_struct_elt_for_reference): Likewise.
11267         * NEWS: Mention this change.
11268
11269 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11270
11271         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11272         print_source_lines.
11273         * source.c (print_source_lines_base): Update line number check.
11274         (print_source_lines): New function.
11275         (source_lines_range::source_lines_range): New function.
11276         * source.h (class source_lines_range): New class.
11277         (print_source_lines): New declaration.
11278
11279 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11280
11281         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11282
11283 2019-01-08  Tom Tromey  <tom@tromey.com>
11284             Simon Marchi  <simon.marchi@ericsson.com>
11285
11286         PR gdb/24060
11287         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11288         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11289         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11290         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11291         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11292         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11293
11294 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11295
11296         * source.c (select_source_symtab): Move header comment to
11297         declaration in source.h.
11298         (forget_cached_source_info_for_objfile): Likewise.
11299         (forget_cached_source_info): Likewise.
11300         (identify_source_line): Likewise.
11301         * source.h (identify_source_line): Move declaration from symtab.h
11302         and add comment from source.c
11303         (print_source_lines): Likewise.
11304         (forget_cached_source_info_for_objfile): Likewise.
11305         (forget_cached_source_info): Likewise.
11306         (select_source_symtab): Likewise.
11307         (enum print_source_lines_flag): Move definition from symtab.h.
11308         * symtab.h (identify_source_line): Move declaration to source.h.
11309         (print_source_lines): Likewise.
11310         (forget_cached_source_info_for_objfile): Likewise.
11311         (forget_cached_source_info): Likewise.
11312         (select_source_symtab): Likewise.
11313         (enum print_source_lines_flag): Move definition to source.h.
11314         * tui/tui-hooks.c: Add 'source.h' include.
11315
11316 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * source.c (print_source_lines_base): Handle requests to print
11319         reverse line number sequences, and guard against empty lines
11320         string.
11321
11322 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11323
11324         * source.c (print_source_lines_base): Fix skip of '\r' if next
11325         character is '\n'.
11326
11327 2019-01-06  Tom Tromey  <tom@tromey.com>
11328
11329         * c-exp.y (struct c_parse_state) <macro_original_text,
11330         expansion_obstack>: New member.
11331         (macro_original_text, expansion_obstack): Remove globals.
11332         (scan_macro_expansion, scanning_macro_expansion)
11333         (finished_macro_expansion): Update.
11334         (scan_macro_cleanup): Remove.
11335         (yylex, c_parse): Update.
11336
11337 2019-01-06  Tom Tromey  <tom@tromey.com>
11338
11339         * c-exp.y (struct c_parse_state) <strings>: New member.
11340         (operator_stoken): Update.
11341
11342 2019-01-06  Tom Tromey  <tom@tromey.com>
11343
11344         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11345         (union type_stack_elt) <typelist_val>: Now a pointer to
11346         std::vector.
11347         (type_stack_cleanup): Don't declare.
11348         (push_typelist): Update.
11349         * parse.c (pop_typelist): Return a std::vector.
11350         (push_typelist): Take a std::vector.
11351         (follow_types): Update.  Do not free args.
11352         (type_stack_cleanup): Remove.
11353         * c-exp.y (struct c_parse_state): New.
11354         (cpstate): New global.
11355         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11356         (nonempty_typelist): Update.
11357         (func_mod): Create a new vector.
11358         (c_parse): Create a c_parse_state.
11359         (check_parameter_typelist): Do not delete params.
11360         (function_method): Update.  Do not delete type_list.
11361
11362 2019-01-06  Tom Tromey  <tom@tromey.com>
11363
11364         PR gdb/28155:
11365         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11366         check_typedef.
11367         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11368         (print_return_value): Likewise.
11369
11370 2019-01-05  Tom Tromey  <tom@tromey.com>
11371
11372         * contrib/cleanup_check.py: Remove.
11373         * contrib/gcc-with-excheck: Remove.
11374         * contrib/exsummary.py: Remove.
11375         * contrib/excheck.py: Remove.
11376
11377 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11378
11379         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11380         NULL. Initialize tpprev to NULL instead of assigning it
11381         to NULL on the next statement.
11382         * windows-nat.c (windows_delete_thread): Remove check for
11383         main_thread_id before printing thread exit notifications.
11384         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11385         Remove thread ID check against main_thread_id.
11386         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11387         windows_delete_thread.
11388         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11389
11390 2019-01-04  Tom Tromey  <tom@tromey.com>
11391
11392         * compile/compile.c (_initialize_compile): Use upper case for
11393         metasyntactic variables.
11394         * symmisc.c (_initialize_symmisc): Use upper case for
11395         metasyntactic variables.
11396         * psymtab.c (_initialize_psymtab): Use upper case for
11397         metasyntactic variables.
11398         * demangle.c (demangle_command): Use upper case for metasyntactic
11399         variables.
11400         (_initialize_demangler): Likewise.
11401         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11402         variables.
11403
11404 2019-01-03  Tom Tromey  <tom@tromey.com>
11405
11406         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11407
11408 2019-01-03  Tom Tromey  <tom@tromey.com>
11409
11410         * python/py-symtab.c (salpy_str): Update.
11411         (struct salpy_sal_object) <symtab>: Now a PyObject.
11412         (salpy_dealloc): Update.
11413         (del_objfile_sal): Use gdbpy_ref.
11414
11415 2019-01-03  Tom Tromey  <tom@tromey.com>
11416
11417         * python/py-type.c (convert_field): Use new_reference.  Return
11418         gdbpy_ref.
11419         (make_fielditem): Return gdbpy_ref.
11420         (typy_fields): Update.
11421         (typy_getitem): Update.
11422         (field_name): Return gdbpy_ref.  Use new_reference.
11423         (typy_iterator_iternext): Update.
11424
11425 2019-01-03  Tom Tromey  <tom@tromey.com>
11426
11427         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11428
11429 2019-01-03  Tom Tromey  <tom@tromey.com>
11430
11431         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11432         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11433         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11434         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11435         (pspy_set_type_printers): Likewise.
11436         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11437         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11438         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11439         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11440         (objfpy_set_type_printers): Likewise.
11441
11442 2019-01-03  Tom Tromey  <tom@tromey.com>
11443
11444         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11445         (gdbpy_print_stack): Use gdbpy_err_fetch.
11446         * python/python-internal.h (class gdbpy_err_fetch): New class.
11447         (class gdbpy_enter) <m_error_type, m_error_value,
11448         m_error_traceback>: Remove.
11449         <m_error>: New member.
11450         (gdbpy_exception_to_string): Don't declare.
11451         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11452         * python/py-value.c (convert_value_from_python): Use
11453         gdbpy_err_fetch.
11454         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11455         gdbpy_exception_to_string.
11456         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11457         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11458         gdbpy_err_fetch.
11459
11460 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11461
11462         * linux-nat.c (delete_lwp_cleanup): Delete.
11463         (struct lwp_deleter): New struct.
11464         (lwp_info_up): New typedef.
11465         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11466         lwp_info_up.
11467
11468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * linux-fork.c (class scoped_switch_fork_info): New class.
11471         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11472
11473 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * valops.c (find_overload_match): Remove use of null_cleanup, and
11476         calls to do_cleanups.
11477
11478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11479
11480         * compile/compile-cplus-types.c
11481         (compile_cplus_instance::decl_name): Handle changes to
11482         cp_func_name.
11483         * cp-support.c (cp_func_name): Update header comment, update
11484         return type.
11485         * cp-support.h (cp_func_name): Update return type in declaration.
11486         * valops.c (find_overload_match): Move temp_func local to top
11487         level of function and change its type.  Use temp_func to hold and
11488         delete temporary string obtained from cp_func_name.
11489
11490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11493         gdb::char_vector, remove cleanup, and update uses of `msg`.
11494
11495 2019-01-03  Jim Wilson  <jimw@sifive.com>
11496
11497         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11498
11499 2019-01-02  Tom Tromey  <tom@tromey.com>
11500
11501         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11502         (tdesc_parse_xml): Remove cleanups.
11503         * target-descriptions.h (make_cleanup_free_target_description):
11504         Don't declare.
11505         (target_desc_deleter): New struct.
11506         (target_desc_up): New typedef.
11507         * target-descriptions.c (target_desc_deleter::operator()): Rename
11508         from free_target_description.
11509         (make_cleanup_free_target_description): Remove.
11510
11511 2019-01-02  Tom Tromey  <tom@tromey.com>
11512
11513         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11514         constructor, destructor.
11515         (linespec_parser): Remove typedef.
11516         (~linespec_parser): Rename from linespec_parser_delete.
11517         (linespec_lex_to_end, linespec_complete_label)
11518         (linespec_complete): Update.
11519         (decode_line_full): Remove cleanups.
11520         (decode_line_1): Update.
11521
11522 2019-01-02  Tom Tromey  <tom@tromey.com>
11523
11524         * python/python-internal.h (inferior_to_inferior_object): Change
11525         return type.
11526         * python/py-exitedevent.c (create_exited_event_object): Update.
11527         * python/py-inferior.c (inferior_to_inferior_object): Return
11528         gdbpy_ref.
11529         (python_new_inferior, python_inferior_deleted)
11530         (thread_to_thread_object, delete_thread_object)
11531         (build_inferior_list, gdbpy_selected_inferior): Update.
11532         * python/py-infthread.c (create_thread_object): Update.  Also fail
11533         if inferior_to_inferior_object fails.
11534
11535 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11536
11537         * inferior.h (class inferior) <displaced_step_state>: New field.
11538         * infrun.h (struct displaced_step_state): Move here from
11539         infrun.c.  Initialize fields, add constructor.
11540         <inf>: Remove field.
11541         <reset>: New method.
11542         * infrun.c (struct displaced_step_inferior_state): Move to
11543         infrun.h.
11544         (displaced_step_inferior_states): Remove.
11545         (get_displaced_stepping_state): Adust.
11546         (displaced_step_in_progress_any_inferior): Adjust.
11547         (displaced_step_in_progress_thread): Adjust.
11548         (displaced_step_in_progress): Adjust.
11549         (add_displaced_stepping_state): Remove.
11550         (get_displaced_step_closure_by_addr): Adjust.
11551         (remove_displaced_stepping_state): Remove.
11552         (infrun_inferior_exit): Call displaced_step_state.reset.
11553         (use_displaced_stepping): Don't check for NULL.
11554         (displaced_step_prepare_throw): Call
11555         get_displaced_stepping_state.
11556         (displaced_step_fixup): Don't check for NULL.
11557         (prepare_for_detach): Don't check for NULL.
11558
11559 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11560
11561         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11562          in case of call that did not complete.
11563
11564 2019-01-02  Andrey Utkin  <autkin@undo.io>
11565
11566         * symfile.c (find_separate_debug_file): Fix search of debug files for
11567         remote debuggee.
11568
11569 2019-01-02  Tom Tromey  <tom@tromey.com>
11570
11571         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11572         indentation.
11573         * python/py-frame.c (frapy_older): Remove cast.
11574         (frapy_newer): Likewise.
11575         * python/py-breakpoint.c (local_setattro): Remove cast.
11576         * python/py-arch.c (archpy_name): Remove local variable.
11577         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11578
11579 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11580
11581         * unittests/basic_string_view/element_access/char/empty.cc:
11582         Fix year range in copyright header.
11583
11584 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11585
11586         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11587         Delete.
11588         <operator==>: Update with for removed field.
11589         <hash>: Likewise.
11590         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11591         <isa_features>: ...this.
11592         <abi_features>: New field.
11593         (riscv_isa_flen): Update comment.
11594         (riscv_abi_xlen): New declaration.
11595         (riscv_abi_flen): New declaration.
11596         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11597         isa_features.
11598         (riscv_abi_xlen): New function.
11599         (riscv_isa_flen): Update to get answer from isa_features.
11600         (riscv_abi_flen): New function.
11601         (riscv_has_fp_abi): Update to get answer from abi_features.
11602         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11603         xlen and flen.
11604         (riscv_call_info) <xlen, flen>: Update comment.
11605         (riscv_call_arg_struct): Remove invalid assertions
11606         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11607         is removed.
11608         (riscv_gdbarch_init): Gather isa features and abi features
11609         separately, ensure both match on the gdbarch when reusing an old
11610         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11611         a target with 64-bit float hardware.
11612
11613 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11614
11615         * source.c (search_command_helper): Stop reverse search
11616         when line 1 has been searched.
11617
11618 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11619
11620         * record-full.c (record_full_base_target::close): Rewrite
11621         record_full_core_buf_list free logic.
11622
11623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11624
11625         * break-catch-syscall.c (print_one_catch_syscall): xfree
11626         the last text.
11627
11628 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11629
11630         * top.c (print_gdb_version): Update Copyright year in version
11631         message.
11632
11633 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11634
11635         Update copyright year range in all GDB files.
11636
11637 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11638
11639         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11640
11641 For older changes see ChangeLog-2018.
11642 \f
11643 Local Variables:
11644 mode: change-log
11645 left-margin: 8
11646 fill-column: 74
11647 version-control: never
11648 coding: utf-8
11649 End:
11650