gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
   4         line_from_reg_element_no, first_reg_element_no_inline,
   5         display_all_data, delete_data_content_windows,
   6         erase_data_content>: Now private.
   7
   8 2019-08-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  11         (tui_unhighlight_win, tui_highlight_win)
  12         (tui_win_info::make_window): Update.
  13         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  14
  15 2019-08-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  18         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  19         (MAX_PID_WIDTH): Move to tui-stack.c.
  20         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  21         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  22         (MAX_PID_WIDTH): Move from tui-data.h.
  23
  24 2019-08-20  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  27         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  28         (box_win): Update.
  29         (tui_gen_win_info::make_window): Rename from tui_make_window.
  30         (tui_win_info::make_window): New method.
  31         (tui_gen_win_info::make_visible): Update.
  32         * tui/tui-source.c (tui_source_window::set_contents): Update.
  33         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  34         (tui_data_window::display_registers_from): Update.
  35         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  36         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  37         Declare.
  38         <can_box>: Remove.
  39         <title>: Remove.
  40         (struct tui_win_info) <make_window>: Declare.
  41         <can_box>: Now virtual.
  42         <title>: New member.
  43         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  44         * tui/tui-command.c (tui_cmd_window::resize): Update.
  45
  46 2019-08-20  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  49         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  50         (tui_data_window::check_register_values): Update.
  51
  52 2019-08-20  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-regs.h (struct tui_data_window): Use
  55         DISABLE_COPY_AND_ASSIGN.
  56         <regs_content>: Change type, removing unique_ptr.
  57         <tui_data_window>: Add move constructor.
  58         * tui/tui-regs.c (tui_data_window::show_registers)
  59         (tui_data_window::show_register_group)
  60         (tui_data_window::display_registers_from)
  61         (tui_data_window::display_registers_from)
  62         (tui_data_window::first_data_item_displayed)
  63         (tui_data_window::delete_data_content_windows)
  64         (tui_data_window::rerender, tui_data_window::refresh_window)
  65         (tui_data_window::check_register_values): Update.
  66
  67 2019-08-20  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  70         show_register_group>: Declare.
  71         (tui_show_register_group): Don't declare.
  72         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  73         tui_show_registers.
  74         (tui_data_window::show_register_group): Rename from
  75         tui_show_register_group.
  76         (tui_data_window::check_register_values, tui_reg_command):
  77         Update.
  78         * tui/tui-layout.c (tui_set_layout): Update.
  79
  80 2019-08-20  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  83         Declare.
  84         (tui_check_register_values): Don't declare.
  85         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  86         from tui_check_register_values.
  87         * tui/tui-hooks.c (tui_register_changed): Update.
  88
  89 2019-08-20  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-regs.c (tui_reg_layout): Move later.
  92         (tui_show_registers): Don't enable TUI mode or change layout.
  93
  94 2019-08-20  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-regs.h (struct tui_data_item_window)
  97         <~tui_data_item_window>: Remove.
  98         <content>: Now a unique_xmalloc_ptr.
  99         * tui/tui-regs.c (tui_register_format): Return a
 100         unique_xmalloc_ptr.
 101         (tui_get_register): Update.
 102         (~tui_data_item_window): Remove.
 103         (tui_data_window::display_registers_from, tui_display_register):
 104         Update.
 105         * tui/tui-io.h (tui_expand_tabs): Update.
 106         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 107         Remove "col" parameter.
 108
 109 2019-08-20  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 112         field.
 113         * tui/tui-regs.c (~tui_data_item_window): Update.
 114
 115 2019-08-20  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 118         earlier.
 119
 120 2019-08-20  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 123
 124 2019-08-20  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-source.h (struct tui_source_window): Update.
 127         * tui/tui-regs.c (tui_show_registers): Update.
 128         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 129         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 130         (NO_REGS_STRING): Remove defines.
 131
 132 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 133
 134         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 135         unnecessary thread walk if remote doesn't support the packet.
 136
 137 2019-08-19  Tom Tromey  <tromey@adacore.com>
 138
 139         * python/py-value.c (value_has_field): Fix indentation.
 140
 141 2019-08-19  Tom Tromey  <tromey@adacore.com>
 142
 143         * printcmd.c (do_one_display, info_display_command): Update.
 144         * block.h (contained_in): Return bool.  Add allow_nested
 145         parameter.
 146         * block.c (contained_in): Return bool.  Add allow_nested
 147         parameter.
 148
 149 2019-08-19  Tom Tromey  <tom@tromey.com>
 150
 151         * configure: Rebuild.
 152         * configure.ac: Disallow the combination of -static-libstdc++ and
 153         source highlight.
 154         * source-cache.c (get_language_name): Handle rust.
 155         (source_cache::get_source_lines): Ignore highlighting exceptions.
 156
 157 2019-08-16  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 160         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 161         (struct tui_source_window_base) <make_visible, refresh_window,
 162         resize>: Remove methods.
 163         <execution_info>: Remove field.
 164         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 165         (tui_show_source_line, tui_source_window_base)
 166         (~tui_source_window_base): Update.
 167         (tui_source_window_base::resize)
 168         (tui_source_window_base::make_visible)
 169         (tui_source_window_base::refresh_window): Remove.
 170         (tui_source_window_base::update_exec_info): Update.
 171         * tui/tui-source.c (tui_source_window::set_contents): Update.
 172         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 173
 174 2019-08-16  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 177         deprecated_query_hook.
 178
 179 2019-08-16  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 182         (tui_update_source_windows_with_line): Update.
 183         * tui/tui-source.h (struct tui_source_window)
 184         <show_symtab_source>: Declare.
 185         (tui_show_symtab_source): Don't declare.
 186         * tui/tui-source.c (tui_show_symtab_source): Rename from
 187         tui_show_symtab_source.
 188
 189 2019-08-16  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-winsource.h (struct tui_source_window_base)
 192         <set_contents>: Declare.
 193         * tui/tui-winsource.c
 194         (tui_source_window_base::update_source_window_as_is): Update.
 195         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 196         Declare.
 197         (tui_set_source_content): Don't declare.
 198         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 199         tui_set_source_content.
 200         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 201         Declare.
 202         (tui_set_disassem_content): Don't declare.
 203         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 204         tui_set_disassem_content.
 205
 206 2019-08-16  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-winsource.h (struct tui_source_window_base)
 209         <update_breakpoint_info>: Declare.
 210         (tui_update_breakpoint_info): Don't declare.
 211         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 212         (tui_update_all_breakpoint_info): Update.
 213         (tui_source_window_base::update_breakpoint_info): Rename from
 214         tui_update_breakpoint_info.
 215         (tui_source_window_base::update_exec_info): Update.
 216
 217 2019-08-16  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.h (struct tui_source_window_base)
 220         <update_source_window>: Declare.
 221         (tui_update_source_window): Don't declare.
 222         * tui/tui-winsource.c
 223         (tui_source_window_base::update_source_window): Rename from
 224         tui_update_source_window.
 225         (tui_source_window_base::rerender): Update.
 226         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 227         * tui/tui-disasm.c (tui_show_disassem)
 228         (tui_show_disassem_and_update_source)
 229         (tui_disasm_window::maybe_update): Update.
 230
 231 2019-08-16  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.h (struct tui_source_window_base)
 234         <update_source_window_as_is>: Declare.
 235         (tui_update_source_window_as_is): Don't declare.
 236         * tui/tui-winsource.c (tui_update_source_window): Update
 237         (tui_source_window_base::update_source_window_as_is): Rename from
 238         tui_update_source_window_as_is.
 239         (tui_source_window_base::refill): Update.
 240         * tui/tui-source.c (tui_show_symtab_source): Update.
 241         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 242         Update.
 243
 244 2019-08-16  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-winsource.h (tui_update_source_window)
 247         (tui_update_source_window_as_is): Remove "noerror" parameter.
 248         * tui/tui-winsource.c (tui_update_source_window)
 249         (tui_update_source_window_as_is): Remove "noerror" parameter.
 250         (tui_update_source_windows_with_addr)
 251         (tui_update_source_windows_with_line)
 252         (tui_source_window_base::rerender)
 253         (tui_source_window_base::refill): Update.
 254         * tui/tui-source.h (tui_set_source_content)
 255         (tui_show_symtab_source): Remove "noerror" parameter.
 256         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 257         parameter.
 258         (tui_show_symtab_source): Likewise.
 259         (tui_source_window::maybe_update): Update.
 260         * tui/tui-disasm.c (tui_show_disassem)
 261         (tui_show_disassem_and_update_source)
 262         (tui_disasm_window::do_scroll_vertical)
 263         (tui_disasm_window::maybe_update): Update.
 264
 265 2019-08-16  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui.c (tui_is_window_visible): Update.
 268         * tui/tui-wingeneral.c (tui_make_window)
 269         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 270         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 271         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 272         (tui_set_win_height_command, parse_scrolling_args): Update.
 273         * tui/tui-source.c (tui_source_window::style_changed): Update.
 274         * tui/tui-regs.c (tui_show_registers)
 275         (tui_data_window::first_data_item_displayed)
 276         (tui_data_window::delete_data_content_windows)
 277         (tui_check_register_values, tui_reg_command): Update.
 278         * tui/tui-disasm.c (tui_show_disassem): Update.
 279         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 280         method.
 281         <is_visible>: Remove field.
 282         * tui/tui-data.c (tui_next_win, tui_prev_win)
 283         (tui_delete_invisible_windows): Update.
 284
 285 2019-08-16  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-winsource.h (struct tui_source_window_base)
 288         <m_has_locator>: Remove.
 289         * tui/tui-layout.c (show_source_disasm_command, show_data)
 290         (show_source_or_disasm_and_command): Update.
 291
 292 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * NEWS (Other MI changes): New subsection.
 295         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 296         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 297         * arch-utils.c (default_get_pc_address_flags): New function.
 298         * arch-utils.h (default_get_pc_address_flags): New declaration.
 299         * gdbarch.sh: Add get_pc_address_flags.
 300         * gdbarch.c: Regenerate.
 301         * gdbarch.h: Likewise.
 302         * stack.c (print_pc): New function.
 303         (print_frame_info) (print_frame): Call print_pc.
 304
 305 2019-08-16  Tom de Vries  <tdevries@suse.de>
 306
 307         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 308         print_objfile_section_info.
 309
 310 2019-08-15  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 313         calling update_cmdwin_start_line.
 314         * tui/tui-winsource.h (struct tui_source_window_base)
 315         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 316         <rerender>: Declare.
 317         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 318         Call rerender.
 319         (tui_source_window_base::set_new_height): Remove.
 320         (tui_source_window_base::rerender): Rename from
 321         do_make_visible_with_new_height.
 322         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 323         resize method.
 324         (tui_win_info::make_invisible_and_set_new_height)
 325         (tui_win_info::make_visible_with_new_height): Remove.
 326         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 327         Declare.
 328         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 329         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 330         do_make_visible_with_new_height>: Don't declare.
 331         <rerender>: Declare.
 332         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 333         set_new_height.
 334         (tui_data_window::do_make_visible_with_new_height): Remove.
 335         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 336         call tui_show_locator_content.
 337         (tui_gen_win_info::resize): Call rerender.
 338         (show_source_or_disasm_and_command): Don't call
 339         tui_show_locator_content.
 340         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 341         method.
 342         (struct tui_win_info) <rerender>: Declare.
 343         <set_new_height, make_invisible_and_set_new_height,
 344         make_visible_with_new_height>: Don't declare.
 345         * tui/tui-data.c (tui_win_list::rerender): New method.
 346         * tui/tui-command.h (struct tui_cmd_window)
 347         <do_make_visible_with_new_height>: Don't declare.
 348         * tui/tui-command.c
 349         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 350
 351 2019-08-15  Tom Tromey  <tromey@adacore.com>
 352
 353         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 354         * ada-lang.c (ada_enum_name): Likewise.
 355
 356 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 357
 358         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 359         leading underscore.
 360         (GdbOutputErrorFile): Likewise.
 361         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 362         accordingly.
 363         (execute_unwinders): Rename to have a leading underscore.
 364         (auto_load_packages): Likewise.
 365         (global scope): Adjust call to auto_load_packages accordingly.
 366         (GdbSetPythonDirectory): Likewise.
 367         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 368         instead of execute_unwinders.
 369
 370 2019-08-15  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 373         (show_data): Don't change window visibility.
 374         (tui_gen_win_info::resize): Remove special case for command
 375         window.  Use wresize, when available.
 376         (show_source_or_disasm_and_command): Don't change window
 377         visibility.
 378         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 379         <make_visible>: New method.
 380         * tui/tui-command.c (tui_cmd_window::resize): New method.
 381
 382 2019-08-15  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 385         (struct tui_source_windows): New.
 386         * tui/tui-winsource.c (tui_display_main): Update.
 387         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 388         (new_height_ok, parse_scrolling_args): Update.
 389         * tui/tui-layout.c (show_layout, show_data): Update.
 390         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 391         (tui_add_to_source_windows): Don't declare.
 392         * tui/tui-data.c (source_windows, tui_source_windows)
 393         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 394
 395 2019-08-15  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 398         Rename from reset.
 399         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 400         * tui/tui-layout.c (show_source_disasm_command, show_data):
 401         Update.
 402         (tui_gen_win_info::resize): Rename.
 403         (show_source_or_disasm_and_command): Update.
 404         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 405         reset.
 406
 407 2019-08-15  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 410         * tui/tui-interp.c (tui_interp::init): Don't call
 411         tui_initialize_static_data.
 412         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 413
 414 2019-08-15  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 417         examine tui_win_list.
 418
 419 2019-08-15  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 422         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 423         tui_clear_source_content.
 424         (tui_clear_source_content): Remove.
 425         (tui_source_window_base::do_erase_source_content): Hoist call to
 426         content.clear().
 427         * tui/tui-stack.c (tui_show_frame_info): Don't call
 428         tui_clear_source_content.
 429
 430 2019-08-15  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (struct tui_source_window_base)
 433         <do_erase_source_content>: New method.
 434         <erase_source_content>: New method.
 435         (tui_erase_source_content): Don't declare.
 436         * tui/tui-winsource.c (tui_clear_source_content): Update.
 437         (tui_source_window_base::do_erase_source_content): Rename from
 438         tui_erase_source_content.
 439         (tui_source_window_base::show_source_content): Update.
 440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 441         * tui/tui-source.h (struct tui_source_window)
 442         <erase_source_content>: New method.
 443         * tui/tui-disasm.h (struct tui_disasm_window)
 444         <erase_source_content>: New method.
 445
 446 2019-08-15  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 449         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 450         constructor.
 451         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 452         * tui/tui-source.c (tui_set_source_content): Update.
 453         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 454
 455 2019-08-15  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 458         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 459         tui-source.c.
 460         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 461         Declare.
 462         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 463         method.
 464         (tui_source_window::maybe_update): Update.
 465
 466 2019-08-15  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 469         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 470         tui-disasm.c.
 471         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 472         Declare.
 473         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 474         method.
 475         (tui_disasm_window::maybe_update): Update.
 476
 477 2019-08-15  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (struct tui_source_window_base)
 480         <maybe_update>: Declare.
 481         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 482         method.
 483         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 484         Declare.
 485         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 486         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 487         Declare.
 488         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 489
 490 2019-08-15  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 493
 494 2019-08-15  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-wingeneral.c: Include tui-stack.h.
 497         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 498         (struct tui_locator_window): Move from tui-data.h.
 499         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 500         (tui_initialize_static_data): Move from tui-data.c.
 501         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 502         (struct tui_locator_window): Move to tui-stack.c.
 503         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 504         (tui_initialize_static_data): Move to tui-stack.c.
 505
 506 2019-08-15  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-layout.c (show_source_disasm_command)
 509         (show_source_or_disasm_and_command): Use make_visible method, not
 510         tui_make_window.
 511         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 512         Remove.
 513
 514 2019-08-15  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-wingeneral.h (tui_make_window): Update.
 517         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 518         parameter.
 519         (tui_gen_win_info::make_visible): Update.
 520         * tui/tui-regs.c (tui_data_window::display_registers_from):
 521         Update.
 522         * tui/tui-layout.c (show_source_disasm_command)
 523         (show_source_or_disasm_and_command): Update.
 524         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 525         (enum tui_box): Remove.
 526         (struct tui_win_info) <can_box>: New method.
 527         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 528         method.
 529
 530 2019-08-15  Tom de Vries  <tdevries@suse.de>
 531
 532         * linux-nat-trad.c: Include gdbarch.h.
 533
 534 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 535
 536         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 537         register sizes.
 538
 539 2019-08-14  Tom Tromey  <tromey@adacore.com>
 540
 541         * darwin-nat.c: Include gdbarch.h.
 542         * darwin-nat-info.c: Include gdbarch.h.
 543
 544 2019-08-13  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 547         Remove.
 548         * tui/tui-data.c (tui_initialize_static_data): Update.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-winsource.h (struct tui_exec_info_window)
 553         <~tui_exec_info_window, maybe_allocate_content, get_content,
 554         m_content>: Remove.
 555         (struct tui_source_window_base) <set_exec_info_content,
 556         show_exec_info_content>: Don't declare.
 557         * tui/tui-winsource.c
 558         (tui_exec_info_window::maybe_allocate_content): Remove.
 559         (tui_source_window_base::update_exec_info): Rename from
 560         set_exec_info_content.
 561         (tui_source_window_base::show_exec_info_content)
 562         (tui_source_window_base::update_exec_info): Remove.
 563
 564 2019-08-13  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 567         declare.
 568         * tui/tui-winsource.c (tui_update_source_window_as_is)
 569         (tui_update_source_windows_with_addr, tui_erase_source_content):
 570         Update.
 571         (tui_clear_exec_info_content): Remove.
 572
 573 2019-08-13  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 576         declare.
 577         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 578         call tui_erase_exec_info_content.
 579         (tui_clear_exec_info_content): Rename from
 580         tui_erase_exec_info_content.
 581         (tui_clear_exec_info_content): Delete.
 582
 583 2019-08-13  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-winsource.h (struct tui_source_window_base)
 586         <show_exec_info_content>: Declare.
 587         (tui_show_exec_info_content): Don't declare.
 588         * tui/tui-winsource.c
 589         (tui_source_window_base::show_exec_info_content): Rename from
 590         tui_show_exec_info_content.
 591         (tui_source_window_base::update_exec_info): Update.
 592
 593 2019-08-13  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 596         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 597         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 598         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 599         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 600         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 601         ... here.
 602
 603 2019-08-13  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-winsource.h (struct tui_source_window_base)
 606         <update_exec_info>: Declare.
 607         (tui_update_exec_info): Don't declare.
 608         * tui/tui-winsource.c (tui_update_source_window_as_is)
 609         (tui_source_window_base::refresh_all)
 610         (tui_update_all_breakpoint_info): Update.
 611         (tui_source_window_base::update_exec_info): Rename from
 612         tui_update_exec_info.
 613         * tui/tui-stack.c (tui_show_frame_info): Update.
 614
 615 2019-08-13  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.h (struct tui_source_window_base)
 618         <set_exec_info_content>: Declare.
 619         (tui_set_exec_info_content): Don't declare.
 620         * tui/tui-winsource.c
 621         (tui_source_window_base::set_exec_info_content): Rename from
 622         tui_set_exec_info_content.
 623         (tui_update_exec_info): Update.
 624
 625 2019-08-13  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.h (struct tui_source_window_base)
 628         <show_source_content>: Declare.
 629         (tui_show_source_content): Don't declare.
 630         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 631         (tui_source_window_base::show_source_content): Rename from
 632         tui_show_source_content.
 633         (tui_source_window_base::refresh_all): Update.
 634         * tui/tui-layout.c (show_source_disasm_command)
 635         (show_source_or_disasm_and_command): Update.
 636
 637 2019-08-13  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.c (tui_erase_source_content)
 640         (tui_show_source_content, tui_source_window_base::refresh_all):
 641         Update.
 642         * tui/tui-wingeneral.h
 643         (tui_check_and_display_highlight_if_needed): Don't declare.
 644         * tui/tui-wingeneral.c
 645         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 646         check_and_display_highlight_if_needed.
 647         * tui/tui-win.c (tui_rehighlight_all)
 648         (tui_win_info::make_visible_with_new_height): Update.
 649         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 650         (tui_data_window::erase_data_content)
 651         (tui_data_window::display_all_data): Update.
 652         * tui/tui-data.h (struct tui_win_info)
 653         <check_and_display_highlight_if_needed>: Declare.
 654
 655 2019-08-13  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-win.c (tui_resize_all): Call
 658         tui_delete_invisible_windows.
 659         * tui/tui-layout.c (show_layout): Call
 660         tui_delete_invisible_windows.
 661         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 662         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 663
 664 2019-08-13  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 667         tui_add_win_to_layout.
 668
 669 2019-08-13  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 672         * tui/tui-layout.c (tui_default_win_height): Now static.
 673
 674 2019-08-13  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 677         single switch.
 678         (show_source_disasm_command, show_source_or_disasm_and_command):
 679         Don't check current layout.
 680
 681 2019-08-13  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-wingeneral.c (make_all_visible): Remove.
 684         (tui_make_all_invisible): Simplify.
 685         * tui/tui-layout.c (tui_make_all_invisible): Move from
 686         tui-wingeneral.c; simplify.
 687         (show_layout): Hoist call to tui_make_all_invisible.
 688         (show_data): Don't call tui_make_all_invisible.
 689
 690 2019-08-13  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 693         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 694
 695 2019-08-13  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 698         tui-data.c.
 699         (show_source_disasm_command, show_data)
 700         (show_source_or_disasm_and_command): Don't use
 701         tui_set_current_layout_to.
 702         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 703         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 704         tui-layout.c.
 705         (tui_set_current_layout_to): Remove.
 706
 707 2019-08-13  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-layout.c (tui_set_layout): Update.
 710         * tui/tui-data.h (struct tui_layout_def): Remove.
 711         (tui_layout_def): Don't declare.
 712         * tui/tui-data.c (layout_def): Remove.
 713         (tui_layout_def): Remove.
 714
 715 2019-08-13  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-winsource.h (struct tui_source_window_base)
 718         <clear_detail>: No longer "override".
 719         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 720         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 721         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 722         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 723         Remove.
 724         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 725
 726 2019-08-13  Tom Tromey  <tromey@adacore.com>
 727
 728         * tracepoint.c: Don't include readline.h or history.h.
 729
 730 2019-08-12  Tom Tromey  <tom@tromey.com>
 731
 732         * configure: Rebuild.
 733         * configure.ac: Check for readline 7.
 734         * NEWS: Mention readline 7 requirement.
 735         * README: Update.
 736
 737 2019-08-12  Tom Tromey  <tom@tromey.com>
 738
 739         * mingw-hdep.c (gdb_select): Remove readline hack.
 740
 741 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 742
 743         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 744         when the function fails.
 745
 746 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 747
 748         * s390-tdep.c (s390_type_align): New function.
 749         (s390_gdbarch_init): Set it as type_align gdbarch method.
 750
 751 2019-08-09  Tom de Vries  <tdevries@suse.de>
 752
 753         PR gdb/24591
 754         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 755         pc_low with relocation offset.
 756
 757 2019-08-07  Tom Tromey  <tromey@adacore.com>
 758
 759         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 760         (print_frame_args): Update.
 761         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 762         Update.
 763         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 764         * frame.h (struct frame_arg): Add initializers.
 765         <error>: Now a unique_xmalloc_ptr.
 766
 767 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * NEWS: Expand the Pointer Authentication entry.
 770         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 771         (aarch64_frame_unmask_lr): ... to this.
 772         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 773         Call aarch64_frame_unmask_lr.
 774         * frame.c (struct frame_info): Add "masked" variable.
 775         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 776         (fprint_frame): Check for masked pc.
 777         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 778         declarations.
 779         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 780         * stack.c (print_frame): Check for masked pc.
 781
 782 2019-08-06  Tom Tromey  <tom@tromey.com>
 783
 784         * stabsread.c (patch_block_stabs, read_one_struct_field)
 785         (read_enum_type): Use obstack_strndup.
 786         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 787         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 788         * dwarf2read.c (guess_full_die_structure_name)
 789         (anonymous_struct_prefix): Use obstack_strndup.
 790         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 791         * c-exp.y (yylex): Use obstack_strndup.
 792         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 793         (write_var_or_type): Use obstack_strndup.
 794
 795 2019-08-06  Tom Tromey  <tom@tromey.com>
 796
 797         * symfile.c (reread_symbols): Use obstack_strdup.
 798         * stabsread.c (read_type): Use obstack_strdup.
 799         * gdb_obstack.h (obstack_strdup): New overload.
 800         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 801         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 802         (dwarf2_canonicalize_name): Use obstack_strdup.
 803         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 804         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 805         Use obstack_strdup.
 806
 807 2019-08-06  Tom Tromey  <tom@tromey.com>
 808
 809         * gdb_obstack.h (obstack_strdup): Define.
 810         * gdb_obstack.c (obstack_strdup): Don't define.
 811
 812 2019-08-06  Tom Tromey  <tom@tromey.com>
 813
 814         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 815         obstack_strdup.
 816         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 817         obstack_strdup.
 818         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 819         * stabsread.c (common_block_start): Use obstack_strdup.
 820         * objfiles.c (set_objfile_main_name, objfile): Use
 821         obstack_strdup.
 822         * namespace.c (add_using_directive): Use obstack_strdup.
 823         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 824         * jit.c (finalize_symtab): Use obstack_strdup.
 825         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 826         (guess_partial_die_structure_name, partial_die_info::fixup)
 827         (dwarf2_name): Use obstack_strdup.
 828         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 829         obstack_strdup.
 830         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 831         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 832         obstack_strdup.
 833         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 834
 835 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * unittests/help-doc-selftests.c: New file.
 838         * Makefile.in: Add the new file.
 839
 840 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 841
 842         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 843         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 844         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 845         the trailing '.' is not output, and the first character is uppercased.
 846         (print_help_for_command): Update call to print_doc_line.
 847         (print_doc_of_command): Likewise.
 848         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 849         * cli/cli-option.c (append_indented_doc): Do not append newline.
 850         (build_help_option): Append newline after first appended_indented_doc
 851         only if a second call is done.
 852         (build_help): Append 2 new lines before each option, except the first
 853         one.
 854         * compile/compile.c (_initialize_compile): Add new lines after
 855         %OPTIONS%, when not at the end of the help.
 856         Change help doc or code
 857         producing the help doc to respect the invariants.
 858         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 859         Also removed the new line after 'Options:', as all other commands
 860         do not put an empty line between 'Options:' and the first option.
 861         * printcmd.c (_initialize_printcmd): Likewise.
 862         * stack.c (_initialize_stack): Likewise.
 863         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 864         incorrectly telling COMMAND is optional.
 865         * ada-lang.c (_initialize_ada_language): Change help doc or code
 866         producing the help doc to respect the invariants.
 867         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 868         * breakpoint.c (_initialize_breakpoint): Likewise.
 869         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 870         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 871         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 872         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 873         _initialize_cli_style): Likewise.
 874         * corelow.c (core_target_info): Likewise.
 875         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 876         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 877         * filesystem.c (_initialize_filesystem): Likewise.
 878         * frame.c (_initialize_frame): Likewise.
 879         * gnu-nat.c (add_task_commands): Likewise.
 880         * infcall.c (_initialize_infcall): Likewise.
 881         * infcmd.c (_initialize_infcmd): Likewise.
 882         * interps.c (_initialize_interpreter): Likewise.
 883         * language.c (_initialize_language): Likewise.
 884         * linux-fork.c (_initialize_linux_fork): Likewise.
 885         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 886         * maint.c (_initialize_maint_cmds): Likewise.
 887         * memattr.c (_initialize_mem): Likewise.
 888         * printcmd.c (_initialize_printcmd): Likewise.
 889         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 890         _RegEx): Likewise.
 891         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 892         * record-btrace.c (_initialize_record_btrace): Likewise.
 893         * record-full.c (_initialize_record_full): Likewise.
 894         * record.c (_initialize_record): Likewise.
 895         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 896         * regcache.c (_initialize_regcache): Likewise.
 897         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 898         _initialize_remote): Likewise.
 899         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 900         * serial.c (_initialize_serial): Likewise.
 901         * skip.c (_initialize_step_skip): Likewise.
 902         * source.c (_initialize_source): Likewise.
 903         * stack.c (_initialize_stack): Likewise.
 904         * symfile.c (_initialize_symfile): Likewise.
 905         * symtab.c (_initialize_symtab): Likewise.
 906         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 907         * top.c (init_main): Likewise.
 908         * tracefile-tfile.c (tfile_target_info): Likewise.
 909         * tracepoint.c (_initialize_tracepoint): Likewise.
 910         * tui/tui-win.c (_initialize_tui_win): Likewise.
 911         * utils.c (add_internal_problem_command): Likewise.
 912         * valprint.c (value_print_option_defs): Likewise.
 913
 914 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 915
 916         PR build/24886
 917         * configure.ac: Drop enable-libmcheck support.
 918         * configure, config.in: Rebuild.
 919         * libmcheck.m4: Remove.
 920         * acinclude.m4: Don't include it.
 921         * Makefile.in: Don't distribute it.
 922         * top.c (print_gdb_configuration): Don't mention it.
 923
 924 2019-08-06  Tom Tromey  <tom@tromey.com>
 925
 926         * utils.c (set_output_style): Sometimes pass stream to
 927         emit_style_escape.
 928         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 929         * record-btrace.c (btrace_insn_history): Update.
 930         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 931         method.
 932         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 933         Update initializers.
 934         <m_uiout>: New field.
 935         <m_di>: Move lower.
 936         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 937         Remove "uiout" parameter.
 938         (dump_insns): Update.
 939         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 940         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 941
 942 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 943
 944         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 945         (error_in_psymtab_expansion): Likewise.
 946         (lookup_symbol_via_quick_fns): Likewise.
 947         (basic_lookup_transparent_type_quick): Likewise.
 948         (basic_lookup_transparent_type_1): Likewise.
 949
 950 2019-08-06  Tom Tromey  <tromey@adacore.com>
 951
 952         * source.c (last_source_error): Now bool.
 953         (print_source_lines_base): Make "noprint" bool.  Only open
 954         source file when last_source_visited changes.
 955
 956 2019-08-06  Tom Tromey  <tromey@adacore.com>
 957
 958         * annotate.c (annotate_source_line): Use g_source_cache.
 959         * source-cache.c (source_cache::get_plain_source_lines): Change
 960         parameters.  Populate m_offset_cache.
 961         (source_cache::ensure): New method.
 962         (source_cache::get_line_charpos): New method.
 963         (extract_lines): Move lower.  Change parameters.
 964         (source_cache::get_source_lines): Move lower.
 965         * source-cache.h (class source_cache): Update comment.
 966         <get_line_charpos>: New method.
 967         <get_source_lines>: Update comment.
 968         <clear>: Clear m_offset_cache.
 969         <get_plain_source_lines>: Change parameters.
 970         <ensure>: New method
 971         <m_offset_cache>: New member.
 972         * source.c (forget_cached_source_info_for_objfile): Update.
 973         (info_source_command): Use g_source_cache.
 974         (find_source_lines, open_source_file_with_line_charpos): Remove.
 975         (print_source_lines_base, search_command_helper): Use g_source_cache.
 976         * source.h (open_source_file_with_line_charpos): Don't declare.
 977         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 978         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 979         Use g_source_cache.
 980
 981 2019-08-06  Tom Tromey  <tromey@adacore.com>
 982
 983         * source-cache.c (source_cache::get_plain_source_lines):
 984         Remove "first_line" and "last_line" parameters.
 985         (source_cache::get_source_lines): Cache plain text.
 986         * source-cache.h (class source_cache)
 987         <get_plain_source_lines>: Update.
 988
 989 2019-08-06  Tom Tromey  <tromey@adacore.com>
 990
 991         * source-cache.c (extract_lines): No longer a method.
 992         Changed type of parameter.  Include final newline.
 993         (selftests::extract_lines_test): New function.
 994         (_initialize_source_cache): Likewise.
 995         * source-cache.h (class source_cache)
 996         <extract_lines>: Don't declare.
 997
 998 2019-08-06  Tom Tromey  <tromey@adacore.com>
 999
1000         * breakpoint.c (init_breakpoint_sal): Update.
1001         (breakpoint): Update.
1002         * breakpoint.h (struct breakpoint) <filter>: Now a
1003         unique_xmalloc_ptr.
1004
1005 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * NEWS: Mention dictionary access on blocks.
1008         * python/py-block.c (blpy_getitem): New function.
1009         (block_object_as_mapping): New struct.
1010         (block_object_type): Use new struct for tp_as_mapping field.
1011
1012 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1013
1014         * objfiles.h (objfile): Add a comment describing partial symbols.
1015
1016 2019-08-05  Tom Tromey  <tromey@adacore.com>
1017
1018         * compile/compile.c (_initialize_compile): Use _(), not N_().
1019         * thread.c (_initialize_thread): Use _(), not N_().
1020         * stack.c (_initialize_stack): Use _(), not N_().
1021         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1022
1023 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1024
1025         * dwarf2read.c (struct dw2_symtab_iterator):
1026         <want_specific_block>: Remove.
1027         <block_index>: Change type to gdb::optional.
1028         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1029         change type of BLOCK_INDEX parameter to gdb::optional.
1030         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1031         (dw2_lookup_symbol): Don't pass argument for
1032         WANT_SPECIFIC_BLOCK.
1033         (dw2_expand_symtabs_for_function): Don't pass argument for
1034         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1035         (class dw2_debug_names_iterator)
1036         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1037         parameter, change BLOCK_INDEX type to gdb::optional.
1038         <m_want_specific_block>: Remove.
1039         <m_block_index>: Change type to gdb::optional.
1040         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1041         gdb::optional.  Re-write in function of gdb::optional.
1042         (dw2_debug_names_lookup_symbol): Don't pass argument for
1043         WANT_SPECIFIC_BLOCK.
1044         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1045         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1046         BLOCK_INDEX.
1047
1048 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1049
1050         * NEWS: Mention changes to "info sources" command.
1051
1052 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1053
1054         * symtab.c (filename_partial_match_opts): New struct type.
1055         (struct output_source_filename_data): New members
1056         regexp, c_regexp, partial_match.
1057         (output_source_filename): Use new members to decide to print file.
1058         (info_sources_option_defs): New variable.
1059         (make_info_sources_options_def_group, print_info_sources_header,
1060         info_sources_command_completer):
1061         New functions.
1062         (info_sources_command): Read new optional arguments.
1063         (_initialize_symtab): Update info sources help.
1064
1065 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1066
1067         * ada-lang.c (exception_support_info_v0): Renamed from...
1068         (default_exception_support_info): ... this.  Create new
1069         definition for v1.
1070         (ada_has_this_exception_support): Look up catch_handlers_sym.
1071         (ada_exception_support_info_sniffer): Try v0 after default.
1072
1073 2019-08-01  Tom Tromey  <tromey@adacore.com>
1074
1075         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1076         gdbarch.h.
1077
1078 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1079
1080         * s12z-tdep.c: Fix include path for s12z-opc.h.
1081
1082 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1083
1084         * NEWS: Require GNU make 3.82.
1085
1086 2019-07-16  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1089         declare.
1090
1091 2019-07-30  Tom Tromey  <tromey@adacore.com>
1092
1093         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1094
1095 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1096
1097         * printcmd.c (print_address_symbolic): Print negative offsets.
1098         (build_address_symbolic): Force signed arithmetic when computing
1099         offset.
1100
1101 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1102
1103         PR/24474: Add a function to lookup static variables.
1104         * NEWS: Mention this new function.
1105         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1106         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1107         * python/python.c (python_GdbMethods): Add new function.
1108
1109 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1110
1111         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1112         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1113         (objfpy_lookup_static_symbol): New function.
1114         (objfile_object_methods): Add new functions.
1115
1116 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * NEWS: Mention 'set|show print frame-info'.  Mention new
1119         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1120         backtrace argument.  Mention that python frame filtering code
1121         is now consistent with what 'backtrace' command prints.
1122
1123 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1124
1125         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1126         comments.
1127         (print_frame_info_auto, print_frame_info_source_line,
1128         print_frame_info_location, print_frame_info_source_and_location,
1129         print_frame_info_location_and_address, print_frame_info_short_location):
1130         New declarations.
1131         (struct frame_print_options): New member print_frame_info.
1132         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1133         * stack.h (get_user_print_what_frame_info): New declaration.
1134         (frame_show_address): New declaration.
1135         * stack.c (print_frame_arguments_choices): New value 'presence'.
1136         (print_frame_info_auto, print_frame_info_source_line,
1137         print_frame_info_location, print_frame_info_source_and_location,
1138         print_frame_info_location_and_address, print_frame_info_short_location,
1139         print_frame_info_choices, print_frame_info_print_what): New definitions.
1140         (print_frame_args): Only print dots for args if print frame-arguments
1141         is 'presence'.
1142         (frame_print_option_defs): New element for "frame-info".
1143         (get_user_print_what_frame_info): New function.
1144         (frame_show_address): Make non static.  Move comment to stack.h.
1145         (print_frame_info_to_print_what): New function.
1146         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1147         to decide what to print.
1148         (backtrace_command_1): Handle the new print_frame_arguments_presence
1149         value.
1150         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1151         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1152         (py_print_frame): In non-mi mode, use LOCATION as default for
1153         print_what, similarly to frame information printed directly by
1154         backtrace command. Handle frame-info user option in non MI mode.
1155
1156 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1157
1158         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1159         Add case for debugging 32-bit target on 64-bit host.  Revise
1160         comment.
1161
1162 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1163
1164         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1165         instead of find_function_entry_range_from_pc.
1166
1167 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1168
1169         * stack.c (find_frame_funname): Remove code which preferred
1170         minsym over symtab sym in "certain pathological cases".
1171
1172         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1173         parameter.  Change type of "do_demangle" to bool.
1174         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1175         Pass suitable "prefer_sym_over_minsym" flag to
1176         build_address_symbolic().  Don't output "+" for negative offsets.
1177         * printcmd.c (print_address_symbolic): Update invocation of
1178         build_address_symbolic to include a "prefer_sym_over_minsym"
1179         flag.
1180         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1181         Restrict cases in which use of minimal symbol is preferred to that
1182         of a found symbol.  Update comments.
1183
1184         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1185         for entry pc when entry pc is out of range for that FDE.
1186
1187 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1188
1189         PR gdb/24839:
1190         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1191         type.
1192
1193 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1194
1195         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1196         this function's Python signature.
1197
1198
1199 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1200
1201         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1202         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1203         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1204         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1205         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1206
1207
1208 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1209
1210         * h8300-tdep.c (h8300_register_name_common): New.
1211         h8300_register_name): Use h8300_register_name_common.
1212         (h8300s_register_name): Likewise.
1213         (h8300sx_register_name): Likewise.
1214         (h8300h_register_nam): New.
1215         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1216
1217
1218 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1219
1220         * arm-tdep.c (arm_skip_cmse_entry): New function.
1221         (arm_is_sgstubs_section): New function.
1222         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1223
1224 2019-07-22  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1227         Don't self-assign.
1228
1229 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1232         type_print.
1233
1234 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1237         so that GDB doesn't match any msymbols when searching in the
1238         TYPES_DOMAIN.
1239         (print_symbol_info): Print using typedef_print or type_print based
1240         on the type of the symbol.  Add updated FIXME comment moved from...
1241         (_initialize_symtab): ... move and update FIXME comment to above.
1242
1243 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * NEWS: Mention adding -q option to "info types".
1246         * symtab.c (struct info_types_options): New struct.
1247         (info_types_options_defs): New variable.
1248         (make_info_types_options_def_group): New function.
1249         (info_types_command): Use gdb::option framework to parse options.
1250         (info_types_command_completer): New function.
1251         (_initialize_symtab): Extend the help text on "info types" and
1252         register command completer.
1253
1254 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1255
1256         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1257         (lookup_symbol_in_objfile): Change int to block_enum and add a
1258         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1259
1260 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1261
1262         * MAINTAINERS (Write After Approval): Add self.
1263
1264 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1265
1266         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1267         instruction to the dummy code region.
1268
1269 2019-07-19  Tom Tromey  <tromey@adacore.com>
1270
1271         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1272         (ARGSUSED, PARAMS, __func__): Remove rules.
1273
1274 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1275
1276         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1277         * features/arm/arm-with-iwmmxt.c: Remove.
1278         * features/arm/arm-with-iwmmxt.xml: Remove.
1279         * features/arm/arm-with-m-fpa-layout.c: Remove.
1280         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1281         * features/arm/arm-with-m-vfp-d16.c: Remove.
1282         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1283         * features/arm/arm-with-m.c: Remove.
1284         * features/arm/arm-with-m.xml: Remove.
1285         * features/arm/arm-with-neon.c: Remove.
1286         * features/arm/arm-with-neon.xml: Remove.
1287         * features/arm/arm-with-vfpv2.c: Remove.
1288         * features/arm/arm-with-vfpv2.xml: Remove.
1289         * features/arm/arm-with-vfpv3.c: Remove.
1290         * features/arm/arm-with-vfpv3.xml: Remove.
1291
1292 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1293
1294         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1295
1296 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * arch/aarch32.c (aarch32_create_target_description): Create
1299         target descriptions using features.
1300         * arch/arm.c (arm_create_target_description)
1301         (arm_create_mprofile_target_description): Likewise.
1302         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1303
1304 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1305
1306         * Makefile.in: Add new files.
1307         * aarch32-tdep.c: New file.
1308         * aarch32-tdep.h: New file.
1309         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1310         Call aarch32_read_description.
1311         * arch/aarch32.c: New file.
1312         * arch/aarch32.h: New file.
1313         * arch/arm.c (arm_create_target_description)
1314         (arm_create_mprofile_target_description): New function.
1315         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1316         (arm_create_target_description)
1317         (arm_create_mprofile_target_description): New declaration.
1318         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1319         read_description functions.
1320         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1321         Likewise.
1322         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1323         * arm-tdep.c (tdesc_arm_list): New variable.
1324         (arm_register_g_packet_guesses): Call create description functions.
1325         (arm_read_description) (arm_read_mprofile_description): New
1326         function.
1327         * arm-tdep.h (arm_read_description)
1328         (arm_read_mprofile_description): Add declaration.
1329         * configure.tgt: Add new files.
1330
1331 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1332
1333         * top.c (new_ui_command): Open specified terminal just once.
1334
1335 2019-07-18  Tom Tromey  <tromey@adacore.com>
1336
1337         * symtab.c (main_name): Constify return type.
1338         * symfile.c (set_initial_language): Update.
1339         * symtab.h (main_name): Constify return type.
1340
1341 2019-07-17  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-winsource.c (tui_update_source_window)
1344         (tui_update_source_window_as_is)
1345         (tui_update_source_windows_with_line): Remove return.
1346         * tui/tui-disasm.c (tui_show_disassem)
1347         (tui_show_disassem_and_update_source): Remove return.
1348         * tui/tui.c (tui_reset): Remove return.
1349         * tui/tui-wingeneral.c
1350         (tui_check_and_display_highlight_if_needed): Remove return.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1355
1356 2019-07-17  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-winsource.h (struct tui_exec_info_window)
1359         (struct tui_source_window_base): Move from tui-data.h.
1360         * tui/tui-winsource.c: Move many method definitions from
1361         elsewhere.  Remove "structuring" comments.
1362         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1363         (tui_source_window_base::refresh_window): Move to
1364         tui-winsource.c.
1365         * tui/tui-win.c (tui_source_window_base::refresh_all)
1366         (tui_source_window_base::update_tab_width)
1367         (tui_source_window_base::set_new_height)
1368         (tui_source_window_base::do_make_visible_with_new_height): Move to
1369         tui-winsource.c.
1370         * tui/tui-source.h: Update.
1371         * tui/tui-source.c (tui_source_window_base::reset): Move to
1372         tui-winsource.c.
1373         * tui/tui-disasm.h: Update.
1374         * tui/tui-data.h (struct tui_exec_info_window): Move to
1375         tui-winsource.h.
1376         (struct tui_source_window_base): Likewise.
1377         * tui/tui-data.c (tui_source_window_base::clear_detail)
1378         (tui_source_window_base, ~tui_source_window_base): Move to
1379         tui-winsource.c.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-win.c (tui_resize_all)
1384         (tui_source_window_base::update_tab_width)
1385         (tui_adjust_win_heights): Update.
1386         (tui_win_info::make_invisible_and_set_new_height): Rename from
1387         make_invisible_and_set_new_height.
1388         * tui/tui-data.h (struct tui_win_info)
1389         <make_invisible_and_set_new_height>: New method.
1390
1391 2019-07-17  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui.c: Update.
1394         * tui/tui-source.h (struct tui_source_window): Move from
1395         tui-data.h.
1396         * tui/tui-layout.c: Update.
1397         * tui/tui-disasm.c: Update.
1398         * tui/tui-data.h (struct tui_source_window): Move to
1399         tui-source.h.
1400
1401 2019-07-17  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1404         tui-data.h.
1405         * tui/tui-data.h (struct tui_disasm_window): Move to
1406         tui-disasm.h.
1407
1408 2019-07-17  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-regs.h (struct tui_data_item_window): Move from
1411         tui-data.h.
1412         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1413         * tui/tui-data.h (struct tui_data_item_window): Move to
1414         tui-regs.h.
1415         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui.c: Update.
1420         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1421         (tui_cmd_window::max_height): Move to tui-command.c.
1422         * tui/tui-layout.c: Update.
1423         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1424         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1425         tui-command.c.
1426         * tui/tui-command.h (struct tui_cmd_window): Move from
1427         tui-data.h.
1428         * tui/tui-command.c: Remove "structuring" comments.
1429         (tui_cmd_window::clear_detail)
1430         (tui_cmd_window::do_make_visible_with_new_height)
1431         (tui_cmd_window::max_height): Move from elsewhere.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1436         Now static.
1437         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1438         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1439
1440 2019-07-17  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui.c: Update.
1443         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1444         tui-regs.c.
1445         * tui/tui-windata.h: Remove file.
1446         * tui/tui-windata.c: Remove file.
1447         * tui/tui-win.c (tui_data_window::set_new_height)
1448         (tui_data_window::do_make_visible_with_new_height): Move to
1449         tui-regs.c.
1450         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1451         * tui/tui-regs.c: Remove "structuring" comments.
1452         (tui_data_window::first_data_item_displayed)
1453         (tui_data_window::delete_data_content_windows)
1454         (tui_data_window::erase_data_content)
1455         (tui_data_window::display_all_data)
1456         (tui_data_window::refresh_all)
1457         (tui_data_window::do_scroll_vertical)
1458         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1459         (tui_data_window::do_make_visible_with_new_height)
1460         (tui_data_window::refresh_window): Move from elsewhere.
1461         (_initialize_tui_regs): Move to end of file.
1462         * tui/tui-layout.c: Update.
1463         * tui/tui-hooks.c: Update.
1464         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1465         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1466         tui-regs.c.
1467         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1472         seen.
1473
1474 2019-07-17  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-win.c (tui_source_window_base::set_new_height)
1477         (tui_source_window_base::do_make_visible_with_new_height): Use
1478         m_has_locator field directly.
1479         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1480         method.
1481         (struct tui_source_window_base) <has_locator>: Likewise.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1486         Don't declare.
1487         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1488         Remove.
1489         * tui/tui-win.c (tui_source_window_base::set_new_height)
1490         (tui_source_window_base::set_new_height)
1491         (make_invisible_and_set_new_height)
1492         (tui_source_window_base::do_make_visible_with_new_height)
1493         (tui_source_window_base::do_make_visible_with_new_height):
1494         Update.
1495         * tui/tui-layout.c (show_source_disasm_command, show_data)
1496         (show_source_or_disasm_and_command): Update.
1497         * tui/tui-layout.c (show_layout): Update.
1498
1499 2019-07-17  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-layout.c (make_data_window): Remove.
1502         (show_data): Unify creation and re-initialization cases.
1503
1504 2019-07-17  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-layout.c (make_source_window, make_disasm_window):
1507         Remove.
1508         (show_data): Unify creation and re-initialization cases.
1509
1510 2019-07-17  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-layout.c (make_command_window): Remove.
1513         (show_source_disasm_command, show_source_or_disasm_and_command):
1514         Unify creation and re-initialization cases.
1515
1516 2019-07-17  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1519         creation and re-initialization cases.
1520
1521 2019-07-17  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-regs.c (tui_get_register): Return void.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1528         Simplify.
1529
1530 2019-07-17  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1533         resetting.
1534
1535 2019-07-17  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1538         * tui/tui-regs.c (tui_reg_layout): New function.
1539         (tui_show_registers, tui_reg_command): Use it.
1540         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1541         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1542         parameters.
1543         (tui_layout_command): Remove.
1544
1545 2019-07-17  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-layout.h (tui/tui-layout): Return void.
1548         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1549
1550 2019-07-17  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-layout.c (show_source_disasm_command, show_data):
1553         Update.
1554         (reset_locator): Remove.
1555         (show_source_or_disasm_and_command): Update.
1556
1557 2019-07-17  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-source.c (tui_source_window_base::reset): Remove
1560         win_type parameter.
1561         * tui/tui-layout.c (make_command_window, make_source_window)
1562         (make_disasm_window, make_data_window)
1563         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1564         (reset_locator, show_source_or_disasm_and_command): Update.
1565         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1566         win_type parameter.
1567         (struct tui_source_window_base) <reset>: Likewise.
1568
1569 2019-07-17  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-layout.c (show_source_disasm_command): Use
1572         reset_locator.
1573         (reset_locator): New function.
1574         (init_and_make_win): Remove.
1575         (show_source_or_disasm_and_command): Use reset_locator.
1576
1577 2019-07-17  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1580         condition.
1581         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1582         Remove condition.
1583         * tui/tui-source.c (tui_source_window_base::reset): New method.
1584         * tui/tui-layout.c (make_command_window): Don't call
1585         init_and_make_win.
1586         (make_source_window, make_disasm_window): Don't call
1587         make_source_or_disasm_window.
1588         (make_data_window): Don't call init_and_make_win.  Change calling
1589         convention.
1590         (show_source_disasm_command, show_data): Simplify.
1591         (make_source_or_disasm_window): Remove.
1592         (show_source_or_disasm_and_command): Simplify.
1593         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1594         (struct tui_source_window_base) <reset>: Likewise.
1595         <execution_info>: Remove initializer.
1596         * tui/tui-data.c (tui_source_window_base): Initialize
1597         execution_info.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1602         variable.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui.c (tui_rl_other_window): Update.
1607         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1608         superclass method first.  Always iterate over regs_content.
1609         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1610         method.
1611         * tui/tui-win.c (tui_set_focus_command): Update.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-win.c (tui_set_focus_command): Rename from
1616         tui_set_focus.  Call tui_enable.
1617         (tui_set_focus_command): Remove.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1622         refresh_window.
1623         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1624         touchwin.
1625         (tui_data_window::refresh_window): Call refresh_window on data
1626         items.  Always call superclass refresh_window.
1627         (tui_win_info::refresh): Remove.
1628         (tui_source_window_base::refresh_window): Update.
1629         (tui_refresh_all): Update.
1630         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1631         refresh_window.
1632         (show_source_or_disasm_and_command): Likewise.
1633         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1634         (struct tui_source_window_base) <refresh>: Likewise.
1635
1636 2019-07-17  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-winsource.c (tui_clear_source_content)
1639         (tui_show_source_content): Update.
1640         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1641         whether content is empty.
1642         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1643         Remove.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1648         window's contents.
1649         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1650         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1651
1652 2019-07-17  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1655         (struct tui_data_item_window): Update.
1656
1657 2019-07-17  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1660         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1661         defines.
1662
1663 2019-07-17  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-winsource.h (tui_erase_source_content)
1666         (tui_clear_source_content): Remove "display_prompt" parameter.
1667         * tui/tui-winsource.c (tui_update_source_window_as_is)
1668         (tui_update_source_windows_with_addr): Update.
1669         (tui_clear_source_content): Remove "display_prompt" parameter.
1670         (tui_erase_source_content): Likewise.  Simplify.
1671         (tui_show_source_content): Update.
1672         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1673         * tui/tui-stack.c (tui_show_frame_info): Update.
1674         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1675         Remove defines.
1676
1677 2019-07-17  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1680         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1681         parameter.
1682         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1683         parameter.
1684
1685 2019-07-17  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-winsource.c (tui_clear_source_content)
1688         (tui_show_source_content, tui_show_exec_info_content)
1689         (tui_clear_exec_info_content): Update.
1690         * tui/tui-stack.c (tui_show_locator_content): Update.
1691         (tui_show_frame_info): Update.
1692         * tui/tui-source.h (tui_source_window): Don't declare.
1693         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1694         from tui_source_is_displayed.
1695         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1696         Remove field.
1697         (struct tui_source_window_base) <content_in_use>: New field.  Now
1698         bool.
1699         (struct tui_source_window) <showing_source_p>: New method.
1700         (TUI_SRC_WIN): Change cast.
1701         * tui/tui-data.c (tui_initialize_static_data): Update.
1702
1703 2019-07-17  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1706         location_matches_p.
1707         * tui/tui-source.c (tui_source_window::location_matches_p): New
1708         method.
1709         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1710         method.
1711         * tui/tui-data.h (struct tui_source_window_base)
1712         <location_matches_p>: New method.
1713         (struct tui_source_window, struct tui_disasm_window)
1714         <location_matches_p>: Likewise.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-win.c (tui_set_win_height_command): Rename from
1719         tui_set_win_height.
1720         (tui_set_win_height_command): Remove.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-source.c (tui_source_window): New constructor.  Add
1725         observer.
1726         (~tui_source_window): New destructor.
1727         (tui_source_window::style_changed): New method.
1728         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1729         (tui_attach_detach_observers): Update.
1730         * tui/tui-data.h (struct tui_source_window): Make constructor not
1731         inline.  Add destructor.
1732         (struct tui_source_window) <style_changed>: New method.
1733         <m_observable>: New member.
1734
1735 2019-07-17  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1738         * tui/tui-win.c (tui_resize_all): Fix typo.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1743         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1744         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1745         * tui/tui-win.c (window_name_completer): Use foreach.
1746         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1747         (update_tab_width): Likewise.
1748         * tui/tui-layout.c (show_layout): Update.
1749         * tui/tui-data.h (class tui_window_iterator): New.
1750         (struct all_tui_windows): New.
1751         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1756         parameter.  Don't reference globals.
1757         (tui_reg_command): Update.
1758
1759 2019-07-17  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-regs.c (tui_show_registers): Simplify.
1762
1763 2019-07-17  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-regs.c (tui_show_registers): Update.
1766         (tui_show_register_group): Add win_info parameter.
1767
1768 2019-07-17  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1771         Rename from tui_display_reg_element_at_line.
1772         (tui_data_window::display_registers_from_line): Update.
1773         * tui/tui-data.h (struct tui_data_window)
1774         <display_reg_element_at_line>: New method.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-regs.h (tui_display_registers_from)
1779         (tui_display_registers_from_line): Don't declare.
1780         * tui/tui-windata.c (tui_data_window::display_all_data)
1781         (tui_data_window::refresh_all)
1782         (tui_data_window::do_scroll_vertical): Update.
1783         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1784         from tui_display_registers_from.
1785         (tui_display_reg_element_at_line): Update.
1786         (tui_data_window::display_registers_from_line): Rename from
1787         tui_display_registers_from_line.
1788         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1789         display_registers_from_line>: New methods.
1790
1791 2019-07-17  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1794         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1795         from tui_erase_data_content.
1796         (tui_data_window::display_all_data)
1797         (tui_data_window::refresh_all)
1798         (tui_data_window::do_scroll_vertical): Update.
1799         * tui/tui-regs.c (tui_show_registers): Update.
1800         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1801         New method.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1806         declare.
1807         * tui/tui-windata.c
1808         (tui_data_window::delete_data_content_windows): Rename from
1809         tui_delete_data_content_windows.
1810         (tui_data_window::display_all_data)
1811         (tui_data_window::do_scroll_vertical): Update.
1812         * tui/tui-data.h (struct tui_data_window)
1813         <delete_data_content_windows>: New method.
1814
1815 2019-07-17  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1818         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1819
1820 2019-07-17  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1823         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1824         from tui_display_all_data.
1825         * tui/tui-win.c
1826         (tui_data_window::do_make_visible_with_new_height): Update.
1827         * tui/tui-regs.c (tui_show_registers): Update.
1828         * tui/tui-layout.c (tui_set_layout): Update.
1829         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1830         method.
1831
1832 2019-07-17  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1835         * tui/tui-windata.c (tui_display_data_from): Remove.
1836         (tui_data_window::refresh_all): Update.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1841         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1842         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1843         tui_display_registers_from_line.
1844         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1845         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1846         "force_display" parameter.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1851         declare.
1852         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1853         Rename from tui_first_reg_element_no_inline.
1854         (tui_display_reg_element_at_line)
1855         (tui_display_registers_from_line): Update.
1856         * tui/tui-data.h (struct tui_data_window)
1857         <first_reg_element_no_inline>: New method.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-windata.c (tui_display_data_from)
1862         (tui_data_window::do_scroll_vertical): Update.
1863         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1864         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1865         Rename from tui_line_from_reg_element_no.
1866         (tui_display_registers_from_line): Update.
1867         * tui/tui-data.h (struct tui_data_window)
1868         <line_from_reg_element_no>: New method.
1869
1870 2019-07-17  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1873         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1874         tui_last_regs_line_no.
1875         (tui_display_reg_element_at_line)
1876         (tui_display_registers_from_line): Update.
1877         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1878         method.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         PR tui/24722:
1883         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1884         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1885         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1886         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1887         (tui_update_breakpoint_info): Likewise.
1888         * tui/tui-hooks.c (tui_event_create_breakpoint)
1889         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1890         Update.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1895
1896 2019-07-17  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.c (tui_update_source_window_as_is)
1899         (tui_update_source_windows_with_addr): Update.
1900         * tui/tui-source.h (tui_set_source_content)
1901         (tui_show_symtab_source): Add "win_info" parameter.
1902         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1903         parameter.
1904         (tui_show_symtab_source): Likewise.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-wingeneral.c
1909         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1910
1911 2019-07-17  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1914         (struct tui_cmd_window) <can_scroll>: New method.
1915         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1916         method.
1917
1918 2019-07-17  Tom Tromey  <tromey@adacore.com>
1919
1920         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1921         do_field_signed>: Rename.  Change type of "value".
1922         * ui-out.c (ui_out::field_signed): Rename from field_int.
1923         Change type of "value".
1924         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1925         type of "value".
1926         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1927         do_field_int.  Change type of "value".
1928         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1929         do_field_int.  Change type of "value".
1930         * tracepoint.c (trace_status_mi, tfind_1)
1931         (print_one_static_tracepoint_marker): Update.
1932         * thread.c (print_thread_info_1, print_selected_thread_frame):
1933         Update.
1934         * stack.c (print_frame, print_frame_info): Update.
1935         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1936         Update.
1937         * source.c (print_source_lines_base): Update.
1938         * skip.c (info_skip_command): Update.
1939         * record-btrace.c (btrace_ui_out_decode_error)
1940         (btrace_call_history_src_line): Update.
1941         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1942         Update.
1943         * progspace.c (print_program_space): Update.
1944         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1945         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1946         do_field_int.  Change type of "value".
1947         * mi/mi-out.c (mi_ui_out::do_table_begin)
1948         (mi_ui_out::do_table_header): Update.
1949         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1950         type of "value".
1951         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1952         (mi_cmd_data_list_changed_registers, output_register)
1953         (mi_cmd_data_read_memory, mi_load_progress)
1954         (mi_cmd_trace_frame_collected): Update.
1955         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1956         Update.
1957         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1958         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1959         (mi_cmd_var_list_children, varobj_update_one): Update.
1960         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1961         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1963         * inferior.c (print_inferior): Update.
1964         * gdb_bfd.c (print_one_bfd): Update.
1965         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1966         Update.
1967         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1968         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1969         do_field_int.  Change type of "value".
1970         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1971         do_field_int.  Change type of "value".
1972         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1973         (print_one_breakpoint_location, print_it_catch_fork)
1974         (print_one_catch_fork, print_it_catch_vfork)
1975         (print_one_catch_vfork, print_it_catch_solib)
1976         (print_it_catch_exec, print_it_ranged_breakpoint)
1977         (print_mention_watchpoint, print_mention_masked_watchpoint)
1978         (bkpt_print_it, update_static_tracepoint): Update.
1979         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1980         * break-catch-syscall.c (print_it_catch_syscall): Update.
1981         * ada-tasks.c (print_ada_task_info): Update.
1982         * ada-lang.c (print_it_exception, print_mention_exception):
1983         Update.
1984
1985 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         PR breakpoints/24541
1988         * gdbarch.c: Regenerate.
1989         * gdbarch.h: Regenerate.
1990         * gdbarch.sh: Adjust return type and parameter types for
1991         'stap_adjust_register'.
1992         (i386_stap_adjust_register): Adjust signature and return new
1993         register name.
1994         * stap-probe.c (stap_parse_register_operand): Adjust use of
1995         'gdbarch_stap_adjust_register'.
1996
1997 2019-07-17  Tom Tromey  <tromey@adacore.com>
1998
1999         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2000         declare VEC.
2001         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2002         std::vector.
2003         (struct s390_process_info): Add initializers.
2004         (s390_add_process): Use new.
2005         (s390_linux_nat_target::low_forget_process): Use delete.
2006         (s390_linux_nat_target::low_new_fork)
2007         (s390_linux_nat_target::stopped_by_watchpoint)
2008         (s390_linux_nat_target::low_prepare_to_resume)
2009         (s390_linux_nat_target::insert_watchpoint)
2010         (s390_linux_nat_target::insert_hw_breakpoint)
2011         (s390_linux_nat_target::remove_watchpoint)
2012         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2013
2014 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2015
2016         * aarch64-fbsd-nat.c: Include regcache.h.
2017         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2018         argument.
2019         (aarch64_fbsd_nat_target::fetch_registers)
2020         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2021         variable.
2022         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2023
2024 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * fbsd-nat.c: Include gdbarch.h.
2027
2028 2019-07-15  Tom Tromey  <tromey@adacore.com>
2029
2030         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2031
2032 2019-07-15  Tom Tromey  <tromey@adacore.com>
2033
2034         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2035         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2036         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2037         * cli-out.c (cli_ui_out::do_field_int): New method.
2038         * ui-out.c (ui_out::field_unsigned): New method.
2039         * symfile.c (generic_load): Use field_unsigned.
2040         (print_transfer_performance): Likewise.
2041         * record-btrace.c (ui_out_field_uint): Remove.
2042         (btrace_call_history_insn_range, btrace_call_history): Use
2043         field_unsigned.
2044         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2045         field_unsigned.
2046         * ui-out.h (class ui_out) <field_unsigned>: New method.
2047         <do_field_unsigned>: Likewise.
2048
2049 2019-07-15  Tom Tromey  <tromey@adacore.com>
2050
2051         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2052         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2053         * target.c (flash_erase_command): Use field_string.
2054         * infrun.c (print_signal_received_reason): Use field_string.
2055         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2056         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2057         field_string.
2058         * ada-tasks.c (print_ada_task_info): Use field_string.
2059
2060 2019-07-15  Tom Tromey  <tromey@adacore.com>
2061
2062         * target.c (flash_erase_command): Use field_core_addr.
2063         * symfile.c (generic_load): Use field_core_addr.
2064         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2065         Use field_core_addr.
2066         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2067         field_core_addr.
2068
2069 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2072         value if its desired type is smaller than a CORE_ADDR and signed.
2073
2074 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2077         of changes to field names, and use new is_reference field to
2078         decide if a property is a reference or not.
2079         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2080         field.
2081         (struct dwarf2_property_baton): Update header comment, rename
2082         'referenced_type' to 'property_type' and update comments.
2083         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2084         default property type, store in property baton, update to take
2085         accound of renamed field.
2086         (read_func_scope): Update call to attr_to_dynamic_prop.
2087         (read_array_type): Likewise.
2088         (dwarf2_per_cu_addr_sized_int_type): New function.
2089         (read_subrange_index_type): Move type finding code to
2090         dwarf2_per_cu_addr_sized_int_type.
2091         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2092         (dwarf2_per_cu_addr_type): New function.
2093         (set_die_type): Update calls to attr_to_dynamic_prop.
2094
2095 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2096
2097         * dwarf2read.c (read_subrange_index_type): New function.
2098         (read_subrange_type): Move code into new function and call it.
2099         * gdbtypes.c (create_range_type): Add some asserts.
2100
2101 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2104         update return statements.
2105         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2106         declaration, and update comment to match.
2107         * gdbtypes.c (resolve_dynamic_array): Update call to
2108         dwarf2_evaluate_property to match new return type.
2109
2110 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * valarith.c (value_subscripted_rvalue): Change lowerbound
2113         parameter type from int to LONGEST.
2114         * value.h (value_subscripted_rvalue): Likewise in declaration.
2115
2116 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2117
2118         * cli/cli-utils.c (info_print_command_completer): New function.
2119         * cli/cli-utils.h: Add 'completer.h' include, and forward
2120         declaration for 'struct cmd_list_element'.
2121         (info_print_command_completer): Declare.
2122         * stack.c (_initialize_stack): Add completer for 'info locals' and
2123         'info args'.
2124         * symtab.c (_initialize_symtab): Add completer for 'info
2125         variables' and 'info functions'.
2126         * NEWS: Mention completion for additional info commands.
2127
2128 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * cli/cli-utils.c (extract_info_print_args): Delete.
2131         (extract_arg_maybe_quoted): Delete.
2132         (info_print_options_defs): New variable.
2133         (make_info_print_options_def_group): New function.
2134         (extract_info_print_options): Define new function.
2135         * cli/cli-utils.h (extract_info_print_args): Delete.
2136         (struct info_print_options): New structure.
2137         (extract_info_print_options): Declare new function.
2138         * stack.c (info_locals_command): Update to use new
2139         extract_info_print_options, also add a header comment.
2140         (info_args_command): Likewise.
2141         * symtab.c (info_variables_command): Likewise.
2142         (info_functions_command): Likewise.
2143
2144 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2147         to extract string arguments.
2148         * common/common-utils.c (extract_string_maybe_quoted): New function.
2149         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2150
2151 2019-07-11  Tom Tromey  <tromey@adacore.com>
2152
2153         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2154         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2155         * top.h (gdbinit): Don't declare.
2156         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2157         into...
2158         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2159         * top.c (gdb_init): Don't call init_cli_cmds.
2160         (gdbinit): Remove.
2161         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2162
2163 2019-07-11  Tom Tromey  <tromey@adacore.com>
2164
2165         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2166         after it has been moved.
2167
2168 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2169
2170         * valops.c (value_must_coerce_to_target): Change return type to
2171         bool.
2172         * value.h (value_must_coerce_to_target): Likewise.
2173
2174 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2175
2176         * breakpoint.c (is_hardware_watchpoint): Remove
2177         forward-declaration.
2178         (is_masked_watchpoint): Change return type to bool.
2179         (is_tracepoint): Likewise.
2180         (is_breakpoint): Likewise.
2181         (is_hardware_watchpoint): Likewise.
2182         (is_watchpoint): Likewise.
2183         (is_no_memory_software_watchpoint): Likewise.
2184         (is_catchpoint): Likewise.
2185         (breakpoint_1): Make FILTER parameter's return type bool.
2186         is_masked_watchpoint): Change return type to bool.
2187         (save_breakpoints): Make FILTER parameter's return type bool.
2188         * breakpoint.h (is_breakpoint): Change return type to bool.
2189         (is_watchpoint): Likewise.
2190         (is_catchpoint): Likewise.
2191         (is_tracepoint): Likewise.
2192
2193 2019-07-10  Tom Tromey  <tom@tromey.com>
2194
2195         * defs.h: Don't include gdbarch.h.
2196         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2197         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2198         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2199         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2200         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2201         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2202         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2203         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2204         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2205         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2206         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2207         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2208         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2209         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2210         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2211         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2212         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2213         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2214         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2215         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2216         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2217         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2218         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2219         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2220         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2221         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2222         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2223
2224 2019-07-10  Tom Tromey  <tromey@adacore.com>
2225
2226         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2227         * breakpoint.c (init_ada_exception_breakpoint): Register as
2228         bp_catchpoint.
2229         (print_one_breakpoint_location, print_one_breakpoint): Use
2230         is_ada_exception_catchpoint.
2231         * ada-lang.c (class ada_catchpoint_location): Pass
2232         bp_loc_software_breakpoint to bp_location constructor.
2233         (is_ada_exception_catchpoint): New function.
2234
2235 2019-07-10  Tom Tromey  <tromey@adacore.com>
2236
2237         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2238         VEC.
2239         (struct arm_exidx_entry): New method operator<.
2240         (struct arm_exidx_data) <section_maps>: Change type.
2241         (arm_exidx_data_free): Remove.
2242         (arm_exidx_data_key): Change type.  Move lower.
2243         (arm_exidx_new_objfile): Update.
2244         (arm_compare_exidx_entries): Remove.
2245         (arm_find_exidx_entry, _initialize_arm_tdep)
2246
2247 2019-07-10  Tom Tromey  <tromey@adacore.com>
2248
2249         * solib-spu.c (ocl_program_data_key): Change type.
2250         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2251         Update.
2252
2253 2019-07-10  Tom Tromey  <tromey@adacore.com>
2254
2255         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2256         (struct solib_aix_inferior_data) <library_list>: Change type.
2257         (solib_aix_inferior_data_handle): Change type.
2258         (get_solib_aix_inferior_data): Update.
2259         (solib_aix_free_library_list): Remove.
2260         (library_list_start_library): Update.
2261         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2262         return type.
2263         (solib_aix_get_library_list)
2264         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2265         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2266
2267 2019-07-10  Tom Tromey  <tromey@adacore.com>
2268
2269         * solib-dsbt.c (struct dsbt_info): Add initializers.
2270         (solib_dsbt_pspace_data): Change type.
2271         (dsbt_pspace_data_cleanup): Remove.
2272         (get_dsbt_info, _initialize_dsbt_solib): Update.
2273
2274 2019-07-10  Tom Tromey  <tromey@adacore.com>
2275
2276         * spu-tdep.c (spu_overlay_data): Change type.
2277         (spu_get_overlay_table, spu_overlay_new_objfile)
2278         (_initialize_spu_tdep): Update.
2279
2280 2019-07-10  Tom Tromey  <tromey@adacore.com>
2281
2282         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2283         destructor.
2284         (dbx_objfile_data_key): Change type and declare later.
2285         (DBX_SYMFILE_INFO): Rewrite.
2286         * dbxread.c (dbx_objfile_data_key): Change type.
2287         (dbx_symfile_init): Update.
2288         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2289         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2290         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2291
2292 2019-07-10  Tom Tromey  <tromey@adacore.com>
2293
2294         * jit.c (jit_program_space_key): Change type.  Move lower.
2295         (get_jit_program_space_data): Update.
2296         (jit_program_space_data_cleanup): Remove.
2297         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2298         Update.
2299         (struct jit_program_space_data): Add initializers.
2300
2301 2019-07-10  Tom Tromey  <tromey@adacore.com>
2302
2303         * solib-darwin.c (struct darwin_info): Add initializers.
2304         (solib_darwin_pspace_data): Change type.
2305         (darwin_pspace_data_cleanup): Remove.
2306         (get_darwin_info, _initialize_darwin_solib): Update.
2307
2308 2019-07-10  Tom Tromey  <tromey@adacore.com>
2309
2310         * remote-sim.c (struct sim_inferior_data): Add initializers,
2311         constructor, and destructor.
2312         (sim_inferior_data_key): Change type.  Move lower.
2313         (check_for_duplicate_sim_descriptor): Update.
2314         (get_sim_inferior_data): Use new.  Update.
2315         (~sim_inferior_data_cleanup): Rename from
2316         sim_inferior_data_cleanup.  Simplify.
2317         (gdbsim_close_inferior, simulator_command)
2318         (sim_command_completer, _initialize_remote_sim): Update.
2319         (next_pid, INITIAL_PID): Move earlier.
2320
2321 2019-07-10  Tom Tromey  <tromey@adacore.com>
2322
2323         * python/python-internal.h (create_thread_object): Return
2324         gdbpy_ref.
2325         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2326         * python/py-inferior.c (struct threadlist_entry): Add
2327         constructor.
2328         <thread_obj>: Now a gdbpy_ref.
2329         (thread_to_thread_object): Update.
2330         (add_thread_object): Use new.
2331         (delete_thread_object): Use delete.
2332         (infpy_threads): Update.
2333         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2334         GIL.
2335
2336 2019-07-10  Tom Tromey  <tromey@adacore.com>
2337
2338         * valops.c (value_cast): Specialize error message for Ada.
2339
2340 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2341
2342         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2343
2344 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2345
2346         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2347         bpstat_should_step): Return bool, adjust comments.
2348         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2349         bpstat_should_step): Likewise.
2350
2351 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2352
2353         * features/Makefile: Use feature target descriptions for Arm.
2354         * features/arm/arm-core.c: Generate new file.
2355         * features/arm/arm-fpa.c: Likewise.
2356         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2357         * features/arm/arm-m-profile.c: Likewise.
2358         * features/arm/arm-vfpv2.c: Likewise.
2359         * features/arm/arm-vfpv3.c: Likewise.
2360         * features/arm/xscale-iwmmxt.c: Likewise.
2361         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2362
2363 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2364
2365         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2366         ptrace earlier.
2367
2368 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2369
2370         * features/aarch64-pauth.c: Regenerate.
2371
2372 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2373
2374         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2375         bool.
2376         (bpstat_what): Use false instead of 0.
2377
2378 2019-07-09  Pedro Alves  <palves@redhat.com>
2379
2380         * break-catch-throw.c (is_exception_catchpoint): New.
2381         * breakpoint.c (print_one_breakpoint_location): New parameter
2382         'raw_loc'.  Handle it.  Use
2383         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2384         looking at the breakpoint's type.
2385         (print_one_breakpoint): If handling "maint info breakpoints", also
2386         print locations of exception catchpoints.
2387         * breakpoint.h (is_exception_catchpoint): Declare.
2388
2389 2019-07-09  Pedro Alves  <palves@redhat.com>
2390
2391         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2392         "addr" field.
2393         (allocate_location_exception_catchpoint): New.
2394         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2395         (initialize_throw_catchpoint_ops): Install
2396         allocate_location_exception_catchpoint as allocate_location
2397         method.
2398         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2399         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2400         bp_loc_other.
2401         (breakpoint_address_is_meaningful): Delete.
2402         (bl_address_is_meaningful): New.
2403         (breakpoint_locations_match): Adjust comment.
2404         (bp_location_from_bp_type): New, factored out of...
2405         (bp_location::bp_location(breakpoint *)): ... this.
2406         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2407         factored out of...
2408         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2409         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2410         breakpoint_address_is_meaningful.
2411         (bp_locations_compare): Adjust comment.
2412         (update_global_location_list): Use bl_address_is_meaningful
2413         instead of breakpoint_address_is_meaningful.
2414         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2415         explicit.
2416         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2417         * python/py-breakpoint.c (bppy_get_location): No longer check
2418         whether location is null.
2419
2420 2019-07-09  Pedro Alves  <palves@redhat.com>
2421
2422         PR c++/15468
2423         * breakpoint.c (print_one_breakpoint_location): Remove
2424         single-location assert.
2425
2426 2019-07-09  Tom Tromey  <tom@tromey.com>
2427
2428         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2429         * configure: Rebuild.
2430         * configure.ac: Change common to gdbsupport.
2431         * gdbsupport: Rename from common.
2432         * acinclude.m4: Change common to gdbsupport.
2433         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2434         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2435         gdbsupport.
2436         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2437         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2438         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2439         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2440         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2441         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2442         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2443         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2444         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2445         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2446         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2447         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2448         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2449         coff-pe-read.c, command.h, compile/compile-c-support.c,
2450         compile/compile-c.h, compile/compile-cplus-symbols.c,
2451         compile/compile-cplus-types.c, compile/compile-cplus.h,
2452         compile/compile-loc2c.c, compile/compile.c, completer.c,
2453         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2454         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2455         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2456         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2457         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2458         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2459         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2460         features/aarch64-core.c, features/aarch64-fpu.c,
2461         features/aarch64-pauth.c, features/aarch64-sve.c,
2462         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2463         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2464         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2465         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2466         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2467         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2468         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2469         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2470         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2471         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2472         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2473         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2474         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2475         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2476         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2477         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2478         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2479         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2480         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2481         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2482         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2483         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2484         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2485         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2486         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2487         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2488         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2489         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2490         minsyms.c, mips-linux-tdep.c, namespace.h,
2491         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2492         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2493         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2494         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2495         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2496         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2497         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2498         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2499         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2500         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2501         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2502         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2503         procfs.c, producer.c, progspace.h, psymtab.h,
2504         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2505         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2506         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2507         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2508         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2509         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2510         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2511         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2512         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2513         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2514         target-memory.c, target.c, target.h, target/waitstatus.c,
2515         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2516         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2517         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2518         unittests/array-view-selftests.c,
2519         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2520         unittests/common-utils-selftests.c,
2521         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2522         unittests/format_pieces-selftests.c,
2523         unittests/function-view-selftests.c,
2524         unittests/lookup_name_info-selftests.c,
2525         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2526         unittests/mkdir-recursive-selftests.c,
2527         unittests/observable-selftests.c,
2528         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2529         unittests/parse-connection-spec-selftests.c,
2530         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2531         unittests/scoped_fd-selftests.c,
2532         unittests/scoped_mmap-selftests.c,
2533         unittests/scoped_restore-selftests.c,
2534         unittests/string_view-selftests.c, unittests/style-selftests.c,
2535         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2536         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2537         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2538         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2539         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2540         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2541
2542 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2545         bool value.
2546         (decode_digits_ordinary): Set explicit_line field in sal.
2547         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2548         symtab_and_line that was set on an explicit line number in
2549         assembler code.  Do always update the recorded symtab and line if
2550         we do skip the prologue.
2551
2552 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * breakpoint.c (set_breakpoint_location_function): Remove
2555         explicit_loc parameter.
2556         (momentary_breakpoint_from_master): Update call to
2557         set_breakpoint_location_function.
2558         (add_location_to_breakpoint): Likewise.
2559
2560 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2563         required features based on default bfd type when no specific bfd
2564         is present.
2565
2566 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * NEWS: Mention that GDB printf and eval commands can now print
2569         C-style and Ada-style convenience var strings without
2570         calling the inferior.
2571         * printcmd.c (printf_c_string): Locally print GDB internal var
2572         instead of transiting via the inferior.
2573         (printf_wide_c_string): Likewise.
2574
2575 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2578
2579 2019-07-04  Tom Tromey  <tom@tromey.com>
2580
2581         PR tui/24724:
2582         * tui/tui-winsource.c (tui_clear_source_content): Update.
2583         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2584         (tui_update_breakpoint_info): Update.
2585         (tui_set_exec_info_content): Update.
2586         * tui/tui-source.c (tui_set_source_content_nil): Update.
2587         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2588         has_break.
2589         * tui/tui-data.h (enum tui_bp_flag): New.
2590         (tui_bp_flags): New enum flags type.
2591         (struct tui_source_element) <break_mode>: Change type.  Rename
2592         from has_break.
2593         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2594         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2595         constants.
2596         * tui/tui-winsource.h: Fix comment.
2597
2598 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2599
2600         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2601         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2602         (store_fpregs_to_thread)
2603         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2604         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2605         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2606         (IWMMXT_REGS_SIZE): Add define.
2607         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2608         (fetch_vfp_regs, store_vfp_regs)
2609         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2610         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2611
2612 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2613
2614         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2615         defines.
2616         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2617         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2618         (ARM_INT_REGISTER_SIZE): ...to this.
2619         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2620         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2621         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2622         (arm_linux_collect_gregset, supply_nwfpe_register)
2623         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2624         defines.
2625         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2626         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2627         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2628         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2629         (arm_return_in_memory, arm_store_return_value)
2630         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2631         (arm_record_ld_st_multiple): Likewise.
2632         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2633         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2634
2635 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2636
2637         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2638         AARCH64_DISPLACED_MODIFIED_INSNS.
2639         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2640         (aarch64_displaced_step_copy_insn): Likewise.
2641         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2642         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2643         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2644         ARM_DISPLACED_MODIFIED_INSNS.
2645         * arm-tdep.c (arm_gdbarch_init): Likewise.
2646         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2647         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2648         (struct arm_displaced_step_closure): Use
2649         ARM_DISPLACED_MODIFIED_INSNS.
2650
2651 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2652
2653         * features/Makefile: Remove unused xml files.
2654         * features/aarch64.xml: Remove.
2655         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2656         * features/i386/amd64-avx-avx512.xml: Remove.
2657         * features/i386/amd64-avx-linux.xml: Remove.
2658         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2659         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2660         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2661         * features/i386/amd64-avx-mpx.xml: Remove.
2662         * features/i386/amd64-avx.xml: Remove.
2663         * features/i386/amd64-linux.xml: Remove.
2664         * features/i386/amd64-mpx-linux.xml: Remove.
2665         * features/i386/amd64-mpx.xml: Remove.
2666         * features/i386/amd64.xml: Remove.
2667         * features/i386/i386-avx-avx512-linux.xml: Remove.
2668         * features/i386/i386-avx-avx512.xml: Remove.
2669         * features/i386/i386-avx-linux.xml: Remove.
2670         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2671         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2672         * features/i386/i386-avx-mpx-linux.xml: Remove.
2673         * features/i386/i386-avx-mpx.xml: Remove.
2674         * features/i386/i386-avx.xml: Remove.
2675         * features/i386/i386-linux.xml: Remove.
2676         * features/i386/i386-mmx-linux.xml: Remove.
2677         * features/i386/i386-mmx.xml: Remove.
2678         * features/i386/i386-mpx-linux.xml: Remove.
2679         * features/i386/i386-mpx.xml: Remove.
2680         * features/i386/i386.xml: Remove.
2681         * features/i386/x32-avx-avx512-linux.xml: Remove.
2682         * features/i386/x32-avx-linux.xml: Remove.
2683         * features/i386/x32-linux.xml: Remove.
2684
2685 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2686
2687         * regformats/aarch64.dat: Remove.
2688         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2689         * regformats/i386/amd64-avx-linux.dat: Remove.
2690         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2691         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2692         * regformats/i386/amd64-linux.dat: Remove.
2693         * regformats/i386/amd64-mpx-linux.dat: Remove.
2694         * regformats/i386/amd64.dat: Remove.
2695         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2696         * regformats/i386/i386-avx-linux.dat: Remove.
2697         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2698         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2699         * regformats/i386/i386-linux.dat: Remove.
2700         * regformats/i386/i386-mmx-linux.dat: Remove.
2701         * regformats/i386/i386-mpx-linux.dat: Remove.
2702         * regformats/i386/i386.dat: Remove.
2703         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2704         * regformats/i386/x32-avx-linux.dat: Remove.
2705         * regformats/i386/x32-linux.dat: Remove.
2706
2707 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2708
2709         * aarch64-tdep.c: Remove xml self tests.
2710         * amd64-linux-tdep.c: Likewise.
2711         * amd64-tdep.c: Likewise.
2712         * i386-linux-tdep.c: Likewise.
2713         * i386-tdep.c: Likewise.
2714
2715 2019-07-03  Pedro Alves  <palves@redhat.com>
2716
2717         PR cli/24732
2718         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2719         (pipe_cmd_option_defs): New.
2720         (make_pipe_cmd_options_def_group): New.
2721         (pipe_command): Use gdb::option::process_options.
2722         (pipe_command_completer): New function.
2723         (_initialize_cli_cmds): Install completer for "pipe" command.
2724
2725 2019-07-03  Pedro Alves  <palves@redhat.com>
2726
2727         * cli/cli-option.c (union option_value) <string>: New field.
2728         (struct option_def_and_value): Add ctor, move ctor, dtor and
2729         use DISABLE_COPY_AND_ASSIGN.
2730         (option_def_and_value::clear_value): New.
2731         (parse_option, save_option_value_in_ctx, get_val_type_str)
2732         (add_setshow_cmds_for_options): Handle var_string.
2733         * cli-option.h (union option_def::var_address) <string>: New
2734         field.
2735         (struct string_option_def): New.
2736         * maint-test-options.c (struct test_options_opts): Add default
2737         ctor and use DISABLE_COPY_AND_ASSIGN.
2738         <string_opt>: New field.
2739         (test_options_opts::~test_options_opts): New.
2740         (test_options_opts::dump): Also dump "-string".
2741         (test_options_option_defs): Install "string.
2742
2743 2019-07-03  Pedro Alves  <palves@redhat.com>
2744
2745         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2746         option_value with a null enumeration.
2747         (complete_options): Save the option values in the context.
2748         (save_option_value_in_ctx): New, factored out from ...
2749         (process_options): ... here.
2750         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2751         of the function.
2752         * maint-test-options.c (test_options_opts::dump): New, factored
2753         out from ...
2754         (maintenance_test_options_command_mode): ... here.
2755         (maintenance_test_options_command_completion_result): Delete.
2756         (maintenance_test_options_command_completion_text): Update
2757         comment.
2758         (maintenance_show_test_options_completion_result): Change
2759         prototype.  Just print
2760         maintenance_test_options_command_completion_text.
2761         (save_completion_result): New.
2762         (maintenance_test_options_completer_mode): Pass options context to
2763         complete_options, and then save a dump.
2764         (_initialize_maint_test_options): Use add_cmd to install "maint
2765         show test-options-completion-result".
2766
2767 2019-07-03  Pedro Alves  <palves@redhat.com>
2768
2769         * NEWS (New commands): Mention "with" and "maint with".
2770         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2771         (with_command, with_command_completer): New.
2772         (pipe_command): Adjust to new repeat_previous
2773         interface.
2774         (_initialize_cli_cmds): Install the "with" command and its "w"
2775         alias.
2776         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2777         declarations.
2778         * cli/cli-setshow.c (parse_cli_var_uinteger)
2779         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2780         argument strings for all var_types.
2781         (get_setshow_command_value_string): New, factored out from ...
2782         (do_show_command): ... this.
2783         * cli/cli-setshow.h: Include <string>.
2784         (get_setshow_command_value_string): Declare.
2785         * command.h (repeat_previous): Now returns const char *.  Adjust
2786         comment.
2787         * maint.c: Include "cli/cli-cmds.h".
2788         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2789         (_initialize_maint_cmds): Register the "maintenance with" command.
2790         * top.c (repeat_previous): Move bits from pipe_command here:
2791         Return the saved command line, if any; error out if there's no
2792         command to relaunch.
2793
2794 2019-07-03  Pedro Alves  <palves@redhat.com>
2795
2796         * NEWS (New commands): Mention "maint set/show test-settings"
2797         instead of "maint test-settings".
2798         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2799         (maintenance_test_settings_set_list): Rename to ...
2800         (maintenance_set_test_settings_list): ... this.
2801         (maintenance_test_settings_show_list): Rename to  ...
2802         (maintenance_show_test_settings_list): ... this.
2803         (maintenance_test_settings_cmd): Delete.
2804         (maintenance_test_settings_set_cmd): ...
2805         (maintenance_set_test_settings_cmd): ... this.
2806         (maintenance_test_settings_show_cmd): ...
2807         (maintenance_show_test_settings_cmd): ... this.
2808         (maintenance_test_settings_show_value_cmd):
2809         (maintenance_show_test_settings_value_cmd): ... this.
2810         (_initialize_maint_test_settings): No longer install the "maint
2811         test-settings" prefix command.  Rename "maint test-settings set"
2812         to "maint set test-settings", and "maint test-settings show" to
2813         "maint show test-settings".  Adjust all subcommands.
2814
2815 2019-07-03  Pedro Alves  <palves@redhat.com>
2816
2817         * maint-test-settings.c: Fix file's intro comment.  Replace all
2818         references to "test-options" with references to "test-settings",
2819         in comments.
2820
2821 2019-07-03  Pedro Alves  <palves@redhat.com>
2822
2823         * maint-test-settings.c (maintenance_test_settings_xxx)
2824         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2825         New.
2826         (maintenance_test_settings_enums): Use them.
2827         (maintenance_test_settings_enum): Default to
2828         maintenance_test_settings_xxx.
2829         (_initialize_maint_test_settings): Initialize
2830         MAINTENANCE_TEST_SETTINGS_FILENAME.
2831
2832 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2833
2834         * breakpoint.h (remove_breakpoints_inf): Change return type to
2835         void, move function documentation here.
2836         * breakpoint.c (remove_breakpoints_inf): Change return type to
2837         void, move function documentation to header.
2838
2839 2019-07-02  Pedro Alves  <palves@redhat.com>
2840
2841         * NEWS (Completion improvements): Mention "info threads".
2842         * thread.c (struct info_threads_opts, info_threads_option_defs)
2843         (make_info_threads_options_def_group): New.
2844         (info_threads_command): Use gdb::option::process_options.
2845         (info_threads_command_completer): New.
2846         (_initialize_thread): Use gdb::option::build_help to build the
2847         help text for "info threads".
2848
2849 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2850
2851         * defs.h (generic_load): Move from here...
2852         * symfile.h (generic_load): ... to here.  Rename name parameter
2853         to args.
2854         * symfile.c (generic_load): Add comment.
2855
2856 2019-07-01  Tom Tromey  <tromey@adacore.com>
2857
2858         * dwarf2read.c
2859         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2860         declaration of without_params.  Fix formatting.
2861
2862 2019-07-01  Tom Tromey  <tromey@adacore.com>
2863
2864         * ada-exp.y (find_primitive_type): Update.
2865         * ada-lang.h (ada_lookup_symbol): Update.
2866         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2867         parameter.
2868         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2869
2870 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2871
2872         PR breakpoints/24541
2873         * gdbarch.c: Regenerate.
2874         * gdbarch.h: Regenerate.
2875         * gdbarch.sh: Add 'stap_adjust_register'.
2876         * i386-tdep.c: Include '<unordered_set>'.
2877         (i386_stap_adjust_register): New function.
2878         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2879         * stap-probe.c (stap_parse_register_operand): Call
2880         'gdbarch_stap_adjust_register'.
2881
2882 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2883
2884         PR python/24742
2885         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2886         * python/python.c (do_start_initialization): Use 'xmalloc'
2887         instead of 'PyMem_Malloc'.
2888
2889 2019-06-28  Tom Tromey  <tromey@adacore.com>
2890
2891         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2892         for Ada.
2893
2894 2019-06-27  Tom Tromey  <tromey@adacore.com>
2895
2896         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2897         objfile_key.
2898         (arm_find_mapping_symbol, arm_record_special_symbol)
2899         (_initialize_arm_tdep): Update.
2900         (arm_objfile_data_free): Remove.
2901
2902 2019-06-27  Tom Tromey  <tromey@adacore.com>
2903
2904         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2905         to cp_print_static_field.
2906
2907 2019-06-26  Tom Tromey  <tromey@adacore.com>
2908
2909         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2910         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2911         declare.
2912
2913 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * features/aarch64-core.c (create_feature_aarch64_core):
2916         Regenerate.
2917         * features/aarch64-core.xml: Add cpsr flags.
2918
2919 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2920
2921         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2922         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2923
2924 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2925
2926         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2927         field.
2928         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2929         use.
2930         (arm_record_special_symbol): Don't insert new symbol in sorted
2931         position, push it at the end.
2932
2933 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2934
2935         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2936         (arm_mapping_symbol_s): Remove.
2937         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2938         (arm_mapping_symbol_vec): New typedef.
2939         (struct arm_per_objfile): Add constructor.
2940         <section_maps>: Change type to
2941         std::unique_ptr<arm_mapping_symbol_vec[]>.
2942         (arm_compare_mapping_symbols): Remove.
2943         (arm_find_mapping_symbol): Adjust to section_maps type change.
2944         (arm_objfile_data_free): Call delete on arm_per_objfile.
2945         (arm_record_special_symbol): Adjust to section_maps type change.
2946         Allocate arm_per_objfile with new.
2947
2948 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2949
2950         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2951         with the command prefix.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2956         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2961         type.
2962         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2963         protected.
2964
2965 2019-06-25  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-winsource.c
2968         (tui_source_window_base::set_is_exec_point_at): Add check against
2969         LOA_ADDRESS.
2970
2971 2019-06-25  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-source.c (tui_set_source_content): Don't check before
2974         xfree.
2975         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-winsource.h (tui_update_source_window_as_is)
2980         (tui_alloc_source_buffer, tui_line_is_displayed)
2981         (tui_addr_is_displayed): Change type of win_info.
2982         * tui/tui-winsource.c (tui_update_source_window_as_is)
2983         (tui_clear_source_content, tui_show_source_line)
2984         (tui_show_source_content, tui_source_window_base::refill)
2985         (tui_source_window_base::set_is_exec_point_at)
2986         (tui_source_window_base::set_is_exec_point_at)
2987         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2988         (tui_alloc_source_buffer, tui_line_is_displayed)
2989         (tui_addr_is_displayed): Change type of win_info.  Update.
2990         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2991         (tui_source_window_base::do_make_visible_with_new_height):
2992         Update.
2993         * tui/tui-source.c (tui_set_source_content)
2994         (tui_set_source_content_nil)
2995         (tui_source_window::do_scroll_vertical): Update.
2996         * tui/tui-layout.c (show_layout): Update.
2997         * tui/tui-disasm.c (tui_set_disassem_content)
2998         (tui_disasm_window::do_scroll_vertical): Update.
2999         * tui/tui-data.h (tui_win_content): Remove.
3000         (struct tui_gen_win_info) <content, content_size>: Remove.
3001         (struct tui_source_element): Add initializers and destructor.
3002         (union tui_which_element, struct tui_win_element): Remove.
3003         (struct tui_source_window_base) <content>: New field.
3004         (struct tui_data_window): Remove destructor.
3005         (tui_alloc_content, tui_free_win_content)
3006         (tui_free_all_source_wins_content): Don't declare.
3007         * tui/tui-data.c (tui_initialize_static_data): Update.
3008         (init_content_element, tui_alloc_content): Remove.
3009         (~tui_gen_win_info): Update.
3010         (~tui_data_window, tui_free_all_source_wins_content)
3011         (tui_free_win_content, free_content, free_content_elements):
3012         Remove.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-winsource.h (tui_clear_source_content)
3017         (tui_erase_source_content, tui_show_source_content): Change type
3018         of win_info.
3019         * tui/tui-winsource.c (tui_clear_source_content)
3020         (tui_erase_source_content, tui_show_source_content): Change type
3021         of win_info.
3022         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3023         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3024         win_info.
3025         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3026         win_info.
3027         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-winsource.c (tui_clear_source_content)
3032         (tui_source_window_base::set_is_exec_point_at): Update.
3033         * tui/tui-source.c (tui_set_source_content_nil): Update.
3034         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3035         a bool.
3036         * tui/tui-data.c (init_content_element): Update.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3041         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3042         * tui/tui-layout.c (init_and_make_win): Update.
3043         * tui/tui.h (enum tui_win_type): Update.
3044         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3045         tui_win_is_auxillary.
3046         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3047         tui_win_is_auxillary.
3048
3049 2019-06-25  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3052         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3053         (tui_delete_data_content_windows, tui_display_all_data)
3054         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3055         Update.
3056         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3057         * tui/tui-regs.c (tui_last_regs_line_no)
3058         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3059         (tui_show_registers): Update.
3060         (tui_show_register_group): Return void.  Update.
3061         (tui_display_registers_from, tui_display_reg_element_at_line)
3062         (tui_display_registers_from_line, tui_check_register_values):
3063         Update.
3064         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3065         member.
3066         (struct tui_data_window) <regs_content>: Now a std::vector.
3067         <regs_content_count>: Remove.
3068         (tui_add_content_elements, tui_free_data_content): Don't declare.
3069         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3070         (init_content_element): Remove DATA_WIN case.  Add assert.
3071         (tui_add_content_elements): Remove.
3072         (tui_data_window): Update.
3073         (tui_free_data_content): Remove.
3074         (free_content_elements): Remove DATA_WIN case.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-data.c (tui_data_item_window): Update.
3079         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3080         * tui/tui-windata.c (tui_display_all_data)
3081         (tui_display_data_from_line): Update.
3082         (tui_check_data_values): Remove.
3083         * tui/tui-regs.c (tui_show_register_group)
3084         (tui_display_reg_element_at_line): Update.
3085         * tui/tui-hooks.c (tui_register_changed)
3086         (tui_refresh_frame_and_register_information): Call
3087         tui_check_register_values.
3088         * tui/tui-data.h (struct tui_data_window) <data_content,
3089         data_content_count, data_type>: Remove.
3090         (enum tui_data_type): Remove.
3091
3092         * tui/tui-data.c (tui_data_window::clear_detail)
3093         (~tui_data_window): Update.
3094
3095 2019-06-25  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3098         declare.
3099         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3100         Rename from tui_first_data_item_displayed.  Update.
3101         (tui_data_window::refresh_all)
3102         (tui_data_window::do_scroll_vertical): Update.
3103         * tui/tui-data.h (struct tui_data_window)
3104         <first_data_item_displayed>: Declare new method.
3105
3106 2019-06-25  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3109         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3110         contents...
3111         (tui_initialize_static_data): ...here.
3112
3113 2019-06-25  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3116         (tui_display_registers_from, tui_check_register_values): Update.
3117         (tui_display_register): Remove win_info parameter; update.
3118         (tui_get_register): Change type of parameters.
3119         * tui/tui-data.h (struct tui_data_element): Remove.
3120         (union tui_which_element) <data>: Remove.
3121         <data_window>: Change type.
3122         (struct tui_data_item_window): New.
3123         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3124         case.  Add assert.
3125         (~tui_data_item_window): New destructor.
3126         (free_content_elements): Remove DATA_ITEM_WIN case.
3127
3128 2019-06-25  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3131         Remove.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-data.h (struct tui_command_element): Remove.
3136         (union tui_which_element) <command>: Remove.
3137         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3138         assert.
3139         (free_content_elements): Remove CMD_WIN case.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-layout.c (tui_set_layout): Update.
3144         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3145         * tui/tui-data.c (layout_def): Update.
3146
3147 2019-06-25  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3150         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3151         (tui_source_window_base::set_new_height): Update.
3152         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3153         Update.
3154         (tui_set_locator_fullname, tui_set_locator_info)
3155         (tui_show_frame_info): Update.
3156         * tui/tui-source.c (tui_set_source_content)
3157         (tui_source_is_displayed): Update.
3158         * tui/tui-layout.c (show_source_disasm_command, show_data)
3159         (show_source_or_disasm_and_command): Update.
3160         * tui/tui-disasm.c (tui_set_disassem_content)
3161         (tui_get_begin_asm_address): Update.
3162         * tui/tui-data.h (struct tui_locator_element): Remove.
3163         (union tui_which_element) <locator>: Remove.
3164         (struct tui_locator_window): New.
3165         (tui_locator_win_info_ptr): Change return type.
3166         * tui/tui-data.c (_locator): Change type.
3167         (tui_locator_win_info_ptr): Change return type.
3168         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3169         (tui_alloc_content): Add assert.
3170
3171 2019-06-25  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-winsource.c
3174         (tui_exec_info_window::maybe_allocate_content): New method.
3175         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3176         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3177         (make_source_or_disasm_window): Add cast.
3178         * tui/tui-data.h (union tui_which_element) <simple_string>:
3179         Remove.
3180         (struct tui_source_info): New.
3181         (struct tui_source_window_base) <execution_info>: Change type.
3182         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3183         case, and add assert.
3184         (tui_alloc_content): Add assert.
3185
3186 2019-06-25  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3189         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3190         * tui/tui-data.c (tui_alloc_win_info): Remove.
3191
3192 2019-06-25  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3195         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3196         can_highlight.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3201         make_visible_with_new_height method.
3202         (tui_win_info::make_visible_with_new_height): New method.
3203         (tui_source_window_base::do_make_visible_with_new_height)
3204         (tui_data_window::do_make_visible_with_new_height)
3205         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3206         (make_visible_with_new_height): Remove.
3207         (tui_resize_all, tui_adjust_win_heights): Use
3208         make_visible_with_new_height method.
3209         * tui/tui-data.h (struct tui_win_info)
3210         <do_make_visible_with_new_height, make_visible_with_new_height>:
3211         New methods.
3212         (struct tui_source_window_base, struct tui_data_window)
3213         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3214         methods.
3215
3216 2019-06-25  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3219         method.
3220         (update_tab_width): Call update_tab_width method.
3221         * tui/tui-data.h (struct tui_win_info)
3222         (struct tui_source_window_base) <update_tab_width>: New methods.
3223
3224 2019-06-25  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3227         parameter.
3228         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3229         parameter.
3230         (tui_gen_win_info::make_visible): Update.
3231         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3232         parameter.
3233         * tui/tui-data.h (enum tui_box): New enum.
3234         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3239         init_and_make_win for EXEC_INFO_WIN.
3240         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3241         longer inline.
3242         (struct tui_win_info) <~tui_win_info>: Inline.
3243         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3244         Don't declare.
3245         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3246         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3247         Remove.
3248         (tui_initialize_static_data): Update.
3249         (~tui_gen_win_info): Handle more cleanup here.
3250         (~tui_source_window_base): Delete "execution_info".
3251         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-layout.c (make_command_window): Don't set
3256         can_highlight.
3257         (show_source_disasm_command): Call the reset method.
3258         (show_data): Don't set can_highlight.  Call the reset method.
3259         (tui_gen_win_info::reset): Rename from init_gen_win_info
3260         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3261         (show_source_or_disasm_and_command): Call the reset method.
3262         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3263         (struct tui_cmd_window): Set can_highlight.
3264
3265 2019-06-25  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3268         from make_visible.
3269         (tui_make_visible, tui_make_invisible): Rewrite.
3270         (tui_win_info::make_visible): Remove.
3271         (tui_source_window_base::make_visible): Update.
3272         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3273         method.  Moved from...
3274         (struct tui_win_info) <make_visible>: ...here.
3275
3276 2019-06-25  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-winsource.c
3279         (tui_source_window_base::do_scroll_horizontal): Remove direction
3280         parameter.
3281         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3282         direction parameter.
3283         * tui/tui-win.c (tui_win_info::forward_scroll)
3284         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3285         (tui_win_info::right_scroll): Update.
3286         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3287         direction parameter.
3288         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3289         direction parameter.
3290         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3291         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3292         Remove direction parameter.
3293         (struct tui_source_window_base, struct tui_source_window)
3294         (struct tui_disasm_window, struct tui_data_window)
3295         (struct tui_cmd_window): Update.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-winsource.h (tui_set_exec_info_content)
3300         (tui_show_exec_info_content, tui_erase_exec_info_content)
3301         (tui_clear_exec_info_content, tui_update_exec_info): Change
3302         argument to tui_source_window_base.
3303         * tui/tui-winsource.c (tui_set_exec_info_content)
3304         (tui_show_exec_info_content, tui_erase_exec_info_content)
3305         (tui_clear_exec_info_content, tui_update_exec_info): Change
3306         argument to tui_source_window_base.
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3311         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3316         check.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3321         type to void.
3322         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3323         type to void.
3324         * tui/tui-source.c (tui_set_source_content): Update.
3325         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-win.c (window_name_completer, tui_set_focus)
3330         (tui_all_windows_info): Use name method.
3331         * tui/tui-data.h (struct tui_gen_win_info)
3332         (struct tui_source_window, struct tui_disasm_window)
3333         (struct tui_data_window, struct tui_cmd_window) <name>: New
3334         method.
3335         (tui_win_name): Don't declare.
3336         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3337         (tui_win_name): Remove.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-winsource.h (tui_update_source_window)
3342         (tui_update_source_window_as_is): Change parameter type.
3343         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3344         to be a tui_source_window_base.
3345         (tui_update_source_window_as_is): Likewise.
3346         * tui/tui-win.c (make_visible_with_new_height): Update.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-winsource.c (tui_erase_source_content)
3351         (tui_show_source_content, tui_show_exec_info_content)
3352         (tui_erase_exec_info_content): Use refresh_window method.
3353         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3354         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3355         from tui_refresh_win.
3356         (tui_data_window::refresh_window): New method.
3357         (tui_win_info::refresh, tui_source_window_base::refresh)
3358         (tui_refresh_all): Use refresh_window method.
3359         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3360         method.
3361         * tui/tui-regs.c (tui_display_register): Call refresh_window
3362         method.
3363         * tui/tui-layout.c (show_source_disasm_command)
3364         (show_source_or_disasm_and_command): Call refresh_window method.
3365         * tui/tui-data.h (struct tui_gen_win_info)
3366         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3367         New method.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui.c (tui_rl_other_window, tui_enable)
3372         (tui_is_window_visible, tui_get_command_dimension): Update.
3373         * tui/tui-winsource.c (tui_update_source_window_as_is)
3374         (tui_clear_source_content, tui_erase_source_content)
3375         (tui_show_source_line, tui_source_window_base::refill)
3376         (tui_source_window_base::do_scroll_horizontal)
3377         (tui_source_window_base::set_is_exec_point_at)
3378         (tui_update_breakpoint_info, tui_set_exec_info_content)
3379         (tui_alloc_source_buffer, tui_line_is_displayed)
3380         (tui_addr_is_displayed): Update.
3381         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3382         (tui_check_and_display_highlight_if_needed)
3383         (tui_win_info::make_visible, tui_win_info::refresh)
3384         (tui_refresh_all): Update.
3385         * tui/tui-windata.c (tui_first_data_item_displayed)
3386         (tui_delete_data_content_windows, tui_erase_data_content)
3387         (tui_display_all_data, tui_data_window::refresh_all)
3388         (tui_check_data_values): Update.
3389         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3390         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3391         (tui_win_info::backward_scroll, tui_refresh_all_win)
3392         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3393         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3394         (tui_source_window_base::set_new_height)
3395         (tui_data_window::set_new_height)
3396         (make_invisible_and_set_new_height)
3397         (make_visible_with_new_height, new_height_ok)
3398         (parse_scrolling_args): Update.
3399         * tui/tui-stack.c (tui_show_frame_info): Update.
3400         * tui/tui-source.c (tui_set_source_content)
3401         (tui_set_source_content_nil, tui_source_is_displayed)
3402         (tui_source_window::do_scroll_vertical): Update.
3403         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3404         (tui_display_registers_from, tui_display_reg_element_at_line)
3405         (tui_check_register_values, tui_reg_command): Update.
3406         * tui/tui-layout.c (tui_default_win_height)
3407         (show_source_disasm_command, show_data, init_and_make_win)
3408         (show_source_or_disasm_and_command): Update.
3409         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3410         (tui_redisplay_readline, tui_mld_flush)
3411         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3412         (tui_getc): Update.
3413         * tui/tui-disasm.c (tui_set_disassem_content)
3414         (tui_disasm_window::do_scroll_vertical): Update.
3415         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3416         Now virtual.
3417         (struct tui_win_info): Derive from tui_gen_win_info.
3418         <~tui_win_info>: Mark as override.
3419         <generic>: Remove member.
3420         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3421         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3422         (~tui_data_window, ~tui_win_info)
3423         (tui_free_all_source_wins_content): Update.
3424         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-layout.c (init_and_make_win): Use new.
3429         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3430         destructor, initializers.
3431         (tui_alloc_generic_win_info): Don't declare.
3432         * tui/tui-data.c (_locator): Add argument to constructor.
3433         (source_win, disasm_win): New globals.
3434         (exec_info): Remove.
3435         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3436         Update.
3437         (tui_alloc_generic_win_info): Remove.
3438         (init_content_element): Use new.
3439         (tui_win_info::tui_win_info): Update.
3440         (free_content_elements) <case DATA_WIN>: Use delete.
3441
3442 2019-06-25  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3445         * tui/tui-windata.c (tui_first_data_item_displayed)
3446         (tui_delete_data_content_windows): Update.
3447         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3448         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3449         (tui_display_registers_from, tui_check_register_values): Update.
3450         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3451         pointer.
3452         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3453         window.
3454         (tui_free_data_content): Update.
3455         (free_content_elements) <case DATA_WIN>: Free the window.
3456
3457 2019-06-25  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3460         Update.
3461         * tui/tui-layout.c (make_command_window)
3462         (show_source_disasm_command, show_data, init_and_make_win)
3463         (show_source_or_disasm_and_command): Update.
3464         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3465         method.
3466         <can_highight, is_highlighted>: Now bool.
3467         (tui_set_win_highlight): Don't declare.
3468         * tui/tui-data.c (tui_set_win_highlight): Remove.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-wingeneral.c (make_visible): Remove check of window
3473         type.
3474
3475 2019-06-25  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-win.c (tui_win_info::max_height)
3478         (tui_cmd_window::max_height): New methods.
3479         (new_height_ok): Call max_height.
3480         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3481         <max_height>: New method.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-win.c (tui_source_window_base::set_new_height)
3486         (tui_data_window::set_new_height): New methods.
3487         (make_invisible_and_set_new_height): Call set_new_height method.
3488         * tui/tui-data.h (struct tui_win_info)
3489         (struct tui_source_window_base, struct tui_data_window)
3490         <set_new_height>: New method.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3495         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3496         tui_refresh_data_win.
3497         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3498         method.
3499         (tui_refresh_all_win): Call the refresh_all method.
3500         (tui_set_focus): Likewise.
3501         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3502         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3503         Likewise.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-winsource.h (tui_refill_source_window)
3508         (tui_set_is_exec_point_at): Don't declare.
3509         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3510         (tui_source_window_base::refill): Rename from
3511         tui_refill_source_window.
3512         (tui_source_window_base::do_scroll_horizontal): Update.
3513         (tui_source_window_base::set_is_exec_point_at): Rename from
3514         tui_set_is_exec_point_at.
3515         (tui_update_all_breakpoint_info): Update.
3516         * tui/tui-stack.c (tui_show_frame_info): Update.
3517         * tui/tui-layout.c (show_data): Add cast.
3518         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3519         * tui/tui-data.h (struct tui_source_window_base) <refill,
3520         set_is_exec_point_at>: New methods.
3521         (tui_source_windows, tui_add_to_source_windows): Update types.
3522         (tui_add_to_source_windows): Remove redundant declaration.
3523         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3524         (tui_source_windows): Change return type.
3525         (tui_clear_source_windows_detail): Update.
3526         (tui_add_to_source_windows): Change type of parameter.
3527         (tui_free_all_source_wins_content): Update.
3528
3529 2019-06-25  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-wingeneral.c (tui_win_info::refresh)
3532         (tui_source_window_base::refresh): New methods.
3533         (tui_refresh_all): Call the refresh method.
3534         * tui/tui-data.h (struct tui_win_info)
3535         (struct tui_source_window_base) <refresh>: New method.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui.h (tui_is_window_visible): Return bool.
3540         * tui/tui.c (tui_is_window_visible): Return bool.
3541         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3542         (tui_make_visible, tui_make_invisible)
3543         (tui_win_info::make_visible)
3544         (tui_source_window_base::make_visible, make_all_visible)
3545         (tui_make_all_visible, tui_make_all_invisible): Update.
3546         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3547         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3548         bool.
3549         (struct tui_win_info, struct tui_source_window_base)
3550         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3551         * tui/tui-data.c (tui_init_generic_part): Update.
3552
3553 2019-06-25  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3556         (tui_source_window_base::make_visible): New methods.
3557         (make_all_visible): Make method call.
3558         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3559         (struct tui_source_window_base, struct tui_cmd_window): Override
3560         make_visible.
3561         (tui_win_is_source_type): Don't declare.
3562         * tui/tui-data.c (tui_win_is_source_type): Remove.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3567         NULL check.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3572         Inline constructor.  Add initializers for members.
3573         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3574         constructors; now inline in class.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-regs.c (tui_show_registers): Update.
3579         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3580         bool.
3581         * tui/tui-data.c (tui_data_window::clear_detail)
3582         (tui_data_window): Update.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-windata.c (tui_display_all_data)
3587         (tui_display_data_from_line, tui_display_data_from)
3588         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3589         Update.
3590         * tui/tui-regs.c (tui_last_regs_line_no)
3591         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3592         (tui_show_registers, tui_show_register_group)
3593         (tui_display_registers_from, tui_display_reg_element_at_line)
3594         (tui_display_registers_from_line, tui_check_register_values)
3595         (tui_reg_next, tui_reg_prev): Update.
3596         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3597         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3598         tui_data_window.
3599         (struct tui_win_info) <detail>: Remove.  Add new fields from
3600         tui_data_info.
3601         (TUI_DATA_WIN): Add cast.
3602         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3603         (~tui_data_window): Simplify.
3604
3605 2019-06-25  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-layout.c (show_source_disasm_command)
3608         (show_source_or_disasm_and_command): Update.
3609         * tui/tui-io.c (update_cmdwin_start_line)
3610         (tui_redisplay_readline): Update.
3611         * tui/tui-data.h (struct tui_command_info): Remove.
3612         (struct tui_win_info) <detail>: Remove command_info member.
3613         (struct tui_data_window) <start_line>: New member, from
3614         tui_command_info.
3615         (TUI_CMD_WIN): Add casts.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-winsource.c (tui_update_source_window)
3620         (tui_refill_source_window)
3621         (tui_source_window_base::do_scroll_horizontal)
3622         (tui_update_breakpoint_info, tui_set_exec_info_content)
3623         (tui_show_exec_info_content, tui_erase_exec_info_content)
3624         (tui_clear_exec_info_content): Update.
3625         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3626         Update.
3627         * tui/tui-win.c (make_invisible_and_set_new_height)
3628         (make_visible_with_new_height): Update.
3629         * tui/tui-source.c (tui_set_source_content)
3630         (tui_show_symtab_source): Update.
3631         * tui/tui-layout.c (extract_display_start_addr)
3632         (show_source_disasm_command, show_data)
3633         (make_source_or_disasm_window)
3634         (show_source_or_disasm_and_command): Update.
3635         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3636         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3637         "gdbarch".
3638         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3639         to tui_source_window_base.
3640         (struct tui_win_info) <detail>: Remove source_info member.
3641         (struct tui_source_window_base) <has_locator>: Inline.
3642         Move contents from tui_source_info; rename has_locator member to
3643         m_has_locator.
3644         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3645         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3646         header file.
3647         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3648         Simplify.
3649         (tui_free_all_source_wins_content): Cast to
3650         tui_source_window_base.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-win.c (make_invisible_and_set_new_height)
3655         (make_visible_with_new_height): Call has_locator method.
3656         * tui/tui-layout.c (show_source_disasm_command, show_data)
3657         (show_source_or_disasm_and_command): Update for bool change.
3658         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3659         (tui_win_info) <has_locator>: New method.
3660         (struct tui_source_window_base) <has_locator>: New method.
3661         (tui_win_has_locator): Don't declare.
3662         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3663         from tui_win_has_locator.
3664         (tui_source_window_base): Use false, not FALSE.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3669         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3670         clear_detail method directly.
3671         (tui_clear_win_detail): Remove.
3672
3673 2019-06-25  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3676         "this", not TUI_DISASM_WIN.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3681         declare.
3682         * tui/tui-winsource.c
3683         (tui_source_window_base::do_scroll_horizontal): Rename from
3684         tui_horizontal_source_scroll.
3685         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3686         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3687         from tui_vertical_data_scroll.
3688         * tui/tui-win.h (tui_scroll): Don't declare.
3689         * tui/tui-win.c (tui_win_info::forward_scroll)
3690         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3691         (tui_win_info::right_scroll): Rename and update.
3692         (tui_scroll_forward_command, tui_scroll_backward_command)
3693         (tui_scroll_left_command, tui_scroll_right_command): Update.
3694         (tui_scroll): Remove.
3695         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3696         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3697         from tui_vertical_source_scroll.
3698         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3699         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3700         from tui_vertical_disassem_scroll.
3701         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3702         do_scroll_horizontal>: New methods.
3703         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3704         Likewise.
3705         (struct tui_source_window_base): Add do_scroll_horizontal.
3706         (struct tui_source_window, struct tui_disasm_window): Add
3707         do_scroll_vertical.
3708         (struct tui_data_window, struct tui_cmd_window): Add
3709         do_scroll_horizontal and do_scroll_vertical.
3710         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3711
3712 2019-06-25  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-data.h (struct tui_source_window_base): New struct.
3715         (struct tui_source_window): Derive from tui_source_window_base.
3716         (struct tui_disasm_window): New struct.
3717         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3718         from tui_source_window::clear_detail.
3719         (tui_source_window_base): Rename from tui_source_window.
3720         (~tui_source_window_base): Rename from ~tui_source_window.
3721         (tui_alloc_win_info): Create a tui_disasm_window.
3722
3723 2019-06-25  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-data.h (struct tui_source_window)
3726         (struct tui_data_window): Declare destructors.
3727         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3728         destructors.
3729         (tui_win_info): Simplify.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-winsource.c (tui_display_main)
3734         (tui_update_source_windows_with_addr)
3735         (tui_update_all_breakpoint_info): Update.
3736         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3737         (new_height_ok, parse_scrolling_args): Update.
3738         * tui/tui-stack.c (tui_show_frame_info): Update.
3739         * tui/tui-data.h (struct tui_list): Remove.
3740         (tui_source_windows): Return a reference to a std::vector.
3741         * tui/tui-data.c (source_windows): Now a std::vector.
3742         (tui_source_windows): Change return type.
3743         (tui_clear_source_windows): Rewrite.
3744         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3745         (tui_free_all_source_wins_content): Rewrite.
3746
3747 2019-06-25  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3750         (struct tui_data_window, struct tui_cmd_window): Declare
3751         clear_detail method.
3752         * tui/tui-data.c (tui_source_window::clear_detail)
3753         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3754         methods.
3755         (tui_clear_win_detail): Simplify.
3756
3757 2019-06-25  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-layout.c (make_source_window, make_disasm_window)
3760         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3761         Return the new window.
3762         (show_source_disasm_command, show_data)
3763         (show_source_or_disasm_and_command): Update.
3764
3765 2019-06-25  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3768         parameter.  Return the new window.
3769         (show_source_disasm_command): Update and remove NULL check.
3770         (show_source_or_disasm_and_command): Update.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-data.h (struct tui_win_info): Make constructor
3779         protected.  Make destructor virtual.  Add initializers.
3780         (tui_source_window, tui_data_window, tui_cmd_window): New
3781         classes.
3782         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3783         constructor.  Add "type" parameter.
3784         (tui_source_window, tui_data_window, tui_cmd_window): New
3785         constructors.
3786         (tui_alloc_win_info): Instantiate the appropriate subclass.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-win.c (tui_resize_all): Use delete.
3791         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3792         destructor.
3793         (tui_free_window): Don't declare.
3794         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3795         Update.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-data.h (struct tui_win_info): Add constructor.
3800         * tui/tui-data.c (tui_alloc_win_info): Use new.
3801         (tui_free_window): Use delete.
3802
3803 2019-06-22  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3806         declare.
3807         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3808
3809 2019-06-22  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3812         declare.
3813         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3814
3815 2019-06-22  Tom de Vries  <tdevries@suse.de>
3816
3817         * dwarf2read.c (create_addrmap_from_aranges)
3818         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3819         instead of '%zu'.
3820
3821 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3822
3823         * dwarf2read.h (dwarf2_section_info_def): Remove.
3824         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3825         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3826         std::vector<dwarf2_section_info>.
3827         (struct dwo_file) <~dwo_file>: Remove.
3828         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3829         types field.
3830         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3831         (dwarf2_read_debug_names): Likewise.
3832         (create_debug_types_hash_table): Change parameter type to
3833         array_view, adjust code accordingly.
3834         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3835         (partial_die_info::fixup): Likewise.
3836         (determine_prefix): Likewise.
3837         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3838
3839 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3840
3841         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3842         gdb_bfd_ref_ptr.
3843         <~dwo_file>: Remove call to gdb_bfd_unref.
3844         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3845         gdb_bfd_ref_ptr::get.
3846
3847 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3848
3849         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3850         type to htab_up.
3851         * dwarf2read.c (struct dwo_file): Initialize fields.
3852         <~dwo_file>: New.
3853         (free_dwo_file): Remove, move content to ~dwo_file.
3854         (struct dwo_file_deleter): Remove.
3855         (dwo_file_up>: Remove custom deleter.
3856         (free_dwo_files): Remove.
3857         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3858         dwo_files.
3859         (process_skeletonless_type_units): Call unique_ptr::get.
3860         (allocate_dwo_file_hash_table): Add deleter to created hash
3861         table.  Change return type to htab_up.
3862         (lookup_dwo_file_slot): Don't memset dwo_file, call
3863         unique_ptr::get.
3864         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3865         (create_dwo_unit_in_dwp_v2): Likewise.
3866         (open_and_init_dwo_file): Likewise.
3867         (free_dwo_file_from_slot): Remove.
3868
3869 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3870
3871         * dwarf2read.h (struct dwarf2_section_info) <readin,
3872         is_virtual>: Change type to bool.
3873         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3874         true instead of 1.
3875
3876 2019-06-19  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-data.h (tui_init_content_element): Don't declare.
3879
3880 2019-06-19  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-data.h (tui_init_win_info): Don't declare.
3883
3884 2019-06-19  Tom de Vries  <tdevries@suse.de>
3885
3886         * dwarf2read.h (abstract_to_concrete): Change type to
3887         std::unordered_map<sect_offset, std::vector<sect_offset>,
3888         gdb::hash_enum<sect_offset>>.
3889
3890 2019-06-19  Tom Tromey  <tromey@adacore.com>
3891
3892         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3893         EVAL_AVOID_SIDE_EFFECTS specially.
3894
3895 2019-06-19  Tom Tromey  <tromey@adacore.com>
3896
3897         * source-cache.c (highlighter): New global.
3898         (source_cache::get_source_lines): Create a highlighter on demand.
3899
3900 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * defs.h (deprecated_interactive_hook): Delete declaration.
3903         * interps.c (clear_interpreter_hooks): Remove use of
3904         deprecated_interactive_hook.
3905         * top.c (deprecated_interactive_hook): Delete definition.
3906         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3907
3908 2019-06-18  Tom de Vries  <tdevries@suse.de>
3909
3910         PR gdb/24515
3911         * dwarf2read.h (abstract_to_concrete): Change type from
3912         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3913         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3914         * dwarf2read.c (read_variable): Update.
3915         (dwarf2_fetch_die_loc_sect_off): Update.
3916
3917 2019-06-17  Tom de Vries  <tdevries@suse.de>
3918
3919         PR gdb/24617
3920         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3921         accessing parent[parent_len - 1].
3922
3923 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3924
3925         PR gdb/24364
3926         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3927         call dtrace_process_dof with NULL dof.
3928
3929 2019-06-16  Tom de Vries  <tdevries@suse.de>
3930
3931         PR gdb/24445
3932         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3933
3934 2019-06-16  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3937         (make_all_visible): Use address of member.
3938
3939 2019-06-16  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3942         (tui_free_window, free_content, free_content_elements): Remove
3943         unnecessary cast.
3944         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3945         cast.
3946         * tui/tui-regs.c (tui_show_register_group)
3947         (tui_display_registers_from, tui_display_reg_element_at_line):
3948         Remove unnecessary cast.
3949
3950 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * linux-nat.c (normal_mask): Delete.
3953         (_initialize_linux_nat): Don't initialise normal_mask.
3954
3955 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3956
3957         PR gdb/24445
3958         * dwarf-index-write.h (write_psymtabs_to_index): Add
3959         dwz_basename parameter.
3960         * dwarf-index-write.c (write_gdbindex): Move file writing to
3961         write_gdbindex_1.  Change return type void.
3962         (assert_file_size): Move up, remove filename parameter.
3963         (write_gdbindex_1): New function.
3964         (write_debug_names): Change return type to void, call
3965         assert_file_size.
3966         (struct index_wip_file): New struct.
3967         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3968         file logic to index_wip_file.  Write index for dwz file if
3969         needed.
3970         (save_gdb_index_command): Pass basename of dwz file, if present.
3971         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3972         build-id of dwz file, if present.
3973         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3974         (dwarf2_get_dwz_file): Likewise.
3975         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3976         (dwarf2_get_dwz_file): Likewise.
3977
3978 2019-06-16  Tom Tromey  <tom@tromey.com>
3979
3980         * coffread.c (process_coff_symbol): Use xstrdup.
3981         * value.c (create_internalvar): Use xstrdup.
3982
3983 2019-06-16  Tom Tromey  <tom@tromey.com>
3984
3985         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3986         * breakpoint.c (stopin_command, stopat_command)
3987         (until_break_command, decode_location_default): Remove unnecessary
3988         cast.
3989         * utils.c (subset_compare): Remove unnecessary cast.
3990         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3991         cast.
3992         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3993         cast.
3994         * infcmd.c (path_command): Remove unnecessary cast.
3995         * coffread.c (decode_type): Remove unnecessary cast.
3996         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3997         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3998         * tui/tui-stack.c (tui_show_locator_content)
3999         (tui_show_frame_info): Remove unnecessary cast.
4000         * tui/tui-win.c (tui_scroll_forward_command)
4001         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4002         (parse_scrolling_args): Remove unnecessary cast.
4003         * tui/tui-data.c (init_win_info, tui_del_window)
4004         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4005         (free_content_elements): Remove unnecessary cast.
4006         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4007         unnecessary cast.
4008         * tui/tui-source.c (tui_set_source_content)
4009         (tui_vertical_source_scroll): Remove unnecessary cast.
4010         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4011         cast.
4012         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4013         * tui/tui-regs.c (tui_display_registers_from)
4014         (tui_display_register): Remove unnecessary cast.
4015         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4016         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4017         (make_visible): Remove unnecessary cast.
4018         * tui/tui-winsource.c (tui_erase_source_content)
4019         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4020         unnecessary cast.
4021         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4022         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4023         * stabsread.c (read_type, read_array_type, read_range_type):
4024         Remove unnecessary cast.
4025         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4026         (parse_symbol, parse_type, upgrade_type, parse_external)
4027         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4028         unnecessary cast.
4029         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4030
4031 2019-06-16  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-data.c (tui_alloc_generic_win_info)
4034         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4035         checks.
4036
4037 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4038             Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * f-typeprint.c (f_print_type): Don't return early for not
4041         associated or not allocated types.
4042         (f_type_print_varspec_suffix): Add print_rank parameter and print
4043         ranks of array types in case they dangling.
4044         (f_type_print_base): Add print_rank parameter.
4045
4046 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * NEWS: Mention new MI commands.
4049         * break-catch-throw.c (enum exception_event_kind): Move to
4050         breakpoint.h.
4051         (print_mention_exception_catchpoint): Output text as a single
4052         message.
4053         (catch_exception_command_1): Rename to...
4054         (catch_exception_event): ...this, make non-static, update header
4055         command, and change some parameter types.
4056         (catch_catch_command): Update for changes to
4057         catch_exception_command_1.
4058         (catch_throw_command): Likewise.
4059         (catch_rethrow_command): Likewise.
4060         * breakpoint.c (enum exception_event_kind): Delete.
4061         * breakpoint.h (enum exception_event_kind): Moved here from
4062         break-catch-throw.c.
4063         (catch_exception_event): Declare.
4064         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4065         (mi_cmd_catch_throw): New function.
4066         (mi_cmd_catch_rethrow): New function.
4067         (mi_cmd_catch_catch): New function.
4068         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4069         'catch-catch' entries.
4070         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4071         (mi_cmd_catch_rethrow): Declare.
4072         (mi_cmd_catch_catch): Declare.
4073
4074 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * annotate.c (annotate_source_line): Change return type to void,
4077         update implementation to match.
4078         * annotate.h (annotate_source_line): Change return type to void,
4079         update header comment.
4080         * stack.c (print_frame_info): Don't change what frame information
4081         is printed based on whether annotations are on or not.
4082
4083 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4086         (annotate_source): Make static.
4087         (annotate_source_line): Moved from source.c and renamed from
4088         identify_source_line.  Update the return type.
4089         * annotate.h (annotate_source): Delete declaration.
4090         (annotate_source_line): Declaration moved from source.h, and
4091         renamed from identify_source_line.  Return type updated.
4092         * source.c (identify_source_line): Moved to annotate.c and renamed
4093         to annotate_source_line.
4094         (info_line_command): Remove check of annotation_level.
4095         * source.h (identify_source_line): Move declaration to annotate.h
4096         and rename to annotate_source_line.
4097         * stack.c: Add 'annotate.h' include.
4098         (print_frame_info): Remove check of annotation_level before
4099         calling annotate_source_line.
4100
4101 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * source-cache.c (source_cache::get_plain_source_lines): Use
4104         open_source_file_with_line_charpos instead of just
4105         open_source_file, remove call to find_source_lines.
4106         (source_cache::get_source_lines): Likewise.
4107         * source.c (find_source_lines): Make static.
4108         (get_filename_and_charpos): Renamed into...
4109         (open_source_file_with_line_charpos): ..this along with changes to
4110         return a scoped_fd, and some other minor clean ups.
4111         (identify_source_line): Use open_source_file_with_line_charpos.
4112         (search_command_helper): Use open_source_file_with_line_charpos
4113         instead of just open_source_file, remove call to
4114         find_source_lines.
4115         * source.h (open_source_file_with_line_charpos): Declare new
4116         function.
4117         (find_source_lines): Delete declaration.
4118
4119 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * source.c (get_filename_and_charpos): Remove fullname
4122         parameter.
4123         (identify_source_line): Update call to get_filename_and_charpos.
4124
4125 2019-06-14  Tom Tromey  <tromey@adacore.com>
4126
4127         PR gdb/24502:
4128         * ui-style.h (skip_ansi_escape): Update comment.
4129         * ui-file.h (class no_terminal_escape_file): New class.
4130         * ui-file.c (no_terminal_escape_file::write)
4131         (no_terminal_escape_file::puts): New methods.
4132         * cli/cli-logging.c (handle_redirections): Use
4133         no_terminal_escape_file.
4134
4135 2019-06-14  Tom Tromey  <tromey@adacore.com>
4136
4137         * NEWS: Move convenience variable news above Python news.
4138
4139 2019-06-14  Tom Tromey  <tom@tromey.com>
4140
4141         * gnulib: Move directory to top-level.
4142         * configure.ac: Don't configure gnulib.
4143         * configure: Rebuild.
4144         * common/common-defs.h: Use new path to gnulib.
4145         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4146         (GNULIB_H): Remove.
4147         (INCGNU): Look in new gnulib location.
4148         (HFILES_NO_SRCDIR): Remove gnulib files.
4149         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4150         (generated_files): Remove GNULIB_H.
4151         ($(LIBGNU), all-lib): Remove targets.
4152         (distclean): Don't mention GNULIB_BUILDDIR.
4153         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4154
4155 2019-06-14  Tom Tromey  <tromey@adacore.com>
4156
4157         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4158         Warn if symbol file does not provide any symbols.
4159
4160 2019-06-14  Tom Tromey  <tromey@adacore.com>
4161
4162         * source.c (find_and_open_source): Respect basenames_may_differ.
4163
4164 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * annotate.c (annotate_breakpoints_invalid): Make use of
4167         scoped_restore_terminal_state.
4168         (annotate_frames_invalid): Likewise.
4169
4170 2019-06-14  Tom Tromey  <tromey@adacore.com>
4171
4172         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4173         allow assignment to an internalvar.
4174
4175 2019-06-14  Tom Tromey  <tromey@adacore.com>
4176
4177         * ada-lex.l: Allow "_" in attribute names.
4178
4179 2019-06-14  Tom Tromey  <tromey@adacore.com>
4180
4181         PR gdb/24653:
4182         * regcache.c (registers_changed): Don't call alloca.
4183         * top.c (execute_command): Don't call alloca.
4184
4185 2019-06-13  Pedro Alves  <palves@redhat.com>
4186
4187         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4188         'expression'.  When parsing an expression, error out if there's
4189         junk after "unlimited".
4190         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4191         (do_set_command): Adjust calls to is_unlimited_literal.
4192
4193 2019-06-13  Pedro Alves  <palves@redhat.com>
4194
4195         * compile/compile.c (make_compile_options_def_group): Add braces
4196         around array_view initializer.
4197         * thread.c (make_thread_apply_all_options_def_group)
4198         (make_thread_apply_all_options_def_group): Likewise.
4199
4200 2019-06-13  Pedro Alves  <palves@redhat.com>
4201
4202         * NEWS (New commands): Mention "maint test-options
4203         require-delimiter", "maint test-options unknown-is-error", "maint
4204         test-options unknown-is-operand" and "maint show
4205         test-options-completion-result".
4206         (New command options, command completion): New section.
4207         (Completion improvements): New section.
4208         Mention that you can abbreviate "unlimited".
4209
4210 2019-06-13  Pedro Alves  <palves@redhat.com>
4211
4212         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4213         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4214         * unittests/cli-utils-selftests.c (test_parse_flags)
4215         (test_parse_flags_qcs): Delete.
4216         (test_cli_utils): Don't call deleted functions.
4217
4218 2019-06-13  Pedro Alves  <palves@redhat.com>
4219
4220         * thread.c: Include "cli/cli-option.h".
4221         (tp_array_compar_ascending): Global.
4222         (tp_array_compar): Delete function.
4223         (tp_array_compar_ascending, tp_array_compar_descending): New
4224         functions.
4225         (ascending_option_def, qcs_flag_option_def)
4226         (thr_qcs_flags_option_defs)
4227         (make_thread_apply_all_options_def_group)
4228         (make_thread_apply_options_def_group): New.
4229         (thread_apply_all_command): Use gdb::option::process_options.
4230         (thread_apply_command_completer)
4231         (thread_apply_all_command_completer): New.
4232         (thread_apply_command): Use gdb::option::process_options.
4233         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4234         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4235         to generate help text of "thread apply".  Adjust "taas"'s help.
4236         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4237         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4238
4239 2019-06-13  Pedro Alves  <palves@redhat.com>
4240
4241         * thread.c (thread_apply_command): Check for invalid TID with
4242         isdigit instead of !isalpha.
4243
4244 2019-06-13  Pedro Alves  <palves@redhat.com>
4245
4246         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4247         (validate_flags_qcs): New.
4248         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4249         (validate_flags_qcs): Declare.
4250         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4251         (make_frame_apply_options_def_group): New.
4252         (frame_apply_command_count): Process options with
4253         gdb::option::process_options.
4254         (frame_apply_completer): New.
4255         (frame_apply_level_completer, frame_apply_all_completer)
4256         (frame_apply_completer): New.
4257         (_initialize_stack): Update help of "frame apply", "frame apply
4258         level", "frame apply all" and "faas" to mention supported options
4259         and install command completers.
4260         * stack.h (frame_apply_all_completer): Declare.
4261         * thread.c: Include "stack.h".
4262         (tfaas_command): Add "--".
4263         (_initialize_thread): Update help "tfaas" to mention supported
4264         options and install command completer.
4265
4266 2019-06-13  Pedro Alves  <palves@redhat.com>
4267
4268         * completer.c (complete_nested_command_line): New.
4269         (gdb_completion_word_break_characters_throw): Add assertion.
4270         * completer.h (complete_nested_command_line): Declare.
4271
4272 2019-06-13  Pedro Alves  <palves@redhat.com>
4273
4274         * stack.c (parse_backtrace_qualifiers): New.
4275         (backtrace_command): Use it.
4276         (backtrace_command_completer): Complete on qualifiers.
4277
4278 2019-06-13  Pedro Alves  <palves@redhat.com>
4279
4280         * frame.c: Include "cli/cli-option.h.
4281         (user_set_backtrace_options): New.
4282         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4283         Delete.
4284         (get_prev_frame): Adjust.
4285         (boolean_option_def, uinteger_option_def)
4286         (set_backtrace_option_defs): New.
4287         (_initialize_frame): Adjust and use
4288         gdb::option::add_setshow_cmds_for_options to install "set
4289         backtrace past-main" and "set backtrace past-entry".
4290         * frame.h: Include "cli/cli-option.h".
4291         (struct frame_print_options): Forward declare.
4292         (print_frame_arguments_all, print_frame_arguments_scalars)
4293         (print_frame_arguments_none): Declare.
4294         (print_entry_values): Delete declaration.
4295         (struct frame_print_options, user_frame_print_options): New.
4296         (struct set_backtrace_options): New.
4297         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4298         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4299         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4300         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4301         (list_args_or_locals): Add frame_print_options parameter.
4302         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4303         * python/py-framefilter.c (enumerate_args): Pass down
4304         USER_FRAME_PRINT_OPTIONS.
4305         * stack.c: Include "cli/cli-option.h".
4306         (print_frame_arguments_all, print_frame_arguments_scalars)
4307         (print_frame_arguments_none): Declare.
4308         (print_raw_frame_arguments, print_entry_values): Delete.
4309         (user_frame_print_options): New.
4310         (boolean_option_def, enum_option_def, frame_print_option_defs):
4311         New.
4312         (struct backtrace_cmd_options): New.
4313         (bt_flag_option_def): New.
4314         (backtrace_command_option_defs): New.
4315         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4316         (print_frame_arg, read_frame_arg, print_frame_args)
4317         (print_frame_info, print_frame): Add frame_print_options parameter
4318         and use it.
4319         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4320         (backtrace_command_1): Add frame_print_options and
4321         backtrace_cmd_options parameters and use them.
4322         (make_backtrace_options_def_group): New.
4323         (backtrace_command): Process command options with
4324         gdb::option::process_options.
4325         (backtrace_command_completer): New.
4326         (_initialize_stack): Extend "backtrace"'s help to mention
4327         supported options.  Install completer for "backtrace".
4328         Install some settings commands with add_setshow_cmds_for_options.
4329
4330 2019-06-13  Pedro Alves  <palves@redhat.com>
4331
4332         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4333         and that "set/show print raw frame-arguments" are now deprecated.
4334
4335         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4336         command.
4337         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4338         * stack.c (_initialize_stack): Install "set/show print
4339         raw-frame-arguments", and deprecate "set/show print raw
4340         frame-arguments".
4341         * valprint.c (_initialize_valprint): Deprecate "set/show print
4342         raw".
4343
4344 2019-06-13  Pedro Alves  <palves@redhat.com>
4345
4346         * compile/compile.c (struct compile_options): New.
4347         (compile_flag_option_def, compile_command_option_defs)
4348         (make_compile_options_def_group): New.
4349         (compile_file_command): Handle options with
4350         gdb::option::process_options.
4351         (compile_file_command_completer): New function.
4352         (compile_code_command): Handle options with
4353         gdb::option::process_options.
4354         (compile_code_command_completer): New function.
4355         (_initialize_compiler): Install completers for "compile code" and
4356         "compile file".  Mention available options in "compile code" and
4357         "compile code"'s help.
4358         * completer.c (advance_to_completion_word): New, factored out from
4359         ...
4360         (advance_to_expression_complete_word_point): ... this.
4361         (advance_to_filename_complete_word_point): New.
4362         * completer.h (advance_to_filename_complete_word_point): New
4363         declaration.
4364
4365 2019-06-13  Pedro Alves  <palves@redhat.com>
4366
4367         * compile/compile.c: Include "cli/cli-option.h".
4368         (compile_print_value): Scope data pointer is now a
4369         value_print_options pointer; adjust.
4370         (compile_print_command): Process options.  Scope data pointer is
4371         now a value_print_options pointer; adjust.
4372         (_initialize_compile): Update "compile print"'s help to include
4373         supported options.  Install a completer for "compile print".
4374         * cp-valprint.c (show_vtblprint, show_objectprint)
4375         (show_static_field_print): Delete.
4376         (_initialize_cp_valprint): Don't install "set print
4377         static-members", "set print vtbl", "set print object" here.
4378         * printcmd.c: Include "cli/cli-option.h" and
4379         "common/gdb_optional.h".
4380         (print_command_parse_format): Rework to fill in a
4381         value_print_options instead of a format_data.
4382         (print_value): Change parameter type from format_data pointer to
4383         value_print_options reference.  Adjust.
4384         (print_command_1): Process options.  Adjust to pass down a
4385         value_print_options.
4386         (print_command_completer): New.
4387         (_initialize_printcmd): Install print_command_completer as
4388         handle_brkchars completer for the "print" command.  Update
4389         "print"'s help to include supported options.
4390         * valprint.c: Include "cli/cli-option.h".
4391         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4392         here from cp-valprint.c.
4393         (boolean_option_def, uinteger_option_def)
4394         (value_print_option_defs, make_value_print_options_def_group):
4395         New.  Use gdb::option::add_setshow_cmds_for_options to install
4396         "set print elements", "set print null-stop", "set print repeats",
4397         "set print pretty", "set print union", "set print array", "set
4398         print address", "set print symbol", "set print array-indexes".
4399         * valprint.h: Include <string> and "cli/cli-option.h".
4400         (make_value_print_options_def_group): Declare.
4401         (print_value): Change parameter type from format_data pointer to
4402         value_print_options reference.
4403         (print_command_completer): Declare.
4404
4405 2019-06-13  Pedro Alves  <palves@redhat.com>
4406
4407         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4408         (COMMON_SFILES): Add maint-test-settings.c.
4409         * cli/cli-decode.c (boolean_enums): New global, factored out from
4410         ...
4411         (add_setshow_boolean_cmd): ... here.
4412         * cli/cli-decode.h (boolean_enums): Declare.
4413         * cli/cli-option.c: New file.
4414         * cli/cli-option.h: New file.
4415         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4416         factored out from ...
4417         (parse_cli_boolean_value(const char *)): ... this.
4418         (is_unlimited_literal): Change parameter type to pointer to
4419         pointer.  Adjust and advance ARG pointer.
4420         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4421         (parse_cli_var_enum): New, factored out from ...
4422         (do_set_command): ... this.  Adjust.
4423         * cli/cli-setshow.h (parse_cli_boolean_value)
4424         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4425         (parse_cli_var_enum): Declare.
4426         * cli/cli-utils.c: Include "cli/cli-option.h".
4427         (get_ulongest): New.
4428         * cli/cli-utils.h (get_ulongest): Declare.
4429         (check_for_argument): New overloads.
4430         * maint-test-options.c: New file.
4431
4432 2019-06-13  Pedro Alves  <palves@redhat.com>
4433
4434         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4435         parse a range if "-" is at the end of the string.
4436
4437 2019-06-13  Pedro Alves  <palves@redhat.com>
4438
4439         * cli/cli-setshow.c (parse_auto_binary_operation)
4440         (parse_cli_boolean_value): Don't allow "o".
4441
4442 2019-06-13  Pedro Alves  <palves@redhat.com>
4443
4444         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4445         * NEWS: Mention maint test-settings KIND.
4446         * maint-test-settings.c: New file.
4447
4448 2019-06-13  Pedro Alves  <palves@redhat.com>
4449
4450         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4451         completer.
4452         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4453         "set" completers.
4454
4455 2019-06-13  Pedro Alves  <palves@redhat.com>
4456
4457         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4458         after item.
4459
4460 2019-06-13  Pedro Alves  <palves@redhat.com>
4461
4462         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4463
4464 2019-06-13  Pedro Alves <palves@redhat.com>
4465
4466         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4467         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4468         call.
4469         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4470         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4471         calls.
4472         (check_for_argument): Skip spaces after argument.
4473
4474 2019-06-13  Pedro Alves  <palves@redhat.com>
4475
4476         * thread.c (thread_apply_command): Adjust TID parsing.
4477         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4478         detected before end of string.
4479         (tid_is_in_list): Error out if LIST is invalid.
4480
4481 2019-06-13  Pedro Alves  <palves@redhat.com>
4482
4483         * completer.c (complete_line_internal_1): Rewind completion word
4484         point.
4485         (completion_tracker::advance_custom_word_point_by): Change
4486         parameter type to int.
4487         * completer.h (completion_tracker::advance_custom_word_point_by):
4488         Likewise.
4489
4490 2019-06-13  Pedro Alves  <palves@redhat.com>
4491
4492         * completer.c (advance_to_completion_word): Handle delimiters.
4493
4494 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4495
4496         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4497
4498 2019-06-11  Tom Tromey  <tom@tromey.com>
4499
4500         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4501         (xmalloc_failed): Move to alloc.c.
4502         * alloc.c: New file.
4503         * Makefile.in (COMMON_SFILES): Add alloc.c.
4504
4505 2019-06-11  Tom Tromey  <tom@tromey.com>
4506
4507         * nat/linux-waitpid.c: Don't include server.h.
4508         (linux_debug): Remove.
4509         (my_waitpid): Update.
4510
4511 2019-06-11  Tom Tromey  <tromey@adacore.com>
4512
4513         * infcall.c (_initialize_infcall): Remove trailing newline from
4514         help.
4515         * user-regs.c (_initialize_user_regs): Remove trailing newline
4516         from help.
4517         * typeprint.c (_initialize_typeprint): Remove trailing newline
4518         from help.
4519         * reverse.c (_initialize_reverse): Remove trailing newlines from
4520         help.
4521         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4522         from help.
4523         * language.c (add_set_language_command): Remove trailing newline
4524         from help.
4525         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4526         help.
4527         * disasm.c (_initialize_disasm): Remove trailing newline from
4528         help.
4529         * top.c (init_main): Remove trailing newline from help.
4530         * interps.c (_initialize_interpreter): Remove trailing newline
4531         from help.
4532         * btrace.c (_initialize_btrace): Remove trailing newlines from
4533         help.
4534         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4535         from help.
4536         * python/python.c (_initialize_python): Remove trailing newline
4537         from help.
4538         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4539         help.
4540         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4541         from help.  Reformat some text.
4542         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4543         from help.
4544         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4545         newline from help.
4546
4547 2019-06-11  Tom Tromey  <tromey@adacore.com>
4548
4549         * darwin-nat.c (darwin_decode_exception_message)
4550         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4551
4552 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * valops.c (value_slice): Check for not allocated or not
4555         associated values.
4556
4557 2019-06-10  Tom de Vries  <tdevries@suse.de>
4558
4559         PR gdb/24618
4560         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4561         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4562         invalid.
4563
4564 2019-06-10  Tom de Vries  <tdevries@suse.de>
4565
4566         PR gdb/24611
4567         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4568         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4569
4570 2019-06-10  Tom de Vries  <tdevries@suse.de>
4571
4572         PR symtab/24545
4573         * symtab.c (struct demangled_name_entry): Add language field.
4574         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4575         static minimal symbol".  Set and use language field.
4576
4577 2019-06-10  Tom Tromey  <tromey@adacore.com>
4578
4579         * ada-lang.c (_initialize_ada_language): Update help text.
4580
4581 2019-06-10  Tom Tromey  <tromey@adacore.com>
4582
4583         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4584         with a newline.
4585         * guile/guile.c (handle_boot_error): Don't end warning with a
4586         newline.
4587         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4588         warning with a newline.
4589         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4590         newline.
4591         (s12z_frame_cache): Likewise.
4592         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4593         a newline.
4594         * solib-svr4.c (disable_probes_interface): Don't end warning with
4595         a newline.
4596         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4597         newline.
4598         * python/python.c (do_finish_initialization): Don't end warning
4599         with a newline.
4600
4601 2019-06-10  Tom Tromey  <tom@tromey.com>
4602
4603         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4604         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4605         gdbpy_enter.
4606
4607 2019-06-10  Tom Tromey  <tromey@adacore.com>
4608
4609         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4610         data.
4611         (elf_new_init): Don't call stabsread_new_init.
4612         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4613         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4614         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4615
4616 2019-06-10  Tom de Vries  <tdevries@suse.de>
4617
4618         PR symtab/16264
4619         PR symtab/24517
4620         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4621
4622 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4623
4624         * source.c (find_and_open_source): Also rewrite relative file
4625         names.
4626
4627 2019-04-26  Amos Bird  <amosbird@gmail.com>
4628
4629         * annotate.c (annotate_thread_exited): Add "thread-exited"
4630         annotation.
4631
4632 2019-06-06  Tom Tromey  <tromey@adacore.com>
4633
4634         * maint.h (class scoped_command_stats): Use
4635         DISABLE_COPY_AND_ASSIGN.
4636         <print_time>: New method.
4637         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4638         print_time.
4639         (scoped_command_stats::print_time): New method.
4640
4641 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4644         instructions of lengths 6 or 8 bytes.
4645
4646 2019-06-04  Pedro Alves  <palves@redhat.com>
4647
4648         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4649
4650         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4651         * breakpoint.c (condition_completer): Likewise.
4652         * cli/cli-dump.c (scan_expression): Likewise.
4653         * common/filestuff.c (mkdir_recursive): Likewise.
4654         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4655         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4656         (gdb_abspath): Likewise.
4657         * compile/compile-cplus-types.c
4658         (compile_cplus_instance::decl_name): Likewise.
4659         * completer.c (complete_explicit_location):
4660         (signal_completer, reg_or_group_completer_1): Likewise.
4661         * cp-support.c (cp_remove_params_if_any): Likewise.
4662         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4663         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4664         * infcmd.c (strip_bg_char): Likewise.
4665         * linespec.c (copy_token_string): Likewise.
4666         * mi/mi-main.c (output_cores): Likewise.
4667         * psymtab.c (psymtab_search_name):
4668         * symfile.c (test_set_ext_lang_command): Likewise.
4669         * target.c (target_fileio_read_stralloc): Likewise.
4670         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4671         * value.c (complete_internalvar): Likewise.
4672
4673 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4674
4675         Add objfile property to gdb.Type.
4676         * NEWS: Mention Python API addition.
4677         * python/py-type.c (typy_get_objfile): New method.
4678
4679 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4680
4681         * NEWS: Mention the new set|show style [title|highlight].
4682         Mention changes to "show style", "help" and "apropos".
4683
4684 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4685
4686         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4687         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4688         instead of print_help_for_command.
4689         (print_doc_of_command): New function.
4690         (help_list): Add 'apropos -v word' suggestion.
4691         (print_help_for_command): Style the command name using title style.
4692         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4693         (_initialize_cli_cmds): Describe -v in apropos_command help.
4694
4695 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4696
4697         * cli/cli-style.h (cli_style_option): Add name in constructor,
4698         add m_name class member, add constructor with intensity,
4699         add name class function.
4700         (cli_style_option::add_setshow_commands): Remove name argument.
4701         (highlight_style, title_style): New styles.
4702         * cli/cli-style.c (do_show): New function that shows a style
4703         characteristic styling the style name with itself.
4704         (set_style_name): New function.
4705         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4706         Update all callers according to the changes in cli/cli-style.h.
4707         * utils.h (fputs_highlighted): New function.
4708         * utils.c (fputs_highlighted): Likewise.
4709
4710 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4711
4712         * NEWS: Mention new pipe command and new convenience variables.
4713
4714 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4715
4716         * cli/cli-cmds.c (pipe_command): New function.
4717         (_initialize_cli_cmds): Call add_com for pipe_command.
4718         Define | as an alias for pipe.
4719         (exit_status_set_internal_vars): New function.
4720         (shell_escape): Call exit_status_set_internal_vars.
4721         cli/cli-decode.c (find_command_name_length): Recognize | as
4722         a single character command.
4723
4724 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725
4726         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4727         top.c (execute_command_to_ui_file): New function, mostly a copy
4728         of execute_command_to_string.
4729         (execute_command_to_string): Implement by calling
4730         execute_command_to_ui_file.
4731
4732 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4733
4734         * top.h (saved_command_line): Remove declaration.
4735         * top.c (previous_saved_command_line, previous_repeat_arguments):
4736         New variables.
4737         (saved_command_line): Make static, define together with other
4738         'repeat variables'.
4739         (dont_repeat): Clear repeat_arguments.
4740         (repeat_previous, get_saved_command_line, save_command_line):
4741         New functions.
4742         (gdb_init): Initialize saved_command_line
4743         and previous_saved_command_line.
4744         * main.c (captured_main_1): Remove saved_command_line initialization.
4745         * event-top.c (handle_line_of_input): Update to use
4746         the new 'repeat' related functions instead of direct access to
4747         saved_command_line.
4748         * command.h (repeat_previous, get_saved_command_line,
4749         save_command_line): New declarations.
4750         (dont_repeat): Add comment.
4751
4752 2019-05-30  Tom Tromey  <tromey@adacore.com>
4753
4754         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4755         Fix comment.
4756         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4757
4758 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4759
4760         PR cli/24587
4761         * completer.c (complete): Initialize variable word.
4762
4763 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4764
4765         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4766         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4767         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4768         'body' is NULL to the outter 'if', protecting the '!is_define'
4769         situation as well.
4770
4771 2019-05-29  Tom Tromey  <tromey@adacore.com>
4772
4773         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4774         (dwarf_unknown): New function.
4775         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4776         (dwarf_type_encoding_name): Use dwarf_unknown.
4777
4778 2019-05-29  Tom Tromey  <tromey@adacore.com>
4779
4780         PR c++/20020:
4781         * cp-valprint.c (cp_print_value_fields): Call
4782         cp_print_static_field inside "try".
4783
4784 2019-05-29  Tom Tromey  <tromey@adacore.com>
4785
4786         * inflow.c (struct terminal_info): Add default operator=.
4787         * configure: Rebuild.
4788         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4789         -Wdeprecated-copy-dtor, -Wredundant-move.
4790
4791 2019-05-29  Tom Tromey  <tromey@adacore.com>
4792
4793         * NEWS: Add entry.
4794         * infcmd.c (print_return_value_1): Handle finish_print
4795         option.
4796         (show_print_finish): New function.
4797         (_initialize_infcmd): Add "set/show print finish" commands.
4798         * valprint.c (user_print_options): Initialize new member.
4799         * valprint.h (struct value_print_options) <finish_print>: New
4800         member.
4801
4802 2019-05-28  Tom Tromey  <tromey@adacore.com>
4803
4804         * ada-lang.c (ada_remove_Xbn_suffix)
4805         (find_old_style_renaming_symbol)
4806         (parse_old_style_renaming): Remove.
4807         (ada_find_renaming_symbol): Don't call
4808         find_old_style_renaming_symbol.
4809         (ada_is_renaming_symbol): Rename from
4810         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4811         bool.  Now static.
4812         (ada_read_var_value): Update and simplify.
4813         * ada-exp.y (write_var_or_type): Remove old code.
4814
4815 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4816
4817         * event-top.c: Remove include comment.
4818         * inflow.c (class scoped_ignore_sigttou): Move from here...
4819         * inflow.h (class scoped_ignore_sigttou): ...to here.
4820         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4821         * top.c:  Remove include comment.
4822
4823 2019-05-27  Tom Tromey  <tom@tromey.com>
4824
4825         * NEWS: Fix typo.
4826
4827 2019-05-22  Tom Tromey  <tromey@adacore.com>
4828
4829         * target.c (target_follow_exec): Constify parameter.
4830         * target-delegates.c: Rebuild.
4831         * remote.c (remote_target::follow_exec): Constify parameter.
4832         * infrun.c (follow_exec): Constify parameter.
4833         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4834         (target_follow_exec): Likewise.
4835
4836 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4837
4838         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4839         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4840
4841 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4842
4843         * NEWS: Add debugredirect and testsuite sections.
4844
4845 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4846
4847         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4848         target descriptions using exclusively floating point register name
4849         aliases.
4850
4851 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4852
4853         PR gdb/18644:
4854         * f-lang.c (build_fortran_types): Handle the case where
4855         gdbarch_floatformat_for_type returns a nullptr.
4856
4857 2019-05-21  Tom de Vries  <tdevries@suse.de>
4858
4859         PR cli/24587
4860         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4861
4862 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         PR gdb/18644:
4865         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4866         16-byte floats.
4867         * i386-tdep.c (i386_floatformat_for_type): Use
4868         floatformats_ia64_quad for the 16-byte floating point component
4869         within a fortran 32-byte complex number.
4870
4871 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4874         delete default constructor.
4875         (find_partial_die): Update to return const struct.
4876         (partial_die_parent_scope): Move variable declaration into scope
4877         of its use and change its type to auto.
4878         (guess_partial_die_structure_name): Likewise.
4879         (partial_die_info::fixup): Likewise.
4880
4881 2019-05-17  Tom Tromey  <tromey@adacore.com>
4882
4883         * source.c (find_and_open_source): Remove cast.
4884
4885 2019-05-17  Tom Tromey  <tromey@adacore.com>
4886
4887         * annotate.c (annotate_source): Make "filename" const.
4888         * annotate.h (annotate_source): Use const.
4889
4890 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4891
4892         * disasm.c (set_disassembler_options): Send errors to stderr.
4893
4894 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4895
4896         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4897         (cli_interp_base::set_logging): Check debug_redirect.
4898         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4899         * cli/cli-logging.c (debug_redirect): Add static variable.
4900         (pop_output_files): Add default param.
4901         (handle_redirections): Print debug setting.
4902         (show_logging_command): Likewise.
4903         (_initialize_cli_logging): Add debugredirect command.
4904         * interps.c (current_interp_set_logging): Add debug_redirect
4905         parameter.
4906         * interps.h (set_logging): Add debug_redirect parameter.
4907         (current_interp_set_logging): Likewise.
4908         * mi/mi-common.h: Likewise.
4909         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4910
4911 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4912             Tom Tromey  <tromey@adacore.com>
4913
4914         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4915         directly.
4916         * cli/cli-interp.h (make_logging_output): Remove declaration.
4917         * cli/cli-logging.c (make_logging_output): Remove function.
4918         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4919         directly.
4920         * ui-file.c (tee_file::tee_file): Remove bools.
4921         (tee_file::~tee_file): Remove deletes.
4922         * ui-file.h (tee_file): Remove bools.
4923
4924 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4925
4926         * mi/mi-cmds.h (mi_cmd_complete): New function.
4927         * mi/mi-main.c (mi_cmd_complete): Likewise.
4928         * mi/mi-cmds.c: Define new MI command -complete.
4929         * NEWS: Mention new -complete command.
4930
4931 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4932
4933         * completer.h (complete): New function.
4934         * completer.c (complete): Likewise.
4935         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4936         function defined in completer.h.
4937
4938 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4939
4940         * MAINTAINERS (Write After Approval): Add myself.
4941
4942 2019-05-17  Tom de Vries  <tdevries@suse.de>
4943
4944         PR gdb/24094
4945         * dwarf2read.c (struct cu_partial_die_info): New struct.
4946         (find_partial_die): Return cu_partial_die_info.
4947         (partial_die_parent_scope, guess_partial_die_structure_name)
4948         (partial_die_info::fixup): Handle new return type of find_partial_die.
4949
4950 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4951
4952         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4953         "std::string", simplifying the algorithm.
4954
4955 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4956
4957         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4958         (stap_static_probe_ops::get_probes): Likewise.
4959
4960 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4961
4962         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4963         '-')" and "else if".
4964         (stap_parse_single_operand): Join checks for
4965         "gdbarch_stap_parse_special_token_p" and
4966         "gdbarch_stap_parse_special_token" in the same "if" statement.
4967         Invert check when verifying for operation on register
4968         displacement.
4969
4970 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4971
4972         * stap-probe.c (stap_get_opcode): Update comment.
4973         (stap_get_expected_argument_type): Likewise.
4974         (handle_stap_probe): Likewise.
4975
4976 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4977
4978         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4979         return type to 'bool'.  Adjust comment.  Use 'bool' when
4980         appropriate.
4981         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4982         * stap-probe.c (stap_parse_argument_1): Likewise.
4983         (stap_is_operator): Likewise.
4984         (stap_is_generic_prefix): Likewise.
4985         (stap_is_register_prefix): Likewise.
4986         (stap_is_register_indirection_prefix): Likewise.
4987         (stap_is_integer_prefix): Likewise.
4988         (stap_generic_check_suffix): Likewise.
4989         (stap_check_integer_suffix): Likewise.
4990         (stap_check_register_suffix): Likewise.
4991         (stap_check_register_indirection_suffix): Likewise.
4992         (stap_parse_register_operand): Likewise.
4993         (stap_parse_single_operand): Likewise.
4994         (stap_parse_argument_1): Likewise.
4995         (stap_probe::get_argument_count): Likewise.
4996         (stap_is_operator): Likewise.
4997
4998 2019-05-16  Tom Tromey  <tromey@adacore.com>
4999
5000         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5001         keyword to foreach.
5002
5003 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5004
5005         * linux-thread-db.c (try_thread_db_load_1): Change return type
5006         to bool.
5007         (try_thread_db_load): Likewise.
5008         (try_thread_db_load_from_pdir_1): Likewise.
5009         (try_thread_db_load_from_pdir): Likewise.
5010         (try_thread_db_load_from_sdir): Likewise.
5011         (try_thread_db_load_from_dir): Likewise.
5012         (thread_db_load_search): Likewise.
5013         (has_libpthread): Likewise.
5014         (thread_db_load): Likewise.
5015
5016 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5017
5018         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5019         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5020         NULL, and complain/return if that's the case.
5021
5022 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5023
5024         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5025         (advance, posn, abstract_read_memory): New functions.
5026         [struct mem_read_abstraction]: New struct.
5027         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5028
5029 2019-05-14  Tom Tromey  <tromey@adacore.com>
5030
5031         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5032         value is not lval_memory.
5033
5034 2019-05-14  Tom Tromey  <tromey@adacore.com>
5035
5036         * solib.c (info_sharedlibrary_command): Style the file name.
5037
5038 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5039
5040         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5041         (aarch64_vnv_type): Likewise.
5042         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5043         * common/tdesc.c: Likewise.
5044         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5045         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5046         * features/aarch64-fpu.xml: Add ieee half view.
5047         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5048         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5049         * gdbtypes.h (struct builtin_type): Likewise.
5050         (struct objfile_type): Likewise.
5051
5052 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5053
5054         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5055         typo.
5056         * location.h (string_to_event_location): Likewise.
5057
5058 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5059
5060         GDB 8.3 released.
5061
5062 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5063
5064         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5065         New variable declaration.
5066         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5067         New variable.
5068         (print_one_breakpoint): Use ui_out::test_flags and new global
5069         variable to compute use_fixed_output.
5070         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5071         Remove.
5072         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5073         (mi_multi_location_breakpoint_output_fixed): Remove.
5074         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5075         new variable.
5076         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5077         fix_multi_location_breakpoint_output flag if version >= 3.
5078         * ui-out.h (enum ui_out_flag)
5079         <fix_multi_location_breakpoint_output>: New enumerator.
5080
5081 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5082
5083         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5084
5085 2019-05-10  Tom Tromey  <tromey@adacore.com>
5086
5087         * ada-lang.c (catch_ada_completer): New function.
5088         (_initialize_ada_language): Use it.
5089
5090 2019-05-10  Tom Tromey  <tromey@adacore.com>
5091
5092         * thread.c (print_thread_info): Make "requested_threads" const.
5093         * gdbthread.h (print_thread_info): Make "requested_threads"
5094         const.
5095         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5096         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5097
5098 2019-05-08  Tom Tromey  <tom@tromey.com>
5099
5100         * gdbtypes.c (objfile_type_data): Change type.
5101         (objfile_type, _initialize_gdbtypes): Update.
5102
5103 2019-05-08  Tom Tromey  <tom@tromey.com>
5104
5105         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5106         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5107         (_initialize_dwarf2_frame): Update.
5108
5109 2019-05-08  Tom Tromey  <tom@tromey.com>
5110
5111         * objc-lang.c (objc_objfile_data): Change type.
5112         (find_methods): Update.
5113         (_initialize_objc_lang): Remove.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * stabsread.c (rs6000_builtin_type_data): Change type.
5118         (rs6000_builtin_type, _initialize_stabsread): Update.
5119
5120 2019-05-08  Tom Tromey  <tom@tromey.com>
5121
5122         * mips-tdep.c (mips_pdr_data): Remove.
5123         (_initialize_mips_tdep): Update.
5124
5125 2019-05-08  Tom Tromey  <tom@tromey.com>
5126
5127         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5128         (hppa_init_objfile_priv_data, read_unwind_info)
5129         (find_unwind_entry, _initialize_hppa_tdep): Update.
5130
5131 2019-05-08  Tom Tromey  <tom@tromey.com>
5132
5133         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5134         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5135         on obstack.
5136         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5137
5138 2019-05-08  Tom Tromey  <tom@tromey.com>
5139
5140         * mdebugread.c (basic_type_data): Change type.
5141         (basic_type, _initialize_mdebugread): Update.
5142
5143 2019-05-08  Tom Tromey  <tom@tromey.com>
5144
5145         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * nto-tdep.c (nto_inferior_data_reg): Change type.
5150         (nto_inferior_data): Update.
5151         (nto_inferior_data_cleanup, nto_new_inferior_data)
5152         (_initialize_nto_tdep): Remove.
5153         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5154
5155 2019-05-08  Tom Tromey  <tom@tromey.com>
5156
5157         * ada-lang.c (struct ada_inferior_data): Add initializers.
5158         (ada_inferior_data): Change type.
5159         (ada_inferior_data_cleanup): Remove.
5160         (get_ada_inferior_data, ada_inferior_exit)
5161         (struct ada_pspace_data): Add initializers, destructor.
5162         (ada_pspace_data_handle): Change type.
5163         (get_ada_pspace_data): Update.
5164         (ada_pspace_data_cleanup): Remove.
5165
5166 2019-05-08  Tom Tromey  <tom@tromey.com>
5167
5168         * coffread.c (struct coff_symfile_info): Add initializers.
5169         (coff_objfile_data_key): Move lower.  Change type.
5170         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5171         Update.
5172         (coff_free_info): Remove.
5173
5174 2019-05-08  Tom Tromey  <tom@tromey.com>
5175
5176         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5177         (fbsd_pspace_data_handle): Move lower.  Change type.
5178         (get_fbsd_pspace_data): Update.
5179         (fbsd_pspace_data_cleanup): Remove.
5180         (_initialize_fbsd_tdep): Update.
5181
5182 2019-05-08  Tom Tromey  <tom@tromey.com>
5183
5184         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5185         (get_ada_tasks_pspace_data): Update.
5186         (ada_tasks_pspace_data_cleanup): Remove.
5187         (_initialize_tasks): Update.
5188         (ada_tasks_inferior_data_handle): Change type.
5189         (get_ada_tasks_inferior_data): Update.
5190         (ada_tasks_inferior_data_cleanup): Remove.
5191         (struct ada_tasks_pspace_data): Add initializers.
5192
5193 2019-05-08  Tom Tromey  <tom@tromey.com>
5194
5195         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5196         * symfile-debug.c (debug_sym_get_probes): Change type.
5197         * stap-probe.c (handle_stap_probe):
5198         (stap_static_probe_ops::get_probes): Change type.
5199         * probe.h (class static_probe_ops) <get_probes>: Change type.
5200         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5201         (parse_probes_in_pspace): Update.
5202         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5203         Update.
5204         (any_static_probe_ops::get_probes): Change type.
5205         * elfread.c (elfread_data): New typedef.
5206         (probe_key): Change type.
5207         (elf_get_probes): Likewise.  Update.
5208         (probe_key_free): Remove.
5209         (_initialize_elfread): Update.
5210         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5211         Change type.
5212         (dtrace_process_dof_probe, dtrace_process_dof)
5213         (dtrace_static_probe_ops::get_probe): Change type.
5214
5215 2019-05-08  Tom Tromey  <tom@tromey.com>
5216
5217         * xcoffread.c (struct xcoff_symfile_info): Rename from
5218         coff_symfile_info.  Add initializers.
5219         (xcoff_objfile_data_key): Move lower.  Change type.
5220         (XCOFF_DATA): Rewrite.
5221         (xcoff_free_info): Remove.
5222         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5223         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5224         (xcoff_initial_scan): Update.
5225
5226 2019-05-08  Tom Tromey  <tom@tromey.com>
5227
5228         * solib-svr4.c (struct svr4_info): Add initializers and
5229         destructor.
5230         <probes_table>: Now an htab_up.
5231         (solib_svr4_pspace_data): Change type.
5232         (free_probes_table): Simplify.
5233         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5234         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5235         (probes_table_remove_objfile_probes, register_solib_event_probe)
5236         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5237         (_initialize_svr4_solib): Update.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * remote.c (remote_pspace_data): Change type.
5242         (remote_pspace_data_cleanup): Remove.
5243         (get_remote_exec_file, set_pspace_remote_exec_file)
5244         (_initialize_remote): Update.
5245
5246 2019-05-08  Tom Tromey  <tom@tromey.com>
5247
5248         * breakpoint.c (breakpoint_objfile_key): Change type.
5249         (get_breakpoint_objfile_data): Update.
5250         (free_breakpoint_objfile_data): Remove.
5251         (_initialize_breakpoint): Update.
5252
5253 2019-05-08  Tom Tromey  <tom@tromey.com>
5254
5255         * linux-tdep.c (struct linux_info): Add initializers.
5256         (linux_inferior_data): Move.  Change type.
5257         (invalidate_linux_cache_inf): Update.
5258         (linux_inferior_data_cleanup): Remove.
5259         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5260
5261 2019-05-08  Tom Tromey  <tom@tromey.com>
5262
5263         * auxv.c (auxv_inferior_data): Move.  Change type.
5264         (auxv_inferior_data_cleanup): Remove.
5265         (invalidate_auxv_cache_inf): Rewrite.
5266         (get_auxv_inferior_data, _initialize_auxv): Update.
5267
5268 2019-05-08  Tom Tromey  <tom@tromey.com>
5269
5270         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5271         (symfile_debug_objfile_data_key): Change type.
5272         (symfile_debug_installed, debug_qf_has_symbols)
5273         (debug_qf_find_last_source_symtab)
5274         (debug_qf_forget_cached_source_info)
5275         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5276         (debug_qf_print_stats, debug_qf_dump)
5277         (debug_qf_expand_symtabs_for_function)
5278         (debug_qf_expand_all_symtabs)
5279         (debug_qf_expand_symtabs_with_fullname)
5280         (debug_qf_map_matching_symbols)
5281         (debug_qf_expand_symtabs_matching)
5282         (debug_qf_find_pc_sect_compunit_symtab)
5283         (debug_qf_map_symbol_filenames)
5284         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5285         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5286         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5287         (debug_sym_read_linetable, debug_sym_relocate): Update.
5288         (symfile_debug_free_objfile): Remove.
5289         (install_symfile_debug_logging, _initialize_symfile_debug):
5290         Update.
5291
5292 2019-05-08  Tom Tromey  <tom@tromey.com>
5293
5294         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5295         allocate_on_obstack.
5296         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5297         (get_dwarf2_per_objfile): Update.
5298         (set_dwarf2_per_objfile): Remove.
5299         (dwarf2_has_info, dwarf2_get_section_info): Update.
5300         (dwarf2_free_objfile): Remove.
5301         (_initialize_dwarf2_read): Update.
5302
5303 2019-05-08  Tom Tromey  <tom@tromey.com>
5304
5305         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5306         initializers.
5307         <unsupported_script_warning_printed,
5308         script_not_found_warning_printed>: Now bool.
5309         (auto_load_pspace_data): Change type.
5310         (~auto_load_pspace_info): Rename from
5311         auto_load_pspace_data_cleanup.
5312         (get_auto_load_pspace_data, init_loaded_scripts_info)
5313         (clear_section_scripts, maybe_print_unsupported_script_warning)
5314         (maybe_print_script_not_found_warning, _initialize_auto_load):
5315         Update.
5316
5317 2019-05-08  Tom Tromey  <tom@tromey.com>
5318
5319         * objfiles.c (objfile_pspace_info): Add destructor and
5320         initializers.
5321         (objfiles_pspace_data): Change type.
5322         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5323         (get_objfile_pspace_data): Update.
5324         (objfiles_bfd_data): Change type.
5325         (get_objfile_bfd_data): Update.
5326         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5327
5328 2019-05-08  Tom Tromey  <tom@tromey.com>
5329
5330         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5331         Change type.
5332         (get_catch_syscall_inferior_data): Update.
5333         (catch_syscall_inferior_data_cleanup): Remove.
5334         (_initialize_break_catch_syscall): Update.
5335
5336 2019-05-08  Tom Tromey  <tom@tromey.com>
5337
5338         * inflow.c (struct terminal_info): Add destructor and
5339         initializers.
5340         (inflow_inferior_data): Change type.
5341         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5342         (get_inflow_inferior_data, inflow_inferior_exit)
5343         (swap_terminal_info, _initialize_inflow): Update.
5344
5345 2019-05-08  Tom Tromey  <tom@tromey.com>
5346
5347         * target-dcache.c (target_dcache_cleanup): Remove.
5348         (target_dcache_aspace_key): Change type.
5349         (target_dcache_init_p, target_dcache_invalidate)
5350         (target_dcache_get, target_dcache_get_or_init)
5351         (_initialize_target_dcache): Update.
5352         * dcache.h (struct dcache_deleter): New.
5353
5354 2019-05-08  Tom Tromey  <tom@tromey.com>
5355
5356         * symtab.c (struct symbol_cache): Add destructor and
5357         initializers.
5358         (symbol_cache_key): Move.  Change type.
5359         (make_symbol_cache, free_symbol_cache): Remove.
5360         (get_symbol_cache): Update.
5361         (symbol_cache_cleanup): Remove.
5362         (ALL_PSPACES, symbol_cache_flush)
5363         (maintenance_print_symbol_cache)
5364         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5365         Update.
5366
5367 2019-05-08  Tom Tromey  <tom@tromey.com>
5368
5369         * symtab.c (struct main_info): Add destructor and initializers.
5370         (main_progspace_key): Move.  Change type.
5371         (get_main_info): Update.
5372         (main_info_cleanup): Remove.
5373         (_initialize_symtab): Update.
5374
5375 2019-05-08  Tom Tromey  <tom@tromey.com>
5376
5377         * registry.h (DECLARE_REGISTRY): Define the _key class.
5378
5379 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * NEWS: Merge two 'New commands' sections.
5382
5383 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5384
5385         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5386         parameter and use Ada language definition instead.
5387         (ada_val_print_ptr): Remove unused language parameter.
5388         (ada_val_print_num): Remove language parameter and use Ada language
5389         definition instead.
5390         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5391         parameter.
5392         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5393         parameter and use Ada language definition instead.
5394         (ada_val_print_1): Update all ada_val_print_xxx calls.
5395         Remove language parameter.
5396         (ada_val_print): Update ada_val_print_1 call.
5397
5398 2019-05-08  Tom Tromey  <tromey@adacore.com>
5399
5400         * remote.c (remote_hw_watchpoint_limit)
5401         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5402         Now static.
5403
5404 2019-05-08  Tom Tromey  <tromey@adacore.com>
5405
5406         * maint.c (_initialize_maint_cmds): Move initialization code to
5407         remote.c.
5408         (watchdog, show_watchdog): Move to remote.c.
5409         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5410         "watchdog" static.
5411         (_initialize_remote): Move initialization code from maint.c.
5412         * defs.h (watchdog): Don't declare.
5413
5414 2019-05-08  Tom Tromey  <tromey@adacore.com>
5415
5416         * tui/tui-interp.c: Include main.h.
5417         * interps.c: Include main.h.
5418         * main.h (interpreter_p): Declare.
5419         * defs.h (interpreter_p): Don't declare.
5420
5421 2019-05-08  Tom Tromey  <tromey@adacore.com>
5422
5423         * dwarf2loc.c: Include dwarf2read.h.
5424         * defs.h (read_unsigned_leb128): Don't declare.
5425         * dwarf2read.h (read_unsigned_leb128): Declare.
5426
5427 2019-05-08  Tom Tromey  <tromey@adacore.com>
5428
5429         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5430         method.
5431
5432 2019-05-08  Tom Tromey  <tromey@adacore.com>
5433
5434         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5435         when no wrap column is set.
5436
5437 2019-05-08  Tom Tromey  <tromey@adacore.com>
5438
5439         * c-lang.c (c_get_string): Handle non-C-style arrays.
5440
5441 2019-05-08  Tom Tromey  <tromey@adacore.com>
5442
5443         * typeprint.c (print_offset_data::update): Print the bit offset,
5444         not the number of bits remaining.
5445
5446 2019-05-08  Tom Tromey  <tromey@adacore.com>
5447
5448         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5449         padding at end of comment.
5450
5451 2019-05-08  Tom Tromey  <tromey@adacore.com>
5452
5453         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5454         Compare main types.
5455
5456 2019-05-06  Tom Tromey  <tom@tromey.com>
5457
5458         * common/scoped_mmap.c: Include common-defs.h.
5459         * common/scoped_mmap.h: Don't include config.h.
5460
5461 2019-05-04  Tom Tromey  <tom@tromey.com>
5462
5463         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5464         (struct aarch64_call_info): Add initializers.
5465         <si>: Now a std::vector.
5466         (pass_on_stack, aarch64_push_dummy_call): Update.
5467
5468 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5469             Tom Tromey  <tom@tromey.com>
5470
5471         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5472         (ppc_threads): Now a std::vector.  Now static.
5473         (hwdebug_find_thread_points_by_tid)
5474         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5475         Update.
5476
5477 2019-05-04  Tom Tromey  <tom@tromey.com>
5478
5479         * arc-tdep.c (arc_tdesc_init): Return bool.
5480
5481 2019-05-04  Tom Tromey  <tom@tromey.com>
5482
5483         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5484         Use gdb_assert_not_reached.
5485
5486 2019-05-04  Tom Tromey  <tom@tromey.com>
5487
5488         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5489         "false".
5490
5491 2019-05-04  Tom Tromey  <tom@tromey.com>
5492
5493         * arc-tdep.c (arc_tdesc_init): Use bool.
5494
5495 2019-05-04  Tom Tromey  <tom@tromey.com>
5496
5497         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5498
5499 2019-05-04  Tom Tromey  <tom@tromey.com>
5500
5501         * cli/cli-cmds.c (valid_command_p): Return bool.
5502
5503 2019-05-04  Tom Tromey  <tom@tromey.com>
5504
5505         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5506         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5507
5508 2019-05-04  Raul Tambre  <raul@tambre.ee>
5509
5510         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5511         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5512         operator for comparison.
5513
5514 2019-05-04  Tom Tromey  <tom@tromey.com>
5515
5516         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5517         (lookup_partial_symbol, print_partial_symbols)
5518         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5519         (psymbol_compare): Update.
5520         (add_psymbol_to_bcache): Clear the entire psymbol.
5521         (maintenance_check_psymtabs): Update.
5522         * psympriv.h (struct partial_symbol): Don't derive from
5523         general_symbol_info.
5524         <obj_section, unrelocated_address, address,
5525         set_unrelocated_address>: Update.
5526         <ginfo>: New member.
5527         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5528         (debug_names::write_psymbols): Update.
5529
5530 2019-05-04  Tom de Vries  <tdevries@suse.de>
5531
5532         * contrib/cc-with-tweaks.sh: Support -n arg.
5533
5534 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5535
5536         * corelow.c (core_target::detach): Ensure frame cache and
5537         register caches are cleared.
5538         inferior.c (exit_inferior_1): Likewise.
5539
5540 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5541             Tom Tromey  <tom@tromey.com>
5542
5543         * dictionary.c (collate_pending_symbols_by_language): Remove
5544         "struct" from foreach.
5545         * symtab.c (lookup_global_symbol_from_objfile)
5546         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5547         foreach.
5548         * ser-tcp.c (net_open): Remove "struct" from foreach.
5549         * objfiles.c (objfile_relocate, objfile_rebase)
5550         (objfile_has_symbols): Remove "struct" from foreach.
5551         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5552         from foreach.
5553         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5554         foreach.
5555         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5556         "struct" from foreach.
5557         * ada-lang.c (create_excep_cond_exprs)
5558         (ada_exception_catchpoint_cond_string): Remove "struct" from
5559         foreach.
5560
5561 2019-05-03  Tom Tromey  <tromey@adacore.com>
5562
5563         * ada-exp.y (convert_char_literal): Check suffix of each
5564         enumerator.
5565
5566 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5567
5568         PR ada/21406:
5569         * ada-exp.y (yywrap): Don't define.
5570         * ada-lex.l (%option): Add noyywrap
5571         (yywrap): Remove.
5572
5573 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5574
5575         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5576         _WIN32_WINNT to the XP level, unless already defined to a higher
5577         level.
5578
5579         * unittests/parse-connection-spec-selftests.c:
5580         * ser-tcp.c:
5581         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5582         override.
5583
5584         * symfile.c (find_separate_debug_file): Remove colon from the
5585         drive spec of DOS/Windows file names of the target, so that the
5586         file name produced from DEBUGDIR and the target's directory will
5587         be valid on DOS/Windows systems.
5588
5589 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * rust-lang.c (val_print_struct): Handle printing structures
5592         containing strings.
5593
5594 2019-05-02  Tom Tromey  <tromey@adacore.com>
5595
5596         * valarith.c (_initialize_valarith): Remove.
5597
5598 2019-05-01  Tom Tromey  <tromey@adacore.com>
5599
5600         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5601         bitfields.
5602
5603 2019-05-01  Tom Tromey  <tromey@adacore.com>
5604
5605         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5606         for big-endian copies.
5607
5608 2019-04-30  Ali Tamur  <tamur@google.com>
5609         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5610         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5611         (read_3_bytes): New function.
5612
5613 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5614
5615         * windows-nat.c (main_thread_id): Delete.
5616         (handle_output_debug_string): Replace main_thread_id by
5617         current_event.dwThreadId.
5618         (fake_create_process): Likewise.
5619         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5620         Do not set main_thread_id.
5621         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5622         current_event.dwThreadId.
5623         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5624
5625 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5626
5627         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5628         Use current_event.dwThreadId instead of main_thread_id.
5629
5630 2019-04-30  Tom Tromey  <tromey@adacore.com>
5631
5632         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5633         (create_excep_cond_exprs): Iterate over program spaces.
5634         (ada_exception_catchpoint_cond_string): Examine all minimal
5635         symbols for exception types.
5636
5637 2019-04-30  Tom Tromey  <tromey@adacore.com>
5638
5639         PR c++/24470:
5640         * dwarf2read.c (process_structure_scope): Handle case where type
5641         has template parameters but no symbol was created.
5642
5643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5644             Chris January  <chris.january@arm.com>
5645
5646         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5647         qualifier.
5648         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5649
5650 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5651
5652         * f-typeprint.c (f_print_type): Update rules for printing
5653         whitespace.
5654         (f_type_print_varspec_suffix): Likewise.
5655
5656 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5657             Chris January  <chris.january@arm.com>
5658
5659         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5660         function arguments.
5661
5662 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5663
5664         * f-lang.c (build_fortran_types): Change name of void type to
5665         lower case.
5666         * f-typeprint.c (f_type_print_base): Print the name of the void
5667         type, rather than a fixed string.
5668         * f-valprint.c (f_decorations): Use lower case void string.
5669
5670 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5671             Chris January  <chris.january@arm.com>
5672
5673         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5674         types for Fortran.
5675
5676 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5677             Chris January  <chris.january@arm.com>
5678             David Lecomber  <david.lecomber@arm.com>
5679
5680         * f-exp.y (BINOP_INTRINSIC): New token.
5681         (exp): New parser rule handling BINOP_INTRINSIC.
5682         (f77_keywords): Add new builtin procedures.
5683         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5684         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5685         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5686         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5687         (print_unop_subexp_f): New function.
5688         (print_binop_subexp_f): New function.
5689         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5690         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5691         (dump_subexp_body_f): Likewise.
5692         (operator_check_f): Likewise.
5693         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5694         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5695
5696 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5697
5698         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5699         UNOP_KIND.
5700         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5701         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5702         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5703         (operator_length_f): New fuction.
5704         (print_subexp_f): New function.
5705         (op_name_f): New function.
5706         (dump_subexp_body_f): New function.
5707         (operator_check_f): New function.
5708         (exp_descriptor_f): Replace standard expression handling functions
5709         with new functions.
5710         * gdb/fortran-operator.def: New file.
5711         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5712         * gdb/std-operator.def: Remove UNOP_KIND.
5713
5714 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5715
5716         * std-operator.def: Remove unbalanced, stray double quote
5717         character.
5718
5719 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5720             Chris January  <chris.january@arm.com>
5721             Daniel Everett  <daniel.everett@arm.com>
5722             Nick Forrington  <nick.forrington@arm.com>
5723             Richard Bunt  <richard.bunt@arm.com>
5724
5725         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5726         of depth when printing anonymous structs or unions.
5727         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5728         Don't print either the top-level value, or the children if the
5729         max-depth is exceeded.
5730         (ppscm_print_children): When printing the key of a map, allow one
5731         extra level of depth.
5732         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5733         print either the top-level value, or the children if the max-depth
5734         is exceeded.
5735         (print_children): When printing the key of a map, allow one extra
5736         level of depth.
5737         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5738         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5739         (user_print_options): Initialise max_depth field.
5740         (val_print_scalar_or_string_type_p): New function.
5741         (val_print): Check to see if the max depth has been reached.
5742         (val_print_check_max_depth): Define new function.
5743         (show_print_max_depth): New function.
5744         (_initialize_valprint): Add 'print max-depth' option.
5745         * valprint.h (struct value_print_options) <max_depth>: New field.
5746         (val_print_check_max_depth): Declare new function.
5747         * NEWS: Document new feature.
5748
5749 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5750
5751         * ada-lang.c (ada_language_defn): Initialise new field.
5752         * c-lang.c (c_is_string_type_p): New function.
5753         (c_language_defn): Initialise new field.
5754         (cplus_language_defn): Initialise new field.
5755         (asm_language_defn): Initialise new field.
5756         (minimal_language_defn): Initialise new field.
5757         * c-lang.h (c_is_string_type_p): Declare new function.
5758         * d-lang.c (d_language_defn): Initialise new field.
5759         * f-lang.c (f_is_string_type_p): New function.
5760         (f_language_defn): Initialise new field.
5761         * go-lang.c (go_is_string_type_p): New function.
5762         (go_language_defn): Initialise new field.
5763         * language.c (default_is_string_type_p): New function.
5764         (unknown_language_defn): Initialise new field.
5765         (auto_language_defn): Initialise new field.
5766         * language.h (struct language_defn) <la_is_string_type_p>: New
5767         member variable.
5768         (default_is_string_type_p): Declare new function.
5769         * m2-lang.c (m2_language_defn): Initialise new field.
5770         * objc-lang.c (objc_language_defn): Initialise new field.
5771         * opencl-lang.c (opencl_language_defn): Initialise new field.
5772         * p-lang.c (pascal_is_string_type_p): New function.
5773         (pascal_language_defn): Initialise new field.
5774         * rust-lang.c (rust_is_string_type_p): New function.
5775         (rust_language_defn): Initialise new field.
5776
5777 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5780         New field.
5781         * ada-lang.c (ada_language_defn): Initialise new field.
5782         * c-lang.c (c_language_defn): Likewise.
5783         (cplus_language_defn): Likewise.
5784         (asm_language_defn): Likewise.
5785         (minimal_language_defn): Likewise.
5786         * d-lang.c (d_language_defn): Likewise.
5787         * f-lang.c (f_language_defn): Likewise.
5788         * go-lang.c (go_language_defn): Likewise.
5789         * language.c (unknown_language_defn): Likewise.
5790         (auto_language_defn): Likewise.
5791         * m2-lang.c (m2_language_defn): Likewise.
5792         * objc-lang.c (objc_language_defn): Likewise.
5793         * opencl-lang.c (opencl_language_defn): Likewise.
5794         * p-lang.c (pascal_language_defn): Likewise.
5795         * rust-lang.c (rust_language_defn): Likewise.
5796
5797 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5798
5799         * ada-lang.c (ada_is_character_type): Change return type to bool.
5800         (ada_is_string_type): Likewise.
5801         * ada-lang.h (ada_is_character_type): Update declaration
5802         (ada_is_string_type): Likewise.
5803
5804 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5805
5806         Support style in 'frame|thread apply'
5807
5808         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5809         * record.c (record_start, record_stop): Update callers of
5810         execute_command_to_string with false.
5811         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5812         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5813         methods.
5814         (class string_file): New constructor with term_out parameter.
5815         Override methods term_out and can_emit_style_escape.  New member
5816         term_out.
5817         (class stdio_file): Override can_emit_style_escape.
5818         (class tee_file): Override term_out and can_emit_style_escape.
5819         * utils.h (can_emit_style_escape): Remove.
5820         * utils.c (can_emit_style_escape): Likewise.
5821         Update all callers of can_emit_style_escape (SOMESTREAM) to
5822         SOMESTREAM->can_emit_style_escape.
5823         * source-cache.c (source_cache::get_source_lines): Likewise.
5824         * stack.c (frame_apply_command_count): Call execute_command_to_string
5825         passing the term_out characteristic of the current gdb_stdout.
5826         * thread.c (thr_try_catch_cmd): Likewise.
5827         * top.c (execute_command_to_string): pass term_out parameter
5828         to construct the string_file for the command output.
5829         * ui-file.c (term_cli_styling): New function (most code moved
5830         from utils.c can_emit_style_escape).
5831         (string_file::string_file, string_file::can_emit_style_escape,
5832         stdio_file::can_emit_style_escape, tee_file::term_out,
5833         tee_file::can_emit_style_escape): New functions.
5834
5835 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5836
5837         * NEWS: Mention the new set|show may-call-functions.
5838         * infcall.c (may_call_functions_p): New variable.
5839         (show_may_call_functions_p): New function.
5840         (call_function_by_hand_dummy): Throws an error if not
5841         may-call-functions.
5842         (_initialize_infcall): Call add_setshow_boolean_cmd for
5843         may-call-functions.
5844
5845 2019-04-25  Keith Seitz  <keiths@redhat.com>
5846
5847         PR c++/24367
5848         * cp-support.c (inspect_type): Don't attempt substitutions
5849         of symbol with the same name.
5850
5851 2019-04-25  Tom Tromey  <tromey@adacore.com>
5852
5853         PR gdb/24475:
5854         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5855         static.
5856
5857 2019-04-25  Tom Tromey  <tromey@adacore.com>
5858
5859         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5860         rvalue reference.
5861         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5862         (gdb_xml_parser::parse): Use std::move.
5863         * python/python-internal.h (gdbpy_convert_exception): Take a const
5864         reference.
5865         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5866         std::move.
5867         * python/py-utils.c (gdbpy_convert_exception): Take a const
5868         reference.
5869         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5870         Use std::move.
5871         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5872         Use std::move.
5873         * mi/mi-main.c (mi_print_exception): Take a const reference.
5874         * main.c (handle_command_errors): Take a const reference.
5875         * linespec.c (parse_linespec): Use std::move.
5876         * infcall.c (run_inferior_call): Use std::move.
5877         (call_function_by_hand_dummy): Use std::move.
5878         * exec.c (try_open_exec_file): Use std::move.
5879         * exceptions.h (exception_print, exception_fprintf)
5880         (exception_print_same): Update.
5881         * exceptions.c (print_exception, exception_print)
5882         (exception_fprintf, exception_print_same): Change parameters to
5883         const reference.
5884         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5885         * common/new-op.c: Use std::move.
5886         * common/common-exceptions.h (struct gdb_exception): Add move
5887         constructor.
5888         (struct gdb_exception_error, struct gdb_exception_quit, struct
5889         gdb_quit_bad_alloc): Change constructor to move constructor.
5890         (throw_exception): Change parameter to rvalue reference.
5891         * common/common-exceptions.c (throw_exception): Take rvalue
5892         reference.
5893         * cli/cli-interp.c (safe_execute_command): Use std::move.
5894         * breakpoint.c (insert_bp_location, location_to_sals): Use
5895         std::move.
5896
5897 2019-04-25  Tom Tromey  <tromey@adacore.com>
5898
5899         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5900         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5901         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5902         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5903         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5904         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5905         guile/scm-value.c: Use unpack.
5906         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5907         gdbscm_gdb_exception.
5908         (gdbscm_throw_gdb_exception): Likewise.
5909         (struct gdbscm_gdb_exception): New.
5910         (unpack): New function.
5911         (gdbscm_wrap): Use unpack.
5912
5913 2019-04-25  Tom Tromey  <tromey@adacore.com>
5914
5915         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5916         (gdb_rl_callback_handler): Use std::move.
5917         * common/common-exceptions.h (struct gdb_exception): Add move
5918         assignment operator.
5919         (throw_exception_sjlj): Change "exception" to const reference.
5920         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5921         (throw_exception_sjlj): Change "exception" to const reference.
5922
5923 2019-04-25  Tom Tromey  <tromey@adacore.com>
5924
5925         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5926         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5927         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5928         Update.
5929         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5930         Update.
5931         * mi/mi-interp.c (mi_interp::exec): Update.
5932         * linespec.c (parse_linespec): Update.
5933         * infcall.c (run_inferior_call): Update.
5934         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5935         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5936         (gdbscm_lookup_global_symbol): Update.
5937         * guile/scm-param.c (gdbscm_parameter_value): Update.
5938         * guile/scm-frame.c (gdbscm_frame_read_register)
5939         (gdbscm_frame_read_var): Update.
5940         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5941         * exec.c (try_open_exec_file): Update.
5942         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5943         (gdb_rl_callback_handler): Update.
5944         * common/common-exceptions.h (exception_none): Don't declare.
5945         * common/common-exceptions.c (exception_none): Don't define.
5946         (struct catcher) <exception>: Update.
5947         * cli/cli-interp.c (safe_execute_command): Update.
5948         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5949
5950 2019-04-25  Ali Tamur  <tamur@google.com>
5951
5952         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5953         (read_attribute_value): Likewise.
5954         (dwarf2_read_addr_index): Update comment.
5955         (read_str_index): Add DW_FORM_strx.
5956         (dwarf2_string_attr): Likewise.
5957         (dwarf2_const_value_attr): Likewise.
5958         (dump_die_shallow): Likewise.
5959         (dwarf2_fetch_constant_bytes): Likewise.
5960         (skip_form_bytes): Likewise.
5961         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5962
5963 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5964
5965         PR corefiles/11608
5966         PR corefiles/18187
5967         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5968         OFFSET.  Verify if current mapping contains an ELF header.
5969         (linux_find_memory_regions_full): Adjust call to
5970         dump_mapping_p.
5971
5972 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5973             Kang Li <kanglictf@gmail.com>
5974
5975         PR gdb/21600
5976
5977         * dwarf2-frame.c (read_initial_length): Be consistent about using
5978         unsigned representation of length.
5979         (decode_frame_entry_1): Likewise.  Check for wraparound of
5980         end pointer as well as buffer overflow.
5981
5982 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5983
5984         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5985         "vq".
5986
5987 2019-04-24  Tom Tromey  <tromey@adacore.com>
5988
5989         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5990
5991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * s12z-tdep.c (s12z_unwind_pc): Delete.
5994         (s12z_unwind_sp): Delete.
5995         (s12z_gdbarch_init): Don't register deleted functions with
5996         gdbarch.
5997
5998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5999
6000         * rl78-tdep.c (rl78_unwind_sp): Delete.
6001         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6002
6003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6006         (xstormy16_unwind_pc): Delete.
6007         (xstormy16_dummy_id): Delete.
6008         (xstormy16_gdbarch_init): Don't register deleted functions with
6009         gdbarch.
6010
6011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * vax-tdep.c (vax_unwind_pc): Delete.
6014         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6015
6016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * v850-tdep.c (v850_unwind_sp): Delete.
6019         (v850_unwind_pc): Delete.
6020         (v850_dummy_id): Delete.
6021         (v850_gdbarch_init): Don't register deleted functions with
6022         gdbarch.
6023
6024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6027         (tilegx_unwind_pc): Delete.
6028         (tilegx_unwind_dummy_id): Delete.
6029         (tilegx_gdbarch_init): Don't register deleted functions with
6030         gdbarch.
6031
6032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6035         (tic6x_dummy_id): Delete.
6036         (tic6x_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * sparc-tdep.c (sparc_unwind_pc): Delete.
6042         (sparc32_gdbarch_init): Don't register deleted function with
6043         gdbarch.
6044
6045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * sh-tdep.c (sh_unwind_sp): Delete.
6048         (sh_unwind_pc): Delete.
6049         (sh_dummy_id): Delete.
6050         (sh_gdbarch_init): Don't register deleted functions with
6051         gdbarch.
6052
6053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * score-tdep.c (score_unwind_sp): Delete.
6056         (score_unwind_pc): Delete.
6057         (score_dummy_id): Delete.
6058         (score_gdbarch_init): Don't register deleted functions with
6059         gdbarch.
6060
6061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * rx-tdep.c (rx_unwind_pc): Delete.
6064         (rx_unwind_sp): Delete.
6065         (rx_dummy_id): Delete.
6066         (rx_gdbarch_init): Don't register deleted functions with
6067         gdbarch.  Update comment.
6068
6069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6070
6071         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6072         (rs6000_dummy_id): Delete.
6073         (rs6000_gdbarch_init): Don't register deleted functions with
6074         gdbarch.
6075
6076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * or1k-tdep.c (or1k_dummy_id): Delete.
6079         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6080
6081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * nios2-tdep.c (nios2_dummy_id): Delete.
6084         (nios2_unwind_sp): Delete.
6085         (nios2_gdbarch_init): Don't register deleted functions with
6086         gdbarch.
6087
6088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6089
6090         * nds32-tdep.c (nds32_dummy_id): Delete.
6091         (nds32_unwind_pc): Delete.
6092         (nds32_unwind_sp): Delete.
6093         (nds32_gdbarch_init): Don't register deleted functions with
6094         gdbarch.
6095
6096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * msp430-tdep.c (msp430_unwind_pc): Delete.
6099         (msp430_unwind_sp): Delete.
6100         (msp430_dummy_id): Delete.
6101         (msp430_gdbarch_init): Don't register deleted functions with
6102         gdbarch.
6103
6104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6105
6106         * moxie-tdep.c (moxie_unwind_sp): Delete.
6107         (moxie_unwind_pc): Delete.
6108         (moxie_dummy_id): Delete.
6109         (moxie_gdbarch_init): Don't register deleted functions with
6110         gdbarch.
6111
6112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6115         (mn10300_unwind_pc): Delete.
6116         (mn10300_unwind_sp): Delete.
6117         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6118         mn10300_unwind_sp.
6119         (mn10300_frame_unwind_init): Don't register deleted functions with
6120         gdbarch.
6121
6122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * mep-tdep.c (mep_unwind_pc): Delete.
6125         (mep_unwind_sp): Delete.
6126         (mep_dummy_id): Delete.
6127         (mep_gdbarch_init): Don't register deleted functions with
6128         gdbarch.
6129
6130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6133         (m68hc11_unwind_sp): Delete.
6134         (m68hc11_gdbarch_init): Don't register deleted functions with
6135         gdbarch.
6136
6137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6138
6139         * m32r-tdep.c (m32r_unwind_sp): Delete.
6140         (m32r_unwind_pc): Delete.
6141         (m32r_dummy_id): Delete.
6142         (m32r_gdbarch_init): Don't register deleted functions with
6143         gdbarch.
6144
6145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * m32c-tdep.c (m32c_unwind_pc): Delete.
6148         (m32c_unwind_sp): Delete.
6149         (m32c_dummy_id): Delete.
6150         (m32c_gdbarch_init): Don't register deleted functions with
6151         gdbarch.
6152
6153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6156         (lm32_unwind_pc): Delete.
6157         (lm32_dummy_id): Delete.
6158         (lm32_gdbarch_init): Don't register deleted functions with
6159         gdbarch.
6160
6161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6164         (iq2000_unwind_pc): Delete.
6165         (iq2000_dummy_id): Delete.
6166         (iq2000_gdbarch_init): Don't register deleted functions with
6167         gdbarch.
6168
6169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * nds32-tdep.c (nds32_type_align): Delete.
6172         (nds32_push_dummy_call): Use type_align instead.
6173
6174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * arm-tdep.c (arm_type_align): Only handle vector override case.
6177         (arm_push_dummy_call): Use type_align.
6178         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6179
6180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6183         case.
6184         (pass_on_stack): Use type_align.
6185         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6186         function.
6187
6188 2019-04-23  Tom Tromey  <tromey@adacore.com>
6189
6190         * dwarf2read.c (line_header::file_name_at): Remove unused
6191         overload.
6192
6193 2019-04-23  Tom de Vries  <tdevries@suse.de>
6194
6195         PR gdb/24438
6196         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6197         invocation.
6198
6199
6200 2019-03-27  Ali Tamur  <tamur@google.com>
6201
6202         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6203         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6204         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6205         (dwarf_expr_context::get_addr_index): Likewise
6206         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6207         (symbol_needs_eval_context::get_addr_index): Likewise
6208         (disassemble_dwarf_expression): Add DW_OP_addrx
6209         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6210         (read_cutu_die_from_dwo): Update comment
6211         (skip_one_die): Add DW_FORM_addrx
6212         (read_attribute_value): Likewise
6213         (var_decode_location): Add DW_OP_addrx
6214         (dwarf2_const_value_attr): Add DW_FORM_addrx
6215         (dump_die_shallow): Likewise
6216         (dwarf2_fetch_constant_bytes): Likewise
6217         (decode_locdesc): Add DW_OP_addrx
6218         (skip_form_bytes): Add DW_FORM_addrx
6219
6220 2019-04-22  Ali Tamur  <tamur@google.com>
6221
6222         * MAINTAINERS (Write After Approval): Add self.
6223
6224 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6225
6226         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6227         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6228         (open_symbol_file_object): Likewise.
6229         (svr4_default_sos): Add info parameter.
6230         (svr4_read_so_list): Likewise.
6231         (svr4_current_sos_direct): Adjust functions calls to pass down
6232         info.
6233         (svr4_current_sos_1): Add info parameter.
6234         (svr4_current_sos): Call get_svr4_info, pass info down to
6235         svr4_current_sos_1.
6236         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6237         get_svr4_info.
6238         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6239         get_svr4_info.
6240         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6241         to get_svr4_info.
6242         (probes_table_remove_objfile_probes): Likewise.
6243         (register_solib_event_probe): Add info parameter.
6244         (solist_update_incremental): Pass info parameter down to
6245         svr4_read_so_list.
6246         (disable_probes_interface): Add info parameter.
6247         (svr4_handle_solib_event): Pass current_program_space to
6248         get_svr4_info.  Adjust disable_probes_interface cleanup.
6249         (svr4_create_probe_breakpoints): Add info parameter, pass it
6250         down to register_solib_event_probe.
6251         (svr4_create_solib_event_breakpoints): Add info parameter,
6252         pass it down to svr4_create_probe_breakpoints.
6253         (enable_break): Pass info down to
6254         svr4_create_solib_event_breakpoints.
6255         (svr4_solib_create_inferior_hook): Pass current_program_space to
6256         get_svr4_info.
6257         (svr4_clear_solib): Likewise.
6258
6259 2019-04-22  Pedro Alves  <palves@redhat.com>
6260
6261         * solib-svr4.c (svr4_free_objfile_observer): New.
6262         (probe_and_action::objfile): New field.
6263         (probes_table_htab_remove_objfile_probes)
6264         (probes_table_remove_objfile_probes): New functions.
6265         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6266         in the new probe_and_action.  Don't store the probe in 'lookup'.
6267         (svr4_create_probe_breakpoints): Pass objfile to
6268         register_solib_event_probe.
6269         (_initialize_svr4_solib): Register a free_objfile observer.
6270
6271 2019-04-19  Tom Tromey  <tom@tromey.com>
6272
6273         * common/queue.h: Remove.
6274
6275 2019-04-19  Tom Tromey  <tom@tromey.com>
6276
6277         * event-loop.c: Don't include "common/queue.h".
6278
6279 2019-04-19  Tom Tromey  <tom@tromey.com>
6280
6281         * remote.c (remote_target): Use delete.
6282         * remote-notif.h: Include <list>, not "common/queue.h".
6283         (notif_client_p): Remove typedef.
6284         (remote_notif_state): Add constructor, destructor, initializer.
6285         <notif_queue>: Now a std::list.
6286         (remote_notif_state_xfree): Don't declare.
6287         * remote-notif.c (remote_notif_process, handle_notification)
6288         (remote_notif_state_allocate): Update.
6289         (~remote_notif_state): Rename from remote_notif_state_xfree.
6290
6291 2019-04-19  Tom Tromey  <tom@tromey.com>
6292
6293         * symfile.c (reread_symbols): Update.
6294         * objfiles.c (objfile_register_static_link)
6295         (objfile_lookup_static_link): Update
6296         (~objfile) Don't delete static_links.
6297         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6298
6299 2019-04-19  Tom Tromey  <tom@tromey.com>
6300
6301         * type-stack.h (struct type_stack) <insert>: Constify string.
6302         * type-stack.c (type_stack::insert): Constify string.
6303         * gdbtypes.h (lookup_template_type): Update.
6304         (address_space_name_to_int): Update.
6305         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6306         const.
6307         (lookup_template_type): Make name const.
6308         * c-exp.y: Update rules.
6309         (lex_one_token, classify_name, classify_inner_name)
6310         (c_print_token): Update.
6311         * p-exp.y: Update rules.
6312         (yylex): Update.
6313         * f-exp.y: Update rules.
6314         (yylex): Update.
6315         * d-exp.y: Update rules.
6316         (lex_one_token, classify_name, classify_inner_name): Update.
6317         * parse.c (write_dollar_variable, copy_name): Return std::string.
6318         * parser-defs.h (copy_name): Change return type.
6319         * m2-exp.y: Update rules.
6320         (yylex): Update.
6321         * go-exp.y (lex_one_token): Update.
6322         Update rules.
6323         (classify_unsafe_function, classify_packaged_name)
6324         (classify_name, yylex): Update.
6325
6326 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6327
6328         * configure.ac: add --enable-source-highlight switch.
6329         * configure: Regenerate.
6330         * top.c (print_gdb_version): plumb --enable-source-highlight
6331         status to "show configuration".
6332
6333 2019-04-19  Tom Tromey  <tromey@adacore.com>
6334
6335         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6336         Check ADA_TYPE_P.
6337         (empty_record, ada_template_to_fixed_record_type_1)
6338         (template_to_static_fixed_type)
6339         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6340         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6341         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6342         macros.
6343
6344 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6345
6346         PR symtab/24423:
6347         * source.c (print_source_lines_base): Advance "iter" when a
6348         control character is seen.
6349
6350 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6351
6352         * inferior.h (struct infcall_suspend_state_deleter):
6353         Catch exception in destructor to avoid crash.
6354
6355 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6356
6357         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6358         close to the add_com "shell".
6359
6360 2019-04-18  Tom Tromey  <tromey@adacore.com>
6361
6362         * process-stratum-target.h (class process_stratum_target)
6363         <stratum>: Add "final".
6364
6365 2019-04-17  Tom Tromey  <tromey@adacore.com>
6366
6367         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6368         against nullptr before use.
6369
6370 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6371
6372         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6373
6374 2019-04-17  Jim Wilson  <jimw@sifive.com>
6375             Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6378         code read might fail, assume 4-byte breakpoint in that case.
6379
6380 2019-04-15  Leszek Swirski  <leszeks@google.com>
6381
6382         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6383         rather than a hand-rolled POD check when checking for forced MEMORY
6384         classification.
6385
6386 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6387
6388         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6389         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6390         function.
6391         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6392         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6393         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6394         declaration.
6395
6396 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * aarch64-linux-nat.c
6399         (aarch64_linux_nat_target::thread_architecture): Add override.
6400         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6401         each VQ.
6402
6403 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6404
6405         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6406
6407 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6410         target types of size 96-bits, add some additional comments, and
6411         check that the builtin type we found was the correct size.
6412
6413 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6414
6415         * utils.c (prompt_for_continue): Don't restore the styling at the
6416         end, as applied_style has the wrong value.  This fixes styling in
6417         long lists of file names that are interrupted by the "Continue?"
6418         prompt.
6419
6420 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6423         * c-lang.c (c_language_defn): Likewise.
6424         (cplus_language_defn): Likewise.
6425         (asm_language_defn): Likewise.
6426         (minimal_language_defn): Likewise.
6427         * d-lang.c (d_language_defn): Likewise.
6428         * f-lang.c (f_language_defn): Likewise.
6429         * go-lang.c (go_language_defn): Likewise.
6430         * language.c (unknown_language_defn): Likewise.
6431         (auto_language_defn): Likewise.
6432         * language.h (struct language_defn): Remove la_magic field.
6433         (LANG_MAGIC): Delete.
6434         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6435         * objc-lang.c (objc_language_defn): Likewise.
6436         * opencl-lang.c (opencl_language_defn): Likewise.
6437         * p-lang.c (pascal_language_defn): Likewise.
6438         * rust-lang.c (rust_language_defn): Likewise.
6439
6440 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * riscv-tdep.c (riscv_type_align): New function.
6443         (riscv_type_alignment): Delete.
6444         (riscv_arg_location): Use 'type_align'.
6445         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6446
6447 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * gdbtypes.c (type_align): A struct with no non-static fields also
6450         has alignment of 1.
6451
6452 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6455         component to 0.
6456         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6457         member.
6458         (riscv_struct_info::analyse): New implementation using new
6459         analyse_inner member function.
6460         (riscv_struct_info::field_offset): New member function.
6461         (riscv_struct_info::m_offsets): New member variable.
6462         (riscv_struct_info::analyse_inner): New private member function,
6463         takes the old implementation of riscv_struct_info::analyse but
6464         extended to track field offsets.
6465         (riscv_call_arg_struct): Update the struct folding special cases
6466         to handle cases where empty C++ structs, which are non-zero
6467         length, are found.
6468         (riscv_arg_location): Initialise the length of each location, a
6469         non-zero length now indicates the location is in use.
6470         (riscv_push_dummy_call): Allow for the first location having a
6471         non-zero offset when setting up arguments.
6472         (riscv_return_value): Likewise, but for return values.
6473
6474 2019-04-11  Tom Tromey  <tromey@adacore.com>
6475
6476         * utils.c (internal_vproblem): Make "msg" const.
6477
6478 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6479
6480         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6481         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6482         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6483         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6484
6485 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6486
6487         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6488         function.
6489         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6490         of amd64_collect_native_gregset.
6491         (amd64_linux_nat_target::store_registers): Likewise.
6492
6493 2019-04-10  Tom Tromey  <tom@tromey.com>
6494
6495         * symtab.c (lookup_global_symbol_from_objfile)
6496         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6497         * objfiles.h (class separate_debug_iterator): New.
6498         (class separate_debug_range): New.
6499         (struct objfile) <separate_debug_objfiles>: New method.
6500         (objfile_separate_debug_iterate): Don't declare.
6501         * objfiles.c (separate_debug_iterator::operator++): Rename from
6502         objfile_separate_debug_iterate.
6503         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6504         iterator.
6505         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6506         iterator.
6507
6508 2019-04-10  Tom Tromey  <tom@tromey.com>
6509
6510         * symfile.c (reread_symbols): Remove old comment.
6511         * objfiles.c (free_all_objfiles): Fix a typo.
6512
6513 2019-04-10  Tom Tromey  <tom@tromey.com>
6514
6515         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6516         * minsyms.c (lookup_minimal_symbol): Use foreach.
6517         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6518         (lookup_minimal_symbol_solib_trampoline): Likewise.
6519         * symfile.c (reread_symbols): Use foreach.
6520
6521 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6522             Tom Tromey  <tromey@adacore.com>
6523
6524         PR rust/24414:
6525         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6526         (rust_lex_int_test): Change "value" to be LONGEST.
6527         (rust_lex_tests): Add test for long integer literal.
6528
6529 2019-04-09  Tom Tromey  <tromey@adacore.com>
6530
6531         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6532         to bool.
6533         (extended_remote_target::attach): Update.
6534         (remote_target::remote_notice_new_inferior): Update.
6535         (remote_target::add_current_inferior_and_thread): Update.
6536         * inferior.c (exit_inferior_1): Use "false".
6537         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6538
6539 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6540
6541         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6542         the "start" command.
6543
6544 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6545
6546         * python/py-inferior.c (infpy_thread_from_thread_handle):
6547         Adjust comments to reflect renaming of thread_from_thread_handle
6548         to thread_from_handle.  Adjust keywords.  Fix type error message.
6549         (inferior_object_methods): Add thread_from_handle.  Retain
6550         thread_from_thread_handle, but mark it as deprecated.
6551
6552 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6553
6554         * gdbthread.h (find_thread_by_handle): Revise declaration.
6555         * thread.c (find_thread_by_handle): Likewise.  Adjust
6556         implementation too.
6557         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6558         support for buffer objects as handles.
6559
6560 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6561
6562         * python/py-infthread.c (thpy_thread_handle): New function.
6563         (thread_object_methods): Register thpy_thread_handle.
6564
6565 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6566
6567         * gdbthread.h (thread_to_thread_handle): Declare.
6568         * thread.c (gdbtypes.h): Include.
6569         (thread_to_thread_handle): New function.
6570
6571         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6572         (target_thread_info_to_thread_handle): Declare.
6573         * target.c (target_thread_info_to_thread_handle): New function.
6574         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6575         * target-delegates.c: Regenerate.
6576
6577         * linux-thread-db.c (class thread_db_target): Add method
6578         thread_info_to_thread_handle.
6579         (thread_db_target::thread_info_to_thread_handle): Define.
6580         * remote.c (class remote_target): Add new method
6581         thread_info_to_thread_handle.
6582         (remote_target::thread_info_to_thread_handle): Define.
6583
6584 2019-04-08  Pedro Alves  <palves@redhat.com>
6585
6586         * common/common-exceptions.c (throw_exception): Don't create
6587         named object to throw; throw directly.
6588         (throw_it): Likewise.  Don't initialize gdb_exception::message
6589         here, with new; pass FMT and AP to the ctor instead.
6590         * common/common-exceptions.h: Include <string>.
6591         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6592         const char *, va_list)): New ctor.  Use std::make_shared.
6593         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6594         errors)): Delete.
6595         (gdb_exception_error::gdb_exception_error(enum errors, const char
6596         *, va_list)): New.
6597         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6598         Add assertion.
6599         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6600         errors)): Delete.
6601         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6602         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6603         Add assertion.
6604
6605 2019-04-08  Tom Tromey  <tom@tromey.com>
6606
6607         * valops.c (value_rtti_indirect_type): Replace throw_exception
6608         with throw.
6609         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6610         with throw.
6611         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6612         throw.
6613         * target.c (target_translate_tls_address): Replace throw_exception
6614         with throw.
6615         * stack.c (frame_apply_command_count): Replace throw_exception
6616         with throw.
6617         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6618         throw.
6619         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6620         with throw.
6621         * rs6000-tdep.c (rs6000_frame_cache)
6622         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6623         * remote.c: Replace throw_exception with throw.
6624         * record-full.c (record_full_message, record_full_wait_1)
6625         (record_full_restore): Replace throw_exception with throw.
6626         * record-btrace.c:
6627         (get_thread_current_frame_id, record_btrace_start_replaying)
6628         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6629         (cmd_record_btrace_start): Replace throw_exception with throw.
6630         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6631         throw.
6632         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6633         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6634         * linespec.c:
6635         (find_linespec_symbols): Replace throw_exception with throw.
6636         * infrun.c (displaced_step_prepare, resume): Replace
6637         throw_exception with throw.
6638         * infcmd.c (post_create_inferior): Replace throw_exception with
6639         throw.
6640         * inf-loop.c (inferior_event_handler): Replace throw_exception
6641         with throw.
6642         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6643         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6644         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6645         (get_prev_frame_always, get_frame_pc_if_available)
6646         (get_frame_address_in_block_if_available, get_frame_language):
6647         Replace throw_exception with throw.
6648         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6649         throw_exception with throw.
6650         * eval.c (fetch_subexp_value, evaluate_var_value)
6651         (evaluate_funcall, evaluate_subexp_standard): Replace
6652         throw_exception with throw.
6653         * dwarf2loc.c (call_site_find_chain)
6654         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6655         Replace throw_exception with throw.
6656         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6657         with throw.
6658         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6659         throw.
6660         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6661         * completer.c (complete_line_internal): Replace throw_exception
6662         with throw.
6663         * compile/compile-object-run.c (compile_object_run): Replace
6664         throw_exception with throw.
6665         * cli/cli-script.c (process_next_line): Replace throw_exception
6666         with throw.
6667         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6668         (btrace_enable, btrace_maint_update_pt_packets): Replace
6669         throw_exception with throw.
6670         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6671         throw_exception with throw.
6672         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6673         throw_exception with throw.
6674         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6675         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6676         * aarch64-tdep.c (aarch64_make_prologue_cache)
6677         (aarch64_make_stub_cache): Replace throw_exception with throw.
6678
6679 2019-04-08  Tom Tromey  <tom@tromey.com>
6680
6681         * common/common-exceptions.c (throw_exception): Rename from
6682         throw_exception_cxx.  Remove old copy.  Make argument const.
6683         (throw_it): Create and throw exception objects directly.
6684         * common/common-exceptions.h (throw_exception): Make argument
6685         const.
6686         (struct gdb_exception_error): Add constructor.
6687         (struct gdb_exception_quit): Add constructor.
6688
6689 2019-04-08  Tom Tromey  <tom@tromey.com>
6690
6691         * common/common-exceptions.h (exception_rethrow): Don't declare.
6692         (TRY_SJLJ): Update comment.
6693         (TRY, CATCH, END_CATCH): Remove.
6694         * common/common-exceptions.c (exception_rethrow): Remove.
6695
6696 2019-04-08  Tom Tromey  <tom@tromey.com>
6697
6698         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6699         Remove.
6700         (gdb_exception_error): Rename from
6701         gdb_exception_RETURN_MASK_ERROR.
6702         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6703         (gdb_quit_bad_alloc): Update.
6704         * aarch64-tdep.c: Update.
6705         * ada-lang.c: Update.
6706         * ada-typeprint.c: Update.
6707         * ada-valprint.c: Update.
6708         * amd64-tdep.c: Update.
6709         * arch-utils.c: Update.
6710         * break-catch-throw.c: Update.
6711         * breakpoint.c: Update.
6712         * btrace.c: Update.
6713         * c-varobj.c: Update.
6714         * cli/cli-cmds.c: Update.
6715         * cli/cli-interp.c: Update.
6716         * cli/cli-script.c: Update.
6717         * common/common-exceptions.c: Update.
6718         * common/new-op.c: Update.
6719         * common/selftest.c: Update.
6720         * compile/compile-c-symbols.c: Update.
6721         * compile/compile-cplus-symbols.c: Update.
6722         * compile/compile-object-load.c: Update.
6723         * compile/compile-object-run.c: Update.
6724         * completer.c: Update.
6725         * corelow.c: Update.
6726         * cp-abi.c: Update.
6727         * cp-support.c: Update.
6728         * cp-valprint.c: Update.
6729         * darwin-nat.c: Update.
6730         * disasm-selftests.c: Update.
6731         * dtrace-probe.c: Update.
6732         * dwarf-index-cache.c: Update.
6733         * dwarf-index-write.c: Update.
6734         * dwarf2-frame-tailcall.c: Update.
6735         * dwarf2-frame.c: Update.
6736         * dwarf2loc.c: Update.
6737         * dwarf2read.c: Update.
6738         * eval.c: Update.
6739         * event-loop.c: Update.
6740         * event-top.c: Update.
6741         * exec.c: Update.
6742         * f-valprint.c: Update.
6743         * fbsd-tdep.c: Update.
6744         * frame-unwind.c: Update.
6745         * frame.c: Update.
6746         * gdbtypes.c: Update.
6747         * gnu-v3-abi.c: Update.
6748         * guile/guile-internal.h: Update.
6749         * guile/scm-block.c: Update.
6750         * guile/scm-breakpoint.c: Update.
6751         * guile/scm-cmd.c: Update.
6752         * guile/scm-disasm.c: Update.
6753         * guile/scm-frame.c: Update.
6754         * guile/scm-lazy-string.c: Update.
6755         * guile/scm-math.c: Update.
6756         * guile/scm-param.c: Update.
6757         * guile/scm-ports.c: Update.
6758         * guile/scm-pretty-print.c: Update.
6759         * guile/scm-symbol.c: Update.
6760         * guile/scm-symtab.c: Update.
6761         * guile/scm-type.c: Update.
6762         * guile/scm-value.c: Update.
6763         * i386-linux-tdep.c: Update.
6764         * i386-tdep.c: Update.
6765         * inf-loop.c: Update.
6766         * infcall.c: Update.
6767         * infcmd.c: Update.
6768         * infrun.c: Update.
6769         * jit.c: Update.
6770         * language.c: Update.
6771         * linespec.c: Update.
6772         * linux-fork.c: Update.
6773         * linux-nat.c: Update.
6774         * linux-tdep.c: Update.
6775         * linux-thread-db.c: Update.
6776         * main.c: Update.
6777         * mi/mi-cmd-break.c: Update.
6778         * mi/mi-cmd-stack.c: Update.
6779         * mi/mi-interp.c: Update.
6780         * mi/mi-main.c: Update.
6781         * objc-lang.c: Update.
6782         * p-valprint.c: Update.
6783         * parse.c: Update.
6784         * ppc-linux-tdep.c: Update.
6785         * printcmd.c: Update.
6786         * python/py-arch.c: Update.
6787         * python/py-breakpoint.c: Update.
6788         * python/py-cmd.c: Update.
6789         * python/py-finishbreakpoint.c: Update.
6790         * python/py-frame.c: Update.
6791         * python/py-framefilter.c: Update.
6792         * python/py-gdb-readline.c: Update.
6793         * python/py-inferior.c: Update.
6794         * python/py-infthread.c: Update.
6795         * python/py-lazy-string.c: Update.
6796         * python/py-linetable.c: Update.
6797         * python/py-objfile.c: Update.
6798         * python/py-param.c: Update.
6799         * python/py-prettyprint.c: Update.
6800         * python/py-progspace.c: Update.
6801         * python/py-record-btrace.c: Update.
6802         * python/py-record.c: Update.
6803         * python/py-symbol.c: Update.
6804         * python/py-type.c: Update.
6805         * python/py-unwind.c: Update.
6806         * python/py-utils.c: Update.
6807         * python/py-value.c: Update.
6808         * python/python.c: Update.
6809         * record-btrace.c: Update.
6810         * record-full.c: Update.
6811         * remote-fileio.c: Update.
6812         * remote.c: Update.
6813         * riscv-tdep.c: Update.
6814         * rs6000-aix-tdep.c: Update.
6815         * rs6000-tdep.c: Update.
6816         * rust-exp.y: Update.
6817         * rust-lang.c: Update.
6818         * s390-tdep.c: Update.
6819         * selftest-arch.c: Update.
6820         * solib-dsbt.c: Update.
6821         * solib-frv.c: Update.
6822         * solib-spu.c: Update.
6823         * solib-svr4.c: Update.
6824         * solib.c: Update.
6825         * sparc64-linux-tdep.c: Update.
6826         * stack.c: Update.
6827         * symfile-mem.c: Update.
6828         * symmisc.c: Update.
6829         * target.c: Update.
6830         * thread.c: Update.
6831         * top.c: Update.
6832         * tracefile-tfile.c: Update.
6833         * tui/tui.c: Update.
6834         * typeprint.c: Update.
6835         * unittests/cli-utils-selftests.c: Update.
6836         * unittests/parse-connection-spec-selftests.c: Update.
6837         * valops.c: Update.
6838         * valprint.c: Update.
6839         * value.c: Update.
6840         * varobj.c: Update.
6841         * windows-nat.c: Update.
6842         * x86-linux-nat.c: Update.
6843         * xml-support.c: Update.
6844
6845 2019-04-08  Tom Tromey  <tom@tromey.com>
6846
6847         * xml-support.c: Use C++ exception handling.
6848         * x86-linux-nat.c: Use C++ exception handling.
6849         * windows-nat.c: Use C++ exception handling.
6850         * varobj.c: Use C++ exception handling.
6851         * value.c: Use C++ exception handling.
6852         * valprint.c: Use C++ exception handling.
6853         * valops.c: Use C++ exception handling.
6854         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6855         handling.
6856         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6857         * typeprint.c: Use C++ exception handling.
6858         * tui/tui.c: Use C++ exception handling.
6859         * tracefile-tfile.c: Use C++ exception handling.
6860         * top.c: Use C++ exception handling.
6861         * thread.c: Use C++ exception handling.
6862         * target.c: Use C++ exception handling.
6863         * symmisc.c: Use C++ exception handling.
6864         * symfile-mem.c: Use C++ exception handling.
6865         * stack.c: Use C++ exception handling.
6866         * sparc64-linux-tdep.c: Use C++ exception handling.
6867         * solib.c: Use C++ exception handling.
6868         * solib-svr4.c: Use C++ exception handling.
6869         * solib-spu.c: Use C++ exception handling.
6870         * solib-frv.c: Use C++ exception handling.
6871         * solib-dsbt.c: Use C++ exception handling.
6872         * selftest-arch.c: Use C++ exception handling.
6873         * s390-tdep.c: Use C++ exception handling.
6874         * rust-lang.c: Use C++ exception handling.
6875         * rust-exp.y: Use C++ exception handling.
6876         * rs6000-tdep.c: Use C++ exception handling.
6877         * rs6000-aix-tdep.c: Use C++ exception handling.
6878         * riscv-tdep.c: Use C++ exception handling.
6879         * remote.c: Use C++ exception handling.
6880         * remote-fileio.c: Use C++ exception handling.
6881         * record-full.c: Use C++ exception handling.
6882         * record-btrace.c: Use C++ exception handling.
6883         * python/python.c: Use C++ exception handling.
6884         * python/py-value.c: Use C++ exception handling.
6885         * python/py-utils.c: Use C++ exception handling.
6886         * python/py-unwind.c: Use C++ exception handling.
6887         * python/py-type.c: Use C++ exception handling.
6888         * python/py-symbol.c: Use C++ exception handling.
6889         * python/py-record.c: Use C++ exception handling.
6890         * python/py-record-btrace.c: Use C++ exception handling.
6891         * python/py-progspace.c: Use C++ exception handling.
6892         * python/py-prettyprint.c: Use C++ exception handling.
6893         * python/py-param.c: Use C++ exception handling.
6894         * python/py-objfile.c: Use C++ exception handling.
6895         * python/py-linetable.c: Use C++ exception handling.
6896         * python/py-lazy-string.c: Use C++ exception handling.
6897         * python/py-infthread.c: Use C++ exception handling.
6898         * python/py-inferior.c: Use C++ exception handling.
6899         * python/py-gdb-readline.c: Use C++ exception handling.
6900         * python/py-framefilter.c: Use C++ exception handling.
6901         * python/py-frame.c: Use C++ exception handling.
6902         * python/py-finishbreakpoint.c: Use C++ exception handling.
6903         * python/py-cmd.c: Use C++ exception handling.
6904         * python/py-breakpoint.c: Use C++ exception handling.
6905         * python/py-arch.c: Use C++ exception handling.
6906         * printcmd.c: Use C++ exception handling.
6907         * ppc-linux-tdep.c: Use C++ exception handling.
6908         * parse.c: Use C++ exception handling.
6909         * p-valprint.c: Use C++ exception handling.
6910         * objc-lang.c: Use C++ exception handling.
6911         * mi/mi-main.c: Use C++ exception handling.
6912         * mi/mi-interp.c: Use C++ exception handling.
6913         * mi/mi-cmd-stack.c: Use C++ exception handling.
6914         * mi/mi-cmd-break.c: Use C++ exception handling.
6915         * main.c: Use C++ exception handling.
6916         * linux-thread-db.c: Use C++ exception handling.
6917         * linux-tdep.c: Use C++ exception handling.
6918         * linux-nat.c: Use C++ exception handling.
6919         * linux-fork.c: Use C++ exception handling.
6920         * linespec.c: Use C++ exception handling.
6921         * language.c: Use C++ exception handling.
6922         * jit.c: Use C++ exception handling.
6923         * infrun.c: Use C++ exception handling.
6924         * infcmd.c: Use C++ exception handling.
6925         * infcall.c: Use C++ exception handling.
6926         * inf-loop.c: Use C++ exception handling.
6927         * i386-tdep.c: Use C++ exception handling.
6928         * i386-linux-tdep.c: Use C++ exception handling.
6929         * guile/scm-value.c: Use C++ exception handling.
6930         * guile/scm-type.c: Use C++ exception handling.
6931         * guile/scm-symtab.c: Use C++ exception handling.
6932         * guile/scm-symbol.c: Use C++ exception handling.
6933         * guile/scm-pretty-print.c: Use C++ exception handling.
6934         * guile/scm-ports.c: Use C++ exception handling.
6935         * guile/scm-param.c: Use C++ exception handling.
6936         * guile/scm-math.c: Use C++ exception handling.
6937         * guile/scm-lazy-string.c: Use C++ exception handling.
6938         * guile/scm-frame.c: Use C++ exception handling.
6939         * guile/scm-disasm.c: Use C++ exception handling.
6940         * guile/scm-cmd.c: Use C++ exception handling.
6941         * guile/scm-breakpoint.c: Use C++ exception handling.
6942         * guile/scm-block.c: Use C++ exception handling.
6943         * guile/guile-internal.h: Use C++ exception handling.
6944         * gnu-v3-abi.c: Use C++ exception handling.
6945         * gdbtypes.c: Use C++ exception handling.
6946         * frame.c: Use C++ exception handling.
6947         * frame-unwind.c: Use C++ exception handling.
6948         * fbsd-tdep.c: Use C++ exception handling.
6949         * f-valprint.c: Use C++ exception handling.
6950         * exec.c: Use C++ exception handling.
6951         * event-top.c: Use C++ exception handling.
6952         * event-loop.c: Use C++ exception handling.
6953         * eval.c: Use C++ exception handling.
6954         * dwarf2read.c: Use C++ exception handling.
6955         * dwarf2loc.c: Use C++ exception handling.
6956         * dwarf2-frame.c: Use C++ exception handling.
6957         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6958         * dwarf-index-write.c: Use C++ exception handling.
6959         * dwarf-index-cache.c: Use C++ exception handling.
6960         * dtrace-probe.c: Use C++ exception handling.
6961         * disasm-selftests.c: Use C++ exception handling.
6962         * darwin-nat.c: Use C++ exception handling.
6963         * cp-valprint.c: Use C++ exception handling.
6964         * cp-support.c: Use C++ exception handling.
6965         * cp-abi.c: Use C++ exception handling.
6966         * corelow.c: Use C++ exception handling.
6967         * completer.c: Use C++ exception handling.
6968         * compile/compile-object-run.c: Use C++ exception handling.
6969         * compile/compile-object-load.c: Use C++ exception handling.
6970         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6971         * compile/compile-c-symbols.c: Use C++ exception handling.
6972         * common/selftest.c: Use C++ exception handling.
6973         * common/new-op.c: Use C++ exception handling.
6974         * cli/cli-script.c: Use C++ exception handling.
6975         * cli/cli-interp.c: Use C++ exception handling.
6976         * cli/cli-cmds.c: Use C++ exception handling.
6977         * c-varobj.c: Use C++ exception handling.
6978         * btrace.c: Use C++ exception handling.
6979         * breakpoint.c: Use C++ exception handling.
6980         * break-catch-throw.c: Use C++ exception handling.
6981         * arch-utils.c: Use C++ exception handling.
6982         * amd64-tdep.c: Use C++ exception handling.
6983         * ada-valprint.c: Use C++ exception handling.
6984         * ada-typeprint.c: Use C++ exception handling.
6985         * ada-lang.c: Use C++ exception handling.
6986         * aarch64-tdep.c: Use C++ exception handling.
6987
6988 2019-04-08  Tom Tromey  <tom@tromey.com>
6989
6990         * xml-support.c (gdb_xml_parser::parse): Update.
6991         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6992         * value.c (show_convenience): Update.
6993         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6994         (test_parse_flags_qcs): Update.
6995         * thread.c (thr_try_catch_cmd): Update.
6996         * target.c (target_translate_tls_address): Update.
6997         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6998         (info_frame_command_core, frame_apply_command_count): Update.
6999         * rust-exp.y (rust_lex_exception_test): Update.
7000         * riscv-tdep.c (riscv_print_one_register_info): Update.
7001         * remote.c (remote_target::enable_btrace): Update.
7002         * record-btrace.c (record_btrace_enable_warn): Update.
7003         * python/py-utils.c (gdbpy_convert_exception): Update.
7004         * printcmd.c (do_one_display, print_variable_and_value): Update.
7005         * mi/mi-main.c (mi_print_exception): Update.
7006         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7007         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7008         * linux-nat.c (linux_nat_target::attach): Update.
7009         * linux-fork.c (class scoped_switch_fork_info): Update.
7010         * infrun.c (displaced_step_prepare): Update.
7011         * infcall.c (call_function_by_hand_dummy): Update.
7012         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7013         * gnu-v3-abi.c (print_one_vtable): Update.
7014         * frame.c (get_prev_frame_always): Update.
7015         * f-valprint.c (info_common_command_for_block): Update.
7016         * exec.c (try_open_exec_file): Update.
7017         * exceptions.c (print_exception, exception_print)
7018         (exception_fprintf, exception_print_same): Update.
7019         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7020         * dwarf-index-cache.c (index_cache::store)
7021         (index_cache::lookup_gdb_index): Update.
7022         * darwin-nat.c (maybe_cache_shell): Update.
7023         * cp-valprint.c (cp_print_value_fields): Update.
7024         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7025         (gcc_cplus_symbol_address): Update.
7026         * compile/compile-c-symbols.c (gcc_convert_symbol)
7027         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7028         * common/selftest.c: Update.
7029         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7030         a std::string.
7031         (exception_try_scope_entry, exception_try_scope_exit): Don't
7032         declare.
7033         (struct exception_try_scope): Remove.
7034         (TRY): Don't use exception_try_scope.
7035         (struct gdb_exception): Add constructor, operator=.
7036         <what>: New method.
7037         (struct gdb_exception_RETURN_MASK_ALL)
7038         (struct gdb_exception_RETURN_MASK_ERROR)
7039         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7040         (struct gdb_quit_bad_alloc): Update.
7041         * common/common-exceptions.c (exception_none): Change
7042         initializer.
7043         (struct catcher) <state, exception>: Initialize inline.
7044         <prev>: Remove member.
7045         (current_catcher): Remove.
7046         (catchers): New global.
7047         (exceptions_state_mc_init): Simplify.
7048         (catcher_pop): Remove.
7049         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7050         (try_scope_depth, exception_try_scope_entry)
7051         (exception_try_scope_exit): Remove.
7052         (throw_exception_sjlj): Update.
7053         (exception_messages, exception_messages_size): Remove.
7054         (throw_it): Simplify.
7055         (gdb_exception_sliced_copy): Remove.
7056         (throw_exception_cxx): Update.
7057         * cli/cli-script.c (script_from_file): Update.
7058         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7059         Update.
7060         * ada-valprint.c (ada_val_print): Update.
7061         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7062         (create_excep_cond_exprs): Update.
7063
7064 2019-04-08  Tom Tromey  <tom@tromey.com>
7065
7066         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7067         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7068         (TRY, CATCH, END_CATCH): Remove some definitions.
7069         * common/common-exceptions.c: Don't use GDB_XCPT.
7070         (catcher_list_size): Remove.
7071         (throw_exception, throw_it): Simplify.
7072
7073 2019-04-05  Tom Tromey  <tom@tromey.com>
7074
7075         Revert the header-sorting patch.
7076         * ft32-tdep.c: Revert.
7077         * frv-tdep.c: Revert.
7078         * frv-linux-tdep.c: Revert.
7079         * frame.c: Revert.
7080         * frame-unwind.c: Revert.
7081         * frame-base.c: Revert.
7082         * fork-child.c: Revert.
7083         * findvar.c: Revert.
7084         * findcmd.c: Revert.
7085         * filesystem.c: Revert.
7086         * filename-seen-cache.h: Revert.
7087         * filename-seen-cache.c: Revert.
7088         * fbsd-tdep.c: Revert.
7089         * fbsd-nat.h: Revert.
7090         * fbsd-nat.c: Revert.
7091         * f-valprint.c: Revert.
7092         * f-typeprint.c: Revert.
7093         * f-lang.c: Revert.
7094         * extension.h: Revert.
7095         * extension.c: Revert.
7096         * extension-priv.h: Revert.
7097         * expprint.c: Revert.
7098         * exec.h: Revert.
7099         * exec.c: Revert.
7100         * exceptions.c: Revert.
7101         * event-top.c: Revert.
7102         * event-loop.c: Revert.
7103         * eval.c: Revert.
7104         * elfread.c: Revert.
7105         * dwarf2read.h: Revert.
7106         * dwarf2read.c: Revert.
7107         * dwarf2loc.c: Revert.
7108         * dwarf2expr.h: Revert.
7109         * dwarf2expr.c: Revert.
7110         * dwarf2-frame.c: Revert.
7111         * dwarf2-frame-tailcall.c: Revert.
7112         * dwarf-index-write.h: Revert.
7113         * dwarf-index-write.c: Revert.
7114         * dwarf-index-common.c: Revert.
7115         * dwarf-index-cache.h: Revert.
7116         * dwarf-index-cache.c: Revert.
7117         * dummy-frame.c: Revert.
7118         * dtrace-probe.c: Revert.
7119         * disasm.h: Revert.
7120         * disasm.c: Revert.
7121         * disasm-selftests.c: Revert.
7122         * dictionary.c: Revert.
7123         * dicos-tdep.c: Revert.
7124         * demangle.c: Revert.
7125         * dcache.h: Revert.
7126         * dcache.c: Revert.
7127         * darwin-nat.h: Revert.
7128         * darwin-nat.c: Revert.
7129         * darwin-nat-info.c: Revert.
7130         * d-valprint.c: Revert.
7131         * d-namespace.c: Revert.
7132         * d-lang.c: Revert.
7133         * ctf.c: Revert.
7134         * csky-tdep.c: Revert.
7135         * csky-linux-tdep.c: Revert.
7136         * cris-tdep.c: Revert.
7137         * cris-linux-tdep.c: Revert.
7138         * cp-valprint.c: Revert.
7139         * cp-support.c: Revert.
7140         * cp-namespace.c: Revert.
7141         * cp-abi.c: Revert.
7142         * corelow.c: Revert.
7143         * corefile.c: Revert.
7144         * continuations.c: Revert.
7145         * completer.h: Revert.
7146         * completer.c: Revert.
7147         * complaints.c: Revert.
7148         * coffread.c: Revert.
7149         * coff-pe-read.c: Revert.
7150         * cli-out.h: Revert.
7151         * cli-out.c: Revert.
7152         * charset.c: Revert.
7153         * c-varobj.c: Revert.
7154         * c-valprint.c: Revert.
7155         * c-typeprint.c: Revert.
7156         * c-lang.c: Revert.
7157         * buildsym.c: Revert.
7158         * buildsym-legacy.c: Revert.
7159         * build-id.h: Revert.
7160         * build-id.c: Revert.
7161         * btrace.c: Revert.
7162         * bsd-uthread.c: Revert.
7163         * breakpoint.h: Revert.
7164         * breakpoint.c: Revert.
7165         * break-catch-throw.c: Revert.
7166         * break-catch-syscall.c: Revert.
7167         * break-catch-sig.c: Revert.
7168         * blockframe.c: Revert.
7169         * block.c: Revert.
7170         * bfin-tdep.c: Revert.
7171         * bfin-linux-tdep.c: Revert.
7172         * bfd-target.c: Revert.
7173         * bcache.c: Revert.
7174         * ax-general.c: Revert.
7175         * ax-gdb.h: Revert.
7176         * ax-gdb.c: Revert.
7177         * avr-tdep.c: Revert.
7178         * auxv.c: Revert.
7179         * auto-load.c: Revert.
7180         * arm-wince-tdep.c: Revert.
7181         * arm-tdep.c: Revert.
7182         * arm-symbian-tdep.c: Revert.
7183         * arm-pikeos-tdep.c: Revert.
7184         * arm-obsd-tdep.c: Revert.
7185         * arm-nbsd-tdep.c: Revert.
7186         * arm-nbsd-nat.c: Revert.
7187         * arm-linux-tdep.c: Revert.
7188         * arm-linux-nat.c: Revert.
7189         * arm-fbsd-tdep.c: Revert.
7190         * arm-fbsd-nat.c: Revert.
7191         * arm-bsd-tdep.c: Revert.
7192         * arch-utils.c: Revert.
7193         * arc-tdep.c: Revert.
7194         * arc-newlib-tdep.c: Revert.
7195         * annotate.h: Revert.
7196         * annotate.c: Revert.
7197         * amd64-windows-tdep.c: Revert.
7198         * amd64-windows-nat.c: Revert.
7199         * amd64-tdep.c: Revert.
7200         * amd64-sol2-tdep.c: Revert.
7201         * amd64-obsd-tdep.c: Revert.
7202         * amd64-obsd-nat.c: Revert.
7203         * amd64-nbsd-tdep.c: Revert.
7204         * amd64-nbsd-nat.c: Revert.
7205         * amd64-nat.c: Revert.
7206         * amd64-linux-tdep.c: Revert.
7207         * amd64-linux-nat.c: Revert.
7208         * amd64-fbsd-tdep.c: Revert.
7209         * amd64-fbsd-nat.c: Revert.
7210         * amd64-dicos-tdep.c: Revert.
7211         * amd64-darwin-tdep.c: Revert.
7212         * amd64-bsd-nat.c: Revert.
7213         * alpha-tdep.c: Revert.
7214         * alpha-obsd-tdep.c: Revert.
7215         * alpha-nbsd-tdep.c: Revert.
7216         * alpha-mdebug-tdep.c: Revert.
7217         * alpha-linux-tdep.c: Revert.
7218         * alpha-linux-nat.c: Revert.
7219         * alpha-bsd-tdep.c: Revert.
7220         * alpha-bsd-nat.c: Revert.
7221         * aix-thread.c: Revert.
7222         * agent.c: Revert.
7223         * addrmap.c: Revert.
7224         * ada-varobj.c: Revert.
7225         * ada-valprint.c: Revert.
7226         * ada-typeprint.c: Revert.
7227         * ada-tasks.c: Revert.
7228         * ada-lang.c: Revert.
7229         * aarch64-tdep.c: Revert.
7230         * aarch64-ravenscar-thread.c: Revert.
7231         * aarch64-newlib-tdep.c: Revert.
7232         * aarch64-linux-tdep.c: Revert.
7233         * aarch64-linux-nat.c: Revert.
7234         * aarch64-fbsd-tdep.c: Revert.
7235         * aarch64-fbsd-nat.c: Revert.
7236         * aarch32-linux-nat.c: Revert.
7237
7238 2019-04-05  Tom Tromey  <tom@tromey.com>
7239
7240         * ft32-tdep.c: Sort headers.
7241         * frv-tdep.c: Sort headers.
7242         * frv-linux-tdep.c: Sort headers.
7243         * frame.c: Sort headers.
7244         * frame-unwind.c: Sort headers.
7245         * frame-base.c: Sort headers.
7246         * fork-child.c: Sort headers.
7247         * findvar.c: Sort headers.
7248         * findcmd.c: Sort headers.
7249         * filesystem.c: Sort headers.
7250         * filename-seen-cache.h: Sort headers.
7251         * filename-seen-cache.c: Sort headers.
7252         * fbsd-tdep.c: Sort headers.
7253         * fbsd-nat.h: Sort headers.
7254         * fbsd-nat.c: Sort headers.
7255         * f-valprint.c: Sort headers.
7256         * f-typeprint.c: Sort headers.
7257         * f-lang.c: Sort headers.
7258         * extension.h: Sort headers.
7259         * extension.c: Sort headers.
7260         * extension-priv.h: Sort headers.
7261         * expprint.c: Sort headers.
7262         * exec.h: Sort headers.
7263         * exec.c: Sort headers.
7264         * exceptions.c: Sort headers.
7265         * event-top.c: Sort headers.
7266         * event-loop.c: Sort headers.
7267         * eval.c: Sort headers.
7268         * elfread.c: Sort headers.
7269         * dwarf2read.h: Sort headers.
7270         * dwarf2read.c: Sort headers.
7271         * dwarf2loc.c: Sort headers.
7272         * dwarf2expr.h: Sort headers.
7273         * dwarf2expr.c: Sort headers.
7274         * dwarf2-frame.c: Sort headers.
7275         * dwarf2-frame-tailcall.c: Sort headers.
7276         * dwarf-index-write.h: Sort headers.
7277         * dwarf-index-write.c: Sort headers.
7278         * dwarf-index-common.c: Sort headers.
7279         * dwarf-index-cache.h: Sort headers.
7280         * dwarf-index-cache.c: Sort headers.
7281         * dummy-frame.c: Sort headers.
7282         * dtrace-probe.c: Sort headers.
7283         * disasm.h: Sort headers.
7284         * disasm.c: Sort headers.
7285         * disasm-selftests.c: Sort headers.
7286         * dictionary.c: Sort headers.
7287         * dicos-tdep.c: Sort headers.
7288         * demangle.c: Sort headers.
7289         * dcache.h: Sort headers.
7290         * dcache.c: Sort headers.
7291         * darwin-nat.h: Sort headers.
7292         * darwin-nat.c: Sort headers.
7293         * darwin-nat-info.c: Sort headers.
7294         * d-valprint.c: Sort headers.
7295         * d-namespace.c: Sort headers.
7296         * d-lang.c: Sort headers.
7297         * ctf.c: Sort headers.
7298         * csky-tdep.c: Sort headers.
7299         * csky-linux-tdep.c: Sort headers.
7300         * cris-tdep.c: Sort headers.
7301         * cris-linux-tdep.c: Sort headers.
7302         * cp-valprint.c: Sort headers.
7303         * cp-support.c: Sort headers.
7304         * cp-namespace.c: Sort headers.
7305         * cp-abi.c: Sort headers.
7306         * corelow.c: Sort headers.
7307         * corefile.c: Sort headers.
7308         * continuations.c: Sort headers.
7309         * completer.h: Sort headers.
7310         * completer.c: Sort headers.
7311         * complaints.c: Sort headers.
7312         * coffread.c: Sort headers.
7313         * coff-pe-read.c: Sort headers.
7314         * cli-out.h: Sort headers.
7315         * cli-out.c: Sort headers.
7316         * charset.c: Sort headers.
7317         * c-varobj.c: Sort headers.
7318         * c-valprint.c: Sort headers.
7319         * c-typeprint.c: Sort headers.
7320         * c-lang.c: Sort headers.
7321         * buildsym.c: Sort headers.
7322         * buildsym-legacy.c: Sort headers.
7323         * build-id.h: Sort headers.
7324         * build-id.c: Sort headers.
7325         * btrace.c: Sort headers.
7326         * bsd-uthread.c: Sort headers.
7327         * breakpoint.h: Sort headers.
7328         * breakpoint.c: Sort headers.
7329         * break-catch-throw.c: Sort headers.
7330         * break-catch-syscall.c: Sort headers.
7331         * break-catch-sig.c: Sort headers.
7332         * blockframe.c: Sort headers.
7333         * block.c: Sort headers.
7334         * bfin-tdep.c: Sort headers.
7335         * bfin-linux-tdep.c: Sort headers.
7336         * bfd-target.c: Sort headers.
7337         * bcache.c: Sort headers.
7338         * ax-general.c: Sort headers.
7339         * ax-gdb.h: Sort headers.
7340         * ax-gdb.c: Sort headers.
7341         * avr-tdep.c: Sort headers.
7342         * auxv.c: Sort headers.
7343         * auto-load.c: Sort headers.
7344         * arm-wince-tdep.c: Sort headers.
7345         * arm-tdep.c: Sort headers.
7346         * arm-symbian-tdep.c: Sort headers.
7347         * arm-pikeos-tdep.c: Sort headers.
7348         * arm-obsd-tdep.c: Sort headers.
7349         * arm-nbsd-tdep.c: Sort headers.
7350         * arm-nbsd-nat.c: Sort headers.
7351         * arm-linux-tdep.c: Sort headers.
7352         * arm-linux-nat.c: Sort headers.
7353         * arm-fbsd-tdep.c: Sort headers.
7354         * arm-fbsd-nat.c: Sort headers.
7355         * arm-bsd-tdep.c: Sort headers.
7356         * arch-utils.c: Sort headers.
7357         * arc-tdep.c: Sort headers.
7358         * arc-newlib-tdep.c: Sort headers.
7359         * annotate.h: Sort headers.
7360         * annotate.c: Sort headers.
7361         * amd64-windows-tdep.c: Sort headers.
7362         * amd64-windows-nat.c: Sort headers.
7363         * amd64-tdep.c: Sort headers.
7364         * amd64-sol2-tdep.c: Sort headers.
7365         * amd64-obsd-tdep.c: Sort headers.
7366         * amd64-obsd-nat.c: Sort headers.
7367         * amd64-nbsd-tdep.c: Sort headers.
7368         * amd64-nbsd-nat.c: Sort headers.
7369         * amd64-nat.c: Sort headers.
7370         * amd64-linux-tdep.c: Sort headers.
7371         * amd64-linux-nat.c: Sort headers.
7372         * amd64-fbsd-tdep.c: Sort headers.
7373         * amd64-fbsd-nat.c: Sort headers.
7374         * amd64-dicos-tdep.c: Sort headers.
7375         * amd64-darwin-tdep.c: Sort headers.
7376         * amd64-bsd-nat.c: Sort headers.
7377         * alpha-tdep.c: Sort headers.
7378         * alpha-obsd-tdep.c: Sort headers.
7379         * alpha-nbsd-tdep.c: Sort headers.
7380         * alpha-mdebug-tdep.c: Sort headers.
7381         * alpha-linux-tdep.c: Sort headers.
7382         * alpha-linux-nat.c: Sort headers.
7383         * alpha-bsd-tdep.c: Sort headers.
7384         * alpha-bsd-nat.c: Sort headers.
7385         * aix-thread.c: Sort headers.
7386         * agent.c: Sort headers.
7387         * addrmap.c: Sort headers.
7388         * ada-varobj.c: Sort headers.
7389         * ada-valprint.c: Sort headers.
7390         * ada-typeprint.c: Sort headers.
7391         * ada-tasks.c: Sort headers.
7392         * ada-lang.c: Sort headers.
7393         * aarch64-tdep.c: Sort headers.
7394         * aarch64-ravenscar-thread.c: Sort headers.
7395         * aarch64-newlib-tdep.c: Sort headers.
7396         * aarch64-linux-tdep.c: Sort headers.
7397         * aarch64-linux-nat.c: Sort headers.
7398         * aarch64-fbsd-tdep.c: Sort headers.
7399         * aarch64-fbsd-nat.c: Sort headers.
7400         * aarch32-linux-nat.c: Sort headers.
7401
7402 2019-04-04  Tom Tromey  <tom@tromey.com>
7403
7404         * varobj.c (varobj_create): Update.
7405         * rust-exp.y (struct rust_parser) <update_innermost_block,
7406         lookup_symbol>: New methods.
7407         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7408         Rename.
7409         (rust_parser::rust_lookup_type)
7410         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7411         * printcmd.c (display_command, do_one_display): Update.
7412         * parser-defs.h (struct parser_state) <parser_state>: Add
7413         "tracker" parameter.
7414         (block_tracker): New member.
7415         (class innermost_block_tracker) <innermost_block_tracker>: Add
7416         "types" parameter.
7417         <reset>: Remove method.
7418         (innermost_block): Don't declare.
7419         (null_post_parser): Update.
7420         * parse.c (innermost_block): Remove global.
7421         (write_dollar_variable): Update.
7422         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7423         Remove "tracker_types" parameter.
7424         (parse_expression): Add "tracker" parameter.
7425         (parse_expression_for_completion): Update.
7426         (null_post_parser): Add "tracker" parameter.
7427         * p-exp.y: Update rules.
7428         * m2-exp.y: Update rules.
7429         * language.h (struct language_defn) <la_post_parser>: Add
7430         "tracker" parameter.
7431         * go-exp.y: Update rules.
7432         * f-exp.y: Update rules.
7433         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7434         parameter.
7435         * d-exp.y: Update rules.
7436         * c-exp.y: Update rules.
7437         * breakpoint.c (set_breakpoint_condition): Create an
7438         innermost_block_tracker.
7439         (watch_command_1): Likewise.
7440         * ada-lang.c (resolve): Add "tracker" parameter.
7441         (resolve_subexp): Likewise.
7442         * ada-exp.y (write_var_from_sym): Update.
7443
7444 2019-04-04  Tom Tromey  <tom@tromey.com>
7445
7446         * type-stack.h: New file.
7447         * type-stack.c: New file.
7448         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7449         type-stack.h.
7450         (insert_into_type_stack, insert_type, push_type, push_type_int)
7451         (insert_type_address_space, pop_type, pop_type_int)
7452         (pop_typelist, pop_type_stack, append_type_stack)
7453         (push_type_stack, get_type_stack, push_typelist)
7454         (follow_type_instance_flags, follow_types): Don't declare.
7455         * parse.c (type_stack): Remove global.
7456         (parse_exp_in_context): Update.
7457         (insert_into_type_stack, insert_type, push_type, push_type_int)
7458         (insert_type_address_space, pop_type, pop_type_int)
7459         (pop_typelist, pop_type_stack, append_type_stack)
7460         (push_type_stack, get_type_stack, push_typelist)
7461         (follow_type_instance_flags, follow_types): Remove (moved to
7462         type-stack.c).
7463         * f-exp.y (type_stack): New global.
7464         Update rules.
7465         (push_kind_type, f_parse): Update.
7466         * d-exp.y (type_stack): New global.
7467         Update rules.
7468         (d_parse): Update.
7469         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7470         Update rules.
7471         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7472         (HFILES_NO_SRCDIR): Add type-stack.h.
7473
7474 2019-04-04  Tom Tromey  <tom@tromey.com>
7475
7476         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7477         (rust_parser::convert_ast_to_expression, rust_parse)
7478         (rust_lex_test_completion, rust_lex_tests): Update.
7479         * parser-defs.h (struct expr_completion_state): New.
7480         (struct parser_state) <parser_state>: Add completion parameter.
7481         <mark_struct_expression, mark_completion_tag>: New methods.
7482         <parse_completion, m_completion_state>: New members.
7483         (prefixify_expression, null_post_parser): Update.
7484         (mark_struct_expression, mark_completion_tag): Don't declare.
7485         * parse.c (parse_completion, expout_last_struct)
7486         (expout_tag_completion_type, expout_completion_name): Remove
7487         globals.
7488         (parser_state::mark_struct_expression)
7489         (parser_state::mark_completion_tag): Now methods.
7490         (prefixify_expression): Add last_struct parameter.
7491         (prefixify_subexp): Likewise.
7492         (parse_exp_1): Update.
7493         (parse_exp_in_context): Add cstate parameter.  Update.
7494         (parse_expression_for_completion): Create an
7495         expr_completion_state.
7496         (null_post_parser): Add "completion" parameter.
7497         * p-exp.y: Update rules.
7498         (yylex): Update.
7499         * language.h (struct language_defn) <la_post_parser>: Add
7500         "completing" parameter.
7501         * go-exp.y: Update rules.
7502         (lex_one_token): Update.
7503         * expression.h (parse_completion): Don't declare.
7504         * d-exp.y: Update rules.
7505         (lex_one_token): Update rules.
7506         * c-exp.y: Update rules.
7507         (lex_one_token): Update.
7508         * ada-lang.c (resolve): Add "parse_completion" parameter.
7509         (resolve_subexp): Likewise.
7510         (ada_resolve_function): Likewise.
7511
7512 2019-04-04  Tom Tromey  <tom@tromey.com>
7513
7514         * parser-defs.h (struct parser_state) <start_arglist,
7515         end_arglist>: New methods.
7516         <arglist_len, m_funcall_chain>: New members.
7517         (arglist_len, start_arglist, end_arglist): Don't declare.
7518         * parse.c (arglist_len, funcall_chain): Remove global.
7519         (start_arglist, end_arglist): Remove functions.
7520         (parse_exp_in_context): Update.
7521         * p-exp.y: Update rules.
7522         * m2-exp.y: Update rules.
7523         * go-exp.y: Update rules.
7524         * f-exp.y: Update rules.
7525         * d-exp.y: Update rules.
7526         * c-exp.y: Update rules.
7527
7528 2019-04-04  Tom Tromey  <tom@tromey.com>
7529
7530         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7531         lex_operator, push_back>: New methods.
7532         Update all rules.
7533         (rust_parser::lex_hex, lex_escape): Rename and update.
7534         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7535         (rust_parser::lex_operator): Rename and update.
7536         (rust_parser::lex_number, rustyylex, rustyyerror)
7537         (rust_lex_test_init, rust_lex_test_sequence)
7538         (rust_lex_test_push_back, rust_lex_tests): Update.
7539         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7540         parameter.
7541         <lexptr, prev_lexptr>: New members.
7542         (lexptr, prev_lexptr): Don't declare.
7543         * parse.c (lexptr, prev_lexptr): Remove globals.
7544         (parse_exp_in_context): Update.
7545         * p-exp.y (yylex, yyerror): Update.
7546         * m2-exp.y (parse_number, yylex, yyerror): Update.
7547         * go-exp.y (lex_one_token, yyerror): Update.
7548         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7549         * d-exp.y (lex_one_token, yyerror): Update.
7550         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7551         (lex_one_token, yyerror): Update.
7552         * ada-lex.l (YY_INPUT): Update.
7553         (rewind_to_char): Update.
7554         * ada-exp.y (yyerror): Update.
7555
7556 2019-04-04  Tom Tromey  <tom@tromey.com>
7557
7558         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7559         * parser-defs.h (struct parser_state) <parser_state>: Add new
7560         parameter.
7561         <comma_terminates>: New member.
7562         (comma_terminates): Don't declare global.
7563         * parse.c (comma_terminates): Remove global.
7564         (parse_exp_in_context): Update.
7565         * p-exp.y (yylex): Update.
7566         * m2-exp.y (yylex): Update.
7567         * go-exp.y (lex_one_token): Update.
7568         * f-exp.y (yylex): Update.
7569         * d-exp.y (lex_one_token): Update.
7570         * c-exp.y (lex_one_token): Update.
7571         * ada-lex.l: Update.
7572
7573 2019-04-04  Tom Tromey  <tom@tromey.com>
7574
7575         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7576         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7577         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7578         * parser-defs.h (paren_depth): Don't declare.
7579         * parse.c (paren_depth): Remove global.
7580         (parse_exp_in_context): Update.
7581         * p-exp.y (paren_depth): New global.
7582         (pascal_parse): Initialize it.
7583         * m2-exp.y (paren_depth): New global.
7584         (m2_parse): Initialize it.
7585         * go-exp.y (paren_depth): New global.
7586         (go_parse): Initialize it.
7587         * f-exp.y (paren_depth): New global.
7588         (f_parse): Initialize it.
7589         * d-exp.y (paren_depth): New global.
7590         (d_parse): Initialize it.
7591         * c-exp.y (paren_depth): New global.
7592         (c_parse): Initialize it.
7593         * ada-lex.l (paren_depth): New global.
7594         (lexer_init): Initialize it.
7595
7596 2019-04-04  Tom Tromey  <tom@tromey.com>
7597
7598         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7599         (rust_parser::convert_ast_to_type)
7600         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7601         * parser-defs.h (struct parser_state) <parser_state>: Add
7602         parameters.  Initialize new members.
7603         <expression_context_block, expression_context_pc>: New members.
7604         * parse.c (expression_context_block, expression_context_pc):
7605         Remove globals.
7606         (parse_exp_in_context): Update.
7607         * p-exp.y: Update all rules.
7608         (yylex): Update.
7609         * m2-exp.y: Update all rules.
7610         (yylex): Update.
7611         * go-exp.y (yylex): Update.
7612         * f-exp.y (yylex): Update.
7613         * d-exp.y: Update all rules.
7614         (yylex): Update.
7615         * c-exp.y: Update all rules.
7616         (lex_one_token, classify_name, yylex, c_parse): Update.
7617         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7618
7619 2019-04-04  Tom Tromey  <tom@tromey.com>
7620
7621         * gdbarch.h, gdbarch.c: Rebuild.
7622         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7623         * stap-probe.h:
7624         (struct stap_parse_info): Replace "parser_state" with
7625         "expr_builder".
7626         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7627         (parser_state): New class.
7628         * parse.c (expr_builder): Rename.
7629         (expr_builder::release): Rename.
7630         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7631         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7632         (write_exp_elt_longcst, write_exp_elt_floatcst)
7633         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7634         (write_exp_string_vector, write_exp_bitstring)
7635         (write_exp_msymbol, mark_struct_expression)
7636         (write_dollar_variable)
7637         (insert_type_address_space, increase_expout_size): Replace
7638         "parser_state" with "expr_builder".
7639         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7640         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7641         "parser_state" with "expr_builder".
7642
7643 2019-04-04  Tom Tromey  <tom@tromey.com>
7644
7645         * rust-exp.y: Replace "parse_language" with method call.
7646         * p-exp.y:
7647         (yylex): Replace "parse_language" with method call.
7648         * m2-exp.y:
7649         (yylex): Replace "parse_language" with method call.
7650         * go-exp.y (classify_name): Replace "parse_language" with method
7651         call.
7652         * f-exp.y (yylex): Replace "parse_language" with method call.
7653         * d-exp.y (lex_one_token): Replace "parse_language" with method
7654         call.
7655         * c-exp.y:
7656         (lex_one_token, classify_name, yylex): Replace "parse_language"
7657         with method call.
7658         * ada-exp.y (find_primitive_type, type_char)
7659         (type_system_address): Replace "parse_language" with method call.
7660
7661 2019-04-04  Tom Tromey  <tom@tromey.com>
7662
7663         * rust-exp.y: Replace "parse_gdbarch" with method call.
7664         * parse.c (write_dollar_variable, insert_type_address_space):
7665         Replace "parse_gdbarch" with method call.
7666         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7667         call.
7668         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7669         call.
7670         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7671         "parse_gdbarch" with method call.
7672         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7673         with method call.
7674         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7675         "parse_gdbarch" with method call.
7676         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7677         "parse_gdbarch" with method call.
7678         * c-exp.y (parse_type, parse_number, classify_name): Replace
7679         "parse_gdbarch" with method call.
7680         * ada-lex.l: Replace "parse_gdbarch" with method call.
7681         * ada-exp.y (parse_type, find_primitive_type, type_char)
7682         (type_system_address): Replace "parse_gdbarch" with method call.
7683
7684 2019-04-04  Tom Tromey  <tom@tromey.com>
7685
7686         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7687         * stap-probe.c (stap_parse_argument): Update.
7688         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7689         initial_size parameter.
7690         * rust-exp.y (rust_lex_tests): Update.
7691         * parse.c (parser_state): Update.
7692         (parse_exp_in_context): Update.
7693         * parser-defs.h (struct parser_state) <parser_state>: Remove
7694         "initial_size" parameter.
7695
7696 2019-04-04  Tom Tromey  <tom@tromey.com>
7697
7698         * parser-defs.h (increase_expout_size): Don't declare.
7699         * parse.c (increase_expout_size): Now static.
7700
7701 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7702
7703         * gnu-nat.c (gnu_nat_target::wait): Fix
7704         target_waitstatus_to_string call.
7705
7706 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7707
7708         * eval.c (evaluate_subexp_standard): Handle internal functions
7709         during Fortran function call handling.
7710
7711 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7712
7713         * NEWS: Mention new internal functions.
7714         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7715         (read_base_type): Use dwarf2_init_complex_target_type.
7716         * value.c (creal_internal_fn): New function.
7717         (cimag_internal_fn): New function.
7718         (_initialize_values): Register new internal functions.
7719
7720 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7721
7722         * infrun.c (stop_all_threads): If debug_infrun, always
7723         trace the wait status after wait_one, using
7724         target_waitstatus_to_string and target_pid_to_str.
7725         (handle_inferior_event): Replace various trace of
7726         wait status kind by a single trace.
7727         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7728         wait status kind image by target_waitstatus_to_string.
7729         * target/waitstatus.c (target_waitstatus_to_string): Fix
7730         obsolete comment.
7731
7732 2019-04-01  Tom Tromey  <tromey@adacore.com>
7733
7734         PR symtab/23331:
7735         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7736
7737 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7738             Pedro Alves  <palves@redhat.com>
7739
7740         * top.c (quit_force): Call 'finalize_values'.
7741         * value.c (finalize_values): New function.
7742         * value.h (finalize_values): Declare.
7743
7744 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7745
7746         * NEWS: Announce $_gdb_major and $_gdb_minor.
7747
7748         * top.c (init_gdb_version_vars): New function.
7749         (gdb_init): Call init_gdb_version_vars.
7750
7751 2019-03-29  Tom Tromey  <tromey@adacore.com>
7752
7753         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7754         help text.  Remove dead code.
7755
7756 2019-03-29  Keith Seitz  <keiths@redhat.com>
7757
7758         From Siddhesh Poyarekar:
7759         * f-lang.h (f77_get_upperbound): Return LONGEST.
7760         (f77_get_lowerbound): Likewise.
7761         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7762         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7763         print them.
7764         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7765         plongest to format print it.
7766         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7767         (f77_get_upperbound): Likewise.
7768         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7769         LOWER_BOUND to LONGEST.
7770         (f77_create_arrayprint_offset_tbl): Likewise.
7771
7772 2019-03-29  Keith Seitz  <keiths@redhat.com>
7773
7774         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7775         %s/pulongest for TYPE_LENGTH instead of %d in format
7776         strings.
7777         * ada-typerint.c (ada_print_type): Likewise.
7778         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7779         * compile/compile-c-support.c (generate_register_struct): Likewise.
7780         * gdbtypes.c (recursive_dump_type): Likewise.
7781         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7782         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7783         instead of %d in format strings.
7784         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7785         to std::min to ULONGEST.
7786         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7787         instead of %d in format strings.
7788         * tracepoint.c (info_scope_command): Likewise.
7789         * typeprint.c (print_offset_data::update)
7790         (print_offset_data::finish): Likewise.
7791         * xtensa-tdep.c (xtensa_store_return_value)
7792         (xtensa_push_dummy_call): Likewise.
7793
7794 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7795
7796         * windows-nat.c (display_selector): Fixed format specifications
7797         for 64-bit Cygwin.
7798
7799 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7800
7801         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7802
7803 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7804
7805         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7806         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7807         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7808         (nios2_linux_init_abi): Install it.
7809
7810 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7811
7812         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7813
7814 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7815
7816         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7817
7818 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7819             Tom Tromey  <tromey@adacore.com>
7820
7821         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7822
7823 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7824
7825         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7826         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7827         method to compute the bounds of range types. Also print "[evaluated]"
7828         if the bounds' values come from a dynamic evaluation.
7829
7830 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7833         whitespace when pretty printing is on.
7834
7835 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7836
7837         * ppc-linux-nat.c: Add include.
7838
7839 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7840
7841         * NEWS: Mention AArch64 Pointer Authentication.
7842
7843 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7844
7845         * arm-linux-nat.c: Add include.
7846
7847 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7848
7849         * source-cache.c (source_cache::get_source_lines): Re-read
7850         fullname after calling open_source_file.
7851
7852 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7853
7854         * NEWS: Mention TLS support for FreeBSD.
7855
7856 2019-03-25  Tom Tromey  <tromey@adacore.com>
7857
7858         * minsyms.c (BUNCH_SIZE): Update comment.
7859         (~minimal_symbol_reader): Remove old comment.
7860         (compact_minimal_symbols): Update comment.
7861         (minimal_symbol_reader::install): Remove old comment.  Update
7862         other comments.
7863
7864 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7865
7866         * s390-linux-nat.c: Add include.
7867
7868 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7869
7870         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7871         Call linux_get_hwcap.
7872         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7873         Likewise.
7874         (aarch64_linux_get_hwcap): Remove function.
7875         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7876         declaration.
7877         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7878         linux_get_hwcap.
7879         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7880         * linux-tdep.c (linux_get_hwcap): Add function.
7881         (linux_get_hwcap2): Likewise.
7882         * linux-tdep.h (linux_get_hwcap): Add declaration.
7883         (linux_get_hwcap2): Likewise.
7884         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7885         (ppc_linux_get_hwcap2): Likewise.
7886         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7887         linux_get_hwcap.
7888         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7889         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7890         (ppc_linux_nat_target::read_description): Likewise.
7891         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7892         * s390-linux-nat.c: Likewise.
7893         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7894
7895 2019-03-24  Tom Tromey  <tom@tromey.com>
7896
7897         * ada-lang.c (standard_lookup): Simplify initialization.
7898         (ada_lookup_symbol_nonlocal): Simplify return.
7899         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7900         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7901         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7902         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7903         initialization.
7904         * solib.c (solib_global_lookup): Simplify.
7905         * symtab.c (null_block_symbol): Remove.
7906         (symbol_cache_lookup): Simplify returns.
7907         (lookup_language_this): Simplify returns.
7908         (lookup_symbol_aux): Simplify return.
7909         (lookup_local_symbol): Simplify returns.
7910         (lookup_global_symbol_from_objfile): Simplify return.
7911         (lookup_symbol_in_objfile_symtabs)
7912         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7913         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7914         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7915         * cp-namespace.c (cp_lookup_bare_symbol)
7916         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7917         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7918         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7919         (cp_lookup_symbol_via_imports): Simplify initialization.
7920         (find_symbol_in_baseclass): Likewise.
7921         * symtab.h (null_block_symbol): Remove.
7922         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7923         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7924         (d_lookup_symbol_module): Likewise.
7925         (find_symbol_in_baseclass): Simplify initialization.
7926
7927 2019-03-24  Tom Tromey  <tom@tromey.com>
7928
7929         * expression.h: Don't include symtab.h.
7930         (struct block): Forward declare.
7931
7932 2019-03-24  Tom Tromey  <tom@tromey.com>
7933
7934         * c-exp.y (typebase): Remove casts.
7935         * gdbtypes.c (lookup_unsigned_typename, )
7936         (lookup_signed_typename): Remove cast.
7937         * eval.c (parse_to_comma_and_eval): Remove cast.
7938         * parse.c (write_dollar_variable): Remove cast.
7939         * block.h (struct block) <superblock>: Now const.
7940         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7941         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7942         (map_block): Make "block" const.
7943         * symfile.h (struct quick_symbol_functions)
7944         <map_matching_symbols>: Constify block argument to "callback".
7945         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7946         const.
7947         (find_pc_sect_compunit_symtab): Make "b" const.
7948         (find_symbol_at_address): Likewise.
7949         (search_symbols): Likewise.
7950         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7951         (dw2_debug_names_lookup_symbol): Likewise.
7952         (dw2_map_matching_symbols): Update.
7953         * p-valprint.c (pascal_val_print): Remove "block".
7954         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7955         (aux_add_nonlocal_symbols): Make "block" const.
7956         (resolve_subexp): Remove cast.
7957         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7958         const.
7959         (iterate_over_file_blocks): Likewise.
7960         * f-exp.y (%union) <bval>: Remove.
7961         * coffread.c (patch_opaque_types): Make "b" const.
7962         * spu-tdep.c (spu_catch_start): Make "block" const.
7963         * c-valprint.c (print_unpacked_pointer): Remove "block".
7964         * symmisc.c (dump_symtab_1): Make "b" const.
7965         (block_depth): Make "block" const.
7966         * d-exp.y (%union) <bval>: Remove.
7967         * cp-support.h (cp_lookup_rtti_type): Update.
7968         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7969         * psymtab.c (psym_lookup_symbol): Make "block" const.
7970         (maintenance_check_psymtabs): Make "b" const.
7971         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7972         (enumerate_locals, enumerate_args): Update.
7973         * python/py-symtab.c (stpy_global_block): Make "block" const.
7974         (stpy_static_block): Likewise.
7975         * inline-frame.c (block_starting_point_at): Make "new_block"
7976         const.
7977         * block.c (find_block_in_blockvector): Make return type const.
7978         (blockvector_for_pc_sect): Make "b" const.
7979         (find_block_in_blockvector): Make "b" const.
7980
7981 2019-03-23  Tom Tromey  <tom@tromey.com>
7982
7983         * varobj.c (varobj_create): Update.
7984         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7985         * printcmd.c (display_command, do_one_display): Don't reset
7986         innermost_block.
7987         * parser-defs.h (enum innermost_block_tracker_type): Move to
7988         expression.h.
7989         (innermost_block): Update comment.
7990         * parse.c (parse_exp_1): Add tracker_types parameter.
7991         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7992         tracker_types parameter.  Reset innermost_block.
7993         (parse_exp_in_context): Remove.
7994         (parse_expression_for_completion): Update.
7995         * objfiles.c (~objfile): Don't reset expression_context_block or
7996         innermost_block.
7997         * expression.h (enum innermost_block_tracker_type): Move from
7998         parser-defs.h.
7999         (parse_exp_1): Add tracker_types parameter.
8000         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8001         reset innermost_block.
8002
8003 2019-03-23  Tom Tromey  <tom@tromey.com>
8004
8005         * objfiles.h: Include bcache.h.
8006
8007 2019-03-23  Tom Tromey  <tom@tromey.com>
8008
8009         * linespec.c (get_current_search_block): Use
8010         scoped_restore_current_language.
8011         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8012
8013 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8014             Jiong Wang  <jiong.wang@arm.com>
8015
8016         * aarch64-linux-tdep.c
8017         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8018         section.
8019         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8020
8021 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8022             Jiong Wang  <jiong.wang@arm.com>
8023
8024         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8025         instructions.
8026         (aarch64_analyze_prologue_test): Add PACIASP test.
8027         (aarch64_prologue_prev_register): Unmask PC value.
8028
8029 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8030             Jiong Wang  <jiong.wang@arm.com>
8031
8032         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8033         (aarch64_dwarf2_prev_register): Unmask PC value.
8034         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8035         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8036         DW_CFA_AARCH64_negate_ra_state.
8037         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8038
8039 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8040             Jiong Wang  <jiong.wang@arm.com>
8041
8042         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8043         registers.
8044         (aarch64_pseudo_register_name): Likewise.
8045         (aarch64_pseudo_register_type): Likewise.
8046         (aarch64_pseudo_register_reggroup_p): Likewise.
8047         (aarch64_gdbarch_init): Add pauth registers.
8048         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8049         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8050         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8051         (struct gdbarch_tdep): Add regnum for ra_state.
8052
8053 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8054             Jiong Wang  <jiong.wang@arm.com>
8055
8056         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8057
8058 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8059             Jiong Wang  <jiong.wang@arm.com>
8060
8061         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8062         function.
8063         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8064         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8065         (aarch64_gdbarch_init): Add puth registers.
8066         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8067         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8068         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8069
8070 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8071             Jiong Wang  <jiong.wang@arm.com>
8072
8073         * aarch64-linux-nat.c
8074         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8075         * aarch64-linux-tdep.c
8076         (aarch64_linux_core_read_description): Likewise.
8077         (aarch64_linux_get_hwcap): New function.
8078         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8079         (aarch64_linux_get_hwcap): New declaration.
8080
8081 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8082             Jiong Wang  <jiong.wang@arm.com>
8083
8084         * aarch64-linux-nat.c
8085         (aarch64_linux_nat_target::read_description): Add pauth param.
8086         * aarch64-linux-tdep.c
8087         (aarch64_linux_core_read_description): Likewise.
8088         * aarch64-tdep.c (struct target_desc): Add in pauth.
8089         (aarch64_read_description): Add pauth param.
8090         (aarch64_gdbarch_init): Likewise.
8091         * aarch64-tdep.h (aarch64_read_description): Likewise.
8092         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8093         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8094         * features/Makefile: Add new files.
8095         * features/aarch64-pauth.c: New file.
8096         * features/aarch64-pauth.xml: New file.
8097
8098 2019-03-20  Tom Tromey  <tromey@adacore.com>
8099
8100         * infrun.c (handle_inferior_event): Rename from
8101         handle_inferior_event_1.  Create a scoped_value_mark.
8102         (handle_inferior_event): Remove.
8103
8104 2019-03-19  Tom Tromey  <tromey@adacore.com>
8105
8106         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8107         * infrun.h (print_stop_event): Add "displays" parameter.
8108         * infrun.c (print_stop_event): Add "displays" parameter.
8109
8110 2019-03-19  Pedro Alves  <palves@redhat.com>
8111
8112         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8113         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8114         to -1.  Fix TABs vs spaces.
8115         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8116         * tui/tui-out.h (tui_ui_out) Add intro comments.
8117         <m_line, m_start_of_line>: In-class initialize, and add describing
8118         comment.
8119
8120 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8121
8122         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8123         variable names.
8124         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8125
8126 2019-03-18  Pedro Alves  <palves@redhat.com>
8127             Eli Zaretskii <eliz@gnu.org>
8128
8129         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8130         m_line and m_start_of_line.
8131
8132 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8133
8134         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8135         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8136         it returns a newline.  This fixes a regression in TU mode, whereby
8137         the next line is output on the same screen line as the user input.
8138
8139 2019-03-18  Tom Tromey  <tromey@adacore.com>
8140
8141         * minsyms.c (minimal_symbol_reader::install): Remove call to
8142         obstack_blank.
8143
8144 2019-03-18  Pedro Alves  <palves@redhat.com>
8145
8146         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8147         New globals.
8148         (apply_style): New, factored out from ...
8149         (apply_ansi_escape): ... this.  Handle reverse video mode.
8150         (tui_set_reverse_mode): New function.
8151         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8152         * tui/tui-winsource.c (tui_show_source_line): Use
8153         tui_set_reverse_mode instead of setting A_STANDOUT.
8154         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8155         New setter methods.
8156
8157 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8158
8159         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8160         Handle tabs.
8161
8162 2019-03-18  Tom Tromey  <tromey@adacore.com>
8163
8164         * ada-lang.c (empty_array): Add "high" parameter.
8165         (ada_evaluate_subexp): Update.
8166
8167 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8168
8169         * unittests/string_view-selftests.c: Define
8170         _initialize_string_view_selftests unconditionally.
8171
8172 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8173
8174         PR gdb/24350
8175         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8176
8177 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8178
8179         PR gdb/24351
8180         * windows-nat.c (display_selector): Fix format specifiers.
8181
8182 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8183
8184         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8185         tui_refill_source_window instead of tui_refresh_win, to update the
8186         current execution line.  This fixes redisplay of the current line
8187         when stepping through the code with "next" or "step".
8188
8189 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8190
8191         * source-cache.c (source_cache::get_source_lines): Call
8192         find_source_lines to initialize s->nlines.  This fixes vertical
8193         scrolling of TUI source window when the DOWN arrow is pressed.
8194
8195 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8196
8197         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8198         linux-thread-db.c (_initialize_thread_db): Likewise.
8199
8200 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8201
8202         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8203         wclrtoeol in tui_show_source_line".  This reverts changes made in
8204         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8205
8206 2019-03-15  Tom Tromey  <tom@tromey.com>
8207
8208         * symtab.h (struct minimal_symbol): Derive from
8209         general_symbol_info.
8210         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8211         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8212         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8213         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8214         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8215         (MSYMBOL_SEARCH_NAME): Update.
8216         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8217         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8218         * minsyms.c (minimal_symbol_reader::record_full): Update.
8219
8220 2019-03-15  Tom Tromey  <tom@tromey.com>
8221
8222         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8223
8224 2019-03-15  Tom Tromey  <tom@tromey.com>
8225
8226         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8227         unique_xmalloc_ptr.
8228         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8229         Update.
8230         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8231         (build_minimal_symbol_hash_tables)
8232         (minimal_symbol_reader::install): Update.
8233
8234 2019-03-15  Tom Tromey  <tom@tromey.com>
8235
8236         * symtab.c (create_demangled_names_hash): Update.
8237         (symbol_set_names): Update.
8238         * objfiles.h (struct objfile_per_bfd_storage)
8239         <demangled_names_hash>: Now an htab_up.
8240         * objfiles.c (objfile_per_bfd_storage): Simplify.
8241
8242 2019-03-15  Tom Tromey  <tom@tromey.com>
8243
8244         * objfiles.h (struct objfile_per_bfd_storage): Declare
8245         destructor.
8246         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8247         New.
8248         (get_objfile_bfd_data): Use new.  Don't initialize
8249         language_of_main.
8250         (free_objfile_per_bfd_storage): Remove.
8251         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8252
8253 2019-03-15  Tom Tromey  <tom@tromey.com>
8254
8255         * symfile.c (reread_symbols): Update.
8256         * objfiles.c (objfile::objfile): Update.
8257         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8258         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8259         comment.
8260         (minimal_symbol_reader::install): Update.
8261         (terminate_minimal_symbol_table): Remove.
8262         * jit.c (jit_object_close_impl): Update.
8263
8264 2019-03-15  Tom Tromey  <tom@tromey.com>
8265
8266         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8267         initializations.
8268
8269 2019-03-15  Tom Tromey  <tom@tromey.com>
8270
8271         * objfiles.h (struct objfile_per_bfd_storage)
8272         <demangled_hash_languages>: Now a bitset.
8273         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8274         (lookup_minimal_symbol): Update.
8275
8276 2019-03-15  Tom Tromey  <tom@tromey.com>
8277
8278         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8279         Don't return the symbol.
8280         * coffread.c (record_minimal_symbol): Use record_full.
8281
8282 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8283
8284         The MS-Windows port of ncurses fails to switch to a color pair if
8285         one or both of the colors are the implicit default colors.  This
8286         change records the default colors when TUI is initialized, and
8287         then specifies them explicitly when a color pair uses the default
8288         colors.  This allows color styling in TUI mode on MS-Windows.
8289
8290         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8291         ncurses_norm_attr.
8292         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8293         colors in ncurses_norm_attr.
8294         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8295         "none", replace it with the default color recorded in
8296         ncurses_norm_attr.
8297
8298 2019-03-14  Tom Tromey  <tromey@adacore.com>
8299
8300         * source-cache.h (class source_cache) <get_source_lines>: Return
8301         std::string.
8302         * source-cache.c (source_cache::extract_lines): Handle case where
8303         first_pos==npos.  Return std::string.
8304         (source_cache::get_source_lines): Update.
8305
8306 2019-03-14  Tom Tromey  <tromey@adacore.com>
8307
8308         * NEWS: Add item for "style sources" commands.
8309         * source-cache.c (source_cache::get_source_lines): Check
8310         source_styling.
8311         * cli/cli-style.c (source_styling): New global.
8312         (_initialize_cli_style): Add "style sources" commands.
8313         (show_style_sources): New function.
8314         * cli/cli-style.h (source_styling): Declare.
8315
8316 2019-03-14  Pedro Alves  <palves@redhat.com>
8317             Tom Tromey  <tromey@adacore.com>
8318
8319         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8320         * tui/tui-winsource.c (tui_refill_source_window): New function,
8321         from...
8322         (tui_horizontal_source_scroll): ... here.  Move some logic.
8323         * cli/cli-style.c (set_style_enabled): Notify new observable.
8324         * tui/tui-hooks.c (tui_redisplay_source): New function.
8325         (tui_attach_detach_observers): Attach or detach
8326         tui_redisplay_source.
8327         * observable.h (source_styling_changed): New observable.
8328         * observable.c: Define source_styling_changed observable.
8329
8330 2019-03-13  Tom Tromey  <tromey@adacore.com>
8331
8332         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8333         (i386_gnu_nat_target::store_registers): Update.
8334         * target-debug.h (target_debug_print_std_string): New macro.
8335         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8336         * windows-tdep.c (display_one_tib): Update.
8337         * tui/tui-stack.c (tui_make_status_line): Update.
8338         * top.c (print_inferior_quit_action): Update.
8339         * thread.c (thr_try_catch_cmd): Update.
8340         (add_thread_with_info): Update.
8341         (thread_target_id_str): Update.
8342         (thr_try_catch_cmd): Update.
8343         (thread_command): Update.
8344         (thread_find_command): Update.
8345         * record-btrace.c (record_btrace_target::info_record)
8346         (record_btrace_resume_thread, record_btrace_target::resume)
8347         (record_btrace_cancel_resume, record_btrace_step_thread)
8348         (record_btrace_target::wait, record_btrace_target::wait)
8349         (record_btrace_target::wait, record_btrace_target::stop): Update.
8350         * progspace.c (print_program_space): Update.
8351         * process-stratum-target.c
8352         (process_stratum_target::thread_address_space): Update.
8353         * linux-fork.c (linux_fork_mourn_inferior)
8354         (detach_checkpoint_command, info_checkpoints_command)
8355         (linux_fork_context): Update.
8356         (linux_fork_detach): Update.
8357         (class scoped_switch_fork_info): Update.
8358         (delete_checkpoint_command): Update.
8359         * infrun.c (follow_fork_inferior): Update.
8360         (follow_fork_inferior): Update.
8361         (proceed_after_vfork_done): Update.
8362         (handle_vfork_child_exec_or_exit): Update.
8363         (follow_exec): Update.
8364         (displaced_step_prepare_throw): Update.
8365         (displaced_step_restore): Update.
8366         (start_step_over): Update.
8367         (resume_1): Update.
8368         (clear_proceed_status_thread): Update.
8369         (proceed): Update.
8370         (print_target_wait_results): Update.
8371         (do_target_wait): Update.
8372         (context_switch): Update.
8373         (stop_all_threads): Update.
8374         (restart_threads): Update.
8375         (finish_step_over): Update.
8376         (handle_signal_stop): Update.
8377         (switch_back_to_stepped_thread): Update.
8378         (keep_going_pass_signal): Update.
8379         (print_exited_reason): Update.
8380         (normal_stop): Update.
8381         * inferior.c (inferior_pid_to_str): Change return type.
8382         (print_selected_inferior): Update.
8383         (add_inferior): Update.
8384         (detach_inferior): Update.
8385         * dummy-frame.c (fprint_dummy_frames): Update.
8386         * dcache.c (dcache_info_1): Update.
8387         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8388         (btrace_fetch, btrace_clear): Update.
8389         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8390         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8391         type.
8392         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8393         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8394         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8395         * gdbarch.c, gdbarch.h: Rebuild.
8396         * gdbarch.sh (core_pid_to_str): Change return type.
8397         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8398         return type.
8399         (windows_nat_target::pid_to_str): Change return type.
8400         (windows_delete_thread): Update.
8401         (windows_nat_target::attach): Update.
8402         (windows_nat_target::files_info): Update.
8403         * target-delegates.c: Rebuild.
8404         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8405         return type.
8406         (sol_thread_target::pid_to_str): Change return type.
8407         * remote.c (class remote_target) <pid_to_str>: Change return
8408         type.
8409         (remote_target::pid_to_str): Change return type.
8410         (extended_remote_target::attach, remote_target::remote_stop_ns)
8411         (remote_target::remote_notif_remove_queued_reply)
8412         (remote_target::push_stop_reply, remote_target::disable_btrace):
8413         Update.
8414         (extended_remote_target::attach): Update.
8415         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8416         type.
8417         (gdbsim_target::pid_to_str): Change return type.
8418         * ravenscar-thread.c (struct ravenscar_thread_target)
8419         <pid_to_str>: Change return type.
8420         (ravenscar_thread_target::pid_to_str): Change return type.
8421         * procfs.c (class procfs_target) <pid_to_str>: Change return
8422         type.
8423         (procfs_target::pid_to_str): Change return type.
8424         (procfs_target::attach): Update.
8425         (procfs_target::detach): Update.
8426         (procfs_target::fetch_registers): Update.
8427         (procfs_target::store_registers): Update.
8428         (procfs_target::wait): Update.
8429         (procfs_target::files_info): Update.
8430         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8431         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8432         return type.
8433         (nto_procfs_target::pid_to_str): Change return type.
8434         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8435         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8436         return type.
8437         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8438         (exit_lwp): Update.
8439         (attach_proc_task_lwp_callback, get_detach_signal)
8440         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8441         (linux_nat_target::resume, wait_lwp, stop_callback)
8442         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8443         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8444         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8445         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8446         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8447         type.
8448         (inf_ptrace_target::attach): Update.
8449         (inf_ptrace_target::files_info): Update.
8450         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8451         type.
8452         (go32_nat_target::pid_to_str): Change return type.
8453         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8454         (gnu_nat_target::wait): Update.
8455         (gnu_nat_target::wait): Update.
8456         (gnu_nat_target::resume): Update.
8457         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8458         (fbsd_nat_target::wait): Update.
8459         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8460         type.
8461         (darwin_nat_target::attach): Update.
8462         * corelow.c (class core_target) <pid_to_str>: Change return type.
8463         (core_target::pid_to_str): Change return type.
8464         * target.c (normal_pid_to_str): Change return type.
8465         (default_pid_to_str): Likewise.
8466         (target_pid_to_str): Change return type.
8467         (target_translate_tls_address): Update.
8468         (target_announce_detach): Update.
8469         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8470         return type.
8471         (bsd_uthread_target::pid_to_str): Change return type.
8472         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8473         type.
8474         (bsd_kvm_target::pid_to_str): Change return type.
8475         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8476         return type.
8477         (aix_thread_target::pid_to_str): Change return type.
8478         * target.h (struct target_ops) <pid_to_str>: Change return type.
8479         (target_pid_to_str, normal_pid_to_str): Likewise.
8480         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8481         type.
8482         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8483         type.
8484         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8485         return type.
8486         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8487         type.
8488         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8489         type.
8490         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8491         return type.
8492
8493 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8494
8495         * NEWS: Mention that the new default MI version is 3.  Mention
8496         changes to the output of commands and events that deal with
8497         multi-location breakpoints.
8498         * breakpoint.c: Include "mi/mi-out.h".
8499         (print_one_breakpoint): Change output syntax if using MI version
8500         >= 3.
8501         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8502         New.
8503         (mi_multi_location_breakpoint_output_fixed): New.
8504         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8505         (mi_cmd_fix_multi_location_breakpoint_output): New.
8506         (mi_multi_location_breakpoint_output_fixed): New.
8507         * mi/mi-cmds.c (mi_cmds): Register command
8508         -fix-multi-location-breakpoint-output.
8509         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8510         interpreter "mi".
8511
8512 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8513
8514         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8515         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8516         instantiate mi_ui_out based on interpreter name.
8517         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8518         * mi/mi-main.c (mi_load_progress): Likewise.
8519
8520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8521
8522         * NEWS: Combine separate "New targets" sections for 8.3.
8523
8524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8525
8526         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8527         (ppcfbsd_init_abi): Install gdbarch
8528         "fetch_tls_load_module_address" and "get_thread_local_address"
8529         methods.
8530
8531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8532
8533         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8534         (riscv_fbsd_init_abi): Install gdbarch
8535         "fetch_tls_load_module_address" and "get_thread_local_address"
8536         methods.
8537
8538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8539
8540         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8541         (i386fbsd_init_abi): Install gdbarch
8542         "fetch_tls_load_module_address" and "get_thread_local_address"
8543         methods.
8544
8545 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8546
8547         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8548         (amd64fbsd_init_abi): Install gdbarch
8549         "fetch_tls_load_module_address" and "get_thread_local_address"
8550         methods.
8551
8552 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8553
8554         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8555         (struct fbsd_pspace_data): New type.
8556         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8557         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8558         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8559         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8560         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8561
8562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8563
8564         * gdbtypes.c (lookup_struct_elt): New function.
8565         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8566         * gdbtypes.h (struct struct_elt): New type.
8567         (lookup_struct_elt): New prototype.
8568
8569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8570
8571         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8572         remove disabled code block.
8573
8574 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8575
8576         * gdbarch.sh (get_thread_local_address): New method.
8577         * gdbarch.h, gdbarch.c: Regenerate.
8578         * target.c (target_translate_tls_address): Use
8579         gdbarch_get_thread_local_address if present instead of
8580         target::get_thread_local_address.
8581
8582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8583
8584         * target.h (target::get_thread_local_address): Update comment.
8585
8586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8587
8588         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8589         objfile->separate_debug_objfile_backlink if not NULL.
8590
8591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8592
8593         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8594         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8595         (amd64bsd_store_inferior_registers): Likewise.
8596         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8597         Enable segment base registers.
8598         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8599         PT_GETFSBASE and PT_GETGSBASE.
8600         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8601         PT_SETGSBASE.
8602         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8603         segment base registers.
8604         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8605
8606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8607
8608         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8609         Update calls to i386_target_description to add 'segments'
8610         parameter.
8611         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8612         add segment base registers.
8613         * arch/i386.c (i386_create_target_description): Add 'segments'
8614         parameter to enable segment base registers.
8615         * arch/i386.h (i386_create_target_description): Likewise.
8616         * features/i386/32bit-segments.xml: New file.
8617         * features/i386/32bit-segments.c: Generate.
8618         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8619         call to i386_target_description to add 'segments' parameter.
8620         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8621         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8622         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8623         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8624         if feature is present.
8625         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8626         Add 'segments' parameter to call to i386_target_description.
8627         (i386_target_description): Add 'segments' parameter to enable
8628         segment base registers.
8629         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8630         to call to i386_target_description.
8631         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8632         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8633         Define I386_NUM_REGS.
8634         (i386_target_description): Add 'segments' parameter to enable
8635         segment base registers.
8636
8637 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8638
8639         PR/24325
8640         * source-cache.c: #undef open and close, to avoid unresolved
8641         externals during linking.
8642
8643 2019-03-12  Tom Tromey  <tromey@adacore.com>
8644
8645         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8646         const.  Add initializers.
8647         (_initialize_remote): Don't initialize ptid globals.
8648
8649 2019-03-12  Pedro Alves  <palves@redhat.com>
8650
8651         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8652
8653 2019-03-12  Pedro Alves  <palves@redhat.com>
8654
8655         * cp-name-parser.y (main): Remove unused 'len' variable.
8656
8657 2019-03-12  Tom Tromey  <tromey@adacore.com>
8658
8659         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8660         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8661
8662 2019-03-12  Tom Tromey  <tromey@adacore.com>
8663
8664         * linux-nat.c (iterate_over_lwps): Update.
8665         (stop_callback): Remove parameter.
8666         (stop_wait_callback, detach_callback, resume_set_callback)
8667         (select_singlestep_lwp_callback, set_ignore_sigint)
8668         (status_callback, resumed_callback, resume_clear_callback)
8669         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8670         data parameter.
8671         (linux_nat_target::detach, linux_nat_target::resume)
8672         (linux_stop_and_wait_all_lwps, select_event_lwp)
8673         (linux_nat_filter_event, linux_nat_wait_1)
8674         (linux_nat_target::kill, linux_nat_target::stop)
8675         (linux_nat_target::stop): Update.
8676         (linux_nat_resume_callback): Change type.
8677         (resume_stopped_resumed_lwps, count_events_callback)
8678         (select_event_lwp_callback): Likewise.
8679         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8680         * arm-linux-nat.c (struct update_registers_data): Remove.
8681         (update_registers_callback): Change type.
8682         (arm_linux_insert_hw_breakpoint1): Update.
8683         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8684         parameter.
8685         (x86_linux_dr_set_addr): Update.
8686         (x86_linux_dr_set_control): Update.
8687         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8688         (iterate_over_lwps): Use gdb::function_view.
8689         * nat/aarch64-linux-hw-point.c (struct
8690         aarch64_dr_update_callback_param): Remove.
8691         (debug_reg_change_callback): Change type.
8692         (aarch64_notify_debug_reg_change): Update.
8693         * s390-linux-nat.c (s390_refresh_per_info): Update.
8694
8695 2019-03-11  Tom Tromey  <tromey@adacore.com>
8696
8697         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8698         redundant assignment to "this_cu".
8699
8700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8701
8702         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8703
8704 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8705
8706         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8707         from...
8708         (rank_one_type): ... this.
8709
8710 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8711
8712         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8713         from...
8714         (rank_one_type): ... this.
8715
8716 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8717
8718         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8719         from...
8720         (rank_one_type): ... this.
8721
8722 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8723
8724         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8725         from...
8726         (rank_one_type): ... this.
8727
8728 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8729
8730         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8731         from...
8732         (rank_one_type): ... this.
8733
8734 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8735
8736         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8737         from...
8738         (rank_one_type): ... this.
8739
8740 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8741
8742         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8743         from...
8744         (rank_one_type): ... this.
8745
8746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8747
8748         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8749         from...
8750         (rank_one_type): ... this.
8751
8752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8753
8754         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8755         from...
8756         (rank_one_type): ... this.
8757
8758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8759
8760         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8761         from...
8762         (rank_one_type): ... this.
8763
8764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8765
8766         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8767         from...
8768         (rank_one_type): ... this.
8769
8770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8771
8772         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8773         from...
8774         (rank_one_type): ... this.
8775
8776 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8777
8778         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8779         inferior-events' shows the example events.
8780
8781 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8782
8783         Support styling on native MS-Windows console
8784
8785         PR/24315
8786         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8787         on MS-Windows if $TERM is not defined.
8788
8789         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8790
8791         * posix-hdep.c (gdb_console_fputs):
8792         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8793         functions.
8794         * ui-file.h (gdb_console_fputs): Add prototype.
8795
8796         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8797         back to fputs only if the former returns zero.
8798
8799 2019-03-07  Tom Tromey  <tom@tromey.com>
8800
8801         * symmisc.c (print_symbol_bcache_statistics): Update.
8802         (print_objfile_statistics): Update.
8803         * symfile.c (allocate_symtab): Update.
8804         * stabsread.c: Don't include bcache.h.
8805         * psymtab.h (struct psymbol_bcache): Don't declare.
8806         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8807         (psymbol_bcache_init, psymbol_bcache_free)
8808         (psymbol_bcache_get_bcache): Don't declare.
8809         * psymtab.c (struct psymbol_bcache): Remove.
8810         (psymtab_storage::psymtab_storage): Update.
8811         (psymtab_storage::~psymtab_storage): Update.
8812         (psymbol_bcache_init, psymbol_bcache_free)
8813         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8814         (add_psymbol_to_bcache): Update.
8815         (allocate_psymtab): Update.
8816         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8817         macro_cache>: No longer pointers.
8818         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8819         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8820         * macrotab.c (macro_bcache): Update.
8821         * macroexp.c: Don't include bcache.h.
8822         * gdbtypes.c (check_types_worklist): Update.
8823         (types_deeply_equal): Remove TRY/CATCH.  Update.
8824         * elfread.c (elf_symtab_read): Update.
8825         * dwarf2read.c: Don't include bcache.h.
8826         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8827         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8828         (print_bcache_statistics, bcache_memory_used): Don't declare.
8829         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8830         methods.  Rename all data members.
8831         * bcache.c (struct bcache): Move to bcache.h.
8832         (bcache::expand_hash_table): Rename from expand_hash_table.
8833         (bcache): Remove.
8834         (bcache::insert): Rename from bcache_full.
8835         (bcache::compare): Rename from bcache_compare.
8836         (bcache_xmalloc): Remove.
8837         (bcache::~bcache): Rename from bcache_xfree.
8838         (bcache::print_statistics): Rename from print_bcache_statistics.
8839         (bcache::memory_used): Rename from bcache_memory_used.
8840
8841 2019-03-07  Pedro Alves  <palves@redhat.com>
8842
8843         * infrun.c (normal_stop): Also check for
8844         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8845
8846 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * f-lang.c (value_from_host_double): Moved to...
8849         * value.c (value_from_host_double): ...here.
8850         * value.h (value_from_host_double): Declare.
8851         * guile/scm-math.c (vlscm_convert_typed_number): Use
8852         value_from_host_double.
8853         (vlscm_convert_number): Likewise.
8854         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8855         * python/py-value.c (convert_value_from_python): Likewise.
8856
8857 2019-03-06  Tom Tromey  <tom@tromey.com>
8858
8859         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8860
8861 2019-03-06  Tom Tromey  <tom@tromey.com>
8862
8863         * utils.h (free_current_contents): Don't declare.
8864         * utils.c (free_current_contents): Remove.
8865
8866 2019-03-06  Tom Tromey  <tom@tromey.com>
8867
8868         * top.c (quit_force): Update.
8869         * main.c (captured_command_loop): Update.
8870         * common/new-op.c (operator new): Update.
8871         * common/common-exceptions.c (struct catcher)
8872         <save_cleanup_chain>: Remove member.
8873         (exceptions_state_mc_init): Update.
8874         (exception_try_scope_entry): Return nullptr.
8875         (exception_try_scope_exit, exception_rethrow)
8876         (throw_exception_sjlj, throw_exception_cxx): Update.
8877         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8878         (all_cleanups, do_cleanups, discard_cleanups)
8879         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8880         (restore_cleanups, restore_final_cleanups): Don't declare.
8881         (do_final_cleanups): Remove parameter.
8882         * common/cleanups.c (cleanup_chain, make_cleanup)
8883         (make_cleanup_dtor, all_cleanups, do_cleanups)
8884         (discard_my_cleanups, discard_cleanups)
8885         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8886         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8887         (null_cleanup): Remove.
8888         (do_final_cleanups): Remove parameter.
8889
8890 2019-03-06  Tom Tromey  <tom@tromey.com>
8891
8892         * remote.c (remote_target::remote_parse_stop_reply): Use
8893         unique_xmalloc_ptr.
8894
8895 2019-03-06  Tom Tromey  <tom@tromey.com>
8896
8897         * stabsread.c (struct stabs_field_info): Rename from field_info.
8898         <list, fnlist>: Add initializers.
8899         <obstack>: New member.
8900         (read_member_functions, read_struct_fields, read_baseclasses):
8901         Allocate on obstack.  Don't use cleanups.
8902         (read_one_struct_field, read_member_functions, read_struct_fields)
8903         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8904         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8905         (read_struct_type): Update.
8906
8907 2019-03-06  Tom Tromey  <tom@tromey.com>
8908
8909         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8910         * common/filestuff.h (make_cleanup_close): Don't declare.
8911         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8912         Remove.
8913
8914 2019-03-06  Tom Tromey  <tom@tromey.com>
8915
8916         * solib-aix.c: Use make_scope_exit.
8917
8918 2019-03-06  Tom Tromey  <tom@tromey.com>
8919
8920         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8921         Use make_scope_exit.
8922
8923 2019-03-06  Tom Tromey  <tom@tromey.com>
8924
8925         * solib-svr4.c (disable_probes_interface): Remove parameter.
8926         (svr4_handle_solib_event): Use make_scope_exit.
8927
8928 2019-03-06  Tom Tromey  <tom@tromey.com>
8929
8930         * remote.c (struct stop_reply_deleter): Remove.
8931         (stop_reply_up): Update.
8932         (struct stop_reply): Derive from notif_event.  Don't typedef.
8933         <regcache>: Now a std::vector.
8934         (stop_reply_xfree): Remove.
8935         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8936         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8937         (remote_target::discard_pending_stop_replies): Use delete.
8938         (remote_target::remote_parse_stop_reply): Update.
8939         (remote_target::process_stop_reply): Update.
8940         * remote-notif.h (struct notif_event): Add virtual destructor.
8941         Remove "dtr" member.
8942         (struct notif_client) <alloc_event>: Return a unique_ptr.
8943         (notif_event_xfree): Don't declare.
8944         (notif_event_up): New typedef.
8945         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8946         (notif_event_xfree, do_notif_event_xfree): Remove.
8947         (remote_notif_state_xfree): Update.
8948
8949 2019-03-06  Tom Tromey  <tom@tromey.com>
8950
8951         * infrun.c (displaced_step_clear_cleanup): Now a
8952         forward_scope_exit type.
8953         (displaced_step_prepare_throw): Update.
8954         (displaced_step_fixup): Update.
8955
8956 2019-03-06  Tom Tromey  <tom@tromey.com>
8957
8958         * inferior.h (class inferior): Update comment.
8959         * gdbthread.h (class thread_info): Update comment.
8960
8961 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8962             Tom Tromey  <tom@tromey.com>
8963
8964         * stabsread.h (struct stab_section_list): Remove.
8965         (coffstab_build_psymtabs): Update.
8966         * dbxread.c (symbuf_sections): Now a std::vector.
8967         (sect_idx): New global.
8968         (fill_symbuf): Update.
8969         (coffstab_build_psymtabs): Change type of stabsects parameter.
8970         Update.
8971         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8972         std::vector.
8973         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8974         (coff_locate_sections): Update.
8975         (coff_symfile_read): Remove cleanups.  Update.
8976         (init_stringtab): Add storage parameter.
8977         (free_stringtab, free_stringtab_cleanup): Remove.
8978         (init_lineno): Add storage parameter.
8979         (free_linetab, free_linetab_cleanup): Remove.
8980
8981 2019-03-06  Pedro Alves  <palves@redhat.com>
8982
8983         * linux-fork.c (fork_info::clobber_regs): Delete.
8984         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8985         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8986         comment.  Adjust.
8987         (scoped_switch_fork_info::scoped_switch_fork_info)
8988         (checkpoint_command, linux_fork_context): Adjust
8989         fork_save_infrun_state calls.
8990
8991 2019-03-06  Pedro Alves  <palves@redhat.com>
8992
8993         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8994         (inf_has_multiple_threads): Return 'bool' and rewrite using
8995         inferior_info::threads().
8996
8997 2019-03-06  Pedro Alves  <palves@redhat.com>
8998
8999         * linux-fork.c: Include <list>.
9000         (fork_list): Now a std::list instance.
9001         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9002         (forks_exist_p, find_last_fork): Adjust.
9003         (new_fork): Delete.
9004         (one_fork_p): New.
9005         (add_fork): Adjust.
9006         (free_fork): Delete, folded into fork_info::~fork_info().
9007         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9008         Adjust.
9009         (init_fork_list): Delete.
9010         (linux_fork_killall, linux_fork_mourn_inferior)
9011         (linux_fork_detach, info_checkpoints_command): Adjust.
9012         (_initialize_linux_fork): No longer call init_fork_list.
9013
9014 2019-03-06  Pedro Alves  <palves@redhat.com>
9015
9016         * linux-fork.c (new_fork): New, split out of ...
9017         (add_fork): ... this.  Return void.  Move "first fork" special
9018         case from here, to ...
9019         (checkpoint_command): ... here.
9020         * linux-linux.h (add_fork): Return void.
9021
9022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9023
9024         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9025
9026 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9027             Chris January  <chris.january@arm.com>
9028             David Lecomber  <david.lecomber@arm.com>
9029
9030         * f-exp.y: New token, UNOP_INTRINSIC.
9031         (exp): New pattern using UNOP_INTRINSIC token.
9032         (f77_keywords): Add 'abs' keyword.
9033         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9034         (value_from_host_double): New function.
9035         (evaluate_subexp_f): Support UNOP_ABS.
9036
9037 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9038
9039         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9040         types.
9041
9042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9043
9044         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9045         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9046         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9047
9048 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9051
9052 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9053             Chris January  <chris.january@arm.com>
9054
9055         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9056         * f-exp.y: Define 'KIND' token.
9057         (exp): New pattern for KIND expressions.
9058         (ptype): Handle types with a kind extension.
9059         (direct_abs_decl): Extend to spot kind extensions.
9060         (f77_keywords): Add 'kind' to the list.
9061         (push_kind_type): New function.
9062         (convert_to_kind_type): New function.
9063         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9064         * parse.c (operator_length_standard): Likewise.
9065         * parser-defs.h (enum type_pieces): Add tp_kind.
9066         * std-operator.def: Add UNOP_KIND.
9067
9068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9069
9070         * f-exp.y (f_parse): Set yydebug.
9071
9072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9073
9074         * f-lang.c (evaluate_subexp_f): New function.
9075         (exp_descriptor_f): New global.
9076         (f_language_defn): Use exp_descriptor_f instead of
9077         exp_descriptor_standard.
9078
9079 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9080
9081         * f-exp.y (struct token): Add comments.
9082         (dot_ops): Remove uppercase versions and the end marker.
9083         (f77_keywords): Likewise.
9084         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9085         entries in the dot_ops array are case insensitive, and use
9086         strncasecmp to compare strings.  Also some whitespace cleanup in
9087         this area.  Similar for the f77_keywords array, except entries in
9088         this list might be case sensitive.
9089
9090 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9091
9092         * f-exp.y (struct f77_boolean_val): Add comments.
9093         (boolean_values): Remove uppercase versions, and end marker.
9094         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9095         and use strncasecmp to achieve case insensitivity.  Additionally,
9096         perform whitespace cleanup around this code.
9097
9098 2019-03-06  Tom Tromey  <tromey@adacore.com>
9099
9100         * remote-sim.c (gdbsim_target_open): Use result of
9101         gdb_argv::release.
9102
9103 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9104         Dirk Schubert  <dirk.schubert@arm.com>
9105         Chris January  <chris.january@arm.com>
9106
9107         * eval.c (evaluate_subexp_standard): Call Fortran argument
9108         wrapping logic.
9109         * f-lang.c (struct value): A value which can be passed into a
9110         Fortran function call.
9111         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9112         where appropriate.
9113         (struct type): Value ready for a Fortran function call.
9114         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9115         is needed.
9116         * f-lang.h (fortran_argument_convert): Declaration.
9117         (fortran_preserve_arg_pointer): Declaration.
9118         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9119
9120 2019-03-05  Tom Tromey  <tromey@adacore.com>
9121
9122         * python/py-prettyprint.c (print_string_repr): Remove #if.
9123         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9124
9125 2019-03-05  Tom Tromey  <tromey@adacore.com>
9126
9127         * target.c (the_dummy_target): Move later.  Change type to
9128         "dummy_target".
9129         (initialize_targets): Don't initialize the_dummy_target.
9130
9131 2019-03-05  Tom Tromey  <tromey@adacore.com>
9132
9133         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9134         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9135
9136 2019-03-05  Tom Tromey  <tromey@adacore.com>
9137
9138         * windows-nat.c (windows_nat_target::attach)
9139         (windows_nat_target::detach): Don't call gdb_flush.
9140         * valprint.c (generic_val_print, val_print, val_print_string):
9141         Don't call gdb_flush.
9142         * utils.c (defaulted_query): Don't call gdb_flush.
9143         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9144         * target.c (target_announce_detach): Don't call gdb_flush.
9145         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9146         * remote.c (extended_remote_target::attach): Don't call
9147         gdb_flush.
9148         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9149         * printcmd.c (do_examine): Don't call gdb_flush.
9150         (info_display_command): Don't call gdb_flush.
9151         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9152         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9153         * memattr.c (info_mem_command): Don't call gdb_flush.
9154         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9155         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9156         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9157         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9158         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9159         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9160         (gnu_nat_target::detach): Don't call gdb_flush.
9161         * f-valprint.c (f_val_print): Don't call gdb_flush.
9162         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9163         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9164         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9165         gdb_flush.
9166         * c-valprint.c (c_val_print): Don't call gdb_flush.
9167         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9168
9169 2019-03-05  Tom Tromey  <tromey@adacore.com>
9170
9171         * varobj.c (update_dynamic_varobj_children): Update.
9172         (install_default_visualizer): Use reset, not release.
9173         * value.c (set_internalvar): Update.
9174         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9175         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9176         ATTRIBUTE_UNUSED_RESULT.
9177
9178 2019-03-05  Tom Tromey  <tromey@adacore.com>
9179
9180         * remote.c (class scoped_remote_fd) <release>: Add
9181         ATTRIBUTE_UNUSED_RESULT.
9182
9183 2019-03-05  Tom Tromey  <tromey@adacore.com>
9184
9185         * macroexp.c (struct macro_buffer) <release>: Add
9186         ATTRIBUTE_UNUSED_RESULT.
9187
9188 2019-03-05  Tom Tromey  <tromey@adacore.com>
9189
9190         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9191         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9192         ATTRIBUTE_UNUSED_RESULT.
9193
9194 2019-03-05  Tom Tromey  <tromey@adacore.com>
9195
9196         * common/scoped_fd.h (class scoped_fd) <release>: Add
9197         ATTRIBUTE_UNUSED_RESULT.
9198
9199 2019-03-05  Tom Tromey  <tromey@adacore.com>
9200
9201         * parser-defs.h (struct parser_state) <release>: Add
9202         ATTRIBUTE_UNUSED_RESULT.
9203
9204 2019-03-05  Tom Tromey  <tromey@adacore.com>
9205
9206         * utils.h (class gdb_argv) <release>: Add
9207         ATTRIBUTE_UNUSED_RESULT.
9208         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9209
9210 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9211
9212         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9213         for-loop range, to avoid compiler warnings.
9214
9215         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9216         avoid compiler warnings about unused variables.
9217
9218         * NEWS: Mention end of support for native debugging on MS-Windows
9219         before XP.
9220
9221         PR gdb/24292
9222         * common/netstuff.c:
9223         * gdbserver/gdbreplay.c
9224         * gdbserver/remote-utils.c:
9225         * ser-tcp.c:
9226         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9227         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9228         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9229         'getaddrinfo' and 'freeaddrinfo' were not available before
9230         Windows XP, and mingw.org's MinGW headers by default define
9231         _WIN32_WINNT to 0x500.
9232
9233 2019-03-01  Gary Benson <gbenson@redhat.com>
9234
9235         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9236
9237 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9238             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9239
9240         PR gdb/8527
9241         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9242         set_sigint_trap, clear_sigint_trap.
9243
9244 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9245
9246         * target.c (target_detach): Clear the regcache and the
9247         frame cache.
9248
9249 2019-02-27  Pedro Alves  <palves@redhat.com>
9250
9251         * utils.c (set_screen_size): When we cap the height/width sizes,
9252         tweak the corresponding command variable to show "unlimited":
9253
9254 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9255             Pedro Alves  <palves@redhat.com>
9256
9257         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9258         before calling rl_set_screen_size.
9259
9260 2019-02-27  Tom Tromey  <tromey@adacore.com>
9261
9262         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9263         define.
9264         * python/py-value.c: Remove Python 2.4 workaround.
9265         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9266         workaround.
9267         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9268         Python 2.4 workaround.
9269         * python/python-internal.h: Remove Python 2.4 comment.
9270         (Py_ssize_t): Don't define.
9271         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9272         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9273         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9274         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9275         * python/python.c (do_start_initialization): Remove Python 2.4
9276         workaround.
9277         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9278         (print_children): Remove Python 2.4 workaround.
9279         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9280         workaround.
9281         (CHARBUFFERPROC_NAME): Remove.
9282         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9283         Python 2.4 workaround.
9284
9285 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9286
9287         * NEWS: Note minimum Python version.
9288
9289 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9290
9291         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9292         code from these functions.  Remove corresponding ifdefs.  Use
9293         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9294         Remove gotos and target of gotos.
9295         (infpy_search_memory): Likewise.
9296
9297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9300         (hppa_gdbarch_init): Don't register deleted functions with
9301         gdbarch.
9302
9303 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9306         (h8300_unwind_sp): Delete.
9307         (h8300_dummy_id): Delete.
9308         (h8300_gdbarch_init): Don't register deleted functions with
9309         gdbarch.
9310
9311 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9312
9313         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9314         (ft32_unwind_pc): Delete.
9315         (ft32_unwind_sp): Delete.
9316         (ft32_gdbarch_init): Don't register deleted functions with
9317         gdbarch.
9318
9319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9320
9321         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9322         (frv_unwind_pc): Delete.
9323         (frv_unwind_sp): Delete.
9324         (frv_gdbarch_init): Don't register deleted functions with
9325         gdbarch.
9326
9327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9328
9329         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9330         (riscv_unwind_pc): Delete.
9331         (riscv_unwind_sp): Delete.
9332         (riscv_gdbarch_init): Don't register deleted functions with
9333         gdbarch.
9334
9335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9338         (csky_unwind_pc): Delete.
9339         (csky_unwind_sp): Delete.
9340         (csky_gdbarch_init): Don't register deleted functions with
9341         gdbarch.
9342
9343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9346         (cris_unwind_pc): Delete.
9347         (cris_unwind_sp): Delete.
9348         (cris_gdbarch_init): Don't register deleted functions with
9349         gdbarch.
9350
9351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9354         (bfin_unwind_pc): Delete.
9355         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9356
9357 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9360         (arm_unwind_pc): Delete.
9361         (arm_unwind_sp): Delete.
9362         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9363
9364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9365
9366         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9367         (arc_unwind_pc): Delete.
9368         (arc_unwind_sp): Delete.
9369         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9370
9371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9372
9373         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9374         (alpha_unwind_pc): Delete.
9375         (alpha_gdbarch_init): Don't register deleted functions with
9376         gdbarch.
9377
9378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9379
9380         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9381         (aarch64_unwind_pc): Delete.
9382         (aarch64_unwind_sp): Delete.
9383         (aarch64_gdbarch_init): Don't register deleted functions with
9384         gdbarch.
9385
9386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * gdbtypes.c (type_align): Don't consider static members when
9389         computing structure alignment.
9390
9391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9392
9393         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9394         return 0 for other types.
9395         * arch-utils.c (default_type_align): Always return 0.
9396         * gdbarch.h: Regenerate.
9397         * gdbarch.sh (type_align): Extend comment.
9398         * gdbtypes.c (type_align): Add additional comments, always call
9399         gdbarch_type_align before applying the default rules.
9400         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9401         generic code will then apply a suitable default.
9402         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9403         types, return 0 for other types.
9404
9405 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9406
9407         * NEWS: Create a new section for the next release branch.
9408         Rename the section of the current branch, now that it has
9409         been cut.
9410
9411 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9412
9413         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9414         * version.in: Bump version to 8.3.50.DATE-git.
9415
9416 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9417
9418         * aix-thread.c (ptid_cmp): Remove unused variable.
9419         (get_signaled_thread): Likewise.
9420         (store_regs_user_thread): Likewise.
9421         (store_regs_kernel_thread): Likewise.
9422         (fetch_regs_kernel_thread): Remove shadowed variable.
9423
9424 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9425
9426         * features/riscv/32bit-cpu.xml: Add register numbers.
9427         * features/riscv/32bit-fpu.c: Regenerate.
9428         * features/riscv/32bit-fpu.xml: Add register numbers.
9429         * features/riscv/64bit-cpu.xml: Add register numbers.
9430         * features/riscv/64bit-fpu.c: Regenerate.
9431         * features/riscv/64bit-fpu.xml: Add register numbers.
9432
9433 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9434
9435         * NEWS: Mention two argument form of gdb.Value constructor.
9436         * python/py-value.c (convert_buffer_and_type_to_value): New
9437         function.
9438         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9439         Add support for handling an optional second argument.  Call
9440         convert_buffer_and_type_to_value as appropriate.
9441         * python/python-internal.h (Py_buffer_deleter): New struct.
9442         (Py_buffer_up): New typedef.
9443
9444 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9445
9446         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9447         instead of releasing ownership.
9448
9449 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9450
9451         * dwarf2read.c (open_and_init_dwp_file): Call
9452         elf_numsections instead of bfd_count_sections to initialize
9453         dwp_file->num_sections.
9454
9455 2019-02-25  Tom Tromey  <tromey@adacore.com>
9456
9457         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9458
9459 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9460
9461         * gcore.in: Add '--readnever' option when invoking GDB.
9462
9463 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9464
9465         * MAINTAINERS: Update my email address.
9466
9467 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9468
9469         * build-id.c (build_id_to_debug_bfd_1): New function.
9470         (build_id_to_debug_bfd): Look for separate debug file in
9471         sysroot.
9472
9473 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * gdbarch.sh: Update the copyright year range that is placed into
9476         generated files.
9477
9478 2019-02-22  Keith Seitz  <keiths@redhat.com>
9479
9480         PR symtab/23853
9481         * linespec.c (create_sals_line_offset): Search for the default
9482         symtab's filename instead of its fullname.
9483
9484 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9485
9486         * NEWS: Update style defaults.
9487
9488 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9489
9490         * main.c (captured_main_1): Disable styling in batch mode.
9491
9492 2019-02-20  Tom Tromey  <tom@tromey.com>
9493
9494         * symtab.c (symtab_symbol_info): Fix typos.
9495
9496 2019-02-20  Tom Tromey  <tromey@adacore.com>
9497
9498         * findcmd.c (_initialize_mem_search): Use upper case for
9499         metasyntactic variables.
9500
9501 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9502
9503         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9504         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9505
9506 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9507
9508         * top.h (source_file_name): Change to std::string.
9509         * top.c (source_file_name): Likewise.
9510         (command_line_input): Adjust.
9511         * cli/cli-script.c (script_from_file): Adjust.
9512
9513 2019-02-19  Tom Tromey  <tromey@adacore.com>
9514
9515         * ravenscar-thread.c
9516         (ravenscar_thread_target::update_thread_list): Don't call
9517         ada_build_task_list.
9518         * ada-lang.h (ada_build_task_list): Don't declare.
9519         * ada-tasks.c (struct ada_tasks_inferior_data)
9520         <task_list_valid_p>: Now bool.
9521         (read_known_tasks, ada_task_list_changed)
9522         (ada_tasks_invalidate_inferior_data): Update.
9523         (read_known_tasks_array): Return bool.
9524         (read_known_tasks_list): Likewise.
9525         (read_known_tasks): Return void.
9526         (ada_build_task_list): Now static.
9527
9528 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9531         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9532
9533 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9534
9535         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9536         variant for ada_tasks_pspace_data_handle and
9537         ada_tasks_inferior_data_handle.
9538         (ada_tasks_pspace_data_cleanup): New function.
9539         (ada_tasks_inferior_data_cleanup): New function.
9540
9541 2019-02-17  Tom Tromey  <tom@tromey.com>
9542
9543         * macrotab.h (macro_source_fullname): Return a std::string.
9544         * macrotab.c (macro_include, check_for_redefinition)
9545         (macro_undef, macro_lookup_definition, foreach_macro)
9546         (foreach_macro_in_scope): Update.
9547         (macro_source_fullname): Return a std::string.
9548         * macrocmd.c (show_pp_source_pos): Update.
9549
9550 2019-02-17  Tom Tromey  <tom@tromey.com>
9551
9552         * macrocmd.c (show_pp_source_pos): Style the file names.
9553
9554 2019-02-17  Tom Tromey  <tom@tromey.com>
9555
9556         PR tui/24197:
9557         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9558
9559 2019-02-17  Tom Tromey  <tom@tromey.com>
9560
9561         * ada-lang.c (user_select_syms): Use filtered printing.
9562         * utils.c (wrap_style): New global.
9563         (desired_style): Remove.
9564         (emit_style_escape): Add stream parameter.
9565         (set_output_style, reset_terminal_style, prompt_for_continue):
9566         Update.
9567         (flush_wrap_buffer): Only flush gdb_stdout.
9568         (wrap_here): Set wrap_style.
9569         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9570         treat escape sequences as a character.  Change when wrap buffer is
9571         flushed.
9572         (fputs_styled): Do not set the output style when the default is
9573         requested.
9574         * ui-style.h (struct ui_file_style) <is_default>: New method.
9575         * source.c (print_source_lines_base): Emit escape sequences in one
9576         piece.
9577
9578 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9579
9580         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9581         integers and enumeration types.
9582
9583 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9584
9585         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9586         instead of lookup_symbol_in_language
9587         (do_exact_match): New function.
9588         (ada_get_symbol_name_matcher): Return do_exact_match when
9589         doing a verbatim match.
9590
9591 2019-02-15  Tom Tromey  <tromey@adacore.com>
9592
9593         * ravenscar-thread.c (ravenscar_thread_target::resume)
9594         (ravenscar_thread_target::wait): Special case wildcard requests.
9595
9596 2019-02-15  Tom Tromey  <tromey@adacore.com>
9597
9598         * ravenscar-thread.c (base_ptid): Remove.
9599         (struct ravenscar_thread_target) <close>: New method.
9600         <m_base_ptid>: New member.
9601         <update_inferior_ptid, active_task, task_is_currently_active,
9602         runtime_initialized>: Declare methods.
9603         <ravenscar_thread_target>: Add constructor.
9604         (ravenscar_thread_target::task_is_currently_active)
9605         (ravenscar_thread_target::update_inferior_ptid)
9606         (ravenscar_runtime_initialized): Rename.  Now methods.
9607         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9608         (ravenscar_thread_target::update_thread_list): Update.
9609         (ravenscar_thread_target::active_task): Now method.
9610         (ravenscar_thread_target::store_registers)
9611         (ravenscar_thread_target::prepare_to_store)
9612         (ravenscar_thread_target::prepare_to_store)
9613         (ravenscar_thread_target::mourn_inferior): Update.
9614         (ravenscar_inferior_created): Use "new" to create target.
9615         (ravenscar_thread_target::get_ada_task_ptid): Update.
9616         (_initialize_ravenscar): Don't initialize base_ptid.
9617         (ravenscar_ops): Remove global.
9618
9619 2019-02-15  Tom Tromey  <tromey@adacore.com>
9620
9621         * target.h (push_target): Declare new overload.
9622         * target.c (push_target): New overload, taking an rvalue reference.
9623         * remote.c (remote_target::open_1): Use push_target overload.
9624         * corelow.c (core_target_open): Use push_target overload.
9625
9626 2019-02-15  Tom Tromey  <tromey@adacore.com>
9627
9628         * ravenscar-thread.c (is_ravenscar_task)
9629         (ravenscar_task_is_currently_active): Return bool.
9630         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9631         (_initialize_ravenscar): Remove "(void)".
9632         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9633         Return bool.
9634
9635 2019-02-15  Tom Tromey  <tromey@adacore.com>
9636
9637         * ravenscar-thread.c (ravenscar_runtime_initializer)
9638         (has_ravenscar_runtime, get_running_thread_id)
9639         (ravenscar_thread_target::resume): Fix indentation.
9640
9641 2019-02-15  Tom Tromey  <tromey@adacore.com>
9642
9643         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9644         from ravenscar_arch_ops.
9645         (sparc_ravenscar_ops::fetch_registers)
9646         (sparc_ravenscar_ops::store_registers): Now methods.
9647         (sparc_ravenscar_prepare_to_store): Remove.
9648         (sparc_ravenscar_ops): Redefine.
9649         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9650         methods and destructor.  Remove members.
9651         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9652         (ravenscar_thread_target::store_registers)
9653         (ravenscar_thread_target::prepare_to_store): Update.
9654         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9655         Remove.
9656         (struct ppc_ravenscar_powerpc_ops): Derive from
9657         ravenscar_arch_ops.
9658         (ppc_ravenscar_powerpc_ops::fetch_registers)
9659         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9660         (ppc_ravenscar_powerpc_ops): Redefine.
9661         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9662         (ppc_ravenscar_e500_ops::fetch_registers)
9663         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9664         (ppc_ravenscar_e500_ops): Redefine.
9665         * aarch64-ravenscar-thread.c
9666         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9667         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9668         (aarch64_ravenscar_fetch_registers)
9669         (aarch64_ravenscar_store_registers): Now methods.
9670         (aarch64_ravenscar_ops): Redefine.
9671
9672 2019-02-15  Tom Tromey  <tromey@adacore.com>
9673
9674         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9675         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9676         (ravenscar_thread_target::stopped_by_watchpoint)
9677         (ravenscar_thread_target::stopped_data_address)
9678         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9679
9680 2019-02-15  Tom Tromey  <tromey@adacore.com>
9681
9682         * ravenscar-thread.c: Fix some typos.
9683
9684 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9685             Tom Tromey  <tromey@adacore.com>
9686
9687         * ada-lang.c (ada_exception_sal): Change addr_string to a
9688         std::string.
9689         (create_ada_exception_catchpoint): Update.
9690
9691 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9692             Tom Tromey  <tromey@adacore.com>
9693
9694         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9695         (bp_location_ops): Remove.
9696         (base_breakpoint_allocate_location): Update.
9697         (free_bp_location): Update.
9698         * ada-lang.c (class ada_catchpoint_location)
9699         <ada_catchpoint_location>: Remove ops parameter.
9700         (ada_catchpoint_location_dtor): Remove.
9701         (ada_catchpoint_location_ops): Remove.
9702         (allocate_location_exception): Update.
9703         * breakpoint.h (struct bp_location_ops): Remove.
9704         (class bp_location) <bp_location>: Remove bp_location_ops
9705         parameter.
9706         <~bp_location>: Add destructor.
9707         <ops>: Remove.
9708
9709 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9710             Pedro Alves  <palves@redhat.com>
9711
9712         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9713         'PATH_MAX'.
9714
9715 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9716             Samuel Thibault  <samuel.thibault@gnu.org>
9717             Thomas Schwinge  <thomas@codesourcery.com>
9718
9719         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9720         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9721
9722 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9723
9724         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9725         (check_empty): Use "const char *".
9726
9727         * gnu-nat.c (gnu_nat_target::detach): Instead of
9728         'detach_inferior (pid)' call
9729         'detach_inferior (find_inferior_pid (pid))'.
9730
9731         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9732         'nat/fork-inferior.o'.
9733         * gnu-nat.c: #include "nat/fork-inferior.h".
9734
9735         * gnu-nat.c (gnu_nat_target::detach): Instead of
9736         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9737         * gnu-nat.h: #include "inf-child.h".
9738         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9739         'i386_gnu_nat_target::fetch_registers'.
9740         (gnu_store_registers): Rename/move to
9741         'i386_gnu_nat_target::store_registers'.
9742
9743         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9744         * gnu-nat.h (mach_thread_info): New function.
9745         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9746
9747         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9748
9749 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9750
9751         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9752
9753 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9754
9755         * windows-nat.c (windows_add_thread): Add new parameter
9756         "main_thread_p" with default value set to false.  Update
9757         function documentation as well as all callers.
9758         (windows_delete_thread): Likewise.
9759         (fake_create_process): Update call to windows_add_thread.
9760         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9761         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9762         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9763         call to windows_delete_thread.
9764
9765 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9766
9767         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9768
9769 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9770
9771         * symfile.c (find_separate_debug_file): Use canonical path of
9772         sysroot with child_path instead of gdb_sysroot if it is valid.
9773
9774 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9775
9776         * symfile.c (find_separate_debug_file): Use child_path to
9777         determine if an object file is under a sysroot.
9778
9779 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9780
9781         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9782         unittests/child-path-selftests.c.
9783         * common/pathstuff.c (child_path): New function.
9784         * common/pathstuff.h (child_path): New prototype.
9785         * unittests/child-path-selftests.c: New file.
9786
9787 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9788
9789         * symfile.c (find_separate_debug_file): Look for separate debug
9790         files in debug directories under the sysroot.
9791
9792 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9793
9794         * symtab.h (struct minimal_symbol data_p): New const method.
9795         (struct minimal_symbol text_p): Likewise.
9796         * symtab.c (output_source_filename): Use file name style
9797         to print file name.
9798         (print_symbol_info): Likewise.
9799         (print_msymbol_info): Use address style to print addresses.
9800         Use function name style to print executable text symbols.
9801         (expand_symtab_containing_pc): Use data_p.
9802         (find_pc_sect_compunit_symtab): Likewise.
9803
9804 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9805
9806         * breakpoint.c (describe_other_breakpoints): Use address style
9807         to print addresses.
9808         (say_where): Likewise.
9809
9810 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9811
9812         * ada-typeprint.c (print_func_type): Print function name
9813         style to print function name.
9814         * c-typeprint.c (c_print_type_1): Likewise.
9815
9816 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9817
9818         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9819         for execve.
9820
9821 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9822
9823         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9824         type_stack.
9825
9826 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9827
9828         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9829         TYPE_CODE_REF types.
9830
9831 2019-02-08  Jim Wilson  <jimw@sifive.com>
9832
9833         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9834         (riscv_linux_fregset): New.
9835         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9836
9837 2019-02-07  Tom Tromey  <tom@tromey.com>
9838
9839         * thread.c (thread_cancel_execution_command): Update.
9840         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9841         methods.
9842         (struct thread_fsm_ops): Remove.
9843         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9844         (thread_fsm_should_stop, thread_fsm_return_value)
9845         (thread_fsm_set_finished, thread_fsm_finished_p)
9846         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9847         Don't declare.
9848         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9849         * infrun.c (clear_proceed_status_thread)
9850         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9851         (print_stop_event): Update.
9852         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9853         Add constructor.
9854         (step_command_fsm_ops): Remove.
9855         (new_step_command_fsm): Remove.
9856         (step_1): Update.
9857         (step_command_fsm::should_stop): Rename from
9858         step_command_fsm_should_stop.
9859         (step_command_fsm::clean_up): Rename from
9860         step_command_fsm_clean_up.
9861         (step_command_fsm::do_async_reply_reason): Rename from
9862         step_command_fsm_async_reply_reason.
9863         (struct until_next_fsm): Inherit from thread_fsm.  Add
9864         constructor.
9865         (until_next_fsm_ops): Remove.
9866         (new_until_next_fsm): Remove.
9867         (until_next_fsm::should_stop): Rename from
9868         until_next_fsm_should_stop.
9869         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9870         (until_next_fsm::do_async_reply_reason): Rename from
9871         until_next_fsm_async_reply_reason.
9872         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9873         constructor.  Change type of breakpoint.
9874         (finish_command_fsm_ops): Remove.
9875         (new_finish_command_fsm): Remove.
9876         (finish_command_fsm::should_stop): Rename from
9877         finish_command_fsm_should_stop.
9878         (finish_command_fsm::clean_up): Rename from
9879         finish_command_fsm_clean_up.
9880         (finish_command_fsm::return_value): Rename from
9881         finish_command_fsm_return_value.
9882         (finish_command_fsm::do_async_reply_reason): Rename from
9883         finish_command_fsm_async_reply_reason.
9884         (finish_command): Update.
9885         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9886         Add constructor.
9887         (call_thread_fsm_ops): Remove.
9888         (call_thread_fsm::call_thread_fsm): Rename from
9889         new_call_thread_fsm.
9890         (call_thread_fsm::should_stop): Rename from
9891         call_thread_fsm_should_stop.
9892         (call_thread_fsm::should_notify_stop): Rename from
9893         call_thread_fsm_should_notify_stop.
9894         (run_inferior_call, call_function_by_hand_dummy): Update.
9895         * cli/cli-interp.c (should_print_stop_to_console): Update.
9896         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9897         Add constructor.  Change type of location_breakpoint,
9898         caller_breakpoint.
9899         (until_break_fsm_ops): Remove.
9900         (new_until_break_fsm): Remove.
9901         (until_break_fsm::should_stop): Rename from
9902         until_break_fsm_should_stop.
9903         (until_break_fsm::clean_up): Rename from
9904         until_break_fsm_clean_up.
9905         (until_break_fsm::do_async_reply_reason): Rename from
9906         until_break_fsm_async_reply_reason.
9907         (until_break_command): Update.
9908         * thread-fsm.c: Remove.
9909         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9910
9911 2019-02-07  Tom Tromey  <tom@tromey.com>
9912
9913         * yy-remap.h: Add include guard.
9914         * xtensa-tdep.h: Add include guard.
9915         * xcoffread.h: Rename include guard.
9916         * varobj-iter.h: Add include guard.
9917         * tui/tui.h: Rename include guard.
9918         * tui/tui-winsource.h: Rename include guard.
9919         * tui/tui-wingeneral.h: Rename include guard.
9920         * tui/tui-windata.h: Rename include guard.
9921         * tui/tui-win.h: Rename include guard.
9922         * tui/tui-stack.h: Rename include guard.
9923         * tui/tui-source.h: Rename include guard.
9924         * tui/tui-regs.h: Rename include guard.
9925         * tui/tui-out.h: Rename include guard.
9926         * tui/tui-layout.h: Rename include guard.
9927         * tui/tui-io.h: Rename include guard.
9928         * tui/tui-hooks.h: Rename include guard.
9929         * tui/tui-file.h: Rename include guard.
9930         * tui/tui-disasm.h: Rename include guard.
9931         * tui/tui-data.h: Rename include guard.
9932         * tui/tui-command.h: Rename include guard.
9933         * tic6x-tdep.h: Add include guard.
9934         * target/waitstatus.h: Rename include guard.
9935         * target/wait.h: Rename include guard.
9936         * target/target.h: Rename include guard.
9937         * target/resume.h: Rename include guard.
9938         * target-float.h: Rename include guard.
9939         * stabsread.h: Add include guard.
9940         * rs6000-tdep.h: Add include guard.
9941         * riscv-fbsd-tdep.h: Add include guard.
9942         * regformats/regdef.h: Rename include guard.
9943         * record.h: Rename include guard.
9944         * python/python.h: Rename include guard.
9945         * python/python-internal.h: Rename include guard.
9946         * python/py-stopevent.h: Rename include guard.
9947         * python/py-ref.h: Rename include guard.
9948         * python/py-record.h: Rename include guard.
9949         * python/py-record-full.h: Rename include guard.
9950         * python/py-record-btrace.h: Rename include guard.
9951         * python/py-instruction.h: Rename include guard.
9952         * python/py-events.h: Rename include guard.
9953         * python/py-event.h: Rename include guard.
9954         * procfs.h: Add include guard.
9955         * proc-utils.h: Add include guard.
9956         * p-lang.h: Add include guard.
9957         * or1k-tdep.h: Rename include guard.
9958         * observable.h: Rename include guard.
9959         * nto-tdep.h: Rename include guard.
9960         * nat/x86-linux.h: Rename include guard.
9961         * nat/x86-linux-dregs.h: Rename include guard.
9962         * nat/x86-gcc-cpuid.h: Add include guard.
9963         * nat/x86-dregs.h: Rename include guard.
9964         * nat/x86-cpuid.h: Rename include guard.
9965         * nat/ppc-linux.h: Rename include guard.
9966         * nat/mips-linux-watch.h: Rename include guard.
9967         * nat/linux-waitpid.h: Rename include guard.
9968         * nat/linux-ptrace.h: Rename include guard.
9969         * nat/linux-procfs.h: Rename include guard.
9970         * nat/linux-osdata.h: Rename include guard.
9971         * nat/linux-nat.h: Rename include guard.
9972         * nat/linux-namespaces.h: Rename include guard.
9973         * nat/linux-btrace.h: Rename include guard.
9974         * nat/glibc_thread_db.h: Rename include guard.
9975         * nat/gdb_thread_db.h: Rename include guard.
9976         * nat/gdb_ptrace.h: Rename include guard.
9977         * nat/fork-inferior.h: Rename include guard.
9978         * nat/amd64-linux-siginfo.h: Rename include guard.
9979         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9980         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9981         * nat/aarch64-linux.h: Rename include guard.
9982         * nat/aarch64-linux-hw-point.h: Rename include guard.
9983         * mn10300-tdep.h: Add include guard.
9984         * mips-linux-tdep.h: Add include guard.
9985         * mi/mi-parse.h: Rename include guard.
9986         * mi/mi-out.h: Rename include guard.
9987         * mi/mi-main.h: Rename include guard.
9988         * mi/mi-interp.h: Rename include guard.
9989         * mi/mi-getopt.h: Rename include guard.
9990         * mi/mi-console.h: Rename include guard.
9991         * mi/mi-common.h: Rename include guard.
9992         * mi/mi-cmds.h: Rename include guard.
9993         * mi/mi-cmd-break.h: Rename include guard.
9994         * m2-lang.h: Add include guard.
9995         * location.h: Rename include guard.
9996         * linux-record.h: Rename include guard.
9997         * linux-nat.h: Add include guard.
9998         * linux-fork.h: Add include guard.
9999         * i386-darwin-tdep.h: Rename include guard.
10000         * hppa-linux-offsets.h: Add include guard.
10001         * guile/guile.h: Rename include guard.
10002         * guile/guile-internal.h: Rename include guard.
10003         * gnu-nat.h: Rename include guard.
10004         * gdb-stabs.h: Rename include guard.
10005         * frv-tdep.h: Add include guard.
10006         * f-lang.h: Add include guard.
10007         * event-loop.h: Add include guard.
10008         * darwin-nat.h: Rename include guard.
10009         * cp-abi.h: Rename include guard.
10010         * config/sparc/nm-sol2.h: Rename include guard.
10011         * config/nm-nto.h: Rename include guard.
10012         * config/nm-linux.h: Add include guard.
10013         * config/i386/nm-i386gnu.h: Rename include guard.
10014         * config/djgpp/nl_types.h: Rename include guard.
10015         * config/djgpp/langinfo.h: Rename include guard.
10016         * compile/gcc-cp-plugin.h: Add include guard.
10017         * compile/gcc-c-plugin.h: Add include guard.
10018         * compile/compile.h: Rename include guard.
10019         * compile/compile-object-run.h: Rename include guard.
10020         * compile/compile-object-load.h: Rename include guard.
10021         * compile/compile-internal.h: Rename include guard.
10022         * compile/compile-cplus.h: Rename include guard.
10023         * compile/compile-c.h: Rename include guard.
10024         * common/xml-utils.h: Rename include guard.
10025         * common/x86-xstate.h: Rename include guard.
10026         * common/version.h: Rename include guard.
10027         * common/vec.h: Rename include guard.
10028         * common/tdesc.h: Rename include guard.
10029         * common/selftest.h: Rename include guard.
10030         * common/scoped_restore.h: Rename include guard.
10031         * common/scoped_mmap.h: Rename include guard.
10032         * common/scoped_fd.h: Rename include guard.
10033         * common/safe-iterator.h: Rename include guard.
10034         * common/run-time-clock.h: Rename include guard.
10035         * common/refcounted-object.h: Rename include guard.
10036         * common/queue.h: Rename include guard.
10037         * common/ptid.h: Rename include guard.
10038         * common/print-utils.h: Rename include guard.
10039         * common/preprocessor.h: Rename include guard.
10040         * common/pathstuff.h: Rename include guard.
10041         * common/observable.h: Rename include guard.
10042         * common/netstuff.h: Rename include guard.
10043         * common/job-control.h: Rename include guard.
10044         * common/host-defs.h: Rename include guard.
10045         * common/gdb_wait.h: Rename include guard.
10046         * common/gdb_vecs.h: Rename include guard.
10047         * common/gdb_unlinker.h: Rename include guard.
10048         * common/gdb_unique_ptr.h: Rename include guard.
10049         * common/gdb_tilde_expand.h: Rename include guard.
10050         * common/gdb_sys_time.h: Rename include guard.
10051         * common/gdb_string_view.h: Rename include guard.
10052         * common/gdb_splay_tree.h: Rename include guard.
10053         * common/gdb_setjmp.h: Rename include guard.
10054         * common/gdb_ref_ptr.h: Rename include guard.
10055         * common/gdb_optional.h: Rename include guard.
10056         * common/gdb_locale.h: Rename include guard.
10057         * common/gdb_assert.h: Rename include guard.
10058         * common/filtered-iterator.h: Rename include guard.
10059         * common/filestuff.h: Rename include guard.
10060         * common/fileio.h: Rename include guard.
10061         * common/environ.h: Rename include guard.
10062         * common/common-utils.h: Rename include guard.
10063         * common/common-types.h: Rename include guard.
10064         * common/common-regcache.h: Rename include guard.
10065         * common/common-inferior.h: Rename include guard.
10066         * common/common-gdbthread.h: Rename include guard.
10067         * common/common-exceptions.h: Rename include guard.
10068         * common/common-defs.h: Rename include guard.
10069         * common/common-debug.h: Rename include guard.
10070         * common/cleanups.h: Rename include guard.
10071         * common/buffer.h: Rename include guard.
10072         * common/btrace-common.h: Rename include guard.
10073         * common/break-common.h: Rename include guard.
10074         * cli/cli-utils.h: Rename include guard.
10075         * cli/cli-style.h: Rename include guard.
10076         * cli/cli-setshow.h: Rename include guard.
10077         * cli/cli-script.h: Rename include guard.
10078         * cli/cli-interp.h: Rename include guard.
10079         * cli/cli-decode.h: Rename include guard.
10080         * cli/cli-cmds.h: Rename include guard.
10081         * charset-list.h: Add include guard.
10082         * buildsym-legacy.h: Rename include guard.
10083         * bfin-tdep.h: Add include guard.
10084         * ax.h: Rename include guard.
10085         * arm-linux-tdep.h: Add include guard.
10086         * arm-fbsd-tdep.h: Add include guard.
10087         * arch/xtensa.h: Rename include guard.
10088         * arch/tic6x.h: Add include guard.
10089         * arch/i386.h: Add include guard.
10090         * arch/arm.h: Rename include guard.
10091         * arch/arm-linux.h: Rename include guard.
10092         * arch/arm-get-next-pcs.h: Rename include guard.
10093         * arch/amd64.h: Add include guard.
10094         * arch/aarch64-insn.h: Rename include guard.
10095         * arch-utils.h: Rename include guard.
10096         * annotate.h: Add include guard.
10097         * amd64-darwin-tdep.h: Rename include guard.
10098         * aarch64-linux-tdep.h: Add include guard.
10099         * aarch64-fbsd-tdep.h: Add include guard.
10100         * aarch32-linux-nat.h: Add include guard.
10101
10102 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10103
10104         * macrotab.c (macro_define_internal): New function that
10105         factorizes macro_define_object_internal and macro_define_function
10106         code.
10107         (macro_define_object_internal): Use macro_define_internal.
10108         (macro_define_function): Likewise.
10109
10110 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10111
10112         * macrocmd.c (extract_identifier): Return
10113         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10114         callers.
10115
10116 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10117
10118         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10119
10120 2019-02-05  Tom Tromey  <tom@tromey.com>
10121
10122         * target.c (target_stack::unpush): Move assertion earlier.
10123
10124 2019-01-30  Tom Tromey  <tom@tromey.com>
10125
10126         PR python/23615:
10127         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10128         (gdbpy_parse_and_eval): Likewise.
10129         * python/python-internal.h (gdbpy_allow_threads): New class.
10130
10131 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10132
10133         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10134         (aarch64_fbsd_fpregmap): Move earlier.
10135         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10136         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10137         instead of individual calls to trad_frame_set_reg_addr.
10138         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10139         earlier.
10140         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10141         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10142         instead of individual calls to trad_frame_set_reg_addr.
10143
10144 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10145
10146         * CONTRIBUTE: Replace contribution list with wiki link.
10147
10148 2019-01-25  Tom Tromey  <tom@tromey.com>
10149
10150         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10151
10152 2019-01-25  Tom Tromey  <tom@tromey.com>
10153
10154         * xtensa-linux-nat.c: Fix common/ includes.
10155         * xml-support.h: Fix common/ includes.
10156         * xml-support.c: Fix common/ includes.
10157         * x86-linux-nat.c: Fix common/ includes.
10158         * windows-nat.c: Fix common/ includes.
10159         * varobj.h: Fix common/ includes.
10160         * varobj.c: Fix common/ includes.
10161         * value.c: Fix common/ includes.
10162         * valops.c: Fix common/ includes.
10163         * utils.c: Fix common/ includes.
10164         * unittests/xml-utils-selftests.c: Fix common/ includes.
10165         * unittests/utils-selftests.c: Fix common/ includes.
10166         * unittests/unpack-selftests.c: Fix common/ includes.
10167         * unittests/tracepoint-selftests.c: Fix common/ includes.
10168         * unittests/style-selftests.c: Fix common/ includes.
10169         * unittests/string_view-selftests.c: Fix common/ includes.
10170         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10171         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10172         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10173         * unittests/rsp-low-selftests.c: Fix common/ includes.
10174         * unittests/parse-connection-spec-selftests.c: Fix common/
10175         includes.
10176         * unittests/optional-selftests.c: Fix common/ includes.
10177         * unittests/offset-type-selftests.c: Fix common/ includes.
10178         * unittests/observable-selftests.c: Fix common/ includes.
10179         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10180         * unittests/memrange-selftests.c: Fix common/ includes.
10181         * unittests/memory-map-selftests.c: Fix common/ includes.
10182         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10183         * unittests/function-view-selftests.c: Fix common/ includes.
10184         * unittests/environ-selftests.c: Fix common/ includes.
10185         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10186         * unittests/common-utils-selftests.c: Fix common/ includes.
10187         * unittests/cli-utils-selftests.c: Fix common/ includes.
10188         * unittests/array-view-selftests.c: Fix common/ includes.
10189         * ui-file.c: Fix common/ includes.
10190         * tui/tui-io.c: Fix common/ includes.
10191         * tracepoint.h: Fix common/ includes.
10192         * tracepoint.c: Fix common/ includes.
10193         * tracefile-tfile.c: Fix common/ includes.
10194         * top.h: Fix common/ includes.
10195         * top.c: Fix common/ includes.
10196         * thread.c: Fix common/ includes.
10197         * target/waitstatus.h: Fix common/ includes.
10198         * target/waitstatus.c: Fix common/ includes.
10199         * target.h: Fix common/ includes.
10200         * target.c: Fix common/ includes.
10201         * target-memory.c: Fix common/ includes.
10202         * target-descriptions.c: Fix common/ includes.
10203         * symtab.h: Fix common/ includes.
10204         * symfile.c: Fix common/ includes.
10205         * stap-probe.c: Fix common/ includes.
10206         * spu-linux-nat.c: Fix common/ includes.
10207         * sparc-nat.c: Fix common/ includes.
10208         * source.c: Fix common/ includes.
10209         * solib.c: Fix common/ includes.
10210         * solib-target.c: Fix common/ includes.
10211         * ser-unix.c: Fix common/ includes.
10212         * ser-tcp.c: Fix common/ includes.
10213         * ser-pipe.c: Fix common/ includes.
10214         * ser-base.c: Fix common/ includes.
10215         * selftest-arch.c: Fix common/ includes.
10216         * s12z-tdep.c: Fix common/ includes.
10217         * rust-exp.y: Fix common/ includes.
10218         * rs6000-aix-tdep.c: Fix common/ includes.
10219         * riscv-tdep.c: Fix common/ includes.
10220         * remote.c: Fix common/ includes.
10221         * remote-notif.h: Fix common/ includes.
10222         * remote-fileio.h: Fix common/ includes.
10223         * remote-fileio.c: Fix common/ includes.
10224         * regcache.h: Fix common/ includes.
10225         * regcache.c: Fix common/ includes.
10226         * record-btrace.c: Fix common/ includes.
10227         * python/python.c: Fix common/ includes.
10228         * python/py-type.c: Fix common/ includes.
10229         * python/py-inferior.c: Fix common/ includes.
10230         * progspace.h: Fix common/ includes.
10231         * producer.c: Fix common/ includes.
10232         * procfs.c: Fix common/ includes.
10233         * proc-api.c: Fix common/ includes.
10234         * printcmd.c: Fix common/ includes.
10235         * ppc-linux-nat.c: Fix common/ includes.
10236         * parser-defs.h: Fix common/ includes.
10237         * osdata.c: Fix common/ includes.
10238         * obsd-nat.c: Fix common/ includes.
10239         * nat/x86-linux.c: Fix common/ includes.
10240         * nat/x86-linux-dregs.c: Fix common/ includes.
10241         * nat/x86-dregs.h: Fix common/ includes.
10242         * nat/x86-dregs.c: Fix common/ includes.
10243         * nat/ppc-linux.c: Fix common/ includes.
10244         * nat/mips-linux-watch.h: Fix common/ includes.
10245         * nat/mips-linux-watch.c: Fix common/ includes.
10246         * nat/linux-waitpid.c: Fix common/ includes.
10247         * nat/linux-ptrace.h: Fix common/ includes.
10248         * nat/linux-ptrace.c: Fix common/ includes.
10249         * nat/linux-procfs.c: Fix common/ includes.
10250         * nat/linux-personality.c: Fix common/ includes.
10251         * nat/linux-osdata.c: Fix common/ includes.
10252         * nat/linux-namespaces.c: Fix common/ includes.
10253         * nat/linux-btrace.h: Fix common/ includes.
10254         * nat/linux-btrace.c: Fix common/ includes.
10255         * nat/fork-inferior.c: Fix common/ includes.
10256         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10257         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10258         * nat/aarch64-linux.c: Fix common/ includes.
10259         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10260         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10261         * namespace.h: Fix common/ includes.
10262         * mips-linux-tdep.c: Fix common/ includes.
10263         * minsyms.c: Fix common/ includes.
10264         * mi/mi-parse.h: Fix common/ includes.
10265         * mi/mi-main.c: Fix common/ includes.
10266         * mi/mi-cmd-env.c: Fix common/ includes.
10267         * memrange.h: Fix common/ includes.
10268         * memattr.c: Fix common/ includes.
10269         * maint.h: Fix common/ includes.
10270         * maint.c: Fix common/ includes.
10271         * main.c: Fix common/ includes.
10272         * machoread.c: Fix common/ includes.
10273         * location.c: Fix common/ includes.
10274         * linux-thread-db.c: Fix common/ includes.
10275         * linux-nat.c: Fix common/ includes.
10276         * linux-fork.c: Fix common/ includes.
10277         * inline-frame.c: Fix common/ includes.
10278         * infrun.c: Fix common/ includes.
10279         * inflow.c: Fix common/ includes.
10280         * inferior.h: Fix common/ includes.
10281         * inferior.c: Fix common/ includes.
10282         * infcmd.c: Fix common/ includes.
10283         * inf-ptrace.c: Fix common/ includes.
10284         * inf-child.c: Fix common/ includes.
10285         * ia64-linux-nat.c: Fix common/ includes.
10286         * i387-tdep.c: Fix common/ includes.
10287         * i386-tdep.c: Fix common/ includes.
10288         * i386-linux-tdep.c: Fix common/ includes.
10289         * i386-linux-nat.c: Fix common/ includes.
10290         * i386-go32-tdep.c: Fix common/ includes.
10291         * i386-fbsd-tdep.c: Fix common/ includes.
10292         * i386-fbsd-nat.c: Fix common/ includes.
10293         * guile/scm-type.c: Fix common/ includes.
10294         * guile/guile.c: Fix common/ includes.
10295         * go32-nat.c: Fix common/ includes.
10296         * gnu-nat.c: Fix common/ includes.
10297         * gdbthread.h: Fix common/ includes.
10298         * gdbarch-selftests.c: Fix common/ includes.
10299         * gdb_usleep.c: Fix common/ includes.
10300         * gdb_select.h: Fix common/ includes.
10301         * gdb_bfd.c: Fix common/ includes.
10302         * gcore.c: Fix common/ includes.
10303         * fork-child.c: Fix common/ includes.
10304         * findvar.c: Fix common/ includes.
10305         * fbsd-nat.c: Fix common/ includes.
10306         * event-top.c: Fix common/ includes.
10307         * event-loop.c: Fix common/ includes.
10308         * dwarf2read.c: Fix common/ includes.
10309         * dwarf2loc.c: Fix common/ includes.
10310         * dwarf2-frame.c: Fix common/ includes.
10311         * dwarf-index-cache.c: Fix common/ includes.
10312         * dtrace-probe.c: Fix common/ includes.
10313         * disasm-selftests.c: Fix common/ includes.
10314         * defs.h: Fix common/ includes.
10315         * csky-tdep.c: Fix common/ includes.
10316         * cp-valprint.c: Fix common/ includes.
10317         * cp-support.h: Fix common/ includes.
10318         * cp-support.c: Fix common/ includes.
10319         * corelow.c: Fix common/ includes.
10320         * completer.h: Fix common/ includes.
10321         * completer.c: Fix common/ includes.
10322         * compile/compile.c: Fix common/ includes.
10323         * compile/compile-loc2c.c: Fix common/ includes.
10324         * compile/compile-cplus-types.c: Fix common/ includes.
10325         * compile/compile-cplus-symbols.c: Fix common/ includes.
10326         * command.h: Fix common/ includes.
10327         * cli/cli-dump.c: Fix common/ includes.
10328         * cli/cli-cmds.c: Fix common/ includes.
10329         * charset.c: Fix common/ includes.
10330         * build-id.c: Fix common/ includes.
10331         * btrace.h: Fix common/ includes.
10332         * btrace.c: Fix common/ includes.
10333         * breakpoint.h: Fix common/ includes.
10334         * breakpoint.c: Fix common/ includes.
10335         * ax.h:
10336         (enum agent_op): Fix common/ includes.
10337         * ax-general.c (struct aop_map): Fix common/ includes.
10338         * ax-gdb.c: Fix common/ includes.
10339         * auxv.c: Fix common/ includes.
10340         * auto-load.c: Fix common/ includes.
10341         * arm-tdep.c: Fix common/ includes.
10342         * arch/riscv.c: Fix common/ includes.
10343         * arch/ppc-linux-common.c: Fix common/ includes.
10344         * arch/i386.c: Fix common/ includes.
10345         * arch/arm.c: Fix common/ includes.
10346         * arch/arm-linux.c: Fix common/ includes.
10347         * arch/arm-get-next-pcs.c: Fix common/ includes.
10348         * arch/amd64.c: Fix common/ includes.
10349         * arch/aarch64.c: Fix common/ includes.
10350         * arch/aarch64-insn.c: Fix common/ includes.
10351         * arch-utils.c: Fix common/ includes.
10352         * amd64-windows-tdep.c: Fix common/ includes.
10353         * amd64-tdep.c: Fix common/ includes.
10354         * amd64-sol2-tdep.c: Fix common/ includes.
10355         * amd64-obsd-tdep.c: Fix common/ includes.
10356         * amd64-nbsd-tdep.c: Fix common/ includes.
10357         * amd64-linux-tdep.c: Fix common/ includes.
10358         * amd64-linux-nat.c: Fix common/ includes.
10359         * amd64-fbsd-tdep.c: Fix common/ includes.
10360         * amd64-fbsd-nat.c: Fix common/ includes.
10361         * amd64-dicos-tdep.c: Fix common/ includes.
10362         * amd64-darwin-tdep.c: Fix common/ includes.
10363         * agent.c: Fix common/ includes.
10364         * ada-lang.h: Fix common/ includes.
10365         * ada-lang.c: Fix common/ includes.
10366         * aarch64-tdep.c: Fix common/ includes.
10367
10368 2019-01-25  Tom Tromey  <tom@tromey.com>
10369
10370         * common/create-version.sh: Use common/version.h.
10371
10372 2019-01-24  Pedro Alves  <palves@redhat.com>
10373
10374         * infrun.c (signal_stop, signal_print, signal_program)
10375         (signal_catch, signal_pass): Now arrays instead of pointers.
10376         (update_signals_program_target, do_target_resume)
10377         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10378         * linux-nat.c (linux_nat_target::pass_signals)
10379         (linux_nat_target::create_inferior, linux_nat_target::attach):
10380         Adjust.
10381         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10382         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10383         * procfs.c (procfs_target::pass_signals): Adjust.
10384         * record-full.c (record_full_target::resume): Adjust.
10385         * remote.c (remote_target::pass_signals)
10386         (remote_target::program_signals): Adjust.
10387         * target-debug.h (target_debug_print_signals): Now takes a
10388         gdb::array_view as parameter.  Adjust.
10389         * target.h (target_ops) <pass_signals, program_signals>: Replace
10390         pointer and length parameters with gdb::array_view.
10391         (target_pass_signals, target_program_signals): Likewise.
10392         * target-delegates.c: Regenerate.
10393
10394 2019-01-24  Pedro Alves  <palves@redhat.com>
10395
10396         * common/forward-scope-exit.h
10397         (forward_scope_exit::forward_scope_exit): Pass arguments to
10398         m_bind_function directly, instead of creating a std::bind and
10399         copying that.
10400
10401 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10402
10403         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10404         for static members.
10405         (pass_in_v_vfp_candidate): Likewise.
10406
10407 2019-01-23  Tom Tromey  <tom@tromey.com>
10408             Pedro Alves  <palves@redhat.com>
10409
10410         * regcache.c (class regcache_invalidator): Remove.
10411         (regcache::raw_write): Use make_scope_exit.
10412
10413 2019-01-23  Tom Tromey  <tom@tromey.com>
10414
10415         * ui-out.h (class ui_out_emit_type): Update comment.
10416
10417 2019-01-23  Tom Tromey  <tom@tromey.com>
10418
10419         * infrun.c (fetch_inferior_event): Update comment.
10420
10421 2019-01-23  Tom Tromey  <tom@tromey.com>
10422             Pedro Alves  <palves@redhat.com>
10423
10424         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10425         parameter.
10426         (fetch_inferior_event): Use SCOPE_EXIT.
10427
10428
10429 2019-01-23  Tom Tromey  <tom@tromey.com>
10430             Pedro Alves  <palves@redhat.com>
10431
10432         * infrun.c (disable_thread_events): Delete.
10433         (stop_all_threads): Use SCOPE_EXIT.
10434
10435 2019-01-23  Tom Tromey  <tom@tromey.com>
10436             Pedro Alves  <palves@redhat.com>
10437
10438         * symfile.c: Include forward-scope-exit.h.
10439         (clear_symtab_users_cleanup): Replace forward declaration with
10440         a FORWARD_SCOPE_EXIT.
10441         (syms_from_objfile_1): Use the forward_scope_exit and
10442         gdb::optional instead of cleanup_function.
10443         (reread_symbols): Use the forward_scope_exit instead of
10444         cleanup_function.
10445         (clear_symtab_users_cleanup): Remove function.
10446
10447 2019-01-23  Tom Tromey  <tom@tromey.com>
10448             Pedro Alves  <palves@redhat.com>
10449
10450         * linux-nat.c: Include scope-exit.h.
10451         (cleanup_target_stop): Remove.
10452         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10453         SCOPE_EXIT.
10454
10455 2019-01-23  Tom Tromey  <tom@tromey.com>
10456             Pedro Alves  <palves@redhat.com>
10457
10458         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10459         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10460
10461 2019-01-23  Tom Tromey  <tom@tromey.com>
10462             Andrew Burgess  <andrew.burgess@embecosm.com>
10463             Pedro Alves  <palves@redhat.com>
10464
10465         * infrun.c (fetch_inferior_event): Use scope_exit.
10466         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10467         * top.c (execute_command): Use scope_exit.
10468         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10469         * utils.c (do_bpstat_clear_actions_cleanup)
10470         (make_bpstat_clear_actions_cleanup): Remove.
10471
10472 2019-01-23  Tom Tromey  <tom@tromey.com>
10473             Pedro Alves  <palves@redhat.com>
10474
10475         * infrun.c: Include "common/scope-exit.h"
10476         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10477         (wait_for_inferior): Use SCOPE_EXIT.
10478         (fetch_inferior_event): Use scope_exit.
10479
10480 2019-01-23  Tom Tromey  <tom@tromey.com>
10481             Pedro Alves  <palves@redhat.com>
10482
10483         * breakpoint.c (create_breakpoint): Remove cleanup.
10484
10485 2019-01-23  Tom Tromey  <tom@tromey.com>
10486             Andrew Burgess  <andrew.burgess@embecosm.com>
10487             Pedro Alves  <palves@redhat.com>
10488
10489 2019-01-23  Pedro Alves  <palves@redhat.com>
10490
10491         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10492
10493 2019-01-23  Pedro Alves  <palves@redhat.com>
10494             Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * gdbthread.h: Include "common/forward-scope-exit.h".
10497         (scoped_finish_thread_state): Redefine custom class in terms of
10498         forward_scope_exit.
10499
10500 2019-01-23  Pedro Alves  <palves@redhat.com>
10501             Andrew Burgess  <andrew.burgess@embecosm.com>
10502
10503         * common/forward-scope-exit.h: New file.
10504
10505 2019-01-23  Pedro Alves  <palves@redhat.com>
10506             Andrew Burgess  <andrew.burgess@embecosm.com>
10507             Tom Tromey  <tom@tromey.com>
10508
10509         * common/scope-exit.h: New file.
10510
10511 2019-01-23  Pedro Alves  <palves@redhat.com>
10512
10513         * common/preprocessor.h (ESC): Rename to ...
10514         (ESC_PARENS): ... this.
10515         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10516         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10517
10518 2019-01-23  Tom Tromey  <tom@tromey.com>
10519
10520         * language.h (class scoped_switch_to_sym_language_if_auto):
10521         Initialize m_lang in both cases.
10522
10523 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10524
10525         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10526         with XCNEW.
10527
10528 2019-01-22  Tom Tromey  <tom@tromey.com>
10529
10530         * corelow.c: Do not include sys/file.h.
10531
10532 2019-01-22  Tom Tromey  <tom@tromey.com>
10533
10534         * tui/tui-wingeneral.h: Include gdb_curses.h.
10535
10536 2019-01-22  Tom Tromey  <tom@tromey.com>
10537
10538         * source-cache.h (class source_cache) <get_source_lines,
10539         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10540
10541 2019-01-22  Tom Tromey  <tom@tromey.com>
10542
10543         * remote-fileio.h (struct remote_target): Declare.
10544
10545 2019-01-22  Tom Tromey  <tom@tromey.com>
10546
10547         * python/py-arch.c: Do not include py-ref.h.
10548         * python/py-bpevent.c: Do not include py-ref.h.
10549         * python/py-cmd.c: Do not include py-ref.h.
10550         * python/py-continueevent.c: Do not include py-ref.h.
10551         * python/py-event.h: Do not include py-ref.h.
10552         * python/py-evtregistry.c: Do not include py-ref.h.
10553         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10554         * python/py-frame.c: Do not include py-ref.h.
10555         * python/py-framefilter.c: Do not include py-ref.h.
10556         * python/py-function.c: Do not include py-ref.h.
10557         * python/py-infevents.c: Do not include py-ref.h.
10558         * python/py-linetable.c: Do not include py-ref.h.
10559         * python/py-objfile.c: Do not include py-ref.h.
10560         * python/py-param.c: Do not include py-ref.h.
10561         * python/py-prettyprint.c: Do not include py-ref.h.
10562         * python/py-progspace.c: Do not include py-ref.h.
10563         * python/py-symbol.c: Do not include py-ref.h.
10564         * python/py-symtab.c: Do not include py-ref.h.
10565         * python/py-type.c: Do not include py-ref.h.
10566         * python/py-unwind.c: Do not include py-ref.h.
10567         * python/py-utils.c: Do not include py-ref.h.
10568         * python/py-value.c: Do not include py-ref.h.
10569         * python/py-varobj.c: Do not include py-ref.h.
10570         * python/py-xmethods.c: Do not include py-ref.h.
10571         * python/python.c: Do not include py-ref.h.
10572         * varobj.c: Do not include py-ref.h.
10573
10574 2019-01-22  Tom Tromey  <tom@tromey.com>
10575
10576         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10577         keyword for bcache.
10578
10579 2019-01-22  Tom Tromey  <tom@tromey.com>
10580
10581         * compile/compile-cplus-types.c: Remove a comment by #include.
10582
10583 2019-01-22  Tom Tromey  <tom@tromey.com>
10584
10585         * compile/gcc-c-plugin.h: Include compile-internal.h.
10586
10587 2019-01-22  Tom Tromey  <tom@tromey.com>
10588
10589         * stabsread.c (EXTERN): Do not define.
10590         (symnum, next_symbol_text_func, processing_gcc_compilation)
10591         (within_function, global_sym_chain, global_stabs)
10592         (previous_stab_code, this_object_header_files)
10593         (n_this_object_header_files)
10594         (n_allocated_this_object_header_files): Define.
10595         * stabsread.h (EXTERN): Never define.  Use "extern".
10596
10597 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10598
10599         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10600         history_value.
10601
10602 2019-01-21  Tom Tromey  <tom@tromey.com>
10603
10604         * ui-out.c: Fix includes.
10605         * tui/tui-source.c: Fix includes.
10606         * target.c: Fix includes.
10607         * remote.c: Fix includes.
10608         * regcache.c: Fix includes.
10609         * python/py-block.c: Fix includes.
10610         * printcmd.c: Fix includes.
10611         * or1k-tdep.c: Fix includes.
10612         * mi/mi-main.c: Fix includes.
10613         * m32r-tdep.c: Fix includes.
10614         * csky-tdep.c: Fix includes.
10615         * compile/compile-cplus-types.c: Fix includes.
10616         * cli/cli-interp.c: Fix includes.
10617
10618 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10619
10620         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10621         for padding.
10622
10623 2019-01-16  Tom Tromey  <tom@tromey.com>
10624
10625         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10626         earlier.
10627         (struct objfile) <msymbols_range>: Move from top level.
10628         <msymbols>: New method.
10629         (class objfile_msymbols): Remove.
10630         * symtab.c (default_collect_symbol_completion_matches_break_on):
10631         Update.
10632         * symmisc.c (dump_msymbols): Update.
10633         * stabsread.c (scan_file_globals): Update.
10634         * objc-lang.c (info_selectors_command, info_classes_command)
10635         (find_methods): Update.
10636         * minsyms.c (find_solib_trampoline_target): Update.
10637         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10638         * coffread.c (coff_symfile_read): Update.
10639         * ada-lang.c (ada_lookup_simple_minsym)
10640         (ada_collect_symbol_completion_matches): Update.
10641
10642 2019-01-16  Tom Tromey  <tom@tromey.com>
10643
10644         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10645         type.  Remove no-argument constructor.
10646         <iterator::operator++>: Simplify.
10647         <begin>: Update.
10648         <end>: Use minimal_symbol_count.
10649
10650 2019-01-16  Tom Tromey  <tom@tromey.com>
10651
10652         * objfiles.h (struct objfile) <psymtabs>: New method.
10653         (class objfile_psymtabs): Remove.
10654         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10655         typedef.
10656         <range>: New method.
10657         (require_partial_symbols): Change return type.
10658         * psymtab.c (require_partial_symbols)
10659         (psym_expand_symtabs_matching): Update.
10660         * mdebugread.c (parse_partial_symbols): Update.
10661         * dbxread.c (dbx_end_psymtab): Update.
10662
10663 2019-01-15  Tom Tromey  <tom@tromey.com>
10664
10665         * symtab.c (lookup_objfile_from_block)
10666         (lookup_symbol_in_objfile_symtabs)
10667         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10668         (find_line_symtab, info_sources_command)
10669         (default_collect_symbol_completion_matches_break_on)
10670         (make_source_files_completion_list): Update.
10671         * symmisc.c (print_objfile_statistics, dump_objfile)
10672         (maintenance_print_symbols, maintenance_info_symtabs)
10673         (maintenance_check_symtabs, maintenance_info_line_tables):
10674         Update.
10675         * source.c (select_source_symtab)
10676         (forget_cached_source_info_for_objfile): Update.
10677         * objfiles.h (class objfile_compunits): Remove.
10678         (struct objfile) <compunits_range>: New typedef.
10679         (compunits): New method.
10680         * objfiles.c (objfile_relocate1): Update.
10681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10682         * maint.c (count_symtabs_and_blocks): Update.
10683         * linespec.c (iterate_over_all_matching_symtabs): Update.
10684         * cp-support.c (add_symbol_overload_list_qualified): Update.
10685         * coffread.c (coff_symtab_read): Update.
10686         * ada-lang.c (add_nonlocal_symbols)
10687         (ada_collect_symbol_completion_matches)
10688         (ada_add_global_exceptions): Update.
10689
10690 2019-01-15  Tom Tromey  <tom@tromey.com>
10691
10692         * progspace.h (program_space) <objfiles_safe_range>: New
10693         typedef.
10694         <objfiles_safe>: New method.
10695         * objfiles.h (class all_objfiles_safe): Remove.
10696         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10697         * jit.c (jit_inferior_exit_hook): Update.
10698
10699 2019-01-17  Tom Tromey  <tom@tromey.com>
10700
10701         * progspace.h (program_space) <objfiles_range>: New typedef.
10702         <objfiles>: New method.
10703         <objfiles_head>: Rename from objfiles.
10704         (object_files): Update.
10705         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10706         * guile/scm-pretty-print.c
10707         (ppscm_find_pretty_printer_from_objfiles): Update.
10708         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10709         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10710         Update.
10711         * python/py-progspace.c (pspy_get_objfiles): Update.
10712         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10713         Update.
10714         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10715         (objfpy_lookup_objfile_by_build_id): Update.
10716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10717         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10718         Update.
10719         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10720         (expand_symtab_containing_pc, lookup_objfile_from_block)
10721         (lookup_static_symbol, basic_lookup_transparent_type)
10722         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10723         (find_line_symtab, info_sources_command)
10724         (default_collect_symbol_completion_matches_break_on)
10725         (make_source_files_completion_list, find_main_name): Update.
10726         * symmisc.c (print_symbol_bcache_statistics)
10727         (print_objfile_statistics, maintenance_print_symbols)
10728         (maintenance_print_msymbols, maintenance_print_objfiles)
10729         (maintenance_info_symtabs, maintenance_check_symtabs)
10730         (maintenance_expand_symtabs, maintenance_info_line_tables):
10731         Update.
10732         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10733         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10734         (map_overlay_command, unmap_overlay_command)
10735         (simple_overlay_update, expand_symtabs_matching)
10736         (map_symbol_filenames): Update.
10737         * symfile-debug.c (set_debug_symfile): Update.
10738         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10739         Update.
10740         * source.c (select_source_symtab, forget_cached_source_info):
10741         Update.
10742         * solib.c (solib_read_symbols): Update.
10743         * solib-spu.c (append_ocl_sos): Update.
10744         * psymtab.c (maintenance_print_psymbols)
10745         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10746         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10747         * printcmd.c (info_symbol_command): Update.
10748         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10749         Update.
10750         * objfiles.h (class all_objfiles): Remove.
10751         * objfiles.c (have_partial_symbols, have_full_symbols)
10752         (have_minimal_symbols, qsort_cmp, update_section_map)
10753         (shared_objfile_contains_address_p)
10754         (default_iterate_over_objfiles_in_search_order): Update.
10755         * objc-lang.c (info_selectors_command, info_classes_command)
10756         (find_methods): Update.
10757         * minsyms.c (find_solib_trampoline_target): Update.
10758         * maint.c (maintenance_info_sections)
10759         (maintenance_translate_address, count_symtabs_and_blocks):
10760         Update.
10761         * main.c (captured_main_1): Update.
10762         * linux-thread-db.c (try_thread_db_load_from_pdir)
10763         (has_libpthread): Update.
10764         * linespec.c (iterate_over_all_matching_symtabs)
10765         (search_minsyms_for_name): Update.
10766         * jit.c (jit_find_objf_with_entry_addr): Update.
10767         * hppa-tdep.c (find_unwind_entry)
10768         (hppa_lookup_stub_minimal_symbol): Update.
10769         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10770         Update.
10771         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10772         (elf_gnu_ifunc_resolve_by_got): Update.
10773         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10774         * dwarf-index-write.c (save_gdb_index_command): Update.
10775         * cp-support.c (add_symbol_overload_list_qualified): Update.
10776         * breakpoint.c (create_overlay_event_breakpoint)
10777         (create_longjmp_master_breakpoint)
10778         (create_std_terminate_master_breakpoint)
10779         (create_exception_master_breakpoint): Update.
10780         * blockframe.c (find_pc_partial_function): Update.
10781         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10782         (ada_collect_symbol_completion_matches)
10783         (ada_add_global_exceptions): Update.
10784
10785 2019-01-17  Tom Tromey  <tom@tromey.com>
10786
10787         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10788         declare VEC.
10789         (solib_target_parse_libraries): Change return type.
10790         (library_list_start_segment, library_list_start_section)
10791         (library_list_end_library, library_list_start_library); Update.
10792         (solib_target_free_library_list): Remove.
10793         (solib_target_parse_libraries): Remove cleanup.  Change return
10794         type.
10795         (solib_target_current_sos): Update.
10796
10797 2019-01-17  Tom Tromey  <tromey@bapiya>
10798
10799         * valprint.c: Replace "the the" with "the".
10800         * symtab.c: Replace "the the" with "the".
10801         * solib.c: Replace "the the" with "the".
10802         * solib-dsbt.c: Replace "the the" with "the".
10803         * linespec.c: Replace "the the" with "the".
10804         * dwarf2loc.h: Replace "the the" with "the".
10805         * amd64-windows-tdep.c: Replace "the the" with "the".
10806         * aarch64-tdep.c: Replace "the the" with "the".
10807
10808 2019-01-16  Keith Seitz  <keiths@redhat.com>
10809
10810         PR gdb/23773
10811         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10812         <builder>: Rename to ..
10813         <m_builder>: ... this and make private.
10814         (dwarf2_cu::get_builder): New method.  Change all users of
10815         `builder' to use this method.
10816         (dwarf2_start_symtab): Move to ...
10817         (dwarf2_cu::start_symtab): ... here.  Update all callers
10818         (setup_type_unit_groups): Move to ...
10819         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10820         callers.
10821         (dwarf2_cu::reset_builder): New method.
10822         (process_full_compunit, process_full_type_unit): Use
10823         dwarf2_cu::reset_builder.
10824         (follow_die_offset): Record the ancestor CU if it is different
10825         from the followed DIE's CU.
10826         (follow_die_sig_1): Likewise.
10827
10828 2019-01-15  Tom Tromey  <tom@tromey.com>
10829
10830         * remote.c (class remote_state) <buf>: Now a char_vector.
10831         <buf_size>: Remove.
10832         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10833         parameter.
10834         (remote_target::getpkt_or_notif_sane_1)
10835         (remote_target::getpkt_sane)
10836         (remote_target::getpkt_or_notif_sane): Likewise.
10837         (class remote_target) <putpkt>: New overload.
10838         (remote_target::read_frame): Change type of "buf_p".  Remove
10839         sizeof_p parameter.
10840         (packet_ok): New overload.
10841         (packet_check_result): New overload.
10842         Update all uses.
10843
10844 2019-01-14  Tom Tromey  <tom@tromey.com>
10845
10846         * remote-notif.c (handle_notification, remote_notif_ack)
10847         (remote_notif_parse): Make "buf" const.
10848         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10849         const.
10850         (remote_notif_parse, remote_notif_ack, handle_notification):
10851         Likewise.
10852         * remote.c (remote_notif_stop_parse): Make "buf" const.
10853         (remote_target::remote_parse_stop_reply): Make "buf" const.
10854         (remote_notif_stop_ack): Make "buf" const.
10855
10856 2019-01-14  Tom Tromey  <tom@tromey.com>
10857
10858         * remote.c (remote_console_output): Make parameter const.
10859
10860 2019-01-14  Tom Tromey  <tom@tromey.com>
10861
10862         * target-debug.h (target_debug_print_signals): Constify.
10863         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10864         * procfs.c (procfs_target::pass_signals): Update.
10865         * linux-nat.c (linux_nat_target::pass_signals): Update.
10866         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10867         * target-delegates.c: Rebuild.
10868         * remote.c (remote_target::program_signals): Update.
10869         (remote_target::pass_signals): Update.
10870         * target.c (target_pass_signals): Constify argument.
10871         (target_program_signals): Likewise.
10872         * target.h (struct target_ops) <pass_signals, program_signals>:
10873         Constify argument.
10874         (target_pass_signals, target_program_signals): Constify argument.
10875
10876 2019-01-14  Tom Tromey  <tom@tromey.com>
10877
10878         PR tui/28819:
10879         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10880
10881 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10882
10883         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10884         field.
10885         * rs6000-tdep.c: Include reggroups.h.
10886         (IS_V_ALIAS_PSEUDOREG): Define.
10887         (rs6000_register_name): Return names for the "vX" aliases.
10888         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10889         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10890         aliases.  Call default_register_reggroup_p for all other
10891         pseudo-registers.
10892         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10893         New functions.
10894         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10895         Handle "vX" aliases.
10896         (v_alias_pseudo_register_collect): New function.
10897         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10898         (rs6000_gdbarch_init): Initialize "vX" aliases as
10899         pseudo-registers.  Restore registration of
10900         rs6000_pseudo_register_reggroup_p with
10901         set_tdesc_pseudo_register_reggroup_p.
10902
10903 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10904
10905         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10906         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10907         set_gdbarch_num_pseudo_regs.
10908
10909 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10910
10911         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10912         Remove arg prefixname, add do_set and do_show.
10913         Add member functions set_list and show_list.
10914         * cli/cli-style.c (class cli_style_option): Update accordingly.
10915         (style_set_list): Move to file scope.
10916         (style_show_list): Likewise.
10917         (set_style): Call help_list.
10918         (show_style): Call cmd_show_list.
10919         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10920         Update to use the new macro.
10921
10922 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10923
10924         * ada-lang.c (_initialize_ada_language): Expand the help text
10925         for the "catch exception" command.
10926
10927 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10928
10929         * symtab.c (matching_obj_sections): Initialize obj,
10930         declare it closer to its usage.
10931
10932 2019-01-10  Tom Tromey  <tom@tromey.com>
10933
10934         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10935         (basic_inf_threads_range): Remove.
10936         (inf_threads_range, inf_non_exited_threads_range)
10937         (safe_inf_threads_range): Use next_adapter.
10938
10939 2019-01-10  Keith Seitz  <keiths@redhat.com>
10940
10941         PR gdb/23712
10942         PR symtab/23010
10943         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10944         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10945
10946 2019-01-10  Keith Seitz  <keiths@redhat.com>
10947
10948         PR gdb/23712
10949         PR symtab/23010
10950         * dictionary.c (pending_to_vector): Remove.
10951         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10952         Remove _1 suffix, replacing functions of the same name.  Update
10953         all callers.
10954         (dict_create_hashed, dict_create_hashed_expandable)
10955         (dict_create_linear, dict_create_linear_expandable, dict_free)
10956         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10957         Make functions static.
10958
10959 2019-01-10  Keith Seitz  <keiths@redhat.com>
10960
10961         PR gdb/23712
10962         PR symtab/23010
10963         * dictionary.h (struct dictionary): Replace declaration with
10964         multidictionary.
10965         (dict_create_hashed, dict_create_hashed_expandable)
10966         (dict_create_linear, dict_create_linear_expandable)
10967         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10968         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10969         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10970         taking multidictionary argument.
10971         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10972         * block.h (struct block) <dict>: Change to multidictionary
10973         and rename `multidict'.
10974         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10975         symmisc.c: Update all dictionary references to multidictionary.
10976
10977 2019-01-10  Keith Seitz  <keiths@redhat.com>
10978
10979         PR gdb/23712
10980         PR symtab/23010
10981         * dictionary.c: Include unordered_map.
10982         (pending_to_vector): New function.
10983         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10984         Rewrite the non-"_1" functions to take vector instead
10985         of linked list.
10986         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10987         "new" _1 versions of the same name.
10988         (multidictionary): Define.
10989         (std::hash<enum language): New definition.
10990         (collate_pending_symbols_by_language, mdict_create_hashed)
10991         (mdict_create_hashed_expandable, mdict_create_linear)
10992         (mdict_create_linear_expandable, mdict_free)
10993         (find_language_dictionary, create_new_language_dictionary)
10994         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10995         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10996         (mdict_size, mdict_empty): New functions.
10997         * dictionary.h (mdict_iterator): Define.
10998
10999 2019-01-10  Pedro Alves  <palves@redhat.com>
11000
11001         * breakpoint.c (read_uploaded_action)
11002         (create_tracepoint_from_upload): Adjust to use
11003         gdb::unique_xmalloc_ptr.
11004         * ctf.c (ctf_write_uploaded_tp):
11005         (SET_ARRAY_FIELD): Use emplace_back.
11006         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11007         * tracefile-tfile.c (tfile_write_uploaded_tp):
11008         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11009         gdb::unique_xmalloc_ptr.
11010         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11011         at_string, cond_string, cmd_strings>: Replace char pointers
11012         with gdb::unique_xmalloc_ptr.
11013
11014 2019-01-10  Pedro Alves  <palves@redhat.com>
11015
11016         * solib-target.c (library_list_start_library): Don't xstrdup name.
11017
11018 2019-01-10  Pedro Alves  <palves@redhat.com>
11019
11020         * mdebugread.c (parse_partial_symbols): Use
11021         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11022
11023 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11024
11025         * linux-fork.c (scoped_switch_fork_info)
11026         <~scoped_switch_fork_info>: Fix incorrect variable name.
11027
11028 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11029
11030         * linux-fork.c (scoped_switch_fork_info)
11031         <scoped_switch_fork_info>: Make explicit.
11032         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11033
11034 2019-01-10  Tom Tromey  <tom@tromey.com>
11035
11036         * objfiles.h (objfile::reset_psymtabs): Update.
11037         * objfiles.c (objfile::objfile): Update.
11038         * psymtab.h (psymtab_storage::obstack): Update.
11039         (psymtab_storage::m_obstack): Use gdb::optional.
11040         (class psymtab_storage): Update comment.  Remove objfile
11041         parameter.
11042         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11043
11044 2019-01-10  Tom Tromey  <tom@tromey.com>
11045
11046         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11047         <free_psymtabs>: Now private.
11048         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11049         (allocate_psymtab): Use new method.
11050
11051 2019-01-10  Tom Tromey  <tom@tromey.com>
11052
11053         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11054         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11055         * mdebugread.c (parse_partial_symbols): Use
11056         allocate_dependencies.
11057         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11058         allocate_dependencies.
11059         (process_psymtab_comp_unit_reader)
11060         (build_type_psymtab_dependencies): Likewise.
11061         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11062
11063 2019-01-10  Tom Tromey  <tom@tromey.com>
11064
11065         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11066         PSYMBOL_SET_LANGUAGE.
11067         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11068
11069 2019-01-10  Tom Tromey  <tom@tromey.com>
11070
11071         * psymtab.h (psymtab_storage::obstack): New method.
11072         <m_obstack>: Rename from obstack; now private.
11073         * psymtab.c (psymtab_storage): Update.
11074         * dwarf2read.c (create_addrmap_from_index)
11075         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11076         Update.
11077
11078 2019-01-10  Tom Tromey  <tom@tromey.com>
11079
11080         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11081         * objfiles.h (objfile::reset_psymtabs): New method.
11082
11083 2019-01-10  Tom Tromey  <tom@tromey.com>
11084
11085         * symmisc.c (print_symbol_bcache_statistics): Update.
11086         (print_objfile_statistics): Update.
11087         * symfile.c (reread_symbols): Update.
11088         * psymtab.h (class psymtab_storage): New.
11089         * psymtab.c (psymtab_storage): New constructor.
11090         (~psymtab_storage): New destructor.
11091         (require_partial_symbols): Update.
11092         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11093         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11094         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11095         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11096         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11097         (start_psymtab_common, end_psymtab_common)
11098         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11099         (allocate_psymtab): Update.
11100         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11101         Update.
11102         (dump_psymtab_addrmap, maintenance_print_psymbols)
11103         (maintenance_check_psymtabs): Update.
11104         (class objfile_psymtabs): Move to objfiles.h.
11105         * psympriv.h (discard_psymtab): Now inline.
11106         (psymtab_discarder::psymtab_discarder): Update.
11107         (psymtab_discarder::~psymtab_discarder): Update.
11108         (ALL_OBJFILE_PSYMTABS): Rewrite.
11109         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11110         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11111         Remove fields.
11112         <partial_symtabs>: New field.
11113         (class objfile_psymtabs): Move from psymtab.h.  Update.
11114         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11115         psymbol_cache.
11116         (objfile::~objfile): Don't destroy psymbol_cache.
11117         * mdebugread.c (parse_partial_symbols): Update.
11118         * dwarf2read.c (create_addrmap_from_index)
11119         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11120         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11121         (add_partial_subprogram, dwarf2_ranges_read): Update.
11122         * dwarf-index-write.c (write_address_map)
11123         (write_one_signatured_type, recursively_write_psymbols)
11124         (class debug_names, class debug_names, write_psymtabs_to_index):
11125         Update.
11126
11127 2019-01-10  Tom Tromey  <tom@tromey.com>
11128
11129         * symtab.h (SYMBOL_SET_NAMES): Update.
11130         (symbol_set_names): Update.
11131         (MSYMBOL_SET_NAMES): Update.
11132         * symtab.c (symbol_set_names): Change argument to be an
11133         objfile_per_bfd_storage.
11134         * psymtab.c (add_psymbol_to_bcache): Update.
11135         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11136
11137 2019-01-10  Tom Tromey  <tom@tromey.com>
11138
11139         * symtab.c (create_demangled_names_hash): Change argument to be an
11140         objfile_per_bfd_storage.
11141         (symbol_set_names): Update.
11142
11143 2019-01-10  Tom Tromey  <tom@tromey.com>
11144
11145         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11146         init_psymbol_list.
11147         * psymtab.c (init_psymbol_list): Do nothing if already called.
11148         * psympriv.h (init_psymbol_list): Add comment.
11149         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11150         init_psymbol_list.
11151         * dbxread.c (dbx_symfile_read): Unconditionally call
11152         init_psymbol_list.
11153
11154 2019-01-10  Tom Tromey  <tom@tromey.com>
11155
11156         * xcoffread.c (scan_xcoff_symtab): Update.
11157         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11158         "where".
11159         * mdebugread.c (parse_partial_symbols)
11160         (handle_psymbol_enumerators): Update.
11161         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11162         * dbxread.c (read_dbx_symtab): Update.
11163         * psympriv.h (psymbol_placement): New enum.
11164         (add_psymbol_to_list): Update.
11165
11166 2019-01-10  Tom Tromey  <tom@tromey.com>
11167
11168         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11169         static_psymbols parameters.
11170         (scan_xcoff_symtab): Update.
11171         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11172         static_psymbols parameters.
11173         * psympriv.h (start_psymtab_common): Update.
11174         * mdebugread.c (parse_partial_symbols): Update.
11175         * dwarf2read.c (create_partial_symtab): Update.
11176         * dbxread.c (read_dbx_symtab): Update.
11177         (start_psymtab): Remove global_psymbols and static_psymbols
11178         parameters.
11179
11180 2019-01-10  Tom Tromey  <tom@tromey.com>
11181
11182         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11183         * psymtab.c (allocate_psymtab): Add comment.
11184         * psympriv.h (allocate_psymtab): Add comment.
11185         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11186         initializations.
11187         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11188
11189 2019-01-10  Tom Tromey  <tom@tromey.com>
11190
11191         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11192         Don't declare.
11193         * mipsread.c: Include mdebugread.h.
11194         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11195         Declare.
11196         * elfread.c: Include mdebugread.h.
11197
11198 2019-01-09  Tom Tromey  <tom@tromey.com>
11199
11200         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11201         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11202         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11203         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11204         (psym_lookup_symbol, psym_find_last_source_symtab)
11205         (psym_forget_cached_source_info, psym_print_stats)
11206         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11207         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11208         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11209         (psym_find_compunit_symtab_by_address)
11210         (maintenance_print_psymbols, maintenance_info_psymtabs)
11211         (maintenance_check_psymtabs): Use ranged for.
11212         * psymtab.h (class objfile_psymtabs): New.
11213         (require_partial_symbols): Return objfile_psymtabs.
11214         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11215
11216 2019-01-09  Tom Tromey  <tom@tromey.com>
11217
11218         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11219         (find_pc_mapped_section, list_overlays_command)
11220         (map_overlay_command, unmap_overlay_command)
11221         (simple_overlay_update): Use all_objfiles.
11222         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11223         * printcmd.c (info_symbol_command): Use all_objfiles.
11224         * objfiles.h (ALL_OBJSECTIONS): Remove.
11225         * maint.c (maintenance_translate_address): Use all_objfiles.
11226         * gcore.c (gcore_create_callback): Use all_objfiles.
11227         (objfile_find_memory_regions): Likewise.
11228
11229 2019-01-09  Tom Tromey  <tom@tromey.com>
11230
11231         * symtab.c (find_line_symtab, info_sources_command)
11232         (make_source_files_completion_list): Use objfile_compunits.
11233         * source.c (select_source_symtab): Use objfile_compunits.
11234         * objfiles.h (struct objfile): Update comment.
11235         (ALL_OBJFILES): Remove.
11236         (ALL_FILETABS): Remove.
11237         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11238         objfile_compunits.
11239
11240 2019-01-09  Tom Tromey  <tom@tromey.com>
11241
11242         * symmisc.c (print_objfile_statistics, dump_objfile)
11243         (maintenance_print_symbols): Use compunit_filetabs.
11244         * source.c (forget_cached_source_info_for_objfile): Use
11245         compunit_filetabs.
11246         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11247         (ALL_FILETABS): Use compunit_filetabs.
11248         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11249         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11250
11251 2019-01-09  Tom Tromey  <tom@tromey.com>
11252
11253         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11254         (compunit_filetabs): New.
11255         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11256         compunit_filetabs.
11257         (info_sources_command, make_source_files_completion_list): Remove
11258         declaration.
11259         * symmisc.c (print_objfile_statistics, dump_objfile)
11260         (maintenance_print_symbols): Remove declaration.
11261         (maintenance_info_symtabs): Use compunit_filetabs.
11262         (maintenance_info_line_tables): Likewise.
11263         * source.c (select_source_symtab): Change local variable name.
11264         (forget_cached_source_info_for_objfile): Remove declaration.
11265         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11266         * objfiles.c (objfile_relocate1): Remove declaration.
11267         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11268         declaration.
11269         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11270         * coffread.c (coff_symtab_read): Remove declaration.
11271         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11272         compunit_filetabs.
11273
11274 2019-01-09  Tom Tromey  <tom@tromey.com>
11275
11276         * symtab.c (lookup_objfile_from_block)
11277         (find_pc_sect_compunit_symtab, search_symbols)
11278         (default_collect_symbol_completion_matches_break_on): Use
11279         objfile_compunits.
11280         * objfiles.h (ALL_COMPUNITS): Remove.
11281         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11282         * cp-support.c (add_symbol_overload_list_qualified): Use
11283         objfile_compunits.
11284         * ada-lang.c (ada_collect_symbol_completion_matches)
11285         (ada_add_global_exceptions): Use objfile_compunits.
11286
11287 2019-01-09  Tom Tromey  <tom@tromey.com>
11288
11289         * source.c (select_source_symtab)
11290         (forget_cached_source_info_for_objfile): Remove declaration.
11291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11292         declaration.
11293         * maint.c (count_symtabs_and_blocks): Remove declaration.
11294         * cp-support.c (add_symbol_overload_list_qualified): Remove
11295         declaration.
11296         * coffread.c (coff_symtab_read): Remove declaration.
11297         * symtab.c (lookup_symbol_in_objfile_symtabs)
11298         (basic_lookup_transparent_type_1): Use objfile_compunits.
11299         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11300         (info_sources_command, search_symbols)
11301         (default_collect_symbol_completion_matches_break_on)
11302         (make_source_files_completion_list): Remove declaration.
11303         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11304         (ada_collect_symbol_completion_matches)
11305         (ada_add_global_exceptions): Remove declaration.
11306         * linespec.c (iterate_over_all_matching_symtabs): Use
11307         objfile_compunits.
11308         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11309         (class objfile_compunits): New.
11310         (ALL_COMPUNITS): Use objfile_compunits.
11311         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11312         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11313         objfile_compunits.
11314         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11315
11316 2019-01-09  Tom Tromey  <tom@tromey.com>
11317
11318         * symtab.c (search_symbols)
11319         (default_collect_symbol_completion_matches_break_on): Use
11320         objfile_msymbols.
11321         * ada-lang.c (ada_lookup_simple_minsym)
11322         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11323         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11324         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11325         objfile_msymbols.
11326         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11327         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11328         * objc-lang.c (find_methods): Use objfile_msymbols.
11329         (info_selectors_command, info_classes_command): Likewise.
11330         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11331         * objfiles.h (class objfile_msymbols): New.
11332         (ALL_OBJFILE_MSYMBOLS): Remove.
11333         (ALL_MSYMBOLS): Remove.
11334
11335 2019-01-09  Tom Tromey  <tom@tromey.com>
11336
11337         * common/next-iterator.h (next_adapter): Add Iterator template
11338         parameter.
11339         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11340         (class all_objfiles_safe): New.
11341         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11342         * objfiles.c (put_objfile_before): Update comment.
11343         (add_separate_debug_objfile): Likewise.
11344         (free_all_objfiles): Use all_objfiles_safe.
11345         (objfile_purge_solibs): Likewise.
11346
11347 2019-01-09  Tom Tromey  <tom@tromey.com>
11348
11349         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11350         (expand_symtab_containing_pc, lookup_static_symbol)
11351         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11352         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11353         all_objfiles.
11354         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11355         * breakpoint.c (create_overlay_event_breakpoint)
11356         (create_longjmp_master_breakpoint)
11357         (create_std_terminate_master_breakpoint)
11358         (create_exception_master_breakpoint): Use all_objfiles.
11359         * linux-thread-db.c (try_thread_db_load_from_pdir)
11360         (has_libpthread): Use all_objfiles.
11361         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11362         * linespec.c (iterate_over_all_matching_symtabs)
11363         (search_minsyms_for_name): Use all_objfiles.
11364         * maint.c (maintenance_info_sections): Use all_objfiles.
11365         * main.c (captured_main_1): Use all_objfiles.
11366         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11367         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11368         * guile/scm-pretty-print.c
11369         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11370         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11371         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11372         (maintenance_print_msymbols): Use all_objfiles.
11373         * source.c (select_source_symtab): Use all_objfiles.
11374         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11375         * symfile.c (remove_symbol_file_command)
11376         (expand_symtabs_matching, map_symbol_filenames): Use
11377         all_objfiles.
11378         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11379         all_objfiles.
11380         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11381         * objc-lang.c (find_methods): Use all_objfiles.
11382         * objfiles.c (have_partial_symbols, have_full_symbols)
11383         (have_minimal_symbols, qsort_cmp)
11384         (default_iterate_over_objfiles_in_search_order): Use
11385         all_objfiles.
11386         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11387         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11388         (maintenance_check_psymtabs): Use all_objfiles.
11389         (ALL_PSYMTABS): Remove.
11390         * compile/compile-object-run.c (do_module_cleanup): Use
11391         all_objfiles.
11392         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11393         * cp-support.c (add_symbol_overload_list_qualified): Use
11394         all_objfiles.
11395         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11396         Use all_objfiles.
11397         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11398         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11399         all_objfiles.
11400         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11401         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11402         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11403         Uses all_objfiles.
11404         * solib.c (solib_read_symbols): Use all_objfiles
11405
11406 2019-01-09  Tom Tromey  <tom@tromey.com>
11407
11408         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11409         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11410         all_objfiles.
11411         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11412         * symmisc.c (print_symbol_bcache_statistics)
11413         (print_objfile_statistics, maintenance_print_objfiles)
11414         (maintenance_info_symtabs, maintenance_check_symtabs)
11415         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11416         all_objfiles.
11417         * source.c (forget_cached_source_info): Use all_objfiles.
11418         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11419         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11420         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11421         * objfiles.c (update_section_map): Use all_objfiles.
11422         (shared_objfile_contains_address_p): Likewise.
11423         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11424         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11425
11426 2019-01-09  Tom Tromey  <tom@tromey.com>
11427
11428         * common/next-iterator.h: New file.
11429         * objfiles.h (class all_objfiles): New.
11430         (struct objfile_iterator): New.
11431
11432 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11433
11434         * NEWS: Move the description of the changed "frame", "select-frame",
11435          and "info frame" commands to the Changed commands section.
11436
11437 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11438
11439         * gdbtypes.c (check_stub_method_group): Remove handling of old
11440         mangling schemes.
11441         * linespec.c (find_methods): Likewise.
11442         * stabsread.c (read_member_functions): Likewise.
11443         * valops.c (search_struct_method): Likewise.
11444         (value_struct_elt_for_reference): Likewise.
11445         * NEWS: Mention this change.
11446
11447 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11448
11449         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11450         print_source_lines.
11451         * source.c (print_source_lines_base): Update line number check.
11452         (print_source_lines): New function.
11453         (source_lines_range::source_lines_range): New function.
11454         * source.h (class source_lines_range): New class.
11455         (print_source_lines): New declaration.
11456
11457 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11458
11459         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11460
11461 2019-01-08  Tom Tromey  <tom@tromey.com>
11462             Simon Marchi  <simon.marchi@ericsson.com>
11463
11464         PR gdb/24060
11465         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11466         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11467         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11468         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11469         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11470         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11471
11472 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11473
11474         * source.c (select_source_symtab): Move header comment to
11475         declaration in source.h.
11476         (forget_cached_source_info_for_objfile): Likewise.
11477         (forget_cached_source_info): Likewise.
11478         (identify_source_line): Likewise.
11479         * source.h (identify_source_line): Move declaration from symtab.h
11480         and add comment from source.c
11481         (print_source_lines): Likewise.
11482         (forget_cached_source_info_for_objfile): Likewise.
11483         (forget_cached_source_info): Likewise.
11484         (select_source_symtab): Likewise.
11485         (enum print_source_lines_flag): Move definition from symtab.h.
11486         * symtab.h (identify_source_line): Move declaration to source.h.
11487         (print_source_lines): Likewise.
11488         (forget_cached_source_info_for_objfile): Likewise.
11489         (forget_cached_source_info): Likewise.
11490         (select_source_symtab): Likewise.
11491         (enum print_source_lines_flag): Move definition to source.h.
11492         * tui/tui-hooks.c: Add 'source.h' include.
11493
11494 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * source.c (print_source_lines_base): Handle requests to print
11497         reverse line number sequences, and guard against empty lines
11498         string.
11499
11500 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11501
11502         * source.c (print_source_lines_base): Fix skip of '\r' if next
11503         character is '\n'.
11504
11505 2019-01-06  Tom Tromey  <tom@tromey.com>
11506
11507         * c-exp.y (struct c_parse_state) <macro_original_text,
11508         expansion_obstack>: New member.
11509         (macro_original_text, expansion_obstack): Remove globals.
11510         (scan_macro_expansion, scanning_macro_expansion)
11511         (finished_macro_expansion): Update.
11512         (scan_macro_cleanup): Remove.
11513         (yylex, c_parse): Update.
11514
11515 2019-01-06  Tom Tromey  <tom@tromey.com>
11516
11517         * c-exp.y (struct c_parse_state) <strings>: New member.
11518         (operator_stoken): Update.
11519
11520 2019-01-06  Tom Tromey  <tom@tromey.com>
11521
11522         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11523         (union type_stack_elt) <typelist_val>: Now a pointer to
11524         std::vector.
11525         (type_stack_cleanup): Don't declare.
11526         (push_typelist): Update.
11527         * parse.c (pop_typelist): Return a std::vector.
11528         (push_typelist): Take a std::vector.
11529         (follow_types): Update.  Do not free args.
11530         (type_stack_cleanup): Remove.
11531         * c-exp.y (struct c_parse_state): New.
11532         (cpstate): New global.
11533         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11534         (nonempty_typelist): Update.
11535         (func_mod): Create a new vector.
11536         (c_parse): Create a c_parse_state.
11537         (check_parameter_typelist): Do not delete params.
11538         (function_method): Update.  Do not delete type_list.
11539
11540 2019-01-06  Tom Tromey  <tom@tromey.com>
11541
11542         PR gdb/28155:
11543         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11544         check_typedef.
11545         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11546         (print_return_value): Likewise.
11547
11548 2019-01-05  Tom Tromey  <tom@tromey.com>
11549
11550         * contrib/cleanup_check.py: Remove.
11551         * contrib/gcc-with-excheck: Remove.
11552         * contrib/exsummary.py: Remove.
11553         * contrib/excheck.py: Remove.
11554
11555 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11556
11557         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11558         NULL. Initialize tpprev to NULL instead of assigning it
11559         to NULL on the next statement.
11560         * windows-nat.c (windows_delete_thread): Remove check for
11561         main_thread_id before printing thread exit notifications.
11562         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11563         Remove thread ID check against main_thread_id.
11564         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11565         windows_delete_thread.
11566         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11567
11568 2019-01-04  Tom Tromey  <tom@tromey.com>
11569
11570         * compile/compile.c (_initialize_compile): Use upper case for
11571         metasyntactic variables.
11572         * symmisc.c (_initialize_symmisc): Use upper case for
11573         metasyntactic variables.
11574         * psymtab.c (_initialize_psymtab): Use upper case for
11575         metasyntactic variables.
11576         * demangle.c (demangle_command): Use upper case for metasyntactic
11577         variables.
11578         (_initialize_demangler): Likewise.
11579         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11580         variables.
11581
11582 2019-01-03  Tom Tromey  <tom@tromey.com>
11583
11584         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11585
11586 2019-01-03  Tom Tromey  <tom@tromey.com>
11587
11588         * python/py-symtab.c (salpy_str): Update.
11589         (struct salpy_sal_object) <symtab>: Now a PyObject.
11590         (salpy_dealloc): Update.
11591         (del_objfile_sal): Use gdbpy_ref.
11592
11593 2019-01-03  Tom Tromey  <tom@tromey.com>
11594
11595         * python/py-type.c (convert_field): Use new_reference.  Return
11596         gdbpy_ref.
11597         (make_fielditem): Return gdbpy_ref.
11598         (typy_fields): Update.
11599         (typy_getitem): Update.
11600         (field_name): Return gdbpy_ref.  Use new_reference.
11601         (typy_iterator_iternext): Update.
11602
11603 2019-01-03  Tom Tromey  <tom@tromey.com>
11604
11605         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11606
11607 2019-01-03  Tom Tromey  <tom@tromey.com>
11608
11609         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11610         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11611         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11612         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11613         (pspy_set_type_printers): Likewise.
11614         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11615         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11616         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11617         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11618         (objfpy_set_type_printers): Likewise.
11619
11620 2019-01-03  Tom Tromey  <tom@tromey.com>
11621
11622         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11623         (gdbpy_print_stack): Use gdbpy_err_fetch.
11624         * python/python-internal.h (class gdbpy_err_fetch): New class.
11625         (class gdbpy_enter) <m_error_type, m_error_value,
11626         m_error_traceback>: Remove.
11627         <m_error>: New member.
11628         (gdbpy_exception_to_string): Don't declare.
11629         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11630         * python/py-value.c (convert_value_from_python): Use
11631         gdbpy_err_fetch.
11632         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11633         gdbpy_exception_to_string.
11634         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11635         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11636         gdbpy_err_fetch.
11637
11638 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11639
11640         * linux-nat.c (delete_lwp_cleanup): Delete.
11641         (struct lwp_deleter): New struct.
11642         (lwp_info_up): New typedef.
11643         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11644         lwp_info_up.
11645
11646 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11647
11648         * linux-fork.c (class scoped_switch_fork_info): New class.
11649         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11650
11651 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11652
11653         * valops.c (find_overload_match): Remove use of null_cleanup, and
11654         calls to do_cleanups.
11655
11656 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11657
11658         * compile/compile-cplus-types.c
11659         (compile_cplus_instance::decl_name): Handle changes to
11660         cp_func_name.
11661         * cp-support.c (cp_func_name): Update header comment, update
11662         return type.
11663         * cp-support.h (cp_func_name): Update return type in declaration.
11664         * valops.c (find_overload_match): Move temp_func local to top
11665         level of function and change its type.  Use temp_func to hold and
11666         delete temporary string obtained from cp_func_name.
11667
11668 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11669
11670         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11671         gdb::char_vector, remove cleanup, and update uses of `msg`.
11672
11673 2019-01-03  Jim Wilson  <jimw@sifive.com>
11674
11675         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11676
11677 2019-01-02  Tom Tromey  <tom@tromey.com>
11678
11679         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11680         (tdesc_parse_xml): Remove cleanups.
11681         * target-descriptions.h (make_cleanup_free_target_description):
11682         Don't declare.
11683         (target_desc_deleter): New struct.
11684         (target_desc_up): New typedef.
11685         * target-descriptions.c (target_desc_deleter::operator()): Rename
11686         from free_target_description.
11687         (make_cleanup_free_target_description): Remove.
11688
11689 2019-01-02  Tom Tromey  <tom@tromey.com>
11690
11691         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11692         constructor, destructor.
11693         (linespec_parser): Remove typedef.
11694         (~linespec_parser): Rename from linespec_parser_delete.
11695         (linespec_lex_to_end, linespec_complete_label)
11696         (linespec_complete): Update.
11697         (decode_line_full): Remove cleanups.
11698         (decode_line_1): Update.
11699
11700 2019-01-02  Tom Tromey  <tom@tromey.com>
11701
11702         * python/python-internal.h (inferior_to_inferior_object): Change
11703         return type.
11704         * python/py-exitedevent.c (create_exited_event_object): Update.
11705         * python/py-inferior.c (inferior_to_inferior_object): Return
11706         gdbpy_ref.
11707         (python_new_inferior, python_inferior_deleted)
11708         (thread_to_thread_object, delete_thread_object)
11709         (build_inferior_list, gdbpy_selected_inferior): Update.
11710         * python/py-infthread.c (create_thread_object): Update.  Also fail
11711         if inferior_to_inferior_object fails.
11712
11713 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11714
11715         * inferior.h (class inferior) <displaced_step_state>: New field.
11716         * infrun.h (struct displaced_step_state): Move here from
11717         infrun.c.  Initialize fields, add constructor.
11718         <inf>: Remove field.
11719         <reset>: New method.
11720         * infrun.c (struct displaced_step_inferior_state): Move to
11721         infrun.h.
11722         (displaced_step_inferior_states): Remove.
11723         (get_displaced_stepping_state): Adust.
11724         (displaced_step_in_progress_any_inferior): Adjust.
11725         (displaced_step_in_progress_thread): Adjust.
11726         (displaced_step_in_progress): Adjust.
11727         (add_displaced_stepping_state): Remove.
11728         (get_displaced_step_closure_by_addr): Adjust.
11729         (remove_displaced_stepping_state): Remove.
11730         (infrun_inferior_exit): Call displaced_step_state.reset.
11731         (use_displaced_stepping): Don't check for NULL.
11732         (displaced_step_prepare_throw): Call
11733         get_displaced_stepping_state.
11734         (displaced_step_fixup): Don't check for NULL.
11735         (prepare_for_detach): Don't check for NULL.
11736
11737 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11738
11739         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11740          in case of call that did not complete.
11741
11742 2019-01-02  Andrey Utkin  <autkin@undo.io>
11743
11744         * symfile.c (find_separate_debug_file): Fix search of debug files for
11745         remote debuggee.
11746
11747 2019-01-02  Tom Tromey  <tom@tromey.com>
11748
11749         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11750         indentation.
11751         * python/py-frame.c (frapy_older): Remove cast.
11752         (frapy_newer): Likewise.
11753         * python/py-breakpoint.c (local_setattro): Remove cast.
11754         * python/py-arch.c (archpy_name): Remove local variable.
11755         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11756
11757 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11758
11759         * unittests/basic_string_view/element_access/char/empty.cc:
11760         Fix year range in copyright header.
11761
11762 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11763
11764         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11765         Delete.
11766         <operator==>: Update with for removed field.
11767         <hash>: Likewise.
11768         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11769         <isa_features>: ...this.
11770         <abi_features>: New field.
11771         (riscv_isa_flen): Update comment.
11772         (riscv_abi_xlen): New declaration.
11773         (riscv_abi_flen): New declaration.
11774         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11775         isa_features.
11776         (riscv_abi_xlen): New function.
11777         (riscv_isa_flen): Update to get answer from isa_features.
11778         (riscv_abi_flen): New function.
11779         (riscv_has_fp_abi): Update to get answer from abi_features.
11780         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11781         xlen and flen.
11782         (riscv_call_info) <xlen, flen>: Update comment.
11783         (riscv_call_arg_struct): Remove invalid assertions
11784         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11785         is removed.
11786         (riscv_gdbarch_init): Gather isa features and abi features
11787         separately, ensure both match on the gdbarch when reusing an old
11788         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11789         a target with 64-bit float hardware.
11790
11791 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11792
11793         * source.c (search_command_helper): Stop reverse search
11794         when line 1 has been searched.
11795
11796 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11797
11798         * record-full.c (record_full_base_target::close): Rewrite
11799         record_full_core_buf_list free logic.
11800
11801 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11802
11803         * break-catch-syscall.c (print_one_catch_syscall): xfree
11804         the last text.
11805
11806 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11807
11808         * top.c (print_gdb_version): Update Copyright year in version
11809         message.
11810
11811 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11812
11813         Update copyright year range in all GDB files.
11814
11815 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11816
11817         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11818
11819 For older changes see ChangeLog-2018.
11820 \f
11821 Local Variables:
11822 mode: change-log
11823 left-margin: 8
11824 fill-column: 74
11825 version-control: never
11826 coding: utf-8
11827 End:
11828