aarch64: add STO_AARCH64_VARIANT_PCS and DT_AARCH64_VARIANT_PCS

Backport commit 2301ed1c9af1316b4bad3747d2b03f7d44940f87

The bottom 2 bits of st_other are used for visibility, the top 6 bits are
de facto reserved for processor specific use.  This patch defines a
bits to mark function symbols that follow a variant procedure call standard
with different register usage convention.

A dynamic tag is also defined that marks modules with R_<CLS>_JUMP_SLOT
relocations referencing symbols marked with STO_AARCH64_VARIANT_PCS.
This can be used by dynamic linkers that support lazy binding to decide
what registers need to be preserved during symbol resolution.

binutils/ChangeLog:

	* readelf.c (get_aarch64_dynamic_type): Handle DT_AARCH64_VARIANT_PCS.
	(get_aarch64_symbol_other): New, handles STO_AARCH64_VARIANT_PCS.
	(get_symbol_other): Call get_aarch64_symbol_other.

include/ChangeLog:

	* elf/aarch64.h (DT_AARCH64_VARIANT_PCS): Define.
	(STO_AARCH64_VARIANT_PCS): Define.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 78fe77dd8ed11c332cc0cd3b67619424b453d22e..011218189095a96721ac8909c14f746cd3d2d23a 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,12 @@
+2019-07-05  Szabolcs Nagy  <szabolcs.nagy@arm.com>
+
+       Backport from mainline.
+       2019-05-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>
+
+       * readelf.c (get_aarch64_dynamic_type): Handle DT_AARCH64_VARIANT_PCS.
+       (get_aarch64_symbol_other): New, handles STO_AARCH64_VARIANT_PCS.
+       (get_symbol_other): Call get_aarch64_symbol_other.
+
 2019-05-21  Tamar Christina  <tamar.christina@arm.com>
 
        Backport from mainline.

diff --git a/binutils/readelf.c b/binutils/readelf.c
index b13eb6a43ba34f6346a2a080573d972540c91010..28466e0cd754b6a244fda1041eee7a46878072f6 100644 (file)
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -1796,6 +1796,17 @@ dump_relocations (Filedata *          filedata,
   return res;
 }
 
+static const char *
+get_aarch64_dynamic_type (unsigned long type)
+{
+  switch (type)
+    {
+    case DT_AARCH64_VARIANT_PCS:  return "AARCH64_VARIANT_PCS";
+    default:
+      return NULL;
+    }
+}
+
 static const char *
 get_mips_dynamic_type (unsigned long type)
 {
@@ -11053,6 +11064,22 @@ get_solaris_symbol_visibility (unsigned int visibility)
     }
 }
 
+static const char *
+get_aarch64_symbol_other (unsigned int other)
+{
+  static char buf[32];
+
+  if (other & STO_AARCH64_VARIANT_PCS)
+    {
+      other &= ~STO_AARCH64_VARIANT_PCS;
+      if (other == 0)
+       return "VARIANT_PCS";
+      snprintf (buf, sizeof buf, "VARIANT_PCS | %x", other);
+      return buf;
+    }
+  return NULL;
+}
+
 static const char *
 get_mips_symbol_other (unsigned int other)
 {
@@ -11164,6 +11191,9 @@ get_symbol_other (Filedata * filedata, unsigned int other)
 
   switch (filedata->file_header.e_machine)
     {
+    case EM_AARCH64:
+      result = get_aarch64_symbol_other (other);
+      break;
     case EM_MIPS:
       result = get_mips_symbol_other (other);
       break;

diff --git a/include/ChangeLog b/include/ChangeLog
index 8c4c6353ad587679a5f0e219787d17647f79a198..0e1d7d433deb328827226bd14669efbb25ffeaae 100644 (file)
--- a/include/ChangeLog
+++ b/include/ChangeLog
@@ -1,3 +1,11 @@
+2019-07-05  Szabolcs Nagy  <szabolcs.nagy@arm.com>
+
+       Backport from mainline.
+       2019-05-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>
+
+       * elf/aarch64.h (DT_AARCH64_VARIANT_PCS): Define.
+       (STO_AARCH64_VARIANT_PCS): Define.
+
 2019-04-16  Sudakshina Das  <sudi.das@arm.com>
 
        Backport from mainline.

diff --git a/include/elf/aarch64.h b/include/elf/aarch64.h
index 3133ea6f6653eefc846da224e14fc6974cb2bf54..841d8479cfb7527a96870fc71f277a32d5ef543d 100644 (file)
--- a/include/elf/aarch64.h
+++ b/include/elf/aarch64.h
@@ -35,6 +35,12 @@
                                                entry point.  */
 #define SHF_COMDEF             0x80000000   /* Section may be multiply defined
                                                in the input to a link step.  */
+/* Processor specific dynamic array tags.  */
+#define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
+
+/* AArch64-specific values for st_other.  */
+#define STO_AARCH64_VARIANT_PCS        0x80  /* Symbol may follow different call
+                                        convention from the base PCS.  */
 
 /* Relocation types.  */