alpha-coff: unitialised read

	* coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
	return value check.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1878fd79716df9e930d72c6f3cd8c72aca72194b..4c2bb14f6ccb99accce826655ba03659528e8639 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-31  Alan Modra  <amodra@gmail.com>
+
+       * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
+       return value check.
+
 2020-03-31  Alan Modra  <amodra@gmail.com>
 
        * vms-alpha.c (image_write): Check bounds for sections without

diff --git a/bfd/coff-alpha.c b/bfd/coff-alpha.c
index b86a8a259b584dd30481389b398fa4f6851ca932..4fd3b5c488dbeec3bcd055ce88316b73bb8232c4 100644 (file)
--- a/bfd/coff-alpha.c
+++ b/bfd/coff-alpha.c
@@ -2130,7 +2130,7 @@ alpha_ecoff_get_elt_at_filepos (bfd *archive, file_ptr filepos)
                n = dict[h];
              else
                {
-                 if (! bfd_bread (&n, (bfd_size_type) 1, nbfd))
+                 if (bfd_bread (&n, 1, nbfd) != 1)
                    goto error_return;
                  dict[h] = n;
                }