Don't output null pathname in core_target::build_file_mappings warning

While looking into the regressions reported by Luis Machado, I noticed
that null pathnames were being output in the warnings.  E.g.

warning: Can't open file (null) during file-backed mapping note processing

I've changed the warning to output the pathname found in the note,
like this:

warning: Can't open file /var/lib/docker/aufs/diff/d07c...e21/lib/x86_64-linux-gnu/libc-2.27.so during file-backed mapping note processing

(I've shortened one of the path elements above.)

gdb/ChangeLog:

	* corelow.c (core_target::build_file_mappings): Don't output
	null pathname in warning.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1d510321d3b2e896eed82ac32ffcfabdaacf1c34..01f3c9e7519d61bf6bd52a3bef1201bdc6c82dd5 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-08-05  Kevin Buettner  <kevinb@redhat.com>
+
+       * corelow.c (core_target::build_file_mappings): Don't output
+       null pathname in warning.
+
 2020-08-05  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,

diff --git a/gdb/corelow.c b/gdb/corelow.c
index 367f54cd53680072c3e7ecbb139a39da8abb7745..b6ee219f57c293eed300c790d76fd8043e209bd5 100644 (file)
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -218,7 +218,7 @@ core_target::build_file_mappings ()
              {
                warning (_("Can't open file %s during file-backed mapping "
                           "note processing"),
-                        expanded_fname.get ());
+                        filename);
                return;
              }