Do not adjust mtime timezone on Windows

PR win32/25302 notes that gdb will crash when trying to "run" even a
simple program on Windows.  The essential bug here is that the BFD
cache can easily be corrupted -- I have sent a separate patch for
that.

The particular reason that the cache is corrupted on Windows is that
gnulib overrides "stat" to make it do timezone adjustment -- but BFD
does not use this version of stat.  The difference here triggers the
latent cache bug, but can also cause other bugs as well; in particular
it can cause spurious warnings about source files being newer.

This patch simply removes the stat override on mingw, making gnulib
and BFD agree.

I tested this by backing out the local AdaCore changes to work around
this bug and then verifying that I could reproduce it.  Then, I
applied this patch and verified that "run" works again.

2020-09-08  Tom Tromey  <tromey@adacore.com>

	PR win32/25302:
	* update-gnulib.sh: Apply stat patch.
	* patches/0001-use-windows-stat: New file.
	* import/m4/stat.m4: Update.
	* configure: Rebuild.

diff --git a/gnulib/ChangeLog b/gnulib/ChangeLog
index b8c6c008895ff293e3d38acd923d97689fabf526..bf617428c4d60f36817ee73992f4da5fae7aa05a 100644 (file)
--- a/gnulib/ChangeLog
+++ b/gnulib/ChangeLog
@@ -1,3 +1,11 @@
+2020-09-08  Tom Tromey  <tromey@adacore.com>
+
+       PR win32/25302:
+       * update-gnulib.sh: Apply stat patch.
+       * patches/0001-use-windows-stat: New file.
+       * import/m4/stat.m4: Update.
+       * configure: Rebuild.
+
 2020-08-26  Christian Biesinger  <cbiesinger@google.com>
            Pedro Alves  <palves@redhat.com>
            Joel Brobecker  <brobecker@adacore.com>

diff --git a/gnulib/configure b/gnulib/configure
index fa2feb5ea9a78a87e96b046f175b21c03b888875..5c6add6e37181096745e59c72740efe3fbaa3231 100644 (file)
--- a/gnulib/configure
+++ b/gnulib/configure
@@ -26907,8 +26907,7 @@ $as_echo "#define ssize_t int" >>confdefs.h
 
   case "$host_os" in
     mingw*)
-                  REPLACE_STAT=1
-      ;;
+                        ;;
     *)
                         { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether stat handles trailing slashes on files" >&5
 $as_echo_n "checking whether stat handles trailing slashes on files... " >&6; }

diff --git a/gnulib/import/m4/stat.m4 b/gnulib/import/m4/stat.m4
index 46e9abceee7d11582f381e2ef9330b044859bcd8..8ef355f9407a017c57142299ab5c780365516aa6 100644 (file)
--- a/gnulib/import/m4/stat.m4
+++ b/gnulib/import/m4/stat.m4
@@ -15,7 +15,7 @@ AC_DEFUN([gl_FUNC_STAT],
     mingw*)
       dnl On this platform, the original stat() returns st_atime, st_mtime,
       dnl st_ctime values that are affected by the time zone.
-      REPLACE_STAT=1
+      dnl REPLACE_STAT=1
       ;;
     *)
       dnl AIX 7.1, Solaris 9, mingw64 mistakenly succeed on stat("file/").

diff --git a/gnulib/patches/0001-use-windows-stat b/gnulib/patches/0001-use-windows-stat
new file mode 100644 (file)
index 0000000..adf9638
--- /dev/null
+++ b/gnulib/patches/0001-use-windows-stat
@@ -0,0 +1,13 @@
+diff --git a/gnulib/import/m4/stat.m4 b/gnulib/import/m4/stat.m4
+index 46e9abceee7..8ef355f9407 100644
+--- a/gnulib/import/m4/stat.m4
++++ b/gnulib/import/m4/stat.m4
+@@ -15,7 +15,7 @@ AC_DEFUN([gl_FUNC_STAT],
+     mingw*)
+       dnl On this platform, the original stat() returns st_atime, st_mtime,
+       dnl st_ctime values that are affected by the time zone.
+-      REPLACE_STAT=1
++      dnl REPLACE_STAT=1
+       ;;
+     *)
+       dnl AIX 7.1, Solaris 9, mingw64 mistakenly succeed on stat("file/").

diff --git a/gnulib/update-gnulib.sh b/gnulib/update-gnulib.sh
index b9cc7d8f353fd449d91e221c8a5a307de2eaa700..ac5e3d56a29ca341718c319a74a4ec3aca81baf7 100755 (executable)
--- a/gnulib/update-gnulib.sh
+++ b/gnulib/update-gnulib.sh
@@ -173,6 +173,8 @@ apply_patches ()
     fi
 }
 
+apply_patches "patches/0001-use-windows-stat"
+
 # Regenerate all necessary files...
 aclocal &&
 autoconf &&