]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 981487 - change bugs_fulltext from myisam to innodb
authorDylan William Hardison <dylan@hardison.net>
Thu, 31 Jan 2019 01:34:54 +0000 (20:34 -0500)
committerDylan William Hardison <dylan@hardison.net>
Thu, 31 Jan 2019 01:34:54 +0000 (20:34 -0500)
Bugzilla/Bug.pm
Bugzilla/DB/Schema/Mysql.pm

index ebf00edf3efd0763cf0afcf8ccfae0e574b9c006..d4e02233600a710a56c7551750028bae5ddd7d9c 100644 (file)
@@ -838,13 +838,10 @@ sub create {
   Bugzilla::Hook::process('bug_end_of_create',
     {bug => $bug, timestamp => $timestamp,});
 
-  $dbh->bz_commit_transaction();
-
-  # Because MySQL doesn't support transactions on the fulltext table,
-  # we do this after we've committed the transaction. That way we're
-  # sure we're inserting a good Bug ID.
   $bug->_sync_fulltext(new_bug => 1);
 
+  $dbh->bz_commit_transaction();
+
   return $bug;
 }
 
@@ -1211,17 +1208,13 @@ sub update {
     delete $user->{bugs_ignored} if $bug_ignored_changed;
   }
 
-  $dbh->bz_commit_transaction();
-
-  # The only problem with this here is that update() is often called
-  # in the middle of a transaction, and if that transaction is rolled
-  # back, this change will *not* be rolled back. As we expect rollbacks
-  # to be extremely rare, that is OK for us.
   $self->_sync_fulltext(
     update_short_desc => $changes->{short_desc},
     update_comments   => $self->{added_comments} || $self->{comment_isprivate}
   );
 
+  $dbh->bz_commit_transaction();
+
   # Remove obsolete internal variables.
   delete $self->{'_old_assigned_to'};
   delete $self->{'_old_qa_contact'};
index fe2191486076d676de48fb15346ecc6a48bcac85..b5bebad305f2d4fdbae09252b97008b5f24af6e4 100644 (file)
@@ -85,7 +85,7 @@ use constant REVERSE_MAPPING => {
   # as in their db-specific version, so no reverse mapping is needed.
 };
 
-use constant MYISAM_TABLES => qw(bugs_fulltext);
+use constant MYISAM_TABLES => qw();
 
 #------------------------------------------------------------------------------
 sub _initialize {