The default IPP version did not always get set before creating a new IPP

request message (<rdar://problem/14401718>)

git-svn-id: svn+ssh://src.apple.com/svn/cups/cups.org/trunk@11113 a1ca3aef-8c08-0410-bb20-df032aa958be

diff --git a/CHANGES-1.6.txt b/CHANGES-1.6.txt
index e564c9d9301e4cd5c0fce1daa1c240f2fb9d87d6..896badedd2e9e65206a9ae16610ced54a6c9b46b 100644 (file)
--- a/CHANGES-1.6.txt
+++ b/CHANGES-1.6.txt
@@ -5,6 +5,8 @@ CHANGES IN CUPS V1.6.3
 
        - The configure script now prefers Clang over GCC.
        - Fixed a compile problem on AIX (STR #4307)
+       - The default IPP version did not always get set before creating a new
+         IPP request message (<rdar://problem/14401718>)
        - The lp, lpq, lpr, and lpstat now display an error message advising the
          use of the /version=1.1 ServerName option (<rdar://problem/14290628>)
        - Added documentation about the /version=1.1 option to ServerName in

diff --git a/cups/globals.c b/cups/globals.c
index b343bcf322bf8a806063d3652934b3e0affd06ec..41a5854cdc6c3af343f43067b2a3f6d183adbe2e 100644 (file)
--- a/cups/globals.c
+++ b/cups/globals.c
@@ -219,7 +219,6 @@ cups_globals_alloc(void)
   cg->any_root       = 1;
   cg->expired_certs  = 1;
   cg->expired_root   = 1;
-  cg->server_version = 20;
 
 #ifdef DEBUG
  /*

diff --git a/cups/ipp.c b/cups/ipp.c
index 409a0ec8268f190ba1232e8346a0db43343b2b13..fc813d658bb73a9a578e29302392bacf15012bc5 100644 (file)
--- a/cups/ipp.c
+++ b/cups/ipp.c
@@ -2741,6 +2741,9 @@ ippNew(void)
     * Set default version - usually 2.0...
     */
 
+    if (cg->server_version == 0)
+      _cupsSetDefaults();
+
     temp->request.any.version[0] = cg->server_version / 10;
     temp->request.any.version[1] = cg->server_version % 10;
     temp->use                    = 1;

diff --git a/cups/usersys.c b/cups/usersys.c
index d01fe08b57b3540af8a277e2122315a287180f0d..9a2df68b6539aa663296ba4b62e74567bf5898cb 100644 (file)
--- a/cups/usersys.c
+++ b/cups/usersys.c
@@ -370,6 +370,8 @@ cupsSetServer(const char *server)   /* I - Server name */
       else if (!strcmp(options, "version=2.2"))
         cg->server_version = 22;
     }
+    else
+      cg->server_version = 20;
 
     if (cg->server[0] != '/' && (port = strrchr(cg->server, ':')) != NULL &&
         !strchr(port, ']') && isdigit(port[1] & 255))