]> git.ipfire.org Git - thirdparty/cups.git/log
thirdparty/cups.git
6 years agoPackaging changes for newer localizations. v2.2.5
Michael R Sweet [Fri, 13 Oct 2017 18:22:26 +0000 (14:22 -0400)] 
Packaging changes for newer localizations.

6 years agoMore updates to the README file.
Michael Sweet [Fri, 13 Oct 2017 00:37:36 +0000 (20:37 -0400)] 
More updates to the README file.

6 years agoPrep for 2.2.5 release.
Michael Sweet [Fri, 13 Oct 2017 00:15:58 +0000 (20:15 -0400)] 
Prep for 2.2.5 release.

6 years agoMerge pull request #5139 from kant/patch-1
Michael R Sweet [Thu, 12 Oct 2017 23:39:22 +0000 (19:39 -0400)] 
Merge pull request #5139 from kant/patch-1

Clean up README markup(down).

6 years agoMinor fixes (proposals) 5139/head
Darío Hereñú [Thu, 12 Oct 2017 19:53:46 +0000 (16:53 -0300)] 
Minor fixes (proposals)

6 years agoIgnore new test programs.
Michael Sweet [Thu, 12 Oct 2017 18:46:02 +0000 (14:46 -0400)] 
Ignore new test programs.

6 years agoFix "make check" for restricted environments (Issue #5099)
Michael Sweet [Thu, 12 Oct 2017 18:27:18 +0000 (14:27 -0400)] 
Fix "make check" for restricted environments (Issue #5099)

6 years agoFixed the script interpreter detection in the configure script (Issue #5122)
Michael Sweet [Thu, 12 Oct 2017 14:43:35 +0000 (10:43 -0400)] 
Fixed the script interpreter detection in the configure script (Issue #5122)

6 years agoChanglog + remove generated web interface header template (Issue #5134)
Michael Sweet [Thu, 12 Oct 2017 14:26:09 +0000 (10:26 -0400)] 
Changlog + remove generated web interface header template (Issue #5134)

6 years agoMerge pull request #5134 from LAfricain/master
Michael R Sweet [Thu, 12 Oct 2017 14:23:44 +0000 (10:23 -0400)] 
Merge pull request #5134 from LAfricain/master

Creation of template/fr and French translation of all the template files

6 years agoOne further fix for cupsGetDests2 - don't show network printers when the server
Michael Sweet [Thu, 12 Oct 2017 12:31:03 +0000 (08:31 -0400)] 
One further fix for cupsGetDests2 - don't show network printers when the server
is remote.

6 years ago`cupsGetDests2` was not using the supplied HTTP connection (Issue #5135)
Michael Sweet [Wed, 11 Oct 2017 17:27:36 +0000 (13:27 -0400)] 
`cupsGetDests2` was not using the supplied HTTP connection (Issue #5135)

- Make a local cups_enum_dests function that accepts a http_t *.
- Have both cupsEnumDests and cupsGetDests2 call cups_enum_dests.

6 years agoFix crash in debug printf.
Michael Sweet [Wed, 11 Oct 2017 17:23:27 +0000 (13:23 -0400)] 
Fix crash in debug printf.

6 years agoThe network backends now retry on more error conditions (Issue #5123)
Michael Sweet [Thu, 5 Oct 2017 19:04:19 +0000 (15:04 -0400)] 
The network backends now retry on more error conditions (Issue #5123)

6 years agoCorrection of a bad translation 5134/head
Lafricain [Thu, 5 Oct 2017 12:00:42 +0000 (13:00 +0100)] 
Correction of a bad translation

6 years agoAdd support for Japanese Kaku 1 envelope size (rdar://34774110)
Michael Sweet [Mon, 2 Oct 2017 23:29:52 +0000 (19:29 -0400)] 
Add support for Japanese Kaku 1 envelope size (rdar://34774110)

- Add jpn_kaku1_270x382mm size to table.

6 years agoThe scheduler did not run with a high enough priority, causing problems on
Michael Sweet [Mon, 2 Oct 2017 23:14:25 +0000 (19:14 -0400)] 
The scheduler did not run with a high enough priority, causing problems on
busy systems (rdar://33789342)

- Change ProcessType to Adaptive for both cupsd and cups-lpd
- Add "working" parameter to cupsdSetBusyState
- Call cupsdSetBusyState on startup to boost the priority on startup.

6 years agoCreation of Template/fr and French translation of all the template files
Lafricain [Mon, 2 Oct 2017 12:56:19 +0000 (13:56 +0100)] 
Creation of Template/fr and French translation of all the template files

6 years agoMerge pull request #5112 from paulmenzel/remove-libgcrypt-detection
Michael R Sweet [Thu, 28 Sep 2017 17:12:01 +0000 (13:12 -0400)] 
Merge pull request #5112 from paulmenzel/remove-libgcrypt-detection

Remove Libgcrypt detection

6 years agoOne more thing for macOS (Issue #5116)
Michael Sweet [Mon, 25 Sep 2017 14:55:27 +0000 (10:55 -0400)] 
One more thing for macOS (Issue #5116)

6 years agoUpdate INSTALL.md (Issue #5116)
Michael Sweet [Mon, 25 Sep 2017 14:54:36 +0000 (10:54 -0400)] 
Update INSTALL.md (Issue #5116)

6 years agoAdd USB quirk for HP LaserJet 1160 (Issue #1160)
Michael Sweet [Mon, 25 Sep 2017 14:19:17 +0000 (10:19 -0400)] 
Add USB quirk for HP LaserJet 1160 (Issue #1160)

6 years agoUpdate configure script.
Michael Sweet [Sun, 24 Sep 2017 15:51:48 +0000 (11:51 -0400)] 
Update configure script.

6 years agoSuppress new GCC warning about snprintf truncation (Issue #5110)
Michael Sweet [Sun, 24 Sep 2017 15:51:07 +0000 (11:51 -0400)] 
Suppress new GCC warning about snprintf truncation (Issue #5110)

6 years agoRe-document that file devices do not work with raw queues, and move FileDevice
Michael Sweet [Fri, 22 Sep 2017 02:47:04 +0000 (22:47 -0400)] 
Re-document that file devices do not work with raw queues, and move FileDevice
to the list of deprecated configuration directives (Issue #5117)

6 years agoBump Xcode CUPS version.
Michael Sweet [Fri, 22 Sep 2017 02:39:52 +0000 (22:39 -0400)] 
Bump Xcode CUPS version.

6 years agoFix Windows builds.
Michael Sweet [Thu, 14 Sep 2017 18:20:07 +0000 (14:20 -0400)] 
Fix Windows builds.

6 years agoDetach worker threads to prevent memory leaks.
Michael Sweet [Thu, 14 Sep 2017 18:19:00 +0000 (14:19 -0400)] 
Detach worker threads to prevent memory leaks.

6 years agoFix memory leaks.
Michael Sweet [Thu, 14 Sep 2017 18:12:49 +0000 (14:12 -0400)] 
Fix memory leaks.

6 years agoAllow DELAY values of 0.
Michael Sweet [Tue, 12 Sep 2017 16:21:00 +0000 (12:21 -0400)] 
Allow DELAY values of 0.

6 years agoconfig-scripts/cups-ssl.m4: Remove Libgcrypt detection 5112/head
Paul Menzel [Tue, 12 Sep 2017 11:11:48 +0000 (13:11 +0200)] 
config-scripts/cups-ssl.m4: Remove Libgcrypt detection

Upstream a change from the book *Beyond Linux From Scratch* [1].

> Prevent configure script from searching libgcrypt-config, because
> libgcrypt is not used anywere else in the package.

[1] http://www.linuxfromscratch.org/blfs/view/svn/pst/cups.html

6 years agoThe scheduler (incorrectly) woke up once per second to remove stale temporary
Michael Sweet [Mon, 11 Sep 2017 21:08:17 +0000 (17:08 -0400)] 
The scheduler (incorrectly) woke up once per second to remove stale temporary
queues (Issue #5100).

- scheduler/main.c: Update local_timeout to start at 0 and only get updated as
  needed.

Fixes: #5100
6 years agoFix mapping and defaulting of print-quality/cupsPrintQuality (Issue #5090)
Michael Sweet [Mon, 11 Sep 2017 20:22:45 +0000 (16:22 -0400)] 
Fix mapping and defaulting of print-quality/cupsPrintQuality (Issue #5090)

- cups/dest.c: Don't include empty default media or print-quality in dest
  options.
- cups/options.c: When setting cupsPrintQuality, clear print-quality and vise-
  versa.
- cups/testipp.c: Use current API to show attribute values.
- scheduler/ipp.c: Log request attributes, defaults.
- scheduler/job.c: Add/map print-quality/cupsPrintQuality, log mapped options.

Fixes: #5090
6 years agoThe `ipptool` program did not compare URI scheme or hostname components
Michael Sweet [Thu, 7 Sep 2017 14:36:09 +0000 (10:36 -0400)] 
The `ipptool` program did not compare URI scheme or hostname components
correctly for the WITH-ALL-HOSTNAMES, WITH-ALL-SCHEMES, WITH-HOSTNAME, or
WITH-SCHEME predicates.

Also fix EXPECT reporting for the URI component WITH predicates.

6 years agoFix builds without Bonjour/Avahi (Issue #5105)
Michael Sweet [Tue, 5 Sep 2017 21:03:10 +0000 (17:03 -0400)] 
Fix builds without Bonjour/Avahi (Issue #5105)

6 years agoChangelog.
Michael Sweet [Tue, 5 Sep 2017 20:59:06 +0000 (16:59 -0400)] 
Changelog.

6 years agoMerge pull request #5103 from michaelweghorn/issue5102
Michael R Sweet [Tue, 5 Sep 2017 20:57:36 +0000 (16:57 -0400)] 
Merge pull request #5103 from michaelweghorn/issue5102

Add a USB quirk rule for the Kyocera Ecosys P6130cdn (Issue #5102)

6 years agoAdd a USB quirk rule for the Kyocera Ecosys P6130cdn (Issue #5102) 5103/head
Michael Weghorn [Fri, 1 Sep 2017 11:37:36 +0000 (13:37 +0200)] 
Add a USB quirk rule for the Kyocera Ecosys P6130cdn (Issue #5102)

6 years agoFix ipptool -P output (some was going to stdout...)
Michael Sweet [Thu, 31 Aug 2017 12:38:39 +0000 (08:38 -0400)] 
Fix ipptool -P output (some was going to stdout...)

6 years ago`httpAddrConnect` leaked sockets in certain circumstances, causing some
Michael Sweet [Wed, 30 Aug 2017 00:42:05 +0000 (20:42 -0400)] 
`httpAddrConnect` leaked sockets in certain circumstances, causing some
printers to hang (rdar://31965686)

6 years agoFix create-job.test file to use filename on command-line.
Michael Sweet [Wed, 30 Aug 2017 00:30:46 +0000 (20:30 -0400)] 
Fix create-job.test file to use filename on command-line.

6 years agoAlways use chunking unless it is a simple request.
Michael Sweet [Wed, 30 Aug 2017 00:30:27 +0000 (20:30 -0400)] 
Always use chunking unless it is a simple request.

6 years agoAdd verbosity option.
Michael Sweet [Wed, 30 Aug 2017 00:29:54 +0000 (20:29 -0400)] 
Add verbosity option.

6 years agoAdd -d (document-format) option to override which format is used.
Michael Sweet [Tue, 29 Aug 2017 23:56:08 +0000 (19:56 -0400)] 
Add -d (document-format) option to override which format is used.

6 years agoFix output to write a full page.
Michael Sweet [Tue, 29 Aug 2017 23:44:10 +0000 (19:44 -0400)] 
Fix output to write a full page.

Add "force grayscale" option.

6 years agoMove test client program to filter directory, finish initial implementation.
Michael Sweet [Tue, 29 Aug 2017 21:27:49 +0000 (17:27 -0400)] 
Move test client program to filter directory, finish initial implementation.

6 years agoSave work on client code.
Michael Sweet [Tue, 29 Aug 2017 18:15:00 +0000 (14:15 -0400)] 
Save work on client code.

6 years agoAdd client simulator for testing basic client functionality from a single
Michael Sweet [Tue, 29 Aug 2017 16:06:23 +0000 (12:06 -0400)] 
Add client simulator for testing basic client functionality from a single
program.

6 years agoFix the interactions between the "print-quality" and "cupsPrintQuality"
Michael Sweet [Tue, 29 Aug 2017 13:33:48 +0000 (09:33 -0400)] 
Fix the interactions between the "print-quality" and "cupsPrintQuality"
options (Issue #5090)

- Make sure print-quality-default does not override cupsPrintQuality
- Make sure print-quality overrides cupsPrintQuality

6 years agoThe CUPS library did not reuse domain sockets (Issue #5098)
Michael Sweet [Mon, 28 Aug 2017 21:59:13 +0000 (17:59 -0400)] 
The CUPS library did not reuse domain sockets (Issue #5098)

6 years agoThe web interface did not support newer language identifiers used by Microsoft 5098/head
Michael Sweet [Mon, 28 Aug 2017 20:18:18 +0000 (16:18 -0400)] 
The web interface did not support newer language identifiers used by Microsoft
web browsers (Issue #5803)

Make sure cupsLangGet supports region codes and that the scheduler uses
cupsLangGet when mapping IPP naturalLanguage values to POSIX locales.

6 years agoMore changes for localization unit test (Issue #5097)
Michael R Sweet [Tue, 25 Jul 2017 23:57:31 +0000 (19:57 -0400)] 
More changes for localization unit test (Issue #5097)

6 years agoUpdate localization information.
Michael Sweet [Mon, 28 Aug 2017 16:29:22 +0000 (12:29 -0400)] 
Update localization information.

Create English locale file from cups.pot for unit tests.

6 years agoFix the localization unit test on Linux (Issue #5097)
Michael Sweet [Mon, 28 Aug 2017 16:19:58 +0000 (12:19 -0400)] 
Fix the localization unit test on Linux (Issue #5097)

Makefile needed to create locale directory for tests.

Also, localization test needs to allow string pointers to match for the POSIX
locale and differ for other languages.

6 years agoUpdate the cups-files.conf and cupsd.conf file documentation for missing
Michael Sweet [Mon, 28 Aug 2017 14:39:18 +0000 (10:39 -0400)] 
Update the cups-files.conf and cupsd.conf file documentation for missing
directives (Issue #5084)

6 years agoFix an Avahi-related crash bug in the scheduler (Issue #5085, Issue #5086)
Michael Sweet [Mon, 28 Aug 2017 14:04:29 +0000 (10:04 -0400)] 
Fix an Avahi-related crash bug in the scheduler (Issue #5085, Issue #5086)

Add NULL pointer check to avoid Avahi assertion in production code.

6 years agoFix compile issue for PID file stuff when no systemd/launchd/upstart is
Michael Sweet [Sun, 27 Aug 2017 14:59:38 +0000 (10:59 -0400)] 
Fix compile issue for PID file stuff when no systemd/launchd/upstart is
available.

Also restructure code slightly so it isn't so convoluted.

6 years agoFix sorting bug.
Michael Sweet [Sun, 27 Aug 2017 14:58:06 +0000 (10:58 -0400)] 
Fix sorting bug.

6 years agoThe IPP Everywhere PPD generator now sorts the supported resolutions before
Michael Sweet [Sun, 27 Aug 2017 14:40:30 +0000 (10:40 -0400)] 
The IPP Everywhere PPD generator now sorts the supported resolutions before
choosing them for draft, normal, and best quality modes (Issue #5091)

Also prefer urf-supported values over pwg-raster-document-xxx-supported values
since the former is more reliable than the latter.

6 years agoSupport internal "only TLS/1.0" option for tlscheck.
Michael Sweet [Fri, 25 Aug 2017 20:38:56 +0000 (16:38 -0400)] 
Support internal "only TLS/1.0" option for tlscheck.

Expand CBC filter on macOS.

Add support for --tls10 and --no-cbc options with tlscheck.

6 years agoMerge pull request #5081 from sblondon/master
Michael R Sweet [Fri, 25 Aug 2017 04:56:08 +0000 (00:56 -0400)] 
Merge pull request #5081 from sblondon/master

Update french translations

6 years agoUpdate changelog.
Michael Sweet [Wed, 9 Aug 2017 17:45:19 +0000 (13:45 -0400)] 
Update changelog.

6 years agoFix the localization fallback code on macOS (rdar://33583699)
Michael Sweet [Wed, 9 Aug 2017 17:43:08 +0000 (13:43 -0400)] 
Fix the localization fallback code on macOS (rdar://33583699)

6 years agoUpdate french translations 5081/head
Stephane Blondon [Sun, 6 Aug 2017 19:58:53 +0000 (21:58 +0200)] 
Update french translations

6 years agoAdd header validation option to ipptool.
Michael Sweet [Fri, 4 Aug 2017 16:52:43 +0000 (12:52 -0400)] 
Add header validation option to ipptool.

Update HTML versions of man pages.

6 years agoFix compiler warning.
Michael Sweet [Thu, 3 Aug 2017 18:00:17 +0000 (14:00 -0400)] 
Fix compiler warning.

6 years agoThe `ippCopyAttribute` function did not copy out-of-band values correctly
Michael Sweet [Wed, 2 Aug 2017 23:53:50 +0000 (19:53 -0400)] 
The `ippCopyAttribute` function did not copy out-of-band values correctly
(rdar://33688003)

6 years agoThe scheduler now creates a PID file when not running on demand with a modern
Michael Sweet [Tue, 1 Aug 2017 23:16:25 +0000 (19:16 -0400)] 
The scheduler now creates a PID file when not running on demand with a modern
service launcher (Issue #5080)

6 years agoUpdate localizations yet again based on IPP sample strings.
Michael Sweet [Tue, 1 Aug 2017 21:09:33 +0000 (17:09 -0400)] 
Update localizations yet again based on IPP sample strings.

6 years agoUpdate copyright.
Michael Sweet [Tue, 1 Aug 2017 04:29:21 +0000 (00:29 -0400)] 
Update copyright.

6 years agoFix default language for multi-language PPDs.
Michael Sweet [Tue, 1 Aug 2017 01:39:13 +0000 (21:39 -0400)] 
Fix default language for multi-language PPDs.

6 years agoFix the adminurl field in the TXT record for fully-qualified `ServerName`
Michael Sweet [Tue, 1 Aug 2017 01:29:20 +0000 (21:29 -0400)] 
Fix the adminurl field in the TXT record for fully-qualified `ServerName`
values (Issue #5074)

6 years agoFix the default ServerAlias value (Issue #5072)
Michael Sweet [Mon, 31 Jul 2017 21:55:01 +0000 (17:55 -0400)] 
Fix the default ServerAlias value (Issue #5072)

6 years agoUpdate localization files with corrections for IPP strings.
Michael Sweet [Mon, 31 Jul 2017 21:34:11 +0000 (17:34 -0400)] 
Update localization files with corrections for IPP strings.

6 years agoFix localizations of some media sizes and remove localizations of operation
Michael Sweet [Mon, 31 Jul 2017 18:59:06 +0000 (14:59 -0400)] 
Fix localizations of some media sizes and remove localizations of operation
names.

6 years agoClean up unit test.
Michael Sweet [Tue, 25 Jul 2017 22:26:20 +0000 (18:26 -0400)] 
Clean up unit test.

6 years agoAdd unit test that loops calling cupsGetDests.
Michael Sweet [Tue, 25 Jul 2017 22:18:14 +0000 (18:18 -0400)] 
Add unit test that loops calling cupsGetDests.

6 years agoAdd error checking for all Bonjour browsing in cupsEnumDests.
Michael Sweet [Tue, 25 Jul 2017 22:11:01 +0000 (18:11 -0400)] 
Add error checking for all Bonjour browsing in cupsEnumDests.

Clean up testcups unit tests.

6 years agoChangelog.
Michael Sweet [Tue, 25 Jul 2017 02:45:46 +0000 (22:45 -0400)] 
Changelog.

6 years agoRemove old API documentation files.
Michael Sweet [Tue, 25 Jul 2017 00:51:11 +0000 (20:51 -0400)] 
Remove old API documentation files.

6 years agoUse a 250ms delay for cupsGetDests - not perfect, but usually gets the full
Michael R Sweet [Tue, 25 Jul 2017 02:43:56 +0000 (22:43 -0400)] 
Use a 250ms delay for cupsGetDests - not perfect, but usually gets the full
list of local network printers (Issue #5049)

6 years agoTry a much shorter enum time for cupsGetDests (Issue #5049)
Michael Sweet [Mon, 24 Jul 2017 22:05:39 +0000 (18:05 -0400)] 
Try a much shorter enum time for cupsGetDests (Issue #5049)

6 years agoFix the `ServerTokens None` option (Issue #5065)
Michael Sweet [Mon, 24 Jul 2017 21:29:07 +0000 (17:29 -0400)] 
Fix the `ServerTokens None` option (Issue #5065)

6 years agoMerge pull request #5066 from sblondon/master
Michael R Sweet [Mon, 24 Jul 2017 15:21:14 +0000 (11:21 -0400)] 
Merge pull request #5066 from sblondon/master

Update french translations

6 years agoFix "DenyCBC" priority string with GNU TLS.
Michael R Sweet [Mon, 24 Jul 2017 00:02:57 +0000 (20:02 -0400)] 
Fix "DenyCBC" priority string with GNU TLS.

6 years agoUpdate french translations 5066/head
Stéphane Blondon [Sat, 22 Jul 2017 13:52:10 +0000 (15:52 +0200)] 
Update french translations

6 years agoThe scheduler's `-t` option did not force all errors to the standard error
Michael Sweet [Wed, 19 Jul 2017 19:37:30 +0000 (15:37 -0400)] 
The scheduler's `-t` option did not force all errors to the standard error
file, making debugging of configuration problems hard (Issue #5041)

6 years agoFix logging when "-t" is used (always to stderr).
Michael Sweet [Wed, 19 Jul 2017 19:29:01 +0000 (15:29 -0400)] 
Fix logging when "-t" is used (always to stderr).

6 years agoLower maximum poll()/select() time to 100ms (possible fix for Issue #5049)
Michael Sweet [Wed, 19 Jul 2017 18:28:11 +0000 (14:28 -0400)] 
Lower maximum poll()/select() time to 100ms (possible fix for Issue #5049)

6 years agoUpdate changelog.
Michael Sweet [Wed, 19 Jul 2017 18:26:08 +0000 (14:26 -0400)] 
Update changelog.

6 years agoChangelog.
Michael Sweet [Wed, 19 Jul 2017 18:19:40 +0000 (14:19 -0400)] 
Changelog.

6 years agoFix a build issue with `--enable-mallinfo` (Issue #5051)
Michael Sweet [Wed, 19 Jul 2017 18:12:41 +0000 (14:12 -0400)] 
Fix a build issue with `--enable-mallinfo` (Issue #5051)

6 years agoImplement standard localizations in cupsLocalizeDest* (Issue #5056)
Michael Sweet [Wed, 19 Jul 2017 17:55:32 +0000 (13:55 -0400)] 
Implement standard localizations in cupsLocalizeDest* (Issue #5056)
Add standard media size names to the localizations, too, since the PPD names
are not the right ones.

6 years agoAdd base IPP attribute/value localizations (Issue #5056)
Michael Sweet [Wed, 19 Jul 2017 16:35:41 +0000 (12:35 -0400)] 
Add base IPP attribute/value localizations (Issue #5056)

6 years agoThe `cupsGetNamedDest` function did not use the local default printer
Michael Sweet [Wed, 19 Jul 2017 12:15:08 +0000 (08:15 -0400)] 
The `cupsGetNamedDest` function did not use the local default printer
(rdar://33228500)

6 years agoChangelog for Issue #5054.
Michael Sweet [Wed, 19 Jul 2017 11:40:41 +0000 (07:40 -0400)] 
Changelog for Issue #5054.

6 years agoCUPS now sends the `Date` HTTP header in IPP requests (rdar://33302034)
Michael Sweet [Tue, 18 Jul 2017 15:55:15 +0000 (11:55 -0400)] 
CUPS now sends the `Date` HTTP header in IPP requests (rdar://33302034)

6 years agoFix the cups.strings file generation (bug in code that generates the Unicode
Michael Sweet [Tue, 18 Jul 2017 15:33:03 +0000 (11:33 -0400)] 
Fix the cups.strings file generation (bug in code that generates the Unicode
quotes), and add support for .strings files in checkpo so that we can validate
the results from now on (rdar://33287650)

6 years agoThe IPP backend incorrectly sent the "job-pages-per-set" attribute to PDF
Michael Sweet [Tue, 18 Jul 2017 14:10:16 +0000 (10:10 -0400)] 
The IPP backend incorrectly sent the "job-pages-per-set" attribute to PDF
printers (rdar://33250434)

Need to save the original number of copies and only send "job-pages-per-set"
when the copy count is reset to 1 (as happens when printing with a raster
format...)

6 years agoMerge pull request #5054 from sanbrother/master
Michael R Sweet [Tue, 18 Jul 2017 12:31:49 +0000 (08:31 -0400)] 
Merge pull request #5054 from sanbrother/master

Fix : dead lock when there is already an active job