]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commit
e2scrub_all: fix broken stdin redirection
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 5 Nov 2019 01:54:20 +0000 (17:54 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 10 Nov 2019 01:29:12 +0000 (20:29 -0500)
commit04335dbf327e4ecedc882237dc491a895e171f17
treec3d7cda70534eacd49d2dac987372108348c5c1d
parent333268d65d26fbb2d22f7a8b6ac797babcc69543
e2scrub_all: fix broken stdin redirection

gregor herrmann reports that the weekly e2scrub cronjob emits these
errors:

/sbin/e2scrub_all: line 173: /proc/8234/fd/pipe:[90083173]: No such file or directory

The root cause of this is that the ls_targets stdout is piped to stdin
to the entire ls_targets loop body to prevent the loop body from reading
the loop iteration items.  Remove all the broken hackery by reading the
target list into a bash array and iterating the bash array.

Addresses-Debian-Bug: #944033

Reported-by: gregor herrmann <gregoa@debian.org>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
scrub/e2scrub_all.in