]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commit
mmp: don't use O_RDWR in ext2fs_mmp_read
authorMarius Vollmer <mvollmer@redhat.com>
Wed, 24 Aug 2022 11:38:48 +0000 (14:38 +0300)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 24 Aug 2022 20:50:26 +0000 (16:50 -0400)
commit5cc83a2e5d2f3ec19462529c4144a2993b0c86e4
tree39267e4bc3d2d72cd35b8ba3b558a83fa8050be3
parent558146c31d341faae62237eafc0c260bd785a2d7
mmp: don't use O_RDWR in ext2fs_mmp_read

It doesn't seem to be necessary since ext2fs_mmp_write doesn't write
via mmp_fd, and opening the block device with O_RDWR will trigger
udev.

Triggering udev is bad because it leads to an infinite loop when
running dumpe2fs in response to a udev event.

[ Rebased onto the maint branch, and added O_RDONLY flag.  From the
  open(2) man page: "The argument flags must include one of the
  following access modes: O_RDONLY, O_WRONLY, or O_RDWR." -- TYT ]

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/mmp.c