]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
[core] Coverity 1325269 Dereference before null check 2233/head
authorJakub Karolczyk <jakub.karolczyk@signalwire.com>
Fri, 1 Sep 2023 10:23:28 +0000 (11:23 +0100)
committerJakub Karolczyk <jakub.karolczyk@signalwire.com>
Fri, 8 Sep 2023 16:54:33 +0000 (17:54 +0100)
src/switch_jitterbuffer.c

index 6f142aec6dcace828338da315ff9899f3f4727c0..655fa022c2f6911461db32d5274e596c624d4ef6 100644 (file)
@@ -1719,20 +1719,13 @@ SWITCH_DECLARE(switch_status_t) switch_jb_get_packet(switch_jb_t *jb, switch_rtp
                }
        }
 
-       if (node) {
-               status = SWITCH_STATUS_SUCCESS;
+       *packet = node->packet;
+       *len = node->len;
+       jb->last_len = *len;
+       packet->header.version = 2;
+       hide_node(node, SWITCH_TRUE);
 
-               *packet = node->packet;
-               *len = node->len;
-               jb->last_len = *len;
-               packet->header.version = 2;
-               hide_node(node, SWITCH_TRUE);
-
-               jb_debug(jb, 2, "GET packet ts:%u seq:%u %s\n", ntohl(packet->header.ts), ntohs(packet->header.seq), packet->header.m ? " <MARK>" : "");
-
-       } else {
-               status = SWITCH_STATUS_MORE_DATA;
-       }
+       jb_debug(jb, 2, "GET packet ts:%u seq:%u %s\n", ntohl(packet->header.ts), ntohs(packet->header.seq), packet->header.m ? " <MARK>" : "");
 
  end: