gcc-changelog: add more Review by prefixes.

contrib/ChangeLog:

	* gcc-changelog/git_commit.py: Add more supported prefixes.
	* gcc-changelog/test_email.py: Fix one flake8 error.
	* gcc-changelog/test_patches.txt: Add tested for newly
	supported prefixes.

diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 0b350ba7fdabfcc039e4ec85a7530034c44b47b3..eac648870532dc4ec275d2da822f64264abe176d 100755 (executable)
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -159,12 +159,10 @@ LINE_LIMIT = 100
 TAB_WIDTH = 8
 CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
 CHERRY_PICK_PREFIX = '(cherry picked from commit '
-REVIEWED_BY_PREFIX = 'reviewed-by: '
-REVIEWED_ON_PREFIX = 'reviewed-on: '
-SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
 
-REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,
-                   SIGNED_OFF_BY_PREFIX)
+REVIEW_PREFIXES = ('reviewed-by: ', 'reviewed-on: ', 'signed-off-by: ',
+                   'acked-by: ', 'tested-by: ', 'reported-by: ',
+                   'suggested-by: ')
 
 
 class Error:

diff --git a/contrib/gcc-changelog/test_email.py b/contrib/gcc-changelog/test_email.py
index df57bb5c94ac68218017a6c5afe7fe4f3fc8328f..c50687bc331c505e5e0ce25786c28a8b98e26c86 100755 (executable)
--- a/contrib/gcc-changelog/test_email.py
+++ b/contrib/gcc-changelog/test_email.py
@@ -161,8 +161,9 @@ class TestGccChangelog(unittest.TestCase):
 
     def test_additional_author_list(self):
         email = self.from_patch_glob('0342')
-        assert (email.errors[1].message == 'additional author must be indented '
-                                           'with one tab and four spaces')
+        msg = 'additional author must be indented ' \
+              'with one tab and four spaces'
+        assert email.errors[1].message == msg
 
     def test_trailing_whitespaces(self):
         email = self.get_git_email('trailing-whitespaces.patch')

diff --git a/contrib/gcc-changelog/test_patches.txt b/contrib/gcc-changelog/test_patches.txt
index 15fe0df1ccc0ad2b13e5a42999a78888b48d249b..1dec932f78315764591b8c8632f7fbdc842ac553 100644 (file)
--- a/contrib/gcc-changelog/test_patches.txt
+++ b/contrib/gcc-changelog/test_patches.txt
@@ -2430,6 +2430,10 @@ Signed-off-by: Keith Packard <keithp@keithp.com>
 Reviewed-by: Keith Packard <keithp@keithp.com>
 Reviewed-on: Keith Packard <keithp@keithp.com>
 Co-Authored-by: Keith Packard <keithp@keithp.com>
+Acked-By: Keith Packard <keithp@keithp.com>
+Tested-by: Keith Packard <keithp@keithp.com>
+Reported-by: Keith Packard <keithp@keithp.com>
+Suggested-by: Keith Packard <keithp@keithp.com>
 ---
  gcc/ChangeLog            |  5 +++++
  gcc/config/riscv/riscv.c | 40 ++++++++++++++++++++++++++++++++++++++++