]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Check for class type before assuming a type is one [PR103703].
authorMartin Sebor <msebor@redhat.com>
Thu, 16 Dec 2021 22:11:45 +0000 (15:11 -0700)
committerMartin Sebor <msebor@redhat.com>
Thu, 16 Dec 2021 22:11:45 +0000 (15:11 -0700)
Resolves:
PR c++/103703 - ICE with -Wmismatched-tags with friends and templates

gcc/cp/ChangeLog:

PR c++/103703
* parser.c (class_decl_loc_t::diag_mismatched_tags): Check for class
type before assuming a type is one.

gcc/testsuite/ChangeLog:

PR c++/103703
* g++.dg/warn/Wmismatched-tags-9.C: New test.

gcc/cp/parser.c
gcc/testsuite/g++.dg/warn/Wmismatched-tags-9.C [new file with mode: 0644]

index 5d72201f87c7eea0af4acb85998916e3e6d67548..9cf74357ac9e993e9fade3f451011af952146ea5 100644 (file)
@@ -33527,7 +33527,7 @@ class_decl_loc_t::diag_mismatched_tags (tree type_decl)
   class_decl_loc_t *cdlguide = this;
 
   tree type = TREE_TYPE (type_decl);
-  if (CLASSTYPE_IMPLICIT_INSTANTIATION (type))
+  if (CLASS_TYPE_P (type) && CLASSTYPE_IMPLICIT_INSTANTIATION (type))
     {
       /* For implicit instantiations of a primary template look up
         the primary or partial specialization and use it as
diff --git a/gcc/testsuite/g++.dg/warn/Wmismatched-tags-9.C b/gcc/testsuite/g++.dg/warn/Wmismatched-tags-9.C
new file mode 100644 (file)
index 0000000..2712c4d
--- /dev/null
@@ -0,0 +1,32 @@
+/* PR c++/103703 - ICE with -Wmismatched-tags with friends and templates
+   { dg-do compile }
+   { dg-options "-Wall -Wmismatched-tags" } */
+
+template <typename T>
+struct A
+{
+  struct B { };
+};
+
+template <typename T>
+struct C
+{
+  friend class A<C>::B;       // { dg-warning "-Wmismatched-tags" "pr102036" { xfail *-*-* } }
+};
+
+template struct C<int>;
+
+
+template <typename T>
+struct D
+{
+  friend class A<D>::B;       // okay, specialized as class below
+};
+
+template <>
+struct A<long>
+{
+  class B { };
+};
+
+template struct D<long>;