]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
x86: Rename -harden-sls=indirect-branch to -harden-sls=indirect-jmp
authorH.J. Lu <hjl.tools@gmail.com>
Thu, 6 Jan 2022 00:33:16 +0000 (16:33 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Thu, 6 Jan 2022 19:35:11 +0000 (11:35 -0800)
Indirect branch also includes indirect call instructions.  Rename
-harden-sls=indirect-branch to -harden-sls=indirect-jmp to match its
intended behavior.

PR target/102952
* config/i386/i386-opts.h (harden_sls): Replace
harden_sls_indirect_branch with harden_sls_indirect_jmp.
* config/i386/i386.c (ix86_output_jmp_thunk_or_indirect):
Likewise.
(ix86_output_indirect_jmp): Likewise.
(ix86_output_call_insn): Likewise.
* config/i386/i386.opt: Replace indirect-branch with
indirect-jmp.  Replace harden_sls_indirect_branch with
harden_sls_indirect_jmp.
* doc/invoke.texi (-harden-sls=): Replace indirect-branch with
indirect-jmp.

gcc/config/i386/i386-opts.h
gcc/config/i386/i386.c
gcc/config/i386/i386.opt
gcc/doc/invoke.texi

index b31f9506c3525bdcfccd9f9accc81da05b4b05de..8f71e89fa9ab9af99e5ff02c5f630382656401dd 100644 (file)
@@ -124,8 +124,8 @@ enum instrument_return {
 enum harden_sls {
   harden_sls_none = 0,
   harden_sls_return = 1 << 0,
-  harden_sls_indirect_branch = 1 << 1,
-  harden_sls_all = harden_sls_return | harden_sls_indirect_branch
+  harden_sls_indirect_jmp = 1 << 1,
+  harden_sls_all = harden_sls_return | harden_sls_indirect_jmp
 };
 
 #endif
index aeb7db5a5e39b114c82fe716b34b87ce49e81a47..736577585f76635510ed8c006b2585eacfb62cbe 100644 (file)
@@ -16052,7 +16052,7 @@ ix86_output_jmp_thunk_or_indirect (const char *thunk_name, const int regno)
       fprintf (asm_out_file, "\tjmp\t");
       assemble_name (asm_out_file, thunk_name);
       putc ('\n', asm_out_file);
-      if ((ix86_harden_sls & harden_sls_indirect_branch))
+      if ((ix86_harden_sls & harden_sls_indirect_jmp))
        fputs ("\tint3\n", asm_out_file);
     }
   else
@@ -16278,7 +16278,7 @@ ix86_output_indirect_jmp (rtx call_op)
     }
   else
     output_asm_insn ("%!jmp\t%A0", &call_op);
-  return (ix86_harden_sls & harden_sls_indirect_branch) ? "int3" : "";
+  return (ix86_harden_sls & harden_sls_indirect_jmp) ? "int3" : "";
 }
 
 /* Output return instrumentation for current function if needed.  */
@@ -16445,7 +16445,7 @@ ix86_output_call_insn (rtx_insn *insn, rtx call_op)
        {
          output_asm_insn (xasm, &call_op);
          if (!direct_p
-             && (ix86_harden_sls & harden_sls_indirect_branch))
+             && (ix86_harden_sls & harden_sls_indirect_jmp))
            return "int3";
        }
       return "";
index e69955bd1a8eded2b427decfab83dd6a098fcc2b..eb829d13d407dd85908eb5e81d797175d8badd04 100644 (file)
@@ -1144,7 +1144,7 @@ EnumValue
 Enum(harden_sls) String(return) Value(harden_sls_return)
 
 EnumValue
-Enum(harden_sls) String(indirect-branch) Value(harden_sls_indirect_branch)
+Enum(harden_sls) String(indirect-jmp) Value(harden_sls_indirect_jmp)
 
 EnumValue
 Enum(harden_sls) String(all) Value(harden_sls_all)
index 04820656ffaa0a0b234b495b1b2390317ee3a416..6b84228f14284d350cb0918e5cf2e6d24770e4cd 100644 (file)
@@ -32507,8 +32507,8 @@ Force indirect call and jump via register.
 @opindex mharden-sls
 Generate code to mitigate against straight line speculation (SLS) with
 @var{choice}.  The default is @samp{none} which disables all SLS
-hardening.  @samp{return} enables SLS hardening for function return.
-@samp{indirect-branch} enables SLS hardening for indirect branch.
+hardening.  @samp{return} enables SLS hardening for function returns.
+@samp{indirect-jmp} enables SLS hardening for indirect jumps.
 @samp{all} enables all SLS hardening.
 
 @item -mindirect-branch-cs-prefix