]> git.ipfire.org Git - thirdparty/git.git/blobdiff - upload-pack.c
The sixth batch
[thirdparty/git.git] / upload-pack.c
index 0478bff3e7fd11fdf89463a1f23cd2371de1b220..39d0cf00be70ec76368dfbce9a2efab5815aea47 100644 (file)
 #define ALL_FLAGS (THEY_HAVE | OUR_REF | WANTED | COMMON_KNOWN | SHALLOW | \
                NOT_SHALLOW | CLIENT_SHALLOW | HIDDEN_REF)
 
-static timestamp_t oldest_have;
-
-static int multi_ack;
-static int no_done;
-static int use_thin_pack, use_ofs_delta, use_include_tag;
-static int no_progress, daemon_mode;
-/* Allow specifying sha1 if it is a ref tip. */
-#define ALLOW_TIP_SHA1 01
-/* Allow request of a sha1 if it is reachable from a ref (possibly hidden ref). */
-#define ALLOW_REACHABLE_SHA1   02
-/* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and ALLOW_REACHABLE_SHA1. */
-#define ALLOW_ANY_SHA1 07
-static unsigned int allow_unadvertised_object_request;
-static int shallow_nr;
-static struct object_array extra_edge_obj;
-static unsigned int timeout;
-static int keepalive = 5;
-/* 0 for no sideband,
- * otherwise maximum packet size (up to 65520 bytes).
+/* Enum for allowed unadvertised object request (UOR) */
+enum allow_uor {
+       /* Allow specifying sha1 if it is a ref tip. */
+       ALLOW_TIP_SHA1 = 0x01,
+       /* Allow request of a sha1 if it is reachable from a ref (possibly hidden ref). */
+       ALLOW_REACHABLE_SHA1 = 0x02,
+       /* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and ALLOW_REACHABLE_SHA1. */
+       ALLOW_ANY_SHA1 = 0x07
+};
+
+/*
+ * Please annotate, and if possible group together, fields used only
+ * for protocol v0 or only for protocol v2.
  */
-static int use_sideband;
-static int stateless_rpc;
-static const char *pack_objects_hook;
+struct upload_pack_data {
+       struct string_list symref;                              /* v0 only */
+       struct object_array want_obj;
+       struct object_array have_obj;
+       struct oid_array haves;                                 /* v2 only */
+       struct string_list wanted_refs;                         /* v2 only */
+
+       struct object_array shallows;
+       struct string_list deepen_not;
+       struct object_array extra_edge_obj;
+       int depth;
+       timestamp_t deepen_since;
+       int deepen_rev_list;
+       int deepen_relative;
+       int keepalive;
+       int shallow_nr;
+       timestamp_t oldest_have;
+
+       unsigned int timeout;                                   /* v0 only */
+       enum {
+               NO_MULTI_ACK = 0,
+               MULTI_ACK = 1,
+               MULTI_ACK_DETAILED = 2
+       } multi_ack;                                            /* v0 only */
 
-static int filter_capability_requested;
-static int allow_filter;
-static int allow_ref_in_want;
+       /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
+       int use_sideband;
 
-static int allow_sideband_all;
+       struct string_list uri_protocols;
+       enum allow_uor allow_uor;
+
+       struct list_objects_filter_options filter_options;
+
+       struct packet_writer writer;
+
+       const char *pack_objects_hook;
+
+       unsigned stateless_rpc : 1;                             /* v0 only */
+       unsigned no_done : 1;                                   /* v0 only */
+       unsigned daemon_mode : 1;                               /* v0 only */
+       unsigned filter_capability_requested : 1;               /* v0 only */
+
+       unsigned use_thin_pack : 1;
+       unsigned use_ofs_delta : 1;
+       unsigned no_progress : 1;
+       unsigned use_include_tag : 1;
+       unsigned allow_filter : 1;
 
-static void reset_timeout(void)
+       unsigned done : 1;                                      /* v2 only */
+       unsigned allow_ref_in_want : 1;                         /* v2 only */
+       unsigned allow_sideband_all : 1;                        /* v2 only */
+};
+
+static void upload_pack_data_init(struct upload_pack_data *data)
+{
+       struct string_list symref = STRING_LIST_INIT_DUP;
+       struct string_list wanted_refs = STRING_LIST_INIT_DUP;
+       struct object_array want_obj = OBJECT_ARRAY_INIT;
+       struct object_array have_obj = OBJECT_ARRAY_INIT;
+       struct oid_array haves = OID_ARRAY_INIT;
+       struct object_array shallows = OBJECT_ARRAY_INIT;
+       struct string_list deepen_not = STRING_LIST_INIT_DUP;
+       struct string_list uri_protocols = STRING_LIST_INIT_DUP;
+       struct object_array extra_edge_obj = OBJECT_ARRAY_INIT;
+
+       memset(data, 0, sizeof(*data));
+       data->symref = symref;
+       data->wanted_refs = wanted_refs;
+       data->want_obj = want_obj;
+       data->have_obj = have_obj;
+       data->haves = haves;
+       data->shallows = shallows;
+       data->deepen_not = deepen_not;
+       data->uri_protocols = uri_protocols;
+       data->extra_edge_obj = extra_edge_obj;
+       packet_writer_init(&data->writer, 1);
+
+       data->keepalive = 5;
+}
+
+static void upload_pack_data_clear(struct upload_pack_data *data)
+{
+       string_list_clear(&data->symref, 1);
+       string_list_clear(&data->wanted_refs, 1);
+       object_array_clear(&data->want_obj);
+       object_array_clear(&data->have_obj);
+       oid_array_clear(&data->haves);
+       object_array_clear(&data->shallows);
+       string_list_clear(&data->deepen_not, 0);
+       object_array_clear(&data->extra_edge_obj);
+       list_objects_filter_release(&data->filter_options);
+
+       free((char *)data->pack_objects_hook);
+}
+
+static void reset_timeout(unsigned int timeout)
 {
        alarm(timeout);
 }
 
-static void send_client_data(int fd, const char *data, ssize_t sz)
+static void send_client_data(int fd, const char *data, ssize_t sz,
+                            int use_sideband)
 {
        if (use_sideband) {
                send_sideband(1, fd, data, sz, use_sideband);
@@ -102,48 +182,119 @@ static int write_one_shallow(const struct commit_graft *graft, void *cb_data)
        return 0;
 }
 
-static void create_pack_file(const struct object_array *have_obj,
-                            const struct object_array *want_obj,
-                            struct list_objects_filter_options *filter_options)
+struct output_state {
+       char buffer[8193];
+       int used;
+       unsigned packfile_uris_started : 1;
+       unsigned packfile_started : 1;
+};
+
+static int relay_pack_data(int pack_objects_out, struct output_state *os,
+                          int use_sideband, int write_packfile_line)
+{
+       /*
+        * We keep the last byte to ourselves
+        * in case we detect broken rev-list, so that we
+        * can leave the stream corrupted.  This is
+        * unfortunate -- unpack-objects would happily
+        * accept a valid packdata with trailing garbage,
+        * so appending garbage after we pass all the
+        * pack data is not good enough to signal
+        * breakage to downstream.
+        */
+       ssize_t readsz;
+
+       readsz = xread(pack_objects_out, os->buffer + os->used,
+                      sizeof(os->buffer) - os->used);
+       if (readsz < 0) {
+               return readsz;
+       }
+       os->used += readsz;
+
+       while (!os->packfile_started) {
+               char *p;
+               if (os->used >= 4 && !memcmp(os->buffer, "PACK", 4)) {
+                       os->packfile_started = 1;
+                       if (write_packfile_line) {
+                               if (os->packfile_uris_started)
+                                       packet_delim(1);
+                               packet_write_fmt(1, "\1packfile\n");
+                       }
+                       break;
+               }
+               if ((p = memchr(os->buffer, '\n', os->used))) {
+                       if (!os->packfile_uris_started) {
+                               os->packfile_uris_started = 1;
+                               if (!write_packfile_line)
+                                       BUG("packfile_uris requires sideband-all");
+                               packet_write_fmt(1, "\1packfile-uris\n");
+                       }
+                       *p = '\0';
+                       packet_write_fmt(1, "\1%s\n", os->buffer);
+
+                       os->used -= p - os->buffer + 1;
+                       memmove(os->buffer, p + 1, os->used);
+               } else {
+                       /*
+                        * Incomplete line.
+                        */
+                       return readsz;
+               }
+       }
+
+       if (os->used > 1) {
+               send_client_data(1, os->buffer, os->used - 1, use_sideband);
+               os->buffer[0] = os->buffer[os->used - 1];
+               os->used = 1;
+       } else {
+               send_client_data(1, os->buffer, os->used, use_sideband);
+               os->used = 0;
+       }
+
+       return readsz;
+}
+
+static void create_pack_file(struct upload_pack_data *pack_data,
+                            const struct string_list *uri_protocols)
 {
        struct child_process pack_objects = CHILD_PROCESS_INIT;
-       char data[8193], progress[128];
+       struct output_state output_state = { { 0 } };
+       char progress[128];
        char abort_msg[] = "aborting due to possible repository "
                "corruption on the remote side.";
-       int buffered = -1;
        ssize_t sz;
        int i;
        FILE *pipe_fd;
 
-       if (!pack_objects_hook)
+       if (!pack_data->pack_objects_hook)
                pack_objects.git_cmd = 1;
        else {
-               argv_array_push(&pack_objects.args, pack_objects_hook);
+               argv_array_push(&pack_objects.args, pack_data->pack_objects_hook);
                argv_array_push(&pack_objects.args, "git");
                pack_objects.use_shell = 1;
        }
 
-       if (shallow_nr) {
+       if (pack_data->shallow_nr) {
                argv_array_push(&pack_objects.args, "--shallow-file");
                argv_array_push(&pack_objects.args, "");
        }
        argv_array_push(&pack_objects.args, "pack-objects");
        argv_array_push(&pack_objects.args, "--revs");
-       if (use_thin_pack)
+       if (pack_data->use_thin_pack)
                argv_array_push(&pack_objects.args, "--thin");
 
        argv_array_push(&pack_objects.args, "--stdout");
-       if (shallow_nr)
+       if (pack_data->shallow_nr)
                argv_array_push(&pack_objects.args, "--shallow");
-       if (!no_progress)
+       if (!pack_data->no_progress)
                argv_array_push(&pack_objects.args, "--progress");
-       if (use_ofs_delta)
+       if (pack_data->use_ofs_delta)
                argv_array_push(&pack_objects.args, "--delta-base-offset");
-       if (use_include_tag)
+       if (pack_data->use_include_tag)
                argv_array_push(&pack_objects.args, "--include-tag");
-       if (filter_options->choice) {
+       if (pack_data->filter_options.choice) {
                const char *spec =
-                       expand_list_objects_filter_spec(filter_options);
+                       expand_list_objects_filter_spec(&pack_data->filter_options);
                if (pack_objects.use_shell) {
                        struct strbuf buf = STRBUF_INIT;
                        sq_quote_buf(&buf, spec);
@@ -154,6 +305,11 @@ static void create_pack_file(const struct object_array *have_obj,
                                         spec);
                }
        }
+       if (uri_protocols) {
+               for (i = 0; i < uri_protocols->nr; i++)
+                       argv_array_pushf(&pack_objects.args, "--uri-protocol=%s",
+                                        uri_protocols->items[i].string);
+       }
 
        pack_objects.in = -1;
        pack_objects.out = -1;
@@ -164,19 +320,19 @@ static void create_pack_file(const struct object_array *have_obj,
 
        pipe_fd = xfdopen(pack_objects.in, "w");
 
-       if (shallow_nr)
+       if (pack_data->shallow_nr)
                for_each_commit_graft(write_one_shallow, pipe_fd);
 
-       for (i = 0; i < want_obj->nr; i++)
+       for (i = 0; i < pack_data->want_obj.nr; i++)
                fprintf(pipe_fd, "%s\n",
-                       oid_to_hex(&want_obj->objects[i].item->oid));
+                       oid_to_hex(&pack_data->want_obj.objects[i].item->oid));
        fprintf(pipe_fd, "--not\n");
-       for (i = 0; i < have_obj->nr; i++)
+       for (i = 0; i < pack_data->have_obj.nr; i++)
                fprintf(pipe_fd, "%s\n",
-                       oid_to_hex(&have_obj->objects[i].item->oid));
-       for (i = 0; i < extra_edge_obj.nr; i++)
+                       oid_to_hex(&pack_data->have_obj.objects[i].item->oid));
+       for (i = 0; i < pack_data->extra_edge_obj.nr; i++)
                fprintf(pipe_fd, "%s\n",
-                       oid_to_hex(&extra_edge_obj.objects[i].item->oid));
+                       oid_to_hex(&pack_data->extra_edge_obj.objects[i].item->oid));
        fprintf(pipe_fd, "\n");
        fflush(pipe_fd);
        fclose(pipe_fd);
@@ -187,10 +343,10 @@ static void create_pack_file(const struct object_array *have_obj,
 
        while (1) {
                struct pollfd pfd[2];
-               int pe, pu, pollsize;
+               int pe, pu, pollsize, polltimeout;
                int ret;
 
-               reset_timeout();
+               reset_timeout(pack_data->timeout);
 
                pollsize = 0;
                pe = pu = -1;
@@ -211,8 +367,11 @@ static void create_pack_file(const struct object_array *have_obj,
                if (!pollsize)
                        break;
 
-               ret = poll(pfd, pollsize,
-                       keepalive < 0 ? -1 : 1000 * keepalive);
+               polltimeout = pack_data->keepalive < 0
+                       ? -1
+                       : 1000 * pack_data->keepalive;
+
+               ret = poll(pfd, pollsize, polltimeout);
 
                if (ret < 0) {
                        if (errno != EINTR) {
@@ -228,7 +387,8 @@ static void create_pack_file(const struct object_array *have_obj,
                        sz = xread(pack_objects.err, progress,
                                  sizeof(progress));
                        if (0 < sz)
-                               send_client_data(2, progress, sz);
+                               send_client_data(2, progress, sz,
+                                                pack_data->use_sideband);
                        else if (sz == 0) {
                                close(pack_objects.err);
                                pack_objects.err = -1;
@@ -239,39 +399,17 @@ static void create_pack_file(const struct object_array *have_obj,
                        continue;
                }
                if (0 <= pu && (pfd[pu].revents & (POLLIN|POLLHUP))) {
-                       /* Data ready; we keep the last byte to ourselves
-                        * in case we detect broken rev-list, so that we
-                        * can leave the stream corrupted.  This is
-                        * unfortunate -- unpack-objects would happily
-                        * accept a valid packdata with trailing garbage,
-                        * so appending garbage after we pass all the
-                        * pack data is not good enough to signal
-                        * breakage to downstream.
-                        */
-                       char *cp = data;
-                       ssize_t outsz = 0;
-                       if (0 <= buffered) {
-                               *cp++ = buffered;
-                               outsz++;
-                       }
-                       sz = xread(pack_objects.out, cp,
-                                 sizeof(data) - outsz);
-                       if (0 < sz)
-                               ;
-                       else if (sz == 0) {
+                       int result = relay_pack_data(pack_objects.out,
+                                                    &output_state,
+                                                    pack_data->use_sideband,
+                                                    !!uri_protocols);
+
+                       if (result == 0) {
                                close(pack_objects.out);
                                pack_objects.out = -1;
-                       }
-                       else
+                       } else if (result < 0) {
                                goto fail;
-                       sz += outsz;
-                       if (1 < sz) {
-                               buffered = data[sz-1] & 0xFF;
-                               sz--;
                        }
-                       else
-                               buffered = -1;
-                       send_client_data(1, data, sz);
                }
 
                /*
@@ -284,7 +422,7 @@ static void create_pack_file(const struct object_array *have_obj,
                 * protocol to say anything, so those clients are just out of
                 * luck.
                 */
-               if (!ret && use_sideband) {
+               if (!ret && pack_data->use_sideband) {
                        static const char buf[] = "0005\1";
                        write_or_die(1, buf, 5);
                }
@@ -296,32 +434,26 @@ static void create_pack_file(const struct object_array *have_obj,
        }
 
        /* flush the data */
-       if (0 <= buffered) {
-               data[0] = buffered;
-               send_client_data(1, data, 1);
+       if (output_state.used > 0) {
+               send_client_data(1, output_state.buffer, output_state.used,
+                                pack_data->use_sideband);
                fprintf(stderr, "flushed.\n");
        }
-       if (use_sideband)
+       if (pack_data->use_sideband)
                packet_flush(1);
        return;
 
  fail:
-       send_client_data(3, abort_msg, sizeof(abort_msg));
+       send_client_data(3, abort_msg, sizeof(abort_msg),
+                        pack_data->use_sideband);
        die("git upload-pack: %s", abort_msg);
 }
 
-static int got_oid(const char *hex, struct object_id *oid,
-                  struct object_array *have_obj)
+static int do_got_oid(struct upload_pack_data *data, const struct object_id *oid)
 {
-       struct object *o;
        int we_knew_they_have = 0;
+       struct object *o = parse_object(the_repository, oid);
 
-       if (get_oid_hex(hex, oid))
-               die("git upload-pack: expected SHA1 object, got '%s'", hex);
-       if (!has_object_file(oid))
-               return -1;
-
-       o = parse_object(the_repository, oid);
        if (!o)
                die("oops (%s)", oid_to_hex(oid));
        if (o->type == OBJ_COMMIT) {
@@ -331,36 +463,44 @@ static int got_oid(const char *hex, struct object_id *oid,
                        we_knew_they_have = 1;
                else
                        o->flags |= THEY_HAVE;
-               if (!oldest_have || (commit->date < oldest_have))
-                       oldest_have = commit->date;
+               if (!data->oldest_have || (commit->date < data->oldest_have))
+                       data->oldest_have = commit->date;
                for (parents = commit->parents;
                     parents;
                     parents = parents->next)
                        parents->item->object.flags |= THEY_HAVE;
        }
        if (!we_knew_they_have) {
-               add_object_array(o, NULL, have_obj);
+               add_object_array(o, NULL, &data->have_obj);
                return 1;
        }
        return 0;
 }
 
-static int ok_to_give_up(const struct object_array *have_obj,
-                        struct object_array *want_obj)
+static int got_oid(struct upload_pack_data *data,
+                  const char *hex, struct object_id *oid)
+{
+       if (get_oid_hex(hex, oid))
+               die("git upload-pack: expected SHA1 object, got '%s'", hex);
+       if (!has_object_file(oid))
+               return -1;
+       return do_got_oid(data, oid);
+}
+
+static int ok_to_give_up(struct upload_pack_data *data)
 {
        uint32_t min_generation = GENERATION_NUMBER_ZERO;
 
-       if (!have_obj->nr)
+       if (!data->have_obj.nr)
                return 0;
 
-       return can_all_from_reach_with_flag(want_obj, THEY_HAVE,
-                                           COMMON_KNOWN, oldest_have,
+       return can_all_from_reach_with_flag(&data->want_obj, THEY_HAVE,
+                                           COMMON_KNOWN, data->oldest_have,
                                            min_generation);
 }
 
-static int get_common_commits(struct packet_reader *reader,
-                             struct object_array *have_obj,
-                             struct object_array *want_obj)
+static int get_common_commits(struct upload_pack_data *data,
+                             struct packet_reader *reader)
 {
        struct object_id oid;
        char last_hex[GIT_MAX_HEXSZ + 1];
@@ -373,34 +513,37 @@ static int get_common_commits(struct packet_reader *reader,
        for (;;) {
                const char *arg;
 
-               reset_timeout();
+               reset_timeout(data->timeout);
 
                if (packet_reader_read(reader) != PACKET_READ_NORMAL) {
-                       if (multi_ack == 2 && got_common
-                           && !got_other && ok_to_give_up(have_obj, want_obj)) {
+                       if (data->multi_ack == MULTI_ACK_DETAILED
+                           && got_common
+                           && !got_other
+                           && ok_to_give_up(data)) {
                                sent_ready = 1;
                                packet_write_fmt(1, "ACK %s ready\n", last_hex);
                        }
-                       if (have_obj->nr == 0 || multi_ack)
+                       if (data->have_obj.nr == 0 || data->multi_ack)
                                packet_write_fmt(1, "NAK\n");
 
-                       if (no_done && sent_ready) {
+                       if (data->no_done && sent_ready) {
                                packet_write_fmt(1, "ACK %s\n", last_hex);
                                return 0;
                        }
-                       if (stateless_rpc)
+                       if (data->stateless_rpc)
                                exit(0);
                        got_common = 0;
                        got_other = 0;
                        continue;
                }
                if (skip_prefix(reader->line, "have ", &arg)) {
-                       switch (got_oid(arg, &oid, have_obj)) {
+                       switch (got_oid(data, arg, &oid)) {
                        case -1: /* they have what we do not */
                                got_other = 1;
-                               if (multi_ack && ok_to_give_up(have_obj, want_obj)) {
+                               if (data->multi_ack
+                                   && ok_to_give_up(data)) {
                                        const char *hex = oid_to_hex(&oid);
-                                       if (multi_ack == 2) {
+                                       if (data->multi_ack == MULTI_ACK_DETAILED) {
                                                sent_ready = 1;
                                                packet_write_fmt(1, "ACK %s ready\n", hex);
                                        } else
@@ -410,19 +553,19 @@ static int get_common_commits(struct packet_reader *reader,
                        default:
                                got_common = 1;
                                oid_to_hex_r(last_hex, &oid);
-                               if (multi_ack == 2)
+                               if (data->multi_ack == MULTI_ACK_DETAILED)
                                        packet_write_fmt(1, "ACK %s common\n", last_hex);
-                               else if (multi_ack)
+                               else if (data->multi_ack)
                                        packet_write_fmt(1, "ACK %s continue\n", last_hex);
-                               else if (have_obj->nr == 1)
+                               else if (data->have_obj.nr == 1)
                                        packet_write_fmt(1, "ACK %s\n", last_hex);
                                break;
                        }
                        continue;
                }
                if (!strcmp(reader->line, "done")) {
-                       if (have_obj->nr > 0) {
-                               if (multi_ack)
+                       if (data->have_obj.nr > 0) {
+                               if (data->multi_ack)
                                        packet_write_fmt(1, "ACK %s\n", last_hex);
                                return 0;
                        }
@@ -433,10 +576,10 @@ static int get_common_commits(struct packet_reader *reader,
        }
 }
 
-static int is_our_ref(struct object *o)
+static int is_our_ref(struct object *o, enum allow_uor allow_uor)
 {
-       int allow_hidden_ref = (allow_unadvertised_object_request &
-                       (ALLOW_TIP_SHA1 | ALLOW_REACHABLE_SHA1));
+       int allow_hidden_ref = (allow_uor &
+                               (ALLOW_TIP_SHA1 | ALLOW_REACHABLE_SHA1));
        return o->flags & ((allow_hidden_ref ? HIDDEN_REF : 0) | OUR_REF);
 }
 
@@ -445,7 +588,8 @@ static int is_our_ref(struct object *o)
  */
 static int do_reachable_revlist(struct child_process *cmd,
                                struct object_array *src,
-                               struct object_array *reachable)
+                               struct object_array *reachable,
+                               enum allow_uor allow_uor)
 {
        static const char *argv[] = {
                "rev-list", "--stdin", NULL,
@@ -479,7 +623,7 @@ static int do_reachable_revlist(struct child_process *cmd,
                        continue;
                if (reachable && o->type == OBJ_COMMIT)
                        o->flags &= ~TMP_MARK;
-               if (!is_our_ref(o))
+               if (!is_our_ref(o, allow_uor))
                        continue;
                memcpy(namebuf + 1, oid_to_hex(&o->oid), hexsz);
                if (write_in_full(cmd->in, namebuf, hexsz + 2) < 0)
@@ -488,7 +632,7 @@ static int do_reachable_revlist(struct child_process *cmd,
        namebuf[hexsz] = '\n';
        for (i = 0; i < src->nr; i++) {
                o = src->objects[i].item;
-               if (is_our_ref(o)) {
+               if (is_our_ref(o, allow_uor)) {
                        if (reachable)
                                add_object_array(o, NULL, reachable);
                        continue;
@@ -515,7 +659,7 @@ error:
        return -1;
 }
 
-static int get_reachable_list(struct object_array *src,
+static int get_reachable_list(struct upload_pack_data *data,
                              struct object_array *reachable)
 {
        struct child_process cmd = CHILD_PROCESS_INIT;
@@ -524,7 +668,8 @@ static int get_reachable_list(struct object_array *src,
        char namebuf[GIT_MAX_HEXSZ + 2]; /* ^ + hash + LF */
        const unsigned hexsz = the_hash_algo->hexsz;
 
-       if (do_reachable_revlist(&cmd, src, reachable) < 0)
+       if (do_reachable_revlist(&cmd, &data->shallows, reachable,
+                                data->allow_uor) < 0)
                return -1;
 
        while ((i = read_in_full(cmd.out, namebuf, hexsz + 1)) == hexsz + 1) {
@@ -555,13 +700,13 @@ static int get_reachable_list(struct object_array *src,
        return 0;
 }
 
-static int has_unreachable(struct object_array *src)
+static int has_unreachable(struct object_array *src, enum allow_uor allow_uor)
 {
        struct child_process cmd = CHILD_PROCESS_INIT;
        char buf[1];
        int i;
 
-       if (do_reachable_revlist(&cmd, src, NULL) < 0)
+       if (do_reachable_revlist(&cmd, src, NULL, allow_uor) < 0)
                return 1;
 
        /*
@@ -592,8 +737,7 @@ error:
        return 1;
 }
 
-static void check_non_tip(struct object_array *want_obj,
-                         struct packet_writer *writer)
+static void check_non_tip(struct upload_pack_data *data)
 {
        int i;
 
@@ -602,18 +746,18 @@ static void check_non_tip(struct object_array *want_obj,
         * uploadpack.allowReachableSHA1InWant,
         * non-tip requests can never happen.
         */
-       if (!stateless_rpc && !(allow_unadvertised_object_request & ALLOW_REACHABLE_SHA1))
+       if (!data->stateless_rpc && !(data->allow_uor & ALLOW_REACHABLE_SHA1))
                goto error;
-       if (!has_unreachable(want_obj))
+       if (!has_unreachable(&data->want_obj, data->allow_uor))
                /* All the non-tip ones are ancestors of what we advertised */
                return;
 
 error:
        /* Pick one of them (we know there at least is one) */
-       for (i = 0; i < want_obj->nr; i++) {
-               struct object *o = want_obj->objects[i].item;
-               if (!is_our_ref(o)) {
-                       packet_writer_error(writer,
+       for (i = 0; i < data->want_obj.nr; i++) {
+               struct object *o = data->want_obj.objects[i].item;
+               if (!is_our_ref(o, data->allow_uor)) {
+                       packet_writer_error(&data->writer,
                                            "upload-pack: not our ref %s",
                                            oid_to_hex(&o->oid));
                        die("git upload-pack: not our ref %s",
@@ -622,32 +766,30 @@ error:
        }
 }
 
-static void send_shallow(struct packet_writer *writer,
+static void send_shallow(struct upload_pack_data *data,
                         struct commit_list *result)
 {
        while (result) {
                struct object *object = &result->item->object;
                if (!(object->flags & (CLIENT_SHALLOW|NOT_SHALLOW))) {
-                       packet_writer_write(writer, "shallow %s",
+                       packet_writer_write(&data->writer, "shallow %s",
                                            oid_to_hex(&object->oid));
                        register_shallow(the_repository, &object->oid);
-                       shallow_nr++;
+                       data->shallow_nr++;
                }
                result = result->next;
        }
 }
 
-static void send_unshallow(struct packet_writer *writer,
-                          const struct object_array *shallows,
-                          struct object_array *want_obj)
+static void send_unshallow(struct upload_pack_data *data)
 {
        int i;
 
-       for (i = 0; i < shallows->nr; i++) {
-               struct object *object = shallows->objects[i].item;
+       for (i = 0; i < data->shallows.nr; i++) {
+               struct object *object = data->shallows.objects[i].item;
                if (object->flags & NOT_SHALLOW) {
                        struct commit_list *parents;
-                       packet_writer_write(writer, "unshallow %s",
+                       packet_writer_write(&data->writer, "unshallow %s",
                                            oid_to_hex(&object->oid));
                        object->flags &= ~CLIENT_SHALLOW;
                        /*
@@ -663,10 +805,10 @@ static void send_unshallow(struct packet_writer *writer,
                        parents = ((struct commit *)object)->parents;
                        while (parents) {
                                add_object_array(&parents->item->object,
-                                                NULL, want_obj);
+                                                NULL, &data->want_obj);
                                parents = parents->next;
                        }
-                       add_object_array(object, NULL, &extra_edge_obj);
+                       add_object_array(object, NULL, &data->extra_edge_obj);
                }
                /* make sure commit traversal conforms to client */
                register_shallow(the_repository, &object->oid);
@@ -675,17 +817,16 @@ static void send_unshallow(struct packet_writer *writer,
 
 static int check_ref(const char *refname_full, const struct object_id *oid,
                     int flag, void *cb_data);
-static void deepen(struct packet_writer *writer, int depth, int deepen_relative,
-                  struct object_array *shallows, struct object_array *want_obj)
+static void deepen(struct upload_pack_data *data, int depth)
 {
        if (depth == INFINITE_DEPTH && !is_repository_shallow(the_repository)) {
                int i;
 
-               for (i = 0; i < shallows->nr; i++) {
-                       struct object *object = shallows->objects[i].item;
+               for (i = 0; i < data->shallows.nr; i++) {
+                       struct object *object = data->shallows.objects[i].item;
                        object->flags |= NOT_SHALLOW;
                }
-       } else if (deepen_relative) {
+       } else if (data->deepen_relative) {
                struct object_array reachable_shallows = OBJECT_ARRAY_INIT;
                struct commit_list *result;
 
@@ -696,87 +837,80 @@ static void deepen(struct packet_writer *writer, int depth, int deepen_relative,
                head_ref_namespaced(check_ref, NULL);
                for_each_namespaced_ref(check_ref, NULL);
 
-               get_reachable_list(shallows, &reachable_shallows);
+               get_reachable_list(data, &reachable_shallows);
                result = get_shallow_commits(&reachable_shallows,
                                             depth + 1,
                                             SHALLOW, NOT_SHALLOW);
-               send_shallow(writer, result);
+               send_shallow(data, result);
                free_commit_list(result);
                object_array_clear(&reachable_shallows);
        } else {
                struct commit_list *result;
 
-               result = get_shallow_commits(want_obj, depth,
+               result = get_shallow_commits(&data->want_obj, depth,
                                             SHALLOW, NOT_SHALLOW);
-               send_shallow(writer, result);
+               send_shallow(data, result);
                free_commit_list(result);
        }
 
-       send_unshallow(writer, shallows, want_obj);
+       send_unshallow(data);
 }
 
-static void deepen_by_rev_list(struct packet_writer *writer, int ac,
-                              const char **av,
-                              struct object_array *shallows,
-                              struct object_array *want_obj)
+static void deepen_by_rev_list(struct upload_pack_data *data,
+                              int ac,
+                              const char **av)
 {
        struct commit_list *result;
 
        disable_commit_graph(the_repository);
        result = get_shallow_commits_by_rev_list(ac, av, SHALLOW, NOT_SHALLOW);
-       send_shallow(writer, result);
+       send_shallow(data, result);
        free_commit_list(result);
-       send_unshallow(writer, shallows, want_obj);
+       send_unshallow(data);
 }
 
 /* Returns 1 if a shallow list is sent or 0 otherwise */
-static int send_shallow_list(struct packet_writer *writer,
-                            int depth, int deepen_rev_list,
-                            timestamp_t deepen_since,
-                            struct string_list *deepen_not,
-                            int deepen_relative,
-                            struct object_array *shallows,
-                            struct object_array *want_obj)
+static int send_shallow_list(struct upload_pack_data *data)
 {
        int ret = 0;
 
-       if (depth > 0 && deepen_rev_list)
+       if (data->depth > 0 && data->deepen_rev_list)
                die("git upload-pack: deepen and deepen-since (or deepen-not) cannot be used together");
-       if (depth > 0) {
-               deepen(writer, depth, deepen_relative, shallows, want_obj);
+       if (data->depth > 0) {
+               deepen(data, data->depth);
                ret = 1;
-       } else if (deepen_rev_list) {
+       } else if (data->deepen_rev_list) {
                struct argv_array av = ARGV_ARRAY_INIT;
                int i;
 
                argv_array_push(&av, "rev-list");
-               if (deepen_since)
-                       argv_array_pushf(&av, "--max-age=%"PRItime, deepen_since);
-               if (deepen_not->nr) {
+               if (data->deepen_since)
+                       argv_array_pushf(&av, "--max-age=%"PRItime, data->deepen_since);
+               if (data->deepen_not.nr) {
                        argv_array_push(&av, "--not");
-                       for (i = 0; i < deepen_not->nr; i++) {
-                               struct string_list_item *s = deepen_not->items + i;
+                       for (i = 0; i < data->deepen_not.nr; i++) {
+                               struct string_list_item *s = data->deepen_not.items + i;
                                argv_array_push(&av, s->string);
                        }
                        argv_array_push(&av, "--not");
                }
-               for (i = 0; i < want_obj->nr; i++) {
-                       struct object *o = want_obj->objects[i].item;
+               for (i = 0; i < data->want_obj.nr; i++) {
+                       struct object *o = data->want_obj.objects[i].item;
                        argv_array_push(&av, oid_to_hex(&o->oid));
                }
-               deepen_by_rev_list(writer, av.argc, av.argv, shallows, want_obj);
+               deepen_by_rev_list(data, av.argc, av.argv);
                argv_array_clear(&av);
                ret = 1;
        } else {
-               if (shallows->nr > 0) {
+               if (data->shallows.nr > 0) {
                        int i;
-                       for (i = 0; i < shallows->nr; i++)
+                       for (i = 0; i < data->shallows.nr; i++)
                                register_shallow(the_repository,
-                                                &shallows->objects[i].item->oid);
+                                                &data->shallows.objects[i].item->oid);
                }
        }
 
-       shallow_nr += shallows->nr;
+       data->shallow_nr += data->shallows.nr;
        return ret;
 }
 
@@ -849,45 +983,36 @@ static int process_deepen_not(const char *line, struct string_list *deepen_not,
        return 0;
 }
 
-static void receive_needs(struct packet_reader *reader,
-                         struct object_array *want_obj,
-                         struct list_objects_filter_options *filter_options)
+static void receive_needs(struct upload_pack_data *data,
+                         struct packet_reader *reader)
 {
-       struct object_array shallows = OBJECT_ARRAY_INIT;
-       struct string_list deepen_not = STRING_LIST_INIT_DUP;
-       int depth = 0;
        int has_non_tip = 0;
-       timestamp_t deepen_since = 0;
-       int deepen_rev_list = 0;
-       int deepen_relative = 0;
-       struct packet_writer writer;
 
-       shallow_nr = 0;
-       packet_writer_init(&writer, 1);
+       data->shallow_nr = 0;
        for (;;) {
                struct object *o;
                const char *features;
                struct object_id oid_buf;
                const char *arg;
 
-               reset_timeout();
+               reset_timeout(data->timeout);
                if (packet_reader_read(reader) != PACKET_READ_NORMAL)
                        break;
 
-               if (process_shallow(reader->line, &shallows))
+               if (process_shallow(reader->line, &data->shallows))
                        continue;
-               if (process_deepen(reader->line, &depth))
+               if (process_deepen(reader->line, &data->depth))
                        continue;
-               if (process_deepen_since(reader->line, &deepen_since, &deepen_rev_list))
+               if (process_deepen_since(reader->line, &data->deepen_since, &data->deepen_rev_list))
                        continue;
-               if (process_deepen_not(reader->line, &deepen_not, &deepen_rev_list))
+               if (process_deepen_not(reader->line, &data->deepen_not, &data->deepen_rev_list))
                        continue;
 
                if (skip_prefix(reader->line, "filter ", &arg)) {
-                       if (!filter_capability_requested)
+                       if (!data->filter_capability_requested)
                                die("git upload-pack: filtering capability not negotiated");
-                       list_objects_filter_die_if_populated(filter_options);
-                       parse_list_objects_filter(filter_options, arg);
+                       list_objects_filter_die_if_populated(&data->filter_options);
+                       parse_list_objects_filter(&data->filter_options, arg);
                        continue;
                }
 
@@ -897,31 +1022,32 @@ static void receive_needs(struct packet_reader *reader,
                            "expected to get object ID, not '%s'", reader->line);
 
                if (parse_feature_request(features, "deepen-relative"))
-                       deepen_relative = 1;
+                       data->deepen_relative = 1;
                if (parse_feature_request(features, "multi_ack_detailed"))
-                       multi_ack = 2;
+                       data->multi_ack = MULTI_ACK_DETAILED;
                else if (parse_feature_request(features, "multi_ack"))
-                       multi_ack = 1;
+                       data->multi_ack = MULTI_ACK;
                if (parse_feature_request(features, "no-done"))
-                       no_done = 1;
+                       data->no_done = 1;
                if (parse_feature_request(features, "thin-pack"))
-                       use_thin_pack = 1;
+                       data->use_thin_pack = 1;
                if (parse_feature_request(features, "ofs-delta"))
-                       use_ofs_delta = 1;
+                       data->use_ofs_delta = 1;
                if (parse_feature_request(features, "side-band-64k"))
-                       use_sideband = LARGE_PACKET_MAX;
+                       data->use_sideband = LARGE_PACKET_MAX;
                else if (parse_feature_request(features, "side-band"))
-                       use_sideband = DEFAULT_PACKET_MAX;
+                       data->use_sideband = DEFAULT_PACKET_MAX;
                if (parse_feature_request(features, "no-progress"))
-                       no_progress = 1;
+                       data->no_progress = 1;
                if (parse_feature_request(features, "include-tag"))
-                       use_include_tag = 1;
-               if (allow_filter && parse_feature_request(features, "filter"))
-                       filter_capability_requested = 1;
+                       data->use_include_tag = 1;
+               if (data->allow_filter &&
+                   parse_feature_request(features, "filter"))
+                       data->filter_capability_requested = 1;
 
                o = parse_object(the_repository, &oid_buf);
                if (!o) {
-                       packet_writer_error(&writer,
+                       packet_writer_error(&data->writer,
                                            "upload-pack: not our ref %s",
                                            oid_to_hex(&oid_buf));
                        die("git upload-pack: not our ref %s",
@@ -929,10 +1055,10 @@ static void receive_needs(struct packet_reader *reader,
                }
                if (!(o->flags & WANTED)) {
                        o->flags |= WANTED;
-                       if (!((allow_unadvertised_object_request & ALLOW_ANY_SHA1) == ALLOW_ANY_SHA1
-                             || is_our_ref(o)))
+                       if (!((data->allow_uor & ALLOW_ANY_SHA1) == ALLOW_ANY_SHA1
+                             || is_our_ref(o, data->allow_uor)))
                                has_non_tip = 1;
-                       add_object_array(o, NULL, want_obj);
+                       add_object_array(o, NULL, &data->want_obj);
                }
        }
 
@@ -944,19 +1070,16 @@ static void receive_needs(struct packet_reader *reader,
         * by another process that handled the initial request.
         */
        if (has_non_tip)
-               check_non_tip(want_obj, &writer);
+               check_non_tip(data);
 
-       if (!use_sideband && daemon_mode)
-               no_progress = 1;
+       if (!data->use_sideband && data->daemon_mode)
+               data->no_progress = 1;
 
-       if (depth == 0 && !deepen_rev_list && shallows.nr == 0)
+       if (data->depth == 0 && !data->deepen_rev_list && data->shallows.nr == 0)
                return;
 
-       if (send_shallow_list(&writer, depth, deepen_rev_list, deepen_since,
-                             &deepen_not, deepen_relative, &shallows,
-                             want_obj))
+       if (send_shallow_list(data))
                packet_flush(1);
-       object_array_clear(&shallows);
 }
 
 /* return non-zero if the ref is hidden, otherwise 0 */
@@ -1000,6 +1123,7 @@ static int send_ref(const char *refname, const struct object_id *oid,
                " deepen-relative no-progress include-tag multi_ack_detailed";
        const char *refname_nons = strip_namespace(refname);
        struct object_id peeled;
+       struct upload_pack_data *data = cb_data;
 
        if (mark_our_ref(refname_nons, refname, oid))
                return 0;
@@ -1007,17 +1131,17 @@ static int send_ref(const char *refname, const struct object_id *oid,
        if (capabilities) {
                struct strbuf symref_info = STRBUF_INIT;
 
-               format_symref_info(&symref_info, cb_data);
+               format_symref_info(&symref_info, &data->symref);
                packet_write_fmt(1, "%s %s%c%s%s%s%s%s%s agent=%s\n",
                             oid_to_hex(oid), refname_nons,
                             0, capabilities,
-                            (allow_unadvertised_object_request & ALLOW_TIP_SHA1) ?
+                            (data->allow_uor & ALLOW_TIP_SHA1) ?
                                     " allow-tip-sha1-in-want" : "",
-                            (allow_unadvertised_object_request & ALLOW_REACHABLE_SHA1) ?
+                            (data->allow_uor & ALLOW_REACHABLE_SHA1) ?
                                     " allow-reachable-sha1-in-want" : "",
-                            stateless_rpc ? " no-done" : "",
+                            data->stateless_rpc ? " no-done" : "",
                             symref_info.buf,
-                            allow_filter ? " filter" : "",
+                            data->allow_filter ? " filter" : "",
                             git_user_agent_sanitized());
                strbuf_release(&symref_info);
        } else {
@@ -1045,33 +1169,35 @@ static int find_symref(const char *refname, const struct object_id *oid,
        return 0;
 }
 
-static int upload_pack_config(const char *var, const char *value, void *unused)
+static int upload_pack_config(const char *var, const char *value, void *cb_data)
 {
+       struct upload_pack_data *data = cb_data;
+
        if (!strcmp("uploadpack.allowtipsha1inwant", var)) {
                if (git_config_bool(var, value))
-                       allow_unadvertised_object_request |= ALLOW_TIP_SHA1;
+                       data->allow_uor |= ALLOW_TIP_SHA1;
                else
-                       allow_unadvertised_object_request &= ~ALLOW_TIP_SHA1;
+                       data->allow_uor &= ~ALLOW_TIP_SHA1;
        } else if (!strcmp("uploadpack.allowreachablesha1inwant", var)) {
                if (git_config_bool(var, value))
-                       allow_unadvertised_object_request |= ALLOW_REACHABLE_SHA1;
+                       data->allow_uor |= ALLOW_REACHABLE_SHA1;
                else
-                       allow_unadvertised_object_request &= ~ALLOW_REACHABLE_SHA1;
+                       data->allow_uor &= ~ALLOW_REACHABLE_SHA1;
        } else if (!strcmp("uploadpack.allowanysha1inwant", var)) {
                if (git_config_bool(var, value))
-                       allow_unadvertised_object_request |= ALLOW_ANY_SHA1;
+                       data->allow_uor |= ALLOW_ANY_SHA1;
                else
-                       allow_unadvertised_object_request &= ~ALLOW_ANY_SHA1;
+                       data->allow_uor &= ~ALLOW_ANY_SHA1;
        } else if (!strcmp("uploadpack.keepalive", var)) {
-               keepalive = git_config_int(var, value);
-               if (!keepalive)
-                       keepalive = -1;
+               data->keepalive = git_config_int(var, value);
+               if (!data->keepalive)
+                       data->keepalive = -1;
        } else if (!strcmp("uploadpack.allowfilter", var)) {
-               allow_filter = git_config_bool(var, value);
+               data->allow_filter = git_config_bool(var, value);
        } else if (!strcmp("uploadpack.allowrefinwant", var)) {
-               allow_ref_in_want = git_config_bool(var, value);
+               data->allow_ref_in_want = git_config_bool(var, value);
        } else if (!strcmp("uploadpack.allowsidebandall", var)) {
-               allow_sideband_all = git_config_bool(var, value);
+               data->allow_sideband_all = git_config_bool(var, value);
        } else if (!strcmp("core.precomposeunicode", var)) {
                precomposed_unicode = git_config_bool(var, value);
        }
@@ -1079,7 +1205,7 @@ static int upload_pack_config(const char *var, const char *value, void *unused)
        if (current_config_scope() != CONFIG_SCOPE_LOCAL &&
        current_config_scope() != CONFIG_SCOPE_WORKTREE) {
                if (!strcmp("uploadpack.packobjectshook", var))
-                       return git_config_string(&pack_objects_hook, var, value);
+                       return git_config_string(&data->pack_objects_hook, var, value);
        }
 
        return parse_hide_refs_config(var, value, "uploadpack");
@@ -1087,99 +1213,43 @@ static int upload_pack_config(const char *var, const char *value, void *unused)
 
 void upload_pack(struct upload_pack_options *options)
 {
-       struct string_list symref = STRING_LIST_INIT_DUP;
-       struct object_array want_obj = OBJECT_ARRAY_INIT;
        struct packet_reader reader;
-       struct list_objects_filter_options filter_options;
+       struct upload_pack_data data;
 
-       stateless_rpc = options->stateless_rpc;
-       timeout = options->timeout;
-       daemon_mode = options->daemon_mode;
+       upload_pack_data_init(&data);
 
-       memset(&filter_options, 0, sizeof(filter_options));
+       git_config(upload_pack_config, &data);
 
-       git_config(upload_pack_config, NULL);
+       data.stateless_rpc = options->stateless_rpc;
+       data.daemon_mode = options->daemon_mode;
+       data.timeout = options->timeout;
 
-       head_ref_namespaced(find_symref, &symref);
+       head_ref_namespaced(find_symref, &data.symref);
 
-       if (options->advertise_refs || !stateless_rpc) {
-               reset_timeout();
-               head_ref_namespaced(send_ref, &symref);
-               for_each_namespaced_ref(send_ref, &symref);
+       if (options->advertise_refs || !data.stateless_rpc) {
+               reset_timeout(data.timeout);
+               head_ref_namespaced(send_ref, &data);
+               for_each_namespaced_ref(send_ref, &data);
                advertise_shallow_grafts(1);
                packet_flush(1);
        } else {
                head_ref_namespaced(check_ref, NULL);
                for_each_namespaced_ref(check_ref, NULL);
        }
-       string_list_clear(&symref, 1);
-       if (options->advertise_refs)
-               return;
 
-       packet_reader_init(&reader, 0, NULL, 0,
-                          PACKET_READ_CHOMP_NEWLINE |
-                          PACKET_READ_DIE_ON_ERR_PACKET);
+       if (!options->advertise_refs) {
+               packet_reader_init(&reader, 0, NULL, 0,
+                                  PACKET_READ_CHOMP_NEWLINE |
+                                  PACKET_READ_DIE_ON_ERR_PACKET);
 
-       receive_needs(&reader, &want_obj, &filter_options);
-       if (want_obj.nr) {
-               struct object_array have_obj = OBJECT_ARRAY_INIT;
-               get_common_commits(&reader, &have_obj, &want_obj);
-               create_pack_file(&have_obj, &want_obj, &filter_options);
+               receive_needs(&data, &reader);
+               if (data.want_obj.nr) {
+                       get_common_commits(&data, &reader);
+                       create_pack_file(&data, NULL);
+               }
        }
 
-       list_objects_filter_release(&filter_options);
-}
-
-struct upload_pack_data {
-       struct object_array wants;
-       struct string_list wanted_refs;
-       struct oid_array haves;
-
-       struct object_array shallows;
-       struct string_list deepen_not;
-       int depth;
-       timestamp_t deepen_since;
-       int deepen_rev_list;
-       int deepen_relative;
-
-       struct list_objects_filter_options filter_options;
-
-       struct packet_writer writer;
-
-       unsigned stateless_rpc : 1;
-
-       unsigned use_thin_pack : 1;
-       unsigned use_ofs_delta : 1;
-       unsigned no_progress : 1;
-       unsigned use_include_tag : 1;
-       unsigned done : 1;
-};
-
-static void upload_pack_data_init(struct upload_pack_data *data)
-{
-       struct object_array wants = OBJECT_ARRAY_INIT;
-       struct string_list wanted_refs = STRING_LIST_INIT_DUP;
-       struct oid_array haves = OID_ARRAY_INIT;
-       struct object_array shallows = OBJECT_ARRAY_INIT;
-       struct string_list deepen_not = STRING_LIST_INIT_DUP;
-
-       memset(data, 0, sizeof(*data));
-       data->wants = wants;
-       data->wanted_refs = wanted_refs;
-       data->haves = haves;
-       data->shallows = shallows;
-       data->deepen_not = deepen_not;
-       packet_writer_init(&data->writer, 1);
-}
-
-static void upload_pack_data_clear(struct upload_pack_data *data)
-{
-       object_array_clear(&data->wants);
-       string_list_clear(&data->wanted_refs, 1);
-       oid_array_clear(&data->haves);
-       object_array_clear(&data->shallows);
-       string_list_clear(&data->deepen_not, 0);
-       list_objects_filter_release(&data->filter_options);
+       upload_pack_data_clear(&data);
 }
 
 static int parse_want(struct packet_writer *writer, const char *line,
@@ -1260,19 +1330,18 @@ static int parse_have(const char *line, struct oid_array *haves)
 }
 
 static void process_args(struct packet_reader *request,
-                        struct upload_pack_data *data,
-                        struct object_array *want_obj)
+                        struct upload_pack_data *data)
 {
        while (packet_reader_read(request) == PACKET_READ_NORMAL) {
                const char *arg = request->line;
                const char *p;
 
                /* process want */
-               if (parse_want(&data->writer, arg, want_obj))
+               if (parse_want(&data->writer, arg, &data->want_obj))
                        continue;
-               if (allow_ref_in_want &&
+               if (data->allow_ref_in_want &&
                    parse_want_ref(&data->writer, arg, &data->wanted_refs,
-                                  want_obj))
+                                  &data->want_obj))
                        continue;
                /* process have line */
                if (parse_have(arg, &data->haves))
@@ -1280,19 +1349,19 @@ static void process_args(struct packet_reader *request,
 
                /* process args like thin-pack */
                if (!strcmp(arg, "thin-pack")) {
-                       use_thin_pack = 1;
+                       data->use_thin_pack = 1;
                        continue;
                }
                if (!strcmp(arg, "ofs-delta")) {
-                       use_ofs_delta = 1;
+                       data->use_ofs_delta = 1;
                        continue;
                }
                if (!strcmp(arg, "no-progress")) {
-                       no_progress = 1;
+                       data->no_progress = 1;
                        continue;
                }
                if (!strcmp(arg, "include-tag")) {
-                       use_include_tag = 1;
+                       data->use_include_tag = 1;
                        continue;
                }
                if (!strcmp(arg, "done")) {
@@ -1316,104 +1385,87 @@ static void process_args(struct packet_reader *request,
                        continue;
                }
 
-               if (allow_filter && skip_prefix(arg, "filter ", &p)) {
+               if (data->allow_filter && skip_prefix(arg, "filter ", &p)) {
                        list_objects_filter_die_if_populated(&data->filter_options);
                        parse_list_objects_filter(&data->filter_options, p);
                        continue;
                }
 
                if ((git_env_bool("GIT_TEST_SIDEBAND_ALL", 0) ||
-                    allow_sideband_all) &&
+                    data->allow_sideband_all) &&
                    !strcmp(arg, "sideband-all")) {
                        data->writer.use_sideband = 1;
                        continue;
                }
 
+               if (skip_prefix(arg, "packfile-uris ", &p)) {
+                       string_list_split(&data->uri_protocols, p, ',', -1);
+                       continue;
+               }
+
                /* ignore unknown lines maybe? */
                die("unexpected line: '%s'", arg);
        }
 
+       if (data->uri_protocols.nr && !data->writer.use_sideband)
+               string_list_clear(&data->uri_protocols, 0);
+
        if (request->status != PACKET_READ_FLUSH)
                die(_("expected flush after fetch arguments"));
 }
 
-static int process_haves(struct oid_array *haves, struct oid_array *common,
-                        struct object_array *have_obj)
+static int process_haves(struct upload_pack_data *data, struct oid_array *common)
 {
        int i;
 
        /* Process haves */
-       for (i = 0; i < haves->nr; i++) {
-               const struct object_id *oid = &haves->oid[i];
-               struct object *o;
-               int we_knew_they_have = 0;
+       for (i = 0; i < data->haves.nr; i++) {
+               const struct object_id *oid = &data->haves.oid[i];
 
                if (!has_object_file(oid))
                        continue;
 
                oid_array_append(common, oid);
 
-               o = parse_object(the_repository, oid);
-               if (!o)
-                       die("oops (%s)", oid_to_hex(oid));
-               if (o->type == OBJ_COMMIT) {
-                       struct commit_list *parents;
-                       struct commit *commit = (struct commit *)o;
-                       if (o->flags & THEY_HAVE)
-                               we_knew_they_have = 1;
-                       else
-                               o->flags |= THEY_HAVE;
-                       if (!oldest_have || (commit->date < oldest_have))
-                               oldest_have = commit->date;
-                       for (parents = commit->parents;
-                            parents;
-                            parents = parents->next)
-                               parents->item->object.flags |= THEY_HAVE;
-               }
-               if (!we_knew_they_have)
-                       add_object_array(o, NULL, have_obj);
+               do_got_oid(data, oid);
        }
 
        return 0;
 }
 
-static int send_acks(struct packet_writer *writer, struct oid_array *acks,
-                    const struct object_array *have_obj,
-                    struct object_array *want_obj)
+static int send_acks(struct upload_pack_data *data, struct oid_array *acks)
 {
        int i;
 
-       packet_writer_write(writer, "acknowledgments\n");
+       packet_writer_write(&data->writer, "acknowledgments\n");
 
        /* Send Acks */
        if (!acks->nr)
-               packet_writer_write(writer, "NAK\n");
+               packet_writer_write(&data->writer, "NAK\n");
 
        for (i = 0; i < acks->nr; i++) {
-               packet_writer_write(writer, "ACK %s\n",
+               packet_writer_write(&data->writer, "ACK %s\n",
                                    oid_to_hex(&acks->oid[i]));
        }
 
-       if (ok_to_give_up(have_obj, want_obj)) {
+       if (ok_to_give_up(data)) {
                /* Send Ready */
-               packet_writer_write(writer, "ready\n");
+               packet_writer_write(&data->writer, "ready\n");
                return 1;
        }
 
        return 0;
 }
 
-static int process_haves_and_send_acks(struct upload_pack_data *data,
-                                      struct object_array *have_obj,
-                                      struct object_array *want_obj)
+static int process_haves_and_send_acks(struct upload_pack_data *data)
 {
        struct oid_array common = OID_ARRAY_INIT;
        int ret = 0;
 
-       process_haves(&data->haves, &common, have_obj);
+       process_haves(data, &common);
        if (data->done) {
                ret = 1;
-       } else if (send_acks(&data->writer, &common, have_obj, want_obj)) {
+       } else if (send_acks(data, &common)) {
                packet_writer_delim(&data->writer);
                ret = 1;
        } else {
@@ -1445,8 +1497,7 @@ static void send_wanted_ref_info(struct upload_pack_data *data)
        packet_writer_delim(&data->writer);
 }
 
-static void send_shallow_info(struct upload_pack_data *data,
-                             struct object_array *want_obj)
+static void send_shallow_info(struct upload_pack_data *data)
 {
        /* No shallow info needs to be sent */
        if (!data->depth && !data->deepen_rev_list && !data->shallows.nr &&
@@ -1455,14 +1506,9 @@ static void send_shallow_info(struct upload_pack_data *data,
 
        packet_writer_write(&data->writer, "shallow-info\n");
 
-       if (!send_shallow_list(&data->writer, data->depth,
-                              data->deepen_rev_list,
-                              data->deepen_since, &data->deepen_not,
-                              data->deepen_relative,
-                              &data->shallows, want_obj) &&
+       if (!send_shallow_list(data) &&
            is_repository_shallow(the_repository))
-               deepen(&data->writer, INFINITE_DEPTH, data->deepen_relative,
-                      &data->shallows, want_obj);
+               deepen(data, INFINITE_DEPTH);
 
        packet_delim(1);
 }
@@ -1479,22 +1525,20 @@ int upload_pack_v2(struct repository *r, struct argv_array *keys,
 {
        enum fetch_state state = FETCH_PROCESS_ARGS;
        struct upload_pack_data data;
-       struct object_array have_obj = OBJECT_ARRAY_INIT;
-       struct object_array want_obj = OBJECT_ARRAY_INIT;
 
        clear_object_flags(ALL_FLAGS);
 
-       git_config(upload_pack_config, NULL);
-
        upload_pack_data_init(&data);
-       use_sideband = LARGE_PACKET_MAX;
+       data.use_sideband = LARGE_PACKET_MAX;
+
+       git_config(upload_pack_config, &data);
 
        while (state != FETCH_DONE) {
                switch (state) {
                case FETCH_PROCESS_ARGS:
-                       process_args(request, &data, &want_obj);
+                       process_args(request, &data);
 
-                       if (!want_obj.nr) {
+                       if (!data.want_obj.nr) {
                                /*
                                 * Request didn't contain any 'want' lines,
                                 * guess they didn't want anything.
@@ -1514,18 +1558,21 @@ int upload_pack_v2(struct repository *r, struct argv_array *keys,
                        }
                        break;
                case FETCH_SEND_ACKS:
-                       if (process_haves_and_send_acks(&data, &have_obj,
-                                                       &want_obj))
+                       if (process_haves_and_send_acks(&data))
                                state = FETCH_SEND_PACK;
                        else
                                state = FETCH_DONE;
                        break;
                case FETCH_SEND_PACK:
                        send_wanted_ref_info(&data);
-                       send_shallow_info(&data, &want_obj);
+                       send_shallow_info(&data);
 
-                       packet_writer_write(&data.writer, "packfile\n");
-                       create_pack_file(&have_obj, &want_obj, &data.filter_options);
+                       if (data.uri_protocols.nr) {
+                               create_pack_file(&data, &data.uri_protocols);
+                       } else {
+                               packet_writer_write(&data.writer, "packfile\n");
+                               create_pack_file(&data, NULL);
+                       }
                        state = FETCH_DONE;
                        break;
                case FETCH_DONE:
@@ -1534,8 +1581,6 @@ int upload_pack_v2(struct repository *r, struct argv_array *keys,
        }
 
        upload_pack_data_clear(&data);
-       object_array_clear(&have_obj);
-       object_array_clear(&want_obj);
        return 0;
 }
 
@@ -1546,6 +1591,7 @@ int upload_pack_advertise(struct repository *r,
                int allow_filter_value;
                int allow_ref_in_want;
                int allow_sideband_all_value;
+               char *str = NULL;
 
                strbuf_addstr(value, "shallow");
 
@@ -1567,6 +1613,14 @@ int upload_pack_advertise(struct repository *r,
                                           &allow_sideband_all_value) &&
                     allow_sideband_all_value))
                        strbuf_addstr(value, " sideband-all");
+
+               if (!repo_config_get_string(the_repository,
+                                           "uploadpack.blobpackfileuri",
+                                           &str) &&
+                   str) {
+                       strbuf_addstr(value, " packfile-uris");
+                       free(str);
+               }
        }
 
        return 1;