]> git.ipfire.org Git - thirdparty/git.git/commit
CodingGuidelines: drop arithmetic expansion advice to use "$x"
authorJeff King <peff@peff.net>
Mon, 4 May 2020 16:07:09 +0000 (12:07 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 4 May 2020 19:36:07 +0000 (12:36 -0700)
commit32b5fe7f0e2cb798954b3e01b990bc140706e191
tree06c0ebef87bc79382d80234f072f9e58814f2c43
parentaf6b65d45ef179ed52087e80cb089f6b2349f4ec
CodingGuidelines: drop arithmetic expansion advice to use "$x"

The advice to use "$x" rather than "x" in arithmetric expansion was
working around a dash bug fixed in 0.5.4. Even Debian oldstable has
0.5.8 these days. And in the meantime, we've added almost two dozen
instances of the "x" form which you can find with:

  git grep '$(([a-z]'

and nobody seems to have complained. Let's declare this workaround
obsolete and simplify our style guide.

Helped-by: Danh Doan <congdanhqx@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/CodingGuidelines