remote-mediawiki tests: use inline PerlIO for readability

Replace the use of the "open" pragma with a three-arg open in the
places that actually care about UTF-8, while leaving those that
don't (the config parsing).

Unlike the previous "encoding" pragma change this isn't needed for
compatibility with anything. I just think it's easier to read code
that has localized effects than code that changes global settings.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/contrib/mw-to-git/t/test-gitmw.pl b/contrib/mw-to-git/t/test-gitmw.pl
index 71e5b06235dfd1455878bf5168c8eab1c0799ad4..c5d687f078a8f001d283bff5ffebd7ff1ee0f022 100755 (executable)
--- a/contrib/mw-to-git/t/test-gitmw.pl
+++ b/contrib/mw-to-git/t/test-gitmw.pl
@@ -25,7 +25,6 @@
 use MediaWiki::API;
 use Getopt::Long;
 use DateTime::Format::ISO8601;
-use open ':encoding(utf8)';
 use constant SLASH_REPLACEMENT => "%2F";
 
 #Parsing of the config file
@@ -86,7 +85,7 @@ sub wiki_getpage {
        # Replace spaces by underscore in the page name
        $pagename =~ s/ /_/g;
        $pagename =~ s/\//%2F/g;
-       open(my $file, ">$destdir/$pagename.mw");
+       open(my $file, ">:encoding(UTF-8)", "$destdir/$pagename.mw");
        print $file "$content";
        close ($file);
 
@@ -171,7 +170,7 @@ sub wiki_getallpagename {
                                cmlimit => 500 },
                )
                || die $mw->{error}->{code}.": ".$mw->{error}->{details};
-               open(my $file, ">all.txt");
+               open(my $file, ">:encoding(UTF-8)", "all.txt");
                foreach my $page (@{$mw_pages}) {
                        print $file "$page->{title}\n";
                }
@@ -184,7 +183,7 @@ sub wiki_getallpagename {
                                aplimit => 500,
                        })
                || die $mw->{error}->{code}.": ".$mw->{error}->{details};
-               open(my $file, ">all.txt");
+               open(my $file, ">:encoding(UTF-8)", "all.txt");
                foreach my $page (@{$mw_pages}) {
                        print $file "$page->{title}\n";
                }