reftable: fix resource leak blocksource.c

This would be triggered in the unlikely event of fstat() failing on an
opened file.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/reftable/blocksource.c b/reftable/blocksource.c
index 0044eecd9aa39afa476dcfb8e6eeaaa89fb08b86..2605371c28d86f638dcd5079466e038e3eb7a38a 100644 (file)
--- a/reftable/blocksource.c
+++ b/reftable/blocksource.c
@@ -134,8 +134,10 @@ int reftable_block_source_from_file(struct reftable_block_source *bs,
        }
 
        err = fstat(fd, &st);
-       if (err < 0)
-               return -1;
+       if (err < 0) {
+               close(fd);
+               return REFTABLE_IO_ERROR;
+       }
 
        p = reftable_calloc(sizeof(struct file_block_source));
        p->size = st.st_size;