replay: add an important FIXME comment about gpg signing

We want to be able to handle signed commits in some way in the future,
but we are not ready to do it now. So for the time being let's just add
a FIXME comment to remind us about it.

These are different ways we could handle them:

  - in case of a cli user and if there was an interactive mode, we could
    perhaps ask if the user wants to sign again
  - we could add an option to just fail if there are signed commits

Co-authored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/replay.c b/builtin/replay.c
index 2f664218be0f899b9a4467af8433029f27758251..384bb4ddd32282aa8c580fd79c75fb49c964b4bb 100644 (file)
--- a/builtin/replay.c
+++ b/builtin/replay.c
@@ -62,7 +62,7 @@ static struct commit *create_commit(struct tree *tree,
        struct object *obj;
        struct commit_list *parents = NULL;
        char *author;
-       char *sign_commit = NULL;
+       char *sign_commit = NULL; /* FIXME: cli users might want to sign again */
        struct commit_extra_header *extra;
        struct strbuf msg = STRBUF_INIT;
        const char *out_enc = get_commit_output_encoding();