]> git.ipfire.org Git - thirdparty/git.git/commitdiff
git-submodule.sh: properly initialize shell variables
authorGerrit Pape <pape@smarden.org>
Mon, 26 Apr 2010 09:50:39 +0000 (11:50 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sat, 1 May 2010 18:11:52 +0000 (11:11 -0700)
git-submodule inherits variables from the environment it is started in,
expects the internal variables init= and recursive= to have an empty
value, but doesn't initialize them appropriately.  Thanks to the
selftests, this can be reproduced through

 init=1 make test
 recursive=1 make test

With this commit the variables are initialized, and the selftests
succeed even if these variables have some values in the environment.

The bug was discovered through the Debian autobuilders
 http://bugs.debian.org/569594

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-submodule.sh

index e2082fd1492fe34e69c59f0a46cbaf7ddd2e2a8e..d3c583d0113e133b8fc75b533ff3f88d2a9c7efe 100755 (executable)
@@ -21,6 +21,8 @@ command=
 branch=
 reference=
 cached=
+recursive=
+init=
 files=
 nofetch=
 update=