]> git.ipfire.org Git - thirdparty/git.git/commitdiff
bisect: stop referring to sha1_array
authorJeff King <peff@peff.net>
Mon, 30 Mar 2020 14:04:06 +0000 (10:04 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 30 Mar 2020 17:59:08 +0000 (10:59 -0700)
Our join_sha1_array_hex() function long ago switched to using an
oid_array; let's change the name to match.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
bisect.c

index 64b579b6ea98497135ec2e945b1a0a1420fb7ba1..d5e830410f5949d1e8c24e990cf0a70b980656ea 100644 (file)
--- a/bisect.c
+++ b/bisect.c
@@ -473,7 +473,7 @@ static void read_bisect_paths(struct argv_array *array)
        fclose(fp);
 }
 
-static char *join_sha1_array_hex(struct oid_array *array, char delim)
+static char *join_oid_array_hex(struct oid_array *array, char delim)
 {
        struct strbuf joined_hexs = STRBUF_INIT;
        int i;
@@ -765,7 +765,7 @@ static enum bisect_error handle_bad_merge_base(void)
 {
        if (is_expected_rev(current_bad_oid)) {
                char *bad_hex = oid_to_hex(current_bad_oid);
-               char *good_hex = join_sha1_array_hex(&good_revs, ' ');
+               char *good_hex = join_oid_array_hex(&good_revs, ' ');
                if (!strcmp(term_bad, "bad") && !strcmp(term_good, "good")) {
                        fprintf(stderr, _("The merge base %s is bad.\n"
                                "This means the bug has been fixed "
@@ -796,7 +796,7 @@ static void handle_skipped_merge_base(const struct object_id *mb)
 {
        char *mb_hex = oid_to_hex(mb);
        char *bad_hex = oid_to_hex(current_bad_oid);
-       char *good_hex = join_sha1_array_hex(&good_revs, ' ');
+       char *good_hex = join_oid_array_hex(&good_revs, ' ');
 
        warning(_("the merge base between %s and [%s] "
                "must be skipped.\n"