]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t4216: avoid unnecessary subshell in test_bloom_filters_not_used
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Wed, 20 May 2020 03:44:42 +0000 (20:44 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 20 May 2020 15:56:12 +0000 (08:56 -0700)
Seems to trigger a bug in at least OpenBSD's 6.7 sh where it is
interpreted as a history lookup and therefore fails 125-126, 128,
130.

Remove the subshell and get a space between ! and grep, so tests
pass successfully.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t4216-log-bloom.sh

index c7011f33e2c1c0d9ad80a6e2e2185f901dbe862d..f19ceec07b3334353cfd03504ceabf34327bebe0 100755 (executable)
@@ -70,7 +70,7 @@ test_bloom_filters_used () {
 test_bloom_filters_not_used () {
        log_args=$1
        setup "$log_args" &&
-       !(grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf") &&
+       ! grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf" &&
        test_cmp log_wo_bloom log_w_bloom
 }