mingw: sh arguments need quoting in more circumstances

Previously, we failed to quote characters such as '*', '(' and the
likes. Let's fix this.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

diff --git a/compat/mingw.c b/compat/mingw.c
index 7635ad5152e4bb5ac4afb726dee6aca80fa86b50..2c55c3426cb7d396fb9edd921805fcc55ac39b2e 100644 (file)
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1120,13 +1120,14 @@ static const char *quote_arg_msys2(const char *arg)
 
        for (p = arg; *p; p++) {
                int ws = isspace(*p);
-               if (!ws && *p != '\\' && *p != '"' && *p != '{')
+               if (!ws && *p != '\\' && *p != '"' && *p != '{' && *p != '\'' &&
+                   *p != '?' && *p != '*' && *p != '~')
                        continue;
                if (!buf.len)
                        strbuf_addch(&buf, '"');
                if (p != p2)
                        strbuf_add(&buf, p2, p - p2);
-               if (!ws && *p != '{')
+               if (*p == '\\' || *p == '"')
                        strbuf_addch(&buf, '\\');
                p2 = p;
        }