]> git.ipfire.org Git - thirdparty/git.git/commitdiff
credential: update description for credential_from_url_gently
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Tue, 5 May 2020 01:39:05 +0000 (18:39 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 5 May 2020 05:56:32 +0000 (22:56 -0700)
c44088ecc4 (credential: treat URL without scheme as invalid, 2020-04-18)
changes the implementation for this function to return -1 if protocol is
missing.

Update blurb to match implementation.

Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
credential.h

index d99ec42b2a8c96a298e75b809bf86e47d6d38211..f51703d9ce3901a645509eee06d0e039ae77e5b4 100644 (file)
@@ -177,8 +177,8 @@ void credential_write(const struct credential *, FILE *);
  * Parse a url into a credential struct, replacing any existing contents.
  *
  * If the url can't be parsed (e.g., a missing "proto://" component), the
- * resulting credential will be empty but we'll still return success from the
- * "gently" form.
+ * resulting credential will be empty and the function will return an
+ * error (even in the "gently" form).
  *
  * If we encounter a component which cannot be represented as a credential
  * value (e.g., because it contains a newline), the "gently" form will return