merge-recursive: comment and reorder the merge_options fields

The merge_options struct had lots of fields, making it a little
imposing, but the options naturally fall into multiple different groups.
Grouping similar options and adding a comment or two makes it easier to
read, easier for new folks to figure out which options are related, and
thus easier for them to find the options they need.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/merge-recursive.c b/merge-recursive.c
index 0f0b952c042837474ae3daf3ef963fbbfa78453b..43dec3307e8a2512895581eb1ece4567d47f8052 100644 (file)
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -3754,21 +3754,27 @@ void init_merge_options(struct merge_options *opt,
 {
        const char *merge_verbosity;
        memset(opt, 0, sizeof(struct merge_options));
+
        opt->repo = repo;
+
+       opt->detect_renames = -1;
+       opt->detect_directory_renames = MERGE_DIRECTORY_RENAMES_CONFLICT;
+       opt->rename_limit = -1;
+
        opt->verbosity = 2;
        opt->buffer_output = 1;
-       opt->rename_limit = -1;
+       strbuf_init(&opt->obuf, 0);
+
        opt->renormalize = 0;
-       opt->detect_renames = -1;
-       opt->detect_directory_renames = MERGE_DIRECTORY_RENAMES_CONFLICT;
+
+       string_list_init(&opt->df_conflict_file_set, 1);
+
        merge_recursive_config(opt);
        merge_verbosity = getenv("GIT_MERGE_VERBOSITY");
        if (merge_verbosity)
                opt->verbosity = strtol(merge_verbosity, NULL, 10);
        if (opt->verbosity >= 5)
                opt->buffer_output = 0;
-       strbuf_init(&opt->obuf, 0);
-       string_list_init(&opt->df_conflict_file_set, 1);
 }
 
 int parse_merge_opt(struct merge_options *opt, const char *s)

diff --git a/merge-recursive.h b/merge-recursive.h
index f4bdfbc897a3fd3ed3b7ece0444bc76e2a2cf674..9e040608fec98e09ac8fa01abc58ed724125735a 100644 (file)
--- a/merge-recursive.h
+++ b/merge-recursive.h
@@ -9,36 +9,48 @@ struct commit;
 struct repository;
 
 struct merge_options {
+       struct repository *repo;
+
+       /* ref names used in console messages and conflict markers */
        const char *ancestor;
        const char *branch1;
        const char *branch2;
-       enum {
-               MERGE_RECURSIVE_NORMAL = 0,
-               MERGE_RECURSIVE_OURS,
-               MERGE_RECURSIVE_THEIRS
-       } recursive_variant;
-       const char *subtree_shift;
-       unsigned buffer_output; /* 1: output at end, 2: keep buffered */
-       unsigned renormalize : 1;
-       long xdl_opts;
-       int verbosity;
+
+       /* rename related options */
+       int detect_renames;
        enum {
                MERGE_DIRECTORY_RENAMES_NONE = 0,
                MERGE_DIRECTORY_RENAMES_CONFLICT = 1,
                MERGE_DIRECTORY_RENAMES_TRUE = 2
        } detect_directory_renames;
-       int detect_renames;
        int rename_limit;
        int rename_score;
-       int needed_rename_limit;
        int show_rename_progress;
+
+       /* xdiff-related options (patience, ignore whitespace, ours/theirs) */
+       long xdl_opts;
+       enum {
+               MERGE_RECURSIVE_NORMAL = 0,
+               MERGE_RECURSIVE_OURS,
+               MERGE_RECURSIVE_THEIRS
+       } recursive_variant;
+
+       /* console output related options */
+       int verbosity;
+       unsigned buffer_output; /* 1: output at end, 2: keep buffered */
+       struct strbuf obuf;     /* output buffer */
+
+       /* miscellaneous control options */
+       const char *subtree_shift;
+       unsigned renormalize : 1;
+
+       /* internal fields used by the implementation (do NOT set these) */
        int call_depth;
-       struct strbuf obuf;
+       int needed_rename_limit;
        struct hashmap current_file_dir_set;
        struct string_list df_conflict_file_set;
        struct unpack_trees_options unpack_opts;
        struct index_state orig_index;
-       struct repository *repo;
 };
 
 void init_merge_options(struct merge_options *opt, struct repository *repo);